|
42370
|
1556
|
3
|
2026-05-14T11:30:38.094008+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758238094_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.057063047,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.08060654,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.09217877,"width":0.101230055,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"bounds":{"left":0.0028257978,"top":0.11332801,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"bounds":{"left":0.015957447,"top":0.12490024,"width":0.076961435,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"bounds":{"left":0.0028257978,"top":0.14604948,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"bounds":{"left":0.015957447,"top":0.15762171,"width":0.08543883,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"bounds":{"left":0.0028257978,"top":0.17877094,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"bounds":{"left":0.015957447,"top":0.19034317,"width":0.04288564,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"bounds":{"left":0.0028257978,"top":0.21149242,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"bounds":{"left":0.015957447,"top":0.22306465,"width":0.12732713,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"bounds":{"left":0.0028257978,"top":0.2442139,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"bounds":{"left":0.015957447,"top":0.25578612,"width":0.033410903,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.27693537,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.28850758,"width":0.18068483,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"bounds":{"left":0.06732048,"top":0.28411812,"width":0.007978723,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"bounds":{"left":0.0028257978,"top":0.30965683,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"bounds":{"left":0.015957447,"top":0.32122904,"width":0.171875,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.3423783,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.35395053,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"bounds":{"left":0.0,"top":0.37509975,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"bounds":{"left":0.013297873,"top":0.386672,"width":0.029920213,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.41300878,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.4365523,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.4481245,"width":0.06632314,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.46927375,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.48084596,"width":0.064494684,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.5019952,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.51356745,"width":0.15658244,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.53990424,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.5634477,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.57501996,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.5961692,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6077414,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.62889063,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6404629,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.66161215,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.67318434,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.6995211,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.72306466,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.73463684,"width":0.091755316,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.7557861,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.76735836,"width":0.11619016,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.7885076,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.8000798,"width":0.18932846,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.82122904,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.8328013,"width":0.12898937,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.8539505,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.86552274,"width":0.079288565,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"bounds":{"left":0.0,"top":0.88667196,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"bounds":{"left":0.013297873,"top":0.8982442,"width":0.032247342,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0,"top":0.9193935,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.013297873,"top":0.93096566,"width":0.013131649,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.95211494,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.9636871,"width":0.041722074,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.9848364,"width":0.07962101,"height":0.0151636},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.99640864,"width":0.041722074,"height":0.0035913587},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":1.0,"width":0.07962101,"height":-0.01755786},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":1.0,"width":0.041722074,"height":-0.029130101},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.007978723,"height":-0.05546689},"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.07679521,"height":-0.07901037},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":1.0,"width":0.21575798,"height":-0.09058261},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"bounds":{"left":0.0028257978,"top":0.92897046,"width":0.07413564,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"bounds":{"left":0.0028257978,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"bounds":{"left":0.013796543,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"bounds":{"left":0.024933511,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"bounds":{"left":0.036070477,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"bounds":{"left":0.04720745,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"bounds":{"left":0.1846742,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"bounds":{"left":0.1966423,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"bounds":{"left":0.1939827,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"bounds":{"left":0.08361037,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"bounds":{"left":0.16605718,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"bounds":{"left":0.17935506,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"bounds":{"left":0.079288565,"top":0.14764565,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"bounds":{"left":0.079288565,"top":0.15003991,"width":0.1200133,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"bounds":{"left":0.1022274,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"bounds":{"left":0.116855055,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"bounds":{"left":0.13680187,"top":0.19313647,"width":0.051861703,"height":0.09577015},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"bounds":{"left":0.079288565,"top":0.19393456,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"bounds":{"left":0.13680187,"top":0.19473264,"width":0.051861703,"height":0.80526733},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"bounds":{"left":0.13680187,"top":0.30965683,"width":0.05119681,"height":0.188747},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"bounds":{"left":0.18866356,"top":0.19313647,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"bounds":{"left":0.1939827,"top":0.32083002,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"bounds":{"left":0.08460771,"top":0.3519553,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"bounds":{"left":0.08460771,"top":0.35395053,"width":0.04105718,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"bounds":{"left":0.08759973,"top":0.35514766,"width":0.1100399,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"bounds":{"left":0.1427859,"top":0.41739824,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"bounds":{"left":0.1627327,"top":0.41739824,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"bounds":{"left":0.08759973,"top":0.45810056,"width":0.11702128,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"bounds":{"left":0.08759973,"top":0.45969674,"width":0.08676862,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"bounds":{"left":0.08759973,"top":0.5051876,"width":0.11702128,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.020944148,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"bounds":{"left":0.12450133,"top":0.5981644,"width":0.075465426,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.10305851,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"bounds":{"left":0.10023271,"top":0.6189146,"width":0.08261303,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"bounds":{"left":0.12732713,"top":0.63846767,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.028590426,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.1043883,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"bounds":{"left":0.08759973,"top":0.7709497,"width":0.11702128,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"bounds":{"left":0.08759973,"top":0.7725459,"width":0.05668218,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"bounds":{"left":0.08759973,"top":0.79888266,"width":0.115359046,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"bounds":{"left":0.10023271,"top":0.89066243,"width":0.04870346,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"bounds":{"left":0.11319814,"top":0.9213887,"width":0.025099734,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"bounds":{"left":0.14029256,"top":0.9201915,"width":0.064328454,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"bounds":{"left":0.11319814,"top":0.94213885,"width":0.041888297,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15708111,"top":0.94094175,"width":0.0026595744,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16173537,"top":0.94213885,"width":0.013962766,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.17769282,"top":0.94094175,"width":0.013297873,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.11319814,"top":0.9628891,"width":0.022273935,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.13746676,"top":0.9616919,"width":0.0014960107,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"bounds":{"left":0.11319814,"top":0.99241817,"width":0.022273935,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.13746676,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"bounds":{"left":0.14394946,"top":0.99241817,"width":0.025099734,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.17104389,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"bounds":{"left":0.1775266,"top":0.99241817,"width":0.019448139,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.111203454,"top":0.9912211,"width":0.09042553,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.13547207,"top":1.0,"width":0.013962766,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15142952,"top":1.0,"width":0.0026595744,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.15608378,"top":1.0,"width":0.02244016,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.18051861,"top":1.0,"width":0.013131649,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.025099734,"height":-0.03391862},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"bounds":{"left":0.14029256,"top":1.0,"width":0.013630319,"height":-0.03272152},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.041888297,"height":-0.063447714},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.15708111,"top":1.0,"width":0.024933511,"height":-0.062250614},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.0390625,"height":-0.08419788},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"bounds":{"left":0.15425532,"top":1.0,"width":0.011968086,"height":-0.08300078},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"bounds":{"left":0.09291888,"top":0.8216281,"width":0.10638298,"height":0.01915403},"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"bounds":{"left":0.099567816,"top":0.82202715,"width":0.069980055,"height":0.018355945},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"bounds":{"left":0.091921546,"top":0.8216281,"width":0.0066489363,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"bounds":{"left":0.08892952,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"bounds":{"left":0.10488697,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"bounds":{"left":0.16007313,"top":0.85514766,"width":0.027925532,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"bounds":{"left":0.1653923,"top":0.8639266,"width":0.00930851,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Microphone","depth":19,"bounds":{"left":0.18999335,"top":0.85514766,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Send message","depth":19,"bounds":{"left":0.19630983,"top":0.85434955,"width":0.013962766,"height":0.033519555},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":false,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.","depth":17,"bounds":{"left":0.08510638,"top":0.90901834,"width":0.11951463,"height":0.025139665},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Your privacy & Gemini Opens in a new window","depth":17,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your privacy & Gemini","depth":18,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Opens in a new window","depth":19,"bounds":{"left":0.079288565,"top":0.92098963,"width":0.043218084,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Summarize page","depth":7,"bounds":{"left":0.08494016,"top":0.95730245,"width":0.053523935,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Summarize page","depth":9,"bounds":{"left":0.09059176,"top":0.96249,"width":0.042220745,"height":0.015163607},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Skip to content","depth":6,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Skip to content","depth":7,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open menu","depth":10,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"Homepage (g then d)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"jiminny","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"jiminny","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"app","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"app","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Search or jump to…","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Type","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to search","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Chat with Copilot","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Open Copilot…","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXMenuButton","text":"Create new...","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXLink","text":"All issues(g then i)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All pull requests","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All repositories","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"You have unread notifications(g then n)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open user navigation menu","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Repository navigation","depth":9,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Repository navigation","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Code","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Pull requests (29)","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pull requests","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"29","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Agents","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Agents","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Actions","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Actions","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Wiki","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Wiki","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Security and quality","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Security and quality","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Insights","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Insights","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Settings","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Settings","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Important update","depth":10,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Important update","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Review this update","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Review this update","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and manage your preferences in your","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"GitHub account settings","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"GitHub account settings","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Dismiss banner","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false}]...
|
-3110969605780987499
|
8923868658492259784
|
visual_change
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner...
|
NULL
|
NULL
|
NULL
|
NULL
|
|
42371
|
1555
|
1
|
2026-05-14T11:30:39.724795+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758239724_m1.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_1
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false}]...
|
-5545981031477750577
|
8923867554677276104
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools...
|
42367
|
NULL
|
NULL
|
NULL
|
|
42372
|
1556
|
4
|
2026-05-14T11:30:39.727306+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758239727_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.057063047,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.08060654,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.09217877,"width":0.101230055,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"bounds":{"left":0.0028257978,"top":0.11332801,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"bounds":{"left":0.015957447,"top":0.12490024,"width":0.076961435,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"bounds":{"left":0.0028257978,"top":0.14604948,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"bounds":{"left":0.015957447,"top":0.15762171,"width":0.08543883,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"bounds":{"left":0.0028257978,"top":0.17877094,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"bounds":{"left":0.015957447,"top":0.19034317,"width":0.04288564,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"bounds":{"left":0.0028257978,"top":0.21149242,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"bounds":{"left":0.015957447,"top":0.22306465,"width":0.12732713,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"bounds":{"left":0.0028257978,"top":0.2442139,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"bounds":{"left":0.015957447,"top":0.25578612,"width":0.033410903,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.27693537,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.28850758,"width":0.18068483,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"bounds":{"left":0.06732048,"top":0.28411812,"width":0.007978723,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"bounds":{"left":0.0028257978,"top":0.30965683,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"bounds":{"left":0.015957447,"top":0.32122904,"width":0.171875,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.3423783,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.35395053,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"bounds":{"left":0.0,"top":0.37509975,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"bounds":{"left":0.013297873,"top":0.386672,"width":0.029920213,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.41300878,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.4365523,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.4481245,"width":0.06632314,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.46927375,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.48084596,"width":0.064494684,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.5019952,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.51356745,"width":0.15658244,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.53990424,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.5634477,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.57501996,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.5961692,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6077414,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.62889063,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6404629,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.66161215,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.67318434,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.6995211,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.72306466,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.73463684,"width":0.091755316,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.7557861,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.76735836,"width":0.11619016,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.7885076,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.8000798,"width":0.18932846,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.82122904,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.8328013,"width":0.12898937,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.8539505,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.86552274,"width":0.079288565,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"bounds":{"left":0.0,"top":0.88667196,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"bounds":{"left":0.013297873,"top":0.8982442,"width":0.032247342,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0,"top":0.9193935,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.013297873,"top":0.93096566,"width":0.013131649,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.95211494,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.9636871,"width":0.041722074,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.9848364,"width":0.07962101,"height":0.0151636},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.99640864,"width":0.041722074,"height":0.0035913587},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":1.0,"width":0.07962101,"height":-0.01755786},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":1.0,"width":0.041722074,"height":-0.029130101},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.007978723,"height":-0.05546689},"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.07679521,"height":-0.07901037},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":1.0,"width":0.21575798,"height":-0.09058261},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"bounds":{"left":0.0028257978,"top":0.92897046,"width":0.07413564,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"bounds":{"left":0.0028257978,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"bounds":{"left":0.013796543,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"bounds":{"left":0.024933511,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"bounds":{"left":0.036070477,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"bounds":{"left":0.04720745,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"bounds":{"left":0.1846742,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"bounds":{"left":0.1966423,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"bounds":{"left":0.1939827,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"bounds":{"left":0.08361037,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"bounds":{"left":0.16605718,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"bounds":{"left":0.17935506,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"bounds":{"left":0.079288565,"top":0.14764565,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"bounds":{"left":0.079288565,"top":0.15003991,"width":0.1200133,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"bounds":{"left":0.1022274,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"bounds":{"left":0.116855055,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"bounds":{"left":0.13680187,"top":0.19313647,"width":0.051861703,"height":0.09577015},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"bounds":{"left":0.079288565,"top":0.19393456,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"bounds":{"left":0.13680187,"top":0.19473264,"width":0.051861703,"height":0.80526733},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"bounds":{"left":0.13680187,"top":0.30965683,"width":0.05119681,"height":0.188747},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"bounds":{"left":0.18866356,"top":0.19313647,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"bounds":{"left":0.1939827,"top":0.32083002,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"bounds":{"left":0.08460771,"top":0.3519553,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"bounds":{"left":0.08460771,"top":0.35395053,"width":0.04105718,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"bounds":{"left":0.08759973,"top":0.35514766,"width":0.1100399,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"bounds":{"left":0.1427859,"top":0.41739824,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"bounds":{"left":0.1627327,"top":0.41739824,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"bounds":{"left":0.08759973,"top":0.45810056,"width":0.11702128,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"bounds":{"left":0.08759973,"top":0.45969674,"width":0.08676862,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"bounds":{"left":0.08759973,"top":0.5051876,"width":0.11702128,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.020944148,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"bounds":{"left":0.12450133,"top":0.5981644,"width":0.075465426,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.10305851,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"bounds":{"left":0.10023271,"top":0.6189146,"width":0.08261303,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"bounds":{"left":0.12732713,"top":0.63846767,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.028590426,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.1043883,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"bounds":{"left":0.08759973,"top":0.7709497,"width":0.11702128,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"bounds":{"left":0.08759973,"top":0.7725459,"width":0.05668218,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"bounds":{"left":0.08759973,"top":0.79888266,"width":0.115359046,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"bounds":{"left":0.10023271,"top":0.89066243,"width":0.04870346,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"bounds":{"left":0.11319814,"top":0.9213887,"width":0.025099734,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"bounds":{"left":0.14029256,"top":0.9201915,"width":0.064328454,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"bounds":{"left":0.11319814,"top":0.94213885,"width":0.041888297,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15708111,"top":0.94094175,"width":0.0026595744,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16173537,"top":0.94213885,"width":0.013962766,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.17769282,"top":0.94094175,"width":0.013297873,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.11319814,"top":0.9628891,"width":0.022273935,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.13746676,"top":0.9616919,"width":0.0014960107,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"bounds":{"left":0.11319814,"top":0.99241817,"width":0.022273935,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.13746676,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"bounds":{"left":0.14394946,"top":0.99241817,"width":0.025099734,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.17104389,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"bounds":{"left":0.1775266,"top":0.99241817,"width":0.019448139,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.111203454,"top":0.9912211,"width":0.09042553,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.13547207,"top":1.0,"width":0.013962766,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15142952,"top":1.0,"width":0.0026595744,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.15608378,"top":1.0,"width":0.02244016,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.18051861,"top":1.0,"width":0.013131649,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.025099734,"height":-0.03391862},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"bounds":{"left":0.14029256,"top":1.0,"width":0.013630319,"height":-0.03272152},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.041888297,"height":-0.063447714},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.15708111,"top":1.0,"width":0.024933511,"height":-0.062250614},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.0390625,"height":-0.08419788},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"bounds":{"left":0.15425532,"top":1.0,"width":0.011968086,"height":-0.08300078},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"bounds":{"left":0.09291888,"top":0.8216281,"width":0.10638298,"height":0.01915403},"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"bounds":{"left":0.099567816,"top":0.82202715,"width":0.069980055,"height":0.018355945},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"bounds":{"left":0.091921546,"top":0.8216281,"width":0.0066489363,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"bounds":{"left":0.08892952,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"bounds":{"left":0.10488697,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"bounds":{"left":0.16007313,"top":0.85514766,"width":0.027925532,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"bounds":{"left":0.1653923,"top":0.8639266,"width":0.00930851,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"}]...
|
1759860134477698640
|
8923867558972243400
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast...
|
42370
|
NULL
|
NULL
|
NULL
|
|
42373
|
1556
|
5
|
2026-05-14T11:30:41.109680+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758241109_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-18091 | Update composer to support php 8.5 #12058 Edit title
JY-18091 | Update composer to support php 8.5
#
12058
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5
JY-18091-upgrade-to-php-8-5
Copy head branch name to clipboard
Lines changed: 2199 additions & 3796 deletions
Conversation (3)
Conversation
(
3
)
Commits (10)
Commits
(
10
)
Checks (3)
Checks
(
3
)
Files changed (260)
Files changed
(
260
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-18091 | Update composer to support php 8.5
JY-18091 | Update composer to support php 8.5
#
12058
All commits
All commits
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5
JY-18091-upgrade-to-php-8-5
Copy head branch name to clipboard
8 of 260 files viewed
Checks failing
Checks failing
Submit review
Submit
review...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.057063047,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.08060654,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.09217877,"width":0.101230055,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"bounds":{"left":0.0028257978,"top":0.11332801,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"bounds":{"left":0.015957447,"top":0.12490024,"width":0.076961435,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"bounds":{"left":0.0028257978,"top":0.14604948,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"bounds":{"left":0.015957447,"top":0.15762171,"width":0.08543883,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"bounds":{"left":0.0028257978,"top":0.17877094,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"bounds":{"left":0.015957447,"top":0.19034317,"width":0.04288564,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"bounds":{"left":0.0028257978,"top":0.21149242,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"bounds":{"left":0.015957447,"top":0.22306465,"width":0.12732713,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"bounds":{"left":0.0028257978,"top":0.2442139,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"bounds":{"left":0.015957447,"top":0.25578612,"width":0.033410903,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.27693537,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.28850758,"width":0.18068483,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"bounds":{"left":0.06732048,"top":0.28411812,"width":0.007978723,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"bounds":{"left":0.0028257978,"top":0.30965683,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"bounds":{"left":0.015957447,"top":0.32122904,"width":0.171875,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.3423783,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.35395053,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"bounds":{"left":0.0,"top":0.37509975,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"bounds":{"left":0.013297873,"top":0.386672,"width":0.029920213,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.41300878,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.4365523,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.4481245,"width":0.06632314,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.46927375,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.48084596,"width":0.064494684,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.5019952,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.51356745,"width":0.15658244,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.53990424,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.5634477,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.57501996,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.5961692,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6077414,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.62889063,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6404629,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.66161215,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.67318434,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.6995211,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.72306466,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.73463684,"width":0.091755316,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.7557861,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.76735836,"width":0.11619016,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.7885076,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.8000798,"width":0.18932846,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.82122904,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.8328013,"width":0.12898937,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.8539505,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.86552274,"width":0.079288565,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"bounds":{"left":0.0,"top":0.88667196,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"bounds":{"left":0.013297873,"top":0.8982442,"width":0.032247342,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0,"top":0.9193935,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.013297873,"top":0.93096566,"width":0.013131649,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.95211494,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.9636871,"width":0.041722074,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.9848364,"width":0.07962101,"height":0.0151636},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.99640864,"width":0.041722074,"height":0.0035913587},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":1.0,"width":0.07962101,"height":-0.01755786},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":1.0,"width":0.041722074,"height":-0.029130101},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.007978723,"height":-0.05546689},"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.07679521,"height":-0.07901037},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":1.0,"width":0.21575798,"height":-0.09058261},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"bounds":{"left":0.0028257978,"top":0.92897046,"width":0.07413564,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"bounds":{"left":0.0028257978,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"bounds":{"left":0.013796543,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"bounds":{"left":0.024933511,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"bounds":{"left":0.036070477,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"bounds":{"left":0.04720745,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"bounds":{"left":0.1846742,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"bounds":{"left":0.1966423,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"bounds":{"left":0.1939827,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"bounds":{"left":0.08361037,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"bounds":{"left":0.16605718,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"bounds":{"left":0.17935506,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"bounds":{"left":0.079288565,"top":0.14764565,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"bounds":{"left":0.079288565,"top":0.15003991,"width":0.1200133,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"bounds":{"left":0.1022274,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"bounds":{"left":0.116855055,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"bounds":{"left":0.13680187,"top":0.19313647,"width":0.051861703,"height":0.09577015},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"bounds":{"left":0.079288565,"top":0.19393456,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"bounds":{"left":0.13680187,"top":0.19473264,"width":0.051861703,"height":0.80526733},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"bounds":{"left":0.13680187,"top":0.30965683,"width":0.05119681,"height":0.188747},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"bounds":{"left":0.18866356,"top":0.19313647,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"bounds":{"left":0.1939827,"top":0.32083002,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"bounds":{"left":0.08460771,"top":0.3519553,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"bounds":{"left":0.08460771,"top":0.35395053,"width":0.04105718,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"bounds":{"left":0.08759973,"top":0.35514766,"width":0.1100399,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"bounds":{"left":0.1427859,"top":0.41739824,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"bounds":{"left":0.1627327,"top":0.41739824,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"bounds":{"left":0.08759973,"top":0.45810056,"width":0.11702128,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"bounds":{"left":0.08759973,"top":0.45969674,"width":0.08676862,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"bounds":{"left":0.08759973,"top":0.5051876,"width":0.11702128,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.020944148,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"bounds":{"left":0.12450133,"top":0.5981644,"width":0.075465426,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.10305851,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"bounds":{"left":0.10023271,"top":0.6189146,"width":0.08261303,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"bounds":{"left":0.12732713,"top":0.63846767,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.028590426,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.1043883,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"bounds":{"left":0.08759973,"top":0.7709497,"width":0.11702128,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"bounds":{"left":0.08759973,"top":0.7725459,"width":0.05668218,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"bounds":{"left":0.08759973,"top":0.79888266,"width":0.115359046,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"bounds":{"left":0.10023271,"top":0.89066243,"width":0.04870346,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"bounds":{"left":0.11319814,"top":0.9213887,"width":0.025099734,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"bounds":{"left":0.14029256,"top":0.9201915,"width":0.064328454,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"bounds":{"left":0.11319814,"top":0.94213885,"width":0.041888297,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15708111,"top":0.94094175,"width":0.0026595744,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16173537,"top":0.94213885,"width":0.013962766,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.17769282,"top":0.94094175,"width":0.013297873,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.11319814,"top":0.9628891,"width":0.022273935,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.13746676,"top":0.9616919,"width":0.0014960107,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"bounds":{"left":0.11319814,"top":0.99241817,"width":0.022273935,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.13746676,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"bounds":{"left":0.14394946,"top":0.99241817,"width":0.025099734,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.17104389,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"bounds":{"left":0.1775266,"top":0.99241817,"width":0.019448139,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.111203454,"top":0.9912211,"width":0.09042553,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.13547207,"top":1.0,"width":0.013962766,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15142952,"top":1.0,"width":0.0026595744,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.15608378,"top":1.0,"width":0.02244016,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.18051861,"top":1.0,"width":0.013131649,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.025099734,"height":-0.03391862},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"bounds":{"left":0.14029256,"top":1.0,"width":0.013630319,"height":-0.03272152},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.041888297,"height":-0.063447714},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.15708111,"top":1.0,"width":0.024933511,"height":-0.062250614},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.0390625,"height":-0.08419788},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"bounds":{"left":0.15425532,"top":1.0,"width":0.011968086,"height":-0.08300078},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"bounds":{"left":0.09291888,"top":0.8216281,"width":0.10638298,"height":0.01915403},"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"bounds":{"left":0.099567816,"top":0.82202715,"width":0.069980055,"height":0.018355945},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"bounds":{"left":0.091921546,"top":0.8216281,"width":0.0066489363,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"bounds":{"left":0.08892952,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"bounds":{"left":0.10488697,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"bounds":{"left":0.16007313,"top":0.85514766,"width":0.027925532,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"bounds":{"left":0.1653923,"top":0.8639266,"width":0.00930851,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Microphone","depth":19,"bounds":{"left":0.18999335,"top":0.85514766,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Send message","depth":19,"bounds":{"left":0.19630983,"top":0.85434955,"width":0.013962766,"height":0.033519555},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":false,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.","depth":17,"bounds":{"left":0.08510638,"top":0.90901834,"width":0.11951463,"height":0.025139665},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Your privacy & Gemini Opens in a new window","depth":17,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your privacy & Gemini","depth":18,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Opens in a new window","depth":19,"bounds":{"left":0.079288565,"top":0.92098963,"width":0.043218084,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Summarize page","depth":7,"bounds":{"left":0.08494016,"top":0.95730245,"width":0.053523935,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Summarize page","depth":9,"bounds":{"left":0.09059176,"top":0.96249,"width":0.042220745,"height":0.015163607},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Skip to content","depth":6,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Skip to content","depth":7,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open menu","depth":10,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"Homepage (g then d)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"jiminny","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"jiminny","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"app","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"app","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Search or jump to…","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Type","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to search","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Chat with Copilot","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Open Copilot…","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXMenuButton","text":"Create new...","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXLink","text":"All issues(g then i)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All pull requests","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All repositories","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"You have unread notifications(g then n)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open user navigation menu","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Repository navigation","depth":9,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Repository navigation","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Code","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Pull requests (29)","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pull requests","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"29","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Agents","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Agents","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Actions","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Actions","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Wiki","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Wiki","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Security and quality","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Security and quality","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Insights","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Insights","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Settings","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Settings","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Important update","depth":10,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Important update","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Review this update","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Review this update","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and manage your preferences in your","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"GitHub account settings","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"GitHub account settings","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Dismiss banner","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"JY-18091 | Update composer to support php 8.5 #12058 Edit title","depth":13,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"#","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"12058","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Edit title","depth":14,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Preview","depth":13,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXStaticText","text":"Preview","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Checks failing","depth":13,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Checks failing","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXMenuButton","text":"Code","depth":13,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXStaticText","text":"Code","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Open","depth":13,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"nikolaybiaivanov","depth":15,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"nikolaybiaivanov","depth":16,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"wants to merge 10 commits into","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"master","depth":15,"on_screen":false,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"master","depth":16,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"from","depth":16,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"JY-18091-upgrade-to-php-8-5","depth":16,"on_screen":false,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-18091-upgrade-to-php-8-5","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy head branch name to clipboard","depth":16,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Lines changed: 2199 additions & 3796 deletions","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Conversation (3)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Conversation","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"3","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Commits (10)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Commits","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"10","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Checks (3)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Checks","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"3","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Files changed (260)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"Files changed","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"260","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Pull Request Toolbar","depth":14,"bounds":{"left":0.22606383,"top":0.075019956,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pull Request Toolbar","depth":15,"bounds":{"left":0.22606383,"top":0.077813245,"width":0.030086435,"height":0.08060654},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Collapse file tree","depth":14,"bounds":{"left":0.22606383,"top":0.06424581,"width":0.00930851,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXStaticText","text":"Open","depth":14,"bounds":{"left":0.2486702,"top":0.06863528,"width":0.011968086,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"JY-18091 | Update composer to support php 8.5","depth":14,"bounds":{"left":0.26728722,"top":0.057462092,"width":0.108211435,"height":0.016759777},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5","depth":16,"bounds":{"left":0.26728722,"top":0.05905826,"width":0.108211435,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"#","depth":15,"bounds":{"left":0.37815824,"top":0.05905826,"width":0.0028257978,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"12058","depth":15,"bounds":{"left":0.38098404,"top":0.05905826,"width":0.013630319,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"All commits","depth":14,"bounds":{"left":0.26462767,"top":0.07102953,"width":0.03374335,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"All commits","depth":16,"bounds":{"left":0.26761967,"top":0.07621708,"width":0.02244016,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"nikolaybiaivanov","depth":15,"bounds":{"left":0.30269283,"top":0.075019956,"width":0.032413565,"height":0.014365523},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"nikolaybiaivanov","depth":16,"bounds":{"left":0.30269283,"top":0.07621708,"width":0.032413565,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"wants to merge 10 commits into","depth":15,"bounds":{"left":0.33643618,"top":0.07621708,"width":0.059840426,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"master","depth":15,"bounds":{"left":0.39760637,"top":0.07342378,"width":0.018450798,"height":0.017557861},"on_screen":true,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"master","depth":16,"bounds":{"left":0.39960107,"top":0.07661612,"width":0.014461436,"height":0.011572227},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"from","depth":16,"bounds":{"left":0.41738698,"top":0.07621708,"width":0.008643617,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"JY-18091-upgrade-to-php-8-5","depth":16,"bounds":{"left":0.4273604,"top":0.07342378,"width":0.06881649,"height":0.017557861},"on_screen":true,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-18091-upgrade-to-php-8-5","depth":17,"bounds":{"left":0.42935506,"top":0.07661612,"width":0.06482713,"height":0.011572227},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy head branch name to clipboard","depth":16,"bounds":{"left":0.49750665,"top":0.07102953,"width":0.00930851,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"8 of 260 files viewed","depth":15,"bounds":{"left":0.8174867,"top":0.07661612,"width":0.01512633,"height":0.08060654},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Checks failing","depth":14,"bounds":{"left":0.86053854,"top":0.06424581,"width":0.03956117,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Checks failing","depth":16,"bounds":{"left":0.87017953,"top":0.06943336,"width":0.026928192,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Submit review","depth":14,"bounds":{"left":0.9027593,"top":0.06424581,"width":0.03856383,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Submit","depth":16,"bounds":{"left":0.90575135,"top":0.06943336,"width":0.014793883,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"review","depth":16,"bounds":{"left":0.9205452,"top":0.06943336,"width":0.012466756,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"}]...
|
990471522240029442
|
8923868658492259784
|
visual_change
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-18091 | Update composer to support php 8.5 #12058 Edit title
JY-18091 | Update composer to support php 8.5
#
12058
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5
JY-18091-upgrade-to-php-8-5
Copy head branch name to clipboard
Lines changed: 2199 additions & 3796 deletions
Conversation (3)
Conversation
(
3
)
Commits (10)
Commits
(
10
)
Checks (3)
Checks
(
3
)
Files changed (260)
Files changed
(
260
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-18091 | Update composer to support php 8.5
JY-18091 | Update composer to support php 8.5
#
12058
All commits
All commits
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5
JY-18091-upgrade-to-php-8-5
Copy head branch name to clipboard
8 of 260 files viewed
Checks failing
Checks failing
Submit review
Submit
review...
|
NULL
|
NULL
|
NULL
|
NULL
|
|
42416
|
1555
|
29
|
2026-05-14T11:34:45.936512+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758485936_m1.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_1
|
NULL
|
NULL
|
NULL
|
NULL
|
HomeDMsActivityFilesLater..•MoreSlackFileEditViewE HomeDMsActivityFilesLater..•MoreSlackFileEditViewEDJiminny ...# engineering# general# jiminny-bg# platform-tickets# product_launches# random# releases#sofia-office# support# thank-yous# the_people_of jimi...• Direct messagese. Aneliya Angelo...C. Vasil Vasilev&. Stefka Stoyanova: Todor StamatovMario GeorgievNikolay IvanovJames GrahamStoyan Tanev®. Galya DimitrovaSteliyan GeorgievPetko KashinskiLukas Kovalik y...:: AppsToastJira CloudGoHistoryWindowHelpDescribe what you are looking forVasil VasilevMessagesAdd canvas@ Files& Pins +тогава не трябва да пипаме activity stageToday ~това искам да се провериLukas Kovalik 2:29 PMахада прав си, ами то стана вече каша покрай всичките rematching-иVasil Vasilev 2:31 PMдаза това и повдигам въпросаLukas Kovalik 2:31 PMами да ако e stage-at call значи каквото бешетрябва да видя какво се случва при lead -› opportuntityVasil Vasilev 2:31 PMтогава е окейпри конвертирането, лийда и стейджа се премахвати се оставя само сделкатамакар, че има смисъл и лийда и неговия стейдж да останатпьк да се асоциира и opportunityи ако активити има едновременно и lead и opportunity, значи вероятно тоя лийд е конвертиранно май не сме го правили по тоя начинLukas Kovalik 2:33 PMами мисля че трием lead и негов стаге тогаватрябва да го проверяMessage Vasil Vasilev+< >0 lhl§ Support Daily - in 26 m100% C8•Thu 14 May 14:34:45New...
|
NULL
|
6418922293758115471
|
NULL
|
click
|
ocr
|
NULL
|
HomeDMsActivityFilesLater..•MoreSlackFileEditViewE HomeDMsActivityFilesLater..•MoreSlackFileEditViewEDJiminny ...# engineering# general# jiminny-bg# platform-tickets# product_launches# random# releases#sofia-office# support# thank-yous# the_people_of jimi...• Direct messagese. Aneliya Angelo...C. Vasil Vasilev&. Stefka Stoyanova: Todor StamatovMario GeorgievNikolay IvanovJames GrahamStoyan Tanev®. Galya DimitrovaSteliyan GeorgievPetko KashinskiLukas Kovalik y...:: AppsToastJira CloudGoHistoryWindowHelpDescribe what you are looking forVasil VasilevMessagesAdd canvas@ Files& Pins +тогава не трябва да пипаме activity stageToday ~това искам да се провериLukas Kovalik 2:29 PMахада прав си, ами то стана вече каша покрай всичките rematching-иVasil Vasilev 2:31 PMдаза това и повдигам въпросаLukas Kovalik 2:31 PMами да ако e stage-at call значи каквото бешетрябва да видя какво се случва при lead -› opportuntityVasil Vasilev 2:31 PMтогава е окейпри конвертирането, лийда и стейджа се премахвати се оставя само сделкатамакар, че има смисъл и лийда и неговия стейдж да останатпьк да се асоциира и opportunityи ако активити има едновременно и lead и opportunity, значи вероятно тоя лийд е конвертиранно май не сме го правили по тоя начинLukas Kovalik 2:33 PMами мисля че трием lead и негов стаге тогаватрябва да го проверяMessage Vasil Vasilev+< >0 lhl§ Support Daily - in 26 m100% C8•Thu 14 May 14:34:45New...
|
42413
|
NULL
|
NULL
|
NULL
|
|
42417
|
1555
|
30
|
2026-05-14T11:34:47.116118+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758487116_m1.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_1
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-18091 | Update composer to support php 8.5 #12058 Edit title
JY-18091 | Update composer to support php 8.5
#
12058
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Microphone","depth":19,"on_screen":true,"role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Send message","depth":19,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":false,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.","depth":17,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Your privacy & Gemini Opens in a new window","depth":17,"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your privacy & Gemini","depth":18,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Opens in a new window","depth":19,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Summarize page","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Summarize page","depth":9,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Skip to content","depth":6,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Skip to content","depth":7,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open menu","depth":10,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"Homepage (g then d)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"jiminny","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"jiminny","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"app","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"app","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Search or jump to…","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Type","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to search","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Chat with Copilot","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Open Copilot…","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXMenuButton","text":"Create new...","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXLink","text":"All issues(g then i)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All pull requests","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All repositories","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"You have unread notifications(g then n)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open user navigation menu","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Repository navigation","depth":9,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Repository navigation","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Code","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Pull requests (29)","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pull requests","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"29","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Agents","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Agents","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Actions","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Actions","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Wiki","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Wiki","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Security and quality","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Security and quality","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Insights","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Insights","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Settings","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Settings","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Important update","depth":10,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Important update","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Review this update","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Review this update","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and manage your preferences in your","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"GitHub account settings","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"GitHub account settings","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Dismiss banner","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"JY-18091 | Update composer to support php 8.5 #12058 Edit title","depth":13,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"#","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"12058","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Edit title","depth":14,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Preview","depth":13,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXStaticText","text":"Preview","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Checks failing","depth":13,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Checks failing","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXMenuButton","text":"Code","depth":13,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXStaticText","text":"Code","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Open","depth":13,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"nikolaybiaivanov","depth":15,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"nikolaybiaivanov","depth":16,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"wants to merge 10 commits into","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"master","depth":15,"on_screen":false,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"master","depth":16,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"from","depth":16,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"JY-18091-upgrade-to-php-8-5","depth":16,"on_screen":false,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false}]...
|
-7528993587919545429
|
8923868658492259784
|
visual_change
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-18091 | Update composer to support php 8.5 #12058 Edit title
JY-18091 | Update composer to support php 8.5
#
12058
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5...
|
NULL
|
NULL
|
NULL
|
NULL
|
|
42418
|
1556
|
21
|
2026-05-14T11:34:45.941025+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758485941_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
• github.com/~ Google Geminip Pinedrive ApI Pefere • github.com/~ Google Geminip Pinedrive ApI Peference and Dod•pipedrive/client-php: Pipedrive AlP Pipedrive API Changelog( client-php/docs/versions/v2/REAIP Changes to the APlP JY-18091| Update composer XG Ihttps://github.com/pipedrive/clidLY [SRD-6849] Recorded call doesw Usage | WindsurfY [SRD-6848] Sidekick SMS issue(UY-20891] Sidekick SMS issue -• Jy-20891 add support for secon11 (SRD-6849] Recorded call does !+ (SRD-6853) Moxso - Potential deA fuy-209031 Recorded call does nJY-20903 Update activity stage -8 Configure SSH access to multiple c& Useful commands - Engineering-Dev Tools - ElasticIL Now TohI'm on page"<tabTitle>JY-18091 |Update composer tosuopor ono 8.s ovn</tabTitle>" with...The selected code changes represent amechanical refactoring of a PHP controller toalign with modern syntax standards, likely aspart of the upgrade to PHP 8.5.Core Change: Member Access onnstantiationThe primary modification across the entire file isthe removal of unnecessary parentheses whenperforming member access (method chaining)on a newly instantiated object.•Pattern: (new ClassNameo)->methodois simplified to new ClassName () -methodo.• Reasoning: Since PHP 8.0+, the parserhandles member access on newexpressions without requiring the wrappingnarentheses tor disamolquationAffected ComponentsEnter a prompt for GeminiFastvAl lt can make mistakes so double check it Your orivaev &. GerSummarize page82 0рJY-18091 | Update composer to support php 8.5 #12058nikolaybiaivanov wants to merge 10 commits into master from JY-18091-upgrade-to-php-8-5• Filter files...v [ .circleci* config_continue.ymlv / aoo~ E Component~# Actionitems/NotificationsActionitemsNotitication.onol~# ActivityAnalytics/ServiceE) TopicTriggerService.phpv ActivitvSearchi~ FilterDefinition• A Securitv.@ PrivateMeetingsForCurren…® RestrictPublicActivitiesOnl….RestrictTeam.phpv — TeaminsiahtsiDateRangeFilter.php( Exists.ohoUserGrouplnFilter.phpE UserInFilter.phpE1 ActivitvActualDate.ohvActivityFilter.phpE ActivityRecordingStopped....ActivityScheduledDate.php# AiCallScoreFilter nhnAutoScoreFilter.phpClosedDealsFilter.phpE CoachingFeedbackAverage...CrmFieldCollection.phpCurrentStage.php@ Customer nhnE HasTopicTriggersFilterDefin...# HasTranscriotion.ohv# LoggedToCrm.phpapp/Component/ActivitySearch/FilterDefinition/Security/RestrictTeam.php Ct> app/Component/ActivitySearch/FilterDefinition/TeamInsights/DateRangeFilter.php> app/Component/ActivitySearch/FilterDefinition/TeamInsights/Exists.php 4app/Component/ActivitySearch/FilterDefinition/TeamInsights/UserGroupInFilter.php [ *aa -36,7 +36,7 aa public function getQueries(): FilterDefinitionQueryCollectionif (sthis->isContext(ContextAwareFilterDefinitionInterface::CONTEXT TEAM INSIGHTS COMMENTS FILLED)) <Ireturn FilterDef1n1t1onQuerycollection::make(lFilterDefinitionQuery:: instance()>setQuery((new Query\Term())->setTerm('comments,type', Models\Activity\Comment: : TYPE_NEUTRAL))->setPath( 'comments'. 'comments').rilterverinicionvuery::1nstance->setQuery (new Query\Terms ('comments.user.id_string-keyword', SuserIds))aa -47,7 +47,7 aa public function getQueries(): FilterDefinitionQueryCollectionif (sthis-sisContext(ContextAwareFilterDefinitionInterface::CONTEXT TEAM INSIGHTS COMMENTS RECETVED)) <|recurn rilcerverin1cionuuervcolleccion::makel50 -FilterdefinitionQuery:.instance->setQuery((new Query\Term())->setTerm('comments,type', Models\Activity\Comment:: TYPE_NEUTRAL))->setPath( "comments'. "comments').rilterverinitlonuuery::instancel)->setQuery(new Query Terms('user.id strina.kevword'. Suserids))I@ -116,7 +116,7 @@ public function getQueries(): FilterDefinitionQueryCollection117|if (Sthis->isContext(ContextAwareFilterDefinitionInterface::CONTEXT_TEAM_INSIGHTS_COACHED_LIVE)) (return_FilterDefinition0ueryCollection::make([lrilterberin1t1onQuery:: 1nstance()119->setQuery((new Ouerv Termo))->setTerm('particioants.is ahost'. true))->setPath( participants, participants ),FilterDefinitionQuerv::instance@l->setQuery(new Query .Terms(participants.user.1d_string.keyword, Suserids))apo/Component/ActivitvSearch/FilterDefinition/TeamInsights/UserInFilter.oho |@@ -34,7 +34,7 @@ public function getQueries(): ?FilterDefinitionQueryCollectionif (Sthis->isContext(ContextAwareFilterDefinitionInterface::CONTEXT_TEAM_INSIGHTS_COMMENTS_FILLED)) {return FilterDefinitionQuervCollection::make([lFilterDef1n1t1onQuery::1nstance)37->setQuerv((new Ouerv\Term())->setTerm( 'comments.tvne'. Models Activitv\Comment::TYPE NEUTRAL))|->setPath('comments', 'comments"),FilterDefinitionQuery:.instance-›setQuery (new Query\Terms('comments.user.id_string.keyword', sthis->getValue()))116118119 +12237‹ S0 lihl 1 Support Daily - in 26m• 8 | 260 viewedx Checks Talling100% L2P• Inu 14 Mау 14.34:40+1-187• Viewed+5 -5 muaa•Viewed+3 -3 004v Viewec+3-3 0027Viewedif ($this->isContext(ContextAwareFilterDefinitionInterface::CONTEXT_TEAM_INSIGHTS_COMMENTS_FILLED)) {return Filterberin1t1onQuerycollection::makeFilterDefinitionQuerv::instance@1->setQuery(new Query\ Term()->setTerm('comments.type', Models\Activity\Comment::TYPE NEUTRAL) )->setPath('comments', 'comments'),FilterDefinitionQuery:: instance()->setQuery(new Querv\Terms('comments.user.id strina.kevord'. Suserlds))if (Sthis-sisContext(ContextAwareFilterDefinitionInterface::CONTEXT TEAM INSIGHTS COMMENTS RECETVED)) <Ireturn FilterDefinitionQueryCollection::make(iFilterdefinitionQuery:.instanced->setQuery(new Query\Term()->setTerm('comments.type', Models\Activity\Comment: :TYPE_NEUTRAL))->setPath('comments', 'comments'),FilterDefinitionQuery:: instance()->setQuery(new Ouery Terms('user.id strina.kevword'. Suserids))if (Sthis->isContext(ContextAwareFilterDefinitionInterface::CONTEXT_TEAM_INSIGHTS_COACHED_LIVE)) {return FilterDefinitionOuervCollection::make(||FilterDefinitionQuery:: instance()->setQuery(new Ouerv Term()->setTerm( 'oarticioants.is ahost'. true))->setPath( participants, 'participants)FilterDefinitionQuerv::instance@1->setQuery new Query Terms('participants.user.1d string.keyword, Suserids))+3 -3 mnae[ Viewedif (Sthis->isContext(ContextAwareFilterDefinitionInterface::CONTEXT_TEAM_INSIGHTS_COMMENTS_FILLED)) {return FilterDefinition0uervCollection::make(|lFilterDefinitionQuery:: instance()->setQuery(new Ouerv\Term()->setTerm( 'comments.tvne'. Models\Activitv\Comment::TYPE NEUTRAL))scotDath(icommontcl "commontc!)FilterDefinitionQuery:.instance()->setQuery(new Query)Terms('comments.user.id string.keyword', Sthis-›getValue()))...
|
NULL
|
1638869492881548611
|
NULL
|
click
|
ocr
|
NULL
|
• github.com/~ Google Geminip Pinedrive ApI Pefere • github.com/~ Google Geminip Pinedrive ApI Peference and Dod•pipedrive/client-php: Pipedrive AlP Pipedrive API Changelog( client-php/docs/versions/v2/REAIP Changes to the APlP JY-18091| Update composer XG Ihttps://github.com/pipedrive/clidLY [SRD-6849] Recorded call doesw Usage | WindsurfY [SRD-6848] Sidekick SMS issue(UY-20891] Sidekick SMS issue -• Jy-20891 add support for secon11 (SRD-6849] Recorded call does !+ (SRD-6853) Moxso - Potential deA fuy-209031 Recorded call does nJY-20903 Update activity stage -8 Configure SSH access to multiple c& Useful commands - Engineering-Dev Tools - ElasticIL Now TohI'm on page"<tabTitle>JY-18091 |Update composer tosuopor ono 8.s ovn</tabTitle>" with...The selected code changes represent amechanical refactoring of a PHP controller toalign with modern syntax standards, likely aspart of the upgrade to PHP 8.5.Core Change: Member Access onnstantiationThe primary modification across the entire file isthe removal of unnecessary parentheses whenperforming member access (method chaining)on a newly instantiated object.•Pattern: (new ClassNameo)->methodois simplified to new ClassName () -methodo.• Reasoning: Since PHP 8.0+, the parserhandles member access on newexpressions without requiring the wrappingnarentheses tor disamolquationAffected ComponentsEnter a prompt for GeminiFastvAl lt can make mistakes so double check it Your orivaev &. GerSummarize page82 0рJY-18091 | Update composer to support php 8.5 #12058nikolaybiaivanov wants to merge 10 commits into master from JY-18091-upgrade-to-php-8-5• Filter files...v [ .circleci* config_continue.ymlv / aoo~ E Component~# Actionitems/NotificationsActionitemsNotitication.onol~# ActivityAnalytics/ServiceE) TopicTriggerService.phpv ActivitvSearchi~ FilterDefinition• A Securitv.@ PrivateMeetingsForCurren…® RestrictPublicActivitiesOnl….RestrictTeam.phpv — TeaminsiahtsiDateRangeFilter.php( Exists.ohoUserGrouplnFilter.phpE UserInFilter.phpE1 ActivitvActualDate.ohvActivityFilter.phpE ActivityRecordingStopped....ActivityScheduledDate.php# AiCallScoreFilter nhnAutoScoreFilter.phpClosedDealsFilter.phpE CoachingFeedbackAverage...CrmFieldCollection.phpCurrentStage.php@ Customer nhnE HasTopicTriggersFilterDefin...# HasTranscriotion.ohv# LoggedToCrm.phpapp/Component/ActivitySearch/FilterDefinition/Security/RestrictTeam.php Ct> app/Component/ActivitySearch/FilterDefinition/TeamInsights/DateRangeFilter.php> app/Component/ActivitySearch/FilterDefinition/TeamInsights/Exists.php 4app/Component/ActivitySearch/FilterDefinition/TeamInsights/UserGroupInFilter.php [ *aa -36,7 +36,7 aa public function getQueries(): FilterDefinitionQueryCollectionif (sthis->isContext(ContextAwareFilterDefinitionInterface::CONTEXT TEAM INSIGHTS COMMENTS FILLED)) <Ireturn FilterDef1n1t1onQuerycollection::make(lFilterDefinitionQuery:: instance()>setQuery((new Query\Term())->setTerm('comments,type', Models\Activity\Comment: : TYPE_NEUTRAL))->setPath( 'comments'. 'comments').rilterverinicionvuery::1nstance->setQuery (new Query\Terms ('comments.user.id_string-keyword', SuserIds))aa -47,7 +47,7 aa public function getQueries(): FilterDefinitionQueryCollectionif (sthis-sisContext(ContextAwareFilterDefinitionInterface::CONTEXT TEAM INSIGHTS COMMENTS RECETVED)) <|recurn rilcerverin1cionuuervcolleccion::makel50 -FilterdefinitionQuery:.instance->setQuery((new Query\Term())->setTerm('comments,type', Models\Activity\Comment:: TYPE_NEUTRAL))->setPath( "comments'. "comments').rilterverinitlonuuery::instancel)->setQuery(new Query Terms('user.id strina.kevword'. Suserids))I@ -116,7 +116,7 @@ public function getQueries(): FilterDefinitionQueryCollection117|if (Sthis->isContext(ContextAwareFilterDefinitionInterface::CONTEXT_TEAM_INSIGHTS_COACHED_LIVE)) (return_FilterDefinition0ueryCollection::make([lrilterberin1t1onQuery:: 1nstance()119->setQuery((new Ouerv Termo))->setTerm('particioants.is ahost'. true))->setPath( participants, participants ),FilterDefinitionQuerv::instance@l->setQuery(new Query .Terms(participants.user.1d_string.keyword, Suserids))apo/Component/ActivitvSearch/FilterDefinition/TeamInsights/UserInFilter.oho |@@ -34,7 +34,7 @@ public function getQueries(): ?FilterDefinitionQueryCollectionif (Sthis->isContext(ContextAwareFilterDefinitionInterface::CONTEXT_TEAM_INSIGHTS_COMMENTS_FILLED)) {return FilterDefinitionQuervCollection::make([lFilterDef1n1t1onQuery::1nstance)37->setQuerv((new Ouerv\Term())->setTerm( 'comments.tvne'. Models Activitv\Comment::TYPE NEUTRAL))|->setPath('comments', 'comments"),FilterDefinitionQuery:.instance-›setQuery (new Query\Terms('comments.user.id_string.keyword', sthis->getValue()))116118119 +12237‹ S0 lihl 1 Support Daily - in 26m• 8 | 260 viewedx Checks Talling100% L2P• Inu 14 Mау 14.34:40+1-187• Viewed+5 -5 muaa•Viewed+3 -3 004v Viewec+3-3 0027Viewedif ($this->isContext(ContextAwareFilterDefinitionInterface::CONTEXT_TEAM_INSIGHTS_COMMENTS_FILLED)) {return Filterberin1t1onQuerycollection::makeFilterDefinitionQuerv::instance@1->setQuery(new Query\ Term()->setTerm('comments.type', Models\Activity\Comment::TYPE NEUTRAL) )->setPath('comments', 'comments'),FilterDefinitionQuery:: instance()->setQuery(new Querv\Terms('comments.user.id strina.kevord'. Suserlds))if (Sthis-sisContext(ContextAwareFilterDefinitionInterface::CONTEXT TEAM INSIGHTS COMMENTS RECETVED)) <Ireturn FilterDefinitionQueryCollection::make(iFilterdefinitionQuery:.instanced->setQuery(new Query\Term()->setTerm('comments.type', Models\Activity\Comment: :TYPE_NEUTRAL))->setPath('comments', 'comments'),FilterDefinitionQuery:: instance()->setQuery(new Ouery Terms('user.id strina.kevword'. Suserids))if (Sthis->isContext(ContextAwareFilterDefinitionInterface::CONTEXT_TEAM_INSIGHTS_COACHED_LIVE)) {return FilterDefinitionOuervCollection::make(||FilterDefinitionQuery:: instance()->setQuery(new Ouerv Term()->setTerm( 'oarticioants.is ahost'. true))->setPath( participants, 'participants)FilterDefinitionQuerv::instance@1->setQuery new Query Terms('participants.user.1d string.keyword, Suserids))+3 -3 mnae[ Viewedif (Sthis->isContext(ContextAwareFilterDefinitionInterface::CONTEXT_TEAM_INSIGHTS_COMMENTS_FILLED)) {return FilterDefinition0uervCollection::make(|lFilterDefinitionQuery:: instance()->setQuery(new Ouerv\Term()->setTerm( 'comments.tvne'. Models\Activitv\Comment::TYPE NEUTRAL))scotDath(icommontcl "commontc!)FilterDefinitionQuery:.instance()->setQuery(new Query)Terms('comments.user.id string.keyword', Sthis-›getValue()))...
|
NULL
|
NULL
|
NULL
|
NULL
|
|
42419
|
1555
|
31
|
2026-05-14T11:34:47.736107+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758487736_m1.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_1
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
....
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"}]...
|
-3933884546851289608
|
4312181537323630024
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
....
|
42417
|
NULL
|
NULL
|
NULL
|
|
42420
|
1556
|
22
|
2026-05-14T11:34:48.195486+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758488195_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-18091 | Update composer to support php 8.5 #12058 Edit title
JY-18091 | Update composer to support php 8.5
#
12058
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5
JY-18091-upgrade-to-php-8-5
Copy head branch name to clipboard
Lines changed: 2199 additions & 3796 deletions
Conversation (3)
Conversation
(
3
)
Commits (10)
Commits
(
10
)
Checks (3)
Checks
(
3
)
Files changed (260)
Files changed
(
260
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-18091 | Update composer to support php 8.5
JY-18091 | Update composer to support php 8.5
#...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.057063047,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.08060654,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.09217877,"width":0.101230055,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"bounds":{"left":0.0028257978,"top":0.11332801,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"bounds":{"left":0.015957447,"top":0.12490024,"width":0.076961435,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"bounds":{"left":0.0028257978,"top":0.14604948,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"bounds":{"left":0.015957447,"top":0.15762171,"width":0.08543883,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"bounds":{"left":0.0028257978,"top":0.17877094,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"bounds":{"left":0.015957447,"top":0.19034317,"width":0.04288564,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"bounds":{"left":0.0028257978,"top":0.21149242,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"bounds":{"left":0.015957447,"top":0.22306465,"width":0.12732713,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"bounds":{"left":0.0028257978,"top":0.2442139,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"bounds":{"left":0.015957447,"top":0.25578612,"width":0.033410903,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.27693537,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.28850758,"width":0.18068483,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"bounds":{"left":0.06732048,"top":0.28411812,"width":0.007978723,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"bounds":{"left":0.0028257978,"top":0.30965683,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"bounds":{"left":0.015957447,"top":0.32122904,"width":0.171875,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.3423783,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.35395053,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"bounds":{"left":0.0,"top":0.37509975,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"bounds":{"left":0.013297873,"top":0.386672,"width":0.029920213,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.41300878,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.4365523,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.4481245,"width":0.06632314,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.46927375,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.48084596,"width":0.064494684,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.5019952,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.51356745,"width":0.15658244,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.53990424,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.5634477,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.57501996,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.5961692,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6077414,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.62889063,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6404629,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.66161215,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.67318434,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.6995211,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.72306466,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.73463684,"width":0.091755316,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.7557861,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.76735836,"width":0.11619016,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.7885076,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.8000798,"width":0.18932846,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.82122904,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.8328013,"width":0.12898937,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.8539505,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.86552274,"width":0.079288565,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"bounds":{"left":0.0,"top":0.88667196,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"bounds":{"left":0.013297873,"top":0.8982442,"width":0.032247342,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0,"top":0.9193935,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.013297873,"top":0.93096566,"width":0.013131649,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.95211494,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.9636871,"width":0.041722074,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.9848364,"width":0.07962101,"height":0.0151636},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.99640864,"width":0.041722074,"height":0.0035913587},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":1.0,"width":0.07962101,"height":-0.01755786},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":1.0,"width":0.041722074,"height":-0.029130101},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.007978723,"height":-0.05546689},"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.07679521,"height":-0.07901037},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":1.0,"width":0.21575798,"height":-0.09058261},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"bounds":{"left":0.0028257978,"top":0.92897046,"width":0.07413564,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"bounds":{"left":0.0028257978,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"bounds":{"left":0.013796543,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"bounds":{"left":0.024933511,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"bounds":{"left":0.036070477,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"bounds":{"left":0.04720745,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"bounds":{"left":0.1846742,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"bounds":{"left":0.1966423,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"bounds":{"left":0.1939827,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"bounds":{"left":0.08361037,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"bounds":{"left":0.16605718,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"bounds":{"left":0.17935506,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"bounds":{"left":0.079288565,"top":0.14764565,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"bounds":{"left":0.079288565,"top":0.15003991,"width":0.1200133,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"bounds":{"left":0.1022274,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"bounds":{"left":0.116855055,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"bounds":{"left":0.13680187,"top":0.19313647,"width":0.051861703,"height":0.09577015},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"bounds":{"left":0.079288565,"top":0.19393456,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"bounds":{"left":0.13680187,"top":0.19473264,"width":0.051861703,"height":0.80526733},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"bounds":{"left":0.13680187,"top":0.30965683,"width":0.05119681,"height":0.188747},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"bounds":{"left":0.18866356,"top":0.19313647,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"bounds":{"left":0.1939827,"top":0.32083002,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"bounds":{"left":0.08460771,"top":0.3519553,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"bounds":{"left":0.08460771,"top":0.35395053,"width":0.04105718,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"bounds":{"left":0.08759973,"top":0.35514766,"width":0.1100399,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"bounds":{"left":0.1427859,"top":0.41739824,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"bounds":{"left":0.1627327,"top":0.41739824,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"bounds":{"left":0.08759973,"top":0.45810056,"width":0.11702128,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"bounds":{"left":0.08759973,"top":0.45969674,"width":0.08676862,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"bounds":{"left":0.08759973,"top":0.5051876,"width":0.11702128,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.020944148,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"bounds":{"left":0.12450133,"top":0.5981644,"width":0.075465426,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.10305851,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"bounds":{"left":0.10023271,"top":0.6189146,"width":0.08261303,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"bounds":{"left":0.12732713,"top":0.63846767,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.028590426,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.1043883,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"bounds":{"left":0.08759973,"top":0.7709497,"width":0.11702128,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"bounds":{"left":0.08759973,"top":0.7725459,"width":0.05668218,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"bounds":{"left":0.08759973,"top":0.79888266,"width":0.115359046,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"bounds":{"left":0.10023271,"top":0.89066243,"width":0.04870346,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"bounds":{"left":0.11319814,"top":0.9213887,"width":0.025099734,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"bounds":{"left":0.14029256,"top":0.9201915,"width":0.064328454,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"bounds":{"left":0.11319814,"top":0.94213885,"width":0.041888297,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15708111,"top":0.94094175,"width":0.0026595744,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16173537,"top":0.94213885,"width":0.013962766,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.17769282,"top":0.94094175,"width":0.013297873,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.11319814,"top":0.9628891,"width":0.022273935,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.13746676,"top":0.9616919,"width":0.0014960107,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"bounds":{"left":0.11319814,"top":0.99241817,"width":0.022273935,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.13746676,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"bounds":{"left":0.14394946,"top":0.99241817,"width":0.025099734,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.17104389,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"bounds":{"left":0.1775266,"top":0.99241817,"width":0.019448139,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.111203454,"top":0.9912211,"width":0.09042553,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.13547207,"top":1.0,"width":0.013962766,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15142952,"top":1.0,"width":0.0026595744,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.15608378,"top":1.0,"width":0.02244016,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.18051861,"top":1.0,"width":0.013131649,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.025099734,"height":-0.03391862},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"bounds":{"left":0.14029256,"top":1.0,"width":0.013630319,"height":-0.03272152},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.041888297,"height":-0.063447714},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.15708111,"top":1.0,"width":0.024933511,"height":-0.062250614},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.0390625,"height":-0.08419788},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"bounds":{"left":0.15425532,"top":1.0,"width":0.011968086,"height":-0.08300078},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"bounds":{"left":0.09291888,"top":0.8216281,"width":0.10638298,"height":0.01915403},"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"bounds":{"left":0.099567816,"top":0.82202715,"width":0.069980055,"height":0.018355945},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"bounds":{"left":0.091921546,"top":0.8216281,"width":0.0066489363,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"bounds":{"left":0.08892952,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"bounds":{"left":0.10488697,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"bounds":{"left":0.16007313,"top":0.85514766,"width":0.027925532,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"bounds":{"left":0.1653923,"top":0.8639266,"width":0.00930851,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Microphone","depth":19,"bounds":{"left":0.18999335,"top":0.85514766,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Send message","depth":19,"bounds":{"left":0.19630983,"top":0.85434955,"width":0.013962766,"height":0.033519555},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":false,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.","depth":17,"bounds":{"left":0.08510638,"top":0.90901834,"width":0.11951463,"height":0.025139665},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Your privacy & Gemini Opens in a new window","depth":17,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your privacy & Gemini","depth":18,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Opens in a new window","depth":19,"bounds":{"left":0.079288565,"top":0.92098963,"width":0.043218084,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Summarize page","depth":7,"bounds":{"left":0.08494016,"top":0.95730245,"width":0.053523935,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Summarize page","depth":9,"bounds":{"left":0.09059176,"top":0.96249,"width":0.042220745,"height":0.015163607},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Skip to content","depth":6,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Skip to content","depth":7,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open menu","depth":10,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"Homepage (g then d)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"jiminny","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"jiminny","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"app","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"app","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Search or jump to…","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Type","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to search","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Chat with Copilot","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Open Copilot…","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXMenuButton","text":"Create new...","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXLink","text":"All issues(g then i)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All pull requests","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All repositories","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"You have unread notifications(g then n)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open user navigation menu","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Repository navigation","depth":9,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Repository navigation","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Code","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Pull requests (29)","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pull requests","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"29","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Agents","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Agents","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Actions","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Actions","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Wiki","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Wiki","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Security and quality","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Security and quality","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Insights","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Insights","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Settings","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Settings","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Important update","depth":10,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Important update","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Review this update","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Review this update","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and manage your preferences in your","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"GitHub account settings","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"GitHub account settings","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Dismiss banner","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"JY-18091 | Update composer to support php 8.5 #12058 Edit title","depth":13,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"#","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"12058","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Edit title","depth":14,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Preview","depth":13,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXStaticText","text":"Preview","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Checks failing","depth":13,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Checks failing","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXMenuButton","text":"Code","depth":13,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXStaticText","text":"Code","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Open","depth":13,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"nikolaybiaivanov","depth":15,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"nikolaybiaivanov","depth":16,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"wants to merge 10 commits into","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"master","depth":15,"on_screen":false,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"master","depth":16,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"from","depth":16,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"JY-18091-upgrade-to-php-8-5","depth":16,"on_screen":false,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-18091-upgrade-to-php-8-5","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy head branch name to clipboard","depth":16,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Lines changed: 2199 additions & 3796 deletions","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Conversation (3)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Conversation","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"3","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Commits (10)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Commits","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"10","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Checks (3)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Checks","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"3","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Files changed (260)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"Files changed","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"260","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Pull Request Toolbar","depth":14,"bounds":{"left":0.22606383,"top":0.075019956,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pull Request Toolbar","depth":15,"bounds":{"left":0.22606383,"top":0.077813245,"width":0.030086435,"height":0.08060654},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Collapse file tree","depth":14,"bounds":{"left":0.22606383,"top":0.06424581,"width":0.00930851,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXStaticText","text":"Open","depth":14,"bounds":{"left":0.2486702,"top":0.06863528,"width":0.011968086,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"JY-18091 | Update composer to support php 8.5","depth":14,"bounds":{"left":0.26728722,"top":0.057462092,"width":0.108211435,"height":0.016759777},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5","depth":16,"bounds":{"left":0.26728722,"top":0.05905826,"width":0.108211435,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"#","depth":15,"bounds":{"left":0.37815824,"top":0.05905826,"width":0.0028257978,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"}]...
|
-7723784441320838491
|
8923868658492259784
|
visual_change
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-18091 | Update composer to support php 8.5 #12058 Edit title
JY-18091 | Update composer to support php 8.5
#
12058
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5
JY-18091-upgrade-to-php-8-5
Copy head branch name to clipboard
Lines changed: 2199 additions & 3796 deletions
Conversation (3)
Conversation
(
3
)
Commits (10)
Commits
(
10
)
Checks (3)
Checks
(
3
)
Files changed (260)
Files changed
(
260
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-18091 | Update composer to support php 8.5
JY-18091 | Update composer to support php 8.5
#...
|
NULL
|
NULL
|
NULL
|
NULL
|
|
42421
|
1555
|
32
|
2026-05-14T11:34:49.291090+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758489291_m1.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_1
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Microphone","depth":19,"on_screen":true,"role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Send message","depth":19,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":false,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.","depth":17,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Your privacy & Gemini Opens in a new window","depth":17,"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false}]...
|
-1178301228808210688
|
8923868658492259784
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window...
|
NULL
|
NULL
|
NULL
|
NULL
|
|
42422
|
1556
|
23
|
2026-05-14T11:34:49.248516+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758489248_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.057063047,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.08060654,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.09217877,"width":0.101230055,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"bounds":{"left":0.0028257978,"top":0.11332801,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"bounds":{"left":0.015957447,"top":0.12490024,"width":0.076961435,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"bounds":{"left":0.0028257978,"top":0.14604948,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"bounds":{"left":0.015957447,"top":0.15762171,"width":0.08543883,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"bounds":{"left":0.0028257978,"top":0.17877094,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"bounds":{"left":0.015957447,"top":0.19034317,"width":0.04288564,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"bounds":{"left":0.0028257978,"top":0.21149242,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"bounds":{"left":0.015957447,"top":0.22306465,"width":0.12732713,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"bounds":{"left":0.0028257978,"top":0.2442139,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"bounds":{"left":0.015957447,"top":0.25578612,"width":0.033410903,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.27693537,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.28850758,"width":0.18068483,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"bounds":{"left":0.06732048,"top":0.28411812,"width":0.007978723,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"bounds":{"left":0.0028257978,"top":0.30965683,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"bounds":{"left":0.015957447,"top":0.32122904,"width":0.171875,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.3423783,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.35395053,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"bounds":{"left":0.0,"top":0.37509975,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"bounds":{"left":0.013297873,"top":0.386672,"width":0.029920213,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.41300878,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.4365523,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.4481245,"width":0.06632314,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.46927375,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.48084596,"width":0.064494684,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.5019952,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.51356745,"width":0.15658244,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.53990424,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.5634477,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.57501996,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.5961692,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6077414,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.62889063,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6404629,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.66161215,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.67318434,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.6995211,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.72306466,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.73463684,"width":0.091755316,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.7557861,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.76735836,"width":0.11619016,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.7885076,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.8000798,"width":0.18932846,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.82122904,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.8328013,"width":0.12898937,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.8539505,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.86552274,"width":0.079288565,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"bounds":{"left":0.0,"top":0.88667196,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"bounds":{"left":0.013297873,"top":0.8982442,"width":0.032247342,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0,"top":0.9193935,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.013297873,"top":0.93096566,"width":0.013131649,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.95211494,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.9636871,"width":0.041722074,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.9848364,"width":0.07962101,"height":0.0151636},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.99640864,"width":0.041722074,"height":0.0035913587},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":1.0,"width":0.07962101,"height":-0.01755786},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":1.0,"width":0.041722074,"height":-0.029130101},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.007978723,"height":-0.05546689},"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.07679521,"height":-0.07901037},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":1.0,"width":0.21575798,"height":-0.09058261},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"bounds":{"left":0.0028257978,"top":0.92897046,"width":0.07413564,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"bounds":{"left":0.0028257978,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"bounds":{"left":0.013796543,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"bounds":{"left":0.024933511,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"bounds":{"left":0.036070477,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"bounds":{"left":0.04720745,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"bounds":{"left":0.1846742,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"bounds":{"left":0.1966423,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"bounds":{"left":0.1939827,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"bounds":{"left":0.08361037,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"bounds":{"left":0.16605718,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"bounds":{"left":0.17935506,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"bounds":{"left":0.079288565,"top":0.14764565,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"bounds":{"left":0.079288565,"top":0.15003991,"width":0.1200133,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"bounds":{"left":0.1022274,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"bounds":{"left":0.116855055,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"bounds":{"left":0.13680187,"top":0.19313647,"width":0.051861703,"height":0.09577015},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"bounds":{"left":0.079288565,"top":0.19393456,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"bounds":{"left":0.13680187,"top":0.19473264,"width":0.051861703,"height":0.80526733},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"bounds":{"left":0.13680187,"top":0.30965683,"width":0.05119681,"height":0.188747},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"bounds":{"left":0.18866356,"top":0.19313647,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"bounds":{"left":0.1939827,"top":0.32083002,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"bounds":{"left":0.08460771,"top":0.3519553,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"bounds":{"left":0.08460771,"top":0.35395053,"width":0.04105718,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"bounds":{"left":0.08759973,"top":0.35514766,"width":0.1100399,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"bounds":{"left":0.1427859,"top":0.41739824,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"bounds":{"left":0.1627327,"top":0.41739824,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"bounds":{"left":0.08759973,"top":0.45810056,"width":0.11702128,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"bounds":{"left":0.08759973,"top":0.45969674,"width":0.08676862,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"bounds":{"left":0.08759973,"top":0.5051876,"width":0.11702128,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.020944148,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"bounds":{"left":0.12450133,"top":0.5981644,"width":0.075465426,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.10305851,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"bounds":{"left":0.10023271,"top":0.6189146,"width":0.08261303,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"bounds":{"left":0.12732713,"top":0.63846767,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.028590426,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.1043883,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"bounds":{"left":0.08759973,"top":0.7709497,"width":0.11702128,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"bounds":{"left":0.08759973,"top":0.7725459,"width":0.05668218,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"bounds":{"left":0.08759973,"top":0.79888266,"width":0.115359046,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"bounds":{"left":0.10023271,"top":0.89066243,"width":0.04870346,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"bounds":{"left":0.11319814,"top":0.9213887,"width":0.025099734,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"bounds":{"left":0.14029256,"top":0.9201915,"width":0.064328454,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"bounds":{"left":0.11319814,"top":0.94213885,"width":0.041888297,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15708111,"top":0.94094175,"width":0.0026595744,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16173537,"top":0.94213885,"width":0.013962766,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.17769282,"top":0.94094175,"width":0.013297873,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.11319814,"top":0.9628891,"width":0.022273935,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.13746676,"top":0.9616919,"width":0.0014960107,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"bounds":{"left":0.11319814,"top":0.99241817,"width":0.022273935,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.13746676,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"bounds":{"left":0.14394946,"top":0.99241817,"width":0.025099734,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.17104389,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"bounds":{"left":0.1775266,"top":0.99241817,"width":0.019448139,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.111203454,"top":0.9912211,"width":0.09042553,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.13547207,"top":1.0,"width":0.013962766,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15142952,"top":1.0,"width":0.0026595744,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.15608378,"top":1.0,"width":0.02244016,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.18051861,"top":1.0,"width":0.013131649,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.025099734,"height":-0.03391862},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"bounds":{"left":0.14029256,"top":1.0,"width":0.013630319,"height":-0.03272152},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.041888297,"height":-0.063447714},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.15708111,"top":1.0,"width":0.024933511,"height":-0.062250614},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.0390625,"height":-0.08419788},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"bounds":{"left":0.15425532,"top":1.0,"width":0.011968086,"height":-0.08300078},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"bounds":{"left":0.09291888,"top":0.8216281,"width":0.10638298,"height":0.01915403},"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"bounds":{"left":0.099567816,"top":0.82202715,"width":0.069980055,"height":0.018355945},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"bounds":{"left":0.091921546,"top":0.8216281,"width":0.0066489363,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"bounds":{"left":0.08892952,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"bounds":{"left":0.10488697,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"bounds":{"left":0.16007313,"top":0.85514766,"width":0.027925532,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"bounds":{"left":0.1653923,"top":0.8639266,"width":0.00930851,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Microphone","depth":19,"bounds":{"left":0.18999335,"top":0.85514766,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Send message","depth":19,"bounds":{"left":0.19630983,"top":0.85434955,"width":0.013962766,"height":0.033519555},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":false,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.","depth":17,"bounds":{"left":0.08510638,"top":0.90901834,"width":0.11951463,"height":0.025139665},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Your privacy & Gemini Opens in a new window","depth":17,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your privacy & Gemini","depth":18,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Opens in a new window","depth":19,"bounds":{"left":0.079288565,"top":0.92098963,"width":0.043218084,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Summarize page","depth":7,"bounds":{"left":0.08494016,"top":0.95730245,"width":0.053523935,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Summarize page","depth":9,"bounds":{"left":0.09059176,"top":0.96249,"width":0.042220745,"height":0.015163607},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"}]...
|
-5523458727026945373
|
8923868658492259784
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page...
|
42420
|
NULL
|
NULL
|
NULL
|
|
42423
|
1556
|
24
|
2026-05-14T11:34:51.223893+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758491223_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-18091 | Update composer to support php 8.5 #12058 Edit title
JY-18091 | Update composer to support php 8.5
#
12058
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5
JY-18091-upgrade-to-php-8-5
Copy head branch name to clipboard
Lines changed: 2199 additions & 3796 deletions
Conversation (3)
Conversation
(
3
)
Commits (10)
Commits
(
10
)
Checks (3)
Checks
(
3
)
Files changed (260)
Files changed
(
260
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-18091 | Update composer to support php 8.5
JY-18091 | Update composer to support php 8.5
#
12058
All commits
All commits
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5
JY-18091-upgrade-to-php-8-5
Copy head branch name to clipboard
11 of 260 files viewed
Checks failing...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.057063047,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.08060654,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.09217877,"width":0.101230055,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"bounds":{"left":0.0028257978,"top":0.11332801,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"bounds":{"left":0.015957447,"top":0.12490024,"width":0.076961435,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"bounds":{"left":0.0028257978,"top":0.14604948,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"bounds":{"left":0.015957447,"top":0.15762171,"width":0.08543883,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"bounds":{"left":0.0028257978,"top":0.17877094,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"bounds":{"left":0.015957447,"top":0.19034317,"width":0.04288564,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"bounds":{"left":0.0028257978,"top":0.21149242,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"bounds":{"left":0.015957447,"top":0.22306465,"width":0.12732713,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"bounds":{"left":0.0028257978,"top":0.2442139,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"bounds":{"left":0.015957447,"top":0.25578612,"width":0.033410903,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.27693537,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.28850758,"width":0.18068483,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"bounds":{"left":0.06732048,"top":0.28411812,"width":0.007978723,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"bounds":{"left":0.0028257978,"top":0.30965683,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"bounds":{"left":0.015957447,"top":0.32122904,"width":0.171875,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.3423783,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.35395053,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"bounds":{"left":0.0,"top":0.37509975,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"bounds":{"left":0.013297873,"top":0.386672,"width":0.029920213,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.41300878,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.4365523,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.4481245,"width":0.06632314,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.46927375,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.48084596,"width":0.064494684,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.5019952,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.51356745,"width":0.15658244,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.53990424,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.5634477,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.57501996,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.5961692,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6077414,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.62889063,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6404629,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.66161215,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.67318434,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.6995211,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.72306466,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.73463684,"width":0.091755316,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.7557861,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.76735836,"width":0.11619016,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.7885076,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.8000798,"width":0.18932846,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.82122904,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.8328013,"width":0.12898937,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.8539505,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.86552274,"width":0.079288565,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"bounds":{"left":0.0,"top":0.88667196,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"bounds":{"left":0.013297873,"top":0.8982442,"width":0.032247342,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0,"top":0.9193935,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.013297873,"top":0.93096566,"width":0.013131649,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.95211494,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.9636871,"width":0.041722074,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.9848364,"width":0.07962101,"height":0.0151636},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.99640864,"width":0.041722074,"height":0.0035913587},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":1.0,"width":0.07962101,"height":-0.01755786},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":1.0,"width":0.041722074,"height":-0.029130101},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.007978723,"height":-0.05546689},"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.07679521,"height":-0.07901037},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":1.0,"width":0.21575798,"height":-0.09058261},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"bounds":{"left":0.0028257978,"top":0.92897046,"width":0.07413564,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"bounds":{"left":0.0028257978,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"bounds":{"left":0.013796543,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"bounds":{"left":0.024933511,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"bounds":{"left":0.036070477,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"bounds":{"left":0.04720745,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"bounds":{"left":0.1846742,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"bounds":{"left":0.1966423,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"bounds":{"left":0.1939827,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"bounds":{"left":0.08361037,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"bounds":{"left":0.16605718,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"bounds":{"left":0.17935506,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"bounds":{"left":0.079288565,"top":0.14764565,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"bounds":{"left":0.079288565,"top":0.15003991,"width":0.1200133,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"bounds":{"left":0.1022274,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"bounds":{"left":0.116855055,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"bounds":{"left":0.13680187,"top":0.19313647,"width":0.051861703,"height":0.09577015},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"bounds":{"left":0.079288565,"top":0.19393456,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"bounds":{"left":0.13680187,"top":0.19473264,"width":0.051861703,"height":0.80526733},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"bounds":{"left":0.13680187,"top":0.30965683,"width":0.05119681,"height":0.188747},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"bounds":{"left":0.18866356,"top":0.19313647,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"bounds":{"left":0.1939827,"top":0.32083002,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"bounds":{"left":0.08460771,"top":0.3519553,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"bounds":{"left":0.08460771,"top":0.35395053,"width":0.04105718,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"bounds":{"left":0.08759973,"top":0.35514766,"width":0.1100399,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"bounds":{"left":0.1427859,"top":0.41739824,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"bounds":{"left":0.1627327,"top":0.41739824,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"bounds":{"left":0.08759973,"top":0.45810056,"width":0.11702128,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"bounds":{"left":0.08759973,"top":0.45969674,"width":0.08676862,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"bounds":{"left":0.08759973,"top":0.5051876,"width":0.11702128,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.020944148,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"bounds":{"left":0.12450133,"top":0.5981644,"width":0.075465426,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.10305851,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"bounds":{"left":0.10023271,"top":0.6189146,"width":0.08261303,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"bounds":{"left":0.12732713,"top":0.63846767,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.028590426,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.1043883,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"bounds":{"left":0.08759973,"top":0.7709497,"width":0.11702128,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"bounds":{"left":0.08759973,"top":0.7725459,"width":0.05668218,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"bounds":{"left":0.08759973,"top":0.79888266,"width":0.115359046,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"bounds":{"left":0.10023271,"top":0.89066243,"width":0.04870346,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"bounds":{"left":0.11319814,"top":0.9213887,"width":0.025099734,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"bounds":{"left":0.14029256,"top":0.9201915,"width":0.064328454,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"bounds":{"left":0.11319814,"top":0.94213885,"width":0.041888297,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15708111,"top":0.94094175,"width":0.0026595744,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16173537,"top":0.94213885,"width":0.013962766,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.17769282,"top":0.94094175,"width":0.013297873,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.11319814,"top":0.9628891,"width":0.022273935,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.13746676,"top":0.9616919,"width":0.0014960107,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"bounds":{"left":0.11319814,"top":0.99241817,"width":0.022273935,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.13746676,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"bounds":{"left":0.14394946,"top":0.99241817,"width":0.025099734,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.17104389,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"bounds":{"left":0.1775266,"top":0.99241817,"width":0.019448139,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.111203454,"top":0.9912211,"width":0.09042553,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.13547207,"top":1.0,"width":0.013962766,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15142952,"top":1.0,"width":0.0026595744,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.15608378,"top":1.0,"width":0.02244016,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.18051861,"top":1.0,"width":0.013131649,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.025099734,"height":-0.03391862},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"bounds":{"left":0.14029256,"top":1.0,"width":0.013630319,"height":-0.03272152},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.041888297,"height":-0.063447714},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.15708111,"top":1.0,"width":0.024933511,"height":-0.062250614},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.0390625,"height":-0.08419788},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"bounds":{"left":0.15425532,"top":1.0,"width":0.011968086,"height":-0.08300078},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"bounds":{"left":0.09291888,"top":0.8216281,"width":0.10638298,"height":0.01915403},"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"bounds":{"left":0.099567816,"top":0.82202715,"width":0.069980055,"height":0.018355945},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"bounds":{"left":0.091921546,"top":0.8216281,"width":0.0066489363,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"bounds":{"left":0.08892952,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"bounds":{"left":0.10488697,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"bounds":{"left":0.16007313,"top":0.85514766,"width":0.027925532,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"bounds":{"left":0.1653923,"top":0.8639266,"width":0.00930851,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Microphone","depth":19,"bounds":{"left":0.18999335,"top":0.85514766,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Send message","depth":19,"bounds":{"left":0.19630983,"top":0.85434955,"width":0.013962766,"height":0.033519555},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":false,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.","depth":17,"bounds":{"left":0.08510638,"top":0.90901834,"width":0.11951463,"height":0.025139665},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Your privacy & Gemini Opens in a new window","depth":17,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your privacy & Gemini","depth":18,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Opens in a new window","depth":19,"bounds":{"left":0.079288565,"top":0.92098963,"width":0.043218084,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Summarize page","depth":7,"bounds":{"left":0.08494016,"top":0.95730245,"width":0.053523935,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Summarize page","depth":9,"bounds":{"left":0.09059176,"top":0.96249,"width":0.042220745,"height":0.015163607},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Skip to content","depth":6,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Skip to content","depth":7,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open menu","depth":10,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"Homepage (g then d)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"jiminny","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"jiminny","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"app","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"app","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Search or jump to…","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Type","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to search","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Chat with Copilot","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Open Copilot…","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXMenuButton","text":"Create new...","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXLink","text":"All issues(g then i)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All pull requests","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All repositories","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"You have unread notifications(g then n)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open user navigation menu","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Repository navigation","depth":9,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Repository navigation","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Code","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Pull requests (29)","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pull requests","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"29","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Agents","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Agents","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Actions","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Actions","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Wiki","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Wiki","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Security and quality","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Security and quality","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Insights","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Insights","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Settings","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Settings","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Important update","depth":10,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Important update","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Review this update","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Review this update","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and manage your preferences in your","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"GitHub account settings","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"GitHub account settings","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Dismiss banner","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"JY-18091 | Update composer to support php 8.5 #12058 Edit title","depth":13,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"#","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"12058","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Edit title","depth":14,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Preview","depth":13,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXStaticText","text":"Preview","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Checks failing","depth":13,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Checks failing","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXMenuButton","text":"Code","depth":13,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXStaticText","text":"Code","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Open","depth":13,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"nikolaybiaivanov","depth":15,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"nikolaybiaivanov","depth":16,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"wants to merge 10 commits into","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"master","depth":15,"on_screen":false,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"master","depth":16,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"from","depth":16,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"JY-18091-upgrade-to-php-8-5","depth":16,"on_screen":false,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-18091-upgrade-to-php-8-5","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy head branch name to clipboard","depth":16,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Lines changed: 2199 additions & 3796 deletions","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Conversation (3)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Conversation","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"3","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Commits (10)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Commits","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"10","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Checks (3)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Checks","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"3","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Files changed (260)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"Files changed","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"260","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Pull Request Toolbar","depth":14,"bounds":{"left":0.22606383,"top":0.075019956,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pull Request Toolbar","depth":15,"bounds":{"left":0.22606383,"top":0.077813245,"width":0.030086435,"height":0.08060654},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Collapse file tree","depth":14,"bounds":{"left":0.22606383,"top":0.06424581,"width":0.00930851,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXStaticText","text":"Open","depth":14,"bounds":{"left":0.2486702,"top":0.06863528,"width":0.011968086,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"JY-18091 | Update composer to support php 8.5","depth":14,"bounds":{"left":0.26728722,"top":0.057462092,"width":0.108211435,"height":0.016759777},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5","depth":16,"bounds":{"left":0.26728722,"top":0.05905826,"width":0.108211435,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"#","depth":15,"bounds":{"left":0.37815824,"top":0.05905826,"width":0.0028257978,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"12058","depth":15,"bounds":{"left":0.38098404,"top":0.05905826,"width":0.013630319,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"All commits","depth":14,"bounds":{"left":0.26462767,"top":0.07102953,"width":0.03374335,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"All commits","depth":16,"bounds":{"left":0.26761967,"top":0.07621708,"width":0.02244016,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"nikolaybiaivanov","depth":15,"bounds":{"left":0.30269283,"top":0.075019956,"width":0.032413565,"height":0.014365523},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"nikolaybiaivanov","depth":16,"bounds":{"left":0.30269283,"top":0.07621708,"width":0.032413565,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"wants to merge 10 commits into","depth":15,"bounds":{"left":0.33643618,"top":0.07621708,"width":0.059840426,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"master","depth":15,"bounds":{"left":0.39760637,"top":0.07342378,"width":0.018450798,"height":0.017557861},"on_screen":true,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"master","depth":16,"bounds":{"left":0.39960107,"top":0.07661612,"width":0.014461436,"height":0.011572227},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"from","depth":16,"bounds":{"left":0.41738698,"top":0.07621708,"width":0.008643617,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"JY-18091-upgrade-to-php-8-5","depth":16,"bounds":{"left":0.4273604,"top":0.07342378,"width":0.06881649,"height":0.017557861},"on_screen":true,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-18091-upgrade-to-php-8-5","depth":17,"bounds":{"left":0.42935506,"top":0.07661612,"width":0.06482713,"height":0.011572227},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy head branch name to clipboard","depth":16,"bounds":{"left":0.49750665,"top":0.07102953,"width":0.00930851,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"11 of 260 files viewed","depth":15,"bounds":{"left":0.81632316,"top":0.07661612,"width":0.01512633,"height":0.08060654},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Checks failing","depth":14,"bounds":{"left":0.86053854,"top":0.06424581,"width":0.03956117,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false}]...
|
-3846450801814892544
|
8923868658492259784
|
visual_change
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-18091 | Update composer to support php 8.5 #12058 Edit title
JY-18091 | Update composer to support php 8.5
#
12058
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5
JY-18091-upgrade-to-php-8-5
Copy head branch name to clipboard
Lines changed: 2199 additions & 3796 deletions
Conversation (3)
Conversation
(
3
)
Commits (10)
Commits
(
10
)
Checks (3)
Checks
(
3
)
Files changed (260)
Files changed
(
260
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-18091 | Update composer to support php 8.5
JY-18091 | Update composer to support php 8.5
#
12058
All commits
All commits
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5
JY-18091-upgrade-to-php-8-5
Copy head branch name to clipboard
11 of 260 files viewed
Checks failing...
|
NULL
|
NULL
|
NULL
|
NULL
|
|
42424
|
1555
|
33
|
2026-05-14T11:34:51.360646+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758491360_m1.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_1
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Microphone","depth":19,"on_screen":true,"role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Send message","depth":19,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":false,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.","depth":17,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Your privacy & Gemini Opens in a new window","depth":17,"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your privacy & Gemini","depth":18,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Opens in a new window","depth":19,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Summarize page","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Summarize page","depth":9,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Skip to content","depth":6,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Skip to content","depth":7,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open menu","depth":10,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"Homepage (g then d)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"jiminny","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"jiminny","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"app","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"app","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Search or jump to…","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Type","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to search","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Chat with Copilot","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Open Copilot…","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXMenuButton","text":"Create new...","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXLink","text":"All issues(g then i)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All pull requests","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All repositories","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"You have unread notifications(g then n)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open user navigation menu","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Repository navigation","depth":9,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Repository navigation","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Code","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Pull requests (29)","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pull requests","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"29","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Agents","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Agents","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Actions","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Actions","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Wiki","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Wiki","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Security and quality","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Security and quality","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Insights","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Insights","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Settings","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Settings","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Important update","depth":10,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Important update","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Review this update","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false}]...
|
-5353545804204936023
|
4312182640064871880
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update...
|
42421
|
NULL
|
NULL
|
NULL
|
|
42425
|
1555
|
34
|
2026-05-14T11:34:52.511247+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758492511_m1.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_1
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"}]...
|
-5909908912783185705
|
8923867554677276104
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery...
|
NULL
|
NULL
|
NULL
|
NULL
|
|
42426
|
1556
|
25
|
2026-05-14T11:34:52.556112+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758492556_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.057063047,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.08060654,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.09217877,"width":0.101230055,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"bounds":{"left":0.0028257978,"top":0.11332801,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"bounds":{"left":0.015957447,"top":0.12490024,"width":0.076961435,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"bounds":{"left":0.0028257978,"top":0.14604948,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"bounds":{"left":0.015957447,"top":0.15762171,"width":0.08543883,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"bounds":{"left":0.0028257978,"top":0.17877094,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"bounds":{"left":0.015957447,"top":0.19034317,"width":0.04288564,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"bounds":{"left":0.0028257978,"top":0.21149242,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"bounds":{"left":0.015957447,"top":0.22306465,"width":0.12732713,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"bounds":{"left":0.0028257978,"top":0.2442139,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"bounds":{"left":0.015957447,"top":0.25578612,"width":0.033410903,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.27693537,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.28850758,"width":0.18068483,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"bounds":{"left":0.06732048,"top":0.28411812,"width":0.007978723,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"bounds":{"left":0.0028257978,"top":0.30965683,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"bounds":{"left":0.015957447,"top":0.32122904,"width":0.171875,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.3423783,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.35395053,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"bounds":{"left":0.0,"top":0.37509975,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"bounds":{"left":0.013297873,"top":0.386672,"width":0.029920213,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.41300878,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.4365523,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.4481245,"width":0.06632314,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.46927375,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.48084596,"width":0.064494684,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.5019952,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.51356745,"width":0.15658244,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.53990424,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.5634477,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.57501996,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.5961692,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6077414,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.62889063,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6404629,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.66161215,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.67318434,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.6995211,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.72306466,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.73463684,"width":0.091755316,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.7557861,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.76735836,"width":0.11619016,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.7885076,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.8000798,"width":0.18932846,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.82122904,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.8328013,"width":0.12898937,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.8539505,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.86552274,"width":0.079288565,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"bounds":{"left":0.0,"top":0.88667196,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"bounds":{"left":0.013297873,"top":0.8982442,"width":0.032247342,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0,"top":0.9193935,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.013297873,"top":0.93096566,"width":0.013131649,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.95211494,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.9636871,"width":0.041722074,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.9848364,"width":0.07962101,"height":0.0151636},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.99640864,"width":0.041722074,"height":0.0035913587},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":1.0,"width":0.07962101,"height":-0.01755786},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":1.0,"width":0.041722074,"height":-0.029130101},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.007978723,"height":-0.05546689},"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.07679521,"height":-0.07901037},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":1.0,"width":0.21575798,"height":-0.09058261},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"bounds":{"left":0.0028257978,"top":0.92897046,"width":0.07413564,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"bounds":{"left":0.0028257978,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"bounds":{"left":0.013796543,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"bounds":{"left":0.024933511,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"bounds":{"left":0.036070477,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"bounds":{"left":0.04720745,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"bounds":{"left":0.1846742,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"bounds":{"left":0.1966423,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"bounds":{"left":0.1939827,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"bounds":{"left":0.08361037,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"bounds":{"left":0.16605718,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"bounds":{"left":0.17935506,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"bounds":{"left":0.079288565,"top":0.14764565,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"bounds":{"left":0.079288565,"top":0.15003991,"width":0.1200133,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"bounds":{"left":0.1022274,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"bounds":{"left":0.116855055,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"bounds":{"left":0.13680187,"top":0.19313647,"width":0.051861703,"height":0.09577015},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"bounds":{"left":0.079288565,"top":0.19393456,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"bounds":{"left":0.13680187,"top":0.19473264,"width":0.051861703,"height":0.80526733},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"bounds":{"left":0.13680187,"top":0.30965683,"width":0.05119681,"height":0.188747},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"bounds":{"left":0.18866356,"top":0.19313647,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"bounds":{"left":0.1939827,"top":0.32083002,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"bounds":{"left":0.08460771,"top":0.3519553,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"bounds":{"left":0.08460771,"top":0.35395053,"width":0.04105718,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"bounds":{"left":0.08759973,"top":0.35514766,"width":0.1100399,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"bounds":{"left":0.1427859,"top":0.41739824,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"bounds":{"left":0.1627327,"top":0.41739824,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"bounds":{"left":0.08759973,"top":0.45810056,"width":0.11702128,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"bounds":{"left":0.08759973,"top":0.45969674,"width":0.08676862,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"bounds":{"left":0.08759973,"top":0.5051876,"width":0.11702128,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.020944148,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"bounds":{"left":0.12450133,"top":0.5981644,"width":0.075465426,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.10305851,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"bounds":{"left":0.10023271,"top":0.6189146,"width":0.08261303,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"bounds":{"left":0.12732713,"top":0.63846767,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.028590426,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.1043883,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"bounds":{"left":0.08759973,"top":0.7709497,"width":0.11702128,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"bounds":{"left":0.08759973,"top":0.7725459,"width":0.05668218,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"bounds":{"left":0.08759973,"top":0.79888266,"width":0.115359046,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"bounds":{"left":0.10023271,"top":0.89066243,"width":0.04870346,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"bounds":{"left":0.11319814,"top":0.9213887,"width":0.025099734,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"bounds":{"left":0.14029256,"top":0.9201915,"width":0.064328454,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"bounds":{"left":0.11319814,"top":0.94213885,"width":0.041888297,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15708111,"top":0.94094175,"width":0.0026595744,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16173537,"top":0.94213885,"width":0.013962766,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.17769282,"top":0.94094175,"width":0.013297873,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.11319814,"top":0.9628891,"width":0.022273935,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.13746676,"top":0.9616919,"width":0.0014960107,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"bounds":{"left":0.11319814,"top":0.99241817,"width":0.022273935,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.13746676,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"bounds":{"left":0.14394946,"top":0.99241817,"width":0.025099734,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.17104389,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"bounds":{"left":0.1775266,"top":0.99241817,"width":0.019448139,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.111203454,"top":0.9912211,"width":0.09042553,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.13547207,"top":1.0,"width":0.013962766,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15142952,"top":1.0,"width":0.0026595744,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.15608378,"top":1.0,"width":0.02244016,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.18051861,"top":1.0,"width":0.013131649,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.025099734,"height":-0.03391862},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"bounds":{"left":0.14029256,"top":1.0,"width":0.013630319,"height":-0.03272152},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.041888297,"height":-0.063447714},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.15708111,"top":1.0,"width":0.024933511,"height":-0.062250614},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.0390625,"height":-0.08419788},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"bounds":{"left":0.15425532,"top":1.0,"width":0.011968086,"height":-0.08300078},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"}]...
|
-4163444141459784656
|
8923867554677276104
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse...
|
42423
|
NULL
|
NULL
|
NULL
|
|
42427
|
1555
|
35
|
2026-05-14T11:34:53.772297+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758493772_m1.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_1
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Microphone","depth":19,"on_screen":true,"role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Send message","depth":19,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":false,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.","depth":17,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Your privacy & Gemini Opens in a new window","depth":17,"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your privacy & Gemini","depth":18,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Opens in a new window","depth":19,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Summarize page","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false}]...
|
-1542418888374724158
|
8923868658492259784
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page...
|
42425
|
NULL
|
NULL
|
NULL
|
|
42428
|
1556
|
26
|
2026-05-14T11:34:53.798367+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758493798_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.057063047,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.08060654,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.09217877,"width":0.101230055,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"bounds":{"left":0.0028257978,"top":0.11332801,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"bounds":{"left":0.015957447,"top":0.12490024,"width":0.076961435,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"bounds":{"left":0.0028257978,"top":0.14604948,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"bounds":{"left":0.015957447,"top":0.15762171,"width":0.08543883,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"bounds":{"left":0.0028257978,"top":0.17877094,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"bounds":{"left":0.015957447,"top":0.19034317,"width":0.04288564,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"bounds":{"left":0.0028257978,"top":0.21149242,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"bounds":{"left":0.015957447,"top":0.22306465,"width":0.12732713,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"bounds":{"left":0.0028257978,"top":0.2442139,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"bounds":{"left":0.015957447,"top":0.25578612,"width":0.033410903,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.27693537,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.28850758,"width":0.18068483,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"bounds":{"left":0.06732048,"top":0.28411812,"width":0.007978723,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"bounds":{"left":0.0028257978,"top":0.30965683,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"bounds":{"left":0.015957447,"top":0.32122904,"width":0.171875,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.3423783,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.35395053,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"bounds":{"left":0.0,"top":0.37509975,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"bounds":{"left":0.013297873,"top":0.386672,"width":0.029920213,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.41300878,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.4365523,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.4481245,"width":0.06632314,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.46927375,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.48084596,"width":0.064494684,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.5019952,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.51356745,"width":0.15658244,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.53990424,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.5634477,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.57501996,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.5961692,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6077414,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.62889063,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6404629,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.66161215,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.67318434,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.6995211,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.72306466,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.73463684,"width":0.091755316,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.7557861,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.76735836,"width":0.11619016,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.7885076,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.8000798,"width":0.18932846,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.82122904,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.8328013,"width":0.12898937,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.8539505,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.86552274,"width":0.079288565,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"bounds":{"left":0.0,"top":0.88667196,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"bounds":{"left":0.013297873,"top":0.8982442,"width":0.032247342,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0,"top":0.9193935,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.013297873,"top":0.93096566,"width":0.013131649,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.95211494,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.9636871,"width":0.041722074,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.9848364,"width":0.07962101,"height":0.0151636},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.99640864,"width":0.041722074,"height":0.0035913587},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":1.0,"width":0.07962101,"height":-0.01755786},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":1.0,"width":0.041722074,"height":-0.029130101},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.007978723,"height":-0.05546689},"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.07679521,"height":-0.07901037},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":1.0,"width":0.21575798,"height":-0.09058261},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"bounds":{"left":0.0028257978,"top":0.92897046,"width":0.07413564,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"bounds":{"left":0.0028257978,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"bounds":{"left":0.013796543,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"bounds":{"left":0.024933511,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"bounds":{"left":0.036070477,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"bounds":{"left":0.04720745,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"bounds":{"left":0.1846742,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"bounds":{"left":0.1966423,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"bounds":{"left":0.1939827,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"bounds":{"left":0.08361037,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"bounds":{"left":0.16605718,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"bounds":{"left":0.17935506,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"bounds":{"left":0.079288565,"top":0.14764565,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"bounds":{"left":0.079288565,"top":0.15003991,"width":0.1200133,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"bounds":{"left":0.1022274,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"bounds":{"left":0.116855055,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"bounds":{"left":0.13680187,"top":0.19313647,"width":0.051861703,"height":0.09577015},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"bounds":{"left":0.079288565,"top":0.19393456,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"bounds":{"left":0.13680187,"top":0.19473264,"width":0.051861703,"height":0.80526733},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"bounds":{"left":0.13680187,"top":0.30965683,"width":0.05119681,"height":0.188747},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"bounds":{"left":0.18866356,"top":0.19313647,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"bounds":{"left":0.1939827,"top":0.32083002,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"bounds":{"left":0.08460771,"top":0.3519553,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"bounds":{"left":0.08460771,"top":0.35395053,"width":0.04105718,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"bounds":{"left":0.08759973,"top":0.35514766,"width":0.1100399,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"bounds":{"left":0.1427859,"top":0.41739824,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"bounds":{"left":0.1627327,"top":0.41739824,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"bounds":{"left":0.08759973,"top":0.45810056,"width":0.11702128,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"bounds":{"left":0.08759973,"top":0.45969674,"width":0.08676862,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"bounds":{"left":0.08759973,"top":0.5051876,"width":0.11702128,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.020944148,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"bounds":{"left":0.12450133,"top":0.5981644,"width":0.075465426,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.10305851,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"bounds":{"left":0.10023271,"top":0.6189146,"width":0.08261303,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"bounds":{"left":0.12732713,"top":0.63846767,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.028590426,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.1043883,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"bounds":{"left":0.08759973,"top":0.7709497,"width":0.11702128,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"bounds":{"left":0.08759973,"top":0.7725459,"width":0.05668218,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"bounds":{"left":0.08759973,"top":0.79888266,"width":0.115359046,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"bounds":{"left":0.10023271,"top":0.89066243,"width":0.04870346,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"bounds":{"left":0.11319814,"top":0.9213887,"width":0.025099734,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"bounds":{"left":0.14029256,"top":0.9201915,"width":0.064328454,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"bounds":{"left":0.11319814,"top":0.94213885,"width":0.041888297,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15708111,"top":0.94094175,"width":0.0026595744,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16173537,"top":0.94213885,"width":0.013962766,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.17769282,"top":0.94094175,"width":0.013297873,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.11319814,"top":0.9628891,"width":0.022273935,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.13746676,"top":0.9616919,"width":0.0014960107,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"bounds":{"left":0.11319814,"top":0.99241817,"width":0.022273935,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.13746676,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"bounds":{"left":0.14394946,"top":0.99241817,"width":0.025099734,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.17104389,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"bounds":{"left":0.1775266,"top":0.99241817,"width":0.019448139,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.111203454,"top":0.9912211,"width":0.09042553,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.13547207,"top":1.0,"width":0.013962766,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15142952,"top":1.0,"width":0.0026595744,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.15608378,"top":1.0,"width":0.02244016,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.18051861,"top":1.0,"width":0.013131649,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.025099734,"height":-0.03391862},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"bounds":{"left":0.14029256,"top":1.0,"width":0.013630319,"height":-0.03272152},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.041888297,"height":-0.063447714},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.15708111,"top":1.0,"width":0.024933511,"height":-0.062250614},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.0390625,"height":-0.08419788},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"bounds":{"left":0.15425532,"top":1.0,"width":0.011968086,"height":-0.08300078},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"bounds":{"left":0.09291888,"top":0.8216281,"width":0.10638298,"height":0.01915403},"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"bounds":{"left":0.099567816,"top":0.82202715,"width":0.069980055,"height":0.018355945},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"bounds":{"left":0.091921546,"top":0.8216281,"width":0.0066489363,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"bounds":{"left":0.08892952,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"bounds":{"left":0.10488697,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"bounds":{"left":0.16007313,"top":0.85514766,"width":0.027925532,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"bounds":{"left":0.1653923,"top":0.8639266,"width":0.00930851,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"}]...
|
1759860134477698640
|
8923867558972243400
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast...
|
NULL
|
NULL
|
NULL
|
NULL
|
|
42429
|
1555
|
36
|
2026-05-14T11:34:54.933719+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758494933_m1.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_1
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Microphone","depth":19,"on_screen":true,"role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Send message","depth":19,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":false,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.","depth":17,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Your privacy & Gemini Opens in a new window","depth":17,"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your privacy & Gemini","depth":18,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Opens in a new window","depth":19,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Summarize page","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Summarize page","depth":9,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Skip to content","depth":6,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Skip to content","depth":7,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open menu","depth":10,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"Homepage (g then d)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"jiminny","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"jiminny","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"app","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"app","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"}]...
|
-4029773446015648167
|
4312182640064871880
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app...
|
NULL
|
NULL
|
NULL
|
NULL
|
|
42430
|
1556
|
27
|
2026-05-14T11:34:54.933737+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758494933_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new......
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.057063047,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.08060654,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.09217877,"width":0.101230055,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"bounds":{"left":0.0028257978,"top":0.11332801,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"bounds":{"left":0.015957447,"top":0.12490024,"width":0.076961435,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"bounds":{"left":0.0028257978,"top":0.14604948,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"bounds":{"left":0.015957447,"top":0.15762171,"width":0.08543883,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"bounds":{"left":0.0028257978,"top":0.17877094,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"bounds":{"left":0.015957447,"top":0.19034317,"width":0.04288564,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"bounds":{"left":0.0028257978,"top":0.21149242,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"bounds":{"left":0.015957447,"top":0.22306465,"width":0.12732713,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"bounds":{"left":0.0028257978,"top":0.2442139,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"bounds":{"left":0.015957447,"top":0.25578612,"width":0.033410903,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.27693537,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.28850758,"width":0.18068483,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"bounds":{"left":0.06732048,"top":0.28411812,"width":0.007978723,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"bounds":{"left":0.0028257978,"top":0.30965683,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"bounds":{"left":0.015957447,"top":0.32122904,"width":0.171875,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.3423783,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.35395053,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"bounds":{"left":0.0,"top":0.37509975,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"bounds":{"left":0.013297873,"top":0.386672,"width":0.029920213,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.41300878,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.4365523,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.4481245,"width":0.06632314,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.46927375,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.48084596,"width":0.064494684,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.5019952,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.51356745,"width":0.15658244,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.53990424,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.5634477,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.57501996,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.5961692,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6077414,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.62889063,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6404629,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.66161215,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.67318434,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.6995211,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.72306466,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.73463684,"width":0.091755316,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.7557861,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.76735836,"width":0.11619016,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.7885076,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.8000798,"width":0.18932846,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.82122904,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.8328013,"width":0.12898937,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.8539505,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.86552274,"width":0.079288565,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"bounds":{"left":0.0,"top":0.88667196,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"bounds":{"left":0.013297873,"top":0.8982442,"width":0.032247342,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0,"top":0.9193935,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.013297873,"top":0.93096566,"width":0.013131649,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.95211494,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.9636871,"width":0.041722074,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.9848364,"width":0.07962101,"height":0.0151636},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.99640864,"width":0.041722074,"height":0.0035913587},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":1.0,"width":0.07962101,"height":-0.01755786},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":1.0,"width":0.041722074,"height":-0.029130101},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.007978723,"height":-0.05546689},"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.07679521,"height":-0.07901037},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":1.0,"width":0.21575798,"height":-0.09058261},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"bounds":{"left":0.0028257978,"top":0.92897046,"width":0.07413564,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"bounds":{"left":0.0028257978,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"bounds":{"left":0.013796543,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"bounds":{"left":0.024933511,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"bounds":{"left":0.036070477,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"bounds":{"left":0.04720745,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"bounds":{"left":0.1846742,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"bounds":{"left":0.1966423,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"bounds":{"left":0.1939827,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"bounds":{"left":0.08361037,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"bounds":{"left":0.16605718,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"bounds":{"left":0.17935506,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"bounds":{"left":0.079288565,"top":0.14764565,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"bounds":{"left":0.079288565,"top":0.15003991,"width":0.1200133,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"bounds":{"left":0.1022274,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"bounds":{"left":0.116855055,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"bounds":{"left":0.13680187,"top":0.19313647,"width":0.051861703,"height":0.09577015},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"bounds":{"left":0.079288565,"top":0.19393456,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"bounds":{"left":0.13680187,"top":0.19473264,"width":0.051861703,"height":0.80526733},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"bounds":{"left":0.13680187,"top":0.30965683,"width":0.05119681,"height":0.188747},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"bounds":{"left":0.18866356,"top":0.19313647,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"bounds":{"left":0.1939827,"top":0.32083002,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"bounds":{"left":0.08460771,"top":0.3519553,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"bounds":{"left":0.08460771,"top":0.35395053,"width":0.04105718,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"bounds":{"left":0.08759973,"top":0.35514766,"width":0.1100399,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"bounds":{"left":0.1427859,"top":0.41739824,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"bounds":{"left":0.1627327,"top":0.41739824,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"bounds":{"left":0.08759973,"top":0.45810056,"width":0.11702128,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"bounds":{"left":0.08759973,"top":0.45969674,"width":0.08676862,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"bounds":{"left":0.08759973,"top":0.5051876,"width":0.11702128,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.020944148,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"bounds":{"left":0.12450133,"top":0.5981644,"width":0.075465426,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.10305851,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"bounds":{"left":0.10023271,"top":0.6189146,"width":0.08261303,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"bounds":{"left":0.12732713,"top":0.63846767,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.028590426,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.1043883,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"bounds":{"left":0.08759973,"top":0.7709497,"width":0.11702128,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"bounds":{"left":0.08759973,"top":0.7725459,"width":0.05668218,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"bounds":{"left":0.08759973,"top":0.79888266,"width":0.115359046,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"bounds":{"left":0.10023271,"top":0.89066243,"width":0.04870346,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"bounds":{"left":0.11319814,"top":0.9213887,"width":0.025099734,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"bounds":{"left":0.14029256,"top":0.9201915,"width":0.064328454,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"bounds":{"left":0.11319814,"top":0.94213885,"width":0.041888297,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15708111,"top":0.94094175,"width":0.0026595744,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16173537,"top":0.94213885,"width":0.013962766,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.17769282,"top":0.94094175,"width":0.013297873,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.11319814,"top":0.9628891,"width":0.022273935,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.13746676,"top":0.9616919,"width":0.0014960107,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"bounds":{"left":0.11319814,"top":0.99241817,"width":0.022273935,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.13746676,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"bounds":{"left":0.14394946,"top":0.99241817,"width":0.025099734,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.17104389,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"bounds":{"left":0.1775266,"top":0.99241817,"width":0.019448139,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.111203454,"top":0.9912211,"width":0.09042553,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.13547207,"top":1.0,"width":0.013962766,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15142952,"top":1.0,"width":0.0026595744,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.15608378,"top":1.0,"width":0.02244016,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.18051861,"top":1.0,"width":0.013131649,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.025099734,"height":-0.03391862},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"bounds":{"left":0.14029256,"top":1.0,"width":0.013630319,"height":-0.03272152},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.041888297,"height":-0.063447714},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.15708111,"top":1.0,"width":0.024933511,"height":-0.062250614},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.0390625,"height":-0.08419788},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"bounds":{"left":0.15425532,"top":1.0,"width":0.011968086,"height":-0.08300078},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"bounds":{"left":0.09291888,"top":0.8216281,"width":0.10638298,"height":0.01915403},"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"bounds":{"left":0.099567816,"top":0.82202715,"width":0.069980055,"height":0.018355945},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"bounds":{"left":0.091921546,"top":0.8216281,"width":0.0066489363,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"bounds":{"left":0.08892952,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"bounds":{"left":0.10488697,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"bounds":{"left":0.16007313,"top":0.85514766,"width":0.027925532,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"bounds":{"left":0.1653923,"top":0.8639266,"width":0.00930851,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Microphone","depth":19,"bounds":{"left":0.18999335,"top":0.85514766,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Send message","depth":19,"bounds":{"left":0.19630983,"top":0.85434955,"width":0.013962766,"height":0.033519555},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":false,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.","depth":17,"bounds":{"left":0.08510638,"top":0.90901834,"width":0.11951463,"height":0.025139665},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Your privacy & Gemini Opens in a new window","depth":17,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your privacy & Gemini","depth":18,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Opens in a new window","depth":19,"bounds":{"left":0.079288565,"top":0.92098963,"width":0.043218084,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Summarize page","depth":7,"bounds":{"left":0.08494016,"top":0.95730245,"width":0.053523935,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Summarize page","depth":9,"bounds":{"left":0.09059176,"top":0.96249,"width":0.042220745,"height":0.015163607},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Skip to content","depth":6,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Skip to content","depth":7,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open menu","depth":10,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"Homepage (g then d)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"jiminny","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"jiminny","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"app","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"app","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Search or jump to…","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Type","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to search","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Chat with Copilot","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Open Copilot…","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXMenuButton","text":"Create new...","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false}]...
|
-4744626393294164789
|
4312182640064871880
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new......
|
42428
|
NULL
|
NULL
|
NULL
|
|
42431
|
1555
|
37
|
2026-05-14T11:34:56.437119+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758496437_m1.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_1
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
....
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"}]...
|
7933594826044215142
|
8923867554677276104
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
....
|
42429
|
NULL
|
NULL
|
NULL
|
|
42432
|
1556
|
28
|
2026-05-14T11:34:56.440587+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758496440_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions....
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.057063047,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.08060654,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.09217877,"width":0.101230055,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"bounds":{"left":0.0028257978,"top":0.11332801,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"bounds":{"left":0.015957447,"top":0.12490024,"width":0.076961435,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"bounds":{"left":0.0028257978,"top":0.14604948,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"bounds":{"left":0.015957447,"top":0.15762171,"width":0.08543883,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"bounds":{"left":0.0028257978,"top":0.17877094,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"bounds":{"left":0.015957447,"top":0.19034317,"width":0.04288564,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"bounds":{"left":0.0028257978,"top":0.21149242,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"bounds":{"left":0.015957447,"top":0.22306465,"width":0.12732713,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"bounds":{"left":0.0028257978,"top":0.2442139,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"bounds":{"left":0.015957447,"top":0.25578612,"width":0.033410903,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.27693537,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.28850758,"width":0.18068483,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"bounds":{"left":0.06732048,"top":0.28411812,"width":0.007978723,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"bounds":{"left":0.0028257978,"top":0.30965683,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"bounds":{"left":0.015957447,"top":0.32122904,"width":0.171875,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.3423783,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.35395053,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"bounds":{"left":0.0,"top":0.37509975,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"bounds":{"left":0.013297873,"top":0.386672,"width":0.029920213,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.41300878,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.4365523,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.4481245,"width":0.06632314,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.46927375,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.48084596,"width":0.064494684,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.5019952,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.51356745,"width":0.15658244,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.53990424,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.5634477,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.57501996,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.5961692,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6077414,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.62889063,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6404629,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.66161215,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.67318434,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.6995211,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.72306466,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.73463684,"width":0.091755316,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.7557861,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.76735836,"width":0.11619016,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.7885076,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.8000798,"width":0.18932846,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.82122904,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.8328013,"width":0.12898937,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.8539505,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.86552274,"width":0.079288565,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"bounds":{"left":0.0,"top":0.88667196,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"bounds":{"left":0.013297873,"top":0.8982442,"width":0.032247342,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0,"top":0.9193935,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.013297873,"top":0.93096566,"width":0.013131649,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.95211494,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.9636871,"width":0.041722074,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.9848364,"width":0.07962101,"height":0.0151636},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.99640864,"width":0.041722074,"height":0.0035913587},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":1.0,"width":0.07962101,"height":-0.01755786},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":1.0,"width":0.041722074,"height":-0.029130101},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.007978723,"height":-0.05546689},"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.07679521,"height":-0.07901037},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":1.0,"width":0.21575798,"height":-0.09058261},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"bounds":{"left":0.0028257978,"top":0.92897046,"width":0.07413564,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"bounds":{"left":0.0028257978,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"bounds":{"left":0.013796543,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"bounds":{"left":0.024933511,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"bounds":{"left":0.036070477,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"bounds":{"left":0.04720745,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"bounds":{"left":0.1846742,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"bounds":{"left":0.1966423,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"bounds":{"left":0.1939827,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"bounds":{"left":0.08361037,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"bounds":{"left":0.16605718,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"bounds":{"left":0.17935506,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"bounds":{"left":0.079288565,"top":0.14764565,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"bounds":{"left":0.079288565,"top":0.15003991,"width":0.1200133,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"bounds":{"left":0.1022274,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"bounds":{"left":0.116855055,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"bounds":{"left":0.13680187,"top":0.19313647,"width":0.051861703,"height":0.09577015},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"bounds":{"left":0.079288565,"top":0.19393456,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"bounds":{"left":0.13680187,"top":0.19473264,"width":0.051861703,"height":0.80526733},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"bounds":{"left":0.13680187,"top":0.30965683,"width":0.05119681,"height":0.188747},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"bounds":{"left":0.18866356,"top":0.19313647,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"bounds":{"left":0.1939827,"top":0.32083002,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"bounds":{"left":0.08460771,"top":0.3519553,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"bounds":{"left":0.08460771,"top":0.35395053,"width":0.04105718,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"bounds":{"left":0.08759973,"top":0.35514766,"width":0.1100399,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"bounds":{"left":0.1427859,"top":0.41739824,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"bounds":{"left":0.1627327,"top":0.41739824,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"bounds":{"left":0.08759973,"top":0.45810056,"width":0.11702128,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"bounds":{"left":0.08759973,"top":0.45969674,"width":0.08676862,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"bounds":{"left":0.08759973,"top":0.5051876,"width":0.11702128,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.020944148,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"bounds":{"left":0.12450133,"top":0.5981644,"width":0.075465426,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.10305851,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"bounds":{"left":0.10023271,"top":0.6189146,"width":0.08261303,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"bounds":{"left":0.12732713,"top":0.63846767,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.028590426,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.1043883,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"bounds":{"left":0.08759973,"top":0.7709497,"width":0.11702128,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"bounds":{"left":0.08759973,"top":0.7725459,"width":0.05668218,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"bounds":{"left":0.08759973,"top":0.79888266,"width":0.115359046,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"bounds":{"left":0.10023271,"top":0.89066243,"width":0.04870346,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"bounds":{"left":0.11319814,"top":0.9213887,"width":0.025099734,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"bounds":{"left":0.14029256,"top":0.9201915,"width":0.064328454,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"bounds":{"left":0.11319814,"top":0.94213885,"width":0.041888297,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15708111,"top":0.94094175,"width":0.0026595744,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16173537,"top":0.94213885,"width":0.013962766,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.17769282,"top":0.94094175,"width":0.013297873,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.11319814,"top":0.9628891,"width":0.022273935,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.13746676,"top":0.9616919,"width":0.0014960107,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"bounds":{"left":0.11319814,"top":0.99241817,"width":0.022273935,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.13746676,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"bounds":{"left":0.14394946,"top":0.99241817,"width":0.025099734,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.17104389,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"bounds":{"left":0.1775266,"top":0.99241817,"width":0.019448139,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.111203454,"top":0.9912211,"width":0.09042553,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.13547207,"top":1.0,"width":0.013962766,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15142952,"top":1.0,"width":0.0026595744,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.15608378,"top":1.0,"width":0.02244016,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.18051861,"top":1.0,"width":0.013131649,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.025099734,"height":-0.03391862},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"bounds":{"left":0.14029256,"top":1.0,"width":0.013630319,"height":-0.03272152},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.041888297,"height":-0.063447714},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.15708111,"top":1.0,"width":0.024933511,"height":-0.062250614},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.0390625,"height":-0.08419788},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"bounds":{"left":0.15425532,"top":1.0,"width":0.011968086,"height":-0.08300078},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"}]...
|
8607839047669418710
|
8923867554677276104
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions....
|
NULL
|
NULL
|
NULL
|
NULL
|
|
42433
|
1556
|
29
|
2026-05-14T11:34:57.514333+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758497514_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-18091 | Update composer to support php 8.5 #12058 Edit title
JY-18091 | Update composer to support php 8.5
#
12058
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5
JY-18091-upgrade-to-php-8-5
Copy head branch name to clipboard
Lines changed: 2199 additions & 3796 deletions
Conversation (3)
Conversation
(
3
)
Commits (10)
Commits
(
10
)
Checks (3)
Checks
(
3
)
Files changed (260)
Files changed
(
260
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-18091 | Update composer to support php 8.5
JY-18091 | Update composer to support php 8.5
#
12058
All commits
All commits
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5
JY-18091-upgrade-to-php-8-5
Copy head branch name to clipboard
16 of 260 files viewed
Checks failing
Checks failing
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
.circleci
config_continue.yml
config_continue.yml
app
Component
ActionItems/Notifications
ActionItemsNotification.php
ActionItemsNotification.php
ActivityAnalytics/Service
TopicTriggerService.php
TopicTriggerService.php
ActivitySearch
FilterDefinition
Security
PrivateMeetingsForCurrentUserOnly.php
RestrictPublicActivitiesOnly.php
RestrictTeam.php...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.057063047,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.08060654,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.09217877,"width":0.101230055,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"bounds":{"left":0.0028257978,"top":0.11332801,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"bounds":{"left":0.015957447,"top":0.12490024,"width":0.076961435,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"bounds":{"left":0.0028257978,"top":0.14604948,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"bounds":{"left":0.015957447,"top":0.15762171,"width":0.08543883,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"bounds":{"left":0.0028257978,"top":0.17877094,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"bounds":{"left":0.015957447,"top":0.19034317,"width":0.04288564,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"bounds":{"left":0.0028257978,"top":0.21149242,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"bounds":{"left":0.015957447,"top":0.22306465,"width":0.12732713,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"bounds":{"left":0.0028257978,"top":0.2442139,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"bounds":{"left":0.015957447,"top":0.25578612,"width":0.033410903,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.27693537,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.28850758,"width":0.18068483,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"bounds":{"left":0.06732048,"top":0.28411812,"width":0.007978723,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"bounds":{"left":0.0028257978,"top":0.30965683,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"bounds":{"left":0.015957447,"top":0.32122904,"width":0.171875,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.3423783,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.35395053,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"bounds":{"left":0.0,"top":0.37509975,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"bounds":{"left":0.013297873,"top":0.386672,"width":0.029920213,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.41300878,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.4365523,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.4481245,"width":0.06632314,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.46927375,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.48084596,"width":0.064494684,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.5019952,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.51356745,"width":0.15658244,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.53990424,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.5634477,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.57501996,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.5961692,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6077414,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.62889063,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6404629,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.66161215,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.67318434,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.6995211,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.72306466,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.73463684,"width":0.091755316,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.7557861,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.76735836,"width":0.11619016,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.7885076,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.8000798,"width":0.18932846,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.82122904,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.8328013,"width":0.12898937,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.8539505,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.86552274,"width":0.079288565,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"bounds":{"left":0.0,"top":0.88667196,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"bounds":{"left":0.013297873,"top":0.8982442,"width":0.032247342,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0,"top":0.9193935,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.013297873,"top":0.93096566,"width":0.013131649,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.95211494,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.9636871,"width":0.041722074,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.9848364,"width":0.07962101,"height":0.0151636},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.99640864,"width":0.041722074,"height":0.0035913587},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":1.0,"width":0.07962101,"height":-0.01755786},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":1.0,"width":0.041722074,"height":-0.029130101},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.007978723,"height":-0.05546689},"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.07679521,"height":-0.07901037},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":1.0,"width":0.21575798,"height":-0.09058261},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"bounds":{"left":0.0028257978,"top":0.92897046,"width":0.07413564,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"bounds":{"left":0.0028257978,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"bounds":{"left":0.013796543,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"bounds":{"left":0.024933511,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"bounds":{"left":0.036070477,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"bounds":{"left":0.04720745,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"bounds":{"left":0.1846742,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"bounds":{"left":0.1966423,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"bounds":{"left":0.1939827,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"bounds":{"left":0.08361037,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"bounds":{"left":0.16605718,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"bounds":{"left":0.17935506,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"bounds":{"left":0.079288565,"top":0.14764565,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"bounds":{"left":0.079288565,"top":0.15003991,"width":0.1200133,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"bounds":{"left":0.1022274,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"bounds":{"left":0.116855055,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"bounds":{"left":0.13680187,"top":0.19313647,"width":0.051861703,"height":0.09577015},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"bounds":{"left":0.079288565,"top":0.19393456,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"bounds":{"left":0.13680187,"top":0.19473264,"width":0.051861703,"height":0.80526733},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"bounds":{"left":0.13680187,"top":0.30965683,"width":0.05119681,"height":0.188747},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"bounds":{"left":0.18866356,"top":0.19313647,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"bounds":{"left":0.1939827,"top":0.32083002,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"bounds":{"left":0.08460771,"top":0.3519553,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"bounds":{"left":0.08460771,"top":0.35395053,"width":0.04105718,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"bounds":{"left":0.08759973,"top":0.35514766,"width":0.1100399,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"bounds":{"left":0.1427859,"top":0.41739824,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"bounds":{"left":0.1627327,"top":0.41739824,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"bounds":{"left":0.08759973,"top":0.45810056,"width":0.11702128,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"bounds":{"left":0.08759973,"top":0.45969674,"width":0.08676862,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"bounds":{"left":0.08759973,"top":0.5051876,"width":0.11702128,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.020944148,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"bounds":{"left":0.12450133,"top":0.5981644,"width":0.075465426,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.10305851,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"bounds":{"left":0.10023271,"top":0.6189146,"width":0.08261303,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"bounds":{"left":0.12732713,"top":0.63846767,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.028590426,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.1043883,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"bounds":{"left":0.08759973,"top":0.7709497,"width":0.11702128,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"bounds":{"left":0.08759973,"top":0.7725459,"width":0.05668218,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"bounds":{"left":0.08759973,"top":0.79888266,"width":0.115359046,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"bounds":{"left":0.10023271,"top":0.89066243,"width":0.04870346,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"bounds":{"left":0.11319814,"top":0.9213887,"width":0.025099734,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"bounds":{"left":0.14029256,"top":0.9201915,"width":0.064328454,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"bounds":{"left":0.11319814,"top":0.94213885,"width":0.041888297,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15708111,"top":0.94094175,"width":0.0026595744,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16173537,"top":0.94213885,"width":0.013962766,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.17769282,"top":0.94094175,"width":0.013297873,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.11319814,"top":0.9628891,"width":0.022273935,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.13746676,"top":0.9616919,"width":0.0014960107,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"bounds":{"left":0.11319814,"top":0.99241817,"width":0.022273935,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.13746676,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"bounds":{"left":0.14394946,"top":0.99241817,"width":0.025099734,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.17104389,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"bounds":{"left":0.1775266,"top":0.99241817,"width":0.019448139,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.111203454,"top":0.9912211,"width":0.09042553,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.13547207,"top":1.0,"width":0.013962766,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15142952,"top":1.0,"width":0.0026595744,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.15608378,"top":1.0,"width":0.02244016,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.18051861,"top":1.0,"width":0.013131649,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.025099734,"height":-0.03391862},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"bounds":{"left":0.14029256,"top":1.0,"width":0.013630319,"height":-0.03272152},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.041888297,"height":-0.063447714},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.15708111,"top":1.0,"width":0.024933511,"height":-0.062250614},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.0390625,"height":-0.08419788},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"bounds":{"left":0.15425532,"top":1.0,"width":0.011968086,"height":-0.08300078},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"bounds":{"left":0.09291888,"top":0.8216281,"width":0.10638298,"height":0.01915403},"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"bounds":{"left":0.099567816,"top":0.82202715,"width":0.069980055,"height":0.018355945},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"bounds":{"left":0.091921546,"top":0.8216281,"width":0.0066489363,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"bounds":{"left":0.08892952,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"bounds":{"left":0.10488697,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"bounds":{"left":0.16007313,"top":0.85514766,"width":0.027925532,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"bounds":{"left":0.1653923,"top":0.8639266,"width":0.00930851,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Microphone","depth":19,"bounds":{"left":0.18999335,"top":0.85514766,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Send message","depth":19,"bounds":{"left":0.19630983,"top":0.85434955,"width":0.013962766,"height":0.033519555},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":false,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.","depth":17,"bounds":{"left":0.08510638,"top":0.90901834,"width":0.11951463,"height":0.025139665},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Your privacy & Gemini Opens in a new window","depth":17,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your privacy & Gemini","depth":18,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Opens in a new window","depth":19,"bounds":{"left":0.079288565,"top":0.92098963,"width":0.043218084,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Summarize page","depth":7,"bounds":{"left":0.08494016,"top":0.95730245,"width":0.053523935,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Summarize page","depth":9,"bounds":{"left":0.09059176,"top":0.96249,"width":0.042220745,"height":0.015163607},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Skip to content","depth":6,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Skip to content","depth":7,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open menu","depth":10,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"Homepage (g then d)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"jiminny","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"jiminny","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"app","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"app","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Search or jump to…","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Type","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to search","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Chat with Copilot","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Open Copilot…","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXMenuButton","text":"Create new...","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXLink","text":"All issues(g then i)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All pull requests","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All repositories","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"You have unread notifications(g then n)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open user navigation menu","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Repository navigation","depth":9,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Repository navigation","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Code","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Pull requests (29)","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pull requests","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"29","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Agents","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Agents","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Actions","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Actions","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Wiki","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Wiki","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Security and quality","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Security and quality","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Insights","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Insights","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Settings","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Settings","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Important update","depth":10,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Important update","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Review this update","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Review this update","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and manage your preferences in your","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"GitHub account settings","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"GitHub account settings","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Dismiss banner","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"JY-18091 | Update composer to support php 8.5 #12058 Edit title","depth":13,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"#","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"12058","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Edit title","depth":14,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Preview","depth":13,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXStaticText","text":"Preview","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Checks failing","depth":13,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Checks failing","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXMenuButton","text":"Code","depth":13,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXStaticText","text":"Code","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Open","depth":13,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"nikolaybiaivanov","depth":15,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"nikolaybiaivanov","depth":16,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"wants to merge 10 commits into","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"master","depth":15,"on_screen":false,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"master","depth":16,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"from","depth":16,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"JY-18091-upgrade-to-php-8-5","depth":16,"on_screen":false,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-18091-upgrade-to-php-8-5","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy head branch name to clipboard","depth":16,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Lines changed: 2199 additions & 3796 deletions","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Conversation (3)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Conversation","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"3","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Commits (10)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Commits","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"10","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Checks (3)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Checks","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"3","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Files changed (260)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"Files changed","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"260","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Pull Request Toolbar","depth":14,"bounds":{"left":0.22606383,"top":0.075019956,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pull Request Toolbar","depth":15,"bounds":{"left":0.22606383,"top":0.077813245,"width":0.030086435,"height":0.08060654},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Collapse file tree","depth":14,"bounds":{"left":0.22606383,"top":0.06424581,"width":0.00930851,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXStaticText","text":"Open","depth":14,"bounds":{"left":0.2486702,"top":0.06863528,"width":0.011968086,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"JY-18091 | Update composer to support php 8.5","depth":14,"bounds":{"left":0.26728722,"top":0.057462092,"width":0.108211435,"height":0.016759777},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5","depth":16,"bounds":{"left":0.26728722,"top":0.05905826,"width":0.108211435,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"#","depth":15,"bounds":{"left":0.37815824,"top":0.05905826,"width":0.0028257978,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"12058","depth":15,"bounds":{"left":0.38098404,"top":0.05905826,"width":0.013630319,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"All commits","depth":14,"bounds":{"left":0.26462767,"top":0.07102953,"width":0.03374335,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"All commits","depth":16,"bounds":{"left":0.26761967,"top":0.07621708,"width":0.02244016,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"nikolaybiaivanov","depth":15,"bounds":{"left":0.30269283,"top":0.075019956,"width":0.032413565,"height":0.014365523},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"nikolaybiaivanov","depth":16,"bounds":{"left":0.30269283,"top":0.07621708,"width":0.032413565,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"wants to merge 10 commits into","depth":15,"bounds":{"left":0.33643618,"top":0.07621708,"width":0.059840426,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"master","depth":15,"bounds":{"left":0.39760637,"top":0.07342378,"width":0.018450798,"height":0.017557861},"on_screen":true,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"master","depth":16,"bounds":{"left":0.39960107,"top":0.07661612,"width":0.014461436,"height":0.011572227},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"from","depth":16,"bounds":{"left":0.41738698,"top":0.07621708,"width":0.008643617,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"JY-18091-upgrade-to-php-8-5","depth":16,"bounds":{"left":0.4273604,"top":0.07342378,"width":0.06881649,"height":0.017557861},"on_screen":true,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-18091-upgrade-to-php-8-5","depth":17,"bounds":{"left":0.42935506,"top":0.07661612,"width":0.06482713,"height":0.011572227},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy head branch name to clipboard","depth":16,"bounds":{"left":0.49750665,"top":0.07102953,"width":0.00930851,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"16 of 260 files viewed","depth":15,"bounds":{"left":0.8156583,"top":0.07661612,"width":0.01512633,"height":0.08060654},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Checks failing","depth":14,"bounds":{"left":0.86053854,"top":0.06424581,"width":0.03956117,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Checks failing","depth":16,"bounds":{"left":0.87017953,"top":0.06943336,"width":0.026928192,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Submit review","depth":14,"bounds":{"left":0.9027593,"top":0.06424581,"width":0.03856383,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Submit","depth":16,"bounds":{"left":0.90575135,"top":0.06943336,"width":0.014793883,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"review","depth":16,"bounds":{"left":0.9205452,"top":0.06943336,"width":0.012466756,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXMenuButton","text":"Open diff view settings","depth":14,"bounds":{"left":0.9439827,"top":0.06424581,"width":0.00930851,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open overview panel","depth":14,"bounds":{"left":0.9616024,"top":0.06424581,"width":0.00930851,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open comments panel","depth":14,"bounds":{"left":0.9722407,"top":0.06424581,"width":0.017287234,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXStaticText","text":"(","depth":16,"bounds":{"left":0.98055184,"top":0.06943336,"width":0.0026595744,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"0","depth":16,"bounds":{"left":0.98321146,"top":0.06943336,"width":0.0026595744,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":16,"bounds":{"left":0.985871,"top":0.06943336,"width":0.0014960107,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXTextField","text":"Filter files…","depth":16,"bounds":{"left":0.23736702,"top":0.11332801,"width":0.06815159,"height":0.023942538},"on_screen":true,"help_text":"","role_description":"text field","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Filter options","depth":16,"bounds":{"left":0.30851063,"top":0.112529926,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"File tree","depth":15,"bounds":{"left":0.22639628,"top":0.15083799,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"File tree","depth":16,"bounds":{"left":0.22639628,"top":0.15363128,"width":0.014295213,"height":0.0518755},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".circleci","depth":19,"bounds":{"left":0.24235372,"top":0.15682362,"width":0.016456118,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"config_continue.yml","depth":21,"bounds":{"left":0.2450133,"top":0.18276137,"width":0.04338431,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"config_continue.yml","depth":22,"bounds":{"left":0.2450133,"top":0.18276137,"width":0.04338431,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"app","depth":19,"bounds":{"left":0.24235372,"top":0.20830008,"width":0.008144947,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Component","depth":21,"bounds":{"left":0.2450133,"top":0.23383878,"width":0.025099734,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ActionItems/Notifications","depth":23,"bounds":{"left":0.24767287,"top":0.25937748,"width":0.054022606,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"ActionItemsNotification.php","depth":25,"bounds":{"left":0.25033244,"top":0.28531525,"width":0.059840426,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"ActionItemsNotification.php","depth":26,"bounds":{"left":0.25033244,"top":0.28531525,"width":0.059840426,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ActivityAnalytics/Service","depth":23,"bounds":{"left":0.24767287,"top":0.31085396,"width":0.052526597,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"TopicTriggerService.php","depth":25,"bounds":{"left":0.25033244,"top":0.33639267,"width":0.05219415,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"TopicTriggerService.php","depth":26,"bounds":{"left":0.25033244,"top":0.33639267,"width":0.05219415,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ActivitySearch","depth":23,"bounds":{"left":0.24767287,"top":0.36193135,"width":0.030917553,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"FilterDefinition","depth":25,"bounds":{"left":0.25033244,"top":0.38786912,"width":0.031416222,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Security","depth":27,"bounds":{"left":0.25299203,"top":0.41340783,"width":0.01761968,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"PrivateMeetingsForCurrentUserOnly.php","depth":29,"bounds":{"left":0.2556516,"top":0.43894652,"width":0.087101065,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"RestrictPublicActivitiesOnly.php","depth":29,"bounds":{"left":0.2556516,"top":0.46448523,"width":0.068317816,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"RestrictTeam.php","depth":29,"bounds":{"left":0.2556516,"top":0.49002394,"width":0.03756649,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false}]...
|
8578557756334509399
|
4168067451980627400
|
visual_change
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-18091 | Update composer to support php 8.5 #12058 Edit title
JY-18091 | Update composer to support php 8.5
#
12058
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5
JY-18091-upgrade-to-php-8-5
Copy head branch name to clipboard
Lines changed: 2199 additions & 3796 deletions
Conversation (3)
Conversation
(
3
)
Commits (10)
Commits
(
10
)
Checks (3)
Checks
(
3
)
Files changed (260)
Files changed
(
260
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-18091 | Update composer to support php 8.5
JY-18091 | Update composer to support php 8.5
#
12058
All commits
All commits
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5
JY-18091-upgrade-to-php-8-5
Copy head branch name to clipboard
16 of 260 files viewed
Checks failing
Checks failing
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
.circleci
config_continue.yml
config_continue.yml
app
Component
ActionItems/Notifications
ActionItemsNotification.php
ActionItemsNotification.php
ActivityAnalytics/Service
TopicTriggerService.php
TopicTriggerService.php
ActivitySearch
FilterDefinition
Security
PrivateMeetingsForCurrentUserOnly.php
RestrictPublicActivitiesOnly.php
RestrictTeam.php...
|
42432
|
NULL
|
NULL
|
NULL
|
|
42434
|
1555
|
38
|
2026-05-14T11:34:59.637879+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758499637_m1.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_1
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Microphone","depth":19,"on_screen":true,"role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Send message","depth":19,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":false,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.","depth":17,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Your privacy & Gemini Opens in a new window","depth":17,"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your privacy & Gemini","depth":18,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Opens in a new window","depth":19,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Summarize page","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Summarize page","depth":9,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Skip to content","depth":6,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Skip to content","depth":7,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open menu","depth":10,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"Homepage (g then d)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"jiminny","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"jiminny","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"app","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"app","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Search or jump to…","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Type","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to search","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Chat with Copilot","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Open Copilot…","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXMenuButton","text":"Create new...","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXLink","text":"All issues(g then i)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All pull requests","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All repositories","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"You have unread notifications(g then n)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open user navigation menu","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Repository navigation","depth":9,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"}]...
|
8668746061887020070
|
4312182640064871880
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation...
|
NULL
|
NULL
|
NULL
|
NULL
|
|
42435
|
1556
|
30
|
2026-05-14T11:34:59.633417+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758499633_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.057063047,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.08060654,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.09217877,"width":0.101230055,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"bounds":{"left":0.0028257978,"top":0.11332801,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"bounds":{"left":0.015957447,"top":0.12490024,"width":0.076961435,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"bounds":{"left":0.0028257978,"top":0.14604948,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"bounds":{"left":0.015957447,"top":0.15762171,"width":0.08543883,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"bounds":{"left":0.0028257978,"top":0.17877094,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"bounds":{"left":0.015957447,"top":0.19034317,"width":0.04288564,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"bounds":{"left":0.0028257978,"top":0.21149242,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"bounds":{"left":0.015957447,"top":0.22306465,"width":0.12732713,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"bounds":{"left":0.0028257978,"top":0.2442139,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"bounds":{"left":0.015957447,"top":0.25578612,"width":0.033410903,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.27693537,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.28850758,"width":0.18068483,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"bounds":{"left":0.06732048,"top":0.28411812,"width":0.007978723,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"bounds":{"left":0.0028257978,"top":0.30965683,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"bounds":{"left":0.015957447,"top":0.32122904,"width":0.171875,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.3423783,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.35395053,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"bounds":{"left":0.0,"top":0.37509975,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"bounds":{"left":0.013297873,"top":0.386672,"width":0.029920213,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.41300878,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.4365523,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.4481245,"width":0.06632314,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.46927375,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.48084596,"width":0.064494684,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.5019952,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.51356745,"width":0.15658244,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.53990424,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.5634477,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.57501996,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.5961692,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6077414,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.62889063,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6404629,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.66161215,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.67318434,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.6995211,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.72306466,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.73463684,"width":0.091755316,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.7557861,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.76735836,"width":0.11619016,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.7885076,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.8000798,"width":0.18932846,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.82122904,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.8328013,"width":0.12898937,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.8539505,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.86552274,"width":0.079288565,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"bounds":{"left":0.0,"top":0.88667196,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"bounds":{"left":0.013297873,"top":0.8982442,"width":0.032247342,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0,"top":0.9193935,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.013297873,"top":0.93096566,"width":0.013131649,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.95211494,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.9636871,"width":0.041722074,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.9848364,"width":0.07962101,"height":0.0151636},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.99640864,"width":0.041722074,"height":0.0035913587},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":1.0,"width":0.07962101,"height":-0.01755786},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":1.0,"width":0.041722074,"height":-0.029130101},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.007978723,"height":-0.05546689},"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.07679521,"height":-0.07901037},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":1.0,"width":0.21575798,"height":-0.09058261},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"bounds":{"left":0.0028257978,"top":0.92897046,"width":0.07413564,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"bounds":{"left":0.0028257978,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"bounds":{"left":0.013796543,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"bounds":{"left":0.024933511,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"bounds":{"left":0.036070477,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"bounds":{"left":0.04720745,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"bounds":{"left":0.1846742,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"bounds":{"left":0.1966423,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"bounds":{"left":0.1939827,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"bounds":{"left":0.08361037,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"bounds":{"left":0.16605718,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"bounds":{"left":0.17935506,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"bounds":{"left":0.079288565,"top":0.14764565,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"bounds":{"left":0.079288565,"top":0.15003991,"width":0.1200133,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"bounds":{"left":0.1022274,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"bounds":{"left":0.116855055,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"bounds":{"left":0.13680187,"top":0.19313647,"width":0.051861703,"height":0.09577015},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"bounds":{"left":0.079288565,"top":0.19393456,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"bounds":{"left":0.13680187,"top":0.19473264,"width":0.051861703,"height":0.80526733},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"bounds":{"left":0.13680187,"top":0.30965683,"width":0.05119681,"height":0.188747},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"bounds":{"left":0.18866356,"top":0.19313647,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"bounds":{"left":0.1939827,"top":0.32083002,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"bounds":{"left":0.08460771,"top":0.3519553,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"bounds":{"left":0.08460771,"top":0.35395053,"width":0.04105718,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"bounds":{"left":0.08759973,"top":0.35514766,"width":0.1100399,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"bounds":{"left":0.1427859,"top":0.41739824,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"bounds":{"left":0.1627327,"top":0.41739824,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"bounds":{"left":0.08759973,"top":0.45810056,"width":0.11702128,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"bounds":{"left":0.08759973,"top":0.45969674,"width":0.08676862,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"bounds":{"left":0.08759973,"top":0.5051876,"width":0.11702128,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.020944148,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"bounds":{"left":0.12450133,"top":0.5981644,"width":0.075465426,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.10305851,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"bounds":{"left":0.10023271,"top":0.6189146,"width":0.08261303,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"bounds":{"left":0.12732713,"top":0.63846767,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.028590426,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.1043883,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"bounds":{"left":0.08759973,"top":0.7709497,"width":0.11702128,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"bounds":{"left":0.08759973,"top":0.7725459,"width":0.05668218,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"bounds":{"left":0.08759973,"top":0.79888266,"width":0.115359046,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"bounds":{"left":0.10023271,"top":0.89066243,"width":0.04870346,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"bounds":{"left":0.11319814,"top":0.9213887,"width":0.025099734,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"bounds":{"left":0.14029256,"top":0.9201915,"width":0.064328454,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"bounds":{"left":0.11319814,"top":0.94213885,"width":0.041888297,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15708111,"top":0.94094175,"width":0.0026595744,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16173537,"top":0.94213885,"width":0.013962766,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.17769282,"top":0.94094175,"width":0.013297873,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.11319814,"top":0.9628891,"width":0.022273935,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.13746676,"top":0.9616919,"width":0.0014960107,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"bounds":{"left":0.11319814,"top":0.99241817,"width":0.022273935,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.13746676,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"bounds":{"left":0.14394946,"top":0.99241817,"width":0.025099734,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.17104389,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"bounds":{"left":0.1775266,"top":0.99241817,"width":0.019448139,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.111203454,"top":0.9912211,"width":0.09042553,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.13547207,"top":1.0,"width":0.013962766,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15142952,"top":1.0,"width":0.0026595744,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.15608378,"top":1.0,"width":0.02244016,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.18051861,"top":1.0,"width":0.013131649,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.025099734,"height":-0.03391862},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"bounds":{"left":0.14029256,"top":1.0,"width":0.013630319,"height":-0.03272152},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.041888297,"height":-0.063447714},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.15708111,"top":1.0,"width":0.024933511,"height":-0.062250614},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.0390625,"height":-0.08419788},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"bounds":{"left":0.15425532,"top":1.0,"width":0.011968086,"height":-0.08300078},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"bounds":{"left":0.09291888,"top":0.8216281,"width":0.10638298,"height":0.01915403},"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"bounds":{"left":0.099567816,"top":0.82202715,"width":0.069980055,"height":0.018355945},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"bounds":{"left":0.091921546,"top":0.8216281,"width":0.0066489363,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"bounds":{"left":0.08892952,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"bounds":{"left":0.10488697,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"bounds":{"left":0.16007313,"top":0.85514766,"width":0.027925532,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"bounds":{"left":0.1653923,"top":0.8639266,"width":0.00930851,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Microphone","depth":19,"bounds":{"left":0.18999335,"top":0.85514766,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Send message","depth":19,"bounds":{"left":0.19630983,"top":0.85434955,"width":0.013962766,"height":0.033519555},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":false,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.","depth":17,"bounds":{"left":0.08510638,"top":0.90901834,"width":0.11951463,"height":0.025139665},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Your privacy & Gemini Opens in a new window","depth":17,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your privacy & Gemini","depth":18,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Opens in a new window","depth":19,"bounds":{"left":0.079288565,"top":0.92098963,"width":0.043218084,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Summarize page","depth":7,"bounds":{"left":0.08494016,"top":0.95730245,"width":0.053523935,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Summarize page","depth":9,"bounds":{"left":0.09059176,"top":0.96249,"width":0.042220745,"height":0.015163607},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Skip to content","depth":6,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Skip to content","depth":7,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open menu","depth":10,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"Homepage (g then d)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"jiminny","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"jiminny","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"app","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"app","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Search or jump to…","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Type","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"}]...
|
4983164582872039260
|
4312182640064871880
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/...
|
NULL
|
NULL
|
NULL
|
NULL
|
|
42436
|
1556
|
31
|
2026-05-14T11:35:00.560953+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758500560_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-18091 | Update composer to support php 8.5 #12058 Edit title
JY-18091 | Update composer to support php 8.5
#
12058
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5
JY-18091-upgrade-to-php-8-5
Copy head branch name to clipboard
Lines changed: 2199 additions & 3796 deletions
Conversation (3)
Conversation
(
3
)
Commits (10)
Commits
(
10
)
Checks (3)
Checks
(
3
)
Files changed (260)
Files changed
(
260
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-18091 | Update composer to support php 8.5
JY-18091 | Update composer to support php 8.5
#
12058
All commits
All commits
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5
JY-18091-upgrade-to-php-8-5
Copy head branch name to clipboard
17 of 260 files viewed
Checks failing
Checks failing
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
.circleci
config_continue.yml
config_continue.yml
app
Component
ActionItems/Notifications
ActionItemsNotification.php
ActionItemsNotification.php
ActivityAnalytics/Service
TopicTriggerService.php
TopicTriggerService.php
ActivitySearch
FilterDefinition
Security
PrivateMeetingsForCurrentUserOnly.php
RestrictPublicActivitiesOnly.php
RestrictTeam.php
TeamInsights
DateRangeFilter.php
Exists.php...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.057063047,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.08060654,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.09217877,"width":0.101230055,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"bounds":{"left":0.0028257978,"top":0.11332801,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"bounds":{"left":0.015957447,"top":0.12490024,"width":0.076961435,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"bounds":{"left":0.0028257978,"top":0.14604948,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"bounds":{"left":0.015957447,"top":0.15762171,"width":0.08543883,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"bounds":{"left":0.0028257978,"top":0.17877094,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"bounds":{"left":0.015957447,"top":0.19034317,"width":0.04288564,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"bounds":{"left":0.0028257978,"top":0.21149242,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"bounds":{"left":0.015957447,"top":0.22306465,"width":0.12732713,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"bounds":{"left":0.0028257978,"top":0.2442139,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"bounds":{"left":0.015957447,"top":0.25578612,"width":0.033410903,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.27693537,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.28850758,"width":0.18068483,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"bounds":{"left":0.06732048,"top":0.28411812,"width":0.007978723,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"bounds":{"left":0.0028257978,"top":0.30965683,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"bounds":{"left":0.015957447,"top":0.32122904,"width":0.171875,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.3423783,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.35395053,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"bounds":{"left":0.0,"top":0.37509975,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"bounds":{"left":0.013297873,"top":0.386672,"width":0.029920213,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.41300878,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.4365523,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.4481245,"width":0.06632314,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.46927375,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.48084596,"width":0.064494684,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.5019952,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.51356745,"width":0.15658244,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.53990424,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.5634477,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.57501996,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.5961692,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6077414,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.62889063,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6404629,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.66161215,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.67318434,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.6995211,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.72306466,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.73463684,"width":0.091755316,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.7557861,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.76735836,"width":0.11619016,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.7885076,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.8000798,"width":0.18932846,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.82122904,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.8328013,"width":0.12898937,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.8539505,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.86552274,"width":0.079288565,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"bounds":{"left":0.0,"top":0.88667196,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"bounds":{"left":0.013297873,"top":0.8982442,"width":0.032247342,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0,"top":0.9193935,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.013297873,"top":0.93096566,"width":0.013131649,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.95211494,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.9636871,"width":0.041722074,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.9848364,"width":0.07962101,"height":0.0151636},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.99640864,"width":0.041722074,"height":0.0035913587},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":1.0,"width":0.07962101,"height":-0.01755786},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":1.0,"width":0.041722074,"height":-0.029130101},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.007978723,"height":-0.05546689},"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.07679521,"height":-0.07901037},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":1.0,"width":0.21575798,"height":-0.09058261},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"bounds":{"left":0.0028257978,"top":0.92897046,"width":0.07413564,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"bounds":{"left":0.0028257978,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"bounds":{"left":0.013796543,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"bounds":{"left":0.024933511,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"bounds":{"left":0.036070477,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"bounds":{"left":0.04720745,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"bounds":{"left":0.1846742,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"bounds":{"left":0.1966423,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"bounds":{"left":0.1939827,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"bounds":{"left":0.08361037,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"bounds":{"left":0.16605718,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"bounds":{"left":0.17935506,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"bounds":{"left":0.079288565,"top":0.14764565,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"bounds":{"left":0.079288565,"top":0.15003991,"width":0.1200133,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"bounds":{"left":0.1022274,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"bounds":{"left":0.116855055,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"bounds":{"left":0.13680187,"top":0.19313647,"width":0.051861703,"height":0.09577015},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"bounds":{"left":0.079288565,"top":0.19393456,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"bounds":{"left":0.13680187,"top":0.19473264,"width":0.051861703,"height":0.80526733},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"bounds":{"left":0.13680187,"top":0.30965683,"width":0.05119681,"height":0.188747},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"bounds":{"left":0.18866356,"top":0.19313647,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"bounds":{"left":0.1939827,"top":0.32083002,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"bounds":{"left":0.08460771,"top":0.3519553,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"bounds":{"left":0.08460771,"top":0.35395053,"width":0.04105718,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"bounds":{"left":0.08759973,"top":0.35514766,"width":0.1100399,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"bounds":{"left":0.1427859,"top":0.41739824,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"bounds":{"left":0.1627327,"top":0.41739824,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"bounds":{"left":0.08759973,"top":0.45810056,"width":0.11702128,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"bounds":{"left":0.08759973,"top":0.45969674,"width":0.08676862,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"bounds":{"left":0.08759973,"top":0.5051876,"width":0.11702128,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.020944148,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"bounds":{"left":0.12450133,"top":0.5981644,"width":0.075465426,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.10305851,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"bounds":{"left":0.10023271,"top":0.6189146,"width":0.08261303,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"bounds":{"left":0.12732713,"top":0.63846767,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.028590426,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.1043883,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"bounds":{"left":0.08759973,"top":0.7709497,"width":0.11702128,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"bounds":{"left":0.08759973,"top":0.7725459,"width":0.05668218,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"bounds":{"left":0.08759973,"top":0.79888266,"width":0.115359046,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"bounds":{"left":0.10023271,"top":0.89066243,"width":0.04870346,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"bounds":{"left":0.11319814,"top":0.9213887,"width":0.025099734,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"bounds":{"left":0.14029256,"top":0.9201915,"width":0.064328454,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"bounds":{"left":0.11319814,"top":0.94213885,"width":0.041888297,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15708111,"top":0.94094175,"width":0.0026595744,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16173537,"top":0.94213885,"width":0.013962766,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.17769282,"top":0.94094175,"width":0.013297873,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.11319814,"top":0.9628891,"width":0.022273935,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.13746676,"top":0.9616919,"width":0.0014960107,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"bounds":{"left":0.11319814,"top":0.99241817,"width":0.022273935,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.13746676,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"bounds":{"left":0.14394946,"top":0.99241817,"width":0.025099734,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.17104389,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"bounds":{"left":0.1775266,"top":0.99241817,"width":0.019448139,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.111203454,"top":0.9912211,"width":0.09042553,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.13547207,"top":1.0,"width":0.013962766,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15142952,"top":1.0,"width":0.0026595744,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.15608378,"top":1.0,"width":0.02244016,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.18051861,"top":1.0,"width":0.013131649,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.025099734,"height":-0.03391862},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"bounds":{"left":0.14029256,"top":1.0,"width":0.013630319,"height":-0.03272152},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.041888297,"height":-0.063447714},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.15708111,"top":1.0,"width":0.024933511,"height":-0.062250614},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.0390625,"height":-0.08419788},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"bounds":{"left":0.15425532,"top":1.0,"width":0.011968086,"height":-0.08300078},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"bounds":{"left":0.09291888,"top":0.8216281,"width":0.10638298,"height":0.01915403},"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"bounds":{"left":0.099567816,"top":0.82202715,"width":0.069980055,"height":0.018355945},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"bounds":{"left":0.091921546,"top":0.8216281,"width":0.0066489363,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"bounds":{"left":0.08892952,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"bounds":{"left":0.10488697,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"bounds":{"left":0.16007313,"top":0.85514766,"width":0.027925532,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"bounds":{"left":0.1653923,"top":0.8639266,"width":0.00930851,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Microphone","depth":19,"bounds":{"left":0.18999335,"top":0.85514766,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Send message","depth":19,"bounds":{"left":0.19630983,"top":0.85434955,"width":0.013962766,"height":0.033519555},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":false,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.","depth":17,"bounds":{"left":0.08510638,"top":0.90901834,"width":0.11951463,"height":0.025139665},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Your privacy & Gemini Opens in a new window","depth":17,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your privacy & Gemini","depth":18,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Opens in a new window","depth":19,"bounds":{"left":0.079288565,"top":0.92098963,"width":0.043218084,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Summarize page","depth":7,"bounds":{"left":0.08494016,"top":0.95730245,"width":0.053523935,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Summarize page","depth":9,"bounds":{"left":0.09059176,"top":0.96249,"width":0.042220745,"height":0.015163607},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Skip to content","depth":6,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Skip to content","depth":7,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open menu","depth":10,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"Homepage (g then d)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"jiminny","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"jiminny","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"app","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"app","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Search or jump to…","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Type","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to search","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Chat with Copilot","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Open Copilot…","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXMenuButton","text":"Create new...","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXLink","text":"All issues(g then i)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All pull requests","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All repositories","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"You have unread notifications(g then n)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open user navigation menu","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Repository navigation","depth":9,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Repository navigation","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Code","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Pull requests (29)","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pull requests","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"29","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Agents","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Agents","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Actions","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Actions","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Wiki","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Wiki","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Security and quality","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Security and quality","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Insights","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Insights","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Settings","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Settings","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Important update","depth":10,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Important update","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Review this update","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Review this update","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and manage your preferences in your","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"GitHub account settings","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"GitHub account settings","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Dismiss banner","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"JY-18091 | Update composer to support php 8.5 #12058 Edit title","depth":13,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"#","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"12058","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Edit title","depth":14,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Preview","depth":13,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXStaticText","text":"Preview","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Checks failing","depth":13,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Checks failing","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXMenuButton","text":"Code","depth":13,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXStaticText","text":"Code","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Open","depth":13,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"nikolaybiaivanov","depth":15,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"nikolaybiaivanov","depth":16,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"wants to merge 10 commits into","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"master","depth":15,"on_screen":false,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"master","depth":16,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"from","depth":16,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"JY-18091-upgrade-to-php-8-5","depth":16,"on_screen":false,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-18091-upgrade-to-php-8-5","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy head branch name to clipboard","depth":16,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Lines changed: 2199 additions & 3796 deletions","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Conversation (3)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Conversation","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"3","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Commits (10)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Commits","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"10","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Checks (3)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Checks","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"3","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Files changed (260)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"Files changed","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"260","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Pull Request Toolbar","depth":14,"bounds":{"left":0.22606383,"top":0.075019956,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pull Request Toolbar","depth":15,"bounds":{"left":0.22606383,"top":0.077813245,"width":0.030086435,"height":0.08060654},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Collapse file tree","depth":14,"bounds":{"left":0.22606383,"top":0.06424581,"width":0.00930851,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXStaticText","text":"Open","depth":14,"bounds":{"left":0.2486702,"top":0.06863528,"width":0.011968086,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"JY-18091 | Update composer to support php 8.5","depth":14,"bounds":{"left":0.26728722,"top":0.057462092,"width":0.108211435,"height":0.016759777},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5","depth":16,"bounds":{"left":0.26728722,"top":0.05905826,"width":0.108211435,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"#","depth":15,"bounds":{"left":0.37815824,"top":0.05905826,"width":0.0028257978,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"12058","depth":15,"bounds":{"left":0.38098404,"top":0.05905826,"width":0.013630319,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"All commits","depth":14,"bounds":{"left":0.26462767,"top":0.07102953,"width":0.03374335,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"All commits","depth":16,"bounds":{"left":0.26761967,"top":0.07621708,"width":0.02244016,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"nikolaybiaivanov","depth":15,"bounds":{"left":0.30269283,"top":0.075019956,"width":0.032413565,"height":0.014365523},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"nikolaybiaivanov","depth":16,"bounds":{"left":0.30269283,"top":0.07621708,"width":0.032413565,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"wants to merge 10 commits into","depth":15,"bounds":{"left":0.33643618,"top":0.07621708,"width":0.059840426,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"master","depth":15,"bounds":{"left":0.39760637,"top":0.07342378,"width":0.018450798,"height":0.017557861},"on_screen":true,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"master","depth":16,"bounds":{"left":0.39960107,"top":0.07661612,"width":0.014461436,"height":0.011572227},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"from","depth":16,"bounds":{"left":0.41738698,"top":0.07621708,"width":0.008643617,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"JY-18091-upgrade-to-php-8-5","depth":16,"bounds":{"left":0.4273604,"top":0.07342378,"width":0.06881649,"height":0.017557861},"on_screen":true,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-18091-upgrade-to-php-8-5","depth":17,"bounds":{"left":0.42935506,"top":0.07661612,"width":0.06482713,"height":0.011572227},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy head branch name to clipboard","depth":16,"bounds":{"left":0.49750665,"top":0.07102953,"width":0.00930851,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"17 of 260 files viewed","depth":15,"bounds":{"left":0.8159907,"top":0.07661612,"width":0.014960106,"height":0.08060654},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Checks failing","depth":14,"bounds":{"left":0.86053854,"top":0.06424581,"width":0.03956117,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Checks failing","depth":16,"bounds":{"left":0.87017953,"top":0.06943336,"width":0.026928192,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Submit review","depth":14,"bounds":{"left":0.9027593,"top":0.06424581,"width":0.03856383,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Submit","depth":16,"bounds":{"left":0.90575135,"top":0.06943336,"width":0.014793883,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"review","depth":16,"bounds":{"left":0.9205452,"top":0.06943336,"width":0.012466756,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXMenuButton","text":"Open diff view settings","depth":14,"bounds":{"left":0.9439827,"top":0.06424581,"width":0.00930851,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open overview panel","depth":14,"bounds":{"left":0.9616024,"top":0.06424581,"width":0.00930851,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open comments panel","depth":14,"bounds":{"left":0.9722407,"top":0.06424581,"width":0.017287234,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXStaticText","text":"(","depth":16,"bounds":{"left":0.98055184,"top":0.06943336,"width":0.0026595744,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"0","depth":16,"bounds":{"left":0.98321146,"top":0.06943336,"width":0.0026595744,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":16,"bounds":{"left":0.985871,"top":0.06943336,"width":0.0014960107,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXTextField","text":"Filter files…","depth":16,"bounds":{"left":0.23736702,"top":0.11332801,"width":0.06815159,"height":0.023942538},"on_screen":true,"help_text":"","role_description":"text field","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Filter options","depth":16,"bounds":{"left":0.30851063,"top":0.112529926,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"File tree","depth":15,"bounds":{"left":0.22639628,"top":0.15083799,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"File tree","depth":16,"bounds":{"left":0.22639628,"top":0.15363128,"width":0.014295213,"height":0.0518755},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".circleci","depth":19,"bounds":{"left":0.24235372,"top":0.15682362,"width":0.016456118,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"config_continue.yml","depth":21,"bounds":{"left":0.2450133,"top":0.18276137,"width":0.04338431,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"config_continue.yml","depth":22,"bounds":{"left":0.2450133,"top":0.18276137,"width":0.04338431,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"app","depth":19,"bounds":{"left":0.24235372,"top":0.20830008,"width":0.008144947,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Component","depth":21,"bounds":{"left":0.2450133,"top":0.23383878,"width":0.025099734,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ActionItems/Notifications","depth":23,"bounds":{"left":0.24767287,"top":0.25937748,"width":0.054022606,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"ActionItemsNotification.php","depth":25,"bounds":{"left":0.25033244,"top":0.28531525,"width":0.059840426,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"ActionItemsNotification.php","depth":26,"bounds":{"left":0.25033244,"top":0.28531525,"width":0.059840426,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ActivityAnalytics/Service","depth":23,"bounds":{"left":0.24767287,"top":0.31085396,"width":0.052526597,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"TopicTriggerService.php","depth":25,"bounds":{"left":0.25033244,"top":0.33639267,"width":0.05219415,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"TopicTriggerService.php","depth":26,"bounds":{"left":0.25033244,"top":0.33639267,"width":0.05219415,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ActivitySearch","depth":23,"bounds":{"left":0.24767287,"top":0.36193135,"width":0.030917553,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"FilterDefinition","depth":25,"bounds":{"left":0.25033244,"top":0.38786912,"width":0.031416222,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Security","depth":27,"bounds":{"left":0.25299203,"top":0.41340783,"width":0.01761968,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"PrivateMeetingsForCurrentUserOnly.php","depth":29,"bounds":{"left":0.2556516,"top":0.43894652,"width":0.087101065,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"RestrictPublicActivitiesOnly.php","depth":29,"bounds":{"left":0.2556516,"top":0.46448523,"width":0.068317816,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"RestrictTeam.php","depth":29,"bounds":{"left":0.2556516,"top":0.49002394,"width":0.03756649,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"TeamInsights","depth":27,"bounds":{"left":0.25299203,"top":0.51556265,"width":0.028424202,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"DateRangeFilter.php","depth":29,"bounds":{"left":0.2556516,"top":0.5415004,"width":0.043716755,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"Exists.php","depth":29,"bounds":{"left":0.2556516,"top":0.56703913,"width":0.022107713,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false}]...
|
3612334729382388331
|
4312182640056483272
|
visual_change
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-18091 | Update composer to support php 8.5 #12058 Edit title
JY-18091 | Update composer to support php 8.5
#
12058
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5
JY-18091-upgrade-to-php-8-5
Copy head branch name to clipboard
Lines changed: 2199 additions & 3796 deletions
Conversation (3)
Conversation
(
3
)
Commits (10)
Commits
(
10
)
Checks (3)
Checks
(
3
)
Files changed (260)
Files changed
(
260
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-18091 | Update composer to support php 8.5
JY-18091 | Update composer to support php 8.5
#
12058
All commits
All commits
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5
JY-18091-upgrade-to-php-8-5
Copy head branch name to clipboard
17 of 260 files viewed
Checks failing
Checks failing
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
.circleci
config_continue.yml
config_continue.yml
app
Component
ActionItems/Notifications
ActionItemsNotification.php
ActionItemsNotification.php
ActivityAnalytics/Service
TopicTriggerService.php
TopicTriggerService.php
ActivitySearch
FilterDefinition
Security
PrivateMeetingsForCurrentUserOnly.php
RestrictPublicActivitiesOnly.php
RestrictTeam.php
TeamInsights
DateRangeFilter.php
Exists.php...
|
42435
|
NULL
|
NULL
|
NULL
|
|
42437
|
1555
|
39
|
2026-05-14T11:35:01.531060+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758501531_m1.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_1
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Microphone","depth":19,"on_screen":true,"role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Send message","depth":19,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":false,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.","depth":17,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Your privacy & Gemini Opens in a new window","depth":17,"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your privacy & Gemini","depth":18,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Opens in a new window","depth":19,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Summarize page","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Summarize page","depth":9,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Skip to content","depth":6,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Skip to content","depth":7,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open menu","depth":10,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"Homepage (g then d)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"jiminny","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"jiminny","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"app","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"app","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Search or jump to…","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Type","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to search","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Chat with Copilot","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Open Copilot…","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXMenuButton","text":"Create new...","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXLink","text":"All issues(g then i)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All pull requests","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All repositories","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"You have unread notifications(g then n)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open user navigation menu","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Repository navigation","depth":9,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Repository navigation","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Code","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Pull requests (29)","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pull requests","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"29","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Agents","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Agents","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Actions","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Actions","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Wiki","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Wiki","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Security and quality","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Security and quality","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Insights","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Insights","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Settings","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false}]...
|
-6212252860694221117
|
4312182640064871880
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings...
|
42434
|
NULL
|
NULL
|
NULL
|
|
42438
|
1556
|
32
|
2026-05-14T11:35:01.512601+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758501512_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.057063047,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.08060654,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.09217877,"width":0.101230055,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"bounds":{"left":0.0028257978,"top":0.11332801,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"bounds":{"left":0.015957447,"top":0.12490024,"width":0.076961435,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"bounds":{"left":0.0028257978,"top":0.14604948,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"bounds":{"left":0.015957447,"top":0.15762171,"width":0.08543883,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"bounds":{"left":0.0028257978,"top":0.17877094,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"bounds":{"left":0.015957447,"top":0.19034317,"width":0.04288564,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"bounds":{"left":0.0028257978,"top":0.21149242,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"bounds":{"left":0.015957447,"top":0.22306465,"width":0.12732713,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"bounds":{"left":0.0028257978,"top":0.2442139,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"bounds":{"left":0.015957447,"top":0.25578612,"width":0.033410903,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.27693537,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.28850758,"width":0.18068483,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"bounds":{"left":0.06732048,"top":0.28411812,"width":0.007978723,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"bounds":{"left":0.0028257978,"top":0.30965683,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"bounds":{"left":0.015957447,"top":0.32122904,"width":0.171875,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.3423783,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.35395053,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"bounds":{"left":0.0,"top":0.37509975,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"bounds":{"left":0.013297873,"top":0.386672,"width":0.029920213,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.41300878,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.4365523,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.4481245,"width":0.06632314,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.46927375,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.48084596,"width":0.064494684,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.5019952,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.51356745,"width":0.15658244,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.53990424,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.5634477,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.57501996,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.5961692,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6077414,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.62889063,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6404629,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.66161215,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.67318434,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.6995211,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.72306466,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.73463684,"width":0.091755316,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.7557861,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.76735836,"width":0.11619016,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.7885076,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.8000798,"width":0.18932846,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.82122904,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.8328013,"width":0.12898937,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.8539505,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.86552274,"width":0.079288565,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"bounds":{"left":0.0,"top":0.88667196,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"bounds":{"left":0.013297873,"top":0.8982442,"width":0.032247342,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0,"top":0.9193935,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.013297873,"top":0.93096566,"width":0.013131649,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.95211494,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.9636871,"width":0.041722074,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.9848364,"width":0.07962101,"height":0.0151636},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.99640864,"width":0.041722074,"height":0.0035913587},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":1.0,"width":0.07962101,"height":-0.01755786},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":1.0,"width":0.041722074,"height":-0.029130101},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.007978723,"height":-0.05546689},"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.07679521,"height":-0.07901037},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":1.0,"width":0.21575798,"height":-0.09058261},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"bounds":{"left":0.0028257978,"top":0.92897046,"width":0.07413564,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"bounds":{"left":0.0028257978,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"bounds":{"left":0.013796543,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"bounds":{"left":0.024933511,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"bounds":{"left":0.036070477,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"bounds":{"left":0.04720745,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"bounds":{"left":0.1846742,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"bounds":{"left":0.1966423,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"bounds":{"left":0.1939827,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"bounds":{"left":0.08361037,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"bounds":{"left":0.16605718,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"bounds":{"left":0.17935506,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"bounds":{"left":0.079288565,"top":0.14764565,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"bounds":{"left":0.079288565,"top":0.15003991,"width":0.1200133,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"bounds":{"left":0.1022274,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"bounds":{"left":0.116855055,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"bounds":{"left":0.13680187,"top":0.19313647,"width":0.051861703,"height":0.09577015},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"bounds":{"left":0.079288565,"top":0.19393456,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"bounds":{"left":0.13680187,"top":0.19473264,"width":0.051861703,"height":0.80526733},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"bounds":{"left":0.13680187,"top":0.30965683,"width":0.05119681,"height":0.188747},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"bounds":{"left":0.18866356,"top":0.19313647,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"bounds":{"left":0.1939827,"top":0.32083002,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"bounds":{"left":0.08460771,"top":0.3519553,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"bounds":{"left":0.08460771,"top":0.35395053,"width":0.04105718,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"bounds":{"left":0.08759973,"top":0.35514766,"width":0.1100399,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"bounds":{"left":0.1427859,"top":0.41739824,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"bounds":{"left":0.1627327,"top":0.41739824,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"bounds":{"left":0.08759973,"top":0.45810056,"width":0.11702128,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"bounds":{"left":0.08759973,"top":0.45969674,"width":0.08676862,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"bounds":{"left":0.08759973,"top":0.5051876,"width":0.11702128,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.020944148,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"bounds":{"left":0.12450133,"top":0.5981644,"width":0.075465426,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.10305851,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"bounds":{"left":0.10023271,"top":0.6189146,"width":0.08261303,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"bounds":{"left":0.12732713,"top":0.63846767,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.028590426,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.1043883,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"bounds":{"left":0.08759973,"top":0.7709497,"width":0.11702128,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"bounds":{"left":0.08759973,"top":0.7725459,"width":0.05668218,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"bounds":{"left":0.08759973,"top":0.79888266,"width":0.115359046,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"bounds":{"left":0.10023271,"top":0.89066243,"width":0.04870346,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"bounds":{"left":0.11319814,"top":0.9213887,"width":0.025099734,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"bounds":{"left":0.14029256,"top":0.9201915,"width":0.064328454,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"bounds":{"left":0.11319814,"top":0.94213885,"width":0.041888297,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15708111,"top":0.94094175,"width":0.0026595744,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16173537,"top":0.94213885,"width":0.013962766,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.17769282,"top":0.94094175,"width":0.013297873,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.11319814,"top":0.9628891,"width":0.022273935,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.13746676,"top":0.9616919,"width":0.0014960107,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"bounds":{"left":0.11319814,"top":0.99241817,"width":0.022273935,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.13746676,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"bounds":{"left":0.14394946,"top":0.99241817,"width":0.025099734,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.17104389,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"bounds":{"left":0.1775266,"top":0.99241817,"width":0.019448139,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.111203454,"top":0.9912211,"width":0.09042553,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.13547207,"top":1.0,"width":0.013962766,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15142952,"top":1.0,"width":0.0026595744,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.15608378,"top":1.0,"width":0.02244016,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.18051861,"top":1.0,"width":0.013131649,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.025099734,"height":-0.03391862},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"bounds":{"left":0.14029256,"top":1.0,"width":0.013630319,"height":-0.03272152},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.041888297,"height":-0.063447714},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.15708111,"top":1.0,"width":0.024933511,"height":-0.062250614},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.0390625,"height":-0.08419788},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"bounds":{"left":0.15425532,"top":1.0,"width":0.011968086,"height":-0.08300078},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"bounds":{"left":0.09291888,"top":0.8216281,"width":0.10638298,"height":0.01915403},"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"bounds":{"left":0.099567816,"top":0.82202715,"width":0.069980055,"height":0.018355945},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"bounds":{"left":0.091921546,"top":0.8216281,"width":0.0066489363,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"bounds":{"left":0.08892952,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"bounds":{"left":0.10488697,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"bounds":{"left":0.16007313,"top":0.85514766,"width":0.027925532,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"bounds":{"left":0.1653923,"top":0.8639266,"width":0.00930851,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Microphone","depth":19,"bounds":{"left":0.18999335,"top":0.85514766,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Send message","depth":19,"bounds":{"left":0.19630983,"top":0.85434955,"width":0.013962766,"height":0.033519555},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":false,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.","depth":17,"bounds":{"left":0.08510638,"top":0.90901834,"width":0.11951463,"height":0.025139665},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Your privacy & Gemini Opens in a new window","depth":17,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your privacy & Gemini","depth":18,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Opens in a new window","depth":19,"bounds":{"left":0.079288565,"top":0.92098963,"width":0.043218084,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Summarize page","depth":7,"bounds":{"left":0.08494016,"top":0.95730245,"width":0.053523935,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Summarize page","depth":9,"bounds":{"left":0.09059176,"top":0.96249,"width":0.042220745,"height":0.015163607},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Skip to content","depth":6,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Skip to content","depth":7,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open menu","depth":10,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"Homepage (g then d)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"jiminny","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"jiminny","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"app","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"app","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Search or jump to…","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Type","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to search","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Chat with Copilot","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Open Copilot…","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXMenuButton","text":"Create new...","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXLink","text":"All issues(g then i)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All pull requests","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All repositories","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"You have unread notifications(g then n)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open user navigation menu","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Repository navigation","depth":9,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Repository navigation","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Code","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Pull requests (29)","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pull requests","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"29","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Agents","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Agents","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Actions","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Actions","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Wiki","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Wiki","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Security and quality","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Security and quality","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Insights","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Insights","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Settings","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Settings","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Important update","depth":10,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Important update","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Review this update","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false}]...
|
-5353545804204936023
|
4312182640064871880
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update...
|
NULL
|
NULL
|
NULL
|
NULL
|
|
42439
|
1555
|
40
|
2026-05-14T11:35:03.632242+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758503632_m1.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_1
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":true,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Microphone","depth":19,"on_screen":true,"role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Send message","depth":19,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":false,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.","depth":17,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Your privacy & Gemini Opens in a new window","depth":17,"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your privacy & Gemini","depth":18,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Opens in a new window","depth":19,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Summarize page","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Summarize page","depth":9,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Skip to content","depth":6,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Skip to content","depth":7,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open menu","depth":10,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"Homepage (g then d)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"jiminny","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"jiminny","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"app","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"app","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Search or jump to…","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Type","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to search","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Chat with Copilot","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Open Copilot…","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXMenuButton","text":"Create new...","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXLink","text":"All issues(g then i)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All pull requests","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All repositories","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"You have unread notifications(g then n)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false}]...
|
3339219148877242699
|
4312182640064871880
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)...
|
NULL
|
NULL
|
NULL
|
NULL
|
|
42440
|
1556
|
33
|
2026-05-14T11:35:03.594036+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758503594_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.057063047,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.08060654,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.09217877,"width":0.101230055,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"bounds":{"left":0.0028257978,"top":0.11332801,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"bounds":{"left":0.015957447,"top":0.12490024,"width":0.076961435,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"bounds":{"left":0.0028257978,"top":0.14604948,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"bounds":{"left":0.015957447,"top":0.15762171,"width":0.08543883,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"bounds":{"left":0.0028257978,"top":0.17877094,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"bounds":{"left":0.015957447,"top":0.19034317,"width":0.04288564,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"bounds":{"left":0.0028257978,"top":0.21149242,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"bounds":{"left":0.015957447,"top":0.22306465,"width":0.12732713,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"bounds":{"left":0.0028257978,"top":0.2442139,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"bounds":{"left":0.015957447,"top":0.25578612,"width":0.033410903,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.27693537,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.28850758,"width":0.18068483,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"bounds":{"left":0.06732048,"top":0.28411812,"width":0.007978723,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"bounds":{"left":0.0028257978,"top":0.30965683,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"bounds":{"left":0.015957447,"top":0.32122904,"width":0.171875,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.3423783,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.35395053,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"bounds":{"left":0.0,"top":0.37509975,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"bounds":{"left":0.013297873,"top":0.386672,"width":0.029920213,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.41300878,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.4365523,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.4481245,"width":0.06632314,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.46927375,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.48084596,"width":0.064494684,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.5019952,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.51356745,"width":0.15658244,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.53990424,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.5634477,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.57501996,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.5961692,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6077414,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.62889063,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6404629,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.66161215,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.67318434,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.6995211,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.72306466,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.73463684,"width":0.091755316,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.7557861,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.76735836,"width":0.11619016,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.7885076,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.8000798,"width":0.18932846,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.82122904,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.8328013,"width":0.12898937,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.8539505,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.86552274,"width":0.079288565,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"bounds":{"left":0.0,"top":0.88667196,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"bounds":{"left":0.013297873,"top":0.8982442,"width":0.032247342,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0,"top":0.9193935,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.013297873,"top":0.93096566,"width":0.013131649,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.95211494,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.9636871,"width":0.041722074,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.9848364,"width":0.07962101,"height":0.0151636},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.99640864,"width":0.041722074,"height":0.0035913587},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":1.0,"width":0.07962101,"height":-0.01755786},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":1.0,"width":0.041722074,"height":-0.029130101},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.007978723,"height":-0.05546689},"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.07679521,"height":-0.07901037},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":1.0,"width":0.21575798,"height":-0.09058261},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"bounds":{"left":0.0028257978,"top":0.92897046,"width":0.07413564,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"bounds":{"left":0.0028257978,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"bounds":{"left":0.013796543,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"bounds":{"left":0.024933511,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"bounds":{"left":0.036070477,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"bounds":{"left":0.04720745,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"bounds":{"left":0.1846742,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"bounds":{"left":0.1966423,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"bounds":{"left":0.1939827,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"bounds":{"left":0.08361037,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"bounds":{"left":0.16605718,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"bounds":{"left":0.17935506,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"bounds":{"left":0.079288565,"top":0.14764565,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"bounds":{"left":0.079288565,"top":0.15003991,"width":0.1200133,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"bounds":{"left":0.1022274,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"bounds":{"left":0.116855055,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"bounds":{"left":0.13680187,"top":0.19313647,"width":0.051861703,"height":0.09577015},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"bounds":{"left":0.079288565,"top":0.19393456,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"bounds":{"left":0.13680187,"top":0.19473264,"width":0.051861703,"height":0.80526733},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"bounds":{"left":0.13680187,"top":0.30965683,"width":0.05119681,"height":0.188747},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"bounds":{"left":0.18866356,"top":0.19313647,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"bounds":{"left":0.1939827,"top":0.32083002,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"bounds":{"left":0.08460771,"top":0.3519553,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"bounds":{"left":0.08460771,"top":0.35395053,"width":0.04105718,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"bounds":{"left":0.08759973,"top":0.35514766,"width":0.1100399,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"bounds":{"left":0.1427859,"top":0.41739824,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"bounds":{"left":0.1627327,"top":0.41739824,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"bounds":{"left":0.08759973,"top":0.45810056,"width":0.11702128,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"bounds":{"left":0.08759973,"top":0.45969674,"width":0.08676862,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"bounds":{"left":0.08759973,"top":0.5051876,"width":0.11702128,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.020944148,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"bounds":{"left":0.12450133,"top":0.5981644,"width":0.075465426,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"bounds":{"left":0.10023271,"top":0.5969673,"width":0.10305851,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"bounds":{"left":0.10023271,"top":0.6189146,"width":0.08261303,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"bounds":{"left":0.12732713,"top":0.63846767,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.028590426,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"bounds":{"left":0.10023271,"top":0.6679968,"width":0.1043883,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"bounds":{"left":0.08759973,"top":0.7709497,"width":0.11702128,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"bounds":{"left":0.08759973,"top":0.7725459,"width":0.05668218,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"bounds":{"left":0.08759973,"top":0.79888266,"width":0.115359046,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"bounds":{"left":0.10023271,"top":0.89066243,"width":0.04870346,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"bounds":{"left":0.11319814,"top":0.9213887,"width":0.025099734,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"bounds":{"left":0.14029256,"top":0.9201915,"width":0.064328454,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"bounds":{"left":0.11319814,"top":0.94213885,"width":0.041888297,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15708111,"top":0.94094175,"width":0.0026595744,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16173537,"top":0.94213885,"width":0.013962766,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.17769282,"top":0.94094175,"width":0.013297873,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.11319814,"top":0.9628891,"width":0.022273935,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.13746676,"top":0.9616919,"width":0.0014960107,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"bounds":{"left":0.11319814,"top":0.99241817,"width":0.022273935,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.13746676,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"bounds":{"left":0.14394946,"top":0.99241817,"width":0.025099734,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.17104389,"top":0.9912211,"width":0.004488032,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"bounds":{"left":0.1775266,"top":0.99241817,"width":0.019448139,"height":0.00758183},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.111203454,"top":0.9912211,"width":0.09042553,"height":0.00877893},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.13547207,"top":1.0,"width":0.013962766,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15142952,"top":1.0,"width":0.0026595744,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.15608378,"top":1.0,"width":0.02244016,"height":-0.013168454},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.18051861,"top":1.0,"width":0.013131649,"height":-0.011971235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.025099734,"height":-0.03391862},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"bounds":{"left":0.14029256,"top":1.0,"width":0.013630319,"height":-0.03272152},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.041888297,"height":-0.063447714},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.15708111,"top":1.0,"width":0.024933511,"height":-0.062250614},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"bounds":{"left":0.11319814,"top":1.0,"width":0.0390625,"height":-0.08419788},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"bounds":{"left":0.15425532,"top":1.0,"width":0.011968086,"height":-0.08300078},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"bounds":{"left":0.09291888,"top":0.8216281,"width":0.10638298,"height":0.01915403},"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":true,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"bounds":{"left":0.099567816,"top":0.82202715,"width":0.069980055,"height":0.018355945},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"bounds":{"left":0.091921546,"top":0.8216281,"width":0.0066489363,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"bounds":{"left":0.08892952,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"bounds":{"left":0.10488697,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"bounds":{"left":0.16007313,"top":0.85514766,"width":0.027925532,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"bounds":{"left":0.1653923,"top":0.8639266,"width":0.00930851,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Microphone","depth":19,"bounds":{"left":0.18999335,"top":0.85514766,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Send message","depth":19,"bounds":{"left":0.19630983,"top":0.85434955,"width":0.013962766,"height":0.033519555},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":false,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.","depth":17,"bounds":{"left":0.08510638,"top":0.90901834,"width":0.11951463,"height":0.025139665},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Your privacy & Gemini Opens in a new window","depth":17,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your privacy & Gemini","depth":18,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Opens in a new window","depth":19,"bounds":{"left":0.079288565,"top":0.92098963,"width":0.043218084,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Summarize page","depth":7,"bounds":{"left":0.08494016,"top":0.95730245,"width":0.053523935,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false}]...
|
-1542418888374724158
|
8923868658492259784
|
visual_change
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page...
|
42438
|
NULL
|
NULL
|
NULL
|
|
42441
|
1555
|
41
|
2026-05-14T11:35:10.805435+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758510805_m1.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_1
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-18091 | Update composer to support php 8.5 #12058 Edit title
JY-18091 | Update composer to support php 8.5
#
12058
Edit title...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":true,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Microphone","depth":19,"on_screen":true,"role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Send message","depth":19,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":false,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.","depth":17,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Your privacy & Gemini Opens in a new window","depth":17,"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your privacy & Gemini","depth":18,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Opens in a new window","depth":19,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Summarize page","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Summarize page","depth":9,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Skip to content","depth":6,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Skip to content","depth":7,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open menu","depth":10,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"Homepage (g then d)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"jiminny","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"jiminny","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"app","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"app","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Search or jump to…","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Type","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to search","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Chat with Copilot","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Open Copilot…","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXMenuButton","text":"Create new...","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXLink","text":"All issues(g then i)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All pull requests","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All repositories","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"You have unread notifications(g then n)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open user navigation menu","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Repository navigation","depth":9,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Repository navigation","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Code","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Pull requests (29)","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pull requests","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"29","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Agents","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Agents","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Actions","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Actions","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Wiki","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Wiki","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Security and quality","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Security and quality","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Insights","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Insights","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Settings","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Settings","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Important update","depth":10,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Important update","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Review this update","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Review this update","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and manage your preferences in your","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"GitHub account settings","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"GitHub account settings","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Dismiss banner","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"JY-18091 | Update composer to support php 8.5 #12058 Edit title","depth":13,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"#","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"12058","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Edit title","depth":14,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false}]...
|
6360970896833549313
|
8923868658492259784
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-18091 | Update composer to support php 8.5 #12058 Edit title
JY-18091 | Update composer to support php 8.5
#
12058
Edit title...
|
42439
|
NULL
|
NULL
|
NULL
|
|
42442
|
1556
|
34
|
2026-05-14T11:35:10.835470+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758510835_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-18091 | Update composer to support php 8.5 #12058 Edit title
JY-18091 | Update composer to support php 8.5
#
12058
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5
JY-18091-upgrade-to-php-8-5
Copy head branch name to clipboard
Lines changed: 2199 additions & 3796 deletions
Conversation (3)
Conversation
(
3
)
Commits (10)
Commits
(
10
)...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.057063047,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.08060654,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.09217877,"width":0.101230055,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"bounds":{"left":0.0028257978,"top":0.11332801,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"bounds":{"left":0.015957447,"top":0.12490024,"width":0.076961435,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"bounds":{"left":0.0028257978,"top":0.14604948,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"bounds":{"left":0.015957447,"top":0.15762171,"width":0.08543883,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"bounds":{"left":0.0028257978,"top":0.17877094,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"bounds":{"left":0.015957447,"top":0.19034317,"width":0.04288564,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"bounds":{"left":0.0028257978,"top":0.21149242,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"bounds":{"left":0.015957447,"top":0.22306465,"width":0.12732713,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"bounds":{"left":0.0028257978,"top":0.2442139,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"bounds":{"left":0.015957447,"top":0.25578612,"width":0.033410903,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.27693537,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.28850758,"width":0.18068483,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"bounds":{"left":0.06732048,"top":0.28411812,"width":0.007978723,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"bounds":{"left":0.0028257978,"top":0.30965683,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"bounds":{"left":0.015957447,"top":0.32122904,"width":0.171875,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.3423783,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.35395053,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"bounds":{"left":0.0,"top":0.37509975,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"bounds":{"left":0.013297873,"top":0.386672,"width":0.029920213,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.41300878,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.4365523,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.4481245,"width":0.06632314,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.46927375,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.48084596,"width":0.064494684,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.5019952,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.51356745,"width":0.15658244,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.53990424,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.5634477,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.57501996,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.5961692,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6077414,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.62889063,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6404629,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.66161215,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.67318434,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.6995211,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.72306466,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.73463684,"width":0.091755316,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.7557861,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.76735836,"width":0.11619016,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.7885076,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.8000798,"width":0.18932846,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.82122904,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.8328013,"width":0.12898937,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.8539505,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.86552274,"width":0.079288565,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"bounds":{"left":0.0,"top":0.88667196,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"bounds":{"left":0.013297873,"top":0.8982442,"width":0.032247342,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0,"top":0.9193935,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.013297873,"top":0.93096566,"width":0.013131649,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.95211494,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.9636871,"width":0.041722074,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.9848364,"width":0.07962101,"height":0.0151636},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.99640864,"width":0.041722074,"height":0.0035913587},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":1.0,"width":0.07962101,"height":-0.01755786},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":1.0,"width":0.041722074,"height":-0.029130101},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.007978723,"height":-0.05546689},"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.07679521,"height":-0.07901037},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":1.0,"width":0.21575798,"height":-0.09058261},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"bounds":{"left":0.0028257978,"top":0.92897046,"width":0.07413564,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"bounds":{"left":0.0028257978,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"bounds":{"left":0.013796543,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"bounds":{"left":0.024933511,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"bounds":{"left":0.036070477,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"bounds":{"left":0.04720745,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"bounds":{"left":0.1846742,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"bounds":{"left":0.1966423,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"bounds":{"left":0.1939827,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"bounds":{"left":0.08361037,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"bounds":{"left":0.16605718,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"bounds":{"left":0.17935506,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"bounds":{"left":0.079288565,"top":0.14764565,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"bounds":{"left":0.079288565,"top":0.15003991,"width":0.1200133,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"bounds":{"left":0.10023271,"top":0.0,"width":0.04870346,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"bounds":{"left":0.11319814,"top":0.006384677,"width":0.025099734,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"bounds":{"left":0.14029256,"top":0.00518755,"width":0.064328454,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"bounds":{"left":0.11319814,"top":0.027134877,"width":0.041888297,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15708111,"top":0.02593775,"width":0.0026595744,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16173537,"top":0.027134877,"width":0.013962766,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.17769282,"top":0.02593775,"width":0.013297873,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.11319814,"top":0.047885075,"width":0.022273935,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.13746676,"top":0.04668795,"width":0.0014960107,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"bounds":{"left":0.11319814,"top":0.07741421,"width":0.022273935,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.13746676,"top":0.07621708,"width":0.004488032,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"bounds":{"left":0.14394946,"top":0.07741421,"width":0.025099734,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.17104389,"top":0.07621708,"width":0.004488032,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"bounds":{"left":0.1775266,"top":0.07741421,"width":0.019448139,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.111203454,"top":0.07621708,"width":0.09042553,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.13547207,"top":0.0981644,"width":0.013962766,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15142952,"top":0.09696728,"width":0.0026595744,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"bounds":{"left":0.15608378,"top":0.0981644,"width":0.02244016,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.18051861,"top":0.09696728,"width":0.013131649,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"bounds":{"left":0.11319814,"top":0.118914604,"width":0.025099734,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"bounds":{"left":0.14029256,"top":0.117717475,"width":0.013630319,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"bounds":{"left":0.11319814,"top":0.14844373,"width":0.041888297,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.15708111,"top":0.14724661,"width":0.024933511,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"bounds":{"left":0.11319814,"top":0.16919394,"width":0.0390625,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"bounds":{"left":0.15425532,"top":0.16799681,"width":0.011968086,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"bounds":{"left":0.11319814,"top":0.18994413,"width":0.03357713,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.14876994,"top":0.188747,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"bounds":{"left":0.11319814,"top":0.21947326,"width":0.027925532,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.14311835,"top":0.21827614,"width":0.024933511,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"bounds":{"left":0.11319814,"top":0.24022347,"width":0.03357713,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"bounds":{"left":0.14876994,"top":0.23902634,"width":0.011801862,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16256648,"top":0.24022347,"width":0.013962766,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.17852394,"top":0.23902634,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"bounds":{"left":0.10023271,"top":0.26855546,"width":0.05269282,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"bounds":{"left":0.11319814,"top":0.29928172,"width":0.027925532,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"bounds":{"left":0.14311835,"top":0.2980846,"width":0.027759308,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"bounds":{"left":0.11319814,"top":0.3200319,"width":0.044714097,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.15990691,"top":0.31883478,"width":0.0026595744,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16456117,"top":0.3200319,"width":0.013962766,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.18051861,"top":0.31883478,"width":0.013297873,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"bounds":{"left":0.11319814,"top":0.34078214,"width":0.025099734,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.14029256,"top":0.339585,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"bounds":{"left":0.11319814,"top":0.37031126,"width":0.025099734,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.14029256,"top":0.36911413,"width":0.004488032,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"bounds":{"left":0.14677526,"top":0.37031126,"width":0.022273935,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.17104389,"top":0.36911413,"width":0.024933511,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"bounds":{"left":0.11319814,"top":0.39106146,"width":0.044714097,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"bounds":{"left":0.15990691,"top":0.38986433,"width":0.011801862,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.17370346,"top":0.39106146,"width":0.013962766,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.1896609,"top":0.38986433,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"bounds":{"left":0.11319814,"top":0.42059058,"width":0.041888297,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.15708111,"top":0.41939345,"width":0.024933511,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"bounds":{"left":0.11319814,"top":0.44134077,"width":0.041888297,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"bounds":{"left":0.15708111,"top":0.44014364,"width":0.011801862,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"bounds":{"left":0.11319814,"top":0.46209097,"width":0.03357713,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.14876994,"top":0.46089387,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"bounds":{"left":0.11319814,"top":0.49162012,"width":0.027925532,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"bounds":{"left":0.14311835,"top":0.490423,"width":0.004488032,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"bounds":{"left":0.14960106,"top":0.49162012,"width":0.030585106,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"bounds":{"left":0.111203454,"top":0.490423,"width":0.07363697,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"bounds":{"left":0.13547207,"top":0.5123703,"width":0.027925532,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"bounds":{"left":0.1653923,"top":0.5111732,"width":0.0026595744,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"bounds":{"left":0.11319814,"top":0.5331205,"width":0.03357713,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.14876994,"top":0.5319234,"width":0.013131649,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16389628,"top":0.5331205,"width":0.013962766,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.17985372,"top":0.5319234,"width":0.0014960107,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"bounds":{"left":0.08759973,"top":0.5726257,"width":0.11702128,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"bounds":{"left":0.08759973,"top":0.57422185,"width":0.04438165,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"bounds":{"left":0.10023271,"top":0.60055864,"width":0.05867686,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"bounds":{"left":0.10023271,"top":0.60055864,"width":0.103390954,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"bounds":{"left":0.10023271,"top":0.6715882,"width":0.04637633,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"bounds":{"left":0.10023271,"top":0.6715882,"width":0.09923537,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"bounds":{"left":0.086269945,"top":0.75059855,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"bounds":{"left":0.09690824,"top":0.75059855,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"bounds":{"left":0.107546546,"top":0.75059855,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"bounds":{"left":0.11818484,"top":0.75059855,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"bounds":{"left":0.12882313,"top":0.75059855,"width":0.010638298,"height":0.025538707},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"bounds":{"left":0.13946144,"top":0.75059855,"width":0.010638298,"height":0.025538707},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"bounds":{"left":0.09291888,"top":0.8216281,"width":0.10638298,"height":0.01915403},"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":true,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"bounds":{"left":0.099567816,"top":0.82202715,"width":0.069980055,"height":0.018355945},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"bounds":{"left":0.091921546,"top":0.8216281,"width":0.0066489363,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"bounds":{"left":0.08892952,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"bounds":{"left":0.10488697,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"bounds":{"left":0.16007313,"top":0.85514766,"width":0.027925532,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"bounds":{"left":0.1653923,"top":0.8639266,"width":0.00930851,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Microphone","depth":19,"bounds":{"left":0.18999335,"top":0.85514766,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Send message","depth":19,"bounds":{"left":0.19630983,"top":0.85434955,"width":0.013962766,"height":0.033519555},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":false,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.","depth":17,"bounds":{"left":0.08510638,"top":0.90901834,"width":0.11951463,"height":0.025139665},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Your privacy & Gemini Opens in a new window","depth":17,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your privacy & Gemini","depth":18,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Opens in a new window","depth":19,"bounds":{"left":0.079288565,"top":0.92098963,"width":0.043218084,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Summarize page","depth":7,"bounds":{"left":0.08494016,"top":0.95730245,"width":0.053523935,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Summarize page","depth":9,"bounds":{"left":0.09059176,"top":0.96249,"width":0.042220745,"height":0.015163607},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Skip to content","depth":6,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Skip to content","depth":7,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open menu","depth":10,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"Homepage (g then d)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"jiminny","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"jiminny","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"app","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"app","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Search or jump to…","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Type","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to search","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Chat with Copilot","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Open Copilot…","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXMenuButton","text":"Create new...","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXLink","text":"All issues(g then i)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All pull requests","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All repositories","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"You have unread notifications(g then n)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open user navigation menu","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Repository navigation","depth":9,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Repository navigation","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Code","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Pull requests (29)","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pull requests","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"29","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Agents","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Agents","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Actions","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Actions","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Wiki","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Wiki","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Security and quality","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Security and quality","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Insights","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Insights","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Settings","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Settings","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Important update","depth":10,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Important update","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Review this update","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Review this update","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and manage your preferences in your","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"GitHub account settings","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"GitHub account settings","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Dismiss banner","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"JY-18091 | Update composer to support php 8.5 #12058 Edit title","depth":13,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"#","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"12058","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Edit title","depth":14,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Preview","depth":13,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXStaticText","text":"Preview","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Checks failing","depth":13,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Checks failing","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXMenuButton","text":"Code","depth":13,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXStaticText","text":"Code","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Open","depth":13,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"nikolaybiaivanov","depth":15,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"nikolaybiaivanov","depth":16,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"wants to merge 10 commits into","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"master","depth":15,"on_screen":false,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"master","depth":16,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"from","depth":16,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"JY-18091-upgrade-to-php-8-5","depth":16,"on_screen":false,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-18091-upgrade-to-php-8-5","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy head branch name to clipboard","depth":16,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Lines changed: 2199 additions & 3796 deletions","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Conversation (3)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Conversation","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"3","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Commits (10)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Commits","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"10","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"}]...
|
7967290915249381521
|
8923868658492259784
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-18091 | Update composer to support php 8.5 #12058 Edit title
JY-18091 | Update composer to support php 8.5
#
12058
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5
JY-18091-upgrade-to-php-8-5
Copy head branch name to clipboard
Lines changed: 2199 additions & 3796 deletions
Conversation (3)
Conversation
(
3
)
Commits (10)
Commits
(
10
)...
|
NULL
|
NULL
|
NULL
|
NULL
|
|
42443
|
NULL
|
0
|
2026-05-14T11:35:34.625395+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758534625_m1.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_1
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"}]...
|
-8121776989947856421
|
8923868654188903880
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest...
|
NULL
|
NULL
|
NULL
|
NULL
|
|
42444
|
NULL
|
0
|
2026-05-14T11:35:34.606337+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758534606_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.057063047,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.08060654,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.09217877,"width":0.101230055,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"bounds":{"left":0.0028257978,"top":0.11332801,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"bounds":{"left":0.015957447,"top":0.12490024,"width":0.076961435,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"bounds":{"left":0.0028257978,"top":0.14604948,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"bounds":{"left":0.015957447,"top":0.15762171,"width":0.08543883,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"bounds":{"left":0.0028257978,"top":0.17877094,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"bounds":{"left":0.015957447,"top":0.19034317,"width":0.04288564,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"bounds":{"left":0.0028257978,"top":0.21149242,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"bounds":{"left":0.015957447,"top":0.22306465,"width":0.12732713,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"bounds":{"left":0.0028257978,"top":0.2442139,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"bounds":{"left":0.015957447,"top":0.25578612,"width":0.033410903,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.27693537,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.28850758,"width":0.18068483,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"bounds":{"left":0.06732048,"top":0.28411812,"width":0.007978723,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"bounds":{"left":0.0028257978,"top":0.30965683,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"bounds":{"left":0.015957447,"top":0.32122904,"width":0.171875,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.3423783,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.35395053,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"bounds":{"left":0.0,"top":0.37509975,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"bounds":{"left":0.013297873,"top":0.386672,"width":0.029920213,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.41300878,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.4365523,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.4481245,"width":0.06632314,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.46927375,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.48084596,"width":0.064494684,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.5019952,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.51356745,"width":0.15658244,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.53990424,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.5634477,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.57501996,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.5961692,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6077414,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.62889063,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6404629,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.66161215,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.67318434,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.6995211,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.72306466,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.73463684,"width":0.091755316,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.7557861,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.76735836,"width":0.11619016,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.7885076,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.8000798,"width":0.18932846,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.82122904,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.8328013,"width":0.12898937,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.8539505,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.86552274,"width":0.079288565,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"bounds":{"left":0.0,"top":0.88667196,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"bounds":{"left":0.013297873,"top":0.8982442,"width":0.032247342,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0,"top":0.9193935,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.013297873,"top":0.93096566,"width":0.013131649,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.95211494,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.9636871,"width":0.041722074,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.9848364,"width":0.07962101,"height":0.0151636},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.99640864,"width":0.041722074,"height":0.0035913587},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":1.0,"width":0.07962101,"height":-0.01755786},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":1.0,"width":0.041722074,"height":-0.029130101},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.007978723,"height":-0.05546689},"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.07679521,"height":-0.07901037},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":1.0,"width":0.21575798,"height":-0.09058261},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"bounds":{"left":0.0028257978,"top":0.92897046,"width":0.07413564,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"bounds":{"left":0.0028257978,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"bounds":{"left":0.013796543,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"bounds":{"left":0.024933511,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"bounds":{"left":0.036070477,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"bounds":{"left":0.04720745,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"bounds":{"left":0.1846742,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"bounds":{"left":0.1966423,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"bounds":{"left":0.1939827,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"bounds":{"left":0.08361037,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"bounds":{"left":0.16605718,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"bounds":{"left":0.17935506,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"bounds":{"left":0.079288565,"top":0.14764565,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"bounds":{"left":0.079288565,"top":0.15003991,"width":0.1200133,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"}]...
|
-6605865723062302081
|
8923868654188903880
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated...
|
42442
|
NULL
|
NULL
|
NULL
|
|
42445
|
1558
|
0
|
2026-05-14T11:35:36.833724+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758536833_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP,
there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
.
Prior to PHP 8.
0,
the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.
5 but a developer's local environment or a specific CI runner is still on PHP 7.
4,
the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax,
human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container,
" making it clear that the instantiation happens first.
Without them,
in very complex one-liners,
it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated,
the inconsistency can lead to "style drift,
" where different developers follow different patterns,
making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.
0+.
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Stop response
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-18091 | Update composer to support php 8.5 #12058 Edit title
JY-18091 | Update composer to support php 8.5
#
12058
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5
JY-18091-upgrade-to-php-8-5
Copy head branch name to clipboard
Lines changed: 2199 additions & 3796 deletions
Conversation (3)
Conversation
(
3
)
Commits (10)
Commits
(
10...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.057063047,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.08060654,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.09217877,"width":0.101230055,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"bounds":{"left":0.0028257978,"top":0.11332801,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"bounds":{"left":0.015957447,"top":0.12490024,"width":0.076961435,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"bounds":{"left":0.0028257978,"top":0.14604948,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"bounds":{"left":0.015957447,"top":0.15762171,"width":0.08543883,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"bounds":{"left":0.0028257978,"top":0.17877094,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"bounds":{"left":0.015957447,"top":0.19034317,"width":0.04288564,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"bounds":{"left":0.0028257978,"top":0.21149242,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"bounds":{"left":0.015957447,"top":0.22306465,"width":0.12732713,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"bounds":{"left":0.0028257978,"top":0.2442139,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"bounds":{"left":0.015957447,"top":0.25578612,"width":0.033410903,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.27693537,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.28850758,"width":0.18068483,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"bounds":{"left":0.06732048,"top":0.28411812,"width":0.007978723,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"bounds":{"left":0.0028257978,"top":0.30965683,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"bounds":{"left":0.015957447,"top":0.32122904,"width":0.171875,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.3423783,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.35395053,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"bounds":{"left":0.0,"top":0.37509975,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"bounds":{"left":0.013297873,"top":0.386672,"width":0.029920213,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.41300878,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.4365523,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.4481245,"width":0.06632314,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.46927375,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.48084596,"width":0.064494684,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.5019952,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.51356745,"width":0.15658244,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.53990424,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.5634477,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.57501996,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.5961692,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6077414,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.62889063,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6404629,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.66161215,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.67318434,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.6995211,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.72306466,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.73463684,"width":0.091755316,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.7557861,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.76735836,"width":0.11619016,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.7885076,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.8000798,"width":0.18932846,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.82122904,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.8328013,"width":0.12898937,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.8539505,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.86552274,"width":0.079288565,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"bounds":{"left":0.0,"top":0.88667196,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"bounds":{"left":0.013297873,"top":0.8982442,"width":0.032247342,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0,"top":0.9193935,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.013297873,"top":0.93096566,"width":0.013131649,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.95211494,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.9636871,"width":0.041722074,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.9848364,"width":0.07962101,"height":0.0151636},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.99640864,"width":0.041722074,"height":0.0035913587},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":1.0,"width":0.07962101,"height":-0.01755786},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":1.0,"width":0.041722074,"height":-0.029130101},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.007978723,"height":-0.05546689},"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.07679521,"height":-0.07901037},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":1.0,"width":0.21575798,"height":-0.09058261},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"bounds":{"left":0.0028257978,"top":0.92897046,"width":0.07413564,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"bounds":{"left":0.0028257978,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"bounds":{"left":0.013796543,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"bounds":{"left":0.024933511,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"bounds":{"left":0.036070477,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"bounds":{"left":0.04720745,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"bounds":{"left":0.1846742,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"bounds":{"left":0.1966423,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"bounds":{"left":0.1939827,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"bounds":{"left":0.08361037,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"bounds":{"left":0.16605718,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"bounds":{"left":0.17935506,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"bounds":{"left":0.079288565,"top":0.14764565,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"bounds":{"left":0.079288565,"top":0.15003991,"width":0.1200133,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"bounds":{"left":0.11319814,"top":0.0,"width":0.03357713,"height":0.014764565},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.14876994,"top":0.0,"width":0.013131649,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16389628,"top":0.0,"width":0.013962766,"height":0.014764565},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.17985372,"top":0.0,"width":0.0014960107,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"bounds":{"left":0.08759973,"top":0.0,"width":0.11702128,"height":0.01915403},"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"bounds":{"left":0.08759973,"top":0.0,"width":0.04438165,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"bounds":{"left":0.10023271,"top":0.0,"width":0.05867686,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"bounds":{"left":0.10023271,"top":0.0,"width":0.103390954,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"bounds":{"left":0.10023271,"top":0.043894652,"width":0.04637633,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"bounds":{"left":0.10023271,"top":0.043894652,"width":0.09923537,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":22,"bounds":{"left":0.086269945,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":22,"bounds":{"left":0.09690824,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Share & export","depth":21,"bounds":{"left":0.107546546,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":22,"bounds":{"left":0.11818484,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":21,"bounds":{"left":0.12882313,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy prompt","depth":21,"bounds":{"left":0.1022274,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"bounds":{"left":0.116855055,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":false,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said are there soem potential issues?","depth":21,"bounds":{"left":0.13680187,"top":0.19313647,"width":0.065159574,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"bounds":{"left":0.079288565,"top":0.19393456,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"are there soem potential issues?","depth":23,"bounds":{"left":0.13680187,"top":0.19473264,"width":0.059175532,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Gemini said","depth":20,"bounds":{"left":0.08460771,"top":0.29449323,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"bounds":{"left":0.08460771,"top":0.29648843,"width":0.04105718,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"While this refactoring is syntactically correct for modern PHP,","depth":23,"bounds":{"left":0.08759973,"top":0.29768556,"width":0.11668883,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"there are a few practical and technical \"gotchas\" to consider when moving from","depth":23,"bounds":{"left":0.08759973,"top":0.31843576,"width":0.11037234,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new Class())->method()","depth":24,"bounds":{"left":0.10239362,"top":0.36113328,"width":0.06416223,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to","depth":23,"bounds":{"left":0.16855054,"top":0.35993615,"width":0.0076462766,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new Class()->method()","depth":24,"bounds":{"left":0.08759973,"top":0.36113328,"width":0.10172872,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":23,"bounds":{"left":0.13713431,"top":0.38068634,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"1. Language Compatibility (Backward Compatibility)","depth":22,"bounds":{"left":0.08759973,"top":0.42138866,"width":0.11702128,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"1. Language Compatibility (Backward Compatibility)","depth":23,"bounds":{"left":0.08759973,"top":0.42298484,"width":0.09757314,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The biggest risk is the PHP version itself.","depth":23,"bounds":{"left":0.08759973,"top":0.46847567,"width":0.09740692,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP < 8.0:","depth":25,"bounds":{"left":0.10023271,"top":0.4980048,"width":0.026263298,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"This change will cause a","depth":25,"bounds":{"left":0.12649602,"top":0.4980048,"width":0.060837764,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Parse Error","depth":25,"bounds":{"left":0.10023271,"top":0.4980048,"width":0.10305851,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":25,"bounds":{"left":0.11319814,"top":0.51875496,"width":0.0014960107,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Prior to PHP 8.","depth":25,"bounds":{"left":0.11469415,"top":0.51875496,"width":0.036236703,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"0,","depth":25,"bounds":{"left":0.15093085,"top":0.51875496,"width":0.004986702,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"the parser could not handle member access on a","depth":25,"bounds":{"left":0.10023271,"top":0.51875496,"width":0.09823803,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new","depth":26,"bounds":{"left":0.18085106,"top":0.54070234,"width":0.00831117,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"expression without parentheses.","depth":25,"bounds":{"left":0.10023271,"top":0.5395052,"width":0.09225399,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The \"Trap\":","depth":25,"bounds":{"left":0.10023271,"top":0.5897845,"width":0.029089095,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If your production environment is updated to PHP 8.","depth":25,"bounds":{"left":0.10023271,"top":0.5897845,"width":0.080119684,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"5 but a developer's local environment or a specific CI runner is still on PHP 7.","depth":25,"bounds":{"left":0.10023271,"top":0.6105347,"width":0.1043883,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"4,","depth":25,"bounds":{"left":0.1612367,"top":0.6520351,"width":0.004488032,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"the code will break immediately.","depth":25,"bounds":{"left":0.10023271,"top":0.6520351,"width":0.0987367,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"2. Operator Precedence and Readability","depth":22,"bounds":{"left":0.08759973,"top":0.7134876,"width":0.11702128,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"2. Operator Precedence and Readability","depth":23,"bounds":{"left":0.08759973,"top":0.7150838,"width":0.10388963,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"While the engine now understands this syntax,","depth":23,"bounds":{"left":0.08759973,"top":0.74142057,"width":0.11186835,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"human developers might find it slightly more ambiguous at a glance.","depth":23,"bounds":{"left":0.08759973,"top":0.74142057,"width":0.11319814,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Visual Grouping:","depth":25,"bounds":{"left":0.10023271,"top":0.8124501,"width":0.042386968,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The parentheses","depth":25,"bounds":{"left":0.14261968,"top":0.8124501,"width":0.04305186,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new Class())","depth":26,"bounds":{"left":0.10023271,"top":0.8136473,"width":0.10139628,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"act as a visual \"container,","depth":25,"bounds":{"left":0.12450133,"top":0.83320034,"width":0.06266622,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"\" making it clear that the instantiation happens first.","depth":25,"bounds":{"left":0.10023271,"top":0.83320034,"width":0.09059176,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Without them,","depth":25,"bounds":{"left":0.13331117,"top":0.8747007,"width":0.03523936,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"in very complex one-liners,","depth":25,"bounds":{"left":0.10023271,"top":0.8747007,"width":0.087101065,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"it can take a fraction of a second longer for a human to parse the execution order.","depth":25,"bounds":{"left":0.10023271,"top":0.8954509,"width":0.099734046,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Consistency:","depth":25,"bounds":{"left":0.10023271,"top":0.96648043,"width":0.03357713,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If only half the codebase is updated,","depth":25,"bounds":{"left":0.10023271,"top":0.96648043,"width":0.10139628,"height":0.033519566},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"the inconsistency can lead to \"style drift,","depth":25,"bounds":{"left":0.10023271,"top":0.98723066,"width":0.094913565,"height":0.0127693415},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"\" where different developers follow different patterns,","depth":25,"bounds":{"left":0.10023271,"top":1.0,"width":0.096409574,"height":-0.0079808235},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"making the code feel disorganized.","depth":25,"bounds":{"left":0.10023271,"top":1.0,"width":0.10239362,"height":-0.028730989},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"3. Tooling and IDE Support","depth":22,"bounds":{"left":0.08759973,"top":1.0,"width":0.11702128,"height":-0.090183616},"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"3. Tooling and IDE Support","depth":23,"bounds":{"left":0.08759973,"top":1.0,"width":0.06815159,"height":-0.09177971},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Static Analysis:","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or \"low-quality code\" if they aren't configured for PHP 8.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"0+.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"bounds":{"left":0.09291888,"top":0.8216281,"width":0.10638298,"height":0.01915403},"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"bounds":{"left":0.099567816,"top":0.82202715,"width":0.069980055,"height":0.018355945},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"bounds":{"left":0.091921546,"top":0.8216281,"width":0.0066489363,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"bounds":{"left":0.08892952,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"bounds":{"left":0.10488697,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"bounds":{"left":0.16007313,"top":0.85514766,"width":0.027925532,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"bounds":{"left":0.1653923,"top":0.8639266,"width":0.00930851,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Stop response","depth":19,"bounds":{"left":0.18932846,"top":0.85434955,"width":0.013962766,"height":0.033519555},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.","depth":17,"bounds":{"left":0.08510638,"top":0.90901834,"width":0.11951463,"height":0.025139665},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Your privacy & Gemini Opens in a new window","depth":17,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your privacy & Gemini","depth":18,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Opens in a new window","depth":19,"bounds":{"left":0.079288565,"top":0.92098963,"width":0.043218084,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Summarize page","depth":7,"bounds":{"left":0.08494016,"top":0.95730245,"width":0.053523935,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Summarize page","depth":9,"bounds":{"left":0.09059176,"top":0.96249,"width":0.042220745,"height":0.015163607},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Skip to content","depth":6,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Skip to content","depth":7,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open menu","depth":10,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"Homepage (g then d)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"jiminny","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"jiminny","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"app","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"app","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Search or jump to…","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Type","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to search","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Chat with Copilot","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Open Copilot…","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXMenuButton","text":"Create new...","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXLink","text":"All issues(g then i)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All pull requests","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All repositories","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"You have unread notifications(g then n)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open user navigation menu","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Repository navigation","depth":9,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Repository navigation","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Code","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Pull requests (29)","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pull requests","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"29","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Agents","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Agents","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Actions","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Actions","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Wiki","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Wiki","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Security and quality","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Security and quality","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Insights","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Insights","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Settings","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Settings","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Important update","depth":10,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Important update","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Review this update","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Review this update","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and manage your preferences in your","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"GitHub account settings","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"GitHub account settings","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Dismiss banner","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"JY-18091 | Update composer to support php 8.5 #12058 Edit title","depth":13,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"#","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"12058","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Edit title","depth":14,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Preview","depth":13,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXStaticText","text":"Preview","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Checks failing","depth":13,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Checks failing","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXMenuButton","text":"Code","depth":13,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXStaticText","text":"Code","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Open","depth":13,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"nikolaybiaivanov","depth":15,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"nikolaybiaivanov","depth":16,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"wants to merge 10 commits into","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"master","depth":15,"on_screen":false,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"master","depth":16,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"from","depth":16,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"JY-18091-upgrade-to-php-8-5","depth":16,"on_screen":false,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-18091-upgrade-to-php-8-5","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy head branch name to clipboard","depth":16,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Lines changed: 2199 additions & 3796 deletions","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Conversation (3)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Conversation","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"3","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Commits (10)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Commits","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"10","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"}]...
|
3824409550155424736
|
8923873056530398664
|
visual_change
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP,
there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
.
Prior to PHP 8.
0,
the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.
5 but a developer's local environment or a specific CI runner is still on PHP 7.
4,
the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax,
human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container,
" making it clear that the instantiation happens first.
Without them,
in very complex one-liners,
it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated,
the inconsistency can lead to "style drift,
" where different developers follow different patterns,
making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.
0+.
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Stop response
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-18091 | Update composer to support php 8.5 #12058 Edit title
JY-18091 | Update composer to support php 8.5
#
12058
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5
JY-18091-upgrade-to-php-8-5
Copy head branch name to clipboard
Lines changed: 2199 additions & 3796 deletions
Conversation (3)
Conversation
(
3
)
Commits (10)
Commits
(
10...
|
NULL
|
NULL
|
NULL
|
NULL
|
|
42446
|
1557
|
0
|
2026-05-14T11:35:37.540785+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758537540_m1.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_1
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":22,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":22,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false}]...
|
6267035936801947995
|
8923867554677276104
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response...
|
42443
|
NULL
|
NULL
|
NULL
|
|
42447
|
1558
|
1
|
2026-05-14T11:35:37.549375+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758537549_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.057063047,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.08060654,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.09217877,"width":0.101230055,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"bounds":{"left":0.0028257978,"top":0.11332801,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"bounds":{"left":0.015957447,"top":0.12490024,"width":0.076961435,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"bounds":{"left":0.0028257978,"top":0.14604948,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"bounds":{"left":0.015957447,"top":0.15762171,"width":0.08543883,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"bounds":{"left":0.0028257978,"top":0.17877094,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"bounds":{"left":0.015957447,"top":0.19034317,"width":0.04288564,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"bounds":{"left":0.0028257978,"top":0.21149242,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"bounds":{"left":0.015957447,"top":0.22306465,"width":0.12732713,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"bounds":{"left":0.0028257978,"top":0.2442139,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"bounds":{"left":0.015957447,"top":0.25578612,"width":0.033410903,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.27693537,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.28850758,"width":0.18068483,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"bounds":{"left":0.06732048,"top":0.28411812,"width":0.007978723,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"bounds":{"left":0.0028257978,"top":0.30965683,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"bounds":{"left":0.015957447,"top":0.32122904,"width":0.171875,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.3423783,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.35395053,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"bounds":{"left":0.0,"top":0.37509975,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"bounds":{"left":0.013297873,"top":0.386672,"width":0.029920213,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.41300878,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.4365523,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.4481245,"width":0.06632314,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.46927375,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.48084596,"width":0.064494684,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.5019952,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.51356745,"width":0.15658244,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.53990424,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.5634477,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.57501996,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.5961692,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6077414,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.62889063,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6404629,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.66161215,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.67318434,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.6995211,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.72306466,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.73463684,"width":0.091755316,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.7557861,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.76735836,"width":0.11619016,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.7885076,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.8000798,"width":0.18932846,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.82122904,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.8328013,"width":0.12898937,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.8539505,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.86552274,"width":0.079288565,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"bounds":{"left":0.0,"top":0.88667196,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"bounds":{"left":0.013297873,"top":0.8982442,"width":0.032247342,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0,"top":0.9193935,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.013297873,"top":0.93096566,"width":0.013131649,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.95211494,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.9636871,"width":0.041722074,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.9848364,"width":0.07962101,"height":0.0151636},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.99640864,"width":0.041722074,"height":0.0035913587},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":1.0,"width":0.07962101,"height":-0.01755786},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":1.0,"width":0.041722074,"height":-0.029130101},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.007978723,"height":-0.05546689},"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.07679521,"height":-0.07901037},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":1.0,"width":0.21575798,"height":-0.09058261},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"bounds":{"left":0.0028257978,"top":0.92897046,"width":0.07413564,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"bounds":{"left":0.0028257978,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"bounds":{"left":0.013796543,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"bounds":{"left":0.024933511,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"bounds":{"left":0.036070477,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"bounds":{"left":0.04720745,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"bounds":{"left":0.1846742,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"bounds":{"left":0.1966423,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"bounds":{"left":0.1939827,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"bounds":{"left":0.08361037,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"bounds":{"left":0.16605718,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"bounds":{"left":0.17935506,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"bounds":{"left":0.079288565,"top":0.14764565,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"bounds":{"left":0.079288565,"top":0.15003991,"width":0.1200133,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"bounds":{"left":0.11319814,"top":0.0,"width":0.03357713,"height":0.014764565},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.14876994,"top":0.0,"width":0.013131649,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16389628,"top":0.0,"width":0.013962766,"height":0.014764565},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.17985372,"top":0.0,"width":0.0014960107,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"bounds":{"left":0.08759973,"top":0.0,"width":0.11702128,"height":0.01915403},"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"bounds":{"left":0.08759973,"top":0.0,"width":0.04438165,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"bounds":{"left":0.10023271,"top":0.0,"width":0.05867686,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"bounds":{"left":0.10023271,"top":0.0,"width":0.103390954,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"bounds":{"left":0.10023271,"top":0.043894652,"width":0.04637633,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"bounds":{"left":0.10023271,"top":0.043894652,"width":0.09923537,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":22,"bounds":{"left":0.086269945,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":22,"bounds":{"left":0.09690824,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Share & export","depth":21,"bounds":{"left":0.107546546,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":22,"bounds":{"left":0.11818484,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":21,"bounds":{"left":0.12882313,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false}]...
|
8915017183362462720
|
8923867554677276104
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options...
|
42445
|
NULL
|
NULL
|
NULL
|
|
42448
|
1558
|
2
|
2026-05-14T11:35:39.814965+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758539814_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.057063047,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.08060654,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.09217877,"width":0.101230055,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"bounds":{"left":0.0028257978,"top":0.11332801,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"bounds":{"left":0.015957447,"top":0.12490024,"width":0.076961435,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"bounds":{"left":0.0028257978,"top":0.14604948,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"bounds":{"left":0.015957447,"top":0.15762171,"width":0.08543883,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"bounds":{"left":0.0028257978,"top":0.17877094,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"bounds":{"left":0.015957447,"top":0.19034317,"width":0.04288564,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"bounds":{"left":0.0028257978,"top":0.21149242,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"bounds":{"left":0.015957447,"top":0.22306465,"width":0.12732713,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"bounds":{"left":0.0028257978,"top":0.2442139,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"bounds":{"left":0.015957447,"top":0.25578612,"width":0.033410903,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.27693537,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.28850758,"width":0.18068483,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"bounds":{"left":0.06732048,"top":0.28411812,"width":0.007978723,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"bounds":{"left":0.0028257978,"top":0.30965683,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"bounds":{"left":0.015957447,"top":0.32122904,"width":0.171875,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.3423783,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.35395053,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"bounds":{"left":0.0,"top":0.37509975,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"bounds":{"left":0.013297873,"top":0.386672,"width":0.029920213,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.41300878,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.4365523,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.4481245,"width":0.06632314,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.46927375,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.48084596,"width":0.064494684,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.5019952,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.51356745,"width":0.15658244,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.53990424,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.5634477,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.57501996,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.5961692,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6077414,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.62889063,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6404629,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.66161215,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.67318434,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.6995211,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.72306466,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.73463684,"width":0.091755316,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.7557861,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.76735836,"width":0.11619016,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.7885076,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.8000798,"width":0.18932846,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.82122904,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.8328013,"width":0.12898937,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.8539505,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.86552274,"width":0.079288565,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"bounds":{"left":0.0,"top":0.88667196,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"bounds":{"left":0.013297873,"top":0.8982442,"width":0.032247342,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0,"top":0.9193935,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.013297873,"top":0.93096566,"width":0.013131649,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.95211494,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.9636871,"width":0.041722074,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.9848364,"width":0.07962101,"height":0.0151636},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.99640864,"width":0.041722074,"height":0.0035913587},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":1.0,"width":0.07962101,"height":-0.01755786},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":1.0,"width":0.041722074,"height":-0.029130101},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.007978723,"height":-0.05546689},"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.07679521,"height":-0.07901037},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":1.0,"width":0.21575798,"height":-0.09058261},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"bounds":{"left":0.0028257978,"top":0.92897046,"width":0.07413564,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"bounds":{"left":0.0028257978,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"bounds":{"left":0.013796543,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"bounds":{"left":0.024933511,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"bounds":{"left":0.036070477,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"bounds":{"left":0.04720745,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"bounds":{"left":0.1846742,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"bounds":{"left":0.1966423,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"bounds":{"left":0.1939827,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"bounds":{"left":0.08361037,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"bounds":{"left":0.16605718,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"bounds":{"left":0.17935506,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"bounds":{"left":0.079288565,"top":0.14764565,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"bounds":{"left":0.079288565,"top":0.15003991,"width":0.1200133,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"bounds":{"left":0.11319814,"top":0.0,"width":0.03357713,"height":0.014764565},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.14876994,"top":0.0,"width":0.013131649,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16389628,"top":0.0,"width":0.013962766,"height":0.014764565},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.17985372,"top":0.0,"width":0.0014960107,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"bounds":{"left":0.08759973,"top":0.0,"width":0.11702128,"height":0.01915403},"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"bounds":{"left":0.08759973,"top":0.0,"width":0.04438165,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"bounds":{"left":0.10023271,"top":0.0,"width":0.05867686,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"bounds":{"left":0.10023271,"top":0.0,"width":0.103390954,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"bounds":{"left":0.10023271,"top":0.043894652,"width":0.04637633,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"bounds":{"left":0.10023271,"top":0.043894652,"width":0.09923537,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":22,"bounds":{"left":0.086269945,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":22,"bounds":{"left":0.09690824,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Share & export","depth":21,"bounds":{"left":0.107546546,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":22,"bounds":{"left":0.11818484,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":21,"bounds":{"left":0.12882313,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy prompt","depth":21,"bounds":{"left":0.1022274,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"bounds":{"left":0.116855055,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":false,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said are there soem potential issues?","depth":21,"bounds":{"left":0.13680187,"top":0.19313647,"width":0.065159574,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"bounds":{"left":0.079288565,"top":0.19393456,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"are there soem potential issues?","depth":23,"bounds":{"left":0.13680187,"top":0.19473264,"width":0.059175532,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Gemini said","depth":20,"bounds":{"left":0.08460771,"top":0.29449323,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"bounds":{"left":0.08460771,"top":0.29648843,"width":0.04105718,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"While this refactoring is syntactically correct for modern PHP, there are a few practical and technical \"gotchas\" to consider when moving from","depth":23,"bounds":{"left":0.08759973,"top":0.29768556,"width":0.11668883,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new Class())->method()","depth":24,"bounds":{"left":0.10239362,"top":0.36113328,"width":0.06416223,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to","depth":23,"bounds":{"left":0.16855054,"top":0.35993615,"width":0.0076462766,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new Class()->method()","depth":24,"bounds":{"left":0.08759973,"top":0.36113328,"width":0.10172872,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":23,"bounds":{"left":0.13713431,"top":0.38068634,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"1. Language Compatibility (Backward Compatibility)","depth":22,"bounds":{"left":0.08759973,"top":0.42138866,"width":0.11702128,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"1. Language Compatibility (Backward Compatibility)","depth":23,"bounds":{"left":0.08759973,"top":0.42298484,"width":0.09757314,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The biggest risk is the PHP version itself.","depth":23,"bounds":{"left":0.08759973,"top":0.46847567,"width":0.09740692,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP < 8.0:","depth":25,"bounds":{"left":0.10023271,"top":0.4980048,"width":0.026263298,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"This change will cause a","depth":25,"bounds":{"left":0.12649602,"top":0.4980048,"width":0.060837764,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Parse Error","depth":25,"bounds":{"left":0.10023271,"top":0.4980048,"width":0.10305851,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":". Prior to PHP 8.0, the parser could not handle member access on a","depth":25,"bounds":{"left":0.10023271,"top":0.51875496,"width":0.09823803,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new","depth":26,"bounds":{"left":0.18085106,"top":0.54070234,"width":0.00831117,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"expression without parentheses.","depth":25,"bounds":{"left":0.10023271,"top":0.5395052,"width":0.09225399,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The \"Trap\":","depth":25,"bounds":{"left":0.10023271,"top":0.5897845,"width":0.029089095,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.","depth":25,"bounds":{"left":0.10023271,"top":0.5897845,"width":0.1043883,"height":0.09936153},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"2. Operator Precedence and Readability","depth":22,"bounds":{"left":0.08759973,"top":0.7134876,"width":0.11702128,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"2. Operator Precedence and Readability","depth":23,"bounds":{"left":0.08759973,"top":0.7150838,"width":0.10388963,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.","depth":23,"bounds":{"left":0.08759973,"top":0.74142057,"width":0.11319814,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Visual Grouping:","depth":25,"bounds":{"left":0.10023271,"top":0.8124501,"width":0.042386968,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"bounds":{"left":0.09291888,"top":0.8216281,"width":0.10638298,"height":0.01915403},"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"bounds":{"left":0.099567816,"top":0.82202715,"width":0.069980055,"height":0.018355945},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"bounds":{"left":0.091921546,"top":0.8216281,"width":0.0066489363,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"bounds":{"left":0.08892952,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"bounds":{"left":0.10488697,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"bounds":{"left":0.16007313,"top":0.85514766,"width":0.027925532,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"bounds":{"left":0.1653923,"top":0.8639266,"width":0.00930851,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Microphone","depth":19,"bounds":{"left":0.18999335,"top":0.85514766,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Send message","depth":19,"bounds":{"left":0.19630983,"top":0.85434955,"width":0.013962766,"height":0.033519555},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":false,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.","depth":17,"bounds":{"left":0.08510638,"top":0.90901834,"width":0.11951463,"height":0.025139665},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Your privacy & Gemini Opens in a new window","depth":17,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your privacy & Gemini","depth":18,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Opens in a new window","depth":19,"bounds":{"left":0.079288565,"top":0.92098963,"width":0.043218084,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Summarize page","depth":7,"bounds":{"left":0.08494016,"top":0.95730245,"width":0.053523935,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Summarize page","depth":9,"bounds":{"left":0.09059176,"top":0.96249,"width":0.042220745,"height":0.015163607},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Skip to content","depth":6,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Skip to content","depth":7,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open menu","depth":10,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"Homepage (g then d)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"jiminny","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"jiminny","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"app","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"app","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Search or jump to…","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Type","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"}]...
|
-5898758306612255761
|
4311056740149640648
|
visual_change
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type...
|
NULL
|
NULL
|
NULL
|
NULL
|
|
42449
|
1558
|
3
|
2026-05-14T11:35:48.886790+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758548886_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor
Production Crash
Developer Confusion
Linting Errors
Level
High
Low
Medium
Mitigation
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Update team style guides to reflect PHP 8.x standards.
Update CI/CD linting rules to support modern PHP syntax.
Copy table
Are you planning to deploy this to an environment where you are certain the PHP version is strictly 8.0 or higher?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.057063047,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.08060654,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.09217877,"width":0.101230055,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"bounds":{"left":0.0028257978,"top":0.11332801,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"bounds":{"left":0.015957447,"top":0.12490024,"width":0.076961435,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"bounds":{"left":0.0028257978,"top":0.14604948,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"bounds":{"left":0.015957447,"top":0.15762171,"width":0.08543883,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"bounds":{"left":0.0028257978,"top":0.17877094,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"bounds":{"left":0.015957447,"top":0.19034317,"width":0.04288564,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"bounds":{"left":0.0028257978,"top":0.21149242,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"bounds":{"left":0.015957447,"top":0.22306465,"width":0.12732713,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"bounds":{"left":0.0028257978,"top":0.2442139,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"bounds":{"left":0.015957447,"top":0.25578612,"width":0.033410903,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.27693537,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.28850758,"width":0.18068483,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"bounds":{"left":0.06732048,"top":0.28411812,"width":0.007978723,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"bounds":{"left":0.0028257978,"top":0.30965683,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"bounds":{"left":0.015957447,"top":0.32122904,"width":0.171875,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.3423783,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.35395053,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"bounds":{"left":0.0,"top":0.37509975,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"bounds":{"left":0.013297873,"top":0.386672,"width":0.029920213,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.41300878,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.4365523,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.4481245,"width":0.06632314,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.46927375,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.48084596,"width":0.064494684,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.5019952,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.51356745,"width":0.15658244,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.53990424,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.5634477,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.57501996,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.5961692,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6077414,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.62889063,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6404629,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.66161215,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.67318434,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.6995211,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.72306466,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.73463684,"width":0.091755316,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.7557861,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.76735836,"width":0.11619016,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.7885076,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.8000798,"width":0.18932846,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.82122904,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.8328013,"width":0.12898937,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.8539505,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.86552274,"width":0.079288565,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"bounds":{"left":0.0,"top":0.88667196,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"bounds":{"left":0.013297873,"top":0.8982442,"width":0.032247342,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0,"top":0.9193935,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.013297873,"top":0.93096566,"width":0.013131649,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.95211494,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.9636871,"width":0.041722074,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.9848364,"width":0.07962101,"height":0.0151636},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.99640864,"width":0.041722074,"height":0.0035913587},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":1.0,"width":0.07962101,"height":-0.01755786},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":1.0,"width":0.041722074,"height":-0.029130101},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.007978723,"height":-0.05546689},"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.07679521,"height":-0.07901037},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":1.0,"width":0.21575798,"height":-0.09058261},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"bounds":{"left":0.0028257978,"top":0.92897046,"width":0.07413564,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"bounds":{"left":0.0028257978,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"bounds":{"left":0.013796543,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"bounds":{"left":0.024933511,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"bounds":{"left":0.036070477,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"bounds":{"left":0.04720745,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"bounds":{"left":0.1846742,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"bounds":{"left":0.1966423,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"bounds":{"left":0.1939827,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"bounds":{"left":0.08361037,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"bounds":{"left":0.16605718,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"bounds":{"left":0.17935506,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"bounds":{"left":0.079288565,"top":0.14764565,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"bounds":{"left":0.079288565,"top":0.15003991,"width":0.1200133,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"bounds":{"left":0.11319814,"top":0.0,"width":0.03357713,"height":0.014764565},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.14876994,"top":0.0,"width":0.013131649,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16389628,"top":0.0,"width":0.013962766,"height":0.014764565},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.17985372,"top":0.0,"width":0.0014960107,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"bounds":{"left":0.08759973,"top":0.0,"width":0.11702128,"height":0.01915403},"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"bounds":{"left":0.08759973,"top":0.0,"width":0.04438165,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"bounds":{"left":0.10023271,"top":0.0,"width":0.05867686,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"bounds":{"left":0.10023271,"top":0.0,"width":0.103390954,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"bounds":{"left":0.10023271,"top":0.043894652,"width":0.04637633,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"bounds":{"left":0.10023271,"top":0.043894652,"width":0.09923537,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":22,"bounds":{"left":0.086269945,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":22,"bounds":{"left":0.09690824,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Share & export","depth":21,"bounds":{"left":0.107546546,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":22,"bounds":{"left":0.11818484,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":21,"bounds":{"left":0.12882313,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy prompt","depth":21,"bounds":{"left":0.1022274,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"bounds":{"left":0.116855055,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said are there soem potential issues?","depth":21,"bounds":{"left":0.13680187,"top":0.19313647,"width":0.065159574,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"bounds":{"left":0.079288565,"top":0.19393456,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"are there soem potential issues?","depth":23,"bounds":{"left":0.13680187,"top":0.19473264,"width":0.059175532,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Listen","depth":21,"bounds":{"left":0.1939827,"top":0.26336792,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"bounds":{"left":0.08460771,"top":0.29449323,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"bounds":{"left":0.08460771,"top":0.29648843,"width":0.04105718,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"While this refactoring is syntactically correct for modern PHP, there are a few practical and technical \"gotchas\" to consider when moving from","depth":23,"bounds":{"left":0.08759973,"top":0.29768556,"width":0.11668883,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new Class())->method()","depth":24,"bounds":{"left":0.10239362,"top":0.36113328,"width":0.06416223,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to","depth":23,"bounds":{"left":0.16855054,"top":0.35993615,"width":0.0076462766,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new Class()->method()","depth":24,"bounds":{"left":0.08759973,"top":0.36113328,"width":0.10172872,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":23,"bounds":{"left":0.13713431,"top":0.38068634,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"1. Language Compatibility (Backward Compatibility)","depth":22,"bounds":{"left":0.08759973,"top":0.42138866,"width":0.11702128,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"1. Language Compatibility (Backward Compatibility)","depth":23,"bounds":{"left":0.08759973,"top":0.42298484,"width":0.09757314,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The biggest risk is the PHP version itself.","depth":23,"bounds":{"left":0.08759973,"top":0.46847567,"width":0.09740692,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP < 8.0:","depth":25,"bounds":{"left":0.10023271,"top":0.4980048,"width":0.026263298,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"This change will cause a","depth":25,"bounds":{"left":0.12649602,"top":0.4980048,"width":0.060837764,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Parse Error","depth":25,"bounds":{"left":0.10023271,"top":0.4980048,"width":0.10305851,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":". Prior to PHP 8.0, the parser could not handle member access on a","depth":25,"bounds":{"left":0.10023271,"top":0.51875496,"width":0.09823803,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new","depth":26,"bounds":{"left":0.18085106,"top":0.54070234,"width":0.00831117,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"expression without parentheses.","depth":25,"bounds":{"left":0.10023271,"top":0.5395052,"width":0.09225399,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The \"Trap\":","depth":25,"bounds":{"left":0.10023271,"top":0.5897845,"width":0.029089095,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.","depth":25,"bounds":{"left":0.10023271,"top":0.5897845,"width":0.1043883,"height":0.09936153},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"2. Operator Precedence and Readability","depth":22,"bounds":{"left":0.08759973,"top":0.7134876,"width":0.11702128,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"2. Operator Precedence and Readability","depth":23,"bounds":{"left":0.08759973,"top":0.7150838,"width":0.10388963,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.","depth":23,"bounds":{"left":0.08759973,"top":0.74142057,"width":0.11319814,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Visual Grouping:","depth":25,"bounds":{"left":0.10023271,"top":0.8124501,"width":0.042386968,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The parentheses","depth":25,"bounds":{"left":0.14261968,"top":0.8124501,"width":0.04305186,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new Class())","depth":26,"bounds":{"left":0.10023271,"top":0.8136473,"width":0.10139628,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"act as a visual \"container,\" making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.","depth":25,"bounds":{"left":0.10023271,"top":0.83320034,"width":0.099734046,"height":0.12011173},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Consistency:","depth":25,"bounds":{"left":0.10023271,"top":0.96648043,"width":0.03357713,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If only half the codebase is updated, the inconsistency can lead to \"style drift,\" where different developers follow different patterns, making the code feel disorganized.","depth":25,"bounds":{"left":0.10023271,"top":0.96648043,"width":0.10239362,"height":0.033519566},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"3. Tooling and IDE Support","depth":22,"bounds":{"left":0.08759973,"top":1.0,"width":0.11702128,"height":-0.090183616},"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"3. Tooling and IDE Support","depth":23,"bounds":{"left":0.08759973,"top":1.0,"width":0.06815159,"height":-0.09177971},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Static Analysis:","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or \"low-quality code\" if they aren't configured for PHP 8.0+.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Automated Refactoring:","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If this change was done via an automated tool (like Rector), it is usually safe. However, if done via \"Find and Replace,\" there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"4. Error Reporting Sensitivity","depth":22,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"4. Error Reporting Sensitivity","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"In some edge cases, if the constructor of the class throws an exception:","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The stack trace remains the same, but when debugging \"on the fly\" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"before","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"the method call in a watch window.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Summary of Risk Levels","depth":22,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Summary of Risk Levels","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Risk Factor","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Level","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Mitigation","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Production Crash","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"High","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Ensure","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"platform","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"in","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"composer.json","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is set to","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"8.0","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"or higher.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Developer Confusion","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Low","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update team style guides to reflect PHP 8.x standards.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Linting Errors","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Medium","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update CI/CD linting rules to support modern PHP syntax.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Risk Factor","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Production Crash","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Developer Confusion","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Linting Errors","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Level","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"High","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Low","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Medium","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Mitigation","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Ensure","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"platform","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"in","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"composer.json","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is set to","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"8.0","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"or higher.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update team style guides to reflect PHP 8.x standards.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update CI/CD linting rules to support modern PHP syntax.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy table","depth":23,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Are you planning to deploy this to an environment where you are certain the PHP version is strictly 8.0 or higher?","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"bounds":{"left":0.09291888,"top":0.8216281,"width":0.10638298,"height":0.01915403},"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"bounds":{"left":0.099567816,"top":0.82202715,"width":0.069980055,"height":0.018355945},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"bounds":{"left":0.091921546,"top":0.8216281,"width":0.0066489363,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"bounds":{"left":0.08892952,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"bounds":{"left":0.10488697,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"bounds":{"left":0.16007313,"top":0.85514766,"width":0.027925532,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"bounds":{"left":0.1653923,"top":0.8639266,"width":0.00930851,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Microphone","depth":19,"bounds":{"left":0.18999335,"top":0.85514766,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Send message","depth":19,"bounds":{"left":0.19630983,"top":0.85434955,"width":0.013962766,"height":0.033519555},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":false,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.","depth":17,"bounds":{"left":0.08510638,"top":0.90901834,"width":0.11951463,"height":0.025139665},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Your privacy & Gemini Opens in a new window","depth":17,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your privacy & Gemini","depth":18,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Opens in a new window","depth":19,"bounds":{"left":0.079288565,"top":0.92098963,"width":0.043218084,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Summarize page","depth":7,"bounds":{"left":0.08494016,"top":0.95730245,"width":0.053523935,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Summarize page","depth":9,"bounds":{"left":0.09059176,"top":0.96249,"width":0.042220745,"height":0.015163607},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Skip to content","depth":6,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Skip to content","depth":7,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open menu","depth":10,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"Homepage (g then d)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"jiminny","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"jiminny","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"}]...
|
5762006806674699057
|
8887843160008195528
|
visual_change
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor
Production Crash
Developer Confusion
Linting Errors
Level
High
Low
Medium
Mitigation
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Update team style guides to reflect PHP 8.x standards.
Update CI/CD linting rules to support modern PHP syntax.
Copy table
Are you planning to deploy this to an environment where you are certain the PHP version is strictly 8.0 or higher?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny...
|
42448
|
NULL
|
NULL
|
NULL
|
|
42450
|
1557
|
1
|
2026-05-14T11:35:50.257480+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758550257_m1.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_1
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor
Production Crash
Developer Confusion
Linting Errors
Level
High
Low
Medium
Mitigation...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":22,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":22,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Share & export","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":22,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said are there soem potential issues?","depth":21,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"are there soem potential issues?","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Listen","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"While this refactoring is syntactically correct for modern PHP, there are a few practical and technical \"gotchas\" to consider when moving from","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new Class())->method()","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new Class()->method()","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"1. Language Compatibility (Backward Compatibility)","depth":22,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"1. Language Compatibility (Backward Compatibility)","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The biggest risk is the PHP version itself.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP < 8.0:","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"This change will cause a","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Parse Error","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":". Prior to PHP 8.0, the parser could not handle member access on a","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"expression without parentheses.","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The \"Trap\":","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"2. Operator Precedence and Readability","depth":22,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"2. Operator Precedence and Readability","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Visual Grouping:","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The parentheses","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new Class())","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"act as a visual \"container,\" making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Consistency:","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If only half the codebase is updated, the inconsistency can lead to \"style drift,\" where different developers follow different patterns, making the code feel disorganized.","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"3. Tooling and IDE Support","depth":22,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"3. Tooling and IDE Support","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Static Analysis:","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or \"low-quality code\" if they aren't configured for PHP 8.0+.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Automated Refactoring:","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If this change was done via an automated tool (like Rector), it is usually safe. However, if done via \"Find and Replace,\" there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"4. Error Reporting Sensitivity","depth":22,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"4. Error Reporting Sensitivity","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"In some edge cases, if the constructor of the class throws an exception:","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The stack trace remains the same, but when debugging \"on the fly\" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"before","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"the method call in a watch window.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Summary of Risk Levels","depth":22,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Summary of Risk Levels","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Risk Factor","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Level","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Mitigation","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Production Crash","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"High","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Ensure","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"platform","depth":28,"bounds":{"left":0.0,"top":1.0,"width":0.046875,"height":-0.0027778149},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"in","depth":27,"bounds":{"left":0.0,"top":1.0,"width":0.011458334,"height":-0.0011111498},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"composer.json","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is set to","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"8.0","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"or higher.","depth":27,"bounds":{"left":0.0,"top":1.0,"width":0.050694443,"height":-0.046666622},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Developer Confusion","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Low","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update team style guides to reflect PHP 8.x standards.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Linting Errors","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Medium","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update CI/CD linting rules to support modern PHP syntax.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Risk Factor","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Production Crash","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Developer Confusion","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Linting Errors","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Level","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"High","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Low","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Medium","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Mitigation","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"}]...
|
5758913742805210507
|
8311382407696383432
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor
Production Crash
Developer Confusion
Linting Errors
Level
High
Low
Medium
Mitigation...
|
NULL
|
NULL
|
NULL
|
NULL
|
|
42451
|
1558
|
4
|
2026-05-14T11:35:50.247390+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758550247_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor
Production Crash
Developer Confusion
Linting Errors
Level
High...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.057063047,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.08060654,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.09217877,"width":0.101230055,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"bounds":{"left":0.0028257978,"top":0.11332801,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"bounds":{"left":0.015957447,"top":0.12490024,"width":0.076961435,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"bounds":{"left":0.0028257978,"top":0.14604948,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"bounds":{"left":0.015957447,"top":0.15762171,"width":0.08543883,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"bounds":{"left":0.0028257978,"top":0.17877094,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"bounds":{"left":0.015957447,"top":0.19034317,"width":0.04288564,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"bounds":{"left":0.0028257978,"top":0.21149242,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"bounds":{"left":0.015957447,"top":0.22306465,"width":0.12732713,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"bounds":{"left":0.0028257978,"top":0.2442139,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"bounds":{"left":0.015957447,"top":0.25578612,"width":0.033410903,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.27693537,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.28850758,"width":0.18068483,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"bounds":{"left":0.06732048,"top":0.28411812,"width":0.007978723,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"bounds":{"left":0.0028257978,"top":0.30965683,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"bounds":{"left":0.015957447,"top":0.32122904,"width":0.171875,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.3423783,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.35395053,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"bounds":{"left":0.0,"top":0.37509975,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"bounds":{"left":0.013297873,"top":0.386672,"width":0.029920213,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.41300878,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.4365523,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.4481245,"width":0.06632314,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.46927375,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.48084596,"width":0.064494684,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.5019952,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.51356745,"width":0.15658244,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.53990424,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.5634477,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.57501996,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.5961692,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6077414,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.62889063,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6404629,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.66161215,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.67318434,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.6995211,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.72306466,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.73463684,"width":0.091755316,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.7557861,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.76735836,"width":0.11619016,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.7885076,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.8000798,"width":0.18932846,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.82122904,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.8328013,"width":0.12898937,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.8539505,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.86552274,"width":0.079288565,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"bounds":{"left":0.0,"top":0.88667196,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"bounds":{"left":0.013297873,"top":0.8982442,"width":0.032247342,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0,"top":0.9193935,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.013297873,"top":0.93096566,"width":0.013131649,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.95211494,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.9636871,"width":0.041722074,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.9848364,"width":0.07962101,"height":0.0151636},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.99640864,"width":0.041722074,"height":0.0035913587},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":1.0,"width":0.07962101,"height":-0.01755786},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":1.0,"width":0.041722074,"height":-0.029130101},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.007978723,"height":-0.05546689},"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.07679521,"height":-0.07901037},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":1.0,"width":0.21575798,"height":-0.09058261},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"bounds":{"left":0.0028257978,"top":0.92897046,"width":0.07413564,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"bounds":{"left":0.0028257978,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"bounds":{"left":0.013796543,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"bounds":{"left":0.024933511,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"bounds":{"left":0.036070477,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"bounds":{"left":0.04720745,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"bounds":{"left":0.1846742,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"bounds":{"left":0.1966423,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"bounds":{"left":0.1939827,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"bounds":{"left":0.08361037,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"bounds":{"left":0.16605718,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"bounds":{"left":0.17935506,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"bounds":{"left":0.079288565,"top":0.14764565,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"bounds":{"left":0.079288565,"top":0.15003991,"width":0.1200133,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"bounds":{"left":0.11319814,"top":0.0,"width":0.03357713,"height":0.014764565},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.14876994,"top":0.0,"width":0.013131649,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16389628,"top":0.0,"width":0.013962766,"height":0.014764565},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.17985372,"top":0.0,"width":0.0014960107,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"bounds":{"left":0.08759973,"top":0.0,"width":0.11702128,"height":0.01915403},"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"bounds":{"left":0.08759973,"top":0.0,"width":0.04438165,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"bounds":{"left":0.10023271,"top":0.0,"width":0.05867686,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"bounds":{"left":0.10023271,"top":0.0,"width":0.103390954,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"bounds":{"left":0.10023271,"top":0.043894652,"width":0.04637633,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"bounds":{"left":0.10023271,"top":0.043894652,"width":0.09923537,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":22,"bounds":{"left":0.086269945,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":22,"bounds":{"left":0.09690824,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Share & export","depth":21,"bounds":{"left":0.107546546,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":22,"bounds":{"left":0.11818484,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":21,"bounds":{"left":0.12882313,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy prompt","depth":21,"bounds":{"left":0.1022274,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"bounds":{"left":0.116855055,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said are there soem potential issues?","depth":21,"bounds":{"left":0.13680187,"top":0.19313647,"width":0.065159574,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"bounds":{"left":0.079288565,"top":0.19393456,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"are there soem potential issues?","depth":23,"bounds":{"left":0.13680187,"top":0.19473264,"width":0.059175532,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Listen","depth":21,"bounds":{"left":0.1939827,"top":0.26336792,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"bounds":{"left":0.08460771,"top":0.29449323,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"bounds":{"left":0.08460771,"top":0.29648843,"width":0.04105718,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"While this refactoring is syntactically correct for modern PHP, there are a few practical and technical \"gotchas\" to consider when moving from","depth":23,"bounds":{"left":0.08759973,"top":0.29768556,"width":0.11668883,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new Class())->method()","depth":24,"bounds":{"left":0.10239362,"top":0.36113328,"width":0.06416223,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to","depth":23,"bounds":{"left":0.16855054,"top":0.35993615,"width":0.0076462766,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new Class()->method()","depth":24,"bounds":{"left":0.08759973,"top":0.36113328,"width":0.10172872,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":23,"bounds":{"left":0.13713431,"top":0.38068634,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"1. Language Compatibility (Backward Compatibility)","depth":22,"bounds":{"left":0.08759973,"top":0.42138866,"width":0.11702128,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"1. Language Compatibility (Backward Compatibility)","depth":23,"bounds":{"left":0.08759973,"top":0.42298484,"width":0.09757314,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The biggest risk is the PHP version itself.","depth":23,"bounds":{"left":0.08759973,"top":0.46847567,"width":0.09740692,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP < 8.0:","depth":25,"bounds":{"left":0.10023271,"top":0.4980048,"width":0.026263298,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"This change will cause a","depth":25,"bounds":{"left":0.12649602,"top":0.4980048,"width":0.060837764,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Parse Error","depth":25,"bounds":{"left":0.10023271,"top":0.4980048,"width":0.10305851,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":". Prior to PHP 8.0, the parser could not handle member access on a","depth":25,"bounds":{"left":0.10023271,"top":0.51875496,"width":0.09823803,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new","depth":26,"bounds":{"left":0.18085106,"top":0.54070234,"width":0.00831117,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"expression without parentheses.","depth":25,"bounds":{"left":0.10023271,"top":0.5395052,"width":0.09225399,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The \"Trap\":","depth":25,"bounds":{"left":0.10023271,"top":0.5897845,"width":0.029089095,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.","depth":25,"bounds":{"left":0.10023271,"top":0.5897845,"width":0.1043883,"height":0.09936153},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"2. Operator Precedence and Readability","depth":22,"bounds":{"left":0.08759973,"top":0.7134876,"width":0.11702128,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"2. Operator Precedence and Readability","depth":23,"bounds":{"left":0.08759973,"top":0.7150838,"width":0.10388963,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.","depth":23,"bounds":{"left":0.08759973,"top":0.74142057,"width":0.11319814,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Visual Grouping:","depth":25,"bounds":{"left":0.10023271,"top":0.8124501,"width":0.042386968,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The parentheses","depth":25,"bounds":{"left":0.14261968,"top":0.8124501,"width":0.04305186,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new Class())","depth":26,"bounds":{"left":0.10023271,"top":0.8136473,"width":0.10139628,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"act as a visual \"container,\" making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.","depth":25,"bounds":{"left":0.10023271,"top":0.83320034,"width":0.099734046,"height":0.12011173},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Consistency:","depth":25,"bounds":{"left":0.10023271,"top":0.96648043,"width":0.03357713,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If only half the codebase is updated, the inconsistency can lead to \"style drift,\" where different developers follow different patterns, making the code feel disorganized.","depth":25,"bounds":{"left":0.10023271,"top":0.96648043,"width":0.10239362,"height":0.033519566},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"3. Tooling and IDE Support","depth":22,"bounds":{"left":0.08759973,"top":1.0,"width":0.11702128,"height":-0.090183616},"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"3. Tooling and IDE Support","depth":23,"bounds":{"left":0.08759973,"top":1.0,"width":0.06815159,"height":-0.09177971},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Static Analysis:","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or \"low-quality code\" if they aren't configured for PHP 8.0+.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Automated Refactoring:","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If this change was done via an automated tool (like Rector), it is usually safe. However, if done via \"Find and Replace,\" there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"4. Error Reporting Sensitivity","depth":22,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"4. Error Reporting Sensitivity","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"In some edge cases, if the constructor of the class throws an exception:","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The stack trace remains the same, but when debugging \"on the fly\" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"before","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"the method call in a watch window.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Summary of Risk Levels","depth":22,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Summary of Risk Levels","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Risk Factor","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Level","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Mitigation","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Production Crash","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"High","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Ensure","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"platform","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"in","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"composer.json","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is set to","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"8.0","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"or higher.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Developer Confusion","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Low","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update team style guides to reflect PHP 8.x standards.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Linting Errors","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Medium","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update CI/CD linting rules to support modern PHP syntax.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Risk Factor","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Production Crash","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Developer Confusion","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Linting Errors","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Level","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"High","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"}]...
|
-9135972224029509509
|
8311382407696383432
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor
Production Crash
Developer Confusion
Linting Errors
Level
High...
|
NULL
|
NULL
|
NULL
|
NULL
|
|
42452
|
1558
|
5
|
2026-05-14T11:35:51.898228+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758551898_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor
Production Crash
Developer Confusion
Linting Errors
Level
High
Low
Medium
Mitigation
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Update team style guides to reflect PHP 8.x standards.
Update CI/CD linting rules to support modern PHP syntax.
Copy table
Are you planning to deploy this to an environment where you are certain the PHP version is strictly 8.0 or higher?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-18091 | Update composer to support php 8.5 #12058 Edit title
JY-18091 | Update composer to support php 8.5
#
12058
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5
JY-18091-upgrade-to-php-8-5
Copy head branch name to clipboard
Lines changed: 2199 additions & 3796 deletions
Conversation (3)
Conversation
(
3
)
Commits (10)
Commits
(
10
)
Checks (3)
Checks
(
3
)
Files changed (260)
Files changed
(
260
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-18091 | Update composer to support php 8.5
JY-18091 | Update composer to support php 8.5
#
12058
All commits
All commits
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5
JY-18091-upgrade-to-php-8-5
Copy head branch name to clipboard
21 of 260 files viewed
Checks failing
Checks failing
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
.circleci...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.057063047,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.08060654,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.09217877,"width":0.101230055,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"bounds":{"left":0.0028257978,"top":0.11332801,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"bounds":{"left":0.015957447,"top":0.12490024,"width":0.076961435,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"bounds":{"left":0.0028257978,"top":0.14604948,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"bounds":{"left":0.015957447,"top":0.15762171,"width":0.08543883,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"bounds":{"left":0.0028257978,"top":0.17877094,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"bounds":{"left":0.015957447,"top":0.19034317,"width":0.04288564,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"bounds":{"left":0.0028257978,"top":0.21149242,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"bounds":{"left":0.015957447,"top":0.22306465,"width":0.12732713,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"bounds":{"left":0.0028257978,"top":0.2442139,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"bounds":{"left":0.015957447,"top":0.25578612,"width":0.033410903,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.27693537,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.28850758,"width":0.18068483,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"bounds":{"left":0.06732048,"top":0.28411812,"width":0.007978723,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"bounds":{"left":0.0028257978,"top":0.30965683,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"bounds":{"left":0.015957447,"top":0.32122904,"width":0.171875,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.3423783,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.35395053,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"bounds":{"left":0.0,"top":0.37509975,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"bounds":{"left":0.013297873,"top":0.386672,"width":0.029920213,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.41300878,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.4365523,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.4481245,"width":0.06632314,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.46927375,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.48084596,"width":0.064494684,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.5019952,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.51356745,"width":0.15658244,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.53990424,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.5634477,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.57501996,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.5961692,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6077414,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.62889063,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6404629,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.66161215,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.67318434,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.6995211,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.72306466,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.73463684,"width":0.091755316,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.7557861,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.76735836,"width":0.11619016,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.7885076,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.8000798,"width":0.18932846,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.82122904,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.8328013,"width":0.12898937,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.8539505,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.86552274,"width":0.079288565,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"bounds":{"left":0.0,"top":0.88667196,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"bounds":{"left":0.013297873,"top":0.8982442,"width":0.032247342,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0,"top":0.9193935,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.013297873,"top":0.93096566,"width":0.013131649,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.95211494,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.9636871,"width":0.041722074,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.9848364,"width":0.07962101,"height":0.0151636},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.99640864,"width":0.041722074,"height":0.0035913587},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":1.0,"width":0.07962101,"height":-0.01755786},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":1.0,"width":0.041722074,"height":-0.029130101},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.007978723,"height":-0.05546689},"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.07679521,"height":-0.07901037},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":1.0,"width":0.21575798,"height":-0.09058261},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"bounds":{"left":0.0028257978,"top":0.92897046,"width":0.07413564,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"bounds":{"left":0.0028257978,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"bounds":{"left":0.013796543,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"bounds":{"left":0.024933511,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"bounds":{"left":0.036070477,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"bounds":{"left":0.04720745,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"bounds":{"left":0.1846742,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"bounds":{"left":0.1966423,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"bounds":{"left":0.1939827,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"bounds":{"left":0.08361037,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"bounds":{"left":0.16605718,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"bounds":{"left":0.17935506,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"bounds":{"left":0.079288565,"top":0.14764565,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"bounds":{"left":0.079288565,"top":0.15003991,"width":0.1200133,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"bounds":{"left":0.11319814,"top":0.0,"width":0.03357713,"height":0.014764565},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.14876994,"top":0.0,"width":0.013131649,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16389628,"top":0.0,"width":0.013962766,"height":0.014764565},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.17985372,"top":0.0,"width":0.0014960107,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"bounds":{"left":0.08759973,"top":0.0,"width":0.11702128,"height":0.01915403},"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"bounds":{"left":0.08759973,"top":0.0,"width":0.04438165,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"bounds":{"left":0.10023271,"top":0.0,"width":0.05867686,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"bounds":{"left":0.10023271,"top":0.0,"width":0.103390954,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"bounds":{"left":0.10023271,"top":0.043894652,"width":0.04637633,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"bounds":{"left":0.10023271,"top":0.043894652,"width":0.09923537,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":22,"bounds":{"left":0.086269945,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":22,"bounds":{"left":0.09690824,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Share & export","depth":21,"bounds":{"left":0.107546546,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":22,"bounds":{"left":0.11818484,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":21,"bounds":{"left":0.12882313,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy prompt","depth":21,"bounds":{"left":0.1022274,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"bounds":{"left":0.116855055,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said are there soem potential issues?","depth":21,"bounds":{"left":0.13680187,"top":0.19313647,"width":0.065159574,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"bounds":{"left":0.079288565,"top":0.19393456,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"are there soem potential issues?","depth":23,"bounds":{"left":0.13680187,"top":0.19473264,"width":0.059175532,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Listen","depth":21,"bounds":{"left":0.1939827,"top":0.26336792,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"bounds":{"left":0.08460771,"top":0.29449323,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"bounds":{"left":0.08460771,"top":0.29648843,"width":0.04105718,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"While this refactoring is syntactically correct for modern PHP, there are a few practical and technical \"gotchas\" to consider when moving from","depth":23,"bounds":{"left":0.08759973,"top":0.29768556,"width":0.11668883,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new Class())->method()","depth":24,"bounds":{"left":0.10239362,"top":0.36113328,"width":0.06416223,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to","depth":23,"bounds":{"left":0.16855054,"top":0.35993615,"width":0.0076462766,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new Class()->method()","depth":24,"bounds":{"left":0.08759973,"top":0.36113328,"width":0.10172872,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":23,"bounds":{"left":0.13713431,"top":0.38068634,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"1. Language Compatibility (Backward Compatibility)","depth":22,"bounds":{"left":0.08759973,"top":0.42138866,"width":0.11702128,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"1. Language Compatibility (Backward Compatibility)","depth":23,"bounds":{"left":0.08759973,"top":0.42298484,"width":0.09757314,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The biggest risk is the PHP version itself.","depth":23,"bounds":{"left":0.08759973,"top":0.46847567,"width":0.09740692,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP < 8.0:","depth":25,"bounds":{"left":0.10023271,"top":0.4980048,"width":0.026263298,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"This change will cause a","depth":25,"bounds":{"left":0.12649602,"top":0.4980048,"width":0.060837764,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Parse Error","depth":25,"bounds":{"left":0.10023271,"top":0.4980048,"width":0.10305851,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":". Prior to PHP 8.0, the parser could not handle member access on a","depth":25,"bounds":{"left":0.10023271,"top":0.51875496,"width":0.09823803,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new","depth":26,"bounds":{"left":0.18085106,"top":0.54070234,"width":0.00831117,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"expression without parentheses.","depth":25,"bounds":{"left":0.10023271,"top":0.5395052,"width":0.09225399,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The \"Trap\":","depth":25,"bounds":{"left":0.10023271,"top":0.5897845,"width":0.029089095,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.","depth":25,"bounds":{"left":0.10023271,"top":0.5897845,"width":0.1043883,"height":0.09936153},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"2. Operator Precedence and Readability","depth":22,"bounds":{"left":0.08759973,"top":0.7134876,"width":0.11702128,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"2. Operator Precedence and Readability","depth":23,"bounds":{"left":0.08759973,"top":0.7150838,"width":0.10388963,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.","depth":23,"bounds":{"left":0.08759973,"top":0.74142057,"width":0.11319814,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Visual Grouping:","depth":25,"bounds":{"left":0.10023271,"top":0.8124501,"width":0.042386968,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The parentheses","depth":25,"bounds":{"left":0.14261968,"top":0.8124501,"width":0.04305186,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new Class())","depth":26,"bounds":{"left":0.10023271,"top":0.8136473,"width":0.10139628,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"act as a visual \"container,\" making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.","depth":25,"bounds":{"left":0.10023271,"top":0.83320034,"width":0.099734046,"height":0.12011173},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Consistency:","depth":25,"bounds":{"left":0.10023271,"top":0.96648043,"width":0.03357713,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If only half the codebase is updated, the inconsistency can lead to \"style drift,\" where different developers follow different patterns, making the code feel disorganized.","depth":25,"bounds":{"left":0.10023271,"top":0.96648043,"width":0.10239362,"height":0.033519566},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"3. Tooling and IDE Support","depth":22,"bounds":{"left":0.08759973,"top":1.0,"width":0.11702128,"height":-0.090183616},"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"3. Tooling and IDE Support","depth":23,"bounds":{"left":0.08759973,"top":1.0,"width":0.06815159,"height":-0.09177971},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Static Analysis:","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or \"low-quality code\" if they aren't configured for PHP 8.0+.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Automated Refactoring:","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If this change was done via an automated tool (like Rector), it is usually safe. However, if done via \"Find and Replace,\" there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"4. Error Reporting Sensitivity","depth":22,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"4. Error Reporting Sensitivity","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"In some edge cases, if the constructor of the class throws an exception:","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The stack trace remains the same, but when debugging \"on the fly\" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"before","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"the method call in a watch window.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Summary of Risk Levels","depth":22,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Summary of Risk Levels","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Risk Factor","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Level","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Mitigation","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Production Crash","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"High","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Ensure","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"platform","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"in","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"composer.json","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is set to","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"8.0","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"or higher.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Developer Confusion","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Low","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update team style guides to reflect PHP 8.x standards.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Linting Errors","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Medium","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update CI/CD linting rules to support modern PHP syntax.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Risk Factor","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Production Crash","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Developer Confusion","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Linting Errors","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Level","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"High","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Low","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Medium","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Mitigation","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Ensure","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"platform","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"in","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"composer.json","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is set to","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"8.0","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"or higher.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update team style guides to reflect PHP 8.x standards.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update CI/CD linting rules to support modern PHP syntax.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy table","depth":23,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Are you planning to deploy this to an environment where you are certain the PHP version is strictly 8.0 or higher?","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"bounds":{"left":0.09291888,"top":0.8216281,"width":0.10638298,"height":0.01915403},"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"bounds":{"left":0.099567816,"top":0.82202715,"width":0.069980055,"height":0.018355945},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"bounds":{"left":0.091921546,"top":0.8216281,"width":0.0066489363,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"bounds":{"left":0.08892952,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"bounds":{"left":0.10488697,"top":0.8575419,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"bounds":{"left":0.16007313,"top":0.85514766,"width":0.027925532,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"bounds":{"left":0.1653923,"top":0.8639266,"width":0.00930851,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Microphone","depth":19,"bounds":{"left":0.18999335,"top":0.85514766,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Send message","depth":19,"bounds":{"left":0.19630983,"top":0.85434955,"width":0.013962766,"height":0.033519555},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":false,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.","depth":17,"bounds":{"left":0.08510638,"top":0.90901834,"width":0.11951463,"height":0.025139665},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Your privacy & Gemini Opens in a new window","depth":17,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your privacy & Gemini","depth":18,"bounds":{"left":0.16705452,"top":0.92178774,"width":0.040059842,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Opens in a new window","depth":19,"bounds":{"left":0.079288565,"top":0.92098963,"width":0.043218084,"height":0.012370312},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Summarize page","depth":7,"bounds":{"left":0.08494016,"top":0.95730245,"width":0.053523935,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Summarize page","depth":9,"bounds":{"left":0.09059176,"top":0.96249,"width":0.042220745,"height":0.015163607},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Skip to content","depth":6,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Skip to content","depth":7,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open menu","depth":10,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"Homepage (g then d)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"jiminny","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"jiminny","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"app","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"app","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Search or jump to…","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Type","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to search","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Chat with Copilot","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Open Copilot…","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXMenuButton","text":"Create new...","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXLink","text":"All issues(g then i)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All pull requests","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All repositories","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"You have unread notifications(g then n)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open user navigation menu","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Repository navigation","depth":9,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Repository navigation","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Code","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Pull requests (29)","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pull requests","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"29","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Agents","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Agents","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Actions","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Actions","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Wiki","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Wiki","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Security and quality","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Security and quality","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Insights","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Insights","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Settings","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Settings","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Important update","depth":10,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Important update","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Review this update","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Review this update","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and manage your preferences in your","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"GitHub account settings","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"GitHub account settings","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Dismiss banner","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"JY-18091 | Update composer to support php 8.5 #12058 Edit title","depth":13,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"#","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"12058","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Edit title","depth":14,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Preview","depth":13,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXStaticText","text":"Preview","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Checks failing","depth":13,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Checks failing","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXMenuButton","text":"Code","depth":13,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXStaticText","text":"Code","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Open","depth":13,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"nikolaybiaivanov","depth":15,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"nikolaybiaivanov","depth":16,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"wants to merge 10 commits into","depth":15,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"master","depth":15,"on_screen":false,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"master","depth":16,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"from","depth":16,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"JY-18091-upgrade-to-php-8-5","depth":16,"on_screen":false,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-18091-upgrade-to-php-8-5","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy head branch name to clipboard","depth":16,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Lines changed: 2199 additions & 3796 deletions","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Conversation (3)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Conversation","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"3","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Commits (10)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Commits","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"10","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Checks (3)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Checks","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"3","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Files changed (260)","depth":16,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"Files changed","depth":17,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"260","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":18,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Pull Request Toolbar","depth":14,"bounds":{"left":0.22606383,"top":0.075019956,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pull Request Toolbar","depth":15,"bounds":{"left":0.22606383,"top":0.077813245,"width":0.030086435,"height":0.08060654},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Collapse file tree","depth":14,"bounds":{"left":0.22606383,"top":0.06424581,"width":0.00930851,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXStaticText","text":"Open","depth":14,"bounds":{"left":0.2486702,"top":0.06863528,"width":0.011968086,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"JY-18091 | Update composer to support php 8.5","depth":14,"bounds":{"left":0.26728722,"top":0.057462092,"width":0.108211435,"height":0.016759777},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5","depth":16,"bounds":{"left":0.26728722,"top":0.05905826,"width":0.108211435,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"#","depth":15,"bounds":{"left":0.37815824,"top":0.05905826,"width":0.0028257978,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"12058","depth":15,"bounds":{"left":0.38098404,"top":0.05905826,"width":0.013630319,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"All commits","depth":14,"bounds":{"left":0.26462767,"top":0.07102953,"width":0.03374335,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"All commits","depth":16,"bounds":{"left":0.26761967,"top":0.07621708,"width":0.02244016,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"nikolaybiaivanov","depth":15,"bounds":{"left":0.30269283,"top":0.075019956,"width":0.032413565,"height":0.014365523},"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"nikolaybiaivanov","depth":16,"bounds":{"left":0.30269283,"top":0.07621708,"width":0.032413565,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"wants to merge 10 commits into","depth":15,"bounds":{"left":0.33643618,"top":0.07621708,"width":0.059840426,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"master","depth":15,"bounds":{"left":0.39760637,"top":0.07342378,"width":0.018450798,"height":0.017557861},"on_screen":true,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"master","depth":16,"bounds":{"left":0.39960107,"top":0.07661612,"width":0.014461436,"height":0.011572227},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"from","depth":16,"bounds":{"left":0.41738698,"top":0.07621708,"width":0.008643617,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"JY-18091-upgrade-to-php-8-5","depth":16,"bounds":{"left":0.4273604,"top":0.07342378,"width":0.06881649,"height":0.017557861},"on_screen":true,"role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-18091-upgrade-to-php-8-5","depth":17,"bounds":{"left":0.42935506,"top":0.07661612,"width":0.06482713,"height":0.011572227},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy head branch name to clipboard","depth":16,"bounds":{"left":0.49750665,"top":0.07102953,"width":0.00930851,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"21 of 260 files viewed","depth":15,"bounds":{"left":0.81582445,"top":0.07661612,"width":0.014960106,"height":0.08060654},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Checks failing","depth":14,"bounds":{"left":0.86053854,"top":0.06424581,"width":0.03956117,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Checks failing","depth":16,"bounds":{"left":0.87017953,"top":0.06943336,"width":0.026928192,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Submit review","depth":14,"bounds":{"left":0.9027593,"top":0.06424581,"width":0.03856383,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Submit","depth":16,"bounds":{"left":0.90575135,"top":0.06943336,"width":0.014793883,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"review","depth":16,"bounds":{"left":0.9205452,"top":0.06943336,"width":0.012466756,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXMenuButton","text":"Open diff view settings","depth":14,"bounds":{"left":0.9439827,"top":0.06424581,"width":0.00930851,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open overview panel","depth":14,"bounds":{"left":0.9616024,"top":0.06424581,"width":0.00930851,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open comments panel","depth":14,"bounds":{"left":0.9722407,"top":0.06424581,"width":0.017287234,"height":0.022346368},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXStaticText","text":"(","depth":16,"bounds":{"left":0.98055184,"top":0.06943336,"width":0.0026595744,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"0","depth":16,"bounds":{"left":0.98321146,"top":0.06943336,"width":0.0026595744,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":16,"bounds":{"left":0.985871,"top":0.06943336,"width":0.0014960107,"height":0.011971269},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXTextField","text":"Filter files…","depth":16,"bounds":{"left":0.23736702,"top":0.11332801,"width":0.06815159,"height":0.023942538},"on_screen":true,"help_text":"","role_description":"text field","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Filter options","depth":16,"bounds":{"left":0.30851063,"top":0.112529926,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"File tree","depth":15,"bounds":{"left":0.22639628,"top":0.15083799,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"File tree","depth":16,"bounds":{"left":0.22639628,"top":0.15363128,"width":0.014295213,"height":0.0518755},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".circleci","depth":19,"bounds":{"left":0.24235372,"top":0.15682362,"width":0.016456118,"height":0.013567438},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"}]...
|
2076646904441645793
|
8311382407704772040
|
visual_change
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor
Production Crash
Developer Confusion
Linting Errors
Level
High
Low
Medium
Mitigation
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Update team style guides to reflect PHP 8.x standards.
Update CI/CD linting rules to support modern PHP syntax.
Copy table
Are you planning to deploy this to an environment where you are certain the PHP version is strictly 8.0 or higher?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-18091 | Update composer to support php 8.5 #12058 Edit title
JY-18091 | Update composer to support php 8.5
#
12058
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5
JY-18091-upgrade-to-php-8-5
Copy head branch name to clipboard
Lines changed: 2199 additions & 3796 deletions
Conversation (3)
Conversation
(
3
)
Commits (10)
Commits
(
10
)
Checks (3)
Checks
(
3
)
Files changed (260)
Files changed
(
260
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-18091 | Update composer to support php 8.5
JY-18091 | Update composer to support php 8.5
#
12058
All commits
All commits
nikolaybiaivanov
nikolaybiaivanov
wants to merge 10 commits into
master
master
from
JY-18091-upgrade-to-php-8-5
JY-18091-upgrade-to-php-8-5
Copy head branch name to clipboard
21 of 260 files viewed
Checks failing
Checks failing
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
.circleci...
|
42451
|
NULL
|
NULL
|
NULL
|
|
42453
|
1557
|
2
|
2026-05-14T11:35:52.219109+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758552219_m1.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_1
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor
Production Crash
Developer Confusion
Linting Errors
Level
High
Low
Medium
Mitigation
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Update team style guides to reflect PHP 8.x standards.
Update CI/CD linting rules to support modern PHP syntax.
Copy table
Are you planning to deploy this to an environment where you are certain the PHP version is strictly 8.0 or higher?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":22,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":22,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Share & export","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":22,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said are there soem potential issues?","depth":21,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"are there soem potential issues?","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Listen","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"While this refactoring is syntactically correct for modern PHP, there are a few practical and technical \"gotchas\" to consider when moving from","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new Class())->method()","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new Class()->method()","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"1. Language Compatibility (Backward Compatibility)","depth":22,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"1. Language Compatibility (Backward Compatibility)","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The biggest risk is the PHP version itself.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP < 8.0:","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"This change will cause a","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Parse Error","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":". Prior to PHP 8.0, the parser could not handle member access on a","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"expression without parentheses.","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The \"Trap\":","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"2. Operator Precedence and Readability","depth":22,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"2. Operator Precedence and Readability","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Visual Grouping:","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The parentheses","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new Class())","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"act as a visual \"container,\" making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Consistency:","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If only half the codebase is updated, the inconsistency can lead to \"style drift,\" where different developers follow different patterns, making the code feel disorganized.","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"3. Tooling and IDE Support","depth":22,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"3. Tooling and IDE Support","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Static Analysis:","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or \"low-quality code\" if they aren't configured for PHP 8.0+.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Automated Refactoring:","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If this change was done via an automated tool (like Rector), it is usually safe. However, if done via \"Find and Replace,\" there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"4. Error Reporting Sensitivity","depth":22,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"4. Error Reporting Sensitivity","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"In some edge cases, if the constructor of the class throws an exception:","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The stack trace remains the same, but when debugging \"on the fly\" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"before","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"the method call in a watch window.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Summary of Risk Levels","depth":22,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Summary of Risk Levels","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Risk Factor","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Level","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Mitigation","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Production Crash","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"High","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Ensure","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"platform","depth":28,"bounds":{"left":0.0,"top":1.0,"width":0.046875,"height":-0.0027778149},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"in","depth":27,"bounds":{"left":0.0,"top":1.0,"width":0.011458334,"height":-0.0011111498},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"composer.json","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is set to","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"8.0","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"or higher.","depth":27,"bounds":{"left":0.0,"top":1.0,"width":0.050694443,"height":-0.046666622},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Developer Confusion","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Low","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update team style guides to reflect PHP 8.x standards.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Linting Errors","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Medium","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update CI/CD linting rules to support modern PHP syntax.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Risk Factor","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Production Crash","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Developer Confusion","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Linting Errors","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Level","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"High","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Low","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Medium","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Mitigation","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Ensure","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"platform","depth":28,"bounds":{"left":0.0,"top":1.0,"width":0.046875,"height":-0.0027778149},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"in","depth":27,"bounds":{"left":0.0,"top":1.0,"width":0.011458334,"height":-0.0011111498},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"composer.json","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is set to","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"8.0","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"or higher.","depth":27,"bounds":{"left":0.0,"top":1.0,"width":0.050694443,"height":-0.046666622},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update team style guides to reflect PHP 8.x standards.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update CI/CD linting rules to support modern PHP syntax.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy table","depth":23,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Are you planning to deploy this to an environment where you are certain the PHP version is strictly 8.0 or higher?","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXTextArea","text":"Enter a prompt for Gemini\nencrypted","depth":20,"on_screen":true,"value":"Enter a prompt for Gemini\nencrypted","help_text":"","role_description":"text entry area","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Enter a prompt for Gemini","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"encrypted","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open upload file menu","depth":20,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Tools","depth":18,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Open mode picker","depth":20,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Fast","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Microphone","depth":19,"on_screen":true,"role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Send message","depth":19,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":false,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.","depth":17,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Your privacy & Gemini Opens in a new window","depth":17,"on_screen":true,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Your privacy & Gemini","depth":18,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Opens in a new window","depth":19,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Summarize page","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Summarize page","depth":9,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Skip to content","depth":6,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Skip to content","depth":7,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Open menu","depth":10,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"Homepage (g then d)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"jiminny","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"jiminny","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"app","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"app","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Search or jump to…","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Type","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to search","depth":12,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Chat with Copilot","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXMenuButton","text":"Open Copilot…","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXMenuButton","text":"Create new...","depth":9,"on_screen":false,"help_text":"","role_description":"menu button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXLink","text":"All issues(g then i)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All pull requests","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"All repositories","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXLink","text":"You have unread notifications(g then n)","depth":9,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open user navigation menu","depth":9,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Repository navigation","depth":9,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Repository navigation","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Code","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Pull requests (29)","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pull requests","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"29","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":")","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Agents","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Agents","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Actions","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Actions","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Wiki","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Wiki","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Security and quality","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Security and quality","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Insights","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Insights","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Settings","depth":12,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Settings","depth":14,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Important update","depth":10,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Important update","depth":11,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.","depth":10,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXLink","text":"Review this update","depth":10,"on_screen":false,"help_text":"","role_description":"link","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false}]...
|
-7308831950543398668
|
8311383507216399816
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor
Production Crash
Developer Confusion
Linting Errors
Level
High
Low
Medium
Mitigation
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Update team style guides to reflect PHP 8.x standards.
Update CI/CD linting rules to support modern PHP syntax.
Copy table
Are you planning to deploy this to an environment where you are certain the PHP version is strictly 8.0 or higher?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update...
|
42450
|
NULL
|
NULL
|
NULL
|
|
42454
|
1557
|
3
|
2026-05-14T11:35:53.422055+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758553422_m1.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_1
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor
Production Crash
Developer Confusion
Linting Errors
Level
High
Low
Medium
Mitigation
Ensure...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":22,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":22,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Share & export","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":22,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said are there soem potential issues?","depth":21,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"are there soem potential issues?","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Listen","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"While this refactoring is syntactically correct for modern PHP, there are a few practical and technical \"gotchas\" to consider when moving from","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new Class())->method()","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new Class()->method()","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"1. Language Compatibility (Backward Compatibility)","depth":22,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"1. Language Compatibility (Backward Compatibility)","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The biggest risk is the PHP version itself.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP < 8.0:","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"This change will cause a","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Parse Error","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":". Prior to PHP 8.0, the parser could not handle member access on a","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"expression without parentheses.","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The \"Trap\":","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"2. Operator Precedence and Readability","depth":22,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"2. Operator Precedence and Readability","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Visual Grouping:","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The parentheses","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new Class())","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"act as a visual \"container,\" making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Consistency:","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If only half the codebase is updated, the inconsistency can lead to \"style drift,\" where different developers follow different patterns, making the code feel disorganized.","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"3. Tooling and IDE Support","depth":22,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"3. Tooling and IDE Support","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Static Analysis:","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or \"low-quality code\" if they aren't configured for PHP 8.0+.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Automated Refactoring:","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If this change was done via an automated tool (like Rector), it is usually safe. However, if done via \"Find and Replace,\" there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"4. Error Reporting Sensitivity","depth":22,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"4. Error Reporting Sensitivity","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"In some edge cases, if the constructor of the class throws an exception:","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The stack trace remains the same, but when debugging \"on the fly\" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"before","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"the method call in a watch window.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Summary of Risk Levels","depth":22,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Summary of Risk Levels","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Risk Factor","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Level","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Mitigation","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Production Crash","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"High","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Ensure","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"platform","depth":28,"bounds":{"left":0.0,"top":1.0,"width":0.046875,"height":-0.0027778149},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"in","depth":27,"bounds":{"left":0.0,"top":1.0,"width":0.011458334,"height":-0.0011111498},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"composer.json","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is set to","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"8.0","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"or higher.","depth":27,"bounds":{"left":0.0,"top":1.0,"width":0.050694443,"height":-0.046666622},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Developer Confusion","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Low","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update team style guides to reflect PHP 8.x standards.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Linting Errors","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Medium","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update CI/CD linting rules to support modern PHP syntax.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Risk Factor","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Production Crash","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Developer Confusion","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Linting Errors","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Level","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"High","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Low","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Medium","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Mitigation","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Ensure","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"}]...
|
-8113954927667360293
|
8311382407696383432
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor
Production Crash
Developer Confusion
Linting Errors
Level
High
Low
Medium
Mitigation
Ensure...
|
NULL
|
NULL
|
NULL
|
NULL
|
|
42455
|
1558
|
6
|
2026-05-14T11:35:53.385777+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758553385_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.057063047,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.08060654,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.09217877,"width":0.101230055,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"bounds":{"left":0.0028257978,"top":0.11332801,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"bounds":{"left":0.015957447,"top":0.12490024,"width":0.076961435,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"bounds":{"left":0.0028257978,"top":0.14604948,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"bounds":{"left":0.015957447,"top":0.15762171,"width":0.08543883,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"bounds":{"left":0.0028257978,"top":0.17877094,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"bounds":{"left":0.015957447,"top":0.19034317,"width":0.04288564,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"bounds":{"left":0.0028257978,"top":0.21149242,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"bounds":{"left":0.015957447,"top":0.22306465,"width":0.12732713,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"bounds":{"left":0.0028257978,"top":0.2442139,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"bounds":{"left":0.015957447,"top":0.25578612,"width":0.033410903,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.27693537,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.28850758,"width":0.18068483,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"bounds":{"left":0.06732048,"top":0.28411812,"width":0.007978723,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"bounds":{"left":0.0028257978,"top":0.30965683,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"bounds":{"left":0.015957447,"top":0.32122904,"width":0.171875,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.3423783,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.35395053,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"bounds":{"left":0.0,"top":0.37509975,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"bounds":{"left":0.013297873,"top":0.386672,"width":0.029920213,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.41300878,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.4365523,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.4481245,"width":0.06632314,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.46927375,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.48084596,"width":0.064494684,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.5019952,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.51356745,"width":0.15658244,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.53990424,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.5634477,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.57501996,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.5961692,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6077414,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.62889063,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6404629,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.66161215,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.67318434,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.6995211,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.72306466,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.73463684,"width":0.091755316,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.7557861,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.76735836,"width":0.11619016,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.7885076,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.8000798,"width":0.18932846,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.82122904,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.8328013,"width":0.12898937,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.8539505,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.86552274,"width":0.079288565,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"bounds":{"left":0.0,"top":0.88667196,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"bounds":{"left":0.013297873,"top":0.8982442,"width":0.032247342,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0,"top":0.9193935,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.013297873,"top":0.93096566,"width":0.013131649,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.95211494,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.9636871,"width":0.041722074,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.9848364,"width":0.07962101,"height":0.0151636},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.99640864,"width":0.041722074,"height":0.0035913587},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":1.0,"width":0.07962101,"height":-0.01755786},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":1.0,"width":0.041722074,"height":-0.029130101},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.007978723,"height":-0.05546689},"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.07679521,"height":-0.07901037},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":1.0,"width":0.21575798,"height":-0.09058261},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"bounds":{"left":0.0028257978,"top":0.92897046,"width":0.07413564,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"bounds":{"left":0.0028257978,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"bounds":{"left":0.013796543,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"bounds":{"left":0.024933511,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"bounds":{"left":0.036070477,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"bounds":{"left":0.04720745,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"bounds":{"left":0.1846742,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"bounds":{"left":0.1966423,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"bounds":{"left":0.1939827,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"bounds":{"left":0.08361037,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"bounds":{"left":0.16605718,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"bounds":{"left":0.17935506,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"bounds":{"left":0.079288565,"top":0.14764565,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"bounds":{"left":0.079288565,"top":0.15003991,"width":0.1200133,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"bounds":{"left":0.11319814,"top":0.0,"width":0.03357713,"height":0.014764565},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.14876994,"top":0.0,"width":0.013131649,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16389628,"top":0.0,"width":0.013962766,"height":0.014764565},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.17985372,"top":0.0,"width":0.0014960107,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"bounds":{"left":0.08759973,"top":0.0,"width":0.11702128,"height":0.01915403},"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"bounds":{"left":0.08759973,"top":0.0,"width":0.04438165,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"bounds":{"left":0.10023271,"top":0.0,"width":0.05867686,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"bounds":{"left":0.10023271,"top":0.0,"width":0.103390954,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"bounds":{"left":0.10023271,"top":0.043894652,"width":0.04637633,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"bounds":{"left":0.10023271,"top":0.043894652,"width":0.09923537,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":22,"bounds":{"left":0.086269945,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":22,"bounds":{"left":0.09690824,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Share & export","depth":21,"bounds":{"left":0.107546546,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":22,"bounds":{"left":0.11818484,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":21,"bounds":{"left":0.12882313,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy prompt","depth":21,"bounds":{"left":0.1022274,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"bounds":{"left":0.116855055,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said are there soem potential issues?","depth":21,"bounds":{"left":0.13680187,"top":0.19313647,"width":0.065159574,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"bounds":{"left":0.079288565,"top":0.19393456,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"are there soem potential issues?","depth":23,"bounds":{"left":0.13680187,"top":0.19473264,"width":0.059175532,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Listen","depth":21,"bounds":{"left":0.1939827,"top":0.26336792,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"bounds":{"left":0.08460771,"top":0.29449323,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"bounds":{"left":0.08460771,"top":0.29648843,"width":0.04105718,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"While this refactoring is syntactically correct for modern PHP, there are a few practical and technical \"gotchas\" to consider when moving from","depth":23,"bounds":{"left":0.08759973,"top":0.29768556,"width":0.11668883,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new Class())->method()","depth":24,"bounds":{"left":0.10239362,"top":0.36113328,"width":0.06416223,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to","depth":23,"bounds":{"left":0.16855054,"top":0.35993615,"width":0.0076462766,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new Class()->method()","depth":24,"bounds":{"left":0.08759973,"top":0.36113328,"width":0.10172872,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":23,"bounds":{"left":0.13713431,"top":0.38068634,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"1. Language Compatibility (Backward Compatibility)","depth":22,"bounds":{"left":0.08759973,"top":0.42138866,"width":0.11702128,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"1. Language Compatibility (Backward Compatibility)","depth":23,"bounds":{"left":0.08759973,"top":0.42298484,"width":0.09757314,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The biggest risk is the PHP version itself.","depth":23,"bounds":{"left":0.08759973,"top":0.46847567,"width":0.09740692,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP < 8.0:","depth":25,"bounds":{"left":0.10023271,"top":0.4980048,"width":0.026263298,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"This change will cause a","depth":25,"bounds":{"left":0.12649602,"top":0.4980048,"width":0.060837764,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Parse Error","depth":25,"bounds":{"left":0.10023271,"top":0.4980048,"width":0.10305851,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":". Prior to PHP 8.0, the parser could not handle member access on a","depth":25,"bounds":{"left":0.10023271,"top":0.51875496,"width":0.09823803,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new","depth":26,"bounds":{"left":0.18085106,"top":0.54070234,"width":0.00831117,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"expression without parentheses.","depth":25,"bounds":{"left":0.10023271,"top":0.5395052,"width":0.09225399,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The \"Trap\":","depth":25,"bounds":{"left":0.10023271,"top":0.5897845,"width":0.029089095,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.","depth":25,"bounds":{"left":0.10023271,"top":0.5897845,"width":0.1043883,"height":0.09936153},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"2. Operator Precedence and Readability","depth":22,"bounds":{"left":0.08759973,"top":0.7134876,"width":0.11702128,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"2. Operator Precedence and Readability","depth":23,"bounds":{"left":0.08759973,"top":0.7150838,"width":0.10388963,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.","depth":23,"bounds":{"left":0.08759973,"top":0.74142057,"width":0.11319814,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Visual Grouping:","depth":25,"bounds":{"left":0.10023271,"top":0.8124501,"width":0.042386968,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The parentheses","depth":25,"bounds":{"left":0.14261968,"top":0.8124501,"width":0.04305186,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new Class())","depth":26,"bounds":{"left":0.10023271,"top":0.8136473,"width":0.10139628,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"act as a visual \"container,\" making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.","depth":25,"bounds":{"left":0.10023271,"top":0.83320034,"width":0.099734046,"height":0.12011173},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Consistency:","depth":25,"bounds":{"left":0.10023271,"top":0.96648043,"width":0.03357713,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If only half the codebase is updated, the inconsistency can lead to \"style drift,\" where different developers follow different patterns, making the code feel disorganized.","depth":25,"bounds":{"left":0.10023271,"top":0.96648043,"width":0.10239362,"height":0.033519566},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"3. Tooling and IDE Support","depth":22,"bounds":{"left":0.08759973,"top":1.0,"width":0.11702128,"height":-0.090183616},"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"3. Tooling and IDE Support","depth":23,"bounds":{"left":0.08759973,"top":1.0,"width":0.06815159,"height":-0.09177971},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Static Analysis:","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or \"low-quality code\" if they aren't configured for PHP 8.0+.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Automated Refactoring:","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If this change was done via an automated tool (like Rector), it is usually safe. However, if done via \"Find and Replace,\" there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"4. Error Reporting Sensitivity","depth":22,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"4. Error Reporting Sensitivity","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"In some edge cases, if the constructor of the class throws an exception:","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The stack trace remains the same, but when debugging \"on the fly\" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"before","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"the method call in a watch window.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Summary of Risk Levels","depth":22,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Summary of Risk Levels","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Risk Factor","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Level","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Mitigation","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Production Crash","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"High","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Ensure","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"platform","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"in","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"composer.json","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is set to","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"8.0","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"or higher.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Developer Confusion","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Low","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update team style guides to reflect PHP 8.x standards.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Linting Errors","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Medium","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update CI/CD linting rules to support modern PHP syntax.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Risk Factor","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"}]...
|
-5304278751776615499
|
8311382407696383432
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor...
|
NULL
|
NULL
|
NULL
|
NULL
|
|
42456
|
1557
|
4
|
2026-05-14T11:35:55.023111+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758555023_m1.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_1
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor
Production Crash
Developer Confusion
Linting Errors
Level
High
Low
Medium
Mitigation
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Update team style guides to reflect PHP 8.x standards.
Update CI/CD linting rules to support modern PHP syntax.
Copy table
Are you planning to deploy this to an environment where you are certain the PHP version is strictly 8.0 or higher?
Good response...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":22,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":22,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Share & export","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":22,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said are there soem potential issues?","depth":21,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"are there soem potential issues?","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Listen","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"While this refactoring is syntactically correct for modern PHP, there are a few practical and technical \"gotchas\" to consider when moving from","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new Class())->method()","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new Class()->method()","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"1. Language Compatibility (Backward Compatibility)","depth":22,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"1. Language Compatibility (Backward Compatibility)","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The biggest risk is the PHP version itself.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP < 8.0:","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"This change will cause a","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Parse Error","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":". Prior to PHP 8.0, the parser could not handle member access on a","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"expression without parentheses.","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The \"Trap\":","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"2. Operator Precedence and Readability","depth":22,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"2. Operator Precedence and Readability","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Visual Grouping:","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The parentheses","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new Class())","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"act as a visual \"container,\" making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Consistency:","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If only half the codebase is updated, the inconsistency can lead to \"style drift,\" where different developers follow different patterns, making the code feel disorganized.","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"3. Tooling and IDE Support","depth":22,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"3. Tooling and IDE Support","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Static Analysis:","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or \"low-quality code\" if they aren't configured for PHP 8.0+.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Automated Refactoring:","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If this change was done via an automated tool (like Rector), it is usually safe. However, if done via \"Find and Replace,\" there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"4. Error Reporting Sensitivity","depth":22,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"4. Error Reporting Sensitivity","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"In some edge cases, if the constructor of the class throws an exception:","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The stack trace remains the same, but when debugging \"on the fly\" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"before","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"the method call in a watch window.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Summary of Risk Levels","depth":22,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Summary of Risk Levels","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Risk Factor","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Level","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Mitigation","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Production Crash","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"High","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Ensure","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"platform","depth":28,"bounds":{"left":0.0,"top":1.0,"width":0.046875,"height":-0.0027778149},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"in","depth":27,"bounds":{"left":0.0,"top":1.0,"width":0.011458334,"height":-0.0011111498},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"composer.json","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is set to","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"8.0","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"or higher.","depth":27,"bounds":{"left":0.0,"top":1.0,"width":0.050694443,"height":-0.046666622},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Developer Confusion","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Low","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update team style guides to reflect PHP 8.x standards.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Linting Errors","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Medium","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update CI/CD linting rules to support modern PHP syntax.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Risk Factor","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Production Crash","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Developer Confusion","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Linting Errors","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Level","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"High","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Low","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Medium","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Mitigation","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Ensure","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"platform","depth":28,"bounds":{"left":0.0,"top":1.0,"width":0.046875,"height":-0.0027778149},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"in","depth":27,"bounds":{"left":0.0,"top":1.0,"width":0.011458334,"height":-0.0011111498},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"composer.json","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is set to","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"8.0","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"or higher.","depth":27,"bounds":{"left":0.0,"top":1.0,"width":0.050694443,"height":-0.046666622},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update team style guides to reflect PHP 8.x standards.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update CI/CD linting rules to support modern PHP syntax.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy table","depth":23,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Are you planning to deploy this to an environment where you are certain the PHP version is strictly 8.0 or higher?","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false}]...
|
8357676771097368503
|
8311382407704772040
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor
Production Crash
Developer Confusion
Linting Errors
Level
High
Low
Medium
Mitigation
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Update team style guides to reflect PHP 8.x standards.
Update CI/CD linting rules to support modern PHP syntax.
Copy table
Are you planning to deploy this to an environment where you are certain the PHP version is strictly 8.0 or higher?
Good response...
|
42454
|
NULL
|
NULL
|
NULL
|
|
42457
|
1558
|
7
|
2026-05-14T11:35:55.029660+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758555029_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor
Production Crash
Developer Confusion
Linting Errors
Level
High
Low
Medium
Mitigation
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Update team style guides to reflect PHP 8.x standards.
Update CI/CD linting rules to support modern PHP syntax.
Copy table
Are you planning to deploy this to an environment where you are certain the PHP version is strictly 8.0 or higher?
Good response
Bad response
Redo
Share & export
Copy
Show more options...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.057063047,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.08060654,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.09217877,"width":0.101230055,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"bounds":{"left":0.0028257978,"top":0.11332801,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"bounds":{"left":0.015957447,"top":0.12490024,"width":0.076961435,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"bounds":{"left":0.0028257978,"top":0.14604948,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"bounds":{"left":0.015957447,"top":0.15762171,"width":0.08543883,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"bounds":{"left":0.0028257978,"top":0.17877094,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"bounds":{"left":0.015957447,"top":0.19034317,"width":0.04288564,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"bounds":{"left":0.0028257978,"top":0.21149242,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"bounds":{"left":0.015957447,"top":0.22306465,"width":0.12732713,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"bounds":{"left":0.0028257978,"top":0.2442139,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"bounds":{"left":0.015957447,"top":0.25578612,"width":0.033410903,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.27693537,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.28850758,"width":0.18068483,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"bounds":{"left":0.06732048,"top":0.28411812,"width":0.007978723,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"bounds":{"left":0.0028257978,"top":0.30965683,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"bounds":{"left":0.015957447,"top":0.32122904,"width":0.171875,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.3423783,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.35395053,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"bounds":{"left":0.0,"top":0.37509975,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"bounds":{"left":0.013297873,"top":0.386672,"width":0.029920213,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.41300878,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.4365523,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.4481245,"width":0.06632314,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.46927375,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.48084596,"width":0.064494684,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.5019952,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.51356745,"width":0.15658244,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.53990424,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.5634477,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.57501996,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.5961692,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6077414,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.62889063,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6404629,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.66161215,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.67318434,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.6995211,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.72306466,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.73463684,"width":0.091755316,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.7557861,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.76735836,"width":0.11619016,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.7885076,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.8000798,"width":0.18932846,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.82122904,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.8328013,"width":0.12898937,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.8539505,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.86552274,"width":0.079288565,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"bounds":{"left":0.0,"top":0.88667196,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"bounds":{"left":0.013297873,"top":0.8982442,"width":0.032247342,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0,"top":0.9193935,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.013297873,"top":0.93096566,"width":0.013131649,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.95211494,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.9636871,"width":0.041722074,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.9848364,"width":0.07962101,"height":0.0151636},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.99640864,"width":0.041722074,"height":0.0035913587},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":1.0,"width":0.07962101,"height":-0.01755786},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":1.0,"width":0.041722074,"height":-0.029130101},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.007978723,"height":-0.05546689},"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.07679521,"height":-0.07901037},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":1.0,"width":0.21575798,"height":-0.09058261},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"bounds":{"left":0.0028257978,"top":0.92897046,"width":0.07413564,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"bounds":{"left":0.0028257978,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"bounds":{"left":0.013796543,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"bounds":{"left":0.024933511,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"bounds":{"left":0.036070477,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"bounds":{"left":0.04720745,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"bounds":{"left":0.1846742,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"bounds":{"left":0.1966423,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"bounds":{"left":0.1939827,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"bounds":{"left":0.08361037,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"bounds":{"left":0.16605718,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"bounds":{"left":0.17935506,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"bounds":{"left":0.079288565,"top":0.14764565,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"bounds":{"left":0.079288565,"top":0.15003991,"width":0.1200133,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"bounds":{"left":0.11319814,"top":0.0,"width":0.03357713,"height":0.014764565},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.14876994,"top":0.0,"width":0.013131649,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16389628,"top":0.0,"width":0.013962766,"height":0.014764565},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.17985372,"top":0.0,"width":0.0014960107,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"bounds":{"left":0.08759973,"top":0.0,"width":0.11702128,"height":0.01915403},"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"bounds":{"left":0.08759973,"top":0.0,"width":0.04438165,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"bounds":{"left":0.10023271,"top":0.0,"width":0.05867686,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"bounds":{"left":0.10023271,"top":0.0,"width":0.103390954,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"bounds":{"left":0.10023271,"top":0.043894652,"width":0.04637633,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"bounds":{"left":0.10023271,"top":0.043894652,"width":0.09923537,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":22,"bounds":{"left":0.086269945,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":22,"bounds":{"left":0.09690824,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Share & export","depth":21,"bounds":{"left":0.107546546,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":22,"bounds":{"left":0.11818484,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":21,"bounds":{"left":0.12882313,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy prompt","depth":21,"bounds":{"left":0.1022274,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"bounds":{"left":0.116855055,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said are there soem potential issues?","depth":21,"bounds":{"left":0.13680187,"top":0.19313647,"width":0.065159574,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"bounds":{"left":0.079288565,"top":0.19393456,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"are there soem potential issues?","depth":23,"bounds":{"left":0.13680187,"top":0.19473264,"width":0.059175532,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Listen","depth":21,"bounds":{"left":0.1939827,"top":0.26336792,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"bounds":{"left":0.08460771,"top":0.29449323,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"bounds":{"left":0.08460771,"top":0.29648843,"width":0.04105718,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"While this refactoring is syntactically correct for modern PHP, there are a few practical and technical \"gotchas\" to consider when moving from","depth":23,"bounds":{"left":0.08759973,"top":0.29768556,"width":0.11668883,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new Class())->method()","depth":24,"bounds":{"left":0.10239362,"top":0.36113328,"width":0.06416223,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to","depth":23,"bounds":{"left":0.16855054,"top":0.35993615,"width":0.0076462766,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new Class()->method()","depth":24,"bounds":{"left":0.08759973,"top":0.36113328,"width":0.10172872,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":23,"bounds":{"left":0.13713431,"top":0.38068634,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"1. Language Compatibility (Backward Compatibility)","depth":22,"bounds":{"left":0.08759973,"top":0.42138866,"width":0.11702128,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"1. Language Compatibility (Backward Compatibility)","depth":23,"bounds":{"left":0.08759973,"top":0.42298484,"width":0.09757314,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The biggest risk is the PHP version itself.","depth":23,"bounds":{"left":0.08759973,"top":0.46847567,"width":0.09740692,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP < 8.0:","depth":25,"bounds":{"left":0.10023271,"top":0.4980048,"width":0.026263298,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"This change will cause a","depth":25,"bounds":{"left":0.12649602,"top":0.4980048,"width":0.060837764,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Parse Error","depth":25,"bounds":{"left":0.10023271,"top":0.4980048,"width":0.10305851,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":". Prior to PHP 8.0, the parser could not handle member access on a","depth":25,"bounds":{"left":0.10023271,"top":0.51875496,"width":0.09823803,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new","depth":26,"bounds":{"left":0.18085106,"top":0.54070234,"width":0.00831117,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"expression without parentheses.","depth":25,"bounds":{"left":0.10023271,"top":0.5395052,"width":0.09225399,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The \"Trap\":","depth":25,"bounds":{"left":0.10023271,"top":0.5897845,"width":0.029089095,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.","depth":25,"bounds":{"left":0.10023271,"top":0.5897845,"width":0.1043883,"height":0.09936153},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"2. Operator Precedence and Readability","depth":22,"bounds":{"left":0.08759973,"top":0.7134876,"width":0.11702128,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"2. Operator Precedence and Readability","depth":23,"bounds":{"left":0.08759973,"top":0.7150838,"width":0.10388963,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.","depth":23,"bounds":{"left":0.08759973,"top":0.74142057,"width":0.11319814,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Visual Grouping:","depth":25,"bounds":{"left":0.10023271,"top":0.8124501,"width":0.042386968,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The parentheses","depth":25,"bounds":{"left":0.14261968,"top":0.8124501,"width":0.04305186,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new Class())","depth":26,"bounds":{"left":0.10023271,"top":0.8136473,"width":0.10139628,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"act as a visual \"container,\" making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.","depth":25,"bounds":{"left":0.10023271,"top":0.83320034,"width":0.099734046,"height":0.12011173},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Consistency:","depth":25,"bounds":{"left":0.10023271,"top":0.96648043,"width":0.03357713,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If only half the codebase is updated, the inconsistency can lead to \"style drift,\" where different developers follow different patterns, making the code feel disorganized.","depth":25,"bounds":{"left":0.10023271,"top":0.96648043,"width":0.10239362,"height":0.033519566},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"3. Tooling and IDE Support","depth":22,"bounds":{"left":0.08759973,"top":1.0,"width":0.11702128,"height":-0.090183616},"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"3. Tooling and IDE Support","depth":23,"bounds":{"left":0.08759973,"top":1.0,"width":0.06815159,"height":-0.09177971},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Static Analysis:","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or \"low-quality code\" if they aren't configured for PHP 8.0+.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Automated Refactoring:","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If this change was done via an automated tool (like Rector), it is usually safe. However, if done via \"Find and Replace,\" there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"4. Error Reporting Sensitivity","depth":22,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"4. Error Reporting Sensitivity","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"In some edge cases, if the constructor of the class throws an exception:","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The stack trace remains the same, but when debugging \"on the fly\" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"before","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"the method call in a watch window.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Summary of Risk Levels","depth":22,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Summary of Risk Levels","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Risk Factor","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Level","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Mitigation","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Production Crash","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"High","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Ensure","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"platform","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"in","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"composer.json","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is set to","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"8.0","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"or higher.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Developer Confusion","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Low","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update team style guides to reflect PHP 8.x standards.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Linting Errors","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Medium","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update CI/CD linting rules to support modern PHP syntax.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Risk Factor","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Production Crash","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Developer Confusion","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Linting Errors","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Level","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"High","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Low","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Medium","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Mitigation","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Ensure","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"platform","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"in","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"composer.json","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is set to","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"8.0","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"or higher.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update team style guides to reflect PHP 8.x standards.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update CI/CD linting rules to support modern PHP syntax.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy table","depth":23,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Are you planning to deploy this to an environment where you are certain the PHP version is strictly 8.0 or higher?","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":21,"on_screen":false,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Redo","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Share & export","depth":20,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":20,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false}]...
|
-5665341071045570719
|
8311382407704772040
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor
Production Crash
Developer Confusion
Linting Errors
Level
High
Low
Medium
Mitigation
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Update team style guides to reflect PHP 8.x standards.
Update CI/CD linting rules to support modern PHP syntax.
Copy table
Are you planning to deploy this to an environment where you are certain the PHP version is strictly 8.0 or higher?
Good response
Bad response
Redo
Share & export
Copy
Show more options...
|
42455
|
NULL
|
NULL
|
NULL
|
|
42458
|
1557
|
5
|
2026-05-14T11:35:56.627373+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758556627_m1.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_1
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
....
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"}]...
|
-7318053790178896287
|
8923867554677276104
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
....
|
NULL
|
NULL
|
NULL
|
NULL
|
|
42459
|
1558
|
8
|
2026-05-14T11:35:56.627385+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758556627_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
....
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.057063047,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.08060654,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.09217877,"width":0.101230055,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"bounds":{"left":0.0028257978,"top":0.11332801,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"bounds":{"left":0.015957447,"top":0.12490024,"width":0.076961435,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"bounds":{"left":0.0028257978,"top":0.14604948,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"bounds":{"left":0.015957447,"top":0.15762171,"width":0.08543883,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"bounds":{"left":0.0028257978,"top":0.17877094,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"bounds":{"left":0.015957447,"top":0.19034317,"width":0.04288564,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"bounds":{"left":0.0028257978,"top":0.21149242,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"bounds":{"left":0.015957447,"top":0.22306465,"width":0.12732713,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"bounds":{"left":0.0028257978,"top":0.2442139,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"bounds":{"left":0.015957447,"top":0.25578612,"width":0.033410903,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.27693537,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.28850758,"width":0.18068483,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"bounds":{"left":0.06732048,"top":0.28411812,"width":0.007978723,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"bounds":{"left":0.0028257978,"top":0.30965683,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"bounds":{"left":0.015957447,"top":0.32122904,"width":0.171875,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.3423783,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.35395053,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"bounds":{"left":0.0,"top":0.37509975,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"bounds":{"left":0.013297873,"top":0.386672,"width":0.029920213,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.41300878,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.4365523,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.4481245,"width":0.06632314,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.46927375,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.48084596,"width":0.064494684,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.5019952,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.51356745,"width":0.15658244,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.53990424,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.5634477,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.57501996,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.5961692,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6077414,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.62889063,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6404629,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.66161215,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.67318434,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.6995211,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.72306466,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.73463684,"width":0.091755316,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.7557861,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.76735836,"width":0.11619016,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.7885076,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.8000798,"width":0.18932846,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.82122904,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.8328013,"width":0.12898937,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.8539505,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.86552274,"width":0.079288565,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"bounds":{"left":0.0,"top":0.88667196,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"bounds":{"left":0.013297873,"top":0.8982442,"width":0.032247342,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0,"top":0.9193935,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.013297873,"top":0.93096566,"width":0.013131649,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.95211494,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.9636871,"width":0.041722074,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.9848364,"width":0.07962101,"height":0.0151636},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.99640864,"width":0.041722074,"height":0.0035913587},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":1.0,"width":0.07962101,"height":-0.01755786},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":1.0,"width":0.041722074,"height":-0.029130101},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.007978723,"height":-0.05546689},"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.07679521,"height":-0.07901037},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":1.0,"width":0.21575798,"height":-0.09058261},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"bounds":{"left":0.0028257978,"top":0.92897046,"width":0.07413564,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"bounds":{"left":0.0028257978,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"bounds":{"left":0.013796543,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"bounds":{"left":0.024933511,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"bounds":{"left":0.036070477,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"bounds":{"left":0.04720745,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"bounds":{"left":0.1846742,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"bounds":{"left":0.1966423,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"bounds":{"left":0.1939827,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"bounds":{"left":0.08361037,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"bounds":{"left":0.16605718,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"bounds":{"left":0.17935506,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"bounds":{"left":0.079288565,"top":0.14764565,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"bounds":{"left":0.079288565,"top":0.15003991,"width":0.1200133,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"}]...
|
-7318053790178896287
|
8923867554677276104
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
....
|
NULL
|
NULL
|
NULL
|
NULL
|
|
42460
|
1557
|
6
|
2026-05-14T11:35:58.366131+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758558366_m1.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_1
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor...
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":22,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":22,"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Share & export","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":22,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said are there soem potential issues?","depth":21,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"are there soem potential issues?","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Listen","depth":21,"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"While this refactoring is syntactically correct for modern PHP, there are a few practical and technical \"gotchas\" to consider when moving from","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new Class())->method()","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new Class()->method()","depth":24,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"1. Language Compatibility (Backward Compatibility)","depth":22,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"1. Language Compatibility (Backward Compatibility)","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The biggest risk is the PHP version itself.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP < 8.0:","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"This change will cause a","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Parse Error","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":". Prior to PHP 8.0, the parser could not handle member access on a","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"expression without parentheses.","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The \"Trap\":","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"2. Operator Precedence and Readability","depth":22,"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"2. Operator Precedence and Readability","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Visual Grouping:","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The parentheses","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new Class())","depth":26,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"act as a visual \"container,\" making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Consistency:","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If only half the codebase is updated, the inconsistency can lead to \"style drift,\" where different developers follow different patterns, making the code feel disorganized.","depth":25,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"3. Tooling and IDE Support","depth":22,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"3. Tooling and IDE Support","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Static Analysis:","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or \"low-quality code\" if they aren't configured for PHP 8.0+.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Automated Refactoring:","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If this change was done via an automated tool (like Rector), it is usually safe. However, if done via \"Find and Replace,\" there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"4. Error Reporting Sensitivity","depth":22,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"4. Error Reporting Sensitivity","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"In some edge cases, if the constructor of the class throws an exception:","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The stack trace remains the same, but when debugging \"on the fly\" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"before","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"the method call in a watch window.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Summary of Risk Levels","depth":22,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Summary of Risk Levels","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Risk Factor","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Level","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Mitigation","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Production Crash","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"High","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Ensure","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"platform","depth":28,"bounds":{"left":0.0,"top":1.0,"width":0.046875,"height":-0.0027778149},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"in","depth":27,"bounds":{"left":0.0,"top":1.0,"width":0.011458334,"height":-0.0011111498},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"composer.json","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is set to","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"8.0","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"or higher.","depth":27,"bounds":{"left":0.0,"top":1.0,"width":0.050694443,"height":-0.046666622},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Developer Confusion","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Low","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update team style guides to reflect PHP 8.x standards.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Linting Errors","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Medium","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update CI/CD linting rules to support modern PHP syntax.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Risk Factor","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"}]...
|
-5304278751776615499
|
8311382407696383432
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor...
|
42458
|
NULL
|
NULL
|
NULL
|
|
42461
|
1558
|
9
|
2026-05-14T11:35:58.366116+00:00
|
/Users/lukas/.screenpipe/data/data/2026-05-14/1778 /Users/lukas/.screenpipe/data/data/2026-05-14/1778758558366_m2.jpg...
|
Firefox
|
JY-18091 | Update composer to support php 8.5 by n JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app — Work...
|
1
|
github.com/jiminny/app/pull/12058/changes
|
monitor_2
|
NULL
|
NULL
|
NULL
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax....
|
[{"role":"AXButton","text" [{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.057063047,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.08060654,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.09217877,"width":0.101230055,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Reference and Documentation","depth":4,"bounds":{"left":0.0028257978,"top":0.11332801,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Reference and Documentation","depth":5,"bounds":{"left":0.015957447,"top":0.12490024,"width":0.076961435,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"bounds":{"left":0.0028257978,"top":0.14604948,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"bounds":{"left":0.015957447,"top":0.15762171,"width":0.08543883,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive API Changelog","depth":4,"bounds":{"left":0.0028257978,"top":0.17877094,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive API Changelog","depth":5,"bounds":{"left":0.015957447,"top":0.19034317,"width":0.04288564,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":4,"bounds":{"left":0.0028257978,"top":0.21149242,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"client-php/docs/versions/v2/README.md at master · pipedrive/client-php","depth":5,"bounds":{"left":0.015957447,"top":0.22306465,"width":0.12732713,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Changes to the API","depth":4,"bounds":{"left":0.0028257978,"top":0.2442139,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Changes to the API","depth":5,"bounds":{"left":0.015957447,"top":0.25578612,"width":0.033410903,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.27693537,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":true},{"role":"AXStaticText","text":"JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.28850758,"width":0.18068483,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Close tab","depth":5,"bounds":{"left":0.06732048,"top":0.28411812,"width":0.007978723,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXRadioButton","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":4,"bounds":{"left":0.0028257978,"top":0.30965683,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[https://github.com/pipedrive/client-php](https://github.com/pipedrive/client-php) - Google Search","depth":5,"bounds":{"left":0.015957447,"top":0.32122904,"width":0.171875,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.3423783,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.35395053,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Usage | Windsurf","depth":4,"bounds":{"left":0.0,"top":0.37509975,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Usage | Windsurf","depth":5,"bounds":{"left":0.013297873,"top":0.386672,"width":0.029920213,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.41300878,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.4365523,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6848] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.4481245,"width":0.06632314,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20891] Sidekick SMS issue - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.46927375,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20891] Sidekick SMS issue - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.48084596,"width":0.064494684,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.5019952,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.51356745,"width":0.15658244,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.53990424,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.5634477,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6849] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.57501996,"width":0.11735372,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.5961692,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6077414,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.62889063,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.6404629,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0028257978,"top":0.66161215,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.015957447,"top":0.67318434,"width":0.013297873,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":0.6995211,"width":0.007978723,"height":0.01915403},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.72306466,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[SRD-6853] Moxso - Potential deal stages bug - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.73463684,"width":0.091755316,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":4,"bounds":{"left":0.0028257978,"top":0.7557861,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20903] Recorded call does not appear on the dashboard - Jira","depth":5,"bounds":{"left":0.015957447,"top":0.76735836,"width":0.11619016,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":0.7885076,"width":0.07679521,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":0.8000798,"width":0.18932846,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.82122904,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Configure SSH access to multiple environment - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.8328013,"width":0.12898937,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Useful commands - Engineering - Confluence","depth":4,"bounds":{"left":0.0,"top":0.8539505,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Useful commands - Engineering - Confluence","depth":5,"bounds":{"left":0.013297873,"top":0.86552274,"width":0.079288565,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Dev Tools - Elastic","depth":4,"bounds":{"left":0.0,"top":0.88667196,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Dev Tools - Elastic","depth":5,"bounds":{"left":0.013297873,"top":0.8982442,"width":0.032247342,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Jiminny","depth":4,"bounds":{"left":0.0,"top":0.9193935,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Jiminny","depth":5,"bounds":{"left":0.013297873,"top":0.93096566,"width":0.013131649,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.95211494,"width":0.07962101,"height":0.032721467},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.9636871,"width":0.041722074,"height":0.010774142},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":0.9848364,"width":0.07962101,"height":0.0151636},"on_screen":true,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":0.99640864,"width":0.041722074,"height":0.0035913587},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"CloudWatch | eu-west-1","depth":4,"bounds":{"left":0.0,"top":1.0,"width":0.07962101,"height":-0.01755786},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"CloudWatch | eu-west-1","depth":5,"bounds":{"left":0.013297873,"top":1.0,"width":0.041722074,"height":-0.029130101},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Unnamed Group","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.007978723,"height":-0.05546689},"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":true},{"role":"AXRadioButton","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":4,"bounds":{"left":0.0028257978,"top":1.0,"width":0.07679521,"height":-0.07901037},"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app","depth":5,"bounds":{"left":0.015957447,"top":1.0,"width":0.21575798,"height":-0.09058261},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Pipedrive Developers Corner | Pipedrive API sandbox","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"pipedrive/client-php: Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXRadioButton","text":"Code search results","depth":4,"on_screen":false,"help_text":"","role_description":"tab","subrole":"AXTabButton","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXStaticText","text":"Code search results","depth":5,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"New Tab","depth":4,"bounds":{"left":0.0028257978,"top":0.92897046,"width":0.07413564,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Customize sidebar","depth":6,"bounds":{"left":0.0028257978,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Close Google Gemini (⌃X)","depth":6,"bounds":{"left":0.013796543,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Tabs from other devices","depth":6,"bounds":{"left":0.024933511,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open history (⇧⌘H)","depth":6,"bounds":{"left":0.036070477,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Open bookmarks (⌘B)","depth":6,"bounds":{"left":0.04720745,"top":0.97007185,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"AI Chat settings","depth":7,"bounds":{"left":0.1846742,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Close","depth":7,"bounds":{"left":0.1966423,"top":0.055067837,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"WORK, Google Account: lukas.kovalik@jiminny.com","depth":12,"bounds":{"left":0.1939827,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXButton","text":"Main menu","depth":12,"bounds":{"left":0.08361037,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"New Chat","depth":12,"bounds":{"left":0.16605718,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Open menu for conversation actions.","depth":12,"bounds":{"left":0.17935506,"top":0.103751,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false,"is_expanded":false},{"role":"AXHeading","text":"Conversation with Gemini","depth":15,"bounds":{"left":0.079288565,"top":0.14764565,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Conversation with Gemini","depth":16,"bounds":{"left":0.079288565,"top":0.15003991,"width":0.1200133,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Copy prompt","depth":21,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":21,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.","depth":23,"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Expand","depth":21,"on_screen":false,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Listen","depth":22,"on_screen":false,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP 8.5","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Core Change: Member Access on Instantiation","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Core Change: Member Access on Instantiation","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Pattern:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new ClassName())->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is simplified to","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new ClassName()->method()","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reasoning:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Affected Components","depth":23,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Affected Components","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:","depth":24,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"User Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified instantiation of","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUserRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putUsers","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"calls.","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getUsersByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetUserByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteUser","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Group Management:","depth":26,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"postGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Simplified","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"putGroups","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"CoreGroupRequest","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"getGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"GetGroupByQuery","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"and","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"ListResponse","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"patchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"/","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"deleteGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":": Updated","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PatchGroup","depth":29,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":",","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"JsonResponse","depth":29,"bounds":{"left":0.11319814,"top":0.0,"width":0.03357713,"height":0.014764565},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":", and","depth":28,"bounds":{"left":0.14876994,"top":0.0,"width":0.013131649,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Error","depth":29,"bounds":{"left":0.16389628,"top":0.0,"width":0.013962766,"height":0.014764565},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":28,"bounds":{"left":0.17985372,"top":0.0,"width":0.0014960107,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Technical Impact","depth":23,"bounds":{"left":0.08759973,"top":0.0,"width":0.11702128,"height":0.01915403},"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Technical Impact","depth":24,"bounds":{"left":0.08759973,"top":0.0,"width":0.04438165,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"No Functional Change:","depth":26,"bounds":{"left":0.10023271,"top":0.0,"width":0.05867686,"height":0.016360734},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The logic for user provisioning, group updates, and error handling remains identical.","depth":26,"bounds":{"left":0.10023271,"top":0.0,"width":0.103390954,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Code Cleanliness:","depth":26,"bounds":{"left":0.10023271,"top":0.043894652,"width":0.04637633,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.","depth":26,"bounds":{"left":0.10023271,"top":0.043894652,"width":0.09923537,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXCheckBox","text":"Good response","depth":22,"bounds":{"left":0.086269945,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXCheckBox","text":"Bad response","depth":22,"bounds":{"left":0.09690824,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"toggle button","subrole":"AXToggle","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Share & export","depth":21,"bounds":{"left":0.107546546,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy","depth":22,"bounds":{"left":0.11818484,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Show more options","depth":21,"bounds":{"left":0.12882313,"top":0.12290503,"width":0.010638298,"height":0.025538707},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Copy prompt","depth":21,"bounds":{"left":0.1022274,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXButton","text":"Edit","depth":21,"bounds":{"left":0.116855055,"top":0.18355946,"width":0.013297873,"height":0.031923383},"on_screen":true,"role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"You said are there soem potential issues?","depth":21,"bounds":{"left":0.13680187,"top":0.19313647,"width":0.065159574,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"You said","depth":23,"bounds":{"left":0.079288565,"top":0.19393456,"width":0.019946808,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"are there soem potential issues?","depth":23,"bounds":{"left":0.13680187,"top":0.19473264,"width":0.059175532,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXButton","text":"Listen","depth":21,"bounds":{"left":0.1939827,"top":0.26336792,"width":0.013297873,"height":0.031923383},"on_screen":true,"help_text":"","role_description":"button","subrole":"AXUnknown","is_enabled":true,"is_focused":false,"is_selected":false},{"role":"AXHeading","text":"Gemini said","depth":20,"bounds":{"left":0.08460771,"top":0.29449323,"width":0.0003324468,"height":0.0007980846},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Gemini said","depth":21,"bounds":{"left":0.08460771,"top":0.29648843,"width":0.04105718,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"While this refactoring is syntactically correct for modern PHP, there are a few practical and technical \"gotchas\" to consider when moving from","depth":23,"bounds":{"left":0.08759973,"top":0.29768556,"width":0.11668883,"height":0.07861133},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new Class())->method()","depth":24,"bounds":{"left":0.10239362,"top":0.36113328,"width":0.06416223,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"to","depth":23,"bounds":{"left":0.16855054,"top":0.35993615,"width":0.0076462766,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new Class()->method()","depth":24,"bounds":{"left":0.08759973,"top":0.36113328,"width":0.10172872,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":".","depth":23,"bounds":{"left":0.13713431,"top":0.38068634,"width":0.0013297872,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"1. Language Compatibility (Backward Compatibility)","depth":22,"bounds":{"left":0.08759973,"top":0.42138866,"width":0.11702128,"height":0.03830806},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"1. Language Compatibility (Backward Compatibility)","depth":23,"bounds":{"left":0.08759973,"top":0.42298484,"width":0.09757314,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The biggest risk is the PHP version itself.","depth":23,"bounds":{"left":0.08759973,"top":0.46847567,"width":0.09740692,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"PHP < 8.0:","depth":25,"bounds":{"left":0.10023271,"top":0.4980048,"width":0.026263298,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"This change will cause a","depth":25,"bounds":{"left":0.12649602,"top":0.4980048,"width":0.060837764,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Parse Error","depth":25,"bounds":{"left":0.10023271,"top":0.4980048,"width":0.10305851,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":". Prior to PHP 8.0, the parser could not handle member access on a","depth":25,"bounds":{"left":0.10023271,"top":0.51875496,"width":0.09823803,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"new","depth":26,"bounds":{"left":0.18085106,"top":0.54070234,"width":0.00831117,"height":0.014764565},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"expression without parentheses.","depth":25,"bounds":{"left":0.10023271,"top":0.5395052,"width":0.09225399,"height":0.037110932},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The \"Trap\":","depth":25,"bounds":{"left":0.10023271,"top":0.5897845,"width":0.029089095,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.","depth":25,"bounds":{"left":0.10023271,"top":0.5897845,"width":0.1043883,"height":0.09936153},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"2. Operator Precedence and Readability","depth":22,"bounds":{"left":0.08759973,"top":0.7134876,"width":0.11702128,"height":0.01915403},"on_screen":true,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"2. Operator Precedence and Readability","depth":23,"bounds":{"left":0.08759973,"top":0.7150838,"width":0.10388963,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.","depth":23,"bounds":{"left":0.08759973,"top":0.74142057,"width":0.11319814,"height":0.057861134},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Visual Grouping:","depth":25,"bounds":{"left":0.10023271,"top":0.8124501,"width":0.042386968,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The parentheses","depth":25,"bounds":{"left":0.14261968,"top":0.8124501,"width":0.04305186,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"(new Class())","depth":26,"bounds":{"left":0.10023271,"top":0.8136473,"width":0.10139628,"height":0.035514764},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"act as a visual \"container,\" making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.","depth":25,"bounds":{"left":0.10023271,"top":0.83320034,"width":0.099734046,"height":0.12011173},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Consistency:","depth":25,"bounds":{"left":0.10023271,"top":0.96648043,"width":0.03357713,"height":0.016360734},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If only half the codebase is updated, the inconsistency can lead to \"style drift,\" where different developers follow different patterns, making the code feel disorganized.","depth":25,"bounds":{"left":0.10023271,"top":0.96648043,"width":0.10239362,"height":0.033519566},"on_screen":true,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"3. Tooling and IDE Support","depth":22,"bounds":{"left":0.08759973,"top":1.0,"width":0.11702128,"height":-0.090183616},"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"3. Tooling and IDE Support","depth":23,"bounds":{"left":0.08759973,"top":1.0,"width":0.06815159,"height":-0.09177971},"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Static Analysis:","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or \"low-quality code\" if they aren't configured for PHP 8.0+.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Automated Refactoring:","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"If this change was done via an automated tool (like Rector), it is usually safe. However, if done via \"Find and Replace,\" there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"4. Error Reporting Sensitivity","depth":22,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"4. Error Reporting Sensitivity","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"In some edge cases, if the constructor of the class throws an exception:","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"The stack trace remains the same, but when debugging \"on the fly\" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"before","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"the method call in a watch window.","depth":25,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXHeading","text":"Summary of Risk Levels","depth":22,"on_screen":false,"help_text":"","role_description":"heading","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Summary of Risk Levels","depth":23,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Risk Factor","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Level","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Mitigation","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Production Crash","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"High","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Ensure","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"platform","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"in","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"composer.json","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"is set to","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"8.0","depth":28,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"or higher.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Developer Confusion","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Low","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update team style guides to reflect PHP 8.x standards.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Linting Errors","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Medium","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"},{"role":"AXStaticText","text":"Update CI/CD linting rules to support modern PHP syntax.","depth":27,"on_screen":false,"help_text":"","role_description":"text","subrole":"AXUnknown"}]...
|
7839176090915688716
|
8311382407696383432
|
click
|
accessibility
|
NULL
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Pipedrive API Changelog
Pipedrive API Changelog
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
client-php/docs/versions/v2/README.md at master · pipedrive/client-php
Changes to the API
Changes to the API
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
JY-18091 | Update composer to support php 8.5 by nikolaybiaivanov · Pull Request #12058 · jiminny/app
Close tab
[[URL_WITH_CREDENTIALS] -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax....
|
42459
|
NULL
|
NULL
|
NULL
|