|
42870
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
Pipedrive Developers Corner | Pipedrive API sandbox
Pipedrive Developers Corner | Pipedrive API sandbox
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
Code search results
Code search results
Jiminny
Jiminny
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Close tab
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
WORK, Google Account: [EMAIL]
Main menu
New Chat
Open menu for conversation actions.
Conversation with Gemini
Conversation with Gemini
Copy prompt
You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor
Production Crash
Developer Confusion
Linting Errors
Level
High
Low
Medium
Mitigation
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Update team style guides to reflect PHP 8.x standards.
Update CI/CD linting rules to support modern PHP syntax.
Copy table
Are you planning to deploy this to an environment where you are certain the PHP version is strictly 8.0 or higher?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
1 Notification
1 Notification
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards
Create dashboard
Create dashboard
More actions for Dashboards
More actions for Dashboards
Operations
Operations
More actions for Operations
More actions for Operations
Confluence , (opens new window)
Confluence
, (opens new window)
Teams , (opens new window)
Teams
, (opens new window)
open menu
open menu
Customise sidebar
Customise sidebar
Resize side navigation panel...
|
Firefox
|
[JY-20903] Recorded call does not appear on the da [JY-20903] Recorded call does not appear on the dashboard - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20903
|
42870
|
|
42871
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
Pipedrive Developers Corner | Pipedrive API sandbox
Pipedrive Developers Corner | Pipedrive API sandbox
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
Code search results
Code search results
Jiminny
Jiminny
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Close tab
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
WORK, Google Account: [EMAIL]
Main menu
New Chat
Open menu for conversation actions.
Conversation with Gemini
Conversation with Gemini
Copy prompt
You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor
Production Crash
Developer Confusion
Linting Errors
Level
High
Low
Medium
Mitigation
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Update team style guides to reflect PHP 8.x standards.
Update CI/CD linting rules to support modern PHP syntax.
Copy table
Are you planning to deploy this to an environment where you are certain the PHP version is strictly 8.0 or higher?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
1 Notification
1 Notification
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards
Create dashboard
Create dashboard
More actions for Dashboards
More actions for Dashboards
Operations
Operations
More actions for Operations
More actions for Operations
Confluence , (opens new window)
Confluence
, (opens new window)
Teams , (opens new window)
Teams
, (opens new window)
open menu
open menu
Customise sidebar
Customise sidebar
Resize side navigation panel
Spaces
Spaces
/
Jiminny (New) Jiminny (New)
Jiminny (New)
/
Epic - Add parent
Add parent
/
Bug - Change work type
JY-20903
JY-20903
Copy link
Recorded call does not appear on the dashboard- Summary, edit
Recorded call does not appear on the dashboard
Recorded call does not appear on the dashboard
Add or create work related to this Bug
Add or create work related to this Bug
View app actions
View app actions
Collapse Key details Key details
Collapse Key details
Collapse Key details
Key details
Description
Description
Edit Description, edit
Hey team,
Line Kristensen from NationBuilder reported that her call from the 12th of May (
https://app.jiminny.com/playback/67cebfc2-ed56-44a2-8c68-7a0286ed8618
https://app.jiminny.com/playback/67cebfc2-ed56-44a2-8c68-7a0286ed8618
) is not appearing in her dashboard under her recorded activities.
Open image-20260513-102905.png
The same meeting is visible in OnDemand, hence excluding issues with Elastic Search, and from what I know, it covers the requirements to be shown in the dashboard.
Open image-20260513-103157.png
Can someone please check what might be the cause of this?
Steps to reproduce
Steps to reproduce
More information about
Edit Steps to reproduce, edit
NA
Actual outcome
More information about
Edit Actual outcome
The activity is missing from the dashboard page
Expected outcome
More information about
Edit Expected outcome
The activity to be displayed in the dashboard page
Collapse Attachments Attachments 2 More actions for attachments Add Attachment
Collapse Attachments
Collapse Attachments
Attachments
2
More actions for attachments
More actions for attachments
Add Attachment
Add Attachment
Open image-20260513-103157.png
image-20260513-103
157.png
14 May 2026, 12:04 pm
image-20260513-103157.png — Download
image-20260513-103157.png — Delete
Open image-20260513-102905.png...
|
Firefox
|
[JY-20903] Recorded call does not appear on the da [JY-20903] Recorded call does not appear on the dashboard - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20903
|
42871
|
|
42872
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
Pipedrive Developers Corner | Pipedrive API sandbox
Pipedrive Developers Corner | Pipedrive API sandbox
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
Code search results
Code search results
Jiminny
Jiminny
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Close tab
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
WORK, Google Account: [EMAIL]
Main menu
New Chat
Open menu for conversation actions.
Conversation with Gemini
Conversation with Gemini
Copy prompt
You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor
Production Crash
Developer Confusion
Linting Errors
Level
High
Low
Medium
Mitigation
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Update team style guides to reflect PHP 8.x standards.
Update CI/CD linting rules to support modern PHP syntax.
Copy table
Are you planning to deploy this to an environment where you are certain the PHP version is strictly 8.0 or higher?
Good response
Bad response
Redo
Share & export
Copy
Show more options...
|
Firefox
|
[JY-20903] Recorded call does not appear on the da [JY-20903] Recorded call does not appear on the dashboard - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20903
|
42872
|
|
42873
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
Pipedrive Developers Corner | Pipedrive API sandbox
Pipedrive Developers Corner | Pipedrive API sandbox
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
Code search results
Code search results
Jiminny
Jiminny
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Close tab
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
WORK, Google Account: [EMAIL]
Main menu
New Chat
Open menu for conversation actions.
Conversation with Gemini
Conversation with Gemini
Copy prompt
You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:...
|
Firefox
|
[JY-20903] Recorded call does not appear on the da [JY-20903] Recorded call does not appear on the dashboard - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20903
|
42873
|
|
42874
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
Pipedrive Developers Corner | Pipedrive API sandbox
Pipedrive Developers Corner | Pipedrive API sandbox
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
Code search results
Code search results
Jiminny
Jiminny
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Close tab
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
WORK, Google Account: [EMAIL]
Main menu
New Chat
Open menu for conversation actions.
Conversation with Gemini
Conversation with Gemini
Copy prompt
You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+....
|
Firefox
|
[JY-20903] Recorded call does not appear on the da [JY-20903] Recorded call does not appear on the dashboard - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20903
|
42874
|
|
42875
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
Pipedrive Developers Corner | Pipedrive API sandbox
Pipedrive Developers Corner | Pipedrive API sandbox
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
Code search results
Code search results
Jiminny
Jiminny
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Close tab
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
WORK, Google Account: [EMAIL]
Main menu
New Chat
Open menu for conversation actions.
Conversation with Gemini
Conversation with Gemini
Copy prompt
You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order....
|
Firefox
|
[JY-20903] Recorded call does not appear on the da [JY-20903] Recorded call does not appear on the dashboard - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20903
|
42875
|
|
42876
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
Pipedrive Developers Corner | Pipedrive API sandbox
Pipedrive Developers Corner | Pipedrive API sandbox
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
Code search results
Code search results
Jiminny
Jiminny
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Close tab
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
WORK, Google Account: [EMAIL]
Main menu
New Chat
Open menu for conversation actions.
Conversation with Gemini
Conversation with Gemini
Copy prompt
You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before...
|
Firefox
|
[JY-20903] Recorded call does not appear on the da [JY-20903] Recorded call does not appear on the dashboard - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20903
|
42876
|
|
42877
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
Pipedrive Developers Corner | Pipedrive API sandbox
Pipedrive Developers Corner | Pipedrive API sandbox
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
Code search results
Code search results
Jiminny
Jiminny
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Close tab
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
WORK, Google Account: [EMAIL]
Main menu
New Chat
Open menu for conversation actions.
Conversation with Gemini
Conversation with Gemini
Copy prompt
You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax....
|
Firefox
|
[JY-20903] Recorded call does not appear on the da [JY-20903] Recorded call does not appear on the dashboard - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20903
|
42877
|
|
42878
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
Pipedrive Developers Corner | Pipedrive API sandbox
Pipedrive Developers Corner | Pipedrive API sandbox
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
Code search results
Code search results
Jiminny
Jiminny
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Close tab
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
WORK, Google Account: [EMAIL]
Main menu
New Chat
Open menu for conversation actions.
Conversation with Gemini
Conversation with Gemini
Copy prompt
You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor
Production Crash
Developer Confusion
Linting Errors
Level
High
Low
Medium
Mitigation
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Update team style guides to reflect PHP 8.x standards.
Update CI/CD linting rules to support modern PHP syntax.
Copy table
Are you planning to deploy this to an environment where you are certain the PHP version is strictly 8.0 or higher?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
1 Notification
1 Notification
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards
Create dashboard
Create dashboard
More actions for Dashboards
More actions for Dashboards
Operations
Operations
More actions for Operations
More actions for Operations
Confluence , (opens new window)
Confluence
, (opens new window)
Teams , (opens new window)
Teams
, (opens new window)
open menu
open menu
Customise sidebar
Customise sidebar
Resize side navigation panel
Spaces
Spaces
/
Jiminny (New) Jiminny (New)
Jiminny (New)
/
Epic - Add parent
Add parent
/
Bug - Change work type
JY-20903
JY-20903
Copy link
Recorded call does not appear on the dashboard- Summary, edit
Recorded call does not appear on the dashboard
Recorded call does not appear on the dashboard
Add or create work related to this Bug
Add or create work related to this Bug
View app actions
View app actions
Collapse Key details Key details
Collapse Key details
Collapse Key details
Key details
Description
Description
Edit Description, edit
Hey team,
Line Kristensen from NationBuilder reported that her call from the 12th of May (
https://app.jiminny.com/playback/67cebfc2-ed56-44a2-8c68-7a0286ed8618
https://app.jiminny.com/playback/67cebfc2-ed56-44a2-8c68-7a0286ed8618
) is not appearing in her dashboard under her recorded activities.
Open image-20260513-102905.png
The same meeting is visible in OnDemand, hence excluding issues with Elastic Search, and from what I know, it covers the requirements to be shown in the dashboard.
Open image-20260513-103157.png
Can someone please check what might be the cause of this?
Steps to reproduce
Steps to reproduce
More information about
Edit Steps to reproduce, edit
NA
Actual outcome
More information about
Edit Actual outcome
The activity is missing from the dashboard page
Expected outcome
More information about
Edit Expected outcome
The activity to be displayed in the dashboard page
Collapse Attachments Attachments 2 More actions for attachments Add Attachment
Collapse Attachments
Collapse Attachments
Attachments...
|
Firefox
|
[JY-20903] Recorded call does not appear on the da [JY-20903] Recorded call does not appear on the dashboard - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20903
|
42878
|
|
42879
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
Pipedrive Developers Corner | Pipedrive API sandbox
Pipedrive Developers Corner | Pipedrive API sandbox
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
Code search results
Code search results
Jiminny
Jiminny
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Close tab
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
WORK, Google Account: [EMAIL]
Main menu
New Chat
Open menu for conversation actions.
Conversation with Gemini
Conversation with Gemini
Copy prompt
You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor
Production Crash
Developer Confusion
Linting Errors
Level
High
Low
Medium
Mitigation
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Update team style guides to reflect PHP 8.x standards.
Update CI/CD linting rules to support modern PHP syntax.
Copy table
Are you planning to deploy this to an environment where you are certain the PHP version is strictly 8.0 or higher?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
1 Notification
1 Notification
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards...
|
Firefox
|
[JY-20903] Recorded call does not appear on the da [JY-20903] Recorded call does not appear on the dashboard - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20903
|
42879
|
|
42880
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
Pipedrive Developers Corner | Pipedrive API sandbox
Pipedrive Developers Corner | Pipedrive API sandbox
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
Code search results
Code search results
Jiminny
Jiminny
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Close tab
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
WORK, Google Account: [EMAIL]
Main menu
New Chat
Open menu for conversation actions.
Conversation with Gemini
Conversation with Gemini
Copy prompt
You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:...
|
Firefox
|
[JY-20903] Recorded call does not appear on the da [JY-20903] Recorded call does not appear on the dashboard - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20903
|
42880
|
|
42881
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
Pipedrive Developers Corner | Pipedrive API sandbox
Pipedrive Developers Corner | Pipedrive API sandbox
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
Code search results
Code search results
Jiminny
Jiminny
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Close tab
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
WORK, Google Account: [EMAIL]
Main menu
New Chat
Open menu for conversation actions.
Conversation with Gemini
Conversation with Gemini
Copy prompt
You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor
Production Crash
Developer Confusion
Linting Errors
Level
High
Low
Medium
Mitigation
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Update team style guides to reflect PHP 8.x standards.
Update CI/CD linting rules to support modern PHP syntax.
Copy table
Are you planning to deploy this to an environment where you are certain the PHP version is strictly 8.0 or higher?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
1 Notification
1 Notification
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards
Create dashboard
Create dashboard
More actions for Dashboards
More actions for Dashboards
Operations
Operations
More actions for Operations
More actions for Operations
Confluence , (opens new window)
Confluence
, (opens new window)
Teams , (opens new window)
Teams
, (opens new window)
open menu
open menu
Customise sidebar
Customise sidebar
Resize side navigation panel
Spaces
Spaces
/
Jiminny (New) Jiminny (New)
Jiminny (New)
/
Epic - Add parent
Add parent
/
Bug - Change work type
JY-20903
JY-20903
Copy link
Recorded call does not appear on the dashboard- Summary, edit
Recorded call does not appear on the dashboard
Recorded call does not appear on the dashboard
Add or create work related to this Bug
Add or create work related to this Bug
View app actions
View app actions
Collapse Key details Key details
Collapse Key details
Collapse Key details
Key details
Description
Description
Edit Description, edit...
|
Firefox
|
[JY-20903] Recorded call does not appear on the da [JY-20903] Recorded call does not appear on the dashboard - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20903
|
42881
|
|
42882
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
Pipedrive Developers Corner | Pipedrive API sandbox
Pipedrive Developers Corner | Pipedrive API sandbox
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
Code search results
Code search results
Jiminny
Jiminny
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Close tab
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
WORK, Google Account: [EMAIL]
Main menu
New Chat
Open menu for conversation actions.
Conversation with Gemini
Conversation with Gemini
Copy prompt
You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy...
|
Firefox
|
[JY-20903] Recorded call does not appear on the da [JY-20903] Recorded call does not appear on the dashboard - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20903
|
42882
|
|
42883
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
github.com
Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
Pipedrive Developers Corner | Pipedrive API sandbox
Pipedrive Developers Corner | Pipedrive API sandbox
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
daniti/pipedrive-laravel: A Pipedrive App boilerplate with Laravel
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
IsraelOrtuno/pipedrive: Complete Pipedrive API client for PHP
Code search results
Code search results
Jiminny
Jiminny
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Close tab
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
WORK, Google Account: [EMAIL]
Main menu
New Chat
Open menu for conversation actions.
Conversation with Gemini
Conversation with Gemini
Copy prompt
You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor
Production Crash
Developer Confusion
Linting Errors
Level
High
Low
Medium
Mitigation
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Update team style guides to reflect PHP 8.x standards.
Update CI/CD linting rules to support modern PHP syntax.
Copy table
Are you planning to deploy this to an environment where you are certain the PHP version is strictly 8.0 or higher?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
1 Notification
1 Notification
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions...
|
Firefox
|
[JY-20903] Recorded call does not appear on the da [JY-20903] Recorded call does not appear on the dashboard - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20903
|
42883
|
|
42975
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
Jiminny
Jiminny
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Close tab
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
WORK, Google Account: [EMAIL]
Main menu
New Chat
Open menu for conversation actions.
Conversation with Gemini
Conversation with Gemini
Copy prompt
You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said...
|
Firefox
|
[JY-20903] Recorded call does not appear on the da [JY-20903] Recorded call does not appear on the dashboard - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20903
|
42975
|
|
42976
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
Jiminny
Jiminny
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Close tab
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
WORK, Google Account: [EMAIL]
Main menu
New Chat
Open menu for conversation actions.
Conversation with Gemini
Conversation with Gemini
Copy prompt
You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said...
|
Firefox
|
[JY-20903] Recorded call does not appear on the da [JY-20903] Recorded call does not appear on the dashboard - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20903
|
42976
|
|
42977
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
CloudWatch | eu-west-1
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
Jiminny
Jiminny
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Close tab
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
WORK, Google Account: [EMAIL]
Main menu
New Chat
Open menu for conversation actions.
Conversation with Gemini
Conversation with Gemini
Copy prompt
You said I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>JY-18091 | Update composer to support php 8.5 by n</tabTitle>” with “<selection>@@ -40,15 +40,15 @@ public function postUsers(Request $request): JsonResponse40 {40 {41$team = $this->getTeamFromRequest($request);41$team = $this->getTeamFromRequest($request);424243-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);43+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);444445if ($requestDTO->getPrimaryPhoneNumber() !== null) {45if ($requestDTO->getPrimaryPhoneNumber() !== null) {46$user = $this->userRepository->findByPhone(46$user = $this->userRepository->findByPhone(47 phone: $requestDTO->getPrimaryPhoneNumber(),47 phone: $requestDTO->getPrimaryPhoneNumber(),48 );48 );494950if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {50if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {51-return (new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists'))51+return new Error(Constants::HTTP_BAD_REQUEST, 'User primary phone already exists')52 ->getResponse();52 ->getResponse();53 }53 }54 }54 }@@ -59,7 +59,7 @@ public function postUsers(Request $request): JsonResponse59 );59 );606061if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {61if ($user !== null && $user->getEmailAddress() !== $requestDTO->getEmailPrimaryWork()) {62-return (new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists'))62+return new Error(Constants::HTTP_BAD_REQUEST, 'User secondary phone already exists')63 ->getResponse();63 ->getResponse();64 }64 }65 }65 }@@ -74,11 +74,11 @@ public function postUsers(Request $request): JsonResponse74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);74$newUser = $this->scimProvisioning->createOrUpdateNewUser($requestDTO, $team);757576if (! $newUser instanceof User) {76if (! $newUser instanceof User) {77-return (new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed'))77+return new Error(Constants::HTTP_BAD_REQUEST, 'User create operation failed')78 ->getResponse();78 ->getResponse();79 }79 }808081-return (new CoreUser())81+return new CoreUser()82 ->createFromUser($newUser)82 ->createFromUser($newUser)83 ->setExternalId($requestDTO->getUserName())83 ->setExternalId($requestDTO->getUserName())84 ->setHttpCode(Constants::HTTP_CREATED)84 ->setHttpCode(Constants::HTTP_CREATED)@@ -93,22 +93,22 @@ public function putUsers(Request $request, string $id): JsonResponse93$team = $this->getTeamFromRequest($request);93$team = $this->getTeamFromRequest($request);949495if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {95if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {96-return (new Error())->getResponse();96+return new Error()->getResponse();97 }97 }989899-$requestDTO = (new CoreUserRequest())->createFromRequestPayload($request);99+$requestDTO = new CoreUserRequest()->createFromRequestPayload($request);100100101try {101try {102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);102$user = $this->scimProvisioning->updateUserAttributesIfChanged(User::uuid($id), $requestDTO, $team);103103104-return (new CoreUser())104+return new CoreUser()105 ->createFromUser($user)105 ->createFromUser($user)106 ->setHttpCode(Constants::HTTP_OK)106 ->setHttpCode(Constants::HTTP_OK)107 ->getResponse();107 ->getResponse();108 } catch (Exception $exception) {108 } catch (Exception $exception) {109 Sentry::captureException($exception);109 Sentry::captureException($exception);110110111-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();111+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();112 }112 }113 }113 }114114@@ -117,7 +117,7 @@ public function deleteUser(Request $request, string $id): JsonResponse117$team = $this->getTeamFromRequest($request);117$team = $this->getTeamFromRequest($request);118118119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {119if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {120-return (new Error())->getResponse();120+return new Error()->getResponse();121 }121 }122122123$user = $this->scimProvisioning->getUserById($id);123$user = $this->scimProvisioning->getUserById($id);@@ -131,18 +131,18 @@ public function deleteUser(Request $request, string $id): JsonResponse131 ),131 ),132 );132 );133133134-return (new JsonResponse())->setStatusCode(204);134+return new JsonResponse()->setStatusCode(204);135 }135 }136136137public function patchUser(Request $request, string $id): JsonResponse137public function patchUser(Request $request, string $id): JsonResponse138 {138 {139$team = $this->getTeamFromRequest($request);139$team = $this->getTeamFromRequest($request);140140141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {141if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {142-return (new Error())->getResponse();142+return new Error()->getResponse();143 }143 }144144145-$requestDTO = (new PatchUser())145+$requestDTO = new PatchUser()146 ->setResourceLocalId($id)146 ->setResourceLocalId($id)147 ->createFromRequestPayload($request);147 ->createFromRequestPayload($request);148148@@ -153,10 +153,10 @@ public function patchUser(Request $request, string $id): JsonResponse153 } catch (Exception $e) {153 } catch (Exception $e) {154 Sentry::captureException($e);154 Sentry::captureException($e);155155156-return (new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed'))->getResponse();156+return new Error(Constants::HTTP_BAD_REQUEST, 'Operation failed')->getResponse();157 }157 }158158159-return (new CoreUser())159+return new CoreUser()160 ->createFromUser($user)160 ->createFromUser($user)161 ->setHttpCode(Constants::HTTP_OK)161 ->setHttpCode(Constants::HTTP_OK)162 ->getResponse();162 ->getResponse();@@ -167,16 +167,16 @@ public function getUser(Request $request, string $id): JsonResponse167$team = $this->getTeamFromRequest($request);167$team = $this->getTeamFromRequest($request);168168169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {169if (! $this->scimProvisioning->validateUserIdInput($id, $team)) {170-return (new Error())->getResponse();170+return new Error()->getResponse();171 }171 }172172173$user = $this->scimProvisioning->getUserById($id);173$user = $this->scimProvisioning->getUserById($id);174174175if (! $team->isSame($user->getTeam())) {175if (! $team->isSame($user->getTeam())) {176-return (new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.'))->getResponse();176+return new Error(Constants::HTTP_ACCESS_DENIED, 'Context does not match.')->getResponse();177 }177 }178178179-return (new CoreUser())179+return new CoreUser()180 ->setHttpCode(Constants::HTTP_OK)180 ->setHttpCode(Constants::HTTP_OK)181 ->createFromUser($user)181 ->createFromUser($user)182 ->getResponse();182 ->getResponse();@@ -186,20 +186,20 @@ public function getUsersByQuery(Request $request): JsonResponse186 {186 {187$team = $this->getTeamFromRequest($request);187$team = $this->getTeamFromRequest($request);188188189-$requestDto = (new GetUserByQuery())->createFromRequestPayload($request);189+$requestDto = new GetUserByQuery()->createFromRequestPayload($request);190190191try {191try {192$resultsQuery = $this->scimProvisioning192$resultsQuery = $this->scimProvisioning193 ->translateQueryStringsToUserModelQuery($requestDto, $team);193 ->translateQueryStringsToUserModelQuery($requestDto, $team);194 } catch (Exception $exception) {194 } catch (Exception $exception) {195-return (new ListResponse())->createEmpty()->getResponse();195+return new ListResponse()->createEmpty()->getResponse();196 }196 }197197198$resultsQuery198$resultsQuery199 ->limit($requestDto->getCount())199 ->limit($requestDto->getCount())200 ->offset($requestDto->getStartIndex() - 1);200 ->offset($requestDto->getStartIndex() - 1);201201202-return (new ListResponse())202+return new ListResponse()203 ->setHttpCode(Constants::HTTP_OK)203 ->setHttpCode(Constants::HTTP_OK)204 ->setStartIndex($requestDto->getStartIndex())204 ->setStartIndex($requestDto->getStartIndex())205 ->createFromCollection($resultsQuery->get())205 ->createFromCollection($resultsQuery->get())@@ -210,15 +210,15 @@ public function postGroups(Request $request): JsonResponse210 {210 {211$team = $this->getTeamFromRequest($request);211$team = $this->getTeamFromRequest($request);212212213-$requestDto = (new CoreGroupRequest())->createFromRequestPayload($request);213+$requestDto = new CoreGroupRequest()->createFromRequestPayload($request);214214215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);215$group = $this->scimProvisioning->createNewGroup($requestDto, $team);216216217if (! $group instanceof Group) {217if (! $group instanceof Group) {218-return (new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed'))->getResponse();218+return new Error(Constants::HTTP_BAD_REQUEST, 'Group resource create failed')->getResponse();219 }219 }220220221-$response = (new CoreGroup())->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();221+$response = new CoreGroup()->createFromGroup($group)->setHttpCode(Constants::HTTP_CREATED)->getResponse();222222223return $response;223return $response;224 }224 }@@ -228,22 +228,22 @@ public function putGroups(Request $request, string $id): JsonResponse228$team = $this->getTeamFromRequest($request);228$team = $this->getTeamFromRequest($request);229229230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {230if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {231-return (new Error())->getResponse();231+return new Error()->getResponse();232 }232 }233233234-$requestDTO = (new CoreGroupRequest())->createFromRequestPayload($request);234+$requestDTO = new CoreGroupRequest()->createFromRequestPayload($request);235235236try {236try {237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);237$group = $this->scimProvisioning->updateGroupAttributesIfChanged(Group::uuid($id), $requestDTO, $team);238238239-return (new CoreGroup())239+return new CoreGroup()240 ->createFromGroup($group)240 ->createFromGroup($group)241 ->setHttpCode(Constants::HTTP_OK)241 ->setHttpCode(Constants::HTTP_OK)242 ->getResponse();242 ->getResponse();243 } catch (Exception $exception) {243 } catch (Exception $exception) {244 Sentry::captureException($exception);244 Sentry::captureException($exception);245245246-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();246+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();247 }247 }248 }248 }249249@@ -252,12 +252,12 @@ public function getGroup(Request $request, string $id): JsonResponse252$team = $this->getTeamFromRequest($request);252$team = $this->getTeamFromRequest($request);253253254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {254if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {255-return (new Error())->getResponse();255+return new Error()->getResponse();256 }256 }257257258$group = $this->scimProvisioning->getGroupById($id);258$group = $this->scimProvisioning->getGroupById($id);259259260-return (new CoreGroup())260+return new CoreGroup()261 ->excludeAttributes($request)261 ->excludeAttributes($request)262 ->setHttpCode(Constants::HTTP_OK)262 ->setHttpCode(Constants::HTTP_OK)263 ->createFromGroup($group)263 ->createFromGroup($group)@@ -268,19 +268,19 @@ public function getGroupByQuery(Request $request): JsonResponse268 {268 {269$team = $this->getTeamFromRequest($request);269$team = $this->getTeamFromRequest($request);270270271-$dto = (new GetGroupByQuery())->createFromRequestPayload($request);271+$dto = new GetGroupByQuery()->createFromRequestPayload($request);272272273try {273try {274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);274$groupsQuery = $this->scimProvisioning->translateQueryStringsToGroupModelQuery($dto, $team);275 } catch (Exception $exception) {275 } catch (Exception $exception) {276-return (new ListResponse())->createEmpty()->getResponse();276+return new ListResponse()->createEmpty()->getResponse();277 }277 }278278279$groupsQuery279$groupsQuery280 ->limit($dto->getCount())280 ->limit($dto->getCount())281 ->offset($dto->getStartIndex() - 1);281 ->offset($dto->getStartIndex() - 1);282282283-return (new ListResponse())283+return new ListResponse()284 ->setHttpCode(Constants::HTTP_OK)284 ->setHttpCode(Constants::HTTP_OK)285 ->setStartIndex($dto->getStartIndex())285 ->setStartIndex($dto->getStartIndex())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())286 ->createFromCollection($groupsQuery->get(), $dto->getExcludeAttributes())@@ -292,30 +292,30 @@ public function patchGroup(Request $request, $id): JsonResponse292$team = $this->getTeamFromRequest($request);292$team = $this->getTeamFromRequest($request);293293294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {294if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {295-return (new Error())->getResponse();295+return new Error()->getResponse();296 }296 }297297298-$dto = (new PatchGroup())->createFromRequestPayload($request);298+$dto = new PatchGroup()->createFromRequestPayload($request);299299300$group = Group::uuid($id);300$group = Group::uuid($id);301301302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);302$this->scimProvisioning->patchGroupOperation($dto, $team, $group);303303304-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);304+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);305 }305 }306306307public function deleteGroup(Request $request, $id): JsonResponse307public function deleteGroup(Request $request, $id): JsonResponse308 {308 {309$team = $this->getTeamFromRequest($request);309$team = $this->getTeamFromRequest($request);310310311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {311if (! $this->scimProvisioning->validateGroupIdInput($id, $team)) {312-return (new Error())->getResponse();312+return new Error()->getResponse();313 }313 }314314315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {315if ($this->scimProvisioning->deleteGroup(Group::uuid($id))) {316-return (new JsonResponse())->setStatusCode(Constants::HTTP_NO_CONTENT);316+return new JsonResponse()->setStatusCode(Constants::HTTP_NO_CONTENT);317 } else {317 } else {318-return (new Error(Constants::HTTP_ERROR, 'Operation failed'))->getResponse();318+return new Error(Constants::HTTP_ERROR, 'Operation failed')->getResponse();319 }319 }320 }320 }321321</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Listen
Gemini said
Gemini said
The selected code changes represent a mechanical refactoring of a PHP controller to align with modern syntax standards, likely as part of the upgrade to
PHP 8.5
.
Core Change: Member Access on Instantiation
Core Change: Member Access on Instantiation
The primary modification across the entire file is the removal of unnecessary parentheses when performing member access (method chaining) on a newly instantiated object.
Pattern:
(new ClassName())->method()
is simplified to
new ClassName()->method()
.
Reasoning:
Since PHP 8.0+, the parser handles member access on new expressions without requiring the wrapping parentheses for disambiguation.
Affected Components
Affected Components
The refactoring impacts various response and DTO (Data Transfer Object) initializations within the following SCIM (System for Cross-domain Identity Management) endpoints:
User Management:
postUsers
: Simplified instantiation of
CoreUserRequest
,
Error
, and
CoreUser
.
putUsers
/
patchUser
/
getUser
: Updated
Error
,
CoreUser
, and
PatchUser
calls.
getUsersByQuery
: Updated
GetUserByQuery
and
ListResponse
.
deleteUser
: Updated
JsonResponse
and
Error
.
Group Management:
postGroups
: Simplified
CoreGroupRequest
,
Error
, and
CoreGroup
.
putGroups
/
getGroup
: Updated
CoreGroupRequest
and
Error
.
getGroupByQuery
: Updated
GetGroupByQuery
and
ListResponse
.
patchGroup
/
deleteGroup
: Updated
PatchGroup
,
JsonResponse
, and
Error
.
Technical Impact
Technical Impact
No Functional Change:
The logic for user provisioning, group updates, and error handling remains identical.
Code Cleanliness:
Reduces visual noise and adopts the more concise syntax permitted in recent PHP versions.
Good response
Bad response
Share & export
Copy
Show more options
Copy prompt
Edit
You said are there soem potential issues?
You said
are there soem potential issues?
Listen
Gemini said
Gemini said
While this refactoring is syntactically correct for modern PHP, there are a few practical and technical "gotchas" to consider when moving from
(new Class())->method()
to
new Class()->method()
.
1. Language Compatibility (Backward Compatibility)
1. Language Compatibility (Backward Compatibility)
The biggest risk is the PHP version itself.
PHP < 8.0:
This change will cause a
Parse Error
. Prior to PHP 8.0, the parser could not handle member access on a
new
expression without parentheses.
The "Trap":
If your production environment is updated to PHP 8.5 but a developer's local environment or a specific CI runner is still on PHP 7.4, the code will break immediately.
2. Operator Precedence and Readability
2. Operator Precedence and Readability
While the engine now understands this syntax, human developers might find it slightly more ambiguous at a glance.
Visual Grouping:
The parentheses
(new Class())
act as a visual "container," making it clear that the instantiation happens first. Without them, in very complex one-liners, it can take a fraction of a second longer for a human to parse the execution order.
Consistency:
If only half the codebase is updated, the inconsistency can lead to "style drift," where different developers follow different patterns, making the code feel disorganized.
3. Tooling and IDE Support
3. Tooling and IDE Support
Static Analysis:
Older versions of static analysis tools (like PHPStan or Psalm) or older IDE versions might flag the new syntax as an error or "low-quality code" if they aren't configured for PHP 8.0+.
Automated Refactoring:
If this change was done via an automated tool (like Rector), it is usually safe. However, if done via "Find and Replace," there is a risk of accidentally stripping parentheses from complex expressions where they might still be required for logic.
4. Error Reporting Sensitivity
4. Error Reporting Sensitivity
In some edge cases, if the constructor of the class throws an exception:
The stack trace remains the same, but when debugging "on the fly" in some older debugger clients, the lack of grouping can occasionally make it slightly harder to evaluate the object state
before
the method call in a watch window.
Summary of Risk Levels
Summary of Risk Levels
Risk Factor
Level
Mitigation
Production Crash
High
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Developer Confusion
Low
Update team style guides to reflect PHP 8.x standards.
Linting Errors
Medium
Update CI/CD linting rules to support modern PHP syntax.
Risk Factor
Production Crash
Developer Confusion
Linting Errors
Level
High
Low
Medium
Mitigation
Ensure
platform
in
composer.json
is set to
8.0
or higher.
Update team style guides to reflect PHP 8.x standards.
Update CI/CD linting rules to support modern PHP syntax.
Copy table
Are you planning to deploy this to an environment where you are certain the PHP version is strictly 8.0 or higher?
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
1 Notification
1 Notification
Help...
|
Firefox
|
[JY-20903] Recorded call does not appear on the da [JY-20903] Recorded call does not appear on the dashboard - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20903
|
42977
|
|
37682
|
Screenpipe — Archive
Screenpipe — Archive
All docs Screenpipe — Archive
Screenpipe — Archive
All docs · AFFiNE
All docs · AFFiNE
DXP4800PLUS-B5F8
DXP4800PLUS-B5F8
New Tab
New Tab
Screenpipe — Archive
Screenpipe — Archive
SQLite Web: archive.db
SQLite Web: archive.db
SQLite Web: db.sqlite
SQLite Web: db.sqlite
Claude
Claude
Manage extra usage for paid Claude plans | Claude Help Center
Manage extra usage for paid Claude plans | Claude Help Center
2 TB in 25 MB/s - Google Search
2 TB in 25 MB/s - Google Search
Jira
Jira
Close tab
New Tab...
|
Firefox
|
Jira — Personal
|
jiminny.atlassian.net/browse/JY-20897?atlOrigin=ey jiminny.atlassian.net/browse/JY-20897?atlOrigin=eyJpIjoiOGQ1YzRiODQ0NGI2NDI5OWE3Nzk1ZWY1NDFlZjY2Y2QiLCJwIjoiamlyYS1zbGFjay1pbnQifQ...
|
37682
|
|
37692
|
Usage | Windsurf
Usage | Windsurf
JY-20891 add sup Usage | Windsurf
Usage | Windsurf
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
Jira
Jira
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Collapse sidebar [
Collapse sidebar [
The App Switcher is loading
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
Notifications
Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards
Create dashboard
Create dashboard
More actions for Dashboards
More actions for Dashboards
Operations...
|
Firefox
|
Jira — Work
|
jiminny.atlassian.net/browse/JY-20897?atlOrigin=ey jiminny.atlassian.net/browse/JY-20897?atlOrigin=eyJpIjoiOGQ1YzRiODQ0NGI2NDI5OWE3Nzk1ZWY1NDFlZjY2Y2QiLCJwIjoiamlyYS1zbGFjay1pbnQifQ...
|
37692
|
|
37693
|
Usage | Windsurf
Usage | Windsurf
JY-20891 add sup Usage | Windsurf
Usage | Windsurf
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
Jira
Jira
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Collapse sidebar [
Collapse sidebar [
The App Switcher is loading
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
Notifications
Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards...
|
Firefox
|
Jira — Work
|
jiminny.atlassian.net/browse/JY-20897?atlOrigin=ey jiminny.atlassian.net/browse/JY-20897?atlOrigin=eyJpIjoiOGQ1YzRiODQ0NGI2NDI5OWE3Nzk1ZWY1NDFlZjY2Y2QiLCJwIjoiamlyYS1zbGFjay1pbnQifQ...
|
37693
|
|
37694
|
Usage | Windsurf
Usage | Windsurf
JY-20891 add sup Usage | Windsurf
Usage | Windsurf
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
Notifications
Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards
Create dashboard
Create dashboard
More actions for Dashboards
More actions for Dashboards
Operations
Operations
More actions for Operations
More actions for Operations
Confluence , (opens new window)
Confluence
, (opens new window)...
|
Firefox
|
[JY-20897] [Laravel 13] Testing of Platform Domain [JY-20897] [Laravel 13] Testing of Platform Domain - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20897?atlOrigin=ey jiminny.atlassian.net/browse/JY-20897?atlOrigin=eyJpIjoiOGQ1YzRiODQ0NGI2NDI5OWE3Nzk1ZWY1NDFlZjY2Y2QiLCJwIjoiamlyYS1zbGFjay1pbnQifQ...
|
37694
|
|
37695
|
Usage | Windsurf
Usage | Windsurf
JY-20891 add sup Usage | Windsurf
Usage | Windsurf
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
Notifications
Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces...
|
Firefox
|
[JY-20897] [Laravel 13] Testing of Platform Domain [JY-20897] [Laravel 13] Testing of Platform Domain - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20897?atlOrigin=ey jiminny.atlassian.net/browse/JY-20897?atlOrigin=eyJpIjoiOGQ1YzRiODQ0NGI2NDI5OWE3Nzk1ZWY1NDFlZjY2Y2QiLCJwIjoiamlyYS1zbGFjay1pbnQifQ...
|
37695
|
|
37696
|
Usage | Windsurf
Usage | Windsurf
JY-20891 add sup Usage | Windsurf
Usage | Windsurf
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
Notifications
Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards
Create dashboard
Create dashboard
More actions for Dashboards...
|
Firefox
|
[JY-20897] [Laravel 13] Testing of Platform Domain [JY-20897] [Laravel 13] Testing of Platform Domain - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20897?atlOrigin=ey jiminny.atlassian.net/browse/JY-20897?atlOrigin=eyJpIjoiOGQ1YzRiODQ0NGI2NDI5OWE3Nzk1ZWY1NDFlZjY2Y2QiLCJwIjoiamlyYS1zbGFjay1pbnQifQ...
|
37696
|
|
37697
|
Usage | Windsurf
Usage | Windsurf
JY-20891 add sup Usage | Windsurf
Usage | Windsurf
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
Notifications
Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards
Create dashboard
Create dashboard
More actions for Dashboards
More actions for Dashboards
Operations
Operations
More actions for Operations
More actions for Operations
Confluence , (opens new window)
Confluence
, (opens new window)
Teams , (opens new window)
Teams
, (opens new window)
open menu
open menu
Customise sidebar
Customise sidebar
Resize side navigation panel
Spaces
Spaces
/
Jiminny (New) Jiminny (New)
Jiminny (New)
/
Epic - Change parent
JY-20894
JY-20894
/
Technical Story - Change work type
JY-20897
JY-20897
Copy link
[Laravel 13] Testing of Platform Domain- Summary, edit
[Laravel 13] Testing of Platform Domain
[Laravel 13] Testing of Platform Domain
Add or create work related to this Technical Story
Add or create work related to this Technical Story
View app actions
View app actions
Description
Description
Add Description, edit
Edit description
Subtasks
Subtasks
Add subtask
Add subtask
Collapse Linked work items Linked work items Link a work item
Collapse Linked work items
Collapse Linked work items
Linked work items
Link a work item
Link a work item
clones
clones
JY-16113 is not done
JY-16113
[Laravel 12] Testing of Platform Domain
[Laravel 12] Testing of Platform Domain
Closed - Change status
CLOSED
Unlink work item
Activity
Activity
All
All
Comments
Comments
History
History...
|
Firefox
|
[JY-20897] [Laravel 13] Testing of Platform Domain [JY-20897] [Laravel 13] Testing of Platform Domain - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20897?atlOrigin=ey jiminny.atlassian.net/browse/JY-20897?atlOrigin=eyJpIjoiOGQ1YzRiODQ0NGI2NDI5OWE3Nzk1ZWY1NDFlZjY2Y2QiLCJwIjoiamlyYS1zbGFjay1pbnQifQ...
|
37697
|
|
37699
|
Usage | Windsurf
Usage | Windsurf
JY-20891 add sup Usage | Windsurf
Usage | Windsurf
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
Notifications
Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards
Create dashboard
Create dashboard
More actions for Dashboards
More actions for Dashboards
Operations
Operations
More actions for Operations
More actions for Operations
Confluence , (opens new window)
Confluence
, (opens new window)
Teams , (opens new window)
Teams
, (opens new window)
open menu
open menu
Customise sidebar
Customise sidebar
Resize side navigation panel
Spaces
Spaces
/
Jiminny (New) Jiminny (New)
Jiminny (New)
/
Epic - Change parent
JY-20894
JY-20894
/
Technical Story - Change work type
JY-20897
JY-20897
Copy link
[Laravel 13] Testing of Platform Domain- Summary, edit
[Laravel 13] Testing of Platform Domain
[Laravel 13] Testing of Platform Domain
Add or create work related to this Technical Story
Add or create work related to this Technical Story
View app actions
View app actions
Description
Description
Add Description, edit
Edit description
Subtasks
Subtasks
Add subtask
Add subtask
Collapse Linked work items Linked work items Link a work item
Collapse Linked work items
Collapse Linked work items
Linked work items
Link a work item
Link a work item
clones
clones
JY-16113 is not done
JY-16113
[Laravel 12] Testing of Platform Domain
[Laravel 12] Testing of Platform Domain
Closed - Change status
CLOSED
Unlink work item
Activity
Activity
All
All
Comments
Comments
History
History
Work log
Work log
Newest first Newest first
Newest first
More information about Stefka Stoyanova
Stefka Stoyanova
updated the
Story Points
1 hour ago
15
→
8
More information about Stefka Stoyanova
Stefka Stoyanova
updated the
Days
1 hour ago
15
→
10
More information about Stefka Stoyanova
Stefka Stoyanova
changed the
Parent
1 hour ago
JY-16110
→
JY-20894
More information about Stefka Stoyanova
Stefka Stoyanova
changed the
Assignee
1 hour ago
Lukas Kovalik
→
Unassigned
More information about Stefka Stoyanova
Stefka Stoyanova
updated the
Link
1 hour ago
None
→
This work item clones JY-16113
More information about Stefka Stoyanova
Stefka Stoyanova
changed the
Parent
1 hour ago
None
→
JY-16110
More information about Stefka Stoyanova
Stefka Stoyanova
created the
Work item
1 hour ago
Resize work item view side panel...
|
Firefox
|
[JY-20897] [Laravel 13] Testing of Platform Domain [JY-20897] [Laravel 13] Testing of Platform Domain - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20897?atlOrigin=ey jiminny.atlassian.net/browse/JY-20897?atlOrigin=eyJpIjoiOGQ1YzRiODQ0NGI2NDI5OWE3Nzk1ZWY1NDFlZjY2Y2QiLCJwIjoiamlyYS1zbGFjay1pbnQifQ...
|
37699
|
|
37700
|
Usage | Windsurf
Usage | Windsurf
JY-20891 add sup Usage | Windsurf
Usage | Windsurf
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
Notifications
Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards
Create dashboard
Create dashboard
More actions for Dashboards
More actions for Dashboards
Operations
Operations
More actions for Operations
More actions for Operations
Confluence , (opens new window)
Confluence
, (opens new window)
Teams , (opens new window)
Teams
, (opens new window)
open menu
open menu
Customise sidebar
Customise sidebar
Resize side navigation panel
Spaces
Spaces
/
Jiminny (New) Jiminny (New)
Jiminny (New)
/
Epic - Change parent
JY-20894
JY-20894
/
Technical Story - Change work type
JY-20897
JY-20897
Copy link
[Laravel 13] Testing of Platform Domain- Summary, edit
[Laravel 13] Testing of Platform Domain
[Laravel 13] Testing of Platform Domain
Add or create work related to this Technical Story
Add or create work related to this Technical Story
View app actions
View app actions
Description
Description
Add Description, edit
Edit description
Subtasks
Subtasks
Add subtask
Add subtask
Collapse Linked work items Linked work items Link a work item
Collapse Linked work items
Collapse Linked work items
Linked work items
Link a work item
Link a work item
clones
clones
JY-16113 is not done
JY-16113
[Laravel 12] Testing of Platform Domain
[Laravel 12] Testing of Platform Domain
Closed - Change status
CLOSED
Unlink work item
Activity
Activity
All
All
Comments
Comments
History
History
Work log
Work log
Newest first Newest first
Newest first
More information about Stefka Stoyanova
Stefka Stoyanova
updated the
Story Points
1 hour ago
15
→
8
More information about Stefka Stoyanova
Stefka Stoyanova
updated the
Days
1 hour ago
15
→
10
More information about Stefka Stoyanova
Stefka Stoyanova
changed the
Parent
1 hour ago
JY-16110
→
JY-20894
More information about Stefka Stoyanova
Stefka Stoyanova
changed the
Assignee
1 hour ago...
|
Firefox
|
[JY-20897] [Laravel 13] Testing of Platform Domain [JY-20897] [Laravel 13] Testing of Platform Domain - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20897?atlOrigin=ey jiminny.atlassian.net/browse/JY-20897?atlOrigin=eyJpIjoiOGQ1YzRiODQ0NGI2NDI5OWE3Nzk1ZWY1NDFlZjY2Y2QiLCJwIjoiamlyYS1zbGFjay1pbnQifQ...
|
37700
|
|
37701
|
Usage | Windsurf
Usage | Windsurf
JY-20891 add sup Usage | Windsurf
Usage | Windsurf
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
Notifications
Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards
Create dashboard
Create dashboard
More actions for Dashboards
More actions for Dashboards
Operations
Operations
More actions for Operations
More actions for Operations
Confluence , (opens new window)
Confluence
, (opens new window)
Teams , (opens new window)
Teams
, (opens new window)
open menu
open menu
Customise sidebar
Customise sidebar
Resize side navigation panel
Spaces
Spaces
/
Jiminny (New) Jiminny (New)
Jiminny (New)
/
Epic - Change parent
JY-20894
JY-20894
/
Technical Story - Change work type
JY-20897
JY-20897
Copy link
[Laravel 13] Testing of Platform Domain- Summary, edit
[Laravel 13] Testing of Platform Domain
[Laravel 13] Testing of Platform Domain
Add or create work related to this Technical Story
Add or create work related to this Technical Story
View app actions
View app actions
Description
Description
Add Description, edit
Edit description
Subtasks
Subtasks
Add subtask
Add subtask
Collapse Linked work items Linked work items Link a work item
Collapse Linked work items
Collapse Linked work items
Linked work items
Link a work item
Link a work item
clones
clones
JY-16113 is not done
JY-16113
[Laravel 12] Testing of Platform Domain
[Laravel 12] Testing of Platform Domain
Closed - Change status
CLOSED
Unlink work item...
|
Firefox
|
[JY-20897] [Laravel 13] Testing of Platform Domain [JY-20897] [Laravel 13] Testing of Platform Domain - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20897?atlOrigin=ey jiminny.atlassian.net/browse/JY-20897?atlOrigin=eyJpIjoiOGQ1YzRiODQ0NGI2NDI5OWE3Nzk1ZWY1NDFlZjY2Y2QiLCJwIjoiamlyYS1zbGFjay1pbnQifQ...
|
37701
|
|
37702
|
Usage | Windsurf
Usage | Windsurf
JY-20891 add sup Usage | Windsurf
Usage | Windsurf
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
Notifications
Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards
Create dashboard
Create dashboard
More actions for Dashboards
More actions for Dashboards
Operations
Operations
More actions for Operations
More actions for Operations
Confluence , (opens new window)
Confluence
, (opens new window)
Teams , (opens new window)
Teams
, (opens new window)
open menu
open menu
Customise sidebar
Customise sidebar
Resize side navigation panel
Spaces
Spaces
/
Jiminny (New) Jiminny (New)
Jiminny (New)
/
Epic - Change parent
JY-20894
JY-20894
/
Technical Story - Change work type
JY-20897
JY-20897
Copy link
[Laravel 13] Testing of Platform Domain- Summary, edit
[Laravel 13] Testing of Platform Domain
[Laravel 13] Testing of Platform Domain
Add or create work related to this Technical Story
Add or create work related to this Technical Story
View app actions
View app actions
Description
Description
Add Description, edit
Edit description
Subtasks
Subtasks
Add subtask
Add subtask
Collapse Linked work items Linked work items Link a work item
Collapse Linked work items
Collapse Linked work items
Linked work items
Link a work item
Link a work item
clones
clones
JY-16113 is not done
JY-16113
[Laravel 12] Testing of Platform Domain
[Laravel 12] Testing of Platform Domain
Closed - Change status
CLOSED
Unlink work item
Activity
Activity
All
All
Comments
Comments
History
History
Work log
Work log
Newest first Newest first
Newest first
More information about Stefka Stoyanova
Stefka Stoyanova
updated the
Story Points
1 hour ago
15
→
8...
|
Firefox
|
[JY-20897] [Laravel 13] Testing of Platform Domain [JY-20897] [Laravel 13] Testing of Platform Domain - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20897?atlOrigin=ey jiminny.atlassian.net/browse/JY-20897?atlOrigin=eyJpIjoiOGQ1YzRiODQ0NGI2NDI5OWE3Nzk1ZWY1NDFlZjY2Y2QiLCJwIjoiamlyYS1zbGFjay1pbnQifQ...
|
37702
|
|
37703
|
Usage | Windsurf
Usage | Windsurf
JY-20891 add sup Usage | Windsurf
Usage | Windsurf
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
Notifications
Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards
Create dashboard
Create dashboard
More actions for Dashboards
More actions for Dashboards
Operations
Operations
More actions for Operations
More actions for Operations
Confluence , (opens new window)
Confluence
, (opens new window)
Teams , (opens new window)
Teams
, (opens new window)
open menu
open menu
Customise sidebar
Customise sidebar
Resize side navigation panel
Spaces
Spaces
/
Jiminny (New) Jiminny (New)
Jiminny (New)
/
Epic - Change parent
JY-20894
JY-20894
/
Technical Story - Change work type
JY-20897
JY-20897
Copy link
[Laravel 13] Testing of Platform Domain- Summary, edit
[Laravel 13] Testing of Platform Domain
[Laravel 13] Testing of Platform Domain
Add or create work related to this Technical Story
Add or create work related to this Technical Story
View app actions
View app actions
Description
Description
Add Description, edit
Edit description
Subtasks
Subtasks
Add subtask
Add subtask
Collapse Linked work items Linked work items Link a work item
Collapse Linked work items
Collapse Linked work items
Linked work items
Link a work item
Link a work item
clones
clones
JY-16113 is not done
JY-16113
[Laravel 12] Testing of Platform Domain
[Laravel 12] Testing of Platform Domain
Closed - Change status
CLOSED
Unlink work item
Activity
Activity
All
All
Comments
Comments
History
History
Work log
Work log
Newest first Newest first
Newest first...
|
Firefox
|
[JY-20897] [Laravel 13] Testing of Platform Domain [JY-20897] [Laravel 13] Testing of Platform Domain - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20897?atlOrigin=ey jiminny.atlassian.net/browse/JY-20897?atlOrigin=eyJpIjoiOGQ1YzRiODQ0NGI2NDI5OWE3Nzk1ZWY1NDFlZjY2Y2QiLCJwIjoiamlyYS1zbGFjay1pbnQifQ...
|
37703
|
|
37704
|
Usage | Windsurf
Usage | Windsurf
JY-20891 add sup Usage | Windsurf
Usage | Windsurf
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
Notifications
Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards
Create dashboard
Create dashboard
More actions for Dashboards
More actions for Dashboards
Operations
Operations
More actions for Operations
More actions for Operations
Confluence , (opens new window)
Confluence
, (opens new window)
Teams , (opens new window)
Teams
, (opens new window)
open menu
open menu
Customise sidebar
Customise sidebar
Resize side navigation panel
Spaces
Spaces
/
Jiminny (New) Jiminny (New)
Jiminny (New)
/
Epic - Change parent
JY-20894
JY-20894
/
Technical Story - Change work type
JY-20897
JY-20897
Copy link
[Laravel 13] Testing of Platform Domain- Summary, edit
[Laravel 13] Testing of Platform Domain
[Laravel 13] Testing of Platform Domain
Add or create work related to this Technical Story
Add or create work related to this Technical Story
View app actions
View app actions
Description
Description
Add Description, edit
Edit description
Subtasks
Subtasks
Add subtask...
|
Firefox
|
[JY-20897] [Laravel 13] Testing of Platform Domain [JY-20897] [Laravel 13] Testing of Platform Domain - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20897?atlOrigin=ey jiminny.atlassian.net/browse/JY-20897?atlOrigin=eyJpIjoiOGQ1YzRiODQ0NGI2NDI5OWE3Nzk1ZWY1NDFlZjY2Y2QiLCJwIjoiamlyYS1zbGFjay1pbnQifQ...
|
37704
|
|
37705
|
Usage | Windsurf
Usage | Windsurf
JY-20891 add sup Usage | Windsurf
Usage | Windsurf
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
Notifications
Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards
Create dashboard
Create dashboard
More actions for Dashboards
More actions for Dashboards
Operations
Operations
More actions for Operations
More actions for Operations
Confluence , (opens new window)
Confluence
, (opens new window)
Teams , (opens new window)
Teams
, (opens new window)
open menu
open menu
Customise sidebar
Customise sidebar
Resize side navigation panel
Spaces
Spaces
/
Jiminny (New) Jiminny (New)
Jiminny (New)
/
Epic - Change parent
JY-20894
JY-20894
/
Technical Story - Change work type
JY-20897
JY-20897
Copy link
[Laravel 13] Testing of Platform Domain- Summary, edit
[Laravel 13] Testing of Platform Domain
[Laravel 13] Testing of Platform Domain
Add or create work related to this Technical Story
Add or create work related to this Technical Story
View app actions
View app actions
Description
Description
Add Description, edit...
|
Firefox
|
[JY-20897] [Laravel 13] Testing of Platform Domain [JY-20897] [Laravel 13] Testing of Platform Domain - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20897?atlOrigin=ey jiminny.atlassian.net/browse/JY-20897?atlOrigin=eyJpIjoiOGQ1YzRiODQ0NGI2NDI5OWE3Nzk1ZWY1NDFlZjY2Y2QiLCJwIjoiamlyYS1zbGFjay1pbnQifQ...
|
37705
|
|
37706
|
Usage | Windsurf
Usage | Windsurf
JY-20891 add sup Usage | Windsurf
Usage | Windsurf
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
Notifications
Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards
Create dashboard
Create dashboard
More actions for Dashboards
More actions for Dashboards
Operations
Operations
More actions for Operations
More actions for Operations
Confluence , (opens new window)
Confluence
, (opens new window)
Teams , (opens new window)
Teams
, (opens new window)
open menu
open menu
Customise sidebar
Customise sidebar
Resize side navigation panel
Spaces
Spaces
/
Jiminny (New) Jiminny (New)
Jiminny (New)
/
Epic - Change parent
JY-20894
JY-20894
/
Technical Story - Change work type
JY-20897
JY-20897
Copy link
[Laravel 13] Testing of Platform Domain- Summary, edit
[Laravel 13] Testing of Platform Domain
[Laravel 13] Testing of Platform Domain
Add or create work related to this Technical Story
Add or create work related to this Technical Story
View app actions
View app actions
Description
Description
Add Description, edit
Edit description
Subtasks
Subtasks
Add subtask
Add subtask
Collapse Linked work items Linked work items Link a work item
Collapse Linked work items
Collapse Linked work items
Linked work items
Link a work item
Link a work item
clones
clones
JY-16113 is not done
JY-16113
[Laravel 12] Testing of Platform Domain
[Laravel 12] Testing of Platform Domain
Closed - Change status
CLOSED
Unlink work item
Activity
Activity
All
All
Comments
Comments
History
History
Work log
Work log
Newest first Newest first
Newest first
More information about Stefka Stoyanova
Stefka Stoyanova
updated the
Story Points
1 hour ago
15
→
8
More information about Stefka Stoyanova
Stefka Stoyanova
updated the
Days
1 hour ago
15
→
10
More information about Stefka Stoyanova
Stefka Stoyanova
changed the
Parent
1 hour ago
JY-16110
→
JY-20894
More information about Stefka Stoyanova
Stefka Stoyanova
changed the
Assignee
1 hour ago
Lukas Kovalik
→
Unassigned
More information about Stefka Stoyanova
Stefka Stoyanova
updated the
Link
1 hour ago
None
→
This work item clones JY-16113
More information about Stefka Stoyanova
Stefka Stoyanova
changed the
Parent
1 hour ago
None
→
JY-16110
More information about Stefka Stoyanova
Stefka Stoyanova
created the
Work item
1 hour ago
Resize work item view side panel
Watch options: You are not watching this issue, 1 person watching
1
Share
Share
Actions
Actions
Backlog - Change status
Backlog
Automation
Automation
Improve Technical Story
Improve Technical Story
Details
Details
Details
Assignee
Assignee Pin to top. Only you can see pinned fields.
Unassigned- edit Assignee
Unassigned
Assign to me
Reporter
Reporter Pin to top. Only you can see pinned fields.
Stefka Stoyanova- edit Reporter
More information about Stefka Stoyanova
Stefka Stoyanova
Development
Development Pin to top. Only you can see pinned fields....
|
Firefox
|
[JY-20897] [Laravel 13] Testing of Platform Domain [JY-20897] [Laravel 13] Testing of Platform Domain - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20897?atlOrigin=ey jiminny.atlassian.net/browse/JY-20897?atlOrigin=eyJpIjoiOGQ1YzRiODQ0NGI2NDI5OWE3Nzk1ZWY1NDFlZjY2Y2QiLCJwIjoiamlyYS1zbGFjay1pbnQifQ...
|
37706
|
|
37707
|
Usage | Windsurf
Usage | Windsurf
JY-20891 add sup Usage | Windsurf
Usage | Windsurf
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
Notifications
Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards
Create dashboard
Create dashboard
More actions for Dashboards
More actions for Dashboards
Operations
Operations
More actions for Operations
More actions for Operations
Confluence , (opens new window)
Confluence
, (opens new window)
Teams , (opens new window)
Teams
, (opens new window)
open menu
open menu
Customise sidebar
Customise sidebar
Resize side navigation panel
Spaces
Spaces
/
Jiminny (New) Jiminny (New)
Jiminny (New)
/
Epic - Change parent
JY-20894
JY-20894
/
Technical Story - Change work type
JY-20897
JY-20897
Copy link
[Laravel 13] Testing of Platform Domain- Summary, edit
[Laravel 13] Testing of Platform Domain
[Laravel 13] Testing of Platform Domain
Add or create work related to this Technical Story
Add or create work related to this Technical Story
View app actions
View app actions
Description
Description
Add Description, edit
Edit description
Subtasks
Subtasks
Add subtask
Add subtask
Collapse Linked work items Linked work items Link a work item
Collapse Linked work items
Collapse Linked work items
Linked work items
Link a work item
Link a work item
clones
clones
JY-16113 is not done
JY-16113
[Laravel 12] Testing of Platform Domain
[Laravel 12] Testing of Platform Domain
Closed - Change status
CLOSED
Unlink work item
Activity
Activity
All
All
Comments
Comments
History
History
Work log
Work log
Newest first Newest first
Newest first
More information about Stefka Stoyanova
Stefka Stoyanova
updated the
Story Points
1 hour ago
15
→
8
More information about Stefka Stoyanova
Stefka Stoyanova
updated the
Days
1 hour ago
15
→
10
More information about Stefka Stoyanova
Stefka Stoyanova
changed the
Parent
1 hour ago
JY-16110
→
JY-20894
More information about Stefka Stoyanova
Stefka Stoyanova
changed the
Assignee
1 hour ago
Lukas Kovalik
→
Unassigned
More information about Stefka Stoyanova
Stefka Stoyanova
updated the
Link
1 hour ago
None
→
This work item clones JY-16113
More information about Stefka Stoyanova
Stefka Stoyanova
changed the
Parent
1 hour ago
None
→
JY-16110
More information about Stefka Stoyanova
Stefka Stoyanova
created the
Work item
1 hour ago
Resize work item view side panel
Watch options: You are not watching this issue, 1 person watching
1
Share
Share
Actions
Actions
Backlog - Change status
Backlog
Automation
Automation
Improve Technical Story
Improve Technical Story
Details
Details
Details
Assignee
Assignee Pin to top. Only you can see pinned fields.
Unassigned- edit Assignee
Unassigned
Assign to me
Reporter
Reporter Pin to top. Only you can see pinned fields.
Stefka Stoyanova- edit Reporter
More information about Stefka Stoyanova
Stefka Stoyanova
Development
Development Pin to top. Only you can see pinned fields.
Open with VS Code Link to external website in new tab
Open with VS Code
Create branch Link to external website in new tab
Create branch
Create and checkout new branch
Create commit
Create commit
Components
Components Pin to top. Only you can see pinned fields.
Edit Components, edit
Platform
Platform
Sub-Product
Sub-Product Pin to top. Only you can see pinned fields.
Edit Sub-Product, Add options selected, edit
Add options
Labels
Labels Pin to top. Only you can see pinned fields.
Edit Labels
QA
QA
Story point estimate
More information about
Story point estimate Pin to top. Only you can see pinned fields.
Edit Story point estimate
None
Story Points
More information about
Story Points Pin to top. Only you can see pinned fields.
Edit Story Points
8
Organisations
More information about Organisations
Organisations Pin to top. Only you can see pinned fields.
Edit Organisations, None selected, edit
None
Priority
Priority Pin to top. Only you can see pinned fields.
Edit Priority
Medium
Fix versions
Fix versions Pin to top. Only you can see pinned fields.
Edit Fix versions, None selected, edit
None
Sprint
More information about
Sprint Pin to top. Only you can see pinned fields.
Edit Sprint
None...
|
Firefox
|
[JY-20897] [Laravel 13] Testing of Platform Domain [JY-20897] [Laravel 13] Testing of Platform Domain - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20897?atlOrigin=ey jiminny.atlassian.net/browse/JY-20897?atlOrigin=eyJpIjoiOGQ1YzRiODQ0NGI2NDI5OWE3Nzk1ZWY1NDFlZjY2Y2QiLCJwIjoiamlyYS1zbGFjay1pbnQifQ...
|
37707
|
|
37708
|
Usage | Windsurf
Usage | Windsurf
JY-20891 add sup Usage | Windsurf
Usage | Windsurf
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
Notifications
Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards
Create dashboard
Create dashboard
More actions for Dashboards
More actions for Dashboards
Operations
Operations
More actions for Operations
More actions for Operations
Confluence , (opens new window)
Confluence
, (opens new window)
Teams , (opens new window)
Teams
, (opens new window)
open menu
open menu
Customise sidebar
Customise sidebar
Resize side navigation panel
Spaces
Spaces
/
Jiminny (New) Jiminny (New)
Jiminny (New)
/
Epic - Change parent
JY-20894
JY-20894
/
Technical Story - Change work type
JY-20897
JY-20897
Copy link
[Laravel 13] Testing of Platform Domain- Summary, edit
[Laravel 13] Testing of Platform Domain
[Laravel 13] Testing of Platform Domain
Add or create work related to this Technical Story
Add or create work related to this Technical Story
View app actions
View app actions
Description
Description
Add Description, edit
Edit description
Subtasks
Subtasks
Add subtask
Add subtask
Collapse Linked work items Linked work items Link a work item
Collapse Linked work items
Collapse Linked work items
Linked work items
Link a work item
Link a work item
clones
clones
JY-16113 is not done
JY-16113
[Laravel 12] Testing of Platform Domain
[Laravel 12] Testing of Platform Domain
Closed - Change status
CLOSED
Unlink work item
Activity
Activity
All
All
Comments
Comments
History
History
Work log
Work log
Newest first Newest first
Newest first
More information about Stefka Stoyanova
Stefka Stoyanova
updated the
Story Points
1 hour ago
15
→
8
More information about Stefka Stoyanova
Stefka Stoyanova
updated the
Days
1 hour ago
15
→
10
More information about Stefka Stoyanova
Stefka Stoyanova
changed the
Parent
1 hour ago
JY-16110
→
JY-20894
More information about Stefka Stoyanova
Stefka Stoyanova
changed the
Assignee
1 hour ago
Lukas Kovalik
→
Unassigned
More information about Stefka Stoyanova...
|
Firefox
|
[JY-20897] [Laravel 13] Testing of Platform Domain [JY-20897] [Laravel 13] Testing of Platform Domain - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20897?atlOrigin=ey jiminny.atlassian.net/browse/JY-20897?atlOrigin=eyJpIjoiOGQ1YzRiODQ0NGI2NDI5OWE3Nzk1ZWY1NDFlZjY2Y2QiLCJwIjoiamlyYS1zbGFjay1pbnQifQ...
|
37708
|
|
37709
|
Usage | Windsurf
Usage | Windsurf
JY-20891 add sup Usage | Windsurf
Usage | Windsurf
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
Notifications
Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards
Create dashboard
Create dashboard
More actions for Dashboards
More actions for Dashboards
Operations
Operations
More actions for Operations
More actions for Operations
Confluence , (opens new window)
Confluence
, (opens new window)
Teams , (opens new window)
Teams
, (opens new window)
open menu
open menu
Customise sidebar
Customise sidebar
Resize side navigation panel
Spaces
Spaces
/
Jiminny (New) Jiminny (New)
Jiminny (New)
/
Epic - Change parent
JY-20894
JY-20894
/
Technical Story - Change work type
JY-20897
JY-20897
Copy link
[Laravel 13] Testing of Platform Domain- Summary, edit
[Laravel 13] Testing of Platform Domain
[Laravel 13] Testing of Platform Domain
Add or create work related to this Technical Story
Add or create work related to this Technical Story
View app actions
View app actions
Description
Description
Add Description, edit
Edit description
Subtasks
Subtasks
Add subtask
Add subtask
Collapse Linked work items Linked work items Link a work item
Collapse Linked work items
Collapse Linked work items
Linked work items
Link a work item
Link a work item
clones
clones
JY-16113 is not done
JY-16113
[Laravel 12] Testing of Platform Domain
[Laravel 12] Testing of Platform Domain
Closed - Change status
CLOSED
Unlink work item
Activity
Activity
All
All
Comments
Comments
History
History
Work log
Work log
Newest first Newest first
Newest first
More information about Stefka Stoyanova
Stefka Stoyanova
updated the
Story Points
1 hour ago
15
→
8
More information about Stefka Stoyanova
Stefka Stoyanova
updated the
Days
1 hour ago...
|
Firefox
|
[JY-20897] [Laravel 13] Testing of Platform Domain [JY-20897] [Laravel 13] Testing of Platform Domain - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20897?atlOrigin=ey jiminny.atlassian.net/browse/JY-20897?atlOrigin=eyJpIjoiOGQ1YzRiODQ0NGI2NDI5OWE3Nzk1ZWY1NDFlZjY2Y2QiLCJwIjoiamlyYS1zbGFjay1pbnQifQ...
|
37709
|
|
37710
|
Usage | Windsurf
Usage | Windsurf
JY-20891 add sup Usage | Windsurf
Usage | Windsurf
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
Notifications
Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards
Create dashboard
Create dashboard
More actions for Dashboards
More actions for Dashboards
Operations
Operations
More actions for Operations
More actions for Operations
Confluence , (opens new window)
Confluence
, (opens new window)
Teams , (opens new window)
Teams
, (opens new window)
open menu
open menu
Customise sidebar
Customise sidebar
Resize side navigation panel
Spaces
Spaces
/
Jiminny (New) Jiminny (New)
Jiminny (New)
/
Epic - Change parent
JY-20894
JY-20894
/
Technical Story - Change work type
JY-20897
JY-20897
Copy link
[Laravel 13] Testing of Platform Domain- Summary, edit
[Laravel 13] Testing of Platform Domain
[Laravel 13] Testing of Platform Domain
Add or create work related to this Technical Story
Add or create work related to this Technical Story
View app actions
View app actions
Description
Description
Add Description, edit
Edit description
Subtasks
Subtasks
Add subtask
Add subtask
Collapse Linked work items Linked work items Link a work item
Collapse Linked work items
Collapse Linked work items
Linked work items
Link a work item
Link a work item
clones
clones
JY-16113 is not done
JY-16113
[Laravel 12] Testing of Platform Domain
[Laravel 12] Testing of Platform Domain
Closed - Change status
CLOSED
Unlink work item
Activity
Activity
All
All
Comments
Comments
History
History
Work log
Work log
Newest first Newest first
Newest first
More information about Stefka Stoyanova
Stefka Stoyanova
updated the
Story Points
1 hour ago
15
→
8
More information about Stefka Stoyanova
Stefka Stoyanova
updated the
Days
1 hour ago
15
→
10
More information about Stefka Stoyanova
Stefka Stoyanova
changed the
Parent
1 hour ago
JY-16110
→
JY-20894
More information about Stefka Stoyanova
Stefka Stoyanova
changed the
Assignee
1 hour ago
Lukas Kovalik
→
Unassigned
More information about Stefka Stoyanova
Stefka Stoyanova
updated the
Link
1 hour ago
None
→
This work item clones JY-16113
More information about Stefka Stoyanova
Stefka Stoyanova
changed the
Parent
1 hour ago
None
→
JY-16110
More information about Stefka Stoyanova
Stefka Stoyanova
created the
Work item
1 hour ago
Resize work item view side panel
Watch options: You are not watching this issue, 1 person watching
1
Share
Share
Actions
Actions
Backlog - Change status
Backlog
Automation
Automation
Improve Technical Story
Improve Technical Story
Details
Details
Details
Assignee
Assignee Pin to top. Only you can see pinned fields.
Unassigned- edit Assignee
Unassigned
Assign to me
Reporter
Reporter Pin to top. Only you can see pinned fields.
Stefka Stoyanova- edit Reporter
More information about Stefka Stoyanova
Stefka Stoyanova...
|
Firefox
|
[JY-20897] [Laravel 13] Testing of Platform Domain [JY-20897] [Laravel 13] Testing of Platform Domain - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20897?atlOrigin=ey jiminny.atlassian.net/browse/JY-20897?atlOrigin=eyJpIjoiOGQ1YzRiODQ0NGI2NDI5OWE3Nzk1ZWY1NDFlZjY2Y2QiLCJwIjoiamlyYS1zbGFjay1pbnQifQ...
|
37710
|
|
37711
|
Usage | Windsurf
Usage | Windsurf
JY-20891 add sup Usage | Windsurf
Usage | Windsurf
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
Notifications
Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards
Create dashboard
Create dashboard
More actions for Dashboards
More actions for Dashboards
Operations
Operations
More actions for Operations
More actions for Operations
Confluence , (opens new window)
Confluence
, (opens new window)
Teams , (opens new window)
Teams
, (opens new window)
open menu
open menu
Customise sidebar
Customise sidebar
Resize side navigation panel
Spaces
Spaces
/
Jiminny (New) Jiminny (New)
Jiminny (New)
/
Epic - Change parent
JY-20894
JY-20894
/
Technical Story - Change work type
JY-20897
JY-20897
Copy link
[Laravel 13] Testing of Platform Domain- Summary, edit
[Laravel 13] Testing of Platform Domain
[Laravel 13] Testing of Platform Domain
Add or create work related to this Technical Story
Add or create work related to this Technical Story
View app actions
View app actions
Description
Description
Add Description, edit
Edit description
Subtasks
Subtasks
Add subtask
Add subtask
Collapse Linked work items Linked work items Link a work item
Collapse Linked work items
Collapse Linked work items
Linked work items
Link a work item
Link a work item
clones
clones
JY-16113 is not done
JY-16113
[Laravel 12] Testing of Platform Domain
[Laravel 12] Testing of Platform Domain
Closed - Change status
CLOSED
Unlink work item
Activity
Activity
All
All
Comments
Comments
History
History
Work log
Work log
Newest first Newest first
Newest first
More information about Stefka Stoyanova
Stefka Stoyanova
updated the
Story Points
1 hour ago
15
→
8
More information about Stefka Stoyanova
Stefka Stoyanova
updated the
Days
1 hour ago
15
→
10
More information about Stefka Stoyanova
Stefka Stoyanova
changed the
Parent
1 hour ago
JY-16110
→
JY-20894
More information about Stefka Stoyanova
Stefka Stoyanova
changed the
Assignee
1 hour ago
Lukas Kovalik
→
Unassigned
More information about Stefka Stoyanova
Stefka Stoyanova
updated the
Link...
|
Firefox
|
[JY-20897] [Laravel 13] Testing of Platform Domain [JY-20897] [Laravel 13] Testing of Platform Domain - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20897?atlOrigin=ey jiminny.atlassian.net/browse/JY-20897?atlOrigin=eyJpIjoiOGQ1YzRiODQ0NGI2NDI5OWE3Nzk1ZWY1NDFlZjY2Y2QiLCJwIjoiamlyYS1zbGFjay1pbnQifQ...
|
37711
|
|
37731
|
Usage | Windsurf
Usage | Windsurf
JY-20891 add sup Usage | Windsurf
Usage | Windsurf
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
Notifications
Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards
Create dashboard
Create dashboard
More actions for Dashboards
More actions for Dashboards
Operations
Operations
More actions for Operations
More actions for Operations
Confluence , (opens new window)
Confluence
, (opens new window)
Teams , (opens new window)
Teams
, (opens new window)
open menu
open menu
Customise sidebar
Customise sidebar
Resize side navigation panel
Spaces
Spaces
/
Jiminny (New) Jiminny (New)
Jiminny (New)
/
Epic - Change parent
JY-20894
JY-20894
/
Technical Story - Change work type
JY-20897
JY-20897
Copy link
[Laravel 13] Testing of Platform Domain- Summary, edit
[Laravel 13] Testing of Platform Domain
[Laravel 13] Testing of Platform Domain
Add or create work related to this Technical Story
Add or create work related to this Technical Story
View app actions
View app actions
Description
Description
Add Description, edit
Edit description
Subtasks
Subtasks
Add subtask
Add subtask
Collapse Linked work items Linked work items Link a work item
Collapse Linked work items
Collapse Linked work items
Linked work items
Link a work item
Link a work item
clones
clones
JY-16113 is not done
JY-16113
[Laravel 12] Testing of Platform Domain
[Laravel 12] Testing of Platform Domain
Closed - Change status
CLOSED
Unlink work item
Activity
Activity
All
All
Comments
Comments
History
History
Work log
Work log
Newest first Newest first
Newest first
More information about Stefka Stoyanova
Stefka Stoyanova
updated the
Story Points
1 hour ago
15
→
8...
|
Firefox
|
[JY-20897] [Laravel 13] Testing of Platform Domain [JY-20897] [Laravel 13] Testing of Platform Domain - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20897?atlOrigin=ey jiminny.atlassian.net/browse/JY-20897?atlOrigin=eyJpIjoiOGQ1YzRiODQ0NGI2NDI5OWE3Nzk1ZWY1NDFlZjY2Y2QiLCJwIjoiamlyYS1zbGFjay1pbnQifQ...
|
37731
|
|
37732
|
Usage | Windsurf
Usage | Windsurf
JY-20891 add sup Usage | Windsurf
Usage | Windsurf
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
Notifications
Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions...
|
Firefox
|
[JY-20897] [Laravel 13] Testing of Platform Domain [JY-20897] [Laravel 13] Testing of Platform Domain - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20897?atlOrigin=ey jiminny.atlassian.net/browse/JY-20897?atlOrigin=eyJpIjoiOGQ1YzRiODQ0NGI2NDI5OWE3Nzk1ZWY1NDFlZjY2Y2QiLCJwIjoiamlyYS1zbGFjay1pbnQifQ...
|
37732
|
|
37733
|
Usage | Windsurf
Usage | Windsurf
JY-20891 add sup Usage | Windsurf
Usage | Windsurf
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Sidebar...
|
Firefox
|
[JY-20897] [Laravel 13] Testing of Platform Domain [JY-20897] [Laravel 13] Testing of Platform Domain - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20897?atlOrigin=ey jiminny.atlassian.net/browse/JY-20897?atlOrigin=eyJpIjoiOGQ1YzRiODQ0NGI2NDI5OWE3Nzk1ZWY1NDFlZjY2Y2QiLCJwIjoiamlyYS1zbGFjay1pbnQifQ...
|
37733
|
|
37734
|
iTerm2Shell EditViewSessionScriptsProfilesWindowHe iTerm2Shell EditViewSessionScriptsProfilesWindowHelpA100% <8• Wed 13 May 19:21:30DOCKERO 81DEV (docker)₴2APP (-zsh)83ec2-user@ip-10-20-31-146:~-zsh|84screenpipe*О ₴5ec2-user@ip-10-30-129-...ec2-user@ip-10-20-31-14... 27[2026-05-13 15:28:23Jproduction.INFO:[SocialAccountService] Fetching"trace_id":"1a72fef6-427a-4e63-a9ba-b340103c976b"}token {"socialAccountId":30110, "provider": "hubspot"} {"correlation_id":"edla364d-0b07-4c47-95a7-d22fd8ef6bec[2026-05-13 15:28:23] production.INFO: [SocialAccountService] Token needs refreshing {"socialAccountId":30110, "provider": "hubspot"} {"correlation_id": "ed1a364d-0b07-4c47-95a7-d22fd&ef6bec","trace_id":"1a72fef6-427a-4e63-a9ba-b340103c976b"}[2026-05-13 15:28:23] production.INFO: [EncryptedTokenManager] Generating access token. {"mode":"legacy"} {"correlation_id":"ed1a364d-0b07-4c47-95a7-d22fd8ef6bec"fef6-427a-4e63-a9ba-b340103c976b"},"trace_id" :"1a72[2026-05-13 15:28:23] production.INFO: [SocialAccountService] Refreshing token from provider {"socialAccountId":30110, "provider": "hubspot", "refreshToken" : "9417a6a067cd68efa0bd023e970cc27482ef7db27b876a4383f5a246c4e8d81c", "state": "full-refresh"} {"correlation_id":"edla364d-0b07-4c47-95a7-d22fd8ef6bec", "trace_id": "1a72fef6-427a-4e63-a9ba-b340103c976b"}[2026-05-1315:28:23Jproduction.ERROR: [SocialAccountService] Failedto refresh token {"socialAccountId" :30110, "provider" : "hubspot",,"responseBody":"{\"status\":\"BAD_HUB\", \"message\":\"missing or unknown hub id\",\"correlationId\":\"019e21f4-1184-72ca-8C79-d9e09814baa4\", \"error)":\"access_denied\", \"error_description)":\"missing or unknown hub idl"}"3 {"correlation_id":"ed1a364d-0b07-4c47-95a7-d22fd8ef6bec", "trace_id":"1a72fef6-427a-4e63-a9ba-b340103c976b"}[2026-05-1315:28:23] production.INF0: [SocialAccountObserver] Saving model {"correlation_id":"ed1a364d-0b07-4c47-95a7-d22fd8ef6bec","trace_id":"1a72fef6-427a-4e63-a9ba-b340103c976b"}Flow refresh required.root@453da0675541:/home/jiminny# php artisan jiminny:token-info -A 30110-R[2026-05-13 15:28:31] production.INF0: Jiminny\Console\Commands\Command::run Memory usage before starting command {"command": "jiminny:token-info"."memoryBeforeCommandInMb" :116.0,"memoryPeakBeforeCommandInMb":116.0} {"correlation_id":"ble2505a-8c60-4607-a96a-a33209efd4c4", "trace_id":"001e9c48-df0f-4111-9988-d3bb8bf7bfa8"}[2026-05-13 15:28:31] production.INFO: [SocialAccountService] Fetching token {"socialAccountId":30110,"provider": "hubspot"} {"correlation_id":"b1e2505a-8c60-4607-a96a-a33209efd4c4, "trace_id": "001e9c48-df0f-4111-9988-d3bb8bf7bfa8"}[2026-05-13 15:28:31] production.INF0: [SocialAccountService]Token needs refreshing {"socialAccountId":30110,"provider": "hubspot"} {"correlation_id":"ble2505a-8c60-4607-a96a-a33209efd4c4", "trace_id":"001e9c48-df0f-4111-9988-d3bb8bf7bfa8"}[2026-05-13 15:28:31] production.INFO: [EncryptedTokenManager] Generating access token. {"mode":"legacy"} {"correlation_id":"ble2505a-8c60-4607-a96a-a33209efd4c4"9c48-df0f-4111-9988-d3bb8bf7bfa8"}"trace_id":"001e[2026-05-13 15:28:31] production.INFO: [SocialAccountService] Refreshing token from provider {"socialAccountId":30110, "provider": "hubspot","refreshToken": "9417aбa067cd68efa0bd023e970cc27482ef7db27b876a4383f5a246c4e8d81c","state": "full-refresh"} {"correlation_id":"ble2505a-8c60-4607-a96a-a33209efd4c4".',"trace_id":"001e9c48-df0f-4111-9988-d3bb8bf7bfa8"}[2026-05-13 15:28:32] production.ERROR: [SocialAccountService] Failed to refresh token {"socialAccountId":30110, "provider": "hubspot","responseBody":"{\"status\":\"BAD_HUB\", \"message\":\"missing or unknown hub id\",\"correlationId\":\"019e21f4-319c-7501-8b0e-d3118c6534f8\".,\"error)":\"access_denied\", \"error_description)":\"missing or unknown hub id\"}"}"correlation_id": "b1e2505a-8c60-4607-a96a-a33209efd4c4", "trace_id": "001e9c48-df0f-4111-9988-d3bb8bf7bfa8"}[2026-05-13 15:28:32] production.INFO: [SocialAccountObserver] Saving model {"correlation_id":"ble2505a-8c60-4607-a96a-a33209efd4c4", "trace_id": "001e9c48-df0f-4111-9988-d3bb8bf7bfa8'"}Flow refresh required.root@453da0675541:/home/jiminny# [ec2-user@ip-10-20-31-146 ~]$ 0...
|
Firefox
|
[JY-20897] [Laravel 13] Testing of Platform Domain [JY-20897] [Laravel 13] Testing of Platform Domain - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20897?atlOrigin=ey jiminny.atlassian.net/browse/JY-20897?atlOrigin=eyJpIjoiOGQ1YzRiODQ0NGI2NDI5OWE3Nzk1ZWY1NDFlZjY2Y2QiLCJwIjoiamlyYS1zbGFjay1pbnQifQ...
|
37734
|
|
37735
|
FirefoxcalVIewMistorbookmarksProtlles()JY-20891 ad FirefoxcalVIewMistorbookmarksProtlles()JY-20891 add support for secondaNN1 (SRD-6848] Sidekick SMS issue -Platform Sprint 4 02 - Platform Telf Dependabot alerts • jiminny/prophe(JY-19958) Upgrade BE libraries -XWY-207731 User Pilot not receivini@JY-19957 | Remove abanded sympTvpeError: Leaque Flvsystem File)u Userpilot | Ask Jiminny Report Gen€ fJY-19957] Upgrade BE libraries• Dependabot alerts - fiminnvlapr.(UY-20891] Sidekick SMS issue - J(SRD-68491 Recorded call does n9 liminnv8 Jiminny8 Jiminnv& Configure SSH access to multiple ‹≥ Useful commands - Engineering -Dev Tools - Flastic8 Jiminny* (SRD-6853) Moxso - Potential deaCa CloudWatch | us-east-2ca CloudWatch | us-east-z…WJY-208971 [Laravel 131 Testin: X_ New Tab1OOISWindowmelpny.atlassian.net/browse/JY-20897?atlOrigin=eyJpljoiOGQ1YzRiODQONGI2NDI50WE3Nzk1ZWY1NDFIZjY2Y2QiLCJwljO JIMINNYQ Search+ Create@ For you(• RecentSpaces / l Jiminny (New) / # sy-20894 / E JY-20897DescriptionEdit descriptioni# Starred•$ AppsQ SpacesSubtasks+...Add subtaskiService-Desk• Jiminny (New) + ...v Linked work itemsclones10D Platform TeamII Capture TeamW Enterprise Stability I…JY-16113 [Laravel 12] Testing of Platform DomainCLOSED VActivityW Processing TeamW SE Kanban= More spacesCommentsHistory Work log— FiltersStefka Stoyanova updated the Story Points" nour ago15 → 8|C DashboardsC÷ OperationsStefka Stoyanova updated the Days1 hour ago15 → 102 Confluence: Teams"= Customise sidebarStefka Stoyanova changed the Parent1 hour agoIY-16110 → IV-20904Stefka Stoyanova changed the Assignee1 hour aadLukas Kovalik → UnassignedStefka Stoyanova updated the Link1 hour aadNone → This work item clones JY-16113₴Stefka Stoyanova changed the Parent1 hour aqdNone → JY-16110Stefka Stoyanova created the Work item1 hour agcAsk Rovo1Backlog v* Improve Technical Story• DetailsAssianee& UnassignedAssign to meReporter& Stefka StoyanovaDevelopment• Onen with VS Code? Create branch/ Create commitComponentsPlatformSub-ProductAdd ootionsanaeQAStorv point estimateNoneStorv PointsOrganisationsNonePriority= MediumFix versionsNoneSprint100% S2Wed 13 May 19:21:30+O •aver.logms (EU]4 SF [iminny@localhost]A HS_local [jiminny@localhost]A console [PROD]lmponbotkecoroingJob.ongOAcuvity.ongA console (STAGING]Playground1d = U.team1dSo jiminny028 A9 A25 X 3 X 105 ^a.provider = 'hubspot'*rovider 1d, s.name, coUNT(* as cntid = os.stage_id594349_provider_id, s.name_id, s.name, s.team_id, s.crm_configuration_ides bps 1<-›1.n: ON bps.stage_id = s.idid = 6024nuractselltid IN (16352,20612, 18281, 7344, 16378,16309, 5036, 15223, 14535, 6293, 12098, 11607).ame LIKE '%Pulsar Group%'; # 472, 380, 15138, [EMAIL] team id = 472: # event 226147gories WHERE playbook_id = 2288;CRE 10 = 226147ues WHERE crm_field_id = 226147;ations WHERE id = 380u,id = t.owner id THEN • (owner)' ELSE •• END) AS user idaccounts saociable id1d = U.team 1da.provider = 'salesforce':ane id = 58081273;ort_results where media tyRe = 'pdf' and status = 2;ame LIKE '%Neil HoyLe%'; # 17651+e WHEPE cociablo id - 17451+Caccade 9e 7=lCommand gelERE uuid_to_bin('975c6830-7d49-4C1e-b2e9-ac80c10a738a') = uvid;WHERE id = 7842553:stages WHERE opportunity id = 7842553:CascadeTrial Owner Role SeleRetactoring User EmaActivity Stage ID Upda• Search for stage_ id updates in listeners/events6 Compile tindings and provide summaryThought for 2s6 6 tasks donestage_id Set/Update Locations on ActivityBased on codebase search, here are all locations where stage id can be set or updated on an activity:Activity Model (app/Models/Activity-php)Lines 2104-2152 - updateActivityCrmData() method:• Line 2104-2106: Sets stage_id when lead is matched and current stage_id is null•Lines 2114, 2144: Sets stage id to null when switching from lead to account/contact (clears lead stage• Lines 2122-2124: Sets stage_id when contact is matched and current stage_id is null• Lines 2150-2152: Sets stage id when account is matched and current stage id is nullLines 2589-2592 - setStageldo setter.• Direct property setter methodLine 930-932 - Event firing:• Fires StageUpdated event when stage_id is dirty during saveJOOSJobs/Activity/Imoort/MatchCrmData.oho (Line 129):Sactivity→>update( [→ $lead->id 27 null,'contact id' = Scontact→>id ?? nul.laccount idi es caccount_sid 22 null.*opportunity_id' => Sopportunity->id 27 null,'stage_id' →> sstage->id 27 null, // - Sets from CRM objectsJobs/Activity/Import/ImportCall.php (Line 212):it (ScrmResolved→>hasStageido) «ScrmData('stage_id'] = ScrmResolved-›getStageId(); // - Sets from CrmResolved DTOJobs/Crm/MatchActivitvCrmData.oho (Line 166);A ohoSactivity->update(I= null,'contact id' =› null.Ask anvthina (84L)« Code SWF-1.6UTF-8...
|
Firefox
|
[JY-20897] [Laravel 13] Testing of Platform Domain [JY-20897] [Laravel 13] Testing of Platform Domain - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20897?atlOrigin=ey jiminny.atlassian.net/browse/JY-20897?atlOrigin=eyJpIjoiOGQ1YzRiODQ0NGI2NDI5OWE3Nzk1ZWY1NDFlZjY2Y2QiLCJwIjoiamlyYS1zbGFjay1pbnQifQ...
|
37735
|
|
37736
|
New Tab
about:newtab
Usage | Windsurf
Usage | Wind New Tab
about:newtab
Usage | Windsurf
Usage | Windsurf
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
Close tab
New Tab
New Tab
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
Notifications
Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters...
|
Firefox
|
[JY-20897] [Laravel 13] Testing of Platform Domain [JY-20897] [Laravel 13] Testing of Platform Domain - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20897?atlOrigin=ey jiminny.atlassian.net/browse/JY-20897?atlOrigin=eyJpIjoiOGQ1YzRiODQ0NGI2NDI5OWE3Nzk1ZWY1NDFlZjY2Y2QiLCJwIjoiamlyYS1zbGFjay1pbnQifQ...
|
37736
|
|
37737
|
New Tab
about:newtab
Usage | Windsurf
Usage | Wind New Tab
about:newtab
Usage | Windsurf
Usage | Windsurf
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Dev Tools - Elastic
Dev Tools - Elastic
Jiminny
Jiminny
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
[JY-20897] [Laravel 13] Testing of Platform Domain - Jira
Close tab
New Tab
New Tab
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
Notifications
Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards
Create dashboard
Create dashboard
More actions for Dashboards
More actions for Dashboards
Operations
Operations
More actions for Operations
More actions for Operations
Confluence , (opens new window)
Confluence
, (opens new window)
Teams , (opens new window)
Teams
, (opens new window)
open menu
open menu
Customise sidebar
Customise sidebar
Resize side navigation panel
Spaces
Spaces
/
Jiminny (New) Jiminny (New)
Jiminny (New)
/...
|
Firefox
|
[JY-20897] [Laravel 13] Testing of Platform Domain [JY-20897] [Laravel 13] Testing of Platform Domain - Jira — Work...
|
jiminny.atlassian.net/browse/JY-20897?atlOrigin=ey jiminny.atlassian.net/browse/JY-20897?atlOrigin=eyJpIjoiOGQ1YzRiODQ0NGI2NDI5OWE3Nzk1ZWY1NDFlZjY2Y2QiLCJwIjoiamlyYS1zbGFjay1pbnQifQ...
|
37737
|
|
34613
|
Usage | Windsurf
Usage | Windsurf
[SRD-6848] Sidek Usage | Windsurf
Usage | Windsurf
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
Findings by vulnerability - Vanta
Findings by vulnerability - Vanta
NVD - cve-2026-33671
NVD - cve-2026-33671
Low vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
Low vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
jiminny/app/backend-code - Vanta
jiminny/app/backend-code - Vanta
NVD - cve-2026-6722
NVD - cve-2026-6722
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
New Tab
New Tab
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
High vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
High vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
Medium vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
Medium vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
Low vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
Low vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
Jira
Jira
Close tab
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
8 Notifications
8 Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards
Create dashboard
Create dashboard
More actions for Dashboards
More actions for Dashboards
Operations
Operations
More actions for Operations
More actions for Operations
Confluence , (opens new window)
Confluence
, (opens new window)
Teams , (opens new window)
Teams
, (opens new window)
open menu
open menu
Customise sidebar
Customise sidebar
Resize side navigation panel
Spaces
Spaces
/
Jiminny (New) Jiminny (New)
Jiminny (New)
/
Epic - Add parent
Add parent
/
Bug - Change work type
JY-20891
JY-20891
Copy link
Sidekick SMS issue- Summary, edit
Sidekick SMS issue
Sidekick SMS issue
Add or create work related to this Bug
Add or create work related to this Bug
View app actions
View app actions
Collapse Key details Key details
Collapse Key details
Collapse Key details
Key details
Description
Description
Add Description, edit
Hey team,
Scott de Zoeten from Reward Gateway-Edenred reached out to complain that he got an automated email stating that his SMS from the 10th of May was not sent to one of his prospects.
I tried investigating (via CloudWatch logs, Twilio messaging logs, Sentry, etc), but I couldn’t find any trace of his attempted reply to that prospect ([PHONE]).
To send the text message, he replied to the email he got when the prospect texted him first:
Open
And this is the email he got after replying to the email:
Open
Reportedly, the text message he tried sending was only two words long.
Mario and I performed a couple of tests, and despite receiving each reply via email, we both got the same emails as Scott, stating that the messages were not sent. Below are the failure messages and the result of our testing:
Open
Open
Open
I couldn’t help but notice that, unlike with Mario’s reply, my reply via email included my email signature by default, and this can significantly increase the size of the text message, but this shouldn’t be an issue if the SMS gets segmented when a certain threshold is reached, making it a so-called long SMS.
Can someone please check why we are always receiving these failure emails, even though the messages were sent, and of course, why Scott’s text message was not sent at all? 🙏
Steps to reproduce
Steps to reproduce
Edit Steps to reproduce, edit
Start an SMS conversation with another Jiminny user and reply to each other via email.
Actual outcome
Edit Actual outcome
With or without success the sender always receives a failure email
Expected outcome
Edit Expected outcome
The text messages to be sent via email without failures
Collapse Attachments Attachments 5 More actions for attachments Add Attachment
Collapse Attachments
Collapse Attachments
Attachments
5
More actions for attachments
More actions for attachments
Add Attachment
Add Attachment
Open image-20260513-072944.png
image-20260513-072
944.png
21 Jan 1970, 02:04 pm
image-20260513-072944.png — Download
Open image-20260513-072913.png
image-20260513-072...
|
Firefox
|
Jira — Work
|
jiminny.atlassian.net/browse/JY-20891
|
34613
|
|
34614
|
Usage | Windsurf
Usage | Windsurf
[SRD-6848] Sidek Usage | Windsurf
Usage | Windsurf
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
Findings by vulnerability - Vanta
Findings by vulnerability - Vanta
NVD - cve-2026-33671
NVD - cve-2026-33671
Low vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
Low vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
jiminny/app/backend-code - Vanta
jiminny/app/backend-code - Vanta
NVD - cve-2026-6722
NVD - cve-2026-6722
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
New Tab
New Tab
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app...
|
Firefox
|
[JY-20891] Sidekick SMS issue - Jira — Work
|
jiminny.atlassian.net/browse/JY-20891
|
34614
|
|
34615
|
Usage | Windsurf
Usage | Windsurf
[SRD-6848] Sidek Usage | Windsurf
Usage | Windsurf
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
Findings by vulnerability - Vanta
Findings by vulnerability - Vanta
NVD - cve-2026-33671
NVD - cve-2026-33671
Low vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
Low vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
jiminny/app/backend-code - Vanta
jiminny/app/backend-code - Vanta
NVD - cve-2026-6722
NVD - cve-2026-6722
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
New Tab
New Tab
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated...
|
Firefox
|
[JY-20891] Sidekick SMS issue - Jira — Work
|
jiminny.atlassian.net/browse/JY-20891
|
34615
|
|
34616
|
Usage | Windsurf
Usage | Windsurf
[SRD-6848] Sidek Usage | Windsurf
Usage | Windsurf
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
Findings by vulnerability - Vanta
Findings by vulnerability - Vanta
NVD - cve-2026-33671
NVD - cve-2026-33671
Low vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
Low vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
jiminny/app/backend-code - Vanta
jiminny/app/backend-code - Vanta
NVD - cve-2026-6722
NVD - cve-2026-6722
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
New Tab
New Tab
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
High vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
High vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
Medium vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
Medium vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
Low vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
Low vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
Close tab
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
8 Notifications
8 Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards
Create dashboard
Create dashboard
More actions for Dashboards
More actions for Dashboards
Operations
Operations
More actions for Operations
More actions for Operations...
|
Firefox
|
[JY-20891] Sidekick SMS issue - Jira — Work
|
jiminny.atlassian.net/browse/JY-20891
|
34616
|
|
34617
|
Usage | Windsurf
Usage | Windsurf
[SRD-6848] Sidek Usage | Windsurf
Usage | Windsurf
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
Findings by vulnerability - Vanta
Findings by vulnerability - Vanta
NVD - cve-2026-33671
NVD - cve-2026-33671
Low vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
Low vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
jiminny/app/backend-code - Vanta
jiminny/app/backend-code - Vanta
NVD - cve-2026-6722
NVD - cve-2026-6722
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
New Tab
New Tab
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
High vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
High vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
Medium vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
Medium vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
Low vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
Low vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
Close tab
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
8 Notifications
8 Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)...
|
Firefox
|
[JY-20891] Sidekick SMS issue - Jira — Work
|
jiminny.atlassian.net/browse/JY-20891
|
34617
|
|
34618
|
Usage | Windsurf
Usage | Windsurf
[SRD-6848] Sidek Usage | Windsurf
Usage | Windsurf
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Dependabot alerts · jiminny/prophet
Dependabot alerts · jiminny/prophet
[JY-19958] Upgrade BE libraries - May - Jira
[JY-19958] Upgrade BE libraries - May - Jira
Findings by vulnerability - Vanta
Findings by vulnerability - Vanta
NVD - cve-2026-33671
NVD - cve-2026-33671
Low vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
Low vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
jiminny/app/backend-code - Vanta
jiminny/app/backend-code - Vanta
NVD - cve-2026-6722
NVD - cve-2026-6722
[JY-20773] User Pilot not receiving events on report generated - Jira
[JY-20773] User Pilot not receiving events on report generated - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
TypeError: League\Flysystem\Filesystem::has(): Argument #1 ($location) must be of type string, null given, called in /home/jiminny/vendor/laravel/framework/src/Illuminate/Filesystem/FilesystemAdapter.php on line 218 — jiminny — app
New Tab
New Tab
Userpilot | Ask Jiminny Report Generated
Userpilot | Ask Jiminny Report Generated
[JY-19957] Upgrade BE libraries - Apr - Jira
[JY-19957] Upgrade BE libraries - Apr - Jira
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
JY-19957 | Remove abanded sympfony debug, compose upgrade by nikolaybiaivanov · Pull Request #12022 · jiminny/app
High vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
High vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
Medium vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
Medium vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
Low vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
Low vulnerabilities identified in packages are addressed (GitHub Repo) - Vanta
Dependabot alerts · jiminny/app
Dependabot alerts · jiminny/app
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
Close tab
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Sidebar
Sidebar
Top Bar
Top Bar
Main Content
Main Content
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
8 Notifications
8 Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Jiminny (New)
Jiminny (New)
Jiminny (New)...
|
Firefox
|
[JY-20891] Sidekick SMS issue - Jira — Work
|
jiminny.atlassian.net/browse/JY-20891
|
34618
|