|
72391
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
New Tab
New Tab
Login - SonarQube Cloud
Login - SonarQube Cloud
What's New in Firefox 151 — Firefox.com
What's New in Firefox 151 — Firefox.com
New Tab
New Tab
[JY-20814] Release unused Twilio numbers on Production - Jira
[JY-20814] Release unused Twilio numbers on Production - Jira
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS]
Show options
LakyLak commented 1 hour ago
LakyLak
LakyLak
commented
1 hour ago
1 hour ago
JIRA: JY-20891
JIRA:
JY-20891
JY-20891
Changes:
Changes:
change environment check
add logs
Add or remove reactions
@LakyLak
JY-20891
JY-20891
fix alias mismatch in text relay service
fix alias mismatch in text relay service
12 / 12 checks OK
a722028
a722028
@sonarqubecloud
Show options
sonarqubecloud Bot commented 45 minutes ago
sonarqubecloud
sonarqubecloud
Bot
commented
45 minutes ago
45 minutes ago
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
85.4% Coverage on New Code
85.4% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud
Add or remove reactions
@LakyLak
Show options
Author
LakyLak commented 45 minutes ago
LakyLak
LakyLak
commented
45 minutes ago
45 minutes ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@github-actions
Show options
github-actions Bot commented 44 minutes ago •
github-actions
github-actions
Bot
commented
44 minutes ago
44 minutes ago
•
edited
edited
Claude finished
@LakyLak
@LakyLak
's task in 2m 46s
——
View job
View job
📋
Jira:
JY-20891 — Sidekick SMS issue
JY-20891 — Sidekick SMS issue
Status:
Deployed
| Requirements were found in the Jira ticket and are included below.
🤖
Model:
claude-opus-4-7
Jira Ticket Requirements Coverage
Jira Ticket Requirements Coverage
Requirement
Status
Notes
Find why valid SMS replies (e.g. Scott's reply to
[PHONE]
) were silently dropped and never reached Twilio
✅ Implemented
Root cause is the strict equality on
X-Gm-Original-To
. Inbound emails arrive with a Gmail-style plus tag (e.g.
[EMAIL]
) which never equals the expected
[EMAIL]
, so the message is silently refused. The new
matchesExpectedRecipient
strips the
+...
suffix before comparing.
Explain why senders always receive the "failure" email even when the message was actually sent
⚠️
Partial
The PR doesn't change the failure-email path itself. The implicit hypothesis is: the same alias mismatch caused
isForCurrentEnvironment
to refuse the relay, hence no Twilio send, hence the failure email. The PR should fix that root cause, but the failure-email producer (likely in
EmailTextRelay
job / Twilio webhook path) is not touched here — worth confirming nothing else can still produce a false failure email after the fix lands.
Investigate trace gap (no CloudWatch / Twilio / Sentry record of the attempted send)
✅ Implemented
The added
Log::info/warning/error
calls in
sync
,
getHistory
, and
isForCurrentEnvironment
close that gap going forward — refused messages, missing headers, and Gmail API errors are now logged with the
message_id
.
Verify segmentation / long-SMS suspicion (email signature blowing up message size)
❌ Out of scope
This PR doesn't touch SMS segmentation. Once the alias fix is in prod, you'll be able to see in logs whether messages were refused vs. actually sent to Twilio; that should rule signature/length in or out.
Requirement
Find why valid SMS replies (e.g. Scott's reply to
[PHONE]
) were silently dropped and never reached Twilio
Explain why senders always receive the "failure" email even when the message was actually sent
Investigate trace gap (no CloudWatch / Twilio / Sentry record of the attempted send)
Verify segmentation / long-SMS suspicion (email signature blowing up message size)
Status
✅ Implemented
⚠️
Partial
✅ Implemented
❌ Out of scope
Notes
Root cause is the strict equality on
X-Gm-Original-To
. Inbound emails arrive with a Gmail-style plus tag (e.g.
[EMAIL]
) which never equals the expected
[EMAIL]
, so the message is silently refused. The new
matchesExpectedRecipient
strips the
+...
suffix before comparing.
The PR doesn't change the failure-email path itself. The implicit hypothesis is: the same alias mismatch caused
isForCurrentEnvironment
to refuse the relay, hence no Twilio send, hence the failure email. The PR should fix that root cause, but the failure-email producer (likely in
EmailTextRelay
job / Twilio webhook path) is not touched here — worth confirming nothing else can still produce a false failure email after the fix lands.
The added
Log::info/warning/error
calls in
sync
,
getHistory
, and
isForCurrentEnvironment
close that gap going forward — refused messages, missing headers, and Gmail API errors are now logged with the
message_id
.
This PR doesn't touch SMS segmentation. Once the alias fix is in prod, you'll be able to see in logs whether messages were refused vs. actually sent to Twilio; that should rule signature/length in or out.
Code Review
Code Review
✅ Core fix is correct
✅ Core fix is correct
app/Services/Mail/TextRelayService.php:211-222
—
matchesExpectedRecipient
correctly:
Splits the host with a 2-arg
explode
(safe against
a@b@c
weirdness)
Compares the host case-insensitively
Strips the
+...
plus-tag from the local part before comparing the alias
This squarely addresses the reported failure (plus-tagged recipients silently refused).
🟡 Issues / suggestions
🟡 Issues / suggestions
testSyncWithRefusedMessageLogs
is a verbatim copy of
testSyncWithEnhancedLogging
—
tests/Unit/Services/Mail/TextRelayServiceTest.php:336-420
. Both set EU region, mock
getHistory
to return
[]
, and expect the same start/completed
Log::info
calls. Neither actually exercises a refused message. Either delete the duplicate or make it return a history containing a non-matching
X-Gm-Original-To
and assert the
Refused message
log.
Fix this →
Fix this →
Log::info('[TextRelayService] Refused message', ...)
fires for every refused message
(
TextRelayService.php:187-191
). If inbound mail for EU and US share the same inbox (which seems to be the design — each env filters by alias), this will produce one info log per cross-region message every sync. Suggest dropping it to
debug
, or rate-limiting it after the immediate investigation, otherwise the diagnostic value drowns in noise quickly.
Log::info('[TextRelayService] Starting sync', ...)
fires after
getService()
and
getHistory()
(
TextRelayService.php:33-41
). If either throws (e.g. credentials missing, Gmail history call fails before the
try
), the "Starting sync" log never appears — exactly when you'd want it. Move it to the very top of
sync()
, right after computing the alias/host....
|
Firefox
|
JY-20891 fix alias mismatch in text relay service JY-20891 fix alias mismatch in text relay service by LakyLak · Pull Request #12128 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12128
|
72391
|
|
72392
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
New Tab
New Tab
Login - SonarQube Cloud
Login - SonarQube Cloud
What's New in Firefox 151 — Firefox.com
What's New in Firefox 151 — Firefox.com
New Tab
New Tab
[JY-20814] Release unused Twilio numbers on Production - Jira
[JY-20814] Release unused Twilio numbers on Production - Jira
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS]
Show options
LakyLak commented 1 hour ago
LakyLak
LakyLak
commented
1 hour ago
1 hour ago
JIRA: JY-20891
JIRA:
JY-20891
JY-20891
Changes:
Changes:
change environment check
add logs
Add or remove reactions
@LakyLak
JY-20891
JY-20891
fix alias mismatch in text relay service
fix alias mismatch in text relay service
12 / 12 checks OK
a722028
a722028
@sonarqubecloud
Show options
sonarqubecloud Bot commented 45 minutes ago
sonarqubecloud
sonarqubecloud
Bot
commented
45 minutes ago
45 minutes ago
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
85.4% Coverage on New Code
85.4% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud
Add or remove reactions
@LakyLak
Show options
Author
LakyLak commented 45 minutes ago
LakyLak
LakyLak
commented
45 minutes ago
45 minutes ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@github-actions
Show options
github-actions Bot commented 44 minutes ago •
github-actions
github-actions
Bot
commented
44 minutes ago
44 minutes ago
•
edited
edited
Claude finished
@LakyLak
@LakyLak
's task in 2m 46s
——
View job
View job
📋
Jira:
JY-20891 — Sidekick SMS issue
JY-20891 — Sidekick SMS issue
Status:
Deployed
| Requirements were found in the Jira ticket and are included below.
🤖
Model:
claude-opus-4-7
Jira Ticket Requirements Coverage
Jira Ticket Requirements Coverage
Requirement
Status
Notes
Find why valid SMS replies (e.g. Scott's reply to
[PHONE]
) were silently dropped and never reached Twilio
✅ Implemented
Root cause is the strict equality on
X-Gm-Original-To
. Inbound emails arrive with a Gmail-style plus tag (e.g.
[EMAIL]
) which never equals the expected
[EMAIL]
, so the message is silently refused. The new
matchesExpectedRecipient
strips the
+...
suffix before comparing.
Explain why senders always receive the "failure" email even when the message was actually sent
⚠️
Partial
The PR doesn't change the failure-email path itself. The implicit hypothesis is: the same alias mismatch caused
isForCurrentEnvironment
to refuse the relay, hence no Twilio send, hence the failure email. The PR should fix that root cause, but the failure-email producer (likely in
EmailTextRelay
job / Twilio webhook path) is not touched here — worth confirming nothing else can still produce a false failure email after the fix lands.
Investigate trace gap (no CloudWatch / Twilio / Sentry record of the attempted send)
✅ Implemented
The added
Log::info/warning/error
calls in
sync
,
getHistory
, and
isForCurrentEnvironment
close that gap going forward — refused messages, missing headers, and Gmail API errors are now logged with the
message_id
.
Verify segmentation / long-SMS suspicion (email signature blowing up message size)
❌ Out of scope
This PR doesn't touch SMS segmentation. Once the alias fix is in prod, you'll be able to see in logs whether messages were refused vs. actually sent to Twilio; that should rule signature/length in or out.
Requirement
Find why valid SMS replies (e.g. Scott's reply to
[PHONE]
) were silently dropped and never reached Twilio
Explain why senders always receive the "failure" email even when the message was actually sent
Investigate trace gap (no CloudWatch / Twilio / Sentry record of the attempted send)
Verify segmentation / long-SMS suspicion (email signature blowing up message size)
Status
✅ Implemented
⚠️
Partial
✅ Implemented
❌ Out of scope
Notes
Root cause is the strict equality on
X-Gm-Original-To
. Inbound emails arrive with a Gmail-style plus tag (e.g.
[EMAIL]
) which never equals the expected
[EMAIL]
, so the message is silently refused. The new
matchesExpectedRecipient
strips the
+...
suffix before comparing.
The PR doesn't change the failure-email path itself. The implicit hypothesis is: the same alias mismatch caused
isForCurrentEnvironment
to refuse the relay, hence no Twilio send, hence the failure email. The PR should fix that root cause, but the failure-email producer (likely in
EmailTextRelay
job / Twilio webhook path) is not touched here — worth confirming nothing else can still produce a false failure email after the fix lands.
The added
Log::info/warning/error
calls in
sync
,
getHistory
, and
isForCurrentEnvironment
close that gap going forward — refused messages, missing headers, and Gmail API errors are now logged with the
message_id
.
This PR doesn't touch SMS segmentation. Once the alias fix is in prod, you'll be able to see in logs whether messages were refused vs. actually sent to Twilio; that should rule signature/length in or out.
Code Review
Code Review
✅ Core fix is correct
✅ Core fix is correct
app/Services/Mail/TextRelayService.php:211-222
—
matchesExpectedRecipient
correctly:
Splits the host with a 2-arg
explode
(safe against
a@b@c
weirdness)
Compares the host case-insensitively
Strips the
+...
plus-tag from the local part before comparing the alias
This squarely addresses the reported failure (plus-tagged recipients silently refused).
🟡 Issues / suggestions
🟡 Issues / suggestions
testSyncWithRefusedMessageLogs
is a verbatim copy of
testSyncWithEnhancedLogging
—
tests/Unit/Services/Mail/TextRelayServiceTest.php:336-420
. Both set EU region, mock
getHistory
to return
[]
, and expect the same start/completed
Log::info
calls. Neither actually exercises a refused message. Either delete the duplicate or make it return a history containing a non-matching
X-Gm-Original-To
and assert the
Refused message
log.
Fix this →
Fix this →
Log::info('[TextRelayService] Refused message', ...)
fires for every refused message
(
TextRelayService.php:187-191
). If inbound mail for EU and US share the same inbox (which seems to be the design — each env filters by alias), this will produce one info log per cross-region message every sync. Suggest dropping it to
debug
, or rate-limiting it after the immediate investigation, otherwise the diagnostic value drowns in noise quickly.
Log::info('[TextRelayService] Starting sync', ...)
fires after
getService()
and
getHistory()
(
TextRelayService.php:33-41
). If either throws (e.g. credentials missing, Gmail history call fails before the
try
), the "Starting sync" log never appears — exactly when you'd want it. Move it to the very top of
sync()
, right after computing the alias/host.
"Sync completed" log includes the full
message_ids
array
(
TextRelayService.php:77-81
). On busy syncs this can be a large payload.
messages_processed
is usually enough; keep
message_ids
only at
debug
, or cap the list.
'original_to' => $header->value
in the refused-message log
(
TextRelayService.php:189
) embeds the plus-tag, which encodes a phone number and Twilio routing hash. That's borderline PII. If this log is shipped to a third-party sink (e.g. Datadog) verify your data-classification policy allows it.
Test comments violate CLAUDE.md
("Do not add comments unless it's a weird quirk").
TextRelayServiceTest.php:343,346,349,366,386,389,392,409
— all 8
//
comments are restating obvious code (
// Mock getHistory to return empty array
,
// Mock Sentry to prevent actual error reporting
, etc.). Please strip them.
\Sentry::shouldReceive('captureException')->zeroOrMoreTimes()
in
testSyncWithEnhancedLogging
/
testSyncWithRefusedMessageLogs
violates CLAUDE.md "Do not use
$this->any()
, always use the exact number of times". Since neither test exercises an error path, this should be
->never()
(or just omit and rely on Mockery's default strict-ness)....
|
Firefox
|
JY-20891 fix alias mismatch in text relay service JY-20891 fix alias mismatch in text relay service by LakyLak · Pull Request #12128 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12128
|
72392
|
|
72393
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
New Tab
New Tab
Login - SonarQube Cloud
Login - SonarQube Cloud
What's New in Firefox 151 — Firefox.com
What's New in Firefox 151 — Firefox.com
New Tab
New Tab
[JY-20814] Release unused Twilio numbers on Production - Jira
[JY-20814] Release unused Twilio numbers on Production - Jira
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS]
Show options
LakyLak commented 1 hour ago
LakyLak
LakyLak
commented
1 hour ago
1 hour ago
JIRA: JY-20891
JIRA:
JY-20891
JY-20891
Changes:
Changes:
change environment check
add logs
Add or remove reactions
@LakyLak
JY-20891
JY-20891
fix alias mismatch in text relay service
fix alias mismatch in text relay service
12 / 12 checks OK
a722028
a722028
@sonarqubecloud
Show options
sonarqubecloud Bot commented 45 minutes ago
sonarqubecloud
sonarqubecloud
Bot
commented
45 minutes ago
45 minutes ago
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
85.4% Coverage on New Code
85.4% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud
Add or remove reactions
@LakyLak
Show options
Author
LakyLak commented 45 minutes ago
LakyLak
LakyLak
commented
45 minutes ago
45 minutes ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@github-actions
Show options
github-actions Bot commented 44 minutes ago •
github-actions
github-actions
Bot
commented
44 minutes ago
44 minutes ago
•
edited
edited
Claude finished
@LakyLak
@LakyLak
's task in 2m 46s
——
View job
View job
📋
Jira:
JY-20891 — Sidekick SMS issue
JY-20891 — Sidekick SMS issue
Status:
Deployed
| Requirements were found in the Jira ticket and are included below.
🤖
Model:
claude-opus-4-7
Jira Ticket Requirements Coverage
Jira Ticket Requirements Coverage
Requirement
Status
Notes
Find why valid SMS replies (e.g. Scott's reply to
[PHONE]
) were silently dropped and never reached Twilio
✅ Implemented
Root cause is the strict equality on
X-Gm-Original-To
. Inbound emails arrive with a Gmail-style plus tag (e.g.
[EMAIL]
) which never equals the expected
[EMAIL]
, so the message is silently refused. The new
matchesExpectedRecipient
strips the
+...
suffix before comparing.
Explain why senders always receive the "failure" email even when the message was actually sent
⚠️
Partial
The PR doesn't change the failure-email path itself. The implicit hypothesis is: the same alias mismatch caused
isForCurrentEnvironment
to refuse the relay, hence no Twilio send, hence the failure email. The PR should fix that root cause, but the failure-email producer (likely in
EmailTextRelay
job / Twilio webhook path) is not touched here — worth confirming nothing else can still produce a false failure email after the fix lands.
Investigate trace gap (no CloudWatch / Twilio / Sentry record of the attempted send)
✅ Implemented
The added
Log::info/warning/error
calls in
sync
,
getHistory
, and
isForCurrentEnvironment
close that gap going forward — refused messages, missing headers, and Gmail API errors are now logged with the
message_id
.
Verify segmentation / long-SMS suspicion (email signature blowing up message size)
❌ Out of scope
This PR doesn't touch SMS segmentation. Once the alias fix is in prod, you'll be able to see in logs whether messages were refused vs. actually sent to Twilio; that should rule signature/length in or out.
Requirement
Find why valid SMS replies (e.g. Scott's reply to
[PHONE]
) were silently dropped and never reached Twilio
Explain why senders always receive the "failure" email even when the message was actually sent
Investigate trace gap (no CloudWatch / Twilio / Sentry record of the attempted send)
Verify segmentation / long-SMS suspicion (email signature blowing up message size)
Status
✅ Implemented
⚠️
Partial
✅ Implemented
❌ Out of scope
Notes
Root cause is the strict equality on
X-Gm-Original-To
. Inbound emails arrive with a Gmail-style plus tag (e.g.
[EMAIL]
) which never equals the expected
[EMAIL]
, so the message is silently refused. The new
matchesExpectedRecipient
strips the
+...
suffix before comparing.
The PR doesn't change the failure-email path itself. The implicit hypothesis is: the same alias mismatch caused
isForCurrentEnvironment
to refuse the relay, hence no Twilio send, hence the failure email. The PR should fix that root cause, but the failure-email producer (likely in
EmailTextRelay
job / Twilio webhook path) is not touched here — worth confirming nothing else can still produce a false failure email after the fix lands.
The added
Log::info/warning/error
calls in
sync
,
getHistory
, and
isForCurrentEnvironment
close that gap going forward — refused messages, missing headers, and Gmail API errors are now logged with the
message_id
.
This PR doesn't touch SMS segmentation. Once the alias fix is in prod, you'll be able to see in logs whether messages were refused vs. actually sent to Twilio; that should rule signature/length in or out.
Code Review
Code Review
✅ Core fix is correct
✅ Core fix is correct
app/Services/Mail/TextRelayService.php:211-222
—
matchesExpectedRecipient
correctly:
Splits the host with a 2-arg
explode
(safe against
a@b@c
weirdness)
Compares the host case-insensitively
Strips the
+...
plus-tag from the local part before comparing the alias
This squarely addresses the reported failure (plus-tagged recipients silently refused).
🟡 Issues / suggestions
🟡 Issues / suggestions
testSyncWithRefusedMessageLogs
is a verbatim copy of
testSyncWithEnhancedLogging
—
tests/Unit/Services/Mail/TextRelayServiceTest.php:336-420
. Both set EU region, mock
getHistory
to return
[]
, and expect the same start/completed
Log::info
calls. Neither actually exercises a refused message. Either delete the duplicate or make it return a history containing a non-matching
X-Gm-Original-To
and assert the
Refused message
log.
Fix this →
Fix this →
Log::info('[TextRelayService] Refused message', ...)
fires for every refused message
(
TextRelayService.php:187-191
). If inbound mail for EU and US share the same inbox (which seems to be the design — each env filters by alias), this will produce one info log per cross-region message every sync. Suggest dropping it to
debug
, or rate-limiting it after the immediate investigation, otherwise the diagnostic value drowns in noise quickly.
Log::info('[TextRelayService] Starting sync', ...)
fires after
getService()
and
getHistory()
(
TextRelayService.php:33-41
). If either throws (e.g. credentials missing, Gmail history call fails before the
try
), the "Starting sync" log never appears — exactly when you'd want it. Move it to the very top of
sync()
, right after computing the alias/host.
"Sync completed" log includes the full
message_ids
array
(
TextRelayService.php:77-81
). On busy syncs this can be a large payload.
messages_processed
is usually enough; keep
message_ids
only at
debug
, or cap the list.
'original_to' => $header->value
in the refused-message log
(
TextRelayService.php:189
) embeds the plus-tag, which encodes a phone number and Twilio routing hash. That's borderline PII. If this log is shipped to a third-party sink (e.g. Datadog) verify your data-classification policy allows it.
Test comments violate CLAUDE.md
("Do not add comments unless it's a weird quirk").
TextRelayServiceTest.php:343,346,349,366,386,389,392,409
— all 8
//
comments are restating obvious code (
// Mock getHistory to return empty array
,
// Mock Sentry to prevent actual error reporting
, etc.). Please strip them.
\Sentry::shouldReceive('captureException')->zeroOrMoreTimes()
in
testSyncWithEnhancedLogging
/
testSyncWithRefusedMessageLogs
violates CLAUDE.md "Do not use
$this->any()
, always use the exact number of times". Since neither test exercises an error path, this should be
->never()
(or just omit and rely on Mockery's default strict-ness).
testSyncWithEnhancedLogging...
|
Firefox
|
JY-20891 fix alias mismatch in text relay service JY-20891 fix alias mismatch in text relay service by LakyLak · Pull Request #12128 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12128
|
72393
|
|
72401
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
New Tab
New Tab
Login - SonarQube Cloud
Login - SonarQube Cloud
What's New in Firefox 151 — Firefox.com
What's New in Firefox 151 — Firefox.com
New Tab
New Tab
[JY-20814] Release unused Twilio numbers on Production - Jira
[JY-20814] Release unused Twilio numbers on Production - Jira
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS]
Show options
LakyLak commented 1 hour ago
LakyLak
LakyLak
commented
1 hour ago
1 hour ago
JIRA: JY-20891
JIRA:
JY-20891
JY-20891
Changes:
Changes:
change environment check
add logs
Add or remove reactions
@LakyLak
JY-20891
JY-20891
fix alias mismatch in text relay service
fix alias mismatch in text relay service
12 / 12 checks OK
a722028
a722028
@sonarqubecloud
Show options
sonarqubecloud Bot commented 46 minutes ago
sonarqubecloud
sonarqubecloud
Bot
commented
46 minutes ago
46 minutes ago
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
85.4% Coverage on New Code
85.4% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud
Add or remove reactions
@LakyLak
Show options
Author
LakyLak commented 46 minutes ago
LakyLak
LakyLak
commented
46 minutes ago
46 minutes ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@github-actions
Show options
github-actions Bot commented 45 minutes ago •
github-actions
github-actions
Bot
commented
45 minutes ago
45 minutes ago
•
edited
edited
Claude finished
@LakyLak
@LakyLak
's task in 2m 46s
——
View job
View job
📋
Jira:
JY-20891 — Sidekick SMS issue
JY-20891 — Sidekick SMS issue
Status:
Deployed
| Requirements were found in the Jira ticket and are included below.
🤖
Model:
claude-opus-4-7
Jira Ticket Requirements Coverage
Jira Ticket Requirements Coverage
Requirement
Status
Notes
Find why valid SMS replies (e.g. Scott's reply to
[PHONE]
) were silently dropped and never reached Twilio
✅ Implemented
Root cause is the strict equality on
X-Gm-Original-To
. Inbound emails arrive with a Gmail-style plus tag (e.g.
[EMAIL]
) which never equals the expected
[EMAIL]
, so the message is silently refused. The new
matchesExpectedRecipient
strips the
+...
suffix before comparing.
Explain why senders always receive the "failure" email even when the message was actually sent
⚠️
Partial
The PR doesn't change the failure-email path itself. The implicit hypothesis is: the same alias mismatch caused
isForCurrentEnvironment
to refuse the relay, hence no Twilio send, hence the failure email. The PR should fix that root cause, but the failure-email producer (likely in
EmailTextRelay
job / Twilio webhook path) is not touched here — worth confirming nothing else can still produce a false failure email after the fix lands.
Investigate trace gap (no CloudWatch / Twilio / Sentry record of the attempted send)
✅ Implemented
The added
Log::info/warning/error
calls in
sync
,
getHistory
, and
isForCurrentEnvironment
close that gap going forward — refused messages, missing headers, and Gmail API errors are now logged with the
message_id
.
Verify segmentation / long-SMS suspicion (email signature blowing up message size)
❌ Out of scope
This PR doesn't touch SMS segmentation. Once the alias fix is in prod, you'll be able to see in logs whether messages were refused vs. actually sent to Twilio; that should rule signature/length in or out.
Requirement
Find why valid SMS replies (e.g. Scott's reply to
[PHONE]
) were silently dropped and never reached Twilio
Explain why senders always receive the "failure" email even when the message was actually sent
Investigate trace gap (no CloudWatch / Twilio / Sentry record of the attempted send)
Verify segmentation / long-SMS suspicion (email signature blowing up message size)
Status
✅ Implemented
⚠️
Partial
✅ Implemented
❌ Out of scope
Notes
Root cause is the strict equality on
X-Gm-Original-To
. Inbound emails arrive with a Gmail-style plus tag (e.g.
[EMAIL]
) which never equals the expected
[EMAIL]
, so the message is silently refused. The new
matchesExpectedRecipient
strips the
+...
suffix before comparing.
The PR doesn't change the failure-email path itself. The implicit hypothesis is: the same alias mismatch caused
isForCurrentEnvironment
to refuse the relay, hence no Twilio send, hence the failure email. The PR should fix that root cause, but the failure-email producer (likely in
EmailTextRelay
job / Twilio webhook path) is not touched here — worth confirming nothing else can still produce a false failure email after the fix lands.
The added
Log::info/warning/error
calls in
sync
,
getHistory
, and
isForCurrentEnvironment
close that gap going forward — refused messages, missing headers, and Gmail API errors are now logged with the
message_id
.
This PR doesn't touch SMS segmentation. Once the alias fix is in prod, you'll be able to see in logs whether messages were refused vs. actually sent to Twilio; that should rule signature/length in or out.
Code Review
Code Review
✅ Core fix is correct
✅ Core fix is correct
app/Services/Mail/TextRelayService.php:211-222
—
matchesExpectedRecipient
correctly:
Splits the host with a 2-arg
explode
(safe against
a@b@c
weirdness)
Compares the host case-insensitively
Strips the
+...
plus-tag from the local part before comparing the alias
This squarely addresses the reported failure (plus-tagged recipients silently refused).
🟡 Issues / suggestions
🟡 Issues / suggestions
testSyncWithRefusedMessageLogs
is a verbatim copy of
testSyncWithEnhancedLogging
—
tests/Unit/Services/Mail/TextRelayServiceTest.php:336-420
. Both set EU region, mock
getHistory
to return
[]
, and expect the same start/completed
Log::info
calls. Neither actually exercises a refused message. Either delete the duplicate or make it return a history containing a non-matching
X-Gm-Original-To
and assert the
Refused message
log.
Fix this →
Fix this →
Log::info('[TextRelayService] Refused message', ...)
fires for every refused message
(
TextRelayService.php:187-191
). If inbound mail for EU and US share the same inbox (which seems to be the design — each env filters by alias), this will produce one info log per cross-region message every sync. Suggest dropping it to
debug
, or rate-limiting it after the immediate investigation, otherwise the diagnostic value drowns in noise quickly.
Log::info('[TextRelayService] Starting sync', ...)
fires after
getService()
and
getHistory()
(
TextRelayService.php:33-41
). If either throws (e.g. credentials missing, Gmail history call fails before the
try
), the "Starting sync" log never appears — exactly when you'd want it. Move it to the very top of
sync()
, right after computing the alias/host.
"Sync completed" log includes the full
message_ids
array
(
TextRelayService.php:77-81
). On busy syncs this can be a large payload.
messages_processed
is usually enough; keep
message_ids
only at
debug
, or cap the list.
'original_to' => $header->value
in the refused-message log
(
TextRelayService.php:189
) embeds the plus-tag, which encodes a phone number and Twilio routing hash. That's borderline PII. If this log is shipped to a third-party sink (e.g. Datadog) verify your data-classification policy allows it.
Test comments violate CLAUDE.md
("Do not add comments unless it's a weird quirk").
TextRelayServiceTest.php:343,346,349,366,386,389,392,409
— all 8
//
comments are restating obvious code (
// Mock getHistory to return empty array
,
// Mock Sentry to prevent actual error reporting
, etc.). Please strip them.
\Sentry::shouldReceive('captureException')->zeroOrMoreTimes()
in
testSyncWithEnhancedLogging
/
testSyncWithRefusedMessageLogs
violates CLAUDE.md "Do not use
$this->any()
, always use the exact number of times". Since neither test exercises an error path, this should be
->never()
(or just omit and rely on Mockery's default strict-ness).
testSyncWithEnhancedLogging
doesn't really assert anything new
beyond "two log lines fire on an empty sync." Consider replacing it (rather than duplicating) with a test that walks a non-empty history end-to-end (
getHistory
→ matching
X-Gm-Original-To
→ dispatched job → "Successfully dispatched message" log). That's where the real regression risk is, and it's currently uncovered.
Minor — log message wording
:
'[TextRelayService] Refused message: missing X-Gm-Original-To header'
(
TextRelayService.php:197
) uses
warning
while a plain mismatch uses
info
. The missing-header case is arguably less serious than mismatch (legitimate Gmail messages always have the header — its absence likely indicates malformed/spam mail, not a config bug). Swapping or aligning the levels would help triage.
🟢 Nice things
🟢 Nice things
Case-insensitive host/alias comparison via
strcasecmp
— good defensive choice.
The new test
testIsForCurrentEnvironmentRejectsWrongHostWithMatchingPlusTag
covers the cross-env confusion case (correct alias, wrong host) which is exactly the kind of edge you want pinned down.
Datasets for the matching/non-matching providers were extended with plus-tag variants — good regression coverage.
Sentry is still being notified on exceptions; only adding logs, not replacing existing observability.
Verdict
Verdict...
|
Firefox
|
JY-20891 fix alias mismatch in text relay service JY-20891 fix alias mismatch in text relay service by LakyLak · Pull Request #12128 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12128
|
72401
|
|
72402
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
New Tab
New Tab
Login - SonarQube Cloud
Login - SonarQube Cloud
What's New in Firefox 151 — Firefox.com
What's New in Firefox 151 — Firefox.com
New Tab
New Tab
[JY-20814] Release unused Twilio numbers on Production - Jira
[JY-20814] Release unused Twilio numbers on Production - Jira
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS]
Show options
LakyLak commented 1 hour ago
LakyLak
LakyLak
commented
1 hour ago
1 hour ago
JIRA: JY-20891
JIRA:
JY-20891
JY-20891
Changes:
Changes:
change environment check
add logs
Add or remove reactions
@LakyLak
JY-20891
JY-20891
fix alias mismatch in text relay service
fix alias mismatch in text relay service
12 / 12 checks OK
a722028
a722028
@sonarqubecloud
Show options
sonarqubecloud Bot commented 46 minutes ago
sonarqubecloud
sonarqubecloud
Bot
commented
46 minutes ago
46 minutes ago
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
85.4% Coverage on New Code
85.4% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud
Add or remove reactions
@LakyLak
Show options
Author
LakyLak commented 46 minutes ago
LakyLak
LakyLak
commented
46 minutes ago
46 minutes ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@github-actions
Show options
github-actions Bot commented 45 minutes ago •
github-actions
github-actions
Bot
commented
45 minutes ago
45 minutes ago
•
edited
edited
Claude finished
@LakyLak
@LakyLak
's task in 2m 46s...
|
Firefox
|
JY-20891 fix alias mismatch in text relay service JY-20891 fix alias mismatch in text relay service by LakyLak · Pull Request #12128 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12128
|
72402
|
|
72403
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
New Tab
New Tab
Login - SonarQube Cloud
Login - SonarQube Cloud
What's New in Firefox 151 — Firefox.com
What's New in Firefox 151 — Firefox.com
New Tab
New Tab
[JY-20814] Release unused Twilio numbers on Production - Jira
[JY-20814] Release unused Twilio numbers on Production - Jira
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS]
Show options
LakyLak commented 1 hour ago
LakyLak
LakyLak
commented
1 hour ago
1 hour ago
JIRA: JY-20891
JIRA:
JY-20891
JY-20891
Changes:
Changes:
change environment check
add logs
Add or remove reactions
@LakyLak
JY-20891
JY-20891
fix alias mismatch in text relay service
fix alias mismatch in text relay service
12 / 12 checks OK
a722028
a722028
@sonarqubecloud
Show options
sonarqubecloud Bot commented 46 minutes ago
sonarqubecloud
sonarqubecloud
Bot
commented
46 minutes ago
46 minutes ago
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
85.4% Coverage on New Code
85.4% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud
Add or remove reactions
@LakyLak
Show options
Author
LakyLak commented 46 minutes ago
LakyLak
LakyLak
commented
46 minutes ago
46 minutes ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@github-actions
Show options
github-actions Bot commented 45 minutes ago •
github-actions
github-actions
Bot
commented
45 minutes ago
45 minutes ago
•
edited
edited
Claude finished
@LakyLak
@LakyLak
's task in 2m 46s
——
View job
View job
📋
Jira:
JY-20891 — Sidekick SMS issue
JY-20891 — Sidekick SMS issue
Status:
Deployed
| Requirements were found in the Jira ticket and are included below.
🤖
Model:
claude-opus-4-7
Jira Ticket Requirements Coverage
Jira Ticket Requirements Coverage
Requirement
Status
Notes
Find why valid SMS replies (e.g. Scott's reply to
[PHONE]
) were silently dropped and never reached Twilio
✅ Implemented
Root cause is the strict equality on
X-Gm-Original-To
. Inbound emails arrive with a Gmail-style plus tag (e.g.
[EMAIL]
) which never equals the expected
[EMAIL]
, so the message is silently refused. The new
matchesExpectedRecipient
strips the
+...
suffix before comparing.
Explain why senders always receive the "failure" email even when the message was actually sent
⚠️
Partial
The PR doesn't change the failure-email path itself. The implicit hypothesis is: the same alias mismatch caused
isForCurrentEnvironment
to refuse the relay, hence no Twilio send, hence the failure email. The PR should fix that root cause, but the failure-email producer (likely in
EmailTextRelay
job / Twilio webhook path) is not touched here — worth confirming nothing else can still produce a false failure email after the fix lands.
Investigate trace gap (no CloudWatch / Twilio / Sentry record of the attempted send)
✅ Implemented
The added...
|
Firefox
|
JY-20891 fix alias mismatch in text relay service JY-20891 fix alias mismatch in text relay service by LakyLak · Pull Request #12128 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12128
|
72403
|
|
72404
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
New Tab
New Tab
Login - SonarQube Cloud
Login - SonarQube Cloud
What's New in Firefox 151 — Firefox.com
What's New in Firefox 151 — Firefox.com
New Tab
New Tab
[JY-20814] Release unused Twilio numbers on Production - Jira
[JY-20814] Release unused Twilio numbers on Production - Jira
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS]
Show options
LakyLak commented 1 hour ago
LakyLak
LakyLak
commented
1 hour ago
1 hour ago
JIRA: JY-20891
JIRA:
JY-20891
JY-20891
Changes:
Changes:
change environment check
add logs
Add or remove reactions
@LakyLak
JY-20891
JY-20891
fix alias mismatch in text relay service
fix alias mismatch in text relay service
12 / 12 checks OK
a722028
a722028
@sonarqubecloud
Show options
sonarqubecloud Bot commented 46 minutes ago
sonarqubecloud
sonarqubecloud
Bot
commented
46 minutes ago
46 minutes ago
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
85.4% Coverage on New Code
85.4% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud
Add or remove reactions
@LakyLak
Show options
Author
LakyLak commented 46 minutes ago
LakyLak
LakyLak
commented
46 minutes ago
46 minutes ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@github-actions
Show options
github-actions Bot commented 45 minutes ago •
github-actions
github-actions
Bot
commented
45 minutes ago
45 minutes ago
•
edited
edited
Claude finished
@LakyLak
@LakyLak
's task in 2m 46s
——
View job
View job
📋
Jira:
JY-20891 — Sidekick SMS issue
JY-20891 — Sidekick SMS issue
Status:
Deployed
| Requirements were found in the Jira ticket and are included below.
🤖
Model:
claude-opus-4-7
Jira Ticket Requirements Coverage
Jira Ticket Requirements Coverage
Requirement
Status
Notes
Find why valid SMS replies (e.g. Scott's reply to
[PHONE]
) were silently dropped and never reached Twilio
✅ Implemented
Root cause is the strict equality on
X-Gm-Original-To
. Inbound emails arrive with a Gmail-style plus tag (e.g.
[EMAIL]
) which never equals the expected
[EMAIL]
, so the message is silently refused. The new
matchesExpectedRecipient
strips the
+...
suffix before comparing.
Explain why senders always receive the "failure" email even when the message was actually sent
⚠️
Partial
The PR doesn't change the failure-email path itself. The implicit hypothesis is: the same alias mismatch caused
isForCurrentEnvironment
to refuse the relay, hence no Twilio send, hence the failure email. The PR should fix that root cause, but the failure-email producer (likely in
EmailTextRelay
job / Twilio webhook path) is not touched here — worth confirming nothing else can still produce a false failure email after the fix lands.
Investigate trace gap (no CloudWatch / Twilio / Sentry record of the attempted send)
✅ Implemented
The added
Log::info/warning/error
calls in
sync
,
getHistory
, and
isForCurrentEnvironment
close that gap going forward — refused messages, missing headers, and Gmail API errors are now logged with the
message_id
.
Verify segmentation / long-SMS suspicion (email signature blowing up message size)
❌ Out of scope
This PR doesn't touch SMS segmentation. Once the alias fix is in prod, you'll be able to see in logs whether messages were refused vs. actually sent to Twilio; that should rule signature/length in or out.
Requirement
Find why valid SMS replies (e.g. Scott's reply to
[PHONE]
) were silently dropped and never reached Twilio
Explain why senders always receive the "failure" email even when the message was actually sent
Investigate trace gap (no CloudWatch / Twilio / Sentry record of the attempted send)
Verify segmentation / long-SMS suspicion (email signature blowing up message size)
Status
✅ Implemented
⚠️
Partial
✅ Implemented
❌ Out of scope
Notes
Root cause is the strict equality on
X-Gm-Original-To
. Inbound emails arrive with a Gmail-style plus tag (e.g.
[EMAIL]
) which never equals the expected
[EMAIL]
, so the message is silently refused. The new
matchesExpectedRecipient
strips the
+...
suffix before comparing.
The PR doesn't change the failure-email path itself. The implicit hypothesis is: the same alias mismatch caused
isForCurrentEnvironment
to refuse the relay, hence no Twilio send, hence the failure email. The PR should fix that root cause, but the failure-email producer (likely in
EmailTextRelay
job / Twilio webhook path) is not touched here — worth confirming nothing else can still produce a false failure email after the fix lands.
The added
Log::info/warning/error
calls in
sync
,
getHistory
, and
isForCurrentEnvironment
close that gap going forward — refused messages, missing headers, and Gmail API errors are now logged with the
message_id
.
This PR doesn't touch SMS segmentation. Once the alias fix is in prod, you'll be able to see in logs whether messages were refused vs. actually sent to Twilio; that should rule signature/length in or out.
Code Review
Code Review
✅ Core fix is correct
✅ Core fix is correct
app/Services/Mail/TextRelayService.php:211-222
—
matchesExpectedRecipient
correctly:
Splits the host with a 2-arg
explode
(safe against
a@b@c
weirdness)
Compares the host case-insensitively
Strips the
+...
plus-tag from the local part before comparing the alias
This squarely addresses the reported failure (plus-tagged recipients silently refused).
🟡 Issues / suggestions
🟡 Issues / suggestions
testSyncWithRefusedMessageLogs
is a verbatim copy of
testSyncWithEnhancedLogging
—
tests/Unit/Services/Mail/TextRelayServiceTest.php:336-420
. Both set EU region, mock
getHistory
to return
[]
, and expect the same start/completed
Log::info
calls. Neither actually exercises a refused message. Either delete the duplicate or make it return a history containing a non-matching
X-Gm-Original-To
and assert the
Refused message
log.
Fix this →
Fix this →
Log::info('[TextRelayService] Refused message', ...)
fires for every refused message
(
TextRelayService.php:187-191
). If inbound mail for EU and US share the same inbox (which seems to be the design — each env filters by alias), this will produce one info log per cross-region message every sync. Suggest dropping it to
debug
, or rate-limiting it after the immediate investigation, otherwise the diagnostic value drowns in noise quickly.
Log::info('[TextRelayService] Starting sync', ...)
fires after
getService()
and
getHistory()
(
TextRelayService.php:33-41
). If either throws (e.g. credentials missing, Gmail history call fails before the
try
), the "Starting sync" log never appears — exactly when you'd want it. Move it to the very top of
sync()
, right after computing the alias/host.
"Sync completed" log includes the full
message_ids
array
(
TextRelayService.php:77-81
). On busy syncs this can be a large payload.
messages_processed
is usually enough; keep
message_ids
only at
debug
, or cap the list.
'original_to' => $header->value
in the refused-message log
(
TextRelayService.php:189
) embeds the plus-tag, which encodes a phone number and Twilio routing hash. That's borderline PII. If this log is shipped to a third-party sink (e.g. Datadog) verify your data-classification policy allows it.
Test comments violate CLAUDE.md
("Do not add comments unless it's a weird quirk").
TextRelayServiceTest.php:343,346,349,366,386,389,392,409
— all 8
//
comments are restating obvious code (
// Mock getHistory to return empty array
,
// Mock Sentry to prevent actual error reporting
, etc.). Please strip them.
\Sentry::shouldReceive('captureException')->zeroOrMoreTimes()
in
testSyncWithEnhancedLogging
/
testSyncWithRefusedMessageLogs
violates CLAUDE.md "Do not use
$this->any()
, always use the exact number of times". Since neither test exercises an error path, this should be
->never()
(or just omit and rely on Mockery's default strict-ness).
testSyncWithEnhancedLogging
doesn't really assert anything new
beyond "two log lines fire on an empty sync." Consider replacing it (rather than duplicating) with a test that walks a non-empty history end-to-end (
getHistory
→ matching
X-Gm-Original-To
→ dispatched job → "Successfully dispatched message" log). That's where the real regression risk is, and it's currently uncovered.
Minor — log message wording
:
'[TextRelayService] Refused message: missing X-Gm-Original-To header'
(
TextRelayService.php:197
) uses
warning
while a plain mismatch uses
info
. The missing-header case is arguably less serious than mismatch (legitimate Gmail messages always have the header — its absence likely indicates malformed/spam mail, not a config bug). Swapping or aligning the levels would help triage.
🟢 Nice things
🟢 Nice things
Case-insensitive host/alias comparison via
strcasecmp
— good defensive choice.
The new test
testIsForCurrentEnvironmentRejectsWrongHostWithMatchingPlusTag
covers the cross-env confusion case (correct alias, wrong host) which is exactly the kind of edge you want pinned down.
Datasets for the matching/non-matching providers were extended with plus-tag variants — good regression coverage.
Sentry is still being notified on exceptions; only adding logs, not replacing existing observability.
Verdict
Verdict
The functional fix is solid and addresses the Jira root cause. The blockers I'd want resolved before tagging "done" are the duplicate test (#1) and the test comments / strict mock counts (#6, #7). The logging cleanups (#2, #3, #4) are quality-of-life improvements once the immediate triage value of
info
-level diagnostics is no longer needed.
--- · Branch:
JY-20891-fix-alias-mismatch-on-sms-text-relay
JY-20891-fix-alias-mismatch-on-sms-text-relay
Add or remove reactions
@LakyLak
JY-20891
JY-20891
code review suggestions
code review suggestions
8 / 10 checks OK
cf76b69
cf76b69
@LakyLak
Show options
Author...
|
Firefox
|
JY-20891 fix alias mismatch in text relay service JY-20891 fix alias mismatch in text relay service by LakyLak · Pull Request #12128 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12128
|
72404
|
|
72561
|
iTerm2ShellEditViewSessionScriptsProfilesWindowHel iTerm2ShellEditViewSessionScriptsProfilesWindowHelpDOCKER881DEV (-zsh)₴2"taskManager""taskManager"],:"TaskManager is identified byUUID: bf01f365-e094-4cde-940d-3e0db65fa22a"}elasticsearch"timestamp" :"2026-05-26T08:41:46,504Z""component":"o.e.c.m.MetadataIndexTemplateService""cluster.name":"docker-clust"node.name":"e802ad473a4f""message":"adding template [.management-beats][.management-beats]", "cluster.uuid":"e2ZKzgw4Q4aCf2w51jWr1A""8uhZw1CUSGyWYR_OvaKx6g","node.id":{"type": "log", "@timestamp": "2026-05-26T08:41:46Z".,"tags": ["info", "plugi"cross(lusterReplication"],"message": "Yourbasic license does not support crossClusterReplication.Please upgrade your license.1 {"'type": "log","@timestamp":"2026-05-26T08:41:467".,"tags":["info","watcher"],"pid":7, "message": "Your basic license does not support watcher. Please upgrade your license. "31 {"type": "log""@timestamp":"2026-05-26T08:41:46Z","tags" : ["info""monitoring", "monitoring", "kibana-monitoring"],"pid" :7, "message": "Starting monitoring stats collection"}I {"'type": "log","@timestamp":"2026-05-26T08:41:46Z","tags" : ["error"ticsearch"',"data"],'"pid":7, "message":"[version_conflict_engine_exception]: [task:Lens-lens_telemetry]: version conflict, document already exists (current version [790])"}ticsearch"1 {"type":"log""@timestamp":"2026-05-26T08:41:46Z"., "tags" : ["error", "elas"data"],"pid" :7,"message":"[version_conflict_engine_exception]: [task:Actions-actions_telemetry]: version conflict, document already exists (current version [790])"}{"type":"log","@timestamp": "2026-05-26T08:41:46Z","tags": ["error"ticsearch",,"data"],"pid":7, "message":"[version_conflict_engine_exception]: [task:endpoint:user-artifact-packager:1.0.0]: version conflict, document already exists (current version (319175])"}1 {"type": "log""@timestamp": "2026-05-26T08:41:46Z", "tags": ["error"ticsearch",,"data"], "pid" :7, "message" : "[version_conflict_engine_exception]: [task:Alerting-alerting_telemetry]: version conflict, document already exists (current version [790])I {"'type": "log", "@timestamp":"2026-05-26T08:41:46Z".,"tags": ["error", "elas"pid":7, "message":"[version_conflict_engine_exception]: [task:apm-telemetry-task]: version conflict,document alreadyexists (current version{"type": "log""@timestamp":"2026-05-26T08:41:47Z", "tags" :["listening","info"],"pid":7, "message": "Serverat [URL_WITH_CREDENTIALS] "http","Kibana"],"pid" :7,: "http server runningat [URL_WITH_CREDENTIALS] : ["warning""reporting"], "pid":7, "message": "Enabling the Chromiumsandbox provides an additional layer of protection."}docker_lamp_1exited with code 2V View in Docker Desktopo View Configw Enable WatchDOCKER (docker-compose)APP (-zsh)&3screenpipe"- 84X.PROD (ssh)See [URL_WITH_CREDENTIALS] 0X L3 EU (ssh)Enable ESM Apps to receive additional future security updates.See [URL_WITH_CREDENTIALS] |T4STAGE (-zsh)Poetry could not find a pyproject.toml file in /Users/lukas or its parentsSTAGEPoetry could not find a pyproject.toml file in /Users/lukas or its parentslukas@Lukas-Kovaliks-MacBook-Pro-Jiminny$75 QA (-zsh)Poetry could not find a pyproject.toml file in /Users/lukas or its parentsPoetry could not find a pyproject.toml file in /Users/lukas or its parentsX 16FE (-zsh)Last login: Wed May 20 09:14:49 on ttys004Poetry could not find a pyproject.toml file in /Users/lukas or its parentsFRONTENDPoetry could not find a pyproject.toml file in /Users/lukas or its parentslukas@Lukas-Kovaliks-MacBook-Pro-Jiminny ~ $ IX Y7 EXT (-zsh)Last login: Wed May 20 09:14:49 on ttys004Poetry could not find a pyproject.toml file in /Users/lukas or its parentsEXTENSIONPoetry could not find a pyproject.toml file in /Users/lukas or its parentsas@Lukas-Kovaliks-MacBook-Pro-Jiminny ~...
|
Firefox
|
JY-20891 fix alias mismatch in text relay service JY-20891 fix alias mismatch in text relay service by LakyLak · Pull Request #12128 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12128
|
72561
|
|
72562
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
New Tab
New Tab
Login - SonarQube Cloud
Login - SonarQube Cloud
What's New in Firefox 151 — Firefox.com
What's New in Firefox 151 — Firefox.com
New Tab
New Tab
[JY-20814] Release unused Twilio numbers on Production - Jira
[JY-20814] Release unused Twilio numbers on Production - Jira
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS]
Show options
LakyLak commented 1 hour ago
LakyLak
LakyLak
commented
1 hour ago
1 hour ago
JIRA: JY-20891
JIRA:
JY-20891
JY-20891
Changes:
Changes:
change environment check
add logs
Add or remove reactions
@LakyLak
JY-20891
JY-20891
fix alias mismatch in text relay service
fix alias mismatch in text relay service
12 / 12 checks OK
a722028
a722028
@sonarqubecloud
Show options
sonarqubecloud Bot commented 1 hour ago
sonarqubecloud
sonarqubecloud
Bot
commented
1 hour ago
1 hour ago
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
85.4% Coverage on New Code
85.4% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud
Add or remove reactions
@LakyLak
Show options
Author
LakyLak commented 1 hour ago
LakyLak
LakyLak
commented
1 hour ago
1 hour ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@github-actions
Show options
github-actions Bot commented 1 hour ago •
github-actions
github-actions
Bot
commented
1 hour ago
1 hour ago
•
edited
edited
Claude finished
@LakyLak
@LakyLak
's task in 2m 46s
——
View job
View job
📋
Jira:
JY-20891 — Sidekick SMS issue
JY-20891 — Sidekick SMS issue
Status:
Deployed
| Requirements were found in the Jira ticket and are included below.
🤖
Model:
claude-opus-4-7
Jira Ticket Requirements Coverage
Jira Ticket Requirements Coverage
Requirement
Status
Notes
Find why valid SMS replies (e.g. Scott's reply to
[PHONE]
) were silently dropped and never reached Twilio
✅ Implemented
Root cause is the strict equality on
X-Gm-Original-To
. Inbound emails arrive with a Gmail-style plus tag (e.g.
[EMAIL]
) which never equals the expected
[EMAIL]
, so the message is silently refused. The new
matchesExpectedRecipient
strips the
+...
suffix before comparing.
Explain why senders always receive the "failure" email even when the message was actually sent
⚠️
Partial
The PR doesn't change the failure-email path itself. The implicit hypothesis is: the same alias mismatch caused
isForCurrentEnvironment
to refuse the relay, hence no Twilio send, hence the failure email. The PR should fix that root cause, but the failure-email producer (likely in
EmailTextRelay
job / Twilio webhook path) is not touched here — worth confirming nothing else can still produce a false failure email after the fix lands.
Investigate trace gap (no CloudWatch / Twilio / Sentry record of the attempted send)
✅ Implemented
The added
Log::info/warning/error
calls in
sync
,
getHistory
, and
isForCurrentEnvironment
close that gap going forward — refused messages, missing headers, and Gmail API errors are now logged with the
message_id
.
Verify segmentation / long-SMS suspicion (email signature blowing up message size)
❌ Out of scope
This PR doesn't touch SMS segmentation. Once the alias fix is in prod, you'll be able to see in logs whether messages were refused vs. actually sent to Twilio; that should rule signature/length in or out.
Requirement
Find why valid SMS replies (e.g. Scott's reply to
[PHONE]
) were silently dropped and never reached Twilio
Explain why senders always receive the "failure" email even when the message was actually sent
Investigate trace gap (no CloudWatch / Twilio / Sentry record of the attempted send)
Verify segmentation / long-SMS suspicion (email signature blowing up message size)
Status
✅ Implemented
⚠️
Partial
✅ Implemented
❌ Out of scope
Notes
Root cause is the strict equality on
X-Gm-Original-To
. Inbound emails arrive with a Gmail-style plus tag (e.g.
[EMAIL]
) which never equals the expected
[EMAIL]
, so the message is silently refused. The new
matchesExpectedRecipient
strips the
+...
suffix before comparing.
The PR doesn't change the failure-email path itself. The implicit hypothesis is: the same alias mismatch caused
isForCurrentEnvironment
to refuse the relay, hence no Twilio send, hence the failure email. The PR should fix that root cause, but the failure-email producer (likely in
EmailTextRelay
job / Twilio webhook path) is not touched here — worth confirming nothing else can still produce a false failure email after the fix lands.
The added
Log::info/warning/error
calls in
sync
,
getHistory
, and
isForCurrentEnvironment
close that gap going forward — refused messages, missing headers, and Gmail API errors are now logged with the
message_id
.
This PR doesn't touch SMS segmentation. Once the alias fix is in prod, you'll be able to see in logs whether messages were refused vs. actually sent to Twilio; that should rule signature/length in or out.
Code Review
Code Review
✅ Core fix is correct
✅ Core fix is correct
app/Services/Mail/TextRelayService.php:211-222
—
matchesExpectedRecipient
correctly:
Splits the host with a 2-arg
explode
(safe against
a@b@c
weirdness)
Compares the host case-insensitively
Strips the
+...
plus-tag from the local part before comparing the alias
This squarely addresses the reported failure (plus-tagged recipients silently refused).
🟡 Issues / suggestions
🟡 Issues / suggestions
testSyncWithRefusedMessageLogs
is a verbatim copy of
testSyncWithEnhancedLogging
—
tests/Unit/Services/Mail/TextRelayServiceTest.php:336-420
. Both set EU region, mock
getHistory
to return
[]
, and expect the same start/completed
Log::info
calls. Neither actually exercises a refused message. Either delete the duplicate or make it return a history containing a non-matching
X-Gm-Original-To
and assert the
Refused message
log.
Fix this →
Fix this →
Log::info('[TextRelayService] Refused message', ...)
fires for every refused message
(
TextRelayService.php:187-191
). If inbound mail for EU and US share the same inbox (which seems to be the design — each env filters by alias), this will produce one info log per cross-region message every sync. Suggest dropping it to
debug
, or rate-limiting it after the immediate investigation, otherwise the diagnostic value drowns in noise quickly.
Log::info('[TextRelayService] Starting sync', ...)
fires after
getService()
and
getHistory()
(
TextRelayService.php:33-41
). If either throws (e.g. credentials missing, Gmail history call fails before the
try
), the "Starting sync" log never appears — exactly when you'd want it. Move it to the very top of
sync()
, right after computing the alias/host.
"Sync completed" log includes the full
message_ids
array
(
TextRelayService.php:77-81
). On busy syncs this can be a large payload.
messages_processed
is usually enough; keep
message_ids
only at
debug
, or cap the list.
'original_to' => $header->value
in the refused-message log
(
TextRelayService.php:189
) embeds the plus-tag, which encodes a phone number and Twilio routing hash. That's borderline PII. If this log is shipped to a third-party sink (e.g. Datadog) verify your data-classification policy allows it.
Test comments violate CLAUDE.md
("Do not add comments unless it's a weird quirk").
TextRelayServiceTest.php:343,346,349,366,386,389,392,409
— all 8
//
comments are restating obvious code (
// Mock getHistory to return empty array
,
// Mock Sentry to prevent actual error reporting
, etc.). Please strip them.
\Sentry::shouldReceive('captureException')->zeroOrMoreTimes()
in
testSyncWithEnhancedLogging
/
testSyncWithRefusedMessageLogs
violates CLAUDE.md "Do not use
$this->any()
, always use the exact number of times". Since neither test exercises an error path, this should be
->never()
(or just omit and rely on Mockery's default strict-ness).
testSyncWithEnhancedLogging
doesn't really assert anything new
beyond "two log lines fire on an empty sync." Consider replacing it (rather than duplicating) with a test that walks a non-empty history end-to-end (
getHistory
→ matching
X-Gm-Original-To...
|
Firefox
|
JY-20891 fix alias mismatch in text relay service JY-20891 fix alias mismatch in text relay service by LakyLak · Pull Request #12128 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12128
|
72562
|
|
72563
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
New Tab
New Tab
Login - SonarQube Cloud
Login - SonarQube Cloud
Close tab
What's New in Firefox 151 — Firefox.com
What's New in Firefox 151 — Firefox.com
New Tab
New Tab
[JY-20814] Release unused Twilio numbers on Production - Jira
[JY-20814] Release unused Twilio numbers on Production - Jira
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
New Tab
New Tab
JY-20891 fix alias mismatch in text relay service by LakyLak · Pull Request #12128 · jiminny/app
JY-20891 fix alias mismatch in text relay service by LakyLak · Pull Request #12128 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (35)
Pull requests
(
35
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20891 fix alias mismatch in text relay service #12128 Edit title
JY-20891 fix alias mismatch in text relay service
#
12128
Edit title
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into...
|
Firefox
|
JY-20891 fix alias mismatch in text relay service JY-20891 fix alias mismatch in text relay service by LakyLak · Pull Request #12128 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12128
|
72563
|
|
74083
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
All commits
All commits
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
0 of 3 files viewed
Checks failing
Checks failing
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app
Http/Controllers/API
ActivityController.php
ActivityController.php
Services/Crm/Salesforce
Service.php
Service.php
tests/Unit/Services/Crm/Salesforce
ServiceTest.php
ServiceTest.php
Collapse file
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
Copy file name to clipboard
Expand all lines: app/Http/Controllers/API/ActivityController.php
Lines changed: 4 additions & 0 deletions
Not Viewed
Viewed
Comment on this file
More options
Original file line number...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes#diff-d35 github.com/jiminny/app/pull/12121/changes#diff-d357223b9be9c9ab792b2b8d612e54cc8b84ab1dad84e6bda239aabc9b8e9405...
|
74083
|
|
74084
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
All commits
All commits
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
0 of 3 files viewed
Checks failing
Checks failing
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app
Http/Controllers/API
ActivityController.php
ActivityController.php
Services/Crm/Salesforce
Service.php
Service.php
tests/Unit/Services/Crm/Salesforce
ServiceTest.php
ServiceTest.php
Collapse file
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
Copy file name to clipboard
Expand all lines: app/Http/Controllers/API/ActivityController.php
Lines changed: 4 additions & 0 deletions
Not Viewed
Viewed
Comment on this file...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes#diff-d35 github.com/jiminny/app/pull/12121/changes#diff-d357223b9be9c9ab792b2b8d612e54cc8b84ab1dad84e6bda239aabc9b8e9405...
|
74084
|
|
74085
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
All commits
All commits
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
0 of 3 files viewed
Checks failing
Checks failing
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app
Http/Controllers/API
ActivityController.php
ActivityController.php
Services/Crm/Salesforce
Service.php
Service.php
tests/Unit/Services/Crm/Salesforce
ServiceTest.php
ServiceTest.php
Collapse file
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
Copy file name to clipboard
Expand all lines: app/Http/Controllers/API/ActivityController.php
Lines changed: 4 additions & 0 deletions
Not Viewed
Viewed
Comment on this file
More options
Original file line number
Original file line
Diff line number
Diff line change
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
371
}
371
}
372
372
373
+
if
(!
$
contact
instanceof
Contact) {
374
+
break
;
375
+
}
376
+
373
$
this
->
logger
->
info
(
'
resolving account
'
);
377
$
this
->
logger
->
info
(
'
resolving account
'
);
374
$
account
=
$
this
->
resolveAccount
(
$
team
,
$
contact
,
$
crmService
,
$
prospects
);
378
$
account
=
$
this
->
resolveAccount
(
$
team
,
$
contact
,
$
crmService
,
$
prospects
);
375
379
Original file line number
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed
370
371
372
373
374...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes#diff-d35 github.com/jiminny/app/pull/12121/changes#diff-d357223b9be9c9ab792b2b8d612e54cc8b84ab1dad84e6bda239aabc9b8e9405...
|
74085
|
|
74086
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
All commits
All commits
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
0 of 3 files viewed
Checks failing
Checks failing
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app
Http/Controllers/API
ActivityController.php
ActivityController.php
Services/Crm/Salesforce
Service.php
Service.php
tests/Unit/Services/Crm/Salesforce
ServiceTest.php
ServiceTest.php
Collapse file
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
Copy file name to clipboard
Expand all lines: app/Http/Controllers/API/ActivityController.php
Lines changed: 4 additions & 0 deletions
Not Viewed
Viewed
Comment on this file
More options
Original file line number
Original file line
Diff line number
Diff line change
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
371
}
371
}
372
372
373
+
if
(!
$
contact
instanceof
Contact) {
374
+
break
;
375
+
}
376
+
373
$
this
->
logger
->
info
(
'
resolving account
'
);
377
$
this
->
logger
->
info
(
'
resolving account
'
);
374
$
account
=
$
this
->
resolveAccount
(
$
team
,
$
contact
,
$
crmService
,
$
prospects
);
378
$
account
=
$
this
->
resolveAccount
(
$
team
,
$...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes#diff-d35 github.com/jiminny/app/pull/12121/changes#diff-d357223b9be9c9ab792b2b8d612e54cc8b84ab1dad84e6bda239aabc9b8e9405...
|
74086
|
|
74087
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
All commits
All commits
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
0 of 3 files viewed
Checks failing
Checks failing
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app
Http/Controllers/API
ActivityController.php
ActivityController.php
Services/Crm/Salesforce
Service.php
Service.php
tests/Unit/Services/Crm/Salesforce
ServiceTest.php
ServiceTest.php
Collapse file
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
Copy file name to clipboard
Expand all lines: app/Http/Controllers/API/ActivityController.php
Lines changed: 4 additions & 0 deletions
Not Viewed
Viewed
Comment on this file
More options
Original file line number
Original file line
Diff line number
Diff line change
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
371
}
371
}
372
372
373
+
if
(!
$
contact
instanceof
Contact) {
374
+
break
;
375
+
}
376
+
373
$
this
->
logger
->
info
(
'
resolving account
'
);
377
$
this
->
logger
->
info
(
'
resolving account
'
);
374
$
account
=
$
this
->
resolveAccount
(
$
team
,
$
contact
,
$
crmService
,
$
prospects
);
378
$
account
=
$
this
->
resolveAccount
(
$
team
,
$
contact
,
$
crmService
,
$
prospects
);
375
379
Original file line number
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed
370
371
372
373
374
375
Original file line
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
}
$
this
->
logger
->
info
(...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes#diff-d35 github.com/jiminny/app/pull/12121/changes#diff-d357223b9be9c9ab792b2b8d612e54cc8b84ab1dad84e6bda239aabc9b8e9405...
|
74087
|
|
74088
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
All commits
All commits
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
0 of 3 files viewed
Checks failing
Checks failing
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app
Http/Controllers/API
ActivityController.php
ActivityController.php
Services/Crm/Salesforce
Service.php
Service.php
tests/Unit/Services/Crm/Salesforce
ServiceTest.php
ServiceTest.php
Collapse file
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
Copy file name to clipboard
Expand all lines: app/Http/Controllers/API/ActivityController.php
Lines changed: 4 additions & 0 deletions
Not Viewed
Viewed
Comment on this file
More options
Original file line number
Original file line
Diff line number
Diff line change
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
371
}
371
}
372
372
373
+
if
(!
$
contact
instanceof
Contact) {
374
+
break
;
375
+
}
376
+
373
$
this
->
logger
->
info
(
'
resolving account
'
);
377
$
this
->
logger
->
info
(
'
resolving account
'
);
374
$
account
=
$
this
->
resolveAccount
(
$
team
,
$
contact
,
$
crmService
,
$
prospects
);
378
$
account
=
$
this
->
resolveAccount
(
$
team
,
$
contact
,
$
crmService
,
$
prospects
);
375
379
Original file line number
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed
370
371
372
373
374
375
Original file line
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
}
$
this
->
logger
->
info
(
'
resolving account
'
);
$
account
=
$
this
->
resolveAccount
(
$
team
,
$
contact
,
$
crmService
,
$
prospects
);
Diff line number...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes#diff-d35 github.com/jiminny/app/pull/12121/changes#diff-d357223b9be9c9ab792b2b8d612e54cc8b84ab1dad84e6bda239aabc9b8e9405...
|
74088
|
|
74089
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
All commits
All commits
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
0 of 3 files viewed
Checks failing
Checks failing
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app
Http/Controllers/API
ActivityController.php
ActivityController.php
Services/Crm/Salesforce
Service.php
Service.php
tests/Unit/Services/Crm/Salesforce
ServiceTest.php
ServiceTest.php
Collapse file
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
Copy file name to clipboard
Expand all lines: app/Http/Controllers/API/ActivityController.php
Lines changed: 4 additions & 0 deletions
Not Viewed
Viewed
Comment on this file
More options
Original file line number
Original file line
Diff line number
Diff line change
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
371
}
371
}
372
372
373
+
if
(!
$
contact
instanceof
Contact) {
374
+
break
;
375
+
}
376
+
373
$
this
->
logger
->
info
(
'
resolving account
'
);
377
$
this
->
logger
->
info
(
'
resolving account
'
);
374
$
account
=
$
this
->
resolveAccount
(
$
team
,
$
contact
,
$
crmService
,
$
prospects
);
378...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes#diff-d35 github.com/jiminny/app/pull/12121/changes#diff-d357223b9be9c9ab792b2b8d612e54cc8b84ab1dad84e6bda239aabc9b8e9405...
|
74089
|
|
74090
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
All commits
All commits
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
0 of 3 files viewed
Checks failing
Checks failing
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app
Http/Controllers/API
ActivityController.php
ActivityController.php
Services/Crm/Salesforce
Service.php
Service.php
tests/Unit/Services/Crm/Salesforce
ServiceTest.php
ServiceTest.php
Collapse file
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
Copy file name to clipboard
Expand all lines: app/Http/Controllers/API/ActivityController.php
Lines changed: 4 additions & 0 deletions
Not Viewed
Viewed
Comment on this file
More options
Original file line number
Original file line
Diff line number
Diff line change
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
371
}
371
}
372
372
373
+
if
(!
$
contact
instanceof
Contact) {
374
+
break
;
375
+
}
376
+
373
$
this
->
logger
->
info
(
'
resolving account
'
);
377
$
this
->
logger
->
info
(
'
resolving account
'
);
374
$
account
=
$
this
->
resolveAccount
(
$
team
,
$
contact
,
$
crmService
,
$
prospects
);
378
$
account
=
$
this
->
resolveAccount
(
$
team
,
$
contact
,
$
crmService
,
$
prospects
);
375
379
Original file line number
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed
370
371
372
373
374
375
Original file line
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
}
$
this...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes#diff-d35 github.com/jiminny/app/pull/12121/changes#diff-d357223b9be9c9ab792b2b8d612e54cc8b84ab1dad84e6bda239aabc9b8e9405...
|
74090
|
|
74091
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
All commits
All commits
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
0 of 3 files viewed
Checks failing
Checks failing
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app
Http/Controllers/API
ActivityController.php
ActivityController.php
Services/Crm/Salesforce
Service.php
Service.php
tests/Unit/Services/Crm/Salesforce
ServiceTest.php
ServiceTest.php
Collapse file
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
Copy file name to clipboard
Expand all lines: app/Http/Controllers/API/ActivityController.php
Lines changed: 4 additions & 0 deletions
Not Viewed
Viewed
Comment on this file
More options
Original file line number
Original file line
Diff line number
Diff line change
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
371
}
371
}
372
372
373
+
if
(!
$
contact
instanceof
Contact) {
374
+
break
;
375
+
}
376
+
373
$
this
->
logger
->
info
(
'
resolving account
'
);
377
$
this
->
logger
->
info
(
'
resolving account
'
);
374
$
account
=
$
this
->
resolveAccount
(
$
team
,
$
contact
,
$
crmService
,
$
prospects
);
378
$
account
=
$
this
->
resolveAccount
(
$
team
,
$
contact
,
$
crmService
,
$
prospects
);
375
379
Original file line number
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed
370
371
372
373
374
375
Original file line
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
}
$
this
->
logger
->
info
(
'
resolving account
'
);
$
account
=
$
this
->
resolveAccount
(
$
team
,
$
contact
,
$...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes#diff-d35 github.com/jiminny/app/pull/12121/changes#diff-d357223b9be9c9ab792b2b8d612e54cc8b84ab1dad84e6bda239aabc9b8e9405...
|
74091
|
|
74092
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
All commits
All commits
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
0 of 3 files viewed
Checks failing
Checks failing
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app
Http/Controllers/API
ActivityController.php
ActivityController.php
Services/Crm/Salesforce
Service.php
Service.php
tests/Unit/Services/Crm/Salesforce
ServiceTest.php
ServiceTest.php
Collapse file
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
Copy file name to clipboard
Expand all lines: app/Http/Controllers/API/ActivityController.php
Lines changed: 4 additions & 0 deletions
Not Viewed
Viewed
Comment on this file
More options
Original file line number
Original file line
Diff line number
Diff line change
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
371
}
371
}
372
372
373
+
if
(!
$
contact
instanceof
Contact) {
374
+
break
;
375
+
}
376
+
373
$
this
->
logger
->
info
(
'
resolving account
'
);
377
$
this
->
logger
->
info
(
'
resolving account
'
);
374
$
account
=
$
this
->
resolveAccount
(
$
team
,
$
contact
,
$
crmService
,
$
prospects
);
378
$
account
=
$
this
->
resolveAccount
(
$
team
,
$
contact
,
$
crmService
,
$
prospects
);
375
379
Original file line number
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed
370
371
372
373
374
375
Original file line
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed
$...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes#diff-d35 github.com/jiminny/app/pull/12121/changes#diff-d357223b9be9c9ab792b2b8d612e54cc8b84ab1dad84e6bda239aabc9b8e9405...
|
74092
|
|
74093
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
All commits
All commits
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
0 of 3 files viewed
Checks failing
Checks failing
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app
Http/Controllers/API
ActivityController.php
ActivityController.php
Services/Crm/Salesforce
Service.php
Service.php
tests/Unit/Services/Crm/Salesforce
ServiceTest.php
ServiceTest.php
Collapse file
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
Copy file name to clipboard
Expand all lines: app/Http/Controllers/API/ActivityController.php
Lines changed: 4 additions & 0 deletions
Not Viewed
Viewed
Comment on this file
More options
Original file line number
Original file line
Diff line number
Diff line change
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
371
}
371
}
372
372
373
+
if
(!
$
contact
instanceof
Contact) {
374
+
break
;
375
+
}
376
+
373
$
this
->
logger
->
info
(
'
resolving account
'
);
377
$
this
->
logger
->
info
(
'
resolving account
'
);
374
$
account
=
$
this
->
resolveAccount
(
$
team
,
$
contact
,
$
crmService
,
$
prospects
);
378
$
account
=
$
this
->
resolveAccount
(
$
team
,
$
contact
,
$
crmService
,
$
prospects
);
375
379
Original file line number
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes#diff-d35 github.com/jiminny/app/pull/12121/changes#diff-d357223b9be9c9ab792b2b8d612e54cc8b84ab1dad84e6bda239aabc9b8e9405...
|
74093
|
|
74094
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
All commits
All commits
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
0 of 3 files viewed
Checks failing
Checks failing
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app
Http/Controllers/API
ActivityController.php
ActivityController.php
Services/Crm/Salesforce
Service.php
Service.php
tests/Unit/Services/Crm/Salesforce
ServiceTest.php
ServiceTest.php
Collapse file
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
Copy file name to clipboard
Expand all lines: app/Http/Controllers/API/ActivityController.php
Lines changed: 4 additions & 0 deletions
Not Viewed
Viewed
Comment on this file
More options
Original file line number
Original file line
Diff line number
Diff line change
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
371
}
371
}
372
372
373
+
if
(!
$
contact
instanceof
Contact) {
374...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes#diff-d35 github.com/jiminny/app/pull/12121/changes#diff-d357223b9be9c9ab792b2b8d612e54cc8b84ab1dad84e6bda239aabc9b8e9405...
|
74094
|
|
74098
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
All commits
All commits
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
0 of 3 files viewed
Checks failing
Checks failing
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app
Http/Controllers/API
ActivityController.php
ActivityController.php
Services/Crm/Salesforce
Service.php
Service.php
tests/Unit/Services/Crm/Salesforce
ServiceTest.php
ServiceTest.php
Collapse file
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
Copy file name to clipboard
Expand all lines: app/Http/Controllers/API/ActivityController.php
Lines changed: 4 additions & 0 deletions
Not Viewed
Viewed
Comment on this file
More options
Original file line number
Original file line
Diff line number
Diff line change
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
371
}
371
}
372
372
373
+
if
(!
$
contact
instanceof
Contact) {...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes#diff-d35 github.com/jiminny/app/pull/12121/changes#diff-d357223b9be9c9ab792b2b8d612e54cc8b84ab1dad84e6bda239aabc9b8e9405...
|
74098
|
|
74099
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
All commits
All commits
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
0 of 3 files viewed
Checks failing
Checks failing
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app
Http/Controllers/API
ActivityController.php
ActivityController.php
Services/Crm/Salesforce
Service.php
Service.php
tests/Unit/Services/Crm/Salesforce
ServiceTest.php
ServiceTest.php
Collapse file
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
Copy file name to clipboard
Expand all lines: app/Http/Controllers/API/ActivityController.php
Lines changed: 4 additions & 0 deletions
Not Viewed
Viewed
Comment on this file
More options
Original file line number
Original file line
Diff line number
Diff line change
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
370
$
contact
=
$
crmService
->...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes#diff-d35 github.com/jiminny/app/pull/12121/changes#diff-d357223b9be9c9ab792b2b8d612e54cc8b84ab1dad84e6bda239aabc9b8e9405...
|
74099
|
|
74100
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
All commits
All commits
0 of 3 files viewed
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app
Http/Controllers/API
ActivityController.php
ActivityController.php
Services/Crm/Salesforce
Service.php
Service.php
tests/Unit/Services/Crm/Salesforce
ServiceTest.php
ServiceTest.php
Collapse file
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
Copy file name to clipboard
Expand all lines: app/Http/Controllers/API/ActivityController.php
Lines changed: 4 additions & 0 deletions
Not Viewed
Viewed...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes#diff-d35 github.com/jiminny/app/pull/12121/changes#diff-d357223b9be9c9ab792b2b8d612e54cc8b84ab1dad84e6bda239aabc9b8e9405...
|
74100
|
|
70862
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Service-Desk - Queues - Platform team - Service space - Jira
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
Jiminny
Jiminny
[JY-20879] Enable users to use their new activity types - Jira
[JY-20879] Enable users to use their new activity types - Jira
Sentry error
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
[JY-20813] Twilio number is not released when Voice role is removed from user - Jira
[JY-20813] Twilio number is not released when Voice role is removed from user - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (33)
Pull requests
(
33
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (2)
Security and quality
(
2
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Preview
Preview
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 1 commit into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 13 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (1)
Commits
(
1
)
Checks (2)
Checks
(
2
)
Files changed (1)
Files changed
(
1...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes
|
70862
|
|
70863
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Service-Desk - Queues - Platform team - Service space - Jira
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
Jiminny
Jiminny
[JY-20879] Enable users to use their new activity types - Jira
[JY-20879] Enable users to use their new activity types - Jira
Sentry error
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
[JY-20813] Twilio number is not released when Voice role is removed from user - Jira
[JY-20813] Twilio number is not released when Voice role is removed from user - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (33)
Pull requests
(
33
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (2)
Security and quality
(
2
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Preview
Preview
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 1 commit into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 13 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (1)
Commits
(
1
)
Checks (2)
Checks
(
2
)
Files changed (1)
Files changed
(
1
)
Pull Request Toolbar...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes
|
70863
|
|
70864
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Service-Desk - Queues - Platform team - Service space - Jira
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
Jiminny
Jiminny
[JY-20879] Enable users to use their new activity types - Jira
[JY-20879] Enable users to use their new activity types - Jira
Sentry error
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
[JY-20813] Twilio number is not released when Voice role is removed from user - Jira
[JY-20813] Twilio number is not released when Voice role is removed from user - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (33)
Pull requests
(
33
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (2)
Security and quality
(
2
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Preview
Preview
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes
|
70864
|
|
70865
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Service-Desk - Queues - Platform team - Service space - Jira
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
Jiminny
Jiminny
[JY-20879] Enable users to use their new activity types - Jira
[JY-20879] Enable users to use their new activity types - Jira
Sentry error
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
[JY-20813] Twilio number is not released when Voice role is removed from user - Jira
[JY-20813] Twilio number is not released when Voice role is removed from user - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (33)
Pull requests
(
33
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (2)
Security and quality
(
2
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Preview
Preview
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 1 commit into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 13 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (1)
Commits
(
1
)
Checks (2)
Checks
(
2
)
Files changed (1)
Files changed
(
1
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
All commits
All commits
0 of 1 file viewed
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app/Services/Crm/Salesforce
Service.php
Service.php
Collapse file
app/Services/Crm/Salesforce/Service.php
app/Services/Crm/Salesforce/Service.php
app/Services/Crm/Salesforce/Service.php
Copy file name to clipboard
Expand all lines: app/Services/Crm/Salesforce/Service.php
Lines changed: 13 additions & 1 deletion
Not Viewed
Viewed
Comment on this file
More options...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes
|
70865
|
|
74076
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 5 days ago •
LakyLak
LakyLak
commented
5 days ago
5 days ago
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
5 days ago
5 days ago
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
79dc986
79dc986
@nikolay-yankov
nikolay-yankov
nikolay-yankov
force-pushed
force-pushed
the
JY-20963-fix-import-on-deleted-entity
branch 2 times, most recently from
86b558b
86b558b
to
79dc986
79dc986
Compare...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes
|
74076
|
|
74077
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 5 days ago •
LakyLak
LakyLak
commented
5 days ago
5 days ago
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
5 days ago
5 days ago
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
79dc986
79dc986
@nikolay-yankov
nikolay-yankov
nikolay-yankov
force-pushed
force-pushed
the
JY-20963-fix-import-on-deleted-entity
branch 2 times, most recently from
86b558b
86b558b
to
79dc986
79dc986
Compare
Compare
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes
|
74077
|
|
74078
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
All commits
All commits
0 of 3 files viewed
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes
|
74078
|
|
74079
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
All commits
All commits
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
0 of 3 files viewed
Checks failing
Checks failing
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app
Http/Controllers/API
ActivityController.php
ActivityController.php
Services/Crm/Salesforce
Service.php
Service.php
tests/Unit/Services/Crm/Salesforce
ServiceTest.php
ServiceTest.php
Collapse file
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
Copy file name to clipboard
Expand all lines: app/Http/Controllers/API/ActivityController.php
Lines changed: 4 additions & 0 deletions
Not Viewed
Viewed
Comment on this file
More options
Original file line number
Original file line
Diff line number
Diff line change
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
371
}
371
}
372
372
373
+
if
(!
$
contact
instanceof
Contact) {
374
+
break
;
375
+
}
376
+
373
$
this
->
logger
->
info
(
'
resolving account
'
);
377
$
this
->
logger
->
info
(
'
resolving account
'
);
374
$
account
=
$
this
->
resolveAccount
(...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes
|
74079
|
|
74080
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
All commits
All commits
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
0 of 3 files viewed
Checks failing
Checks failing
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app
Http/Controllers/API
ActivityController.php
ActivityController.php
Services/Crm/Salesforce
Service.php
Service.php
tests/Unit/Services/Crm/Salesforce
ServiceTest.php
ServiceTest.php
Collapse file
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
Copy file name to clipboard
Expand all lines: app/Http/Controllers/API/ActivityController.php
Lines changed: 4 additions & 0 deletions
Not Viewed
Viewed
Comment on this file
More options
Original file line number
Original file line
Diff line number
Diff line change
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
371
}
371
}
372
372
373
+
if
(!
$
contact
instanceof
Contact) {
374
+
break
;
375
+
}
376
+
373
$
this
->
logger
->
info
(
'
resolving account
'
);
377
$
this
->
logger
->
info
(
'
resolving account
'
);
374
$
account
=
$
this
->
resolveAccount
(
$
team
,
$
contact
,
$
crmService
,
$
prospects
);
378
$
account
=
$
this
->
resolveAccount...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes
|
74080
|
|
74081
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
All commits
All commits
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
0 of 3 files viewed
Checks failing
Checks failing
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app
Http/Controllers/API
ActivityController.php
ActivityController.php
Services/Crm/Salesforce
Service.php
Service.php
tests/Unit/Services/Crm/Salesforce
ServiceTest.php
ServiceTest.php
Collapse file
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
Copy file name to clipboard
Expand all lines: app/Http/Controllers/API/ActivityController.php
Lines changed: 4 additions & 0 deletions
Not Viewed
Viewed
Comment on this file
More options
Original file line number
Original file line
Diff line number
Diff line change
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
371
}
371
}
372
372
373
+
if
(!
$
contact
instanceof
Contact) {
374
+
break
;
375
+
}
376
+
373
$
this
->
logger
->
info
(
'
resolving account
'
);
377
$
this
->
logger
->
info
(
'
resolving account
'
);
374
$
account
=
$
this
->
resolveAccount
(
$
team
,
$
contact
,
$
crmService
,
$...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes
|
74081
|
|
74082
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Preview
Preview
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
Open
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
All commits
All commits
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
0 of 3 files viewed
Checks failing
Checks failing
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app
Http/Controllers/API
ActivityController.php
ActivityController.php
Services/Crm/Salesforce
Service.php
Service.php
tests/Unit/Services/Crm/Salesforce
ServiceTest.php
ServiceTest.php
Collapse file
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
app/Http/Controllers/API/ActivityController.php
Copy file name to clipboard
Expand all lines: app/Http/Controllers/API/ActivityController.php
Lines changed: 4 additions & 0 deletions
Not Viewed
Viewed
Comment on this file
More options
Original file line number
Original file line
Diff line number
Diff line change
@@ -370,6 +370,10 @@ public function summarize(Activity $activity): mixed
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
370
$
contact
=
$
crmService
->
syncContact
(
$
objectId
);
371
}
371
}
372
372
373
+
if
(!
$
contact
instanceof
Contact) {
374
+
break
;
375...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes
|
74082
|
|
83285
|
Platform Sprint 5 Q2 - Platform Team - Scrum Board Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
BE upgrade libraries
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Text relay
Deleted object error
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Login | Salesforce
Login | Salesforce
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Inbox (1,732) - [EMAIL] - Jiminny Mail
Inbox (1,732) - [EMAIL] - Jiminny Mail
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
Jiminny
Jiminny
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
transcript ss issue
Jiminny
Jiminny
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Open
JY-20963 fix deleted object import #12121 LakyLak wants to merge 6 commits into master from JY-20963-fix-import-on-deleted-entity Copy head branch name to clipboard
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented last week •
LakyLak
LakyLak
commented
last week
last week
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
last week
last week
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes
|
83285
|
|
83286
|
Platform Sprint 5 Q2 - Platform Team - Scrum Board Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
BE upgrade libraries
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Text relay
Deleted object error
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Login | Salesforce
Login | Salesforce
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Inbox (1,732) - [EMAIL] - Jiminny Mail
Inbox (1,732) - [EMAIL] - Jiminny Mail
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
Jiminny
Jiminny
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
transcript ss issue
Jiminny
Jiminny
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Conversation
Conversation
@LakyLak
Show options
LakyLak commented last week •
LakyLak
LakyLak
commented...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes
|
83286
|
|
83287
|
Platform Sprint 5 Q2 - Platform Team - Scrum Board Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
BE upgrade libraries
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Text relay
Deleted object error
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Login | Salesforce
Login | Salesforce
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Inbox (1,732) - [EMAIL] - Jiminny Mail
Inbox (1,732) - [EMAIL] - Jiminny Mail
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
Jiminny
Jiminny
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
transcript ss issue
Jiminny
Jiminny
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Conversation
Conversation
@LakyLak
Show options
LakyLak commented last week •
LakyLak
LakyLak
commented
last week
last week
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
last week
last week
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
79dc986
79dc986
@nikolay-yankov
nikolay-yankov
nikolay-yankov
force-pushed
force-pushed
the
JY-20963-fix-import-on-deleted-entity
branch 2 times, most recently from
86b558b
86b558b
to
79dc986
79dc986
Compare
Compare
last week
last week
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
last week
last week
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
last week
last week
@nikolay-yankov
Show options
nikolay-yankov commented last week
nikolay-yankov...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes
|
83287
|
|
83288
|
Platform Sprint 5 Q2 - Platform Team - Scrum Board Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
BE upgrade libraries
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Text relay
Deleted object error
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Login | Salesforce
Login | Salesforce
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Inbox (1,732) - [EMAIL] - Jiminny Mail
Inbox (1,732) - [EMAIL] - Jiminny Mail
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
Jiminny
Jiminny
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
transcript ss issue
Jiminny
Jiminny
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes
|
83288
|
|
83289
|
Platform Sprint 5 Q2 - Platform Team - Scrum Board Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
BE upgrade libraries
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Text relay
Deleted object error
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Login | Salesforce
Login | Salesforce
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Inbox (1,732) - [EMAIL] - Jiminny Mail
Inbox (1,732) - [EMAIL] - Jiminny Mail
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
Jiminny
Jiminny
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
transcript ss issue
Jiminny
Jiminny
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Conversation
Conversation
@LakyLak
Show options
LakyLak commented last week •
LakyLak
LakyLak
commented
last week
last week
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
last week
last week
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
79dc986
79dc986
@nikolay-yankov
nikolay-yankov
nikolay-yankov
force-pushed
force-pushed
the
JY-20963-fix-import-on-deleted-entity
branch 2 times, most recently from
86b558b
86b558b
to
79dc986
79dc986
Compare
Compare
last week
last week
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
last week
last week
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
last week
last week
@nikolay-yankov
Show options
nikolay-yankov commented last week
nikolay-yankov
nikolay-yankov
commented
last week
last week
@claude
@claude
Add or remove reactions
react with eyes...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes
|
83289
|
|
83290
|
Platform Sprint 5 Q2 - Platform Team - Scrum Board Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
BE upgrade libraries
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Text relay
Deleted object error
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Login | Salesforce
Login | Salesforce
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Inbox (1,732) - [EMAIL] - Jiminny Mail
Inbox (1,732) - [EMAIL] - Jiminny Mail
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
Jiminny
Jiminny
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
transcript ss issue
Jiminny
Jiminny
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Conversation
Conversation
@LakyLak
Show options
LakyLak commented last week •
LakyLak
LakyLak
commented
last week
last week
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes
|
83290
|
|
83291
|
Platform Sprint 5 Q2 - Platform Team - Scrum Board Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
BE upgrade libraries
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Text relay
Deleted object error
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Login | Salesforce
Login | Salesforce
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Inbox (1,732) - [EMAIL] - Jiminny Mail
Inbox (1,732) - [EMAIL] - Jiminny Mail
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
Jiminny
Jiminny
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
transcript ss issue
Jiminny
Jiminny
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Conversation
Conversation
@LakyLak
Show options
LakyLak commented last week •
LakyLak
LakyLak
commented
last week
last week
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
last week
last week
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
79dc986
79dc986
@nikolay-yankov
nikolay-yankov
nikolay-yankov
force-pushed
force-pushed
the
JY-20963-fix-import-on-deleted-entity
branch 2 times, most recently from
86b558b
86b558b
to
79dc986
79dc986
Compare
Compare
last week
last week
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
last week
last week
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
last week
last week
@nikolay-yankov
Show options
nikolay-yankov commented last week
nikolay-yankov
nikolay-yankov
commented
last week
last week
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
d3de6e8
d3de6e8
@nikolay-yankov
Show options
nikolay-yankov commented last week
nikolay-yankov
nikolay-yankov
commented
last week
last week
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@github-actions...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes
|
83291
|
|
85592
|
iTerm2• • 0Shell|EditViewSessionScripts|Profiles iTerm2• • 0Shell|EditViewSessionScripts|ProfilesWindowHelp-zshDOCKERO ₴1DEV (docker)₴82-zshN3screenpipe"O ₴4-zshapp/Component/ES/Repositories/EsResetActivityRepository.phpapp/Component/KeyPoints/Services/KeyPointsIndexingService.php348+++app/Component/TranscriptionSummary/Services/GetTranscriptionSummaryService.phpapp/Component/TranscriptionSummary/Services/TranscriptionSummaryIndexingService.phpapp/Models/Activity/Moment.phpapp/Models/Activity/Note.php402116app/Models/CommentAbstract.php++++app/Models/Crm/FieldData.phpapp/Models/ElasticSearch/ActivityElasticSearchTrait.php651+++++++=app/Models/Participant.phpapp/Traits/RequiresUUID.php5scripts/run_command_stagetests/Unit/Component/ActionItems/Services/ActionItemsIndexingServiceTest.phptests/Unit/Component/KeyPoints/Services/GetKeyPointsServiceTest.phptests/Unit/Component/KeyPoints/Services/KeyPointsIndexingServiceTest.phptests/Unit/Component/TranscriptionSummary/Services/TranscriptionSummaryIndexingServiceTest.php71346976++++++++++17 files changed, 472 insertions(+), 22 deletions(-)create mode 100644 app/Component/ActionItems/Services/ActionItemsIndexingService.phpcreate mode 100644 app/Component/KeyPoints/Services/KeyPointsIndexingService.phpcreate mode 100644 app/Component/TranscriptionSummary/Services/TranscriptionSummaryIndexingService.phpcreate mode 100644 tests/Unit/Component/ActionItems/Services/ActionItemsIndexingServicelest.phpcreate mode 100644 tests/Unit/Component/KeyPoints/Services/KeyPointsIndexingServiceTest.phpcreate mode 100644 tests/Unit/Component/TranscriptionSummary/Services/TranscriptionSummaryIndexingServiceTest.phplukas@Lukas-Kovaliks-MacBook-Pro-Jiminny ~/jiminny/app (master) $ ;xddocker exec-it docker_lamp_1 bash -c "mv /usr/local/etc/php/conf.d/xdebug.ini ~/xdebug.ini"What's next:Try Docker Debug for seamless, persistent debugging tools in any container or image → docker debug docker_lamp_1Learn more at [URL_WITH_CREDENTIALS] ~/jiminny/app (JY-20963-fix-import-on-deleted-entity) $ ;xddockerexec-it docker_lamp_1 bash-c "mv /usr/local/etc/php/conf.d/xdebug.ini ~/xdebug.ini"mv: cannot stat '/usr/local/etc/php/conf.d/xdebug.ini': No such file or directoryWhat's next:Try Docker Debug for seamless, persistent debugging tools in any container or image → docker debug docker_lamp_1Learn more at [URL_WITH_CREDENTIALS] ~/jiminny/app (JY-20963-fix-import-on-deleted-entity)$D‹>0 (|85ec2-user@ip-10-30-129-...100% <78• Thu 28 May 15:51:101₴1ec2-user@ip-10-30-140-...₴7...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes
|
85592
|
|
85593
|
Platform Sprint 5 Q2 - Platform Team - Scrum Board Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
BE upgrade libraries
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Text relay
Deleted object error
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Login | Salesforce
Login | Salesforce
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Inbox (1,734) - [EMAIL] - Jiminny Mail
Inbox (1,734) - [EMAIL] - Jiminny Mail
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
Jiminny
Jiminny
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
transcript ss issue
Jiminny
Jiminny
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Sona Subramanian at 27/05/2026, 17:46:08 - Session Replay - LogRocket
Sona Subramanian at 27/05/2026, 17:46:08 - Session Replay - LogRocket
Iliyana Netseva at 27/05/2026, 18:48:18 - Session Replay - LogRocket
Iliyana Netseva at 27/05/2026, 18:48:18 - Session Replay - LogRocket
Jiminny...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes
|
85593
|
|
85594
|
Platform Sprint 5 Q2 - Platform Team - Scrum Board Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
BE upgrade libraries
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Text relay
Deleted object error
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Login | Salesforce
Login | Salesforce
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes
|
85594
|
|
85595
|
iTerm2• • 0Shell|EditViewSessionScripts|Profiles iTerm2• • 0Shell|EditViewSessionScripts|ProfilesWindowHelp-zshDOCKERO ₴1DEV (docker)₴82-zshN3screenpipe"app/Component/ES/Repositories/EsResetActivityRepository.phpapp/Component/KeyPoints/Services/KeyPointsIndexingService.php84348-zsh+++app/Component/TranscriptionSummary/Services/GetTranscriptionSummaryService.phpapp/Component/TranscriptionSummary/Services/TranscriptionSummaryIndexingService.phpapp/Models/Activity/Moment.phpapp/Models/Activity/Note.php402116app/Models/CommentAbstract.php++++app/Models/Crm/FieldData.phpapp/Models/ElasticSearch/ActivityElasticSearchTrait.php651+++++++=app/Models/Participant.phpapp/Traits/RequiresUUID.php5scripts/run_command_stagetests/Unit/Component/ActionItems/Services/ActionItemsIndexingServiceTest.phptests/Unit/Component/KeyPoints/Services/GetKeyPointsServiceTest.phptests/Unit/Component/KeyPoints/Services/KeyPointsIndexingServiceTest.phptests/Unit/Component/TranscriptionSummary/Services/TranscriptionSummaryIndexingServiceTest.php71346976++++++++++17 files changed, 472 insertions(+), 22 deletions(-)create mode 100644 app/Component/ActionItems/Services/ActionItemsIndexingService.phpcreate mode 100644 app/Component/KeyPoints/Services/KeyPointsIndexingService.phpcreate mode 100644 app/Component/TranscriptionSummary/Services/TranscriptionSummaryIndexingService.phpcreate mode 100644 tests/Unit/Component/ActionItems/Services/ActionItemsIndexingServicelest.phpcreate mode 100644 tests/Unit/Component/KeyPoints/Services/KeyPointsIndexingServiceTest.phpcreate mode 100644 tests/Unit/Component/TranscriptionSummary/Services/TranscriptionSummaryIndexingServiceTest.phplukas@Lukas-Kovaliks-MacBook-Pro-Jiminny ~/jiminny/app (master) $ ;xddocker exec-it docker_lamp_1 bash -c "mv /usr/local/etc/php/conf.d/xdebug.ini ~/xdebug.ini"What's next:Try Docker Debug for seamless, persistent debugging tools in any container or image → docker debug docker_lamp_1Learn more at [URL_WITH_CREDENTIALS] ~/jiminny/app (JY-20963-fix-import-on-deleted-entity) $ ;xddockerexec-it docker_lamp_1 bash-c "mv /usr/local/etc/php/conf.d/xdebug.ini ~/xdebug.ini"mv: cannot stat '/usr/local/etc/php/conf.d/xdebug.ini': No such file or directoryWhat's next:Try Docker Debug for seamless, persistent debugging tools in any container or image → docker debug docker_lamp_1Learn more at [URL_WITH_CREDENTIALS] ~/jiminny/app (JY-20963-fix-import-on-deleted-entity)$D‹>0 (|85ec2-user@ip-10-30-129-...100% <78• Thu 28 May 15:51:161₴1ec2-user@ip-10-30-140-...₴7...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes
|
85595
|
|
85596
|
rircroxViewhsttonooorinsnsroiuesWindowHelp- github rircroxViewhsttonooorinsnsroiuesWindowHelp- github.com/ininnydpo ouleicuchonde~ Google Gemini© Pipelines - |Iminnylapp* (JY-20613) Allow owner's role to txUewredtines on New codJY-20963 fix deleted objecti Xm.cwdSycaotionslsmalldcthatteM'inbox (1734) - Aukas.kovallk@jlminoonye Rosd ve php 81.15 dedPlatform Sorint 5.02 - Platform Te8 Jiminny7 (SRD-6881] (On demand) TransSona Strbramaal an at 27/05/2021O Illyana Netsova at 27/05/2026, 18Jimny+ New TabGemini 3.1 Pro ~That is a very common misconception, but it is not true anymoreWhile it is true that many years ago (around 2014-2016) phpredis had some bugs regarding theorder in which EX and NX arguments were passed, it has fully supported combining them into asingle atomic command for a very long time.To do this atomically using the phpredis driver, you simply pass an associative array of options asthe third argumentHere is exactly how you would write it in your code:PHPSlockKey = sprintf(self::LOCK_KEY, $this->updateTarget);1/ This executes a single, atomic SET conand with both NX and EXSacquired = Redis::set(slockkey, true, L'NX, "EX => seLf::LOCK.TTL-SECONDSJ)8if (! Sacquired) €// Another process already holds the lockxeturn./1 ... report your metrics …..By relying on separate (get, set, and expire commands, you are leaving a microsecond gapopen. In your new multi-process Supervisor architecture, two parallel workers can check the get,both see (null, and both proceed to write the lock and push duplicate metrics. Using the arraysyntax above closes that gap completely.A Cleaner Laravel AlternativeSince vou are inside a Laravel app, you don't even need to fight with driver-specific Redis syntax.Ask GeminilYour lim nou chate trhn" uend to imnroy our moddle Camioiie 4l1t cao mata mtake co donbls chack " Yoir oracy & CaminSummarize pageiminny / app 8<> Code17 Pull requests 36(. Agents • Actions00 Wiki Security and quality 3 w Insights SettingsJY-20963 fix deleted object import #12121 •17 Open LakyLak wants to merge 6 commits into naster from JY-20963-fix-import-on-deleted-entityQ) Conversation 4Commits 6 E Checks 3 Files changed 3LakyLak commented last week • edited by nikolay-yankovJIKA.Changes:• Fix imeort obiect it deletedE LakyLak and others added 2 commits last week0 © JY-28963 11x deleted object importX ec151a10 & Merge branch 'naster' into JY-20963-1ix-import-on-deleted-entityVerified X 79dc986Et , nikolay-yankov force-pushed the JY-20963-fix-import-on-deleted-entity branch 2 times, most recently from2hhtsah to 79dc0%k las: wep.Compardx & nikolay-yankov deleted a comment from github-actions (Bot last weekx & nikolay-yankov deleted a comment from github-actions Bot last weeknikolay-yankov commented last week@claude-0 & Merge branch "naster' into JY-20963-1ix-import-on-deleted-entityVerified X d3de6e8nikolav-wankov commaotedhe weakOESOMОД100% K/3 8 • Thu 28 May 15:51:16Q Type to search8 -® Checks failingeode-+403 -52 BBB0ReviewersSuggestionsyalokin-jiminnyE asi- iminnyQ ilan-jiminnyRequestAt least 1 approving review is required to merge this pulreauesStill in progress? Convert to draftAssigneesNo one-assign yourselfNone yetProjectsNone yetMilestoneNo milestone$DevelopmentSuccesstully merging this oull recuest may close thesissues.None yetNotificationsUnsubscribeYou're receiving notifications because you're watchingthis repository-2 participants...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes
|
85596
|
|
85597
|
Platform Sprint 5 Q2 - Platform Team - Scrum Board Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
BE upgrade libraries
rircroxViewhsttonooorinsnsroiuesWindowHelp- github.com/ininnydpo ouleicuchonde~ Google GeminiGemini 3.1 Pro ~© Pipelines - |Iminnylapp* (JY-20613) Allow owner's role to txUewredtines on New codJY-20963 fix deleted objecti Xlm cwdsycaotionslEmnlltcthtteM'inbox (1734) - Aukas.kovallk@jlmirnoonre Rose ve php 81.15 dedPlatform Sorint 5.02 - Platform Te8 Jiminny7 (SRD-6881] (On demand) TransSona Subramaaian at 27/05/202O Illyana Netsova at 27/05/2026, 18Jimny+ New TabThat is a very common misconception, but it is not true anymoreWhile it is true that many years ago (around 2014-2016) phpredis had some bugs regarding theorder in which EX and NX arguments were passed, it has fully supported combining them into asingle atomic command for a very long time.To do this atomically using the phpredis driver, you simply pass an associative array of options asthe third argumentHere is exactly how you would write it in your code:PHPSlockKey = sprintf(self::LOCK_KEY, $this->updateTarget);1/ This executes a single, atomic SET conand with both NX and EXSacquired = Redis::set(slockkey, true, L'NX, "EX => seLf::LOCK.TTL-SECONDSJ)8if (! Sacquired) €// Another process already holds the lockxeturn./1 ... report your metrics …..By relying on separate (get, set, and expire commands, you are leaving a microsecond gapopen. In your new multi-process Supervisor architecture, two parallel workers can check the (get,both see (null, and both proceed to write the lock and push duplicate metrics. Using the arraysyntax above closes that gap completely.A Cleaner Laravel AlternativeSince vou are inside a Laravel app, you don't even need to fight with driver-specific Redis syntax.Ask GeminilYoe lim nou Chate teho' uend to imnrmy our moddle Camioiie Allt cao make mtakhe to donbls chch+ Yoir oiacy & CaminiSummarize pageQa @JY-20963 fix deleted object importX ec151a1a & Merge branch 'naster' into JY-28963-fix-import-on-deleted-entityVerified X 79dc986G nikolay-yankov force-pushed the JY-20963-fix-import-on-deleted-entity branch 2 times, most recently from866558b t0 79dc986 last weekCompareX & nikolay-yankov deleted a comment from github-actions Bot last weekx &nikolay-yankov deleted a comment from github-actions Bot last weeknikofiv-vankoy commeniceweek@claudea &Merge branch 'naster' into JY-28963-fix-import-on-deleted-entitynikolay-yankoy commented last week@claudeVerified X d3de6e8OESOMОД100% K52 8 • Thu 28 May 15:51:19No one—assign yourseltNone yetProjectsNone yetMilestoneNo milestondDevelopmentSuccessfully morging this pull request may close theseissues.None yetNotificationsCustomiz2 Unsubscribethu re rosotiviy: notfications because you're watching2 participants8 Lock conversationaithub-actions Bot commented lact wepk . editediClaude finished @nikolay-yankov's task in 3m 3s — View jobE Jira: JY-20963 - Fix foreign key violation when matching activities to deleted Salesforce opportunitiesStatus: In Dev | Requirements were found in the Jira ticket and are included below.é Model: claude-opus-4-7Jira Ticket Requirements CoverageRequirementStatusNotesSioo teturnina a troch vade cied doporunitv tromincor Dooorunyy sod 2Scontrk-voalewhen setting activity.opportunity_idImnlementedReturns null afterhandleObjectDeletion if the opportunityended up trashed...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes
|
85597
|
|
85598
|
Platform Sprint 5 Q2 - Platform Team - Scrum Board Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
BE upgrade libraries
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Text relay
rircroxViewhsttonooorinsnsroiueslootWindowHelp- github.com/ininnydpo ouleicuchonde~ Google GeminiGemini 3.1 Pro ~© Pipelines - |Iminnylapp* (JY-20613) Allow owner's role to txUewredtines on New codJY-20963 fix deleted objecti Xm.cwdSycaotionslsmalldcthatteM'inbox (1734) - lkas.kovallk@jiminoonye Rosd ve php 81.15 dedPlatform Sorint 5.02 - Platform Te8 Jiminny7 (SRD-6881] (On demand) TransSona Strbramaal an at 27/05/2021O Illyana Netsova at 27/05/2026, 18Jimny+ New TabThat is a very common misconception, but it is not true anymoreWhile it is true that many years ago (around 2014-2016) phpredis had some bugs regarding theorder in which EX and NX arguments were passed, it has fully supported combining them into asingle atomic command for a very long time.To do this atomically using the phpredis driver, you simply pass an associative array of options asthe third argumentHere is exactly how you would write it in your code:PHPSlockKey = sprintf(self::LOCK_KEY, $this->updateTarget);1/ This executes a single, atomic SET conand with both NX and EXSacquired = Redis::set(slockkey, true, L'NX, "EX => seLf::LOCK.TTL-SECONDSJ)8if (! Sacquired) €// Another process already holds the locknetuyn:/1 ... report your metrics …..By relying on separate (get, set, and expire commands, you are leaving a microsecond gapopen. In your new multi-process Supervisor architecture, two parallel workers can check the (get,both see (null, and both proceed to write the lock and push duplicate metrics. Using the arraysyntax above closes that gap completely.A Cleaner Laravel AlternativeSince vou are inside a Laravel app, you don't even need to fight with driver-specific Redis syntax.Ask GeminilYoe lim nou Chate teho' uend to imnrmy our moddle Camioiie Allt cao make mtakhe to donbls chch+ Yoir oiacy & CaminiSummarize pageQ SOMOX 100%K3 8• Thu 28 May 15:51:22neviewreculetAt least 1 approving review is required by reviewers with write access.) Some checks were not successful1 failing, 11 successful checks1 tailina check© & SonarCloud Code Analysis Falling after 1m - Quality Gate falled11 cuccaceful chackeO build_accept_deploy Successful in 14m - Workflow: buld_accept_deployv O ci/circleci: build-backend - Your tests passed on CircleCIv O ci/circleci: build-frontend - Your tests passed on CircleCH!v O cil/circleci: checkout-code - Your tests passed on CircleCl!0 ci/circleci: phostan = Your tests passed on CircieClA This branch is out-of-date with the base branchMerge the latest changes from master into this branch. This merge commit will beassociated with Lakvlak4 Merging is blockedAt least 1 approving review is required by reviewers with write accessiEnable auto-mergeYou can also merge this with the command line. View.command line instructionsAdd a commentWritePreviewAdd your comment here…..RequiredUpdate branchStill in progress? Convert to drafth Wackelman le cuneateh# Paste, drop, or click to add files11 Close pull request(®) Remember, contributions to this recository should follow our GitHub Community Guidelines.Q ProTip! Add comments to specific lines under Files changed.0 2026 GitHub, Inc. Terms Privacy Security Status Community Docs Contact Manage cookies Do not share my personal information...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121/changes
|
85598
|