|
70785
|
[JY-20963] Fix foreign key violation when matching [JY-20963] Fix foreign key violation when matching activities to deleted Salesforce opportunities - Jira
[JY-20963] Fix foreign key violation when matching activities to deleted Salesforce opportunities - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
JY-20915 add alias for EU by LakyLak · Pull Request #12105 · jiminny/app
JY-20915 add alias for EU by LakyLak · Pull Request #12105 · jiminny/app
Service-Desk - Queues - Platform team - Service space - Jira
Service-Desk - Queues - Platform team - Service space - Jira
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20915 add alias for EU by LakyLak · Pull Request #12105 · jiminny/app
JY-20915 add alias for EU by LakyLak · Pull Request #12105 · jiminny/app
Pipelines - jiminny/app
Pipelines - jiminny/app
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS]
Show options
LakyLak commented 1 minute ago
LakyLak
LakyLak
commented
1 minute ago
1 minute ago
JIRA: JY-20963
JIRA:
JY-20963
JY-20963
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
2 / 4 checks OK
0c151a1
0c151a1
This branch has not been deployed
This branch has not been deployed
No deployments
Merge info
Merge info
Review required
Review required
At least 1 approving review is required by reviewers with write access.
Some checks haven't completed yet
Some checks haven't completed yet...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
70785
|
|
70786
|
[JY-20963] Fix foreign key violation when matching [JY-20963] Fix foreign key violation when matching activities to deleted Salesforce opportunities - Jira
[JY-20963] Fix foreign key violation when matching activities to deleted Salesforce opportunities - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
JY-20915 add alias for EU by LakyLak · Pull Request #12105 · jiminny/app
JY-20915 add alias for EU by LakyLak · Pull Request #12105 · jiminny/app
Service-Desk - Queues - Platform team - Service space - Jira
Service-Desk - Queues - Platform team - Service space - Jira
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20915 add alias for EU by LakyLak · Pull Request #12105 · jiminny/app
JY-20915 add alias for EU by LakyLak · Pull Request #12105 · jiminny/app
Pipelines - jiminny/app
Pipelines - jiminny/app
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
Jiminny
Jiminny
[JY-20879] Enable users to use their new activity types - Jira
[JY-20879] Enable users to use their new activity types - Jira
Sentry error
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
[JY-20813] Twilio number is not released when Voice role is removed from user - Jira
[JY-20813] Twilio number is not released when Voice role is removed from user - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (33)
Pull requests
(
33
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (2)
Security and quality
(
2
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Checks pending...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
70786
|
|
70859
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Service-Desk - Queues - Platform team - Service space - Jira
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
Jiminny
Jiminny
[JY-20879] Enable users to use their new activity types - Jira
[JY-20879] Enable users to use their new activity types - Jira
Sentry error
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
[JY-20813] Twilio number is not released when Voice role is removed from user - Jira
[JY-20813] Twilio number is not released when Voice role is removed from user - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (33)
Pull requests
(
33
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (2)
Security and quality
(
2
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 1 commit into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 13 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (1)
Commits
(
1
)...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
70859
|
|
70860
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Service-Desk - Queues - Platform team - Service space - Jira
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
Jiminny
Jiminny
[JY-20879] Enable users to use their new activity types - Jira
[JY-20879] Enable users to use their new activity types - Jira
Sentry error
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
[JY-20813] Twilio number is not released when Voice role is removed from user - Jira
[JY-20813] Twilio number is not released when Voice role is removed from user - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (33)
Pull requests
(
33
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (2)
Security and quality
(
2
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 1 commit into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 13 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (1)
Commits
(
1
)
Checks (2)
Checks
(
2
)
Files changed (1)
Files changed
(
1...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
70860
|
|
70861
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Service-Desk - Queues - Platform team - Service space - Jira
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS]
Show options
LakyLak commented 5 minutes ago
LakyLak
LakyLak
commented
5 minutes ago
5 minutes ago
JIRA: JY-20963
JIRA:
JY-20963
JY-20963
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
7 / 10 checks OK
0c151a1
0c151a1
This branch has not been deployed
This branch has not been deployed
No deployments
Merge info
Merge info
Review required
Review required
At least 1 approving review is required by reviewers with write access.
Some checks haven't completed yet
Some checks haven't completed yet
2 pending, 1 in progress, 1 expected, 7 successful checks
Collapse checks
Collapse 3 pending checks group
3 pending checks
Checks settings
pending checks
pending checks
ci/circleci: test
ci/circleci: test
ci/circleci: test
Waiting for status to be reported
— CircleCI is running your tests
More actions
ci/circleci: test-backend-lint
ci/circleci: test-backend-lint
ci/circleci: test-backend-lint
Waiting for status to be reported
— CircleCI is running your tests
More actions...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
70861
|
|
70866
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Service-Desk - Queues - Platform team - Service space - Jira
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS]
Show options
LakyLak commented 6 minutes ago
LakyLak
LakyLak
commented
6 minutes ago
6 minutes ago
JIRA: JY-20963
JIRA:
JY-20963
JY-20963
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
7 / 10 checks OK
0c151a1
0c151a1
This branch has not been deployed
This branch has not been deployed
No deployments
Merge info
Merge info
Review required
Review required
At least 1 approving review is required by reviewers with write access.
Some checks haven't completed yet
Some checks haven't completed yet
2 pending, 1 in progress, 1 expected, 7 successful checks
Collapse checks
Collapse 3 pending checks group
3 pending checks
Checks settings
pending checks
pending checks
ci/circleci: test
ci/circleci: test
ci/circleci: test
Waiting for status to be reported
— CircleCI is running your tests
More actions
ci/circleci: test-backend-lint
ci/circleci: test-backend-lint
ci/circleci: test-backend-lint
Waiting for status to be reported
— CircleCI is running your tests
More actions
SonarCloud Code Analysis
SonarCloud Code Analysis
Expected
— Waiting for status to be reported
Required...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
70866
|
|
70867
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Service-Desk - Queues - Platform team - Service space - Jira
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
Jiminny
Jiminny
[JY-20879] Enable users to use their new activity types - Jira
[JY-20879] Enable users to use their new activity types - Jira
Sentry error
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
[JY-20813] Twilio number is not released when Voice role is removed from user - Jira
[JY-20813] Twilio number is not released when Voice role is removed from user - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (33)
Pull requests
(
33
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (2)
Security and quality
(
2
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 1 commit into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 13 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (1)
Commits
(
1
)
Checks (2)
Checks
(
2
)
Files changed (1)
Files changed
(
1...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
70867
|
|
70868
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Service-Desk - Queues - Platform team - Service space - Jira
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS]
Show options
LakyLak commented 6 minutes ago
LakyLak
LakyLak
commented
6 minutes ago
6 minutes ago
JIRA: JY-20963
JIRA:
JY-20963
JY-20963
Changes:
Changes:
Fix import object if deleted...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
70868
|
|
70869
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Service-Desk - Queues - Platform team - Service space - Jira
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS]
Show options
LakyLak commented 6 minutes ago
LakyLak
LakyLak
commented
6 minutes ago
6 minutes ago
JIRA: JY-20963
JIRA:
JY-20963
JY-20963
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
7 / 10 checks OK
0c151a1
0c151a1
This branch has not been deployed
This branch has not been deployed
No deployments
Merge info
Merge info
Review required
Review required
At least 1 approving review is required by reviewers with write access.
Some checks haven't completed yet
Some checks haven't completed yet
2 pending, 1 in progress, 1 expected, 7 successful checks
Collapse checks
Collapse 3 pending checks group
3 pending checks
Checks settings
pending checks
pending checks
ci/circleci: test
ci/circleci: test...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
70869
|
|
70870
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
[JY-20912] Fallback mechanism for users with active SF tokens for CRM Matching - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Service-Desk - Queues - Platform team - Service space - Jira
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20676 delete AJ reports related objects by LakyLak · Pull Request #12098 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST https://api.hubapi.com/crm/v3/objects/contact/search` resulted in a `429 Too Many Requests` response: {"status":"error","message":"You have reached your secondly limit.","errorType":"RATE_LIMIT
Jiminny
Jiminny...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
70870
|
|
74067
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
Pull requests · jiminny/app
Pull requests · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
Pull requests: jiminny/app
Pull requests: jiminny/app
Filters
Filters
is:open is:pr author:LakyLak
Labels 67
Labels
67
Milestones 1
Milestones
1
New pull request
New pull request
Clear current search query, filters, and sorts
Clear current search query, filters, and sorts
Select all issues
8 Open
8 Open
364 Closed
364 Closed
Author
Author
Label
Label
Projects
Projects
Milestones
Milestones
Reviews
Reviews
Assignee
Assignee
Sort
Sort
Pull requests list
Pull requests list
JY-20963 fix deleted object import
JY-20963 fix deleted object import
JY-20963 fix deleted object import
11 / 12 checks OK
#12121 opened
5 days ago
by
LakyLak
LakyLak
•
Review required before merging
Review required
4 comments
4
pipedrive offical SDK v2 POC
pipedrive offical SDK v2 POC
pipedrive offical SDK v2 POC
8 / 10 checks OK
#12090 opened
last week
by
LakyLak
LakyLak
•
Draft
Draft
Test hublets latency
Test hublets latency
Test hublets latency
22 / 23 checks OK
#11443 opened
on Dec 8, 2025
by
LakyLak
LakyLak
•
Draft
Draft
1 comment
1
JY-19501 webhook based opportunity sync
JY-19501 webhook based opportunity sync
JY-19501 webhook based opportunity sync
11 / 12 checks OK
#11327 opened
on Nov 10, 2025
by
LakyLak
LakyLak
•
Draft
Draft
9 comments
9
Jy 18908 streaming on chat abort
Jy 18908 streaming on chat abort
Jy 18908 streaming on chat abort
22 / 23 checks OK
#11197 opened
on Oct 13, 2025
by
LakyLak
LakyLak
•
Draft
Draft
1 comment
1
JY-18750 debug logs for OD data loading
JY-18750 debug logs for OD data loading
JY-18750 debug logs for OD data loading
24 / 25 checks OK
#11125 opened
on Sep 18, 2025
by
LakyLak
LakyLak
•
Draft
Draft
JY-17640 push data to Dynamics
JY-17640 push data to Dynamics
JY-17640 push data to Dynamics
11 / 12 checks OK
#10810 opened
on Jun 19, 2025
by
LakyLak
LakyLak
•
1 review approval
Approved
1 comment
1
JY-13692 add after parameter to opportunity sync for HS
JY-13692 add after parameter to opportunity sync for HS
JY-13692 add after parameter to opportunity sync for HS
#9246 opened
on Jul 9, 2024
by
LakyLak
LakyLak
•
Review required before merging
Review required
1 comment
1
ProTip!
Exclude your own issues with
-author:LakyLak
-author:LakyLak
.
Footer
Footer
GitHub Homepage
© 2026 GitHub, Inc.
Footer navigation
Footer navigation
Terms
Terms
Privacy
Privacy
Security
Security
Status
Status
Community
Community
Docs
Docs
Contact
Contact
Manage cookies
Do not share my personal information
Waiting for github.com…...
|
Firefox
|
Pull requests · jiminny/app — Work
|
github.com/jiminny/app/pull/12121
|
74067
|
|
74068
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Open
JY-20963 fix deleted object import #12121 LakyLak wants to merge 6 commits into master from JY-20963-fix-import-on-deleted-entity Copy head branch name to clipboard
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 5 days ago •
LakyLak
LakyLak
commented
5 days ago
5 days ago
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
5 days ago
5 days ago
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
79dc986
79dc986
@nikolay-yankov
nikolay-yankov
nikolay-yankov
force-pushed
force-pushed
the
JY-20963-fix-import-on-deleted-entity
branch 2 times, most recently from
86b558b
86b558b
to
79dc986
79dc986
Compare
Compare
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
d3de6e8
d3de6e8
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
74068
|
|
74069
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Open
JY-20963 fix deleted object import #12121 LakyLak wants to merge 6 commits into master from JY-20963-fix-import-on-deleted-entity Copy head branch name to clipboard
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 5 days ago •
LakyLak
LakyLak
commented
5 days ago
5 days ago
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
5 days ago
5 days ago
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
79dc986
79dc986
@nikolay-yankov
nikolay-yankov
nikolay-yankov
force-pushed
force-pushed
the
JY-20963-fix-import-on-deleted-entity
branch 2 times, most recently from
86b558b
86b558b
to
79dc986
79dc986
Compare
Compare
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
d3de6e8
d3de6e8
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@github-actions
Show options
github-actions Bot commented 5 days ago •
github-actions
github-actions
Bot
commented
5 days ago
5 days ago
•
edited
edited...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
74069
|
|
74070
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Open
JY-20963 fix deleted object import #12121 LakyLak wants to merge 6 commits into master from JY-20963-fix-import-on-deleted-entity Copy head branch name to clipboard
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 5 days ago •
LakyLak
LakyLak
commented
5 days ago
5 days ago
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
5 days ago
5 days ago
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
79dc986
79dc986
@nikolay-yankov
nikolay-yankov
nikolay-yankov
force-pushed
force-pushed
the
JY-20963-fix-import-on-deleted-entity
branch 2 times, most recently from
86b558b
86b558b
to
79dc986
79dc986
Compare
Compare
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
d3de6e8
d3de6e8
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@github-actions
Show options
github-actions Bot commented 5 days ago •
github-actions
github-actions
Bot
commented
5 days ago
5 days ago
•
edited
edited
Claude finished
@nikolay-yankov
@nikolay-yankov
's task in 3m 3s
——
View job
View job
📋
Jira:
JY-20963 — Fix foreign key violation when matching activities to deleted Salesforce opportunities
JY-20963 — Fix foreign key violation when matching activities to deleted Salesforce opportunities
Status:
In Dev
| Requirements were found in the Jira ticket and are included below.
🤖
Model:
claude-opus-4-7
Jira Ticket Requirements Coverage
Jira Ticket Requirements Coverage
Requirement
Status
Notes
Stop returning a freshly-deleted Opportunity from
importOpportunity
so callers don't FK-violate when setting
activity.opportunity_id
✅ Implemented
Returns
null
after
handleObjectDeletion
if the opportunity ended up trashed
Apply the same fix to similar methods (Lead, Account, Contact) as called out in the ticket
⚠️
Partial
Patched in
importLead
,
importContact
.
importAccount
was NOT touched
— same defect path still exists for Accounts
Avoid the restore → upsert → delete dance for already-deleted records (root cause described in ticket)
❌ Missing
The fix masks the symptom but leaves the wasted writes and the brief restored-then-deleted window in place
Cover the new behavior with unit tests (per CLAUDE.md)
❌ Missing
No tests added for the
IsDeleted = true
path returning null
Requirement
Stop returning a freshly-deleted Opportunity from
importOpportunity
so callers don't FK-violate when setting
activity.opportunity_id
Apply the same fix to similar methods (Lead, Account, Contact) as called out in the ticket
Avoid the restore → upsert → delete dance for already-deleted records (root cause described in ticket)
Cover the new behavior with unit tests (per CLAUDE.md)
Status
✅ Implemented
⚠️
Partial
❌ Missing
❌ Missing
Notes
Returns
null
after
handleObjectDeletion
if the opportunity ended up trashed
Patched in
importLead
,
importContact
.
importAccount
was NOT touched
— same defect path still exists for Accounts
The fix masks the symptom but leaves the wasted writes and the brief restored-then-deleted window in place
No tests added for the
IsDeleted = true
path returning null
Code Review
Code Review
🔴 Critical — null deref regression introduced in convertCrmData()
🔴 Critical — null deref regression introduced in
convertCrmData()
app/Services/Crm/Salesforce/Service.php:2582-2587
app/Services/Crm/Salesforce/Service.php:2582-2587
Changing
importContact
from
Contact
to
?Contact
broke an existing caller:
if
(
$
object
[
'
attributes
'...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
74070
|
|
74071
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Open
JY-20963 fix deleted object import #12121 LakyLak wants to merge 6 commits into master from JY-20963-fix-import-on-deleted-entity Copy head branch name to clipboard
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 5 days ago •
LakyLak
LakyLak
commented
5 days ago
5 days ago
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
5 days ago
5 days ago
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
79dc986
79dc986
@nikolay-yankov
nikolay-yankov
nikolay-yankov
force-pushed
force-pushed
the
JY-20963-fix-import-on-deleted-entity
branch 2 times, most recently from
86b558b
86b558b
to
79dc986
79dc986
Compare
Compare
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
d3de6e8
d3de6e8
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@github-actions
Show options
github-actions Bot commented 5 days ago •
github-actions
github-actions
Bot
commented
5 days ago
5 days ago
•
edited
edited
Claude finished
@nikolay-yankov
@nikolay-yankov
's task in 3m 3s
——
View job
View job
📋
Jira:
JY-20963 — Fix foreign key violation when matching activities to deleted Salesforce opportunities
JY-20963 — Fix foreign key violation when matching activities to deleted Salesforce opportunities
Status:
In Dev
| Requirements were found in the Jira ticket and are included below.
🤖
Model:
claude-opus-4-7
Jira Ticket Requirements Coverage
Jira Ticket Requirements Coverage
Requirement
Status
Notes
Stop returning a freshly-deleted Opportunity from
importOpportunity
so callers don't FK-violate when setting
activity.opportunity_id
✅ Implemented
Returns
null
after
handleObjectDeletion
if the opportunity ended up trashed
Apply the same fix to similar methods (Lead, Account, Contact) as called out in the ticket
⚠️
Partial
Patched in
importLead
,
importContact
.
importAccount
was NOT touched
— same defect path still exists for Accounts
Avoid the restore → upsert → delete dance for already-deleted records (root cause described in ticket)
❌ Missing
The fix masks the symptom but leaves the wasted writes and the brief restored-then-deleted window in place
Cover the new behavior with unit tests (per CLAUDE.md)
❌ Missing
No tests added for the
IsDeleted = true
path returning null
Requirement
Stop returning a freshly-deleted Opportunity from
importOpportunity
so callers don't FK-violate when setting
activity.opportunity_id
Apply the same fix to similar methods (Lead, Account, Contact) as called out in the ticket
Avoid the restore → upsert → delete dance for already-deleted records (root cause described in ticket)
Cover the new behavior with unit tests (per CLAUDE.md)
Status
✅ Implemented
⚠️
Partial
❌ Missing
❌ Missing
Notes
Returns
null
after
handleObjectDeletion
if the opportunity ended up trashed
Patched in
importLead
,
importContact
.
importAccount
was NOT touched
— same defect path still exists for Accounts
The fix masks the symptom but leaves the wasted writes and the brief restored-then-deleted window in place
No tests added for the
IsDeleted = true
path returning null
Code Review
Code Review
🔴 Critical — null deref regression introduced in convertCrmData()
🔴 Critical — null deref regression introduced in
convertCrmData()
app/Services/Crm/Salesforce/Service.php:2582-2587...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
74071
|
|
74072
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Open
JY-20963 fix deleted object import #12121 LakyLak wants to merge 6 commits into master from JY-20963-fix-import-on-deleted-entity Copy head branch name to clipboard
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 5 days ago •
LakyLak
LakyLak
commented
5 days ago
5 days ago
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
5 days ago
5 days ago
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
79dc986
79dc986
@nikolay-yankov
nikolay-yankov
nikolay-yankov
force-pushed
force-pushed
the
JY-20963-fix-import-on-deleted-entity
branch 2 times, most recently from
86b558b
86b558b
to
79dc986
79dc986
Compare
Compare
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
d3de6e8
d3de6e8
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@github-actions
Show options
github-actions Bot commented 5 days ago •
github-actions
github-actions
Bot
commented
5 days ago
5 days ago
•
edited
edited
Claude finished
@nikolay-yankov
@nikolay-yankov
's task in 3m 3s
——
View job
View job
📋
Jira:
JY-20963 — Fix foreign key violation when matching activities to deleted Salesforce opportunities
JY-20963 — Fix foreign key violation when matching activities to deleted Salesforce opportunities
Status:
In Dev
| Requirements were found in the Jira ticket and are included below.
🤖
Model:
claude-opus-4-7
Jira Ticket Requirements Coverage
Jira Ticket Requirements Coverage
Requirement
Status
Notes
Stop returning a freshly-deleted Opportunity from
importOpportunity
so callers don't FK-violate when setting
activity.opportunity_id
✅ Implemented
Returns
null
after
handleObjectDeletion
if the opportunity ended up trashed
Apply the same fix to similar methods (Lead, Account, Contact) as called out in the ticket
⚠️
Partial
Patched in
importLead
,
importContact
.
importAccount
was NOT touched
— same defect path still exists for Accounts
Avoid the restore → upsert → delete dance for already-deleted records (root cause described in ticket)
❌ Missing
The fix masks the symptom but leaves the wasted writes and the brief restored-then-deleted window in place
Cover the new behavior with unit tests (per CLAUDE.md)
❌ Missing
No tests added for the
IsDeleted = true
path returning null
Requirement
Stop returning a freshly-deleted Opportunity from
importOpportunity
so callers don't FK-violate when setting
activity.opportunity_id
Apply the same fix to similar methods (Lead, Account, Contact) as called out in the ticket
Avoid the restore → upsert → delete dance for already-deleted records (root cause described in ticket)
Cover the new behavior with unit tests (per CLAUDE.md)
Status
✅ Implemented
⚠️
Partial...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
74072
|
|
74073
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Open
JY-20963 fix deleted object import #12121 LakyLak wants to merge 6 commits into master from JY-20963-fix-import-on-deleted-entity Copy head branch name to clipboard
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 5 days ago •
LakyLak
LakyLak
commented
5 days ago
5 days ago
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
5 days ago
5 days ago
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
79dc986
79dc986
@nikolay-yankov
nikolay-yankov
nikolay-yankov
force-pushed
force-pushed
the
JY-20963-fix-import-on-deleted-entity
branch 2 times, most recently from
86b558b
86b558b
to
79dc986
79dc986
Compare
Compare
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
d3de6e8...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
74073
|
|
74074
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 5 days ago •
LakyLak
LakyLak
commented
5 days ago
5 days ago
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
5 days ago
5 days ago
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
79dc986
79dc986
@nikolay-yankov
nikolay-yankov
nikolay-yankov
force-pushed
force-pushed
the
JY-20963-fix-import-on-deleted-entity
branch 2 times, most recently from
86b558b
86b558b
to
79dc986
79dc986
Compare
Compare
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
d3de6e8
d3de6e8
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@github-actions
Show options
github-actions Bot commented 5 days ago •
github-actions
github-actions
Bot
commented
5 days ago
5 days ago
•
edited
edited
Claude finished
@nikolay-yankov
@nikolay-yankov
's task in 3m 3s
——
View job
View job
📋
Jira:
JY-20963 — Fix foreign key violation when matching activities to deleted Salesforce opportunities
JY-20963 — Fix foreign key violation when matching activities to deleted Salesforce opportunities
Status:
In Dev
| Requirements were found in the Jira ticket and are included below.
🤖
Model:
claude-opus-4-7
Jira Ticket Requirements Coverage
Jira Ticket Requirements Coverage
Requirement
Status
Notes
Stop returning a freshly-deleted Opportunity from
importOpportunity
so callers don't FK-violate when setting
activity.opportunity_id
✅ Implemented
Returns
null
after
handleObjectDeletion
if the opportunity ended up trashed
Apply the same fix to similar methods (Lead, Account, Contact) as called out in the ticket
⚠️
Partial
Patched in
importLead
,
importContact
.
importAccount
was NOT touched
— same defect path still exists for Accounts
Avoid the restore → upsert → delete dance for already-deleted records (root cause described in ticket)
❌ Missing
The fix masks the symptom but leaves the wasted writes and the brief restored-then-deleted window in place
Cover the new behavior with unit tests (per CLAUDE.md)
❌ Missing
No tests added for the
IsDeleted = true
path returning null
Requirement
Stop returning a freshly-deleted Opportunity from
importOpportunity
so callers don't FK-violate when setting
activity.opportunity_id
Apply the same fix to similar methods (Lead, Account, Contact) as called out in the ticket...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
74074
|
|
74075
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 5 days ago •
LakyLak
LakyLak
commented
5 days ago
5 days ago
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
5 days ago
5 days ago
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
79dc986
79dc986
@nikolay-yankov
nikolay-yankov
nikolay-yankov
force-pushed
force-pushed
the
JY-20963-fix-import-on-deleted-entity
branch 2 times, most recently from
86b558b
86b558b
to
79dc986
79dc986
Compare
Compare
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
d3de6e8
d3de6e8
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@github-actions
Show options
github-actions Bot commented 5 days ago •
github-actions
github-actions
Bot
commented
5 days ago
5 days ago
•
edited
edited
Claude finished
@nikolay-yankov
@nikolay-yankov
's task in 3m 3s
——
View job
View job
📋
Jira:
JY-20963 — Fix foreign key violation when matching activities to deleted Salesforce opportunities
JY-20963 — Fix foreign key violation when matching activities to deleted Salesforce opportunities
Status:
In Dev
| Requirements were found in the Jira ticket and are included below.
🤖
Model:
claude-opus-4-7
Jira Ticket Requirements Coverage
Jira Ticket Requirements Coverage
Requirement
Status
Notes
Stop returning a freshly-deleted Opportunity from
importOpportunity
so callers don't FK-violate when setting
activity.opportunity_id
✅ Implemented
Returns
null
after
handleObjectDeletion
if the opportunity ended up trashed
Apply the same fix to similar methods (Lead, Account, Contact) as called out in the ticket
⚠️
Partial
Patched in
importLead
,
importContact
.
importAccount
was NOT touched
— same defect path still exists for Accounts
Avoid the restore → upsert → delete dance for already-deleted records (root cause described in ticket)
❌ Missing
The fix masks the symptom but leaves the wasted writes and the brief restored-then-deleted window in place
Cover the new behavior with unit tests (per CLAUDE.md)
❌ Missing
No tests added for the
IsDeleted = true
path returning null
Requirement
Stop returning a freshly-deleted Opportunity from
importOpportunity
so callers don't FK-violate when setting
activity.opportunity_id
Apply the same fix to similar methods (Lead, Account, Contact) as called out in the ticket
Avoid the restore → upsert → delete dance for already-deleted records (root cause described in ticket)
Cover the new behavior with unit tests (per CLAUDE.md)
Status
✅ Implemented
⚠️
Partial
❌ Missing
❌ Missing
Notes
Returns
null
after
handleObjectDeletion
if the opportunity ended up trashed
Patched in
importLead
,
importContact
.
importAccount
was NOT touched
— same defect path still exists for Accounts
The fix masks the symptom but leaves the wasted writes and the brief restored-then-deleted window in place
No tests added for the
IsDeleted = true
path returning null...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
74075
|
|
77072
|
Platform Team - Backlog - Jira
[JY-20915] Add envi Platform Team - Backlog - Jira
[JY-20915] Add environment-specific email domains for text relay to prevent duplicate processing - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Text relay
TypeError: Jiminny\Services\Mail\TextRelayService::setHistoryPoint(): Argument #2 ($historyPoint) must be of type int, string given, called in /home/jiminny/app/Services/Mail/TextRelayService.php on line 118 — jiminny — app
TypeError: Jiminny\Services\Mail\TextRelayService::setHistoryPoint(): Argument #2 ($historyPoint) must be of type int, string given, called in /home/jiminny/app/Services/Mail/TextRelayService.php on line 118 — jiminny — app
CloudWatch | us-east-2
CloudWatch | us-east-2
JY-20915 fix strict casting by LakyLak · Pull Request #12134 · jiminny/app
JY-20915 fix strict casting by LakyLak · Pull Request #12134 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS]
Show options
LakyLak commented 5 days ago •
LakyLak
LakyLak
commented
5 days ago
5 days ago
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
5 days ago
5 days ago
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
79dc986
79dc986
@nikolay-yankov
nikolay-yankov
nikolay-yankov
force-pushed
force-pushed
the
JY-20963-fix-import-on-deleted-entity
branch 2 times, most recently from
86b558b
86b558b
to
79dc986
79dc986
Compare
Compare
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
77072
|
|
77073
|
Platform Team - Backlog - Jira
[JY-20915] Add envi Platform Team - Backlog - Jira
[JY-20915] Add environment-specific email domains for text relay to prevent duplicate processing - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Text relay
TypeError: Jiminny\Services\Mail\TextRelayService::setHistoryPoint(): Argument #2 ($historyPoint) must be of type int, string given, called in /home/jiminny/app/Services/Mail/TextRelayService.php on line 118 — jiminny — app
TypeError: Jiminny\Services\Mail\TextRelayService::setHistoryPoint(): Argument #2 ($historyPoint) must be of type int, string given, called in /home/jiminny/app/Services/Mail/TextRelayService.php on line 118 — jiminny — app
CloudWatch | us-east-2
CloudWatch | us-east-2
JY-20915 fix strict casting by LakyLak · Pull Request #12134 · jiminny/app
JY-20915 fix strict casting by LakyLak · Pull Request #12134 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS]
Show options
LakyLak commented 5 days ago •
LakyLak
LakyLak
commented
5 days ago
5 days ago
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
5 days ago
5 days ago
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
79dc986
79dc986
@nikolay-yankov
nikolay-yankov
nikolay-yankov
force-pushed
force-pushed
the
JY-20963-fix-import-on-deleted-entity
branch 2 times, most recently from
86b558b
86b558b
to
79dc986
79dc986
Compare
Compare
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
d3de6e8
d3de6e8
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@github-actions
Show options
github-actions Bot commented 5 days ago •
github-actions
github-actions
Bot
commented
5 days ago
5 days ago
•
edited
edited
Claude finished
@nikolay-yankov
@nikolay-yankov
's task in 3m 3s
——
View job
View job
📋
Jira:
JY-20963 — Fix foreign key violation when matching activities to deleted Salesforce opportunities
JY-20963 — Fix foreign key violation when matching activities to deleted Salesforce opportunities
Status:
In Dev
| Requirements were found in the Jira ticket and are included below.
🤖
Model:...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
77073
|
|
77074
|
Platform Team - Backlog - Jira
[JY-20915] Add envi Platform Team - Backlog - Jira
[JY-20915] Add environment-specific email domains for text relay to prevent duplicate processing - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Text relay
TypeError: Jiminny\Services\Mail\TextRelayService::setHistoryPoint(): Argument #2 ($historyPoint) must be of type int, string given, called in /home/jiminny/app/Services/Mail/TextRelayService.php on line 118 — jiminny — app
TypeError: Jiminny\Services\Mail\TextRelayService::setHistoryPoint(): Argument #2 ($historyPoint) must be of type int, string given, called in /home/jiminny/app/Services/Mail/TextRelayService.php on line 118 — jiminny — app
CloudWatch | us-east-2
CloudWatch | us-east-2
JY-20915 fix strict casting by LakyLak · Pull Request #12134 · jiminny/app
JY-20915 fix strict casting by LakyLak · Pull Request #12134 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS]
Show options
LakyLak commented 5 days ago •
LakyLak
LakyLak
commented
5 days ago
5 days ago
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
5 days ago
5 days ago
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
79dc986
79dc986
@nikolay-yankov
nikolay-yankov
nikolay-yankov
force-pushed
force-pushed
the
JY-20963-fix-import-on-deleted-entity
branch 2 times, most recently from
86b558b
86b558b
to
79dc986
79dc986
Compare
Compare
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
d3de6e8
d3de6e8
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@github-actions
Show options
github-actions Bot commented 5 days ago •
github-actions
github-actions
Bot
commented
5 days ago
5 days ago
•
edited
edited
Claude finished
@nikolay-yankov
@nikolay-yankov
's task in 3m 3s
——
View job...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
77074
|
|
77075
|
Platform Team - Backlog - Jira
[JY-20915] Add envi Platform Team - Backlog - Jira
[JY-20915] Add environment-specific email domains for text relay to prevent duplicate processing - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Text relay
TypeError: Jiminny\Services\Mail\TextRelayService::setHistoryPoint(): Argument #2 ($historyPoint) must be of type int, string given, called in /home/jiminny/app/Services/Mail/TextRelayService.php on line 118 — jiminny — app
TypeError: Jiminny\Services\Mail\TextRelayService::setHistoryPoint(): Argument #2 ($historyPoint) must be of type int, string given, called in /home/jiminny/app/Services/Mail/TextRelayService.php on line 118 — jiminny — app
CloudWatch | us-east-2
CloudWatch | us-east-2
JY-20915 fix strict casting by LakyLak · Pull Request #12134 · jiminny/app
JY-20915 fix strict casting by LakyLak · Pull Request #12134 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS]
Show options
LakyLak commented 5 days ago •
LakyLak
LakyLak
commented
5 days ago
5 days ago
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
5 days ago
5 days ago
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
79dc986
79dc986
@nikolay-yankov
nikolay-yankov
nikolay-yankov
force-pushed
force-pushed
the
JY-20963-fix-import-on-deleted-entity
branch 2 times, most recently from
86b558b
86b558b
to
79dc986
79dc986
Compare
Compare
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
d3de6e8
d3de6e8
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@github-actions
Show options
github-actions Bot commented 5 days ago •
github-actions
github-actions
Bot
commented
5 days ago
5 days ago
•
edited
edited
Claude finished
@nikolay-yankov
@nikolay-yankov
's task in 3m 3s
——
View job
View job
📋
Jira:
JY-20963 — Fix foreign key violation when matching activities to deleted Salesforce opportunities
JY-20963 — Fix foreign key violation when matching activities to deleted Salesforce opportunities
Status:
In Dev
| Requirements were found in the Jira ticket and are included below.
🤖
Model:
claude-opus-4-7
Jira Ticket Requirements Coverage
Jira Ticket Requirements Coverage...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
77075
|
|
77076
|
Platform Team - Backlog - Jira
[JY-20915] Add envi Platform Team - Backlog - Jira
[JY-20915] Add environment-specific email domains for text relay to prevent duplicate processing - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Text relay
TypeError: Jiminny\Services\Mail\TextRelayService::setHistoryPoint(): Argument #2 ($historyPoint) must be of type int, string given, called in /home/jiminny/app/Services/Mail/TextRelayService.php on line 118 — jiminny — app
TypeError: Jiminny\Services\Mail\TextRelayService::setHistoryPoint(): Argument #2 ($historyPoint) must be of type int, string given, called in /home/jiminny/app/Services/Mail/TextRelayService.php on line 118 — jiminny — app
CloudWatch | us-east-2
CloudWatch | us-east-2
JY-20915 fix strict casting by LakyLak · Pull Request #12134 · jiminny/app
JY-20915 fix strict casting by LakyLak · Pull Request #12134 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS]
Show options
LakyLak commented 5 days ago •
LakyLak
LakyLak
commented
5 days ago
5 days ago
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
5 days ago
5 days ago
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
79dc986
79dc986
@nikolay-yankov
nikolay-yankov
nikolay-yankov
force-pushed
force-pushed
the
JY-20963-fix-import-on-deleted-entity
branch 2 times, most recently from
86b558b
86b558b
to
79dc986
79dc986
Compare
Compare
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
d3de6e8
d3de6e8
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@github-actions
Show options
github-actions Bot commented 5 days ago •
github-actions
github-actions
Bot
commented
5 days ago
5 days ago
•
edited
edited
Claude finished
@nikolay-yankov
@nikolay-yankov
's task in 3m 3s
——
View job
View job
📋
Jira:
JY-20963 — Fix foreign key violation when matching activities to deleted Salesforce opportunities
JY-20963 — Fix foreign key violation when matching activities to deleted Salesforce opportunities
Status:
In Dev
| Requirements were found in the Jira ticket and are included below.
🤖
Model:
claude-opus-4-7
Jira Ticket Requirements Coverage
Jira Ticket Requirements Coverage
Requirement
Status
Notes
Stop returning a freshly-deleted Opportunity from
importOpportunity
so callers don't FK-violate when setting
activity.opportunity_id
✅ Implemented
Returns
null
after
handleObjectDeletion
if the opportunity ended up trashed
Apply the same fix to similar methods (Lead, Account, Contact) as called out in the ticket
⚠️
Partial
Patched in
importLead
,
importContact
.
importAccount
was NOT touched
— same defect path still exists for Accounts
Avoid the restore → upsert → delete dance for already-deleted records (root cause described in ticket)
❌ Missing
The fix masks the symptom but leaves the wasted writes and the brief restored-then-deleted window in place
Cover the new behavior with unit tests (per CLAUDE.md)
❌ Missing
No tests added for the
IsDeleted = true
path returning null
Requirement
Stop returning a freshly-deleted Opportunity from
importOpportunity
so callers don't FK-violate when setting
activity.opportunity_id
Apply the same fix to similar methods (Lead, Account, Contact) as called out in the ticket
Avoid the restore → upsert → delete dance for already-deleted records (root cause described in ticket)
Cover the new behavior with unit tests (per CLAUDE.md)
Status
✅ Implemented
⚠️
Partial
❌ Missing
❌ Missing
Notes
Returns
null
after...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
77076
|
|
77078
|
Platform Team - Backlog - Jira
[JY-20915] Add envi Platform Team - Backlog - Jira
[JY-20915] Add environment-specific email domains for text relay to prevent duplicate processing - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Text relay
TypeError: Jiminny\Services\Mail\TextRelayService::setHistoryPoint(): Argument #2 ($historyPoint) must be of type int, string given, called in /home/jiminny/app/Services/Mail/TextRelayService.php on line 118 — jiminny — app
TypeError: Jiminny\Services\Mail\TextRelayService::setHistoryPoint(): Argument #2 ($historyPoint) must be of type int, string given, called in /home/jiminny/app/Services/Mail/TextRelayService.php on line 118 — jiminny — app
CloudWatch | us-east-2
CloudWatch | us-east-2
JY-20915 fix strict casting by LakyLak · Pull Request #12134 · jiminny/app
JY-20915 fix strict casting by LakyLak · Pull Request #12134 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS]
Show options
LakyLak commented 5 days ago •
LakyLak
LakyLak
commented
5 days ago
5 days ago
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
5 days ago
5 days ago
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
79dc986
79dc986
@nikolay-yankov
nikolay-yankov
nikolay-yankov
force-pushed
force-pushed
the
JY-20963-fix-import-on-deleted-entity
branch 2 times, most recently from
86b558b
86b558b
to
79dc986
79dc986
Compare
Compare
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
d3de6e8
d3de6e8
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@github-actions
Show options
github-actions Bot commented 5 days ago •
github-actions
github-actions
Bot
commented
5 days ago
5 days ago
•
edited
edited
Claude finished
@nikolay-yankov
@nikolay-yankov
's task in 3m 3s
——
View job
View job
📋
Jira:
JY-20963 — Fix foreign key violation when matching activities to deleted Salesforce opportunities
JY-20963 — Fix foreign key violation when matching activities to deleted Salesforce opportunities
Status:
In Dev
| Requirements were found in the Jira ticket and are included below.
🤖
Model:
claude-opus-4-7
Jira Ticket Requirements Coverage
Jira Ticket Requirements Coverage
Requirement
Status
Notes
Stop returning a freshly-deleted Opportunity from
importOpportunity
so callers don't FK-violate when setting
activity.opportunity_id
✅ Implemented
Returns
null
after
handleObjectDeletion
if the opportunity ended up trashed
Apply the same fix to similar methods (Lead, Account, Contact) as called out in the ticket
⚠️
Partial
Patched in
importLead
,
importContact
.
importAccount
was NOT touched
— same defect path still exists for Accounts
Avoid the restore → upsert → delete dance for already-deleted records (root cause described in ticket)
❌ Missing
The fix masks the symptom but leaves the wasted writes and the brief restored-then-deleted window in place
Cover the new behavior with unit tests (per CLAUDE.md)
❌ Missing
No tests added for the
IsDeleted = true
path returning null
Requirement
Stop returning a freshly-deleted Opportunity from
importOpportunity
so callers don't FK-violate when setting
activity.opportunity_id
Apply the same fix to similar methods (Lead, Account, Contact) as called out in the ticket
Avoid the restore → upsert → delete dance for already-deleted records (root cause described in ticket)
Cover the new behavior with unit tests (per CLAUDE.md)
Status
✅ Implemented
⚠️
Partial
❌ Missing
❌ Missing
Notes
Returns
null
after
handleObjectDeletion
if the opportunity ended up trashed
Patched in
importLead
,
importContact
.
importAccount
was NOT touched
— same defect path still exists for Accounts
The fix masks the symptom but leaves the wasted writes and the brief restored-then-deleted window in place
No tests added for the
IsDeleted = true
path returning null
Code Review
Code Review
🔴 Critical — null deref regression introduced in convertCrmData()
🔴 Critical — null deref regression introduced in
convertCrmData()
app/Services/Crm/Salesforce/Service.php:2582-2587
app/Services/Crm/Salesforce/Service.php:2582-2587
Changing
importContact
from
Contact
to
?Contact
broke an existing caller:
if
(
$
object
[
'
attributes
'
][
'
type
'
] ===
'
Contact
'
) {
$
contact
=
$
this
->
importContact
(
$
object
);
$
account
=
$
contact
->
account
;
// ❌ "Attempt to read property 'account' on null"
}
Copy code to clipboard
This is on the exact code path the ticket is trying to harden — when Salesforce returns
IsDeleted = true
for a contact,
importContact
now returns null and the very next line fatals.
Fix this →
Fix this →
Same hazard, lower severity, in
ActivityController.php:370-374
ActivityController.php:370-374
:
syncContact()
can now return null and is passed straight into
resolveAccount(Team, Contact, ...)
which type-hints non-nullable
Contact
. Triggers a
TypeError
on the deleted-contact path.
🟡 Scope — importAccount left out
🟡 Scope —
importAccount
left out
app/Services/Crm/Salesforce/Service.php:1153-1225
app/Services/Crm/Salesforce/Service.php:1153-1225
The ticket explicitly names Account as one of the affected methods.
importAccount
still returns the just-deleted Account, so the same
account_id
FK violation can occur on the
Contact → Account
and
Account
import paths. Either apply the same guard, or note in the PR description why Account is exempt.
🟡 Approach — fix the symptom or the cause?
🟡 Approach — fix the symptom or the cause?
Even on the happy path the current sequence does three writes for an object Salesforce told us is dead:
restoreAnyTrashedEntity()
undeletes it
updateOrCreate()
writes all fields
handleObjectDeletion()
deletes it again
An early short-circuit when
IsDeleted === true
would (a) eliminate the wasted writes, (b) close the tiny window where the row is restored and visible to other queries, (c) eliminate the need for
if ($entity->trashed()) return null;
blocks entirely, and (d) cover all four import* methods uniformly. Something like:
if
(!
empty
(
$
crmData
[
'
IsDeleted
'
])) {
$
this
->
handleEntityDeletionByProviderId
(
$
this
->
config
->
opportunities
(),
$
crmData...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
77078
|
|
77079
|
Platform Team - Backlog - Jira
[JY-20915] Add envi Platform Team - Backlog - Jira
[JY-20915] Add environment-specific email domains for text relay to prevent duplicate processing - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Text relay
TypeError: Jiminny\Services\Mail\TextRelayService::setHistoryPoint(): Argument #2 ($historyPoint) must be of type int, string given, called in /home/jiminny/app/Services/Mail/TextRelayService.php on line 118 — jiminny — app
TypeError: Jiminny\Services\Mail\TextRelayService::setHistoryPoint(): Argument #2 ($historyPoint) must be of type int, string given, called in /home/jiminny/app/Services/Mail/TextRelayService.php on line 118 — jiminny — app
CloudWatch | us-east-2
CloudWatch | us-east-2
JY-20915 fix strict casting by LakyLak · Pull Request #12134 · jiminny/app
JY-20915 fix strict casting by LakyLak · Pull Request #12134 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS]
Show options
LakyLak commented 5 days ago •
LakyLak
LakyLak
commented
5 days ago
5 days ago
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
5 days ago
5 days ago
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
79dc986
79dc986
@nikolay-yankov
nikolay-yankov
nikolay-yankov
force-pushed
force-pushed
the
JY-20963-fix-import-on-deleted-entity
branch 2 times, most recently from
86b558b
86b558b
to
79dc986
79dc986
Compare
Compare
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
d3de6e8
d3de6e8
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@github-actions
Show options
github-actions Bot commented 5 days ago •
github-actions
github-actions
Bot
commented
5 days ago
5 days ago
•
edited
edited
Claude finished
@nikolay-yankov
@nikolay-yankov
's task in 3m 3s
——
View job
View job
📋
Jira:
JY-20963 — Fix foreign key violation when matching activities to deleted Salesforce opportunities
JY-20963 — Fix foreign key violation when matching activities to deleted Salesforce opportunities
Status:
In Dev
| Requirements were found in the Jira ticket and are included below.
🤖
Model:
claude-opus-4-7
Jira Ticket Requirements Coverage
Jira Ticket Requirements Coverage
Requirement
Status
Notes
Stop returning a freshly-deleted Opportunity from
importOpportunity
so callers don't FK-violate when setting
activity.opportunity_id
✅ Implemented
Returns
null
after
handleObjectDeletion
if the opportunity ended up trashed
Apply the same fix to similar methods (Lead, Account, Contact) as called out in the ticket
⚠️
Partial
Patched in
importLead
,
importContact
.
importAccount
was NOT touched
— same defect path still exists for Accounts
Avoid the restore → upsert → delete dance for already-deleted records (root cause described in ticket)
❌ Missing
The fix masks the symptom but leaves the wasted writes and the brief restored-then-deleted window in place
Cover the new behavior with unit tests (per CLAUDE.md)
❌ Missing
No tests added for the
IsDeleted = true
path returning null
Requirement
Stop returning a freshly-deleted Opportunity from
importOpportunity
so callers don't FK-violate when setting
activity.opportunity_id
Apply the same fix to similar methods (Lead, Account, Contact) as called out in the ticket
Avoid the restore → upsert → delete dance for already-deleted records (root cause described in ticket)
Cover the new behavior with unit tests (per CLAUDE.md)
Status
✅ Implemented
⚠️
Partial
❌ Missing
❌ Missing
Notes
Returns
null
after
handleObjectDeletion
if the opportunity ended up trashed
Patched in
importLead
,
importContact
.
importAccount
was NOT touched
— same defect path still exists for Accounts
The fix masks the symptom but leaves the wasted writes and the brief restored-then-deleted window in place
No tests added for the
IsDeleted = true
path returning null
Code Review
Code Review
🔴 Critical — null deref regression introduced in convertCrmData()
🔴 Critical — null deref regression introduced in
convertCrmData()
app/Services/Crm/Salesforce/Service.php:2582-2587
app/Services/Crm/Salesforce/Service.php:2582-2587
Changing
importContact
from
Contact
to
?Contact
broke an existing caller:
if
(
$
object
[
'
attributes
'
][
'
type
'
] ===
'
Contact
'
) {
$
contact
=
$
this
->
importContact
(
$
object
);
$
account
=
$
contact
->
account
;
// ❌ "Attempt to read property 'account' on null"
}
Copy code to clipboard
This is on the exact code path the ticket is trying to harden — when Salesforce returns
IsDeleted = true
for a contact,
importContact
now returns null and the very next line fatals.
Fix this →
Fix this →
Same hazard, lower severity, in
ActivityController.php:370-374
ActivityController.php:370-374
:
syncContact()
can now return null and is passed straight into
resolveAccount(Team, Contact, ...)
which type-hints non-nullable
Contact
. Triggers a
TypeError
on the deleted-contact path.
🟡 Scope — importAccount left out
🟡 Scope —
importAccount
left out
app/Services/Crm/Salesforce/Service.php:1153-1225
app/Services/Crm/Salesforce/Service.php:1153-1225
The ticket explicitly names Account as one of the affected methods.
importAccount
still returns the just-deleted Account, so the same
account_id
FK violation can occur on the
Contact → Account
and
Account
import paths. Either apply the same guard, or note in the PR description why Account is exempt.
🟡 Approach — fix the symptom or the cause?
🟡 Approach — fix the symptom or the cause?
Even on the happy path the current sequence does three writes for an object Salesforce told us is dead:
restoreAnyTrashedEntity()
undeletes it
updateOrCreate()
writes all fields
handleObjectDeletion()
deletes it again
An early short-circuit when
IsDeleted === true
would (a) eliminate the wasted writes, (b) close the tiny window where the row is restored and visible to other queries, (c) eliminate the need for
if ($entity->trashed()) return null;
blocks entirely, and (d) cover all four import* methods uniformly. Something like:
if...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
77079
|
|
77080
|
Platform Team - Backlog - Jira
[JY-20915] Add envi Platform Team - Backlog - Jira
[JY-20915] Add environment-specific email domains for text relay to prevent duplicate processing - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Text relay
TypeError: Jiminny\Services\Mail\TextRelayService::setHistoryPoint(): Argument #2 ($historyPoint) must be of type int, string given, called in /home/jiminny/app/Services/Mail/TextRelayService.php on line 118 — jiminny — app
TypeError: Jiminny\Services\Mail\TextRelayService::setHistoryPoint(): Argument #2 ($historyPoint) must be of type int, string given, called in /home/jiminny/app/Services/Mail/TextRelayService.php on line 118 — jiminny — app
CloudWatch | us-east-2
CloudWatch | us-east-2
JY-20915 fix strict casting by LakyLak · Pull Request #12134 · jiminny/app
JY-20915 fix strict casting by LakyLak · Pull Request #12134 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS]
Show options
LakyLak commented 5 days ago •
LakyLak
LakyLak
commented
5 days ago
5 days ago
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
5 days ago
5 days ago
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
79dc986
79dc986
@nikolay-yankov
nikolay-yankov
nikolay-yankov
force-pushed
force-pushed
the
JY-20963-fix-import-on-deleted-entity
branch 2 times, most recently from
86b558b
86b558b
to
79dc986
79dc986
Compare
Compare
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
77080
|
|
77081
|
Platform Team - Backlog - Jira
[JY-20915] Add envi Platform Team - Backlog - Jira
[JY-20915] Add environment-specific email domains for text relay to prevent duplicate processing - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Text relay
TypeError: Jiminny\Services\Mail\TextRelayService::setHistoryPoint(): Argument #2 ($historyPoint) must be of type int, string given, called in /home/jiminny/app/Services/Mail/TextRelayService.php on line 118 — jiminny — app
TypeError: Jiminny\Services\Mail\TextRelayService::setHistoryPoint(): Argument #2 ($historyPoint) must be of type int, string given, called in /home/jiminny/app/Services/Mail/TextRelayService.php on line 118 — jiminny — app
CloudWatch | us-east-2
CloudWatch | us-east-2
JY-20915 fix strict casting by LakyLak · Pull Request #12134 · jiminny/app
JY-20915 fix strict casting by LakyLak · Pull Request #12134 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS]
Show options
LakyLak commented 5 days ago •
LakyLak
LakyLak
commented
5 days ago
5 days ago
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
5 days ago
5 days ago
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
79dc986
79dc986
@nikolay-yankov
nikolay-yankov
nikolay-yankov
force-pushed
force-pushed
the
JY-20963-fix-import-on-deleted-entity
branch 2 times, most recently from
86b558b
86b558b
to
79dc986
79dc986
Compare
Compare
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
d3de6e8
d3de6e8
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@github-actions
Show options
github-actions Bot commented 5 days ago •
github-actions
github-actions
Bot
commented
5 days ago
5 days ago
•
edited
edited
Claude finished
@nikolay-yankov
@nikolay-yankov
's task in 3m 3s
——
View job
View job
📋
Jira:
JY-20963 — Fix foreign key violation when matching activities to deleted Salesforce opportunities
JY-20963 — Fix foreign key violation when matching activities to deleted Salesforce opportunities
Status:
In Dev
| Requirements were found in the Jira ticket and are included below.
🤖
Model:
claude-opus-4-7
Jira Ticket Requirements Coverage
Jira Ticket Requirements Coverage
Requirement
Status
Notes
Stop returning a freshly-deleted Opportunity from
importOpportunity
so callers don't FK-violate when setting
activity.opportunity_id
✅ Implemented
Returns
null
after
handleObjectDeletion
if the opportunity ended up trashed
Apply the same fix to similar methods (Lead, Account, Contact) as called out in the ticket
⚠️
Partial
Patched in
importLead
,
importContact
.
importAccount
was NOT touched
— same defect path still exists for Accounts
Avoid the restore → upsert → delete dance for already-deleted records (root cause described in ticket)
❌ Missing
The fix masks the symptom but leaves the wasted writes and the brief restored-then-deleted window in place
Cover the new behavior with unit tests (per CLAUDE.md)
❌ Missing
No tests added for the
IsDeleted = true
path returning null
Requirement
Stop returning a freshly-deleted Opportunity from
importOpportunity
so callers don't FK-violate when setting
activity.opportunity_id
Apply the same fix to similar methods (Lead, Account, Contact) as called out in the ticket
Avoid the restore → upsert → delete dance for already-deleted records (root cause described in ticket)
Cover the new behavior with unit tests (per CLAUDE.md)
Status
✅ Implemented
⚠️
Partial
❌ Missing
❌ Missing
Notes
Returns
null
after
handleObjectDeletion
if the opportunity ended up trashed
Patched in
importLead
,
importContact
.
importAccount
was NOT touched
— same defect path still exists for Accounts
The fix masks the symptom but leaves the wasted writes and the brief restored-then-deleted window in place
No tests added for the
IsDeleted = true
path returning null
Code Review
Code Review
🔴 Critical — null deref regression introduced in convertCrmData()
🔴 Critical — null deref regression introduced in
convertCrmData()
app/Services/Crm/Salesforce/Service.php:2582-2587
app/Services/Crm/Salesforce/Service.php:2582-2587
Changing
importContact
from
Contact
to
?Contact
broke an existing caller:
if
(
$
object
[
'
attributes
'
][
'
type
'
] ===
'
Contact
'
) {
$
contact
=
$
this
->
importContact
(
$
object
);
$
account
=
$
contact
->
account
;
// ❌ "Attempt to read property 'account' on null"
}
Copy code to clipboard
This is on the exact code path the ticket is trying to harden — when Salesforce returns
IsDeleted = true
for a contact,
importContact
now returns null and the very next line fatals.
Fix this →
Fix this →
Same hazard, lower severity, in
ActivityController.php:370-374
ActivityController.php:370-374
:
syncContact()
can now return null and is passed straight into
resolveAccount(Team, Contact, ...)
which type-hints non-nullable
Contact
. Triggers a
TypeError
on the deleted-contact path.
🟡 Scope — importAccount left out
🟡 Scope —
importAccount
left out
app/Services/Crm/Salesforce/Service.php:1153-1225
app/Services/Crm/Salesforce/Service.php:1153-1225
The ticket explicitly names Account as one of the affected methods.
importAccount
still returns the just-deleted Account, so the same
account_id
FK violation can occur on the
Contact → Account
and
Account
import paths. Either apply the same guard, or note in the PR description why Account is exempt.
🟡 Approach — fix the symptom or the cause?
🟡 Approach — fix the symptom or the cause?
Even on the happy path the current sequence does three writes for an object Salesforce told us is dead:
restoreAnyTrashedEntity()
undeletes it
updateOrCreate()
writes all fields
handleObjectDeletion()
deletes it again
An early short-circuit when
IsDeleted === true
would (a) eliminate the wasted writes, (b) close the tiny window where the row is restored and visible to other queries, (c) eliminate the need for
if ($entity->trashed()) return null;
blocks entirely, and (d) cover all four import* methods uniformly. Something like:
if
(!
empty
(
$
crmData
[
'
IsDeleted...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
77081
|
|
77082
|
Platform Team - Backlog - Jira
[JY-20915] Add envi Platform Team - Backlog - Jira
[JY-20915] Add environment-specific email domains for text relay to prevent duplicate processing - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Text relay
TypeError: Jiminny\Services\Mail\TextRelayService::setHistoryPoint(): Argument #2 ($historyPoint) must be of type int, string given, called in /home/jiminny/app/Services/Mail/TextRelayService.php on line 118 — jiminny — app
TypeError: Jiminny\Services\Mail\TextRelayService::setHistoryPoint(): Argument #2 ($historyPoint) must be of type int, string given, called in /home/jiminny/app/Services/Mail/TextRelayService.php on line 118 — jiminny — app
CloudWatch | us-east-2
CloudWatch | us-east-2
JY-20915 fix strict casting by LakyLak · Pull Request #12134 · jiminny/app
JY-20915 fix strict casting by LakyLak · Pull Request #12134 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS]
Show options
LakyLak commented 5 days ago •
LakyLak
LakyLak
commented
5 days ago
5 days ago
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
5 days ago
5 days ago
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
79dc986
79dc986
@nikolay-yankov
nikolay-yankov
nikolay-yankov
force-pushed
force-pushed
the
JY-20963-fix-import-on-deleted-entity
branch 2 times, most recently from
86b558b
86b558b
to
79dc986
79dc986
Compare
Compare
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
nikolay-yankov
nikolay-yankov
deleted a comment from
github-actions
github-actions
Bot
5 days ago
5 days ago
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
d3de6e8
d3de6e8
@nikolay-yankov
Show options
nikolay-yankov commented 5 days ago
nikolay-yankov
nikolay-yankov
commented
5 days ago
5 days ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@github-actions
Show options
github-actions Bot commented 5 days ago •
github-actions
github-actions
Bot
commented
5 days ago
5 days ago
•
edited
edited
Claude finished
@nikolay-yankov
@nikolay-yankov
's task in 3m 3s
——
View job
View job
📋
Jira:
JY-20963 — Fix foreign key violation when matching activities to deleted Salesforce opportunities
JY-20963 — Fix foreign key violation when matching activities to deleted Salesforce opportunities
Status:
In Dev
| Requirements were found in the Jira ticket and are included below.
🤖
Model:
claude-opus-4-7
Jira Ticket Requirements Coverage
Jira Ticket Requirements Coverage
Requirement
Status
Notes
Stop returning a freshly-deleted Opportunity from
importOpportunity
so callers don't FK-violate when setting
activity.opportunity_id
✅ Implemented
Returns
null
after
handleObjectDeletion
if the opportunity ended up trashed
Apply the same fix to similar methods (Lead, Account, Contact) as called out in the ticket
⚠️
Partial
Patched in
importLead
,
importContact
.
importAccount
was NOT touched
— same defect path still exists for Accounts
Avoid the restore → upsert → delete dance for already-deleted records (root cause described in ticket)
❌ Missing
The fix masks the symptom but leaves the wasted writes and the brief restored-then-deleted window in place
Cover the new behavior with unit tests (per CLAUDE.md)
❌ Missing
No tests added for the
IsDeleted = true
path returning null
Requirement
Stop returning a freshly-deleted Opportunity from
importOpportunity
so callers don't FK-violate when setting
activity.opportunity_id
Apply the same fix to similar methods (Lead, Account, Contact) as called out in the ticket
Avoid the restore → upsert → delete dance for already-deleted records (root cause described in ticket)
Cover the new behavior with unit tests (per CLAUDE.md)
Status
✅ Implemented
⚠️
Partial
❌ Missing
❌ Missing
Notes
Returns
null
after
handleObjectDeletion
if the opportunity ended up trashed
Patched in
importLead
,
importContact
.
importAccount
was NOT touched
— same defect path still exists for Accounts
The fix masks the symptom but leaves the wasted writes and the brief restored-then-deleted window in place
No tests added for the
IsDeleted = true
path returning null
Code Review
Code Review
🔴 Critical — null deref regression introduced in convertCrmData()
🔴 Critical — null deref regression introduced in
convertCrmData()
app/Services/Crm/Salesforce/Service.php:2582-2587
app/Services/Crm/Salesforce/Service.php:2582-2587
Changing
importContact
from
Contact
to
?Contact
broke an existing caller:
if
(
$
object...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
77082
|
|
82148
|
iTerm2ShellEditViewSessionScriptsProfilesWindowHel iTerm2ShellEditViewSessionScriptsProfilesWindowHelp-zshDOCKER881DEV (-zsh)O 82tests/Unit/Policies/CanAccessAiReportsTest.php-zshN3screenpipe"84-zshno changes addedto commit (use "git add"and/or "git commit -a")lukas@Lukas-Kovaliks-MacBook-Pro-Jiminny~/jiminny/app (master) $ git pullremote:Enumerating objects: 3114,done.remote: Counting objects: 100% (2026/2026),done.remote: Compressing objects: 100% (676/676),done.remote: Total 1678 (delta 1255), reused 1328 (delta 974), pack-reused 0 (from 0)Receiving objects: 100% (1678/1678), 260.56 KiB | 1.33 MiB/s, done.Resolving deltas: 100% (1255/1255), completed with 182 local objects.From github.com:jiminny/app828865edeb..96465d0b0bmaster8fafc5d81d..04a1cdf13aJY-20606-desktop-app-recall+ 724040d8bf...ffebe9bale JY-20741-user-can-log-in-access-the-desktop-app* [new branch]+ 145d59435f...346478f081JY-20771-call-scoring-filter-for-exec-reportsJY-20828-user-can-manage-desktop-recording-permissions+ 5428ec3836...a112445df0 JY-20853-mcp-seach_callseb199eee57..6119438d56JY-20910-schedule-parallel-update-target-processingUpdating 828865edeb..96465d0b0bFast-forwardapp/Component/ActionItems/Services/ActionItemsIndexingService.phpapp/Component/ES/Repositories/EsResetActivityRepository.phpapp/Component/KeyPoints/Services/KeyPointsIndexingService.phpapp/Component/TranscriptionSummary/Services/GetTranscriptionSummaryService.phpapp/Component/TranscriptionSummary/Services/TranscriptionSummaryIndexingService.phpapp/Models/Activity/Moment.phpapp/Models/Activity/Note.php1 41++++++++++++*3+++1 481402116app/Models/CommentAbstract.phpapp/Models/Crm/FieldData.phpapp/Models/ElasticSearch/ActivityElasticSearchTrait.php51app/Models/Participant.phpapp/Traits/RequiresUUID.phpscripts/run_command_stagetests/Unit/Component/ActionItems/Services/ActionItemsIndexingServiceTest.phptests/Unit/Component/KeyPoints/Services/GetKeyPointsServiceTest.phptests/Unit/Component/KeyPoints/Services/KeyPointsIndexingServiceTest.phptests/Unit/Component/TranscriptionSummary/Services/TranscriptionSummaryIndexingServiceTest.php7134697617 files changed, 472 insertions(+), 22 deletions(-)create mode 100644 app/Component/ActionItems/Services/ActionItemsIndexingService.phpcreate mode 100644 app/Component/KeyPoints/Services/KeyPointsIndexingService.phpcreate mode 100644 app/Component/TranscriptionSummary/Services/TranscriptionSummaryIndexingService.phpcreate mode 100644 tests/Unit/Component/ActionItems/Services/ActionItemsIndexingServiceTest.phpcreate mode 100644 tests/Unit/Component/KeyPoints/Services/KeyPointsIndexingServiceTest.phpcreate mode 100644 tests/Unit/Component/TranscriptionSummary/Services/TranscriptionSummaryIndexingServiceTest.phpukas@Lukas-Kovaliks-MacBook-Pro-Jiminny ~/jiminny/app (master) $ DX5ec2-user@ip-10-30-1...100% <78• Thu 28 May 12:17:59181O ₴6ec2-user@ip-10-30-140-...₴7-> origin/master-> origin/JY-20606-desktop-app-recall-› origin/JY-20741-user-can-log-in-access-the-desktop-app(forced update)origin/JY-20771-call-scoring-filter-for-exec-reports-> origin/JY-20828-user-can-manage-desktop-recording-permissions (forced update)-› origin/JY-20853-mcp-seach_calls(forced update)-> origin/JY-20910-schedule-parallel-update-target-processing...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
82148
|
|
82149
|
rircroxhsttonooonnsrnroie.WindowHelpapp.logrocket. rircroxhsttonooonnsrnroie.WindowHelpapp.logrocket.com/ponxaf/platform-production/s/6-019c69c6-70d1-7ad6-a716-169a3efeee17/0?dashboardID=NaN&filterintent=%2578%2522type%2522%253A%2522all%2522%252C%25%Thu 28 May 12:17:59%2522%253A%2522session%2522%252C%2522type%2522%253A%2522email%2522%252C%2522v.Pipelines - jiminny/app0.52ml221ml(JY-20613) Allow owner's role to bFeed - jminny - SentryACoswchus-euskecloudWatchus-cast-zCloudWntch luseonst.2JY-20915 fx missing header by1y-20963 fix deletod obicct in200•200•200• 200•200•200•200O200• 200©260riefk. Pr Becert e12121- limhoutnorncopssreppo nnhy.con vor assooorsssoeroon toanto wlckoroencops/leppoahnhy.conwuorassororsssoe/oon toanto cowoi.chwrops.//oppoanhhy.con/wuo-ossor/ssseo/[URL_WITH_CREDENTIALS] 04/02/002M/D8271360272a76dacl: : ["Event recd",(*event":*pusher_internal:subscription_succeeded*, "channel":*private-user.72c175c3-c33f-46c5-982d-db5740f39093*, "data":())].TENACtthoAkeAArSuathelcAr.T0AS2RARCAO0C-A6OK.0904-4667/0610408 the AiboRse,Kenekankon Sinnonanan)Ctees fhnns sesleoreLEGISTER_FILTER_VALUE", payload: Cbject)*Undefined key BRANCHobfect {type-filters/SET_DATEPICKER_OPTIONS", payload: Cbject)Cbfect (type: *filters/SET_SEQUENCE_NUMBER", payload: 19)conectbype:conertwoe:#ltersRPRIMNPROCRLoso3yloadguesôtAMM970S14-13:44390...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
82149
|
|
83188
|
FirefoxViewhsttonooountrnPotLe.ToolsWVindownel:m.a FirefoxViewhsttonooountrnPotLe.ToolsWVindownel:m.awasson.neutolbcrviceocskforolcoo oror cucues custom s/oho"ooo0) JIMINNYPipelines - jiminny/app* (JY-20613) Allow owner's role to tText relayFeed - jiminny - Sentrya CloudWatch | su-weste1JY-20915 fic missing header by LJY-20963 fix deleted object impor• Login | SalesforcelimnasxceotionslEmailActivitytrM Inbox (1,732) - lukas.kovalic@jiminR (JY-20979) Resoive PHP 8.5.5 depmlimiomPlattorm Sprint 5 Q2 - Platform Te8 Jiminy** (SRD-6881) (0n demand) Transe8 Sona Subramanian at 27/05/20218 Illyana Netseva at 27/05/2026, 18a Jiminm.+ New TabQ Search< Back0 SRD-6881[On demand] Transcription in saved search disappears@ Link work itemAdd form& Add designCreatevIliyana Netseva ralsed this request via JiraMam request in portalHide detailsDescriptionI have tested the nudges (saved searches) with a word in the transcription field and the word disappears every time on EU, and a user has reported the same on US:the user session: [ LogRocketHere is a link to my session: [ LogRocketData CenteusSteps to reproduce1. open Jiminny on EU2. Create a search with a word in the transcript field3. Save the search and create a nuage.4. Ooen something else and then return to the search, the wordCustomer typeSMBActual outcomeThe word disappearsExpected outcomeThe word in the transcript field should appear when opening an already saved search with it.Severity levelS2ImpacNonekoot causcNoneACtvItVWork1oeApprovalso Summarise comments =Add internal note / Reolv to customenePro tip: press M to commen.100% K52 8 • Thu 28 May 13:12:42O ASK ROVO A ® $+ Create1Analyzing~ DetailsAssigneeReporterRequest TypeKnowledge basePriority levelDev TeamCanny Links® Lukas Kovalik@ Illyana Netseva• Reporta bugE View related articlesP2 MediumPlatform teamOpen Canny Links> More fields Labels, Time tracking, Type of InfoSec incident, Components (InfoSec), Client, Alfected u...> Automation 4 Rule executions> featureOS = Open featureos~ IntercomShowing 1 out of 1 linked conversations& Sona Subramanian..>> Sentry Sll Linked IssuesCreated 17 hours agoUpdated 3 hours ago@ Configure...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
83188
|
|
83189
|
Platform Sprint 5 Q2 - Platform Team - Scrum Board Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
BE upgrade libraries
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Text relay
Feed — jiminny — Sentry
Feed — jiminny — Sentry
CloudWatch | eu-west-1
CloudWatch | eu-west-1
JY-20915 fix missing header by LakyLak · Pull Request #12136 · jiminny/app
JY-20915 fix missing header by LakyLak · Pull Request #12136 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
83189
|
|
83190
|
Platform Sprint 5 Q2 - Platform Team - Scrum Board Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
SlackFileEditViewGoHistoryWindowHelpDOCKERDOCKER (-zsh)2c55fe91ca4148a230e32eadocker_lamp_12026] No failed transcriptidocker_lamp_18? Stadocker_lamp_1205 Ddocker_lamp_1roc/1/fd/1'2>&1docker_lamp_12026ONEdocker_lamp_1Gracefully Stopping...Container docker-blackfContainer docker-mariadContainer kibanaStoppiContainer docker_lamp_1Container docker-jiminnContainer ngrok StoppinContainer docker-datadoContainer docker-datadoContainer docker-blackfContainer kibana StoppeContainer elasticsearchContainer docker-jiminnContainer elasticsearchmariadb-11 2026-0ownngrokpReq="{err: ‹nil>mariadb-1ngrokt=2026restar2026-0t=2026on err=nilngrokt=2026f0743derr="reconnectinContainer docker_lamp_1Container ngrokError EContainer docker-mariadunexpected EOFerror during connect: Painers/ala97af7b5a28480What's next:Debug this Composelukas@Lukas-Kovaliks-Mav ALL VAULTS8My vaultExported88All items* FavouritesBinTYPESLoginCardIdentitySecure noteSSH keyFOLDERS+2FADCSV Import 28.01.22LastPass Import 1.11.21NAS UsersSalesloftStarter KitNo folderCOLLECTIONSPersonal collectionMy vaultSendQ [URL_WITH_CREDENTIALS] mJ2STigExRjaUT^BoFy8NFEDOhttps://blog.whitelabeltechnologies....J2STigExRjaUT^BoFy8NFEDOhttps://www.rescuetime.com/log..XDLHx3m/Vangseyhttps://www.rescuetime.com/login?…https://www.outsourcely.com/log..mLkl1230Shttps://www.outsourcely.com/login/Lkl1230Shttps://www.martinus.sk/login/?r..mLkl123Mhttps://www.martinus.sk/login/?redi..Lk/123Mhttps://www.jefit.com/login/m141122+HomeDMsActivityFilesLater...More+→Jiminny ...# infra-changes# infrastructure_dev# jbu-team-info# jiminny-bg# platform-team# platform-tickets# product_launches# random# releases# support# thank-yous# the_people_of jimi...° Direct messages. Stoyan TomovLo lliyana Netseva€ Vasil Vasilev& Petko Kashinski®. Galya Dimitrova8. Stefka Stoyanova%: Todor Stamatov&. Steliyan GeorgievC. Ves(8. MiraR. Nikolay Yankovdo James GrahamLukas Kovalik y... OApps100% CThu 28 May 13:12:42Describe what you are looking forStoyan Tomov• Messagest Add canvasO FilesMorev+сега погледFriday, May 22nd ~Lukas Kovalik 2:48 PMдаже не знаех че мога на prodStoyan Tomov 2:48 PMто се е ъпдейтнал lead-а в базата на моментаLukas Kovalik 3:25 PMда, има грешкав понеделник ще я деплойнаStoyan Tomov 3:31 PMdobreToday ~Lukas Kovalik 1:00 PMздрасти (edited)случайно да знеаш как работи днес ИлиянаStoyan Tomov 1:09 PMЗдрастиОт 3 часа е тяLukas Kovalik 1:09 PMок, ще я пиша тогавамерсиStoyan Tomov 1:10 PMза нъджовете лиMessage Stoyan Tomov......
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
83190
|
|
83191
|
Platform Sprint 5 Q2 - Platform Team - Scrum Board Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
BE upgrade libraries
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Text relay
Feed — jiminny — Sentry
Feed — jiminny — Sentry
CloudWatch | eu-west-1
CloudWatch | eu-west-1
JY-20915 fix missing header by LakyLak · Pull Request #12136 · jiminny/app
JY-20915 fix missing header by LakyLak · Pull Request #12136 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Login | Salesforce
Login | Salesforce
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Inbox (1,732) - [EMAIL] - Jiminny Mail
Inbox (1,732) - [EMAIL] - Jiminny Mail
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
Jiminny
Jiminny
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
Jiminny
Jiminny
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Sona Subramanian at 27/05/2026, 17:46:08 - Session Replay - LogRocket
Sona Subramanian at 27/05/2026, 17:46:08 - Session Replay - LogRocket
Iliyana Netseva at 27/05/2026, 18:48:18 - Session Replay - LogRocket
Iliyana Netseva at 27/05/2026, 18:48:18 - Session Replay - LogRocket
Jiminny
Jiminny
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Open
JY-20963 fix deleted object import #12121 LakyLak wants to merge 6 commits into master from JY-20963-fix-import-on-deleted-entity Copy head branch name to clipboard
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented last week •
LakyLak
LakyLak
commented
last week...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
83191
|
|
83192
|
Platform Sprint 5 Q2 - Platform Team - Scrum Board Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
BE upgrade libraries
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Text relay
Feed — jiminny — Sentry
Feed — jiminny — Sentry
CloudWatch | eu-west-1
CloudWatch | eu-west-1
JY-20915 fix missing header by LakyLak · Pull Request #12136 · jiminny/app
JY-20915 fix missing header by LakyLak · Pull Request #12136 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Login | Salesforce
Login | Salesforce
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Inbox (1,732) - [EMAIL] - Jiminny Mail
Inbox (1,732) - [EMAIL] - Jiminny Mail
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
Jiminny
Jiminny
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
Jiminny
Jiminny
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Sona Subramanian at 27/05/2026, 17:46:08 - Session Replay - LogRocket
Sona Subramanian at 27/05/2026, 17:46:08 - Session Replay - LogRocket
Iliyana Netseva at 27/05/2026, 18:48:18 - Session Replay - LogRocket
Iliyana Netseva at 27/05/2026, 18:48:18 - Session Replay - LogRocket
Jiminny
Jiminny
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Open
JY-20963 fix deleted object import #12121 LakyLak wants to merge 6 commits into master from JY-20963-fix-import-on-deleted-entity Copy head branch name to clipboard
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented last week •
LakyLak
LakyLak
commented
last week
last week
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
last week
last week
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
83192
|
|
83194
|
Platform Sprint 5 Q2 - Platform Team - Scrum Board Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
BE upgrade libraries
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Text relay
Feed — jiminny — Sentry
Feed — jiminny — Sentry
CloudWatch | eu-west-1
CloudWatch | eu-west-1
JY-20915 fix missing header by LakyLak · Pull Request #12136 · jiminny/app
JY-20915 fix missing header by LakyLak · Pull Request #12136 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Login | Salesforce
Login | Salesforce
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Inbox (1,732) - [EMAIL] - Jiminny Mail
Inbox (1,732) - [EMAIL] - Jiminny Mail
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
Jiminny
Jiminny
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
Jiminny
Jiminny
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Sona Subramanian at 27/05/2026, 17:46:08 - Session Replay - LogRocket
Sona Subramanian at 27/05/2026, 17:46:08 - Session Replay - LogRocket
Iliyana Netseva at 27/05/2026, 18:48:18 - Session Replay - LogRocket
Iliyana Netseva at 27/05/2026, 18:48:18 - Session Replay - LogRocket
Jiminny
Jiminny
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…...
|
Firefox
|
404 Not found — Work
|
github.com/jiminny/app/pull/12121
|
83194
|
|
83195
|
Platform Sprint 5 Q2 - Platform Team - Scrum Board Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
BE upgrade libraries
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Text relay
Feed — jiminny — Sentry
Feed — jiminny — Sentry
CloudWatch | eu-west-1
CloudWatch | eu-west-1
JY-20915 fix missing header by LakyLak · Pull Request #12136 · jiminny/app
JY-20915 fix missing header by LakyLak · Pull Request #12136 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Login | Salesforce
Login | Salesforce
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Inbox (1,732) - [EMAIL] - Jiminny Mail
Inbox (1,732) - [EMAIL] - Jiminny Mail
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
Jiminny
Jiminny
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
Jiminny
Jiminny
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Sona Subramanian at 27/05/2026, 17:46:08 - Session Replay - LogRocket
Sona Subramanian at 27/05/2026, 17:46:08 - Session Replay - LogRocket
Iliyana Netseva at 27/05/2026, 18:48:18 - Session Replay - LogRocket
Iliyana Netseva at 27/05/2026, 18:48:18 - Session Replay - LogRocket
Jiminny
Jiminny
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Open
JY-20963 fix deleted object import #12121 LakyLak wants to merge 6 commits into master from JY-20963-fix-import-on-deleted-entity Copy head branch name to clipboard
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Conversation...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
83195
|
|
83196
|
Platform Sprint 5 Q2 - Platform Team - Scrum Board Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
BE upgrade libraries
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Text relay
Feed — jiminny — Sentry
Feed — jiminny — Sentry
CloudWatch | eu-west-1
CloudWatch | eu-west-1
JY-20915 fix missing header by LakyLak · Pull Request #12136 · jiminny/app
JY-20915 fix missing header by LakyLak · Pull Request #12136 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Login | Salesforce
Login | Salesforce
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Inbox (1,732) - [EMAIL] - Jiminny Mail
Inbox (1,732) - [EMAIL] - Jiminny Mail
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
Jiminny
Jiminny
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
Jiminny
Jiminny
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Sona Subramanian at 27/05/2026, 17:46:08 - Session Replay - LogRocket
Sona Subramanian at 27/05/2026, 17:46:08 - Session Replay - LogRocket
Iliyana Netseva at 27/05/2026, 18:48:18 - Session Replay - LogRocket
Iliyana Netseva at 27/05/2026, 18:48:18 - Session Replay - LogRocket
Jiminny
Jiminny
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
sonarcloud.io/component_measures?id=jiminny_app&pullRequest=12121&metric=new_coverage&view=list...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
83196
|
|
83198
|
Platform Sprint 5 Q2 - Platform Team - Scrum Board Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
BE upgrade libraries
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Text relay
Feed — jiminny — Sentry
Feed — jiminny — Sentry
CloudWatch | eu-west-1
CloudWatch | eu-west-1
JY-20915 fix missing header by LakyLak · Pull Request #12136 · jiminny/app
JY-20915 fix missing header by LakyLak · Pull Request #12136 · jiminny/app
404 Not found
404 Not found
Close tab
Login | Salesforce
Login | Salesforce
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Inbox (1,732) - [EMAIL] - Jiminny Mail
Inbox (1,732) - [EMAIL] - Jiminny Mail
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
Jiminny
Jiminny
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
Unnamed Group
Jiminny
Jiminny
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Sona Subramanian at 27/05/2026, 17:46:08 - Session Replay - LogRocket
Sona Subramanian at 27/05/2026, 17:46:08 - Session Replay - LogRocket
Iliyana Netseva at 27/05/2026, 18:48:18 - Session Replay - LogRocket
Iliyana Netseva at 27/05/2026, 18:48:18 - Session Replay - LogRocket
Jiminny
Jiminny
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Continuous Code Quality
Explore
Explore
Search
Help
Start Free
Start Free
Log in
Log in
The requested project does not exist, or you have not authenticated with SonarQube Cloud.
The requested project does not exist, or you have not authenticated with SonarQube Cloud.
Make sure the project has been analyzed successfully, hasn't been deleted, and that you are authenticated to SonarQube Cloud with a user account with permission to view the project.
Login
Login
Or
Go back to the homepage
Go back to the homepage
Error:
Project doesn't exist...
|
Firefox
|
404 Not found — Work
|
github.com/jiminny/app/pull/12121
|
83198
|
|
83199
|
Firefox..••+EditViewHistoryooonnsinssroitesToolsWi Firefox..••+EditViewHistoryooonnsinssroitesToolsWindowHelpsonarcloud.io/component_measures?id=jiminny_app&pullRequest=121218metricerB sonarQubeExploreB40@ X 100%42 8• Thu 28 May 13:12:54a o Start Free) LoginPipelines - jiminny/appBE uporade libraries(JY-20613) Allow owner's role to bText relayFeed - jminny - Sentrya CloudWatch | su-weste1JY-20915 fi missing header by !404 Not foundLogin | Salesforce.Jimine/ExceotionslEmailActivitvteM Inbox (1,732) - lukas.kovalic@jiminR (JY-20979) Rescive PHP 8.5.5 depmlimicoPlattorm Sprint 5 Q2 - Plattorm TeThe requested project does not exist, or youhave not authenticated with SonarQube Cloud.Make sure the project has been analyzed successfully, hasn't beendeleted, and that vou are authenticated to Sonaroune Cloud with aluser account with permission to view the project.LOCInGo back to the homepage8) Jiminny** (SRD-6881) (0n demand) Transe8 Sona Subramanian at 27/05/202€8 Iliyana Netseva at 27/05/2026, 18a Jiminm.+ New Tab• Project doesn't exist...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
83199
|
|
83200
|
SlackFileEditViewGoHistoryWindowHelpDOCKERDOCKER ( SlackFileEditViewGoHistoryWindowHelpDOCKERDOCKER (-zsh)2c55fe91ca4148a230e32eadocker_lamp_12026] No failed transcriptidocker_lamp_18? Stadocker_lamp_1205 Ddocker_lamp_1roc/1/fd/1'2>&1docker_lamp_12026ONEdocker_lamp_1Gracefully Stopping...Container docker-blackfContainer docker-mariadContainer kibanaStoppiContainer docker_lamp_1Container docker-jiminnContainer ngrok StoppinContainer docker-datadoContainer docker-datadoContainer docker-blackfContainer kibana StoppeContainer elasticsearchContainer docker-jiminnContainer elasticsearchmariadb-11 2026-0ownngrokpReq="{err: ‹nil>mariadb-1ngrokt=2026restar2026-0t=2026on err=nilngrokt=2026f0743derr="reconnectinContainer docker_lamp_1Container ngrokError EContainer docker-mariadunexpected EOFerror during connect: Painers/ala97af7b5a28480What's next:Debug this Composelukas@Lukas-Kovaliks-Mav ALL VAULTS8My vaultExported88All items* FavouritesBinTYPESLoginCardIdentitySecure noteSSH keyFOLDERS+2FADCSV Import 28.01.22LastPass Import 1.11.21NAS UsersSalesloftStarter KitNo folderCOLLECTIONSPersonal collectionMy vaultSendQ [URL_WITH_CREDENTIALS] mJ2STigExRjaUT^BoFy8NFEDOhttps://blog.whitelabeltechnologies....J2STigExRjaUT^BoFy8NFEDOhttps://www.rescuetime.com/log..XDLHx3m/Vangseyhttps://www.rescuetime.com/login?…https://www.outsourcely.com/log..mLkl1230Shttps://www.outsourcely.com/login/Lkl1230Shttps://www.martinus.sk/login/?r..mLkl123Mhttps://www.martinus.sk/login/?redi..Lk/123Mhttps://www.jefit.com/login/m141122+HomeDMsActivityFilesLater...More+→Jiminny ...# infra-changes# infrastructure_dev# jbu-team-info# jiminny-bg# platform-team# platform-tickets# product_launches# random# releases# support# thank-yous# the_people_of jimi...° Direct messages. Stoyan TomovLo lliyana Netseva€ Vasil Vasilev& Petko Kashinski®. Galya Dimitrova8. Stefka Stoyanova%: Todor Stamatov&. Steliyan GeorgievC. Ves(8. MiraR. Nikolay Yankovdo James GrahamLukas Kovalik y... OApps100% CThu 28 May 13:12:56Describe what you are looking forStoyan Tomov• Messagest Add canvasO FilesMorev+сега погледFriday, May 22nd ~Lukas Kovalik 2:48 PMдаже не знаех че мога на prodStoyan Tomov 2:48 PMто се е ъпдейтнал lead-а в базата на моментаLukas Kovalik 3:25 PMда, има грешкав понеделник ще я деплойнаStoyan Tomov 3:31 PMdobreToday ~Lukas Kovalik 1:00 PMздрасти (edited)случайно да знеаш как работи днес ИлиянаStoyan Tomov 1:09 PMЗдрастиОт 3 часа е тяLukas Kovalik 1:09 PMок, ще я пиша тогавамерсиStoyan Tomov 1:10 PMза нъджовете лиMessage Stoyan Tomov......
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
83200
|
|
83201
|
rircrox..••+EditviehhsttonooorinsnsProfilesToolsWi rircrox..••+EditviehhsttonooorinsnsProfilesToolsWindow relt=github.com/inny/app/pull/12121O40 X 100%K3 8• Thu 28 May 13:12:5617 OpenPipelines - jiminny/app8 uporade libraries(JY-20613) Allow owner's role to bText relayFeed - jminny - Sentry4 CloudWatch | eu-west-1JY-20915 fi missing header by !JY-20963 fix deleted object in xLogin | SalesforceJimina/ExceotionslEmailActivitvteMinbox (1280) - Iikae koralieeie(JY-20979) Resolve PHP 8.5.5 desmlimicoPtatform Sprint 5 Q2 - Platform TeJY-20963 fix deleted object import #12121LakyLak wants to merge 6 commits into master from JY-28963-fix-import=on-deleted-entity* LakyLak and others added 3 commits 2 days agoa @Merge branch 'naster' into JY-20963-1ix-import-on-deleted-entity• @ JY-28963 code snelt• @ Jy-28963 add code coverageVerified X e918496X 6bc5c12X 41e8c6bsonarqubecloud Bot commented 2 days agcx Quality Gate failedralled concttionsX 67.4% Coverace on New Code (recuired ≥ 70%See analysis details on SonarQube CloudThis branch has not been deployed8) Jiminny(SRD-6881) (On demand) Transo8 Sona Subramanian at 27/05/20268 Iliyana Netseva at 27/05/2026, 18a Jiminm.tNaw TahReview requiredAlersanooroune temewt tedutred ov temewers wun wrrle aiccessSome checks were not successfultatino. nn Stccesstulcteck1tailinn checkx €8 SonarCloud Code Analysis Failing after 1m - Quality Gate failedv O build_accept_deploy Successful in 14m - Workflow: build_accept_deploy0 ci/circleci: build-backend — Your tests passed on CircleClv 0 ci/circleci: build-frontend - Your tests passed on CircleCiv ci/circleci: checkout-code — Your tests passed on CircleCI!v O ci/circleci: phpstan - Your tests passed on CircleCIThis branch is out-of-date with the hase branchNaras the ataet ensnase trom mactes into thie hranen Thie morad commit will naUodate branch...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
83201
|
|
83280
|
Platform Sprint 5 Q2 - Platform Team - Scrum Board Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
BE upgrade libraries
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Text relay
Deleted object error
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Login | Salesforce
Login | Salesforce
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Inbox (1,732) - [EMAIL] - Jiminny Mail
Inbox (1,732) - [EMAIL] - Jiminny Mail
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
Jiminny
Jiminny
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
transcript ss issue
Jiminny
Jiminny
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
83280
|
|
83281
|
Platform Sprint 5 Q2 - Platform Team - Scrum Board Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
BE upgrade libraries
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Text relay
Deleted object error
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Login | Salesforce
Login | Salesforce
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Inbox (1,732) - [EMAIL] - Jiminny Mail
Inbox (1,732) - [EMAIL] - Jiminny Mail
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
Jiminny
Jiminny
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
transcript ss issue
Jiminny
Jiminny
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Open
JY-20963 fix deleted object import #12121 LakyLak wants to merge 6 commits into master from JY-20963-fix-import-on-deleted-entity Copy head branch name to clipboard
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented last week •
LakyLak
LakyLak
commented
last week
last week
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
last week
last week
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
83281
|
|
83282
|
Platform Sprint 5 Q2 - Platform Team - Scrum Board Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
BE upgrade libraries
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Text relay
Deleted object error
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Login | Salesforce
Login | Salesforce
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Inbox (1,732) - [EMAIL] - Jiminny Mail
Inbox (1,732) - [EMAIL] - Jiminny Mail
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
Jiminny
Jiminny
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
transcript ss issue
Jiminny
Jiminny
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Open
JY-20963 fix deleted object import #12121 LakyLak wants to merge 6 commits into master from JY-20963-fix-import-on-deleted-entity Copy head branch name to clipboard
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented last week •
LakyLak
LakyLak
commented
last week
last week
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
last week
last week
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20963
JY-20963
-fix-import-on-deleted-entity
-fix-import-on-deleted-entity
Verified
Verified
11 / 12 checks OK
79dc986
79dc986
@nikolay-yankov
nikolay-yankov
nikolay-yankov
force-pushed
force-pushed
the
JY-20963-fix-import-on-deleted-entity
branch 2 times, most recently from
86b558b
86b558b
to
79dc986
79dc986
Compare
Compare
last week...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
83282
|
|
83283
|
Platform Sprint 5 Q2 - Platform Team - Scrum Board Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
BE upgrade libraries
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Text relay
Deleted object error
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Login | Salesforce
Login | Salesforce
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Inbox (1,732) - [EMAIL] - Jiminny Mail
Inbox (1,732) - [EMAIL] - Jiminny Mail
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
Jiminny
Jiminny
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
transcript ss issue
Jiminny
Jiminny
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Open
JY-20963 fix deleted object import #12121 LakyLak wants to merge 6 commits into master from JY-20963-fix-import-on-deleted-entity Copy head branch name to clipboard
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented last week •
LakyLak
LakyLak
commented
last week
last week
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
last week
last week
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov
Merge branch 'master' into...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
83283
|
|
83284
|
Platform Sprint 5 Q2 - Platform Team - Scrum Board Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
BE upgrade libraries
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Text relay
Deleted object error
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Login | Salesforce
Login | Salesforce
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Inbox (1,732) - [EMAIL] - Jiminny Mail
Inbox (1,732) - [EMAIL] - Jiminny Mail
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
Jiminny
Jiminny
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
transcript ss issue
Jiminny
Jiminny
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (36)
Pull requests
(
36
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality (3)
Security and quality
(
3
)
Insights
Insights
Settings
Settings
JY-20963 fix deleted object import #12121 Edit title
JY-20963 fix deleted object import
#
12121
Edit title
Checks failing
Checks failing
Code
Code
Open
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Lines changed: 403 additions & 52 deletions
Conversation (4)
Conversation
(
4
)
Commits (6)
Commits
(
6
)
Checks (3)
Checks
(
3
)
Files changed (3)
Files changed
(
3
)
Open
JY-20963 fix deleted object import #12121 LakyLak wants to merge 6 commits into master from JY-20963-fix-import-on-deleted-entity Copy head branch name to clipboard
JY-20963 fix deleted object import
JY-20963 fix deleted object import
#
12121
LakyLak
LakyLak
wants to merge 6 commits into
master
master
from
JY-20963-fix-import-on-deleted-entity
JY-20963-fix-import-on-deleted-entity
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented last week •
LakyLak
LakyLak
commented
last week
last week
•
edited by nikolay-yankov
edited by nikolay-yankov
JIRA:
JIRA:
Changes:
Changes:
Fix import object if deleted
Add or remove reactions
LakyLak
LakyLak
and others
added
2
commits
last week
last week
@LakyLak
JY-20963
JY-20963
fix deleted object import
fix deleted object import
11 / 12 checks OK
0c151a1
0c151a1
@nikolay-yankov
Merge branch 'master' into...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
83284
|
|
85832
|
Platform Sprint 5 Q2 - Platform Team - Scrum Board Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
BE upgrade libraries
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Text relay
Deleted object error
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
Uncovered Lines on New Code - app in Jiminny SonarQube Cloud
Close tab
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Login | Salesforce
Login | Salesforce
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Inbox (1,734) - [EMAIL] - Jiminny Mail
Inbox (1,734) - [EMAIL] - Jiminny Mail
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
Jiminny
Jiminny
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
transcript ss issue
Jiminny
Jiminny
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Sona Subramanian at 27/05/2026, 17:46:08 - Session Replay - LogRocket
Sona Subramanian at 27/05/2026, 17:46:08 - Session Replay - LogRocket
Iliyana Netseva at 27/05/2026, 18:48:18 - Session Replay - LogRocket
Iliyana Netseva at 27/05/2026, 18:48:18 - Session Replay - LogRocket
Jiminny
Jiminny
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
85832
|
|
85834
|
Platform Sprint 5 Q2 - Platform Team - Scrum Board Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
BE upgrade libraries
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Text relay
Deleted object error
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
Close tab
Login | Salesforce
Login | Salesforce
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Jiminny\Exceptions\EmailActivityImportException: [Email Import] Failed for InboxEmail ID: 125695762: Error: Request failed — jiminny — app
Inbox (1,734) - [EMAIL] - Jiminny Mail
Inbox (1,734) - [EMAIL] - Jiminny Mail
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
[JY-20979] Resolve PHP 8.5.5 deprications - Jira
Jiminny
Jiminny
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 5 Q2 - Platform Team - Scrum Board - Jira
transcript ss issue
Jiminny
Jiminny
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
[SRD-6881] [On demand] Transcription in saved search disappears - Jira
Sona Subramanian at 27/05/2026, 17:46:08 - Session Replay - LogRocket
Sona Subramanian at 27/05/2026, 17:46:08 - Session Replay - LogRocket
Iliyana Netseva at 27/05/2026, 18:48:18 - Session Replay - LogRocket
Iliyana Netseva at 27/05/2026, 18:48:18 - Session Replay - LogRocket
Jiminny
Jiminny
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
Main menu
Open mode picker, currently 3.1 Pro
Gemini
3.1 Pro
New Chat
Open menu for conversation actions.
Conversation with Gemini
Conversation with Gemini
You said I’m on page “<tabTitle>Jy 20910 schedule parallel update target processin</tabTitle>” with “<selection>@@ -4,7 +4,6 @@445namespace Tests\Unit\Component\ES;5namespace Tests\Unit\Component\ES;667-use ChaseConey\LaravelDatadogHelper\Datadog;8use Elastica\Index;7use Elastica\Index;9use Illuminate\Support\Facades\App;8use Illuminate\Support\Facades\App;10use Illuminate\Support\Facades\Log;9use Illuminate\Support\Facades\Log;@@ -20,6 +19,7 @@20use Jiminny\Component\ES\Processor\TargetEntitiesSelector;19use Jiminny\Component\ES\Processor\TargetEntitiesSelector;21use Jiminny\Component\ES\Processor\UpdateTarget;20use Jiminny\Component\ES\Processor\UpdateTarget;22use Jiminny\Component\ES\QueuePriorityEnum;21use Jiminny\Component\ES\QueuePriorityEnum;22+use Jiminny\Component\ES\ReindexTargetStatsReporter;23use Jiminny\Component\ES\UpdateProcessManager;23use Jiminny\Component\ES\UpdateProcessManager;24use Jiminny\Contracts\ES\UpdateTargetEnum;24use Jiminny\Contracts\ES\UpdateTargetEnum;25use PHPUnit\Framework\Attributes\CoversClass;25use PHPUnit\Framework\Attributes\CoversClass;@@ -31,6 +31,7 @@ class UpdateProcessManagerTest extends TestCase31{31{32private const string BATCH_NAME = '9440de7a-1c0f-4541-a235-592f2117bb20';32private const string BATCH_NAME = '9440de7a-1c0f-4541-a235-592f2117bb20';33private const string UPDATE_TARGET = UpdateTarget::ACTIVITY;33private const string UPDATE_TARGET = UpdateTarget::ACTIVITY;34+private const string ENVIRONMENT = 'testing';343535private array $normalPriority = [];36private array $normalPriority = [];36private array $highPriority = [];37private array $highPriority = [];@@ -40,6 +41,7 @@ class UpdateProcessManagerTest extends TestCase40private ?SimpleCollection $documentsToUpdate = null;41private ?SimpleCollection $documentsToUpdate = null;414242private BatchStatusManager|MockObject|null $batchStatusManager = null;43private BatchStatusManager|MockObject|null $batchStatusManager = null;44+private ReindexTargetStatsReporter|MockObject|null $statsReporter = null;43private Index|MockObject|null $targetIndex = null;45private Index|MockObject|null $targetIndex = null;444645private string|UpdateTargetEnum $updateTargetEntity = UpdateTarget::ACTIVITY;47private string|UpdateTargetEnum $updateTargetEntity = UpdateTarget::ACTIVITY;@@ -68,8 +70,13 @@ protected function setUp(): void68array_diff($allEntities, $deleteIds)70array_diff($allEntities, $deleteIds)69 );71 );707271-$this->prepareStatusManager();73+$this->statsReporter = $this->createMock(ReindexTargetStatsReporter::class);72-$this->prepareLogger();74+$this->statsReporter->expects($this->once())75+ ->method('setEnvironment')76+ ->with(self::ENVIRONMENT);77+$this->statsReporter->expects($this->once())78+ ->method('setUpdateTarget')79+ ->with(self::UPDATE_TARGET);73 }80 }748175/**82/**@@ -81,76 +88,75 @@ public function testRunUpdate(): void81// Also test that the trait works with entities and strings alike88// Also test that the trait works with entities and strings alike82$this->updateTargetEntity = UpdateTargetEnum::ACTIVITY;89$this->updateTargetEntity = UpdateTargetEnum::ACTIVITY;839084-$this->silenceDatadogAndRedisLock();91+ Log::shouldReceive('info')->withAnyArgs();92+ Log::shouldReceive('debug')->withAnyArgs();93+94+$this->statsReporter->expects($this->once())->method('report');95+96+$this->prepareStatusManager(1);859786$processor = $this->getProcessor();98$processor = $this->getProcessor();879988// There are exactly 250 chunks100// There are exactly 250 chunks89$this->assertTrue($processor->doUpdateEntitiesChunk());101$this->assertTrue($processor->doUpdateEntitiesChunk());102+90// But the second execution is on empty set103// But the second execution is on empty set91$this->assertFalse($processor->doUpdateEntitiesChunk());104$this->assertFalse($processor->doUpdateEntitiesChunk());92 }105 }9310694-/**107+public function testEmptySelectionLogsAndReturnsFalse(): void95- * When no Redis lock exists, logMemoryUsage should set the lock and emit a Datadog gauge96- * with the correct stat name, sample rate, and environment/type tags.97- */98-public function testLogMemoryUsageEmitsGaugeWhenLockIsAbsent(): void99 {108 {100-$gaugeLockKey = sprintf('%s-process-manager-lock', self::UPDATE_TARGET);109+$batchStatusManager = $this->createMock(BatchStatusManager::class);101-110+$batchStatusManager->expects($this->once())->method('setUpdateTarget')->with(self::UPDATE_TARGET);102- Redis::shouldReceive('get')->once()->with($gaugeLockKey)->andReturn(null);111+$batchStatusManager->expects($this->never())->method('generateName');103- Redis::shouldReceive('set')->once()->with($gaugeLockKey, true);112+$batchStatusManager->expects($this->never())->method('scheduleWork');104- Redis::shouldReceive('expire')->once()->with($gaugeLockKey, 60);113+$batchStatusManager->expects($this->never())->method('finishWork');105-106- Datadog::shouldReceive('increment')->once()->withAnyArgs();107- Datadog::shouldReceive('gauge')108- ->once()109- ->with(110-'jiminny.reindex-memory-usage',111- \Mockery::type('int'),112-1,113- ['environment' => 'staging', 'type' => self::UPDATE_TARGET]114- );115-116-$processor = $this->getProcessor();117-$processor->setEnvironment('staging');118114119-$processor->doUpdateEntitiesChunk();115+$emptySelection = $this->createMock(SelectionList::class);120-}116+ $emptySelection->expects($this->once())->method('isEmpty')->willReturn(true);121117122-/**118+$entitySelector = $this->createMock(TargetEntitiesSelector::class);123- * When a Redis lock already exists, logMemoryUsage should return early119+$entitySelector->expects($this->once())->method('setUpdateTarget')->with(self::UPDATE_TARGET);124- * and not emit a Datadog gauge.120+$entitySelector->expects($this->once())->method('setBatchStatusManager')->with($batchStatusManager);125- */121+$entitySelector->expects($this->once())->method('select')->willReturn($emptySelection);126-public function testLogMemoryUsageSkipsGaugeWhenLockIsPresent(): void127- {128-$gaugeLockKey = sprintf('%s-process-manager-lock', self::UPDATE_TARGET);129122130-Redis::shouldReceive('get')->once()->with($gaugeLockKey)->andReturn(true);123+Log::shouldReceive('debug')131-Redis::shouldReceive('set')->never();124+ ->once()132-Redis::shouldReceive('expire')->never();125+ ->with('[ EsUpdateProcessManager ] Empty selection', ['update_target' => self::UPDATE_TARGET]);133126134- Datadog::shouldReceive('increment')->once()->withAnyArgs();127+$this->statsReporter->expects($this->never())->method('report');135- Datadog::shouldReceive('gauge')->never();136128137-$processor = $this->getProcessor();129+$processor = new UpdateProcessManager(138-$processor->setEnvironment('staging');130+ esClient: $this->getEsClientMock(),131+ entitySelector: $entitySelector,132+ batchStatusManager: $batchStatusManager,133+ deleteDocumentsAction: $this->createMock(DeleteDocumentsAction::class),134+ upsertDocumentsAction: $this->createMock(UpsertDocumentsAction::class),135+ loadDocumentsAction: $this->createMock(LoadDocumentsAction::class),136+ statsReporter: $this->statsReporter,137+ );138+$processor->setEnvironment(self::ENVIRONMENT);139+$processor->setUpdateTarget(self::UPDATE_TARGET);140+$processor->bootstrap();139141140-$processor->doUpdateEntitiesChunk();142+$this->assertFalse($processor->doUpdateEntitiesChunk());141 }143 }142144143public function testRunDoUpdateButThrottled(): void145public function testRunDoUpdateButThrottled(): void144 {146 {145$this->isThrottled = true;147$this->isThrottled = true;146148147-$this->silenceDatadogAndRedisLock();149+ Log::shouldReceive('info')->withAnyArgs();150+151+$this->statsReporter->expects($this->once())->method('report');148152149// Reschedule High priority153// Reschedule High priority150 Redis::shouldReceive('saddarray')->with('activities-for-update-priority', $this->highPriority);154 Redis::shouldReceive('saddarray')->with('activities-for-update-priority', $this->highPriority);151// Reschedule low priority155// Reschedule low priority152 Redis::shouldReceive('saddarray')->with('activities-for-update', $this->normalPriority);156 Redis::shouldReceive('saddarray')->with('activities-for-update', $this->normalPriority);153157158+$this->prepareStatusManager(1);159+154$processor = $this->getProcessor();160$processor = $this->getProcessor();155161156$this->assertTrue($processor->doUpdateEntitiesChunk());162$this->assertTrue($processor->doUpdateEntitiesChunk());@@ -165,10 +171,11 @@ private function getProcessor(): UpdateProcessManager165 deleteDocumentsAction: $this->getDeleteActionMock(),171 deleteDocumentsAction: $this->getDeleteActionMock(),166 upsertDocumentsAction: $this->getUpsertActionMock(),172 upsertDocumentsAction: $this->getUpsertActionMock(),167 loadDocumentsAction: $this->getLoadDocumentsMock(),173 loadDocumentsAction: $this->getLoadDocumentsMock(),174+ statsReporter: $this->statsReporter,168 );175 );169176170$updateProcessor->setUpdateTarget($this->updateTargetEntity);177$updateProcessor->setUpdateTarget($this->updateTargetEntity);171-$updateProcessor->setEnvironment('test-env');178+$updateProcessor->setEnvironment(self::ENVIRONMENT);172179173$updateProcessor->bootstrap();180$updateProcessor->bootstrap();174181@@ -195,23 +202,6 @@ private function getEsClientMock(): Client|MockObject195return $clientMock;202return $clientMock;196 }203 }197204198-private function prepareLogger(): void199- {200- Log::shouldReceive('info')201- ->atLeast()202- ->once()203- ->with('[ EsUpdateProcessManager ] Finished updating entities in ES', $this->anything());204- }205-206-private function silenceDatadogAndRedisLock(): void207- {208- Datadog::shouldReceive('increment')->atLeast()->once()->withAnyArgs();209- Datadog::shouldReceive('gauge')->withAnyArgs();210- Redis::shouldReceive('get')->withAnyArgs()->andReturn(null);211- Redis::shouldReceive('set')->withAnyArgs();212- Redis::shouldReceive('expire')->withAnyArgs();213- }214-215private function getDeleteActionMock(): DeleteDocumentsAction|MockObject205private function getDeleteActionMock(): DeleteDocumentsAction|MockObject216 {206 {217$deleteAction = $this->createMock(DeleteDocumentsAction::class);207$deleteAction = $this->createMock(DeleteDocumentsAction::class);@@ -320,26 +310,30 @@ private function mockSelection(): SelectionList|MockObject320return $selectionList;310return $selectionList;321 }311 }322312323-private function prepareStatusManager(): void313+private function prepareStatusManager(int $invokeTimes = 0): void324 {314 {325$batchStatusManager = $this->createMock(BatchStatusManager::class);315$batchStatusManager = $this->createMock(BatchStatusManager::class);326316327-$batchStatusManager->expects($this->atLeastOnce())317+if ($invokeTimes) {318+$batchStatusManager->expects($this->once())319+ ->method('setUpdateTarget')320+ ->with(self::UPDATE_TARGET);321+ } else {322+$batchStatusManager->expects($this->never())->method('setUpdateTarget');323+ }324+325+$batchStatusManager->expects($this->exactly($invokeTimes))328 ->method('generateName')326 ->method('generateName')329 ->willReturn(self::BATCH_NAME);327 ->willReturn(self::BATCH_NAME);330328331-$batchStatusManager->expects($this->atLeastOnce())329+$batchStatusManager->expects($this->exactly($invokeTimes))332- ->method('setUpdateTarget')333- ->with(self::UPDATE_TARGET);334-335-$batchStatusManager->expects($this->atLeastOnce())336 ->method('scheduleWork')330 ->method('scheduleWork')337 ->with(331 ->with(338array_merge($this->highPriority, $this->normalPriority),332array_merge($this->highPriority, $this->normalPriority),339self::BATCH_NAME333self::BATCH_NAME340 );334 );341335342-$batchStatusManager->expects($this->atLeastOnce())336+$batchStatusManager->expects($this->exactly($invokeTimes))343 ->method('finishWork')337 ->method('finishWork')344 ->with(self::BATCH_NAME);338 ->with(self::BATCH_NAME);345339</selection>” selected. Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
You said
I’m on page “<tabTitle>Jy 20910 schedule parallel update target processin</tabTitle>” with “<selection>@@ -4,7 +4,6 @@445namespace Tests\Unit\Component\ES;5namespace Tests\Unit\Component\ES;667-use ChaseConey\LaravelDatadogHelper\Datadog;8use Elastica\Index;7use Elastica\Index;9use Illuminate\Support\Facades\App;8use Illuminate\Support\Facades\App;10use Illuminate\Support\Facades\Log;9use Illuminate\Support\Facades\Log;@@ -20,6 +19,7 @@20use Jiminny\Component\ES\Processor\TargetEntitiesSelector;19use Jiminny\Component\ES\Processor\TargetEntitiesSelector;21use Jiminny\Component\ES\Processor\UpdateTarget;20use Jiminny\Component\ES\Processor\UpdateTarget;22use Jiminny\Component\ES\QueuePriorityEnum;21use Jiminny\Component\ES\QueuePriorityEnum;22+use Jiminny\Component\ES\ReindexTargetStatsReporter;23use Jiminny\Component\ES\UpdateProcessManager;23use Jiminny\Component\ES\UpdateProcessManager;24use Jiminny\Contracts\ES\UpdateTargetEnum;24use Jiminny\Contracts\ES\UpdateTargetEnum;25use PHPUnit\Framework\Attributes\CoversClass;25use PHPUnit\Framework\Attributes\CoversClass;@@ -31,6 +31,7 @@ class UpdateProcessManagerTest extends TestCase31{31{32private const string BATCH_NAME = '9440de7a-1c0f-4541-a235-592f2117bb20';32private const string BATCH_NAME = '9440de7a-1c0f-4541-a235-592f2117bb20';33private const string UPDATE_TARGET = UpdateTarget::ACTIVITY;33private const string UPDATE_TARGET = UpdateTarget::ACTIVITY;34+private const string ENVIRONMENT = 'testing';343535private array $normalPriority = [];36private array $normalPriority = [];36private array $highPriority = [];37private array $highPriority = [];@@ -40,6 +41,7 @@ class UpdateProcessManagerTest extends TestCase40private ?SimpleCollection $documentsToUpdate = null;41private ?SimpleCollection $documentsToUpdate = null;414242private BatchStatusManager|MockObject|null $batchStatusManager = null;43private BatchStatusManager|MockObject|null $batchStatusManager = null;44+private ReindexTargetStatsReporter|MockObject|null $statsReporter = null;43private Index|MockObject|null $targetIndex = null;45private Index|MockObject|null $targetIndex = null;444645private string|UpdateTargetEnum $updateTargetEntity = UpdateTarget::ACTIVITY;47private string|UpdateTargetEnum $updateTargetEntity = UpdateTarget::ACTIVITY;@@ -68,8 +70,13 @@ protected function setUp(): void68array_diff($allEntities, $deleteIds)70array_diff($allEntities, $deleteIds)69 );71 );707271-$this->prepareStatusManager();73+$this->statsReporter = $this->createMock(ReindexTargetStatsReporter::class);72-$this->prepareLogger();74+$this->statsReporter->expects($this->once())75+ ->method('setEnvironment')76+ ->with(self::ENVIRONMENT);77+$this->statsReporter->expects($this->once())78+ ->method('setUpdateTarget')79+ ->with(self::UPDATE_TARGET);73 }80 }748175/**82/**@@ -81,76 +88,75 @@ public function testRunUpdate(): void81// Also test that the trait works with entities and strings alike88// Also test that the trait works with entities and strings alike82$this->updateTargetEntity = UpdateTargetEnum::ACTIVITY;89$this->updateTargetEntity = UpdateTargetEnum::ACTIVITY;839084-$this->silenceDatadogAndRedisLock();91+ Log::shouldReceive('info')->withAnyArgs();92+ Log::shouldReceive('debug')->withAnyArgs();93+94+$this->statsReporter->expects($this->once())->method('report');95+96+$this->prepareStatusManager(1);859786$processor = $this->getProcessor();98$processor = $this->getProcessor();879988// There are exactly 250 chunks100// There are exactly 250 chunks89$this->assertTrue($processor->doUpdateEntitiesChunk());101$this->assertTrue($processor->doUpdateEntitiesChunk());102+90// But the second execution is on empty set103// But the second execution is on empty set91$this->assertFalse($processor->doUpdateEntitiesChunk());104$this->assertFalse($processor->doUpdateEntitiesChunk());92 }105 }9310694-/**107+public function testEmptySelectionLogsAndReturnsFalse(): void95- * When no Redis lock exists, logMemoryUsage should set the lock and emit a Datadog gauge96- * with the correct stat name, sample rate, and environment/type tags.97- */98-public function testLogMemoryUsageEmitsGaugeWhenLockIsAbsent(): void99 {108 {100-$gaugeLockKey = sprintf('%s-process-manager-lock', self::UPDATE_TARGET);109+$batchStatusManager = $this->createMock(BatchStatusManager::class);101-110+$batchStatusManager->expects($this->once())->method('setUpdateTarget')->with(self::UPDATE_TARGET);102- Redis::shouldReceive('get')->once()->with($gaugeLockKey)->andReturn(null);111+$batchStatusManager->expects($this->never())->method('generateName');103- Redis::shouldReceive('set')->once()->with($gaugeLockKey, true);112+$batchStatusManager->expects($this->never())->method('scheduleWork');104- Redis::shouldReceive('expire')->once()->with($gaugeLockKey, 60);113+$batchStatusManager->expects($this->never())->method('finishWork');105-106- Datadog::shouldReceive('increment')->once()->withAnyArgs();107- Datadog::shouldReceive('gauge')108- ->once()109- ->with(110-'jiminny.reindex-memory-usage',111- \Mockery::type('int'),112-1,113- ['environment' => 'staging', 'type' => self::UPDATE_TARGET]114- );115-116-$processor = $this->getProcessor();117-$processor->setEnvironment('staging');118114119-$processor->doUpdateEntitiesChunk();115+$emptySelection = $this->createMock(SelectionList::class);120-}116+ $emptySelection->expects($this->once())->method('isEmpty')->willReturn(true);121117122-/**118+$entitySelector = $this->createMock(TargetEntitiesSelector::class);123- * When a Redis lock already exists, logMemoryUsage should return early119+$entitySelector->expects($this->once())->method('setUpdateTarget')->with(self::UPDATE_TARGET);124- * and not emit a Datadog gauge.120+$entitySelector->expects($this->once())->method('setBatchStatusManager')->with($batchStatusManager);125- */121+$entitySelector->expects($this->once())->method('select')->willReturn($emptySelection);126-public function testLogMemoryUsageSkipsGaugeWhenLockIsPresent(): void127- {128-$gaugeLockKey = sprintf('%s-process-manager-lock', self::UPDATE_TARGET);129122130-Redis::shouldReceive('get')->once()->with($gaugeLockKey)->andReturn(true);123+Log::shouldReceive('debug')131-Redis::shouldReceive('set')->never();124+ ->once()132-Redis::shouldReceive('expire')->never();125+ ->with('[ EsUpdateProcessManager ] Empty selection', ['update_target' => self::UPDATE_TARGET]);133126134- Datadog::shouldReceive('increment')->once()->withAnyArgs();127+$this->statsReporter->expects($this->never())->method('report');135- Datadog::shouldReceive('gauge')->never();136128137-$processor = $this->getProcessor();129+$processor = new UpdateProcessManager(138-$processor->setEnvironment('staging');130+ esClient: $this->getEsClientMock(),131+ entitySelector: $entitySelector,132+ batchStatusManager: $batchStatusManager,133+ deleteDocumentsAction: $this->createMock(DeleteDocumentsAction::class),134+ upsertDocumentsAction: $this->createMock(UpsertDocumentsAction::class),135+ loadDocumentsAction: $this->createMock(LoadDocumentsAction::class),136+ statsReporter: $this->statsReporter,137+ );138+$processor->setEnvironment(self::ENVIRONMENT);139+$processor->setUpdateTarget(self::UPDATE_TARGET);140+$processor->bootstrap();139141140-$processor->doUpdateEntitiesChunk();142+$this->assertFalse($processor->doUpdateEntitiesChunk());141 }143 }142144143public function testRunDoUpdateButThrottled(): void145public function testRunDoUpdateButThrottled(): void144 {146 {145$this->isThrottled = true;147$this->isThrottled = true;146148147-$this->silenceDatadogAndRedisLock();149+ Log::shouldReceive('info')->withAnyArgs();150+151+$this->statsReporter->expects($this->once())->method('report');148152149// Reschedule High priority153// Reschedule High priority150 Redis::shouldReceive('saddarray')->with('activities-for-update-priority', $this->highPriority);154 Redis::shouldReceive('saddarray')->with('activities-for-update-priority', $this->highPriority);151// Reschedule low priority155// Reschedule low priority152 Redis::shouldReceive('saddarray')->with('activities-for-update', $this->normalPriority);156 Redis::shouldReceive('saddarray')->with('activities-for-update', $this->normalPriority);153157158+$this->prepareStatusManager(1);159+154$processor = $this->getProcessor();160$processor = $this->getProcessor();155161156$this->assertTrue($processor->doUpdateEntitiesChunk());162$this->assertTrue($processor->doUpdateEntitiesChunk());@@ -165,10 +171,11 @@ private function getProcessor(): UpdateProcessManager165 deleteDocumentsAction: $this->getDeleteActionMock(),171 deleteDocumentsAction: $this->getDeleteActionMock(),166 upsertDocumentsAction: $this->getUpsertActionMock(),172 upsertDocumentsAction: $this->getUpsertActionMock(),167 loadDocumentsAction: $this->getLoadDocumentsMock(),173 loadDocumentsAction: $this->getLoadDocumentsMock(),174+ statsReporter: $this->statsReporter,168 );175 );169176170$updateProcessor->setUpdateTarget($this->updateTargetEntity);177$updateProcessor->setUpdateTarget($this->updateTargetEntity);171-$updateProcessor->setEnvironment('test-env');178+$updateProcessor->setEnvironment(self::ENVIRONMENT);172179173$updateProcessor->bootstrap();180$updateProcessor->bootstrap();174181@@ -195,23 +202,6 @@ private function getEsClientMock(): Client|MockObject195return $clientMock;202return $clientMock;196 }203 }197204198-private function prepareLogger(): void199- {200- Log::shouldReceive('info')201- ->atLeast()202- ->once()203- ->with('[ EsUpdateProcessManager ] Finished updating entities in ES', $this->anything());204- }205-206-private function silenceDatadogAndRedisLock(): void207- {208- Datadog::shouldReceive('increment')->atLeast()->once()->withAnyArgs();209- Datadog::shouldReceive('gauge')->withAnyArgs();210- Redis::shouldReceive('get')->withAnyArgs()->andReturn(null);211- Redis::shouldReceive('set')->withAnyArgs();212- Redis::shouldReceive('expire')->withAnyArgs();213- }214-215private function getDeleteActionMock(): DeleteDocumentsAction|MockObject205private function getDeleteActionMock(): DeleteDocumentsAction|MockObject216 {206 {217$deleteAction = $this->createMock(DeleteDocumentsAction::class);207$deleteAction = $this->createMock(DeleteDocumentsAction::class);@@ -320,26 +310,30 @@ private function mockSelection(): SelectionList|MockObject320return $selectionList;310return $selectionList;321 }311 }322312323-private function prepareStatusManager(): void313+private function prepareStatusManager(int $invokeTimes = 0): void324 {314 {325$batchStatusManager = $this->createMock(BatchStatusManager::class);315$batchStatusManager = $this->createMock(BatchStatusManager::class);326316327-$batchStatusManager->expects($this->atLeastOnce())317+if ($invokeTimes) {318+$batchStatusManager->expects($this->once())319+ ->method('setUpdateTarget')320+ ->with(self::UPDATE_TARGET);321+ } else {322+$batchStatusManager->expects($this->never())->method('setUpdateTarget');323+ }324+325+$batchStatusManager->expects($this->exactly($invokeTimes))328 ->method('generateName')326 ->method('generateName')329 ->willReturn(self::BATCH_NAME);327 ->willReturn(self::BATCH_NAME);330328331-$batchStatusManager->expects($this->atLeastOnce())329+$batchStatusManager->expects($this->exactly($invokeTimes))332- ->method('setUpdateTarget')333- ->with(self::UPDATE_TARGET);334-335-$batchStatusManager->expects($this->atLeastOnce())336 ->method('scheduleWork')330 ->method('scheduleWork')337 ->with(331 ->with(338array_merge($this->highPriority, $this->normalPriority),332array_merge($this->highPriority, $this->normalPriority),339self::BATCH_NAME333self::BATCH_NAME340 );334 );341335342-$batchStatusManager->expects($this->atLeastOnce())336+$batchStatusManager->expects($this->exactly($invokeTimes))343 ->method('finishWork')337 ->method('finishWork')344 ->with(self::BATCH_NAME);338 ->with(self::BATCH_NAME);345339</selection>” selected.
Please summarize the selection using precise and concise language. Use headers and bulleted lists in the summary, to make it scannable. Maintain the meaning and factual accuracy.
Expand
Copy prompt
Gemini said
Gemini said
Here is a summary of the changes in the provided git diff for
UpdateProcessManagerTest.php
:
Structural and Dependency Changes
Structural and Dependency Changes
Replaced Datadog:
Removed the
ChaseConey\LaravelDatadogHelper\Datadog
dependency and replaced it with
Jiminny\Component\ES\ReindexTargetStatsReporter
.
Added Constants and Properties:
Introduced a new
ENVIRONMENT
constant (set to
'testing'
) and a
$statsReporter
property to hold the mock for the new stats reporter.
Processor Instantiation:
Updated the
getProcessor()
method to inject the new
$statsReporter
mock into the
UpdateProcessManager
and utilize the
ENVIRONMENT
constant.
Test Case Modifications
Test Case Modifications
Removed Memory Logging Tests:
Deleted
testLogMemoryUsageEmitsGaugeWhenLockIsAbsent
and
testLogMemoryUsageSkipsGaugeWhenLockIsPresent
entirely, as the Redis lock and Datadog gauge logic were removed.
Added Empty Selection Test:
Introduced
testEmptySelectionLogsAndReturnsFalse
to verify that processing an empty selection logs a debug message, skips batch manager operations (
generateName
,
scheduleWork
,
finishWork
), skips the stats reporter, and cleanly returns
false
.
Updated Existing Tests:
Modified
testRunUpdate
and
testRunDoUpdateButThrottled
to assert that the
$statsReporter->report()
method is called and to utilize the updated status manager mock.
Helper Method Refactoring
Helper Method Refactoring
Dynamic Status Manager Assertions:
Updated the
prepareStatusManager(int $invokeTimes = 0)
method to accept an integer. This allows tests to dynamically assert exactly how many times methods like
generateName
,
setUpdateTarget
,
scheduleWork
, and
finishWork
are invoked.
Removed Obsolete Helpers:
Deleted the
prepareLogger()
and
silenceDatadogAndRedisLock()
helper methods, replacing their inline functionality with standard
Log::shouldReceive
expectations where needed.
Good response
Bad response
Share & export
Copy
Show more options
You said find potential issues
You said
find potential issues
Copy prompt
Gemini said
Gemini said
Based on the provided git diff of
UpdateProcessManagerTest.php
, here are the potential issues, risks, and improvements identified in the changes:
1. Missing setUpdateTarget Expectation in testEmptySelectionLogsAndReturnsFalse
1. Missing
setUpdateTarget
Expectation in
testEmptySelectionLogsAndReturnsFalse...
|
Firefox
|
JY-20963 fix deleted object import by LakyLak · Pu JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12121
|
85834
|