|
51511
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new......
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092/changes
|
51511
|
|
51525
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (30)
Pull requests
(
30
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Preview
Preview
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 1 commit into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 12 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (1)
Commits
(
1
)
Checks (2)
Checks
(
2
)
Files changed (3)
Files changed
(
3
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
All commits
All commits
0 of 3 files viewed
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app
DTO/Invitation
UserInvitationDTO.php
UserInvitationDTO.php
Http/Requests/Settings/Teams
CreateTeamRequest.php
CreateTeamRequest.php
EditTeamRequest.php
EditTeamRequest.php
Collapse file
app/DTO/Invitation/UserInvitationDTO.php
app/DTO/Invitation/UserInvitationDTO.php
app/DTO/Invitation/UserInvitationDTO.php
Copy file name to clipboard
Expand all lines: app/DTO/Invitation/UserInvitationDTO.php
Lines changed: 5 additions & 1 deletion
Not Viewed
Viewed
Comment on this file
More options
Original file line number
Original file line
Diff line number
Diff line change
@@ -51,9 +51,13 @@ private function __construct(array $attributes)
51
51
52
public
static
function
forOwner
(
CreateTeamRequest
|
EditTeamRequest
$
request
,
Team
$
team
):
self
52
public
static
function
forOwner
(
CreateTeamRequest
|
EditTeamRequest
$
request
,
Team...
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092/changes
|
51525
|
|
51526
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (30)
Pull requests
(
30
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Preview
Preview
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 1 commit into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 12 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (1)
Commits
(
1
)
Checks (2)
Checks
(
2
)
Files changed (3)
Files changed
(
3
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
All commits
All commits
0 of 3 files viewed
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app
DTO/Invitation
UserInvitationDTO.php
UserInvitationDTO.php
Http/Requests/Settings/Teams
CreateTeamRequest.php
CreateTeamRequest.php
EditTeamRequest.php
EditTeamRequest.php
Collapse file
app/DTO/Invitation/UserInvitationDTO.php
app/DTO/Invitation/UserInvitationDTO.php
app/DTO/Invitation/UserInvitationDTO.php
Copy file name to clipboard
Expand all lines: app/DTO/Invitation/UserInvitationDTO.php
Lines changed: 5 additions & 1 deletion
Not Viewed
Viewed
Comment on this file
More options
Original file line number
Original file line
Diff line number
Diff line change
@@ -51,9 +51,13 @@ private function __construct(array $attributes)
51
51
52
public
static
function
forOwner
(
CreateTeamRequest
|
EditTeamRequest
$
request
,
Team
$
team
):
self
52
public
static
function
forOwner
(
CreateTeamRequest
|
EditTeamRequest
$
request
,
Team
$
team
):
self
53
{
53
{
54
+
$
selectedRole
=
$
request
instanceof
CreateTeamRequest...
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092/changes
|
51526
|
|
51527
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (30)
Pull requests
(
30
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Preview
Preview
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 1 commit into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 12 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (1)
Commits
(
1
)
Checks (2)
Checks
(
2
)
Files changed (3)
Files changed
(
3
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
All commits
All commits
0 of 3 files viewed
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app
DTO/Invitation
UserInvitationDTO.php
UserInvitationDTO.php
Http/Requests/Settings/Teams
CreateTeamRequest.php
CreateTeamRequest.php
EditTeamRequest.php
EditTeamRequest.php
Collapse file
app/DTO/Invitation/UserInvitationDTO.php
app/DTO/Invitation/UserInvitationDTO.php
app/DTO/Invitation/UserInvitationDTO.php
Copy file name to clipboard
Expand all lines: app/DTO/Invitation/UserInvitationDTO.php
Lines changed: 5 additions & 1 deletion
Not Viewed
Viewed
Comment on this file
More options
Original file line number
Original file line
Diff line number
Diff line change
@@ -51,9 +51,13 @@ private function __construct(array $attributes)...
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092/changes
|
51527
|
|
51528
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (30)
Pull requests
(
30
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Preview
Preview
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 1 commit into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 12 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (1)
Commits
(
1
)
Checks (2)
Checks
(
2
)
Files changed (3)
Files changed
(
3
)
Pull Request Toolbar
Pull Request Toolbar
Collapse file tree
All commits
All commits
0 of 3 files viewed
Submit review
Submit
review
Open diff view settings
Open overview panel
Open comments panel
(
0
)
Filter files…
Filter options
File tree
File tree
app
DTO/Invitation
UserInvitationDTO.php
UserInvitationDTO.php
Http/Requests/Settings/Teams
CreateTeamRequest.php
CreateTeamRequest.php
EditTeamRequest.php
EditTeamRequest.php
Collapse file
app/DTO/Invitation/UserInvitationDTO.php
app/DTO/Invitation/UserInvitationDTO.php
app/DTO/Invitation/UserInvitationDTO.php
Copy file name to clipboard
Expand all lines: app/DTO/Invitation/UserInvitationDTO.php
Lines changed: 5 additions & 1 deletion
Not Viewed
Viewed
Comment on this file
More options
Original file line number
Original file line
Diff line number
Diff line change
@@ -51,9 +51,13 @@ private function __construct(array $attributes)
51
51
52...
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092/changes
|
51528
|
|
75303
|
Platform Team - Backlog - Jira
Service-Desk - Queu Platform Team - Backlog - Jira
Service-Desk - Queues - Platform team - Service space - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -1,5 +1,7 @@
1
<?php
1
<?php
2
2
3
+
declare
(strict_types=
1
);
4
+
3
namespace
Jiminny
\
DTO
\
Invitation
;
5
namespace
Jiminny
\
DTO
\
Invitation
;
4
6
5
use
Jiminny
\
DTO
\
UserEmail
;
7
use
Jiminny
\
DTO
\
UserEmail
;
@@ -51,9 +53,13 @@ private function __construct(array $attributes)
51
53
52
public
static
function
forOwner
(
CreateTeamRequest
|
EditTeamRequest
$
request
,
Team
$
team
):
self
54
public
static
function
forOwner
(
CreateTeamRequest
|
EditTeamRequest
$
request
,
Team
$
team
):
self
53
{
55
{
56
+
$
selectedRole
=
$
request
instanceof
CreateTeamRequest
57
+
?
$
request
->
getOwnerRole
()
58
+
: User::
ROLE_RECORDER
;
59
+
54
$
roleIds
= Role::
whereIn
(
'
name
'
, [
60
$
roleIds
= Role::
whereIn
(
'
name
'
, [
55
User::
ROLE_ADMIN
,
61
User::
ROLE_ADMIN
,
56
-
User::
ROLE_RECORDER
,
62
+
$
selectedRole
,
57
])->
pluck
(
'
id
'
)->
toArray
();
63...
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092/changes
|
75303
|
|
75304
|
Platform Team - Backlog - Jira
Service-Desk - Queu Platform Team - Backlog - Jira
Service-Desk - Queues - Platform team - Service space - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
[JY-20613] Allow owner's role to be selected when setting up a trial - Jira
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
JY-20963 fix deleted object import by LakyLak · Pull Request #12121 · jiminny/app
SevenShores\Hubspot\Exceptions\BadRequest: Client error: `POST [URL_WITH_CREDENTIALS] -1,5 +1,7 @@
1
<?php
1
<?php
2
2
3
+
declare
(strict_types=
1
);
4
+
3
namespace
Jiminny
\
DTO
\
Invitation
;
5
namespace
Jiminny
\
DTO
\
Invitation
;
4
6
5
use
Jiminny
\
DTO
\
UserEmail
;
7
use
Jiminny
\
DTO
\
UserEmail
;
@@ -51,9 +53,13 @@ private function __construct(array $attributes)
51
53
52
public
static
function
forOwner
(
CreateTeamRequest
|
EditTeamRequest
$
request
,
Team
$
team
):
self
54
public
static
function
forOwner
(
CreateTeamRequest
|
EditTeamRequest
$
request
,
Team
$
team
):
self
53
{
55
{
56
+
$
selectedRole
=
$
request
instanceof
CreateTeamRequest
57
+
?
$
request
->
getOwnerRole
()
58
+
: User::
ROLE_RECORDER
;
59
+
54
$
roleIds
= Role::
whereIn
(
'
name
'
, [
60
$
roleIds
= Role::
whereIn
(
'
name
'
, [
55
User::
ROLE_ADMIN
,
61
User::
ROLE_ADMIN
,
56
-
User::
ROLE_RECORDER
,
62
+
$
selectedRole
,
57
])->
pluck
(
'
id
'
)->...
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092/changes
|
75304
|
|
51480
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (30)
Pull requests
(
30
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20613 support owner role on setup team #12092 Edit title
JY-20613 support owner role on setup team
#
12092
Edit title
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 1 commit into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 12 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (1)
Commits
(
1
)
Checks (2)
Checks
(
2
)
Files changed (3)
Files changed
(
3
)
Conversation
Conversation
@LakyLak
Show options
LakyLak commented now
LakyLak
LakyLak
commented
now
now
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
3 / 6 checks OK
6fae8bb
6fae8bb
This branch has not been deployed
This branch has not been deployed
No deployments
Merge info
Merge info
Some checks haven't completed yet
Some checks haven't completed yet
2 pending, 1 in progress, 1 expected, 3 successful checks
Collapse checks
Collapse 3 pending checks group
3 pending checks
Checks settings
pending checks
pending checks
ci/circleci: build-backend
ci/circleci: build-backend
ci/circleci: build-backend
Waiting for status to be reported
— CircleCI is running your tests
More actions
ci/circleci: build-frontend
ci/circleci: build-frontend
ci/circleci: build-frontend
Waiting for status to be reported
— CircleCI is running your tests
More actions
SonarCloud Code Analysis
SonarCloud Code Analysis
Expected
— Waiting for status to be reported
Required
Collapse 1 in progress check group
1 in progress check
in progress checks
in progress checks
Loading
build_accept_deploy
build_accept_deploy
build_accept_deploy
Started
2 minutes ago
— Workflow: build_accept_deploy
More actions
Collapse 3 successful checks group
3 successful checks
successful checks
successful checks
ci/circleci: checkout-code
ci/circleci: checkout-code
ci/circleci: checkout-code
— Your tests passed on CircleCI!
More actions
ci/circleci: setup
ci/circleci: setup
ci/circleci: setup
— Your tests passed on CircleCI!
More actions
setup-workflow
setup-workflow
setup-workflow
Successful in 34s
— Workflow: setup-workflow
More actions
Loading
Checking for the ability to merge automatically...
Checking for the ability to merge automatically...
Hang in there while we check the branch's status.
Update branch
Update branch
Enable auto-merge
Enable auto-merge
Select merge method
You can also merge this with the command line.
View command line instructions.
Still in progress?
Convert to draft
Convert to draft
@LakyLak
Add a comment
Add a comment
Comment
Write
Write
Preview
Preview
Comment
Markdown is supported
Markdown
is supported
Paste, drop, or click to add files
Paste, drop, or click to add files
Close pull request
Close pull request
Comment
Remember, contributions to this repository should follow our
GitHub Community Guidelines
GitHub Community Guidelines
.
ProTip!
Add
.patch
.patch
or
.diff
.diff
to the end of URLs for Git’s plaintext views.
Reviewers
Suggestions
Request
Request
@ivhristova
ivhristova
ivhristova
Request
Request
@mihailmihaylovjiminny
mihailmihaylovjiminny
mihailmihaylovjiminny
At least 1 approving review is required to merge this pull request.
Still in progress?
Convert to draft
Assignees
No one—
assign yourself
Labels
None yet
Projects
None yet
Milestone
No milestone
Development
Development
Successfully merging this pull request may close these issues.
None yet
Notifications Customize
Notifications
Customize
Unsubscribe
Unsubscribe
You’re receiving notifications because you’re watching this repository.
1 participant
1 participant
@LakyLak
Lock conversation...
|
Firefox
|
JY-20613 support owner role on setup team by LakyL JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
51480
|
|
51627
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code...
|
Firefox
|
JY-20613 support owner role on setup team by LakyL JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
51627
|
|
51628
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (30)
Pull requests
(
30
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Checks pending
Checks pending
Code
Code
Open
LakyLak...
|
Firefox
|
JY-20613 support owner role on setup team by LakyL JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
51628
|
|
51629
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (30)
Pull requests
(
30
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 1 commit into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 12 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (1)
Commits
(
1
)
Checks (2)
Checks
(
2
)
Files changed (3)
Files changed
(
3
)
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 3 minutes ago
LakyLak
LakyLak
commented
3 minutes ago
3 minutes ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
2 minutes ago
2 minutes ago
This branch has not been deployed
This branch has not been deployed
No deployments
Merge info
Merge info
Review required
Review required
At least 1 approving review is required by reviewers with write access.
Some checks were not successful
Some checks were not successful
2 failing, 1 expected, 8 successful checks
Collapse checks
Collapse 2 failing checks group
2 failing checks
Checks settings
failing checks
failing checks
build_accept_deploy
build_accept_deploy
build_accept_deploy
Failing after 12m
— Workflow: build_accept_deploy
More actions
ci/circleci: test
ci/circleci: test
ci/circleci: test
— Your tests failed on CircleCI
More actions
Collapse 1 pending check group
1 pending check
pending checks
pending checks
SonarCloud Code Analysis
SonarCloud Code Analysis
Expected
— Waiting for status to be reported
Required
Collapse 8 successful checks group
8 successful checks
successful checks
successful checks
ci/circleci: build-backend
ci/circleci: build-backend
ci/circleci: build-backend
— Your tests passed on CircleCI!
More actions
ci/circleci: build-frontend
ci/circleci: build-frontend
ci/circleci: build-frontend
— Your tests passed on CircleCI!
More actions
ci/circleci: checkout-code
ci/circleci: checkout-code
ci/circleci: checkout-code
— Your tests passed on CircleCI!
More actions
ci/circleci: phpstan
ci/circleci: phpstan
ci/circleci: phpstan
— Your tests passed on CircleCI!
More actions
ci/circleci: setup
ci/circleci: setup
ci/circleci: setup
— Your tests passed on CircleCI!
More actions
ci/circleci: test-backend-lint
ci/circleci: test-backend-lint
ci/circleci: test-backend-lint
— Your tests passed on CircleCI!
More actions
ci/circleci: test-frontend
ci/circleci: test-frontend
ci/circleci: test-frontend
— Your tests passed on CircleCI!
More actions
setup-workflow
setup-workflow
setup-workflow
Successful in 34s
— Workflow: setup-workflow
More actions
This branch is out-of-date with the base branch
This branch is out-of-date with the base branch
Merge the latest changes from master into this branch. This merge commit will be associated with LakyLak.
Update branch
Update branch
Update branch options
Merging is blocked
Merging is blocked
At least 1 approving review is required by reviewers with write access.
Enable auto-merge
Enable auto-merge
Select merge method
You can also merge this with the command line.
View command line instructions.
Still in progress?
Convert to draft
Convert to draft
@LakyLak
Add a comment
Add a comment
Comment
Write
Write
Preview
Preview
Comment
Markdown is supported
Markdown
is supported
Paste, drop, or click to add files
Paste, drop, or click to add files
Close pull request
Close pull request
Comment
Remember, contributions to this repository should follow our
GitHub Community Guidelines
GitHub Community Guidelines
.
ProTip!
Add comments to specific lines under
Files changed
Files changed
.
Reviewers
Suggestions
Request
Request
@ivhristova
ivhristova
ivhristova
Request
Request
@mihailmihaylovjiminny
mihailmihaylovjiminny
mihailmihaylovjiminny
At least 1 approving review is required to merge this pull request.
Still in progress?
Convert to draft
Assignees
No one—
assign yourself
Labels
None yet
Projects
None yet
Milestone
No milestone
Development
Development
Successfully merging this pull request may close these issues.
None yet
Notifications Customize
Notifications
Customize
Unsubscribe
Unsubscribe
You’re receiving notifications because you’re watching this repository.
1 participant
1 participant
@LakyLak...
|
Firefox
|
JY-20613 support owner role on setup team by LakyL JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
51629
|
|
51940
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (30)
Pull requests
(
30
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 5 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 12 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (5)
Commits
(
5
)
Checks (2)
Checks
(
2
)
Files changed (3)
Files changed
(
3
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 5 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 5 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 3 minutes ago
LakyLak
LakyLak
commented
3 minutes ago
3 minutes ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
2 minutes ago
2 minutes ago
@LakyLak
JY-20613
JY-20613
fix tests
fix tests
12 / 12 checks OK
b7df560
b7df560
@sonarqubecloud
Show options
sonarqubecloud Bot commented now
sonarqubecloud
sonarqubecloud
Bot
commented
now
now
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
75.0% Coverage on New Code
75.0% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud
Add or remove reactions
nikolay-yankov
nikolay-yankov
added
2
commits
now...
|
Firefox
|
JY-20613 support owner role on setup team by LakyL JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
51940
|
|
51941
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (30)
Pull requests
(
30
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 5 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 12 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (5)
Commits
(
5
)
Checks (2)
Checks
(
2
)
Files changed (3)
Files changed
(
3
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 5 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 5 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 3 minutes ago
LakyLak
LakyLak
commented
3 minutes ago
3 minutes ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role...
|
Firefox
|
JY-20613 support owner role on setup team by LakyL JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
51941
|
|
51942
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (30)
Pull requests
(
30
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 5 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 12 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (5)
Commits
(
5
)
Checks (2)
Checks
(
2
)
Files changed (3)
Files changed
(
3
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 5 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 5 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 3 minutes ago
LakyLak
LakyLak
commented
3 minutes ago
3 minutes ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
2 minutes ago
2 minutes ago
@LakyLak
JY-20613
JY-20613
fix tests
fix tests
12 / 12 checks OK
b7df560
b7df560
@sonarqubecloud
Show options
sonarqubecloud Bot commented now
sonarqubecloud
sonarqubecloud
Bot
commented
now...
|
Firefox
|
JY-20613 support owner role on setup team by LakyL JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
51942
|
|
51943
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny...
|
Firefox
|
JY-20613 support owner role on setup team by LakyL JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
51943
|
|
51956
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (30)
Pull requests
(
30
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 5 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 12 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (5)
Commits
(
5
)
Checks (2)
Checks
(
2
)
Files changed (3)
Files changed
(
3
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 5 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 5 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 3 minutes ago
LakyLak
LakyLak
commented
3 minutes ago
3 minutes ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
2 minutes ago
2 minutes ago
@LakyLak
JY-20613
JY-20613
fix tests
fix tests
12 / 12 checks OK
b7df560
b7df560
@sonarqubecloud
Show options
sonarqubecloud Bot commented now
sonarqubecloud
sonarqubecloud
Bot
commented
now
now
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
75.0% Coverage on New Code
75.0% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud
Add or remove reactions
nikolay-yankov
nikolay-yankov
added
2
commits
now
now
@nikolay-yankov
JY-20613
JY-20613
Add Owner Role field
Add Owner Role field
2864624
2864624
@nikolay-yankov
Merge branch '
Merge branch '
JY-20613
JY-20613
-allow-owner-role-on-team-setup' of github.com:…
-allow-owner-role-on-team-setup' of github.com:…...
|
Firefox
|
JY-20613 support owner role on setup team by LakyL JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
51956
|
|
52043
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (30)
Pull requests
(
30
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Awaiting approval
Awaiting approval
Code
Code
Open
LakyLak
LakyLak
wants to merge 5 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 12 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (5)
Commits
(
5
)
Checks (2)
Checks
(
2
)
Files changed (3)
Files changed
(
3
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 5 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 5 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 3 minutes ago
LakyLak
LakyLak
commented
3 minutes ago
3 minutes ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
2 minutes ago
2 minutes ago
@LakyLak
JY-20613
JY-20613
fix tests
fix tests
12 / 12 checks OK
b7df560
b7df560
@sonarqubecloud
Show options
sonarqubecloud Bot commented now
sonarqubecloud
sonarqubecloud
Bot
commented
now
now
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
75.0% Coverage on New Code
75.0% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud
Add or remove reactions
nikolay-yankov
nikolay-yankov
added
2
commits
now
now
@nikolay-yankov
JY-20613
JY-20613
Add Owner Role field
Add Owner Role field
2864624
2864624
@nikolay-yankov
Merge branch '
Merge branch '
JY-20613
JY-20613
-allow-owner-role-on-team-setup' of github.com:…
-allow-owner-role-on-team-setup' of github.com:…
Commit message body
0 / 2 checks OK
d2d5ccc
d2d5ccc
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20613
JY-20613
-allow-owner-role-on-team-setup
-allow-owner-role-on-team-setup
0 / 4 checks OK
190239d
190239d
@nikolay-yankov
Show options
nikolay-yankov commented now
nikolay-yankov
nikolay-yankov
commented
now
now
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 2 minutes ago •
claude
claude
Bot
commented
2 minutes ago
2 minutes ago
•
edited
edited
Claude finished
@nikolay-yankov
@nikolay-yankov
's task in 2m 4s
——
View job
View job
Code Review: Allow owner's role to be selected when setting up a trial
Code Review: Allow owner's role to be selected when setting up a trial
Completed task
Gather context
Completed task
Read changed files
Completed task
Analyze and review code
Completed task
Post review findings
Overall, the implementation is clean and the intent is clear. A few issues worth addressing:...
|
Firefox
|
JY-20613 support owner role on setup team by LakyL JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52043
|
|
52044
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (30)
Pull requests
(
30
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Awaiting approval
Awaiting approval
Code
Code
Open
LakyLak
LakyLak
wants to merge 5 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 12 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (5)
Commits
(
5
)
Checks (2)
Checks
(
2
)
Files changed (3)
Files changed
(
3
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 5 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 5 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 3 minutes ago
LakyLak
LakyLak
commented
3 minutes ago
3 minutes ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
2 minutes ago
2 minutes ago
@LakyLak
JY-20613
JY-20613
fix tests
fix tests
12 / 12 checks OK
b7df560
b7df560
@sonarqubecloud
Show options
sonarqubecloud Bot commented now
sonarqubecloud
sonarqubecloud
Bot
commented
now
now
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
75.0% Coverage on New Code
75.0% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud
Add or remove reactions
nikolay-yankov
nikolay-yankov
added
2
commits
now
now
@nikolay-yankov
JY-20613
JY-20613
Add Owner Role field
Add Owner Role field
2864624
2864624
@nikolay-yankov
Merge branch '
Merge branch '
JY-20613
JY-20613
-allow-owner-role-on-team-setup' of github.com:…
-allow-owner-role-on-team-setup' of github.com:…
Commit message body
0 / 2 checks OK
d2d5ccc
d2d5ccc
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20613...
|
Firefox
|
JY-20613 support owner role on setup team by LakyL JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52044
|
|
52045
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (30)
Pull requests
(
30
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Awaiting approval
Awaiting approval
Code
Code
Open
LakyLak
LakyLak
wants to merge 5 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 12 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (5)
Commits
(
5
)
Checks (2)
Checks
(
2
)
Files changed (3)
Files changed
(
3
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 5 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 5 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 3 minutes ago
LakyLak
LakyLak
commented
3 minutes ago
3 minutes ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
2 minutes ago
2 minutes ago
@LakyLak
JY-20613
JY-20613
fix tests
fix tests
12 / 12 checks OK
b7df560
b7df560
@sonarqubecloud
Show options
sonarqubecloud Bot commented now
sonarqubecloud
sonarqubecloud
Bot
commented
now
now
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
75.0% Coverage on New Code
75.0% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud
Add or remove reactions
nikolay-yankov
nikolay-yankov
added
2
commits
now
now
@nikolay-yankov
JY-20613
JY-20613
Add Owner Role field
Add Owner Role field
2864624
2864624
@nikolay-yankov
Merge branch '
Merge branch '
JY-20613
JY-20613
-allow-owner-role-on-team-setup' of github.com:…
-allow-owner-role-on-team-setup' of github.com:…
Commit message body
0 / 2 checks OK
d2d5ccc
d2d5ccc
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20613
JY-20613
-allow-owner-role-on-team-setup
-allow-owner-role-on-team-setup
0 / 4 checks OK
190239d
190239d
@nikolay-yankov
Show options
nikolay-yankov commented now
nikolay-yankov
nikolay-yankov
commented
now
now
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 2 minutes ago •
claude
claude
Bot
commented
2 minutes ago
2 minutes ago
•
edited
edited...
|
Firefox
|
JY-20613 support owner role on setup team by LakyL JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52045
|
|
52046
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (30)
Pull requests
(
30
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Awaiting approval
Awaiting approval
Code
Code
Open
LakyLak
LakyLak
wants to merge 5 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 12 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (5)
Commits
(
5
)
Checks (2)
Checks
(
2
)
Files changed (3)
Files changed
(
3
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 5 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 5 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 3 minutes ago
LakyLak
LakyLak
commented
3 minutes ago
3 minutes ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
2 minutes ago
2 minutes ago
@LakyLak
JY-20613
JY-20613
fix tests
fix tests
12 / 12 checks OK
b7df560
b7df560
@sonarqubecloud
Show options
sonarqubecloud Bot commented now
sonarqubecloud
sonarqubecloud
Bot
commented
now
now
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
75.0% Coverage on New Code
75.0% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud
Add or remove reactions
nikolay-yankov
nikolay-yankov
added
2
commits
now
now
@nikolay-yankov
JY-20613
JY-20613
Add Owner Role field
Add Owner Role field
2864624
2864624
@nikolay-yankov
Merge branch '
Merge branch '
JY-20613
JY-20613
-allow-owner-role-on-team-setup' of github.com:…
-allow-owner-role-on-team-setup' of github.com:…
Commit message body
0 / 2 checks OK
d2d5ccc...
|
Firefox
|
JY-20613 support owner role on setup team by LakyL JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52046
|
|
52047
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (30)
Pull requests
(
30
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Awaiting approval
Awaiting approval
Code
Code
Open
LakyLak
LakyLak
wants to merge 5 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 12 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (5)
Commits
(
5
)
Checks (2)
Checks
(
2
)
Files changed (3)
Files changed
(
3
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 5 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 5 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 3 minutes ago
LakyLak
LakyLak
commented
3 minutes ago
3 minutes ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
2 minutes ago
2 minutes ago
@LakyLak
JY-20613
JY-20613
fix tests
fix tests
12 / 12 checks OK
b7df560
b7df560
@sonarqubecloud
Show options
sonarqubecloud Bot commented now
sonarqubecloud
sonarqubecloud
Bot
commented
now
now
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
75.0% Coverage on New Code
75.0% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud
Add or remove reactions
nikolay-yankov
nikolay-yankov
added
2
commits
now
now
@nikolay-yankov
JY-20613
JY-20613
Add Owner Role field
Add Owner Role field
2864624
2864624
@nikolay-yankov
Merge branch '
Merge branch '
JY-20613
JY-20613
-allow-owner-role-on-team-setup' of github.com:…
-allow-owner-role-on-team-setup' of github.com:…
Commit message body
0 / 2 checks OK
d2d5ccc
d2d5ccc
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20613
JY-20613
-allow-owner-role-on-team-setup
-allow-owner-role-on-team-setup
0 / 4 checks OK
190239d
190239d
@nikolay-yankov
Show options
nikolay-yankov commented now
nikolay-yankov
nikolay-yankov
commented
now
now
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 2 minutes ago •
claude
claude
Bot...
|
Firefox
|
JY-20613 support owner role on setup team by LakyL JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52047
|
|
52048
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (30)
Pull requests
(
30
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Awaiting approval
Awaiting approval
Code
Code
Open
LakyLak
LakyLak
wants to merge 5 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 12 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (5)
Commits
(
5
)
Checks (2)
Checks
(
2
)
Files changed (3)
Files changed
(
3
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 5 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 5 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 3 minutes ago
LakyLak
LakyLak
commented
3 minutes ago
3 minutes ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
2 minutes ago
2 minutes ago
@LakyLak
JY-20613
JY-20613
fix tests
fix tests
12 / 12 checks OK
b7df560
b7df560
@sonarqubecloud
Show options
sonarqubecloud Bot commented now
sonarqubecloud
sonarqubecloud
Bot
commented
now
now
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
75.0% Coverage on New Code
75.0% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud
Add or remove reactions
nikolay-yankov
nikolay-yankov
added
2
commits
now
now
@nikolay-yankov
JY-20613
JY-20613
Add Owner Role field
Add Owner Role field
2864624
2864624
@nikolay-yankov
Merge branch '
Merge branch '
JY-20613
JY-20613
-allow-owner-role-on-team-setup' of github.com:…
-allow-owner-role-on-team-setup' of github.com:…
Commit message body
0 / 2 checks OK...
|
Firefox
|
JY-20613 support owner role on setup team by LakyL JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52048
|
|
52055
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (30)
Pull requests
(
30
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Awaiting approval
Awaiting approval
Code
Code
Open
LakyLak
LakyLak
wants to merge 5 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 12 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (5)
Commits
(
5
)
Checks (2)
Checks
(
2
)
Files changed (3)
Files changed
(
3
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 5 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 5 commits into
master
master
from...
|
Firefox
|
JY-20613 support owner role on setup team by LakyL JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52055
|
|
52056
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (30)
Pull requests
(
30
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Awaiting approval
Awaiting approval
Code
Code
Open
LakyLak
LakyLak
wants to merge 5 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 12 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (5)
Commits
(
5
)
Checks (2)
Checks
(
2
)
Files changed (3)
Files changed
(
3
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 5 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 5 commits into
master
master...
|
Firefox
|
JY-20613 support owner role on setup team by LakyL JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52056
|
|
52059
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (30)
Pull requests
(
30
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Awaiting approval
Awaiting approval
Code
Code
Open
LakyLak
LakyLak
wants to merge 5 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 12 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (5)
Commits
(
5
)
Checks (2)
Checks
(
2
)
Files changed (3)
Files changed
(
3
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 5 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 5 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 3 minutes ago
LakyLak
LakyLak
commented
3 minutes ago
3 minutes ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
2 minutes ago
2 minutes ago
@LakyLak
JY-20613
JY-20613
fix tests
fix tests
12 / 12 checks OK
b7df560
b7df560
@sonarqubecloud
Show options
sonarqubecloud Bot commented now
sonarqubecloud
sonarqubecloud
Bot
commented
now
now
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
75.0% Coverage on New Code
75.0% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud
Add or remove reactions
nikolay-yankov
nikolay-yankov
added
2
commits
now
now
@nikolay-yankov
JY-20613
JY-20613
Add Owner Role field
Add Owner Role field
2864624
2864624
@nikolay-yankov
Merge branch '
Merge branch '
JY-20613
JY-20613
-allow-owner-role-on-team-setup' of github.com:…
-allow-owner-role-on-team-setup' of github.com:…
Commit message body
0 / 2 checks OK
d2d5ccc
d2d5ccc
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20613
JY-20613
-allow-owner-role-on-team-setup
-allow-owner-role-on-team-setup
0 / 4 checks OK
190239d
190239d
@nikolay-yankov
Show options
nikolay-yankov commented now
nikolay-yankov
nikolay-yankov
commented
now
now
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 2 minutes ago •
claude
claude
Bot
commented
2 minutes ago
2 minutes ago
•
edited
edited
Claude finished
@nikolay-yankov
@nikolay-yankov
's task in 2m 4s
——
View job
View job
Code Review: Allow owner's role to be selected when setting up a trial
Code Review: Allow owner's role to be selected when setting up a trial
Completed task
Gather context
Completed task
Read changed files
Completed task
Analyze and review code
Completed task
Post review findings
Overall, the implementation is clean and the intent is clear. A few issues worth addressing:
Issues
Issues
1. Potential test flakiness — unordered whereIn results
1. Potential test flakiness — unordered
whereIn
results
UserInvitationDTO::forOwner
uses
Role::whereIn('name', [...])
which does
not
guarantee a consistent order from the database. All three new tests assert a specific order:
// tests/Feature/DTO/UserInvitationDTOTest.php:72, 101, 130
self
::
assertSame
([
$
adminRole
->
getId
(),
$
recorderRole
->
getId
()],
$
dto
->
roleIds
);
Copy code to clipboard
This could be silently flaky depending on query execution plan or DB state. Use
assertEqualsCanonicalizing...
|
Firefox
|
JY-20613 support owner role on setup team by LakyL JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52059
|
|
52060
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (30)
Pull requests
(
30
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Awaiting approval
Awaiting approval
Code
Code
Open
LakyLak
LakyLak
wants to merge 5 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 12 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (5)
Commits
(
5
)
Checks (2)
Checks
(
2
)
Files changed (3)
Files changed
(
3
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 5 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 5 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 3 minutes ago
LakyLak
LakyLak
commented
3 minutes ago
3 minutes ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
2 minutes ago
2 minutes ago
@LakyLak
JY-20613
JY-20613
fix tests
fix tests
12 / 12 checks OK
b7df560
b7df560
@sonarqubecloud
Show options
sonarqubecloud Bot commented now
sonarqubecloud
sonarqubecloud
Bot
commented
now
now
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
75.0% Coverage on New Code
75.0% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud
Add or remove reactions
nikolay-yankov
nikolay-yankov
added
2
commits
now
now
@nikolay-yankov
JY-20613
JY-20613
Add Owner Role field
Add Owner Role field
2864624
2864624
@nikolay-yankov
Merge branch '
Merge branch '
JY-20613
JY-20613
-allow-owner-role-on-team-setup' of github.com:…
-allow-owner-role-on-team-setup' of github.com:…
Commit message body
0 / 2 checks OK
d2d5ccc
d2d5ccc
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20613
JY-20613
-allow-owner-role-on-team-setup
-allow-owner-role-on-team-setup
0 / 4 checks OK
190239d
190239d
@nikolay-yankov
Show options
nikolay-yankov commented now
nikolay-yankov
nikolay-yankov
commented
now
now
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 2 minutes ago •
claude
claude
Bot
commented
2 minutes ago
2 minutes ago
•
edited
edited...
|
Firefox
|
JY-20613 support owner role on setup team by LakyL JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52060
|
|
52377
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
Jiminny
Jiminny
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (30)
Pull requests
(
30
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 7 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 12 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (7)
Commits
(
7
)
Checks (2)
Checks
(
2
)
Files changed (3)
Files changed
(
3
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 7 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 7 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 3 minutes ago
LakyLak
LakyLak
commented
3 minutes ago
3 minutes ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
2 minutes ago
2 minutes ago
@LakyLak
JY-20613
JY-20613
fix tests
fix tests
12 / 12 checks OK...
|
Firefox
|
JY-20613 support owner role on setup team by LakyL JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52377
|
|
52378
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
Jiminny
Jiminny
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (30)
Pull requests
(
30
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 7 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 12 additions & 1 deletion
Conversation (0)
Conversation
(
0
)
Commits (7)
Commits
(
7
)
Checks (2)
Checks
(
2
)
Files changed (3)
Files changed
(
3
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 7 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 7 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 3 minutes ago
LakyLak
LakyLak
commented
3 minutes ago
3 minutes ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
2 minutes ago
2 minutes ago
@LakyLak
JY-20613
JY-20613
fix tests
fix tests
12 / 12 checks OK
b7df560
b7df560
@sonarqubecloud
Show options
sonarqubecloud Bot commented now
sonarqubecloud
sonarqubecloud
Bot
commented
now
now
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
75.0% Coverage on New Code
75.0% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud
Add or remove reactions
nikolay-yankov
nikolay-yankov
added
2
commits
now
now
@nikolay-yankov
JY-20613
JY-20613
Add Owner Role field
Add Owner Role field
2864624
2864624
@nikolay-yankov
Merge branch '
Merge branch '
JY-20613...
|
Firefox
|
JY-20613 support owner role on setup team by LakyL JY-20613 support owner role on setup team by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52378
|
|
52379
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
Jiminny
Jiminny
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 7 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 129 additions & 18 deletions
Conversation (3)
Conversation
(
3
)
Commits (7)
Commits
(
7
)
Checks (2)
Checks
(
2
)
Files changed (6)
Files changed
(
6
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 7 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 7 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 1 hour ago
LakyLak
LakyLak
commented
1 hour ago
1 hour ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
1 hour ago
1 hour ago
New changes since you last viewed
View changes
View changes
LakyLak
LakyLak
and others
added
4
commits
1 hour ago
1 hour ago
@LakyLak
JY-20613
JY-20613
fix tests
fix tests
12 / 12 checks OK
b7df560
b7df560
@nikolay-yankov
JY-20613
JY-20613
Add Owner Role field
Add Owner Role field
2864624
2864624
@nikolay-yankov
Merge branch '
Merge branch '
JY-20613
JY-20613
-allow-owner-role-on-team-setup' of github.com:…
-allow-owner-role-on-team-setup' of github.com:…
Commit message body
0 / 2 checks OK
d2d5ccc
d2d5ccc
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20613
JY-20613
-allow-owner-role-on-team-setup
-allow-owner-role-on-team-setup
20 / 21 checks OK
190239d
190239d
@nikolay-yankov
Show options
nikolay-yankov commented 39 minutes ago
nikolay-yankov
nikolay-yankov
commented
39 minutes ago
39 minutes ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 38 minutes ago •
claude
claude
Bot
commented
38 minutes ago
38 minutes ago
•
edited
edited
Claude finished
@nikolay-yankov
@nikolay-yankov
's task in 2m 4s
——...
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52379
|
|
52380
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
Jiminny
Jiminny
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 7 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 129 additions & 18 deletions
Conversation (3)
Conversation
(
3
)
Commits (7)
Commits
(
7
)
Checks (2)
Checks
(
2
)
Files changed (6)
Files changed
(
6
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 7 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 7 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 1 hour ago
LakyLak
LakyLak
commented
1 hour ago
1 hour ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
1 hour ago
1 hour ago
New changes since you last viewed
View changes
View changes
LakyLak
LakyLak
and others
added
4
commits
1 hour ago
1 hour ago
@LakyLak
JY-20613
JY-20613
fix tests
fix tests
12 / 12 checks OK
b7df560
b7df560
@nikolay-yankov
JY-20613
JY-20613
Add Owner Role field
Add Owner Role field
2864624
2864624
@nikolay-yankov
Merge branch '
Merge branch '
JY-20613
JY-20613
-allow-owner-role-on-team-setup' of github.com:…
-allow-owner-role-on-team-setup' of github.com:…
Commit message body
0 / 2 checks OK
d2d5ccc
d2d5ccc
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20613
JY-20613
-allow-owner-role-on-team-setup
-allow-owner-role-on-team-setup
20 / 21 checks OK
190239d
190239d
@nikolay-yankov
Show options
nikolay-yankov commented 39 minutes ago
nikolay-yankov
nikolay-yankov
commented
39 minutes ago
39 minutes ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 38 minutes ago •
claude
claude
Bot
commented
38 minutes ago
38 minutes ago
•
edited
edited
Claude finished
@nikolay-yankov
@nikolay-yankov
's task in 2m 4s
——
View job
View job
Code Review: Allow owner's role to be selected when setting up a trial
Code Review: Allow owner's role to be selected when setting up a trial
Completed task
Gather context
Completed task
Read changed files
Completed task
Analyze and review code
Completed task
Post review findings
Overall, the implementation is clean and the intent is clear. A few issues worth addressing:
Issues
Issues
1. Potential test flakiness — unordered whereIn results
1. Potential test flakiness — unordered
whereIn
results
UserInvitationDTO::forOwner
uses
Role::whereIn('name', [...])
which does
not
guarantee a consistent order from the database. All three new tests assert a specific order:
// tests/Feature/DTO/UserInvitationDTOTest.php:72, 101, 130
self
::
assertSame
([
$
adminRole
->
getId
(),
$
recorderRole
->
getId
()],
$
dto
->
roleIds
);
Copy code to clipboard
This could be silently flaky depending on query execution plan or DB state. Use
assertEqualsCanonicalizing
instead, which ignores order:
self
::
assertEqualsCanonicalizing
(
[
$...
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52380
|
|
52381
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
Jiminny
Jiminny
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 7 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 129 additions & 18 deletions
Conversation (3)
Conversation
(
3
)
Commits (7)
Commits
(
7
)
Checks (2)
Checks
(
2
)
Files changed (6)
Files changed
(
6
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 7 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 7 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 1 hour ago
LakyLak
LakyLak
commented
1 hour ago
1 hour ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
1 hour ago
1 hour ago
New changes since you last viewed
View changes
View changes
LakyLak
LakyLak
and others
added
4
commits
1 hour ago
1 hour ago
@LakyLak
JY-20613
JY-20613
fix tests
fix tests
12 / 12 checks OK
b7df560
b7df560
@nikolay-yankov
JY-20613...
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52381
|
|
52382
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
Jiminny
Jiminny
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 7 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 129 additions & 18 deletions
Conversation (3)
Conversation
(
3
)
Commits (7)
Commits
(
7
)
Checks (2)
Checks
(
2
)
Files changed (6)
Files changed
(
6
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 7 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 7 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 1 hour ago
LakyLak
LakyLak
commented
1 hour ago
1 hour ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
1 hour ago
1 hour ago
New changes since you last viewed
View changes
View changes
LakyLak
LakyLak
and others
added
4
commits
1 hour ago
1 hour ago
@LakyLak
JY-20613
JY-20613
fix tests
fix tests...
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52382
|
|
52383
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Close tab
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
Jiminny
Jiminny
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Awaiting approval
Awaiting approval
Code
Code
Open
LakyLak
LakyLak
wants to merge 7 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 129 additions & 18 deletions
Conversation (3)
Conversation
(
3
)
Commits (7)
Commits
(
7
)
Checks (2)
Checks
(
2
)
Files changed (6)
Files changed
(
6
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 7 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 7 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation...
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52383
|
|
52384
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Close tab
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Close tab
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
Jiminny
Jiminny
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Awaiting approval
Awaiting approval
Code
Code
Open
LakyLak
LakyLak
wants to merge 7 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 129 additions & 18 deletions
Conversation (3)
Conversation
(
3
)
Commits (7)
Commits
(
7
)
Checks (2)
Checks
(
2
)
Files changed (6)
Files changed
(
6
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 7 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial...
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52384
|
|
52438
|
FirefoxcalVIewHistorybookmarksProtllesToolsWindowH FirefoxcalVIewHistorybookmarksProtllesToolsWindowHelpgithub.com/jiminny/app/pull/12092# Support Daily - in 59 m100% LzMon 18 May 14:01:13Platform Sprint 4 Q2 - Platform TeW Usage I WindsurfFeed - jiminny - SentryAllow owner's role to be selectedPipelines - jiminny/app9(SRD-6848] Sidekick SMS issueCloudWatch I us-east-2CloudWatch | us-east-28 Jiminnyaithub.com/iiminnvlapo/oull/1— New TatWaitina for aithub.com....
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52438
|
|
52439
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
Jiminny
Jiminny
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Awaiting approval
Awaiting approval
Code
Code
Open
LakyLak
LakyLak
wants to merge 7 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 129 additions & 18 deletions
Conversation (5)
Conversation
(
5
)
Commits (7)
Commits
(
7
)
Checks (3)
Checks
(
3
)
Files changed (6)
Files changed
(
6
)
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 2 hours ago
LakyLak
LakyLak
commented
2 hours ago
2 hours ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
2 hours ago
2 hours ago
New changes since you last viewed
View changes
View changes
LakyLak
LakyLak
and others
added
4
commits
1 hour ago
1 hour ago
@LakyLak
JY-20613
JY-20613
fix tests
fix tests
12 / 12 checks OK
b7df560
b7df560
@nikolay-yankov
JY-20613
JY-20613
Add Owner Role field
Add Owner Role field
2864624
2864624
@nikolay-yankov
Merge branch '
Merge branch '
JY-20613
JY-20613
-allow-owner-role-on-team-setup' of github.com:…
-allow-owner-role-on-team-setup' of github.com:…
Commit message body
0 / 2 checks OK
d2d5ccc
d2d5ccc
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20613
JY-20613
-allow-owner-role-on-team-setup
-allow-owner-role-on-team-setup
20 / 21 checks OK
190239d
190239d
@nikolay-yankov
Show options
nikolay-yankov commented 1 hour ago
nikolay-yankov
nikolay-yankov
commented
1 hour ago
1 hour ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 1 hour ago •
claude
claude
Bot
commented
1 hour ago
1 hour ago
•
edited
edited
Claude finished
@nikolay-yankov
@nikolay-yankov
's task in 2m 4s
——
View job
View job
Code Review: Allow owner's role to be selected when setting up a trial
Code Review: Allow owner's role to be selected when setting up a trial
Completed task
Gather context
Completed task
Read changed files
Completed task
Analyze and review code
Completed task
Post review findings
Overall, the implementation is clean and the intent is clear. A few issues worth addressing:
Issues
Issues
1. Potential test flakiness — unordered whereIn results
1. Potential test flakiness — unordered
whereIn
results
UserInvitationDTO::forOwner
uses
Role::whereIn('name', [...])
which does
not
guarantee a consistent order from the database. All three new tests assert a specific order:
// tests/Feature/DTO/UserInvitationDTOTest.php:72, 101, 130
self
::
assertSame
([
$
adminRole
->
getId
(),
$
recorderRole
->
getId
()],
$
dto
->
roleIds
);
Copy code to clipboard
This could be silently flaky depending on query execution plan or DB state. Use
assertEqualsCanonicalizing
instead, which ignores order:
self
::
assertEqualsCanonicalizing
(
[
$
adminRole
->
getId
(),
$
recorderRole
->
getId
()],
$
dto
->
roleIds
);
Copy code to clipboard
Fix this →
Fix this →
2. Hardcoded role strings duplicate User::ROLE_* constants
2. Hardcoded role strings duplicate
User::ROLE_*
constants
CreateTeamRequest.php:26
:
'
owner_role
'
=> [
'
required
'
,
'
in:recorder,recorder_and_voice,analyst
'
],
Copy code to clipboard
These string literals duplicate the
User::ROLE_RECORDER
,
User::ROLE_RECORDER_AND_VOICE
,
User::ROLE_ANALYST
constants. If a role name changes, both places need updating. Prefer:
'
owner_role
'
=> [
'
required
'
,
'
in:
'
.
implode
(
'
,
'
, [
User::
ROLE_RECORDER
,
User::
ROLE_RECORDER_AND_VOICE
,
User::
ROLE_ANALYST
,
])],
Copy code to clipboard
Fix this →
Fix this →
3. Missing declare(strict_types=1) in CreateTeamRequest.php
3. Missing
declare(strict_types=1)
in
CreateTeamRequest.php
EditTeamRequest.php
has it (line 3), but
CreateTeamRequest.php
does not. Per project rules, all PHP files must declare
strict_types=1
. Since this file is already being modified, this is the right moment to add it.
Nits
Nits
getOwnerRole()
uses
$this->input()
instead of
$this->validated()
— consistent with
getOwnerEmail()
in the same file, so not a blocker, but
validated()
is technically safer since it only returns data that passed validation.
ownerRoleOptions
is in
<script setup>
— in Vue 3,
<script setup>
runs once per instance. Since it's a static array, it's fine functionally, but moving it to the module-level
<script>
block alongside the other constants (e.g.,
SOFTPHONE_FEATURE_ID
,
syncPeriodOptions
) would be more consistent....
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52439
|
|
52440
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
Jiminny
Jiminny
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Awaiting approval
Awaiting approval
Code
Code
Open
LakyLak
LakyLak
wants to merge 7 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 129 additions & 18 deletions
Conversation (5)
Conversation
(
5
)
Commits (7)
Commits
(
7
)
Checks (3)
Checks
(
3
)
Files changed (6)
Files changed
(
6
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 7 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 7 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 2 hours ago
LakyLak
LakyLak
commented
2 hours ago
2 hours ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
2 hours ago
2 hours ago
New changes since you last viewed
View changes
View changes
LakyLak
LakyLak
and others
added
4
commits
1 hour ago
1 hour ago
@LakyLak
JY-20613
JY-20613
fix tests
fix tests
12 / 12 checks OK
b7df560
b7df560
@nikolay-yankov
JY-20613
JY-20613
Add Owner Role field
Add Owner Role field
2864624
2864624
@nikolay-yankov
Merge branch '
Merge branch '
JY-20613
JY-20613
-allow-owner-role-on-team-setup' of github.com:…
-allow-owner-role-on-team-setup' of github.com:…
Commit message body
0 / 2 checks OK
d2d5ccc
d2d5ccc
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20613
JY-20613
-allow-owner-role-on-team-setup
-allow-owner-role-on-team-setup
20 / 21 checks OK
190239d
190239d
@nikolay-yankov
Show options
nikolay-yankov commented 1 hour ago
nikolay-yankov...
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52440
|
|
52441
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
Jiminny
Jiminny
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Awaiting approval
Awaiting approval
Code
Code
Open
LakyLak
LakyLak
wants to merge 7 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 129 additions & 18 deletions
Conversation (5)
Conversation
(
5
)
Commits (7)
Commits
(
7
)
Checks (3)
Checks
(
3
)
Files changed (6)
Files changed
(
6
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 7 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial...
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52441
|
|
52442
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
Jiminny
Jiminny
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title...
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52442
|
|
52457
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
Jiminny
Jiminny
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Awaiting approval
Awaiting approval
Code
Code
Open
LakyLak
LakyLak
wants to merge 7 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 129 additions & 18 deletions
Conversation (5)
Conversation
(
5
)
Commits (7)
Commits
(
7
)
Checks (3)
Checks
(
3
)
Files changed (6)
Files changed
(
6
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 7 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 7 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 2 hours ago
LakyLak
LakyLak
commented
2 hours ago
2 hours ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
2 hours ago
2 hours ago
New changes since you last viewed
View changes
View changes
LakyLak
LakyLak
and others
added
4
commits
1 hour ago
1 hour ago
@LakyLak
JY-20613
JY-20613
fix tests
fix tests
12 / 12 checks OK
b7df560
b7df560
@nikolay-yankov
JY-20613
JY-20613
Add Owner Role field
Add Owner Role field
2864624
2864624
@nikolay-yankov
Merge branch '
Merge branch '
JY-20613
JY-20613
-allow-owner-role-on-team-setup' of github.com:…
-allow-owner-role-on-team-setup' of github.com:…
Commit message body
0 / 2 checks OK
d2d5ccc
d2d5ccc
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20613
JY-20613
-allow-owner-role-on-team-setup
-allow-owner-role-on-team-setup
20 / 21 checks OK
190239d
190239d
@nikolay-yankov
Show options
nikolay-yankov commented 1 hour ago
nikolay-yankov
nikolay-yankov
commented
1 hour ago
1 hour ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 1 hour ago •
claude
claude
Bot
commented
1 hour ago
1 hour ago
•
edited
edited
Claude finished
@nikolay-yankov
@nikolay-yankov
's task in 2m 4s
——
View job
View job
Code Review: Allow owner's role to be selected when setting up a trial
Code Review: Allow owner's role to be selected when setting up a trial
Completed task
Gather context
Completed task
Read changed files
Completed task
Analyze and review code
Completed task
Post review findings
Overall, the implementation is clean and the intent is clear. A few issues worth addressing:
Issues
Issues
1. Potential test flakiness — unordered whereIn results
1. Potential test flakiness — unordered
whereIn
results
UserInvitationDTO::forOwner
uses
Role::whereIn('name', [...])
which does
not
guarantee a consistent order from the database. All three new tests assert a specific order:
// tests/Feature/DTO/UserInvitationDTOTest.php:72, 101, 130
self
::
assertSame
([
$
adminRole
->
getId
(),
$
recorderRole
->
getId
()],
$
dto
->
roleIds
);
Copy code to clipboard
This could be silently flaky depending on query execution plan or DB state. Use
assertEqualsCanonicalizing
instead, which ignores order:
self
::
assertEqualsCanonicalizing
(
[
$
adminRole
->
getId
(),
$
recorderRole
->
getId
()],
$
dto
->
roleIds
);
Copy code to clipboard
Fix this →
Fix this →
2. Hardcoded role strings duplicate User::ROLE_* constants
2. Hardcoded role strings duplicate
User::ROLE_*
constants
CreateTeamRequest.php:26
:
'
owner_role
'
=> [
'
required
'
,
'
in:recorder,recorder_and_voice,analyst
'
],
Copy code to clipboard
These string literals duplicate the
User::ROLE_RECORDER
,
User::ROLE_RECORDER_AND_VOICE
,
User::ROLE_ANALYST
constants. If a role name changes, both places need updating. Prefer:
'
owner_role
'
=> [
'
required
'
,
'
in:
'
.
implode
(
'
,
'
, [
User::
ROLE_RECORDER
,
User::
ROLE_RECORDER_AND_VOICE
,
User::
ROLE_ANALYST
,
])],...
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52457
|
|
52461
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
Jiminny
Jiminny
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Awaiting approval
Awaiting approval
Code
Code
Open
LakyLak
LakyLak
wants to merge 7 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 129 additions & 18 deletions
Conversation (5)
Conversation
(
5
)
Commits (7)
Commits
(
7
)
Checks (3)
Checks
(
3
)
Files changed (6)
Files changed
(
6
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 7 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 7 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 2 hours ago
LakyLak
LakyLak
commented
2 hours ago
2 hours ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
2 hours ago
2 hours ago
New changes since you last viewed
View changes
View changes
LakyLak
LakyLak
and others
added
4
commits
1 hour ago
1 hour ago
@LakyLak
JY-20613
JY-20613
fix tests
fix tests
12 / 12 checks OK
b7df560
b7df560
@nikolay-yankov
JY-20613
JY-20613
Add Owner Role field
Add Owner Role field
2864624
2864624
@nikolay-yankov
Merge branch '
Merge branch '
JY-20613
JY-20613
-allow-owner-role-on-team-setup' of github.com:…
-allow-owner-role-on-team-setup' of github.com:…
Commit message body
0 / 2 checks OK
d2d5ccc
d2d5ccc
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20613
JY-20613
-allow-owner-role-on-team-setup
-allow-owner-role-on-team-setup
20 / 21 checks OK
190239d
190239d
@nikolay-yankov
Show options
nikolay-yankov commented 1 hour ago
nikolay-yankov
nikolay-yankov
commented
1 hour ago
1 hour ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 1 hour ago •
claude
claude
Bot
commented
1 hour ago
1 hour ago
•
edited
edited
Claude finished
@nikolay-yankov
@nikolay-yankov
's task in 2m 4s
——
View job
View job
Code Review: Allow owner's role to be selected when setting up a trial
Code Review: Allow owner's role to be selected when setting up a trial
Completed task
Gather context
Completed task
Read changed files
Completed task
Analyze and review code
Completed task
Post review findings
Overall, the implementation is clean and the intent is clear. A few issues worth addressing:
Issues
Issues
1. Potential test flakiness — unordered whereIn results
1. Potential test flakiness — unordered
whereIn
results
UserInvitationDTO::forOwner
uses
Role::whereIn('name', [...])
which does
not
guarantee a consistent order from the database. All three new tests assert a specific order:
// tests/Feature/DTO/UserInvitationDTOTest.php:72, 101, 130
self
::
assertSame
([
$
adminRole
->
getId
(),
$
recorderRole
->
getId
()],
$
dto
->
roleIds
);
Copy code to clipboard
This could be silently flaky depending on query execution plan or DB state. Use
assertEqualsCanonicalizing
instead, which ignores order:
self
::
assertEqualsCanonicalizing
(
[
$
adminRole
->
getId
(),
$
recorderRole
->
getId
()],
$
dto
->
roleIds
);
Copy code to clipboard
Fix this →
Fix this →
2. Hardcoded role strings duplicate User::ROLE_* constants
2. Hardcoded role strings duplicate
User::ROLE_*
constants
CreateTeamRequest.php:26
:
'
owner_role
'
=> [
'
required
'
,
'
in:recorder,recorder_and_voice,analyst
'
],
Copy code to clipboard
These string literals duplicate the
User::ROLE_RECORDER
,
User::ROLE_RECORDER_AND_VOICE
,
User::ROLE_ANALYST
constants. If a role name changes, both places need updating. Prefer:
'
owner_role
'
=> [
'
required
'
,
'
in:
'
.
implode
(
'
,
'
, [
User::
ROLE_RECORDER
,
User::
ROLE_RECORDER_AND_VOICE
,
User::
ROLE_ANALYST
,
])],
Copy code to clipboard
Fix this →
Fix this →
3. Missing declare(strict_types=1) in CreateTeamRequest.php
3. Missing
declare(strict_types=1)
in
CreateTeamRequest.php
EditTeamRequest.php
has it (line 3), but
CreateTeamRequest.php
does not. Per project rules, all PHP files must declare
strict_types=1
. Since this file is already being modified, this is the right moment to add it.
Nits
Nits
getOwnerRole()
uses
$this->input()
instead of
$this->validated()
— consistent with
getOwnerEmail()
in the same file, so not a blocker, but
validated()
is technically safer since it only returns data that passed validation.
ownerRoleOptions
is in
<script setup>
— in Vue 3,
<script setup>
runs once per instance. Since it's a static array, it's fine functionally, but moving it to the module-level
<script>
block alongside the other constants (e.g.,
SOFTPHONE_FEATURE_ID
,
syncPeriodOptions
) would be more consistent.
No validation test for
CreateTeamRequest...
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52461
|
|
52520
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
Jiminny
Jiminny
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents...
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52520
|
|
52521
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
Jiminny
Jiminny
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions...
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52521
|
|
52522
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
Jiminny
Jiminny
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 7 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 129 additions & 18 deletions
Conversation (5)
Conversation
(
5
)
Commits (7)
Commits
(
7
)
Checks (3)
Checks
(
3
)
Files changed (6)
Files changed
(
6
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 7 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 7 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 2 hours ago
LakyLak
LakyLak
commented
2 hours ago
2 hours ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
2 hours ago
2 hours ago
New changes since you last viewed
View changes
View changes
LakyLak
LakyLak
and others
added
4
commits
1 hour ago
1 hour ago
@LakyLak
JY-20613
JY-20613
fix tests
fix tests
12 / 12 checks OK
b7df560
b7df560
@nikolay-yankov
JY-20613
JY-20613
Add Owner Role field
Add Owner Role field
2864624
2864624
@nikolay-yankov
Merge branch '
Merge branch '
JY-20613
JY-20613
-allow-owner-role-on-team-setup' of github.com:…
-allow-owner-role-on-team-setup' of github.com:…
Commit message body
0 / 2 checks OK
d2d5ccc
d2d5ccc
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20613
JY-20613
-allow-owner-role-on-team-setup
-allow-owner-role-on-team-setup
20 / 21 checks OK
190239d
190239d
@nikolay-yankov
Show options
nikolay-yankov commented 1 hour ago
nikolay-yankov
nikolay-yankov
commented
1 hour ago
1 hour ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 1 hour ago •
claude
claude
Bot
commented
1 hour ago
1 hour ago
•
edited
edited
Claude finished
@nikolay-yankov
@nikolay-yankov
's task in 2m 4s
——
View job
View job
Code Review: Allow owner's role to be selected when setting up a trial
Code Review: Allow owner's role to be selected when setting up a trial
Completed task
Gather context
Completed task
Read changed files
Completed task
Analyze and review code
Completed task
Post review findings
Overall, the implementation is clean and the intent is clear. A few issues worth addressing:
Issues
Issues
1. Potential test flakiness — unordered whereIn results
1. Potential test flakiness — unordered
whereIn
results
UserInvitationDTO::forOwner
uses
Role::whereIn('name', [...])
which does
not
guarantee a consistent order from the database. All three new tests assert a specific order:
// tests/Feature/DTO/UserInvitationDTOTest.php:72, 101, 130
self
::
assertSame
([
$
adminRole
->
getId
(),
$
recorderRole
->
getId
()],
$
dto
->
roleIds
);
Copy code to clipboard
This could be silently flaky depending on query execution plan or DB state. Use
assertEqualsCanonicalizing
instead, which ignores order:
self
::
assertEqualsCanonicalizing
(
[
$
adminRole
->
getId
(),
$
recorderRole
->
getId
()],
$
dto
->
roleIds
);
Copy code to clipboard
Fix this →
Fix this →
2. Hardcoded role strings duplicate User::ROLE_* constants
2. Hardcoded role strings duplicate
User::ROLE_*
constants
CreateTeamRequest.php:26
:
'
owner_role
'
=> [
'
required
'
,
'
in:recorder,recorder_and_voice,analyst
'
],
Copy code to clipboard
These string literals duplicate the
User::ROLE_RECORDER
,
User::ROLE_RECORDER_AND_VOICE
,
User::ROLE_ANALYST
constants. If a role name changes, both places need updating. Prefer:
'
owner_role
'
=> [
'
required
'
,
'
in:
'
.
implode
(
'
,
'
, [
User::
ROLE_RECORDER
,
User::
ROLE_RECORDER_AND_VOICE
,
User::
ROLE_ANALYST
,
])],
Copy code to clipboard
Fix this →
Fix this →
3. Missing declare(strict_types=1) in CreateTeamRequest.php
3. Missing
declare(strict_types=1)
in
CreateTeamRequest.php
EditTeamRequest.php
has it (line 3), but
CreateTeamRequest.php
does not. Per project rules, all PHP files must declare
strict_types=1
. Since this file is already being modified, this is the right moment to add it.
Nits
Nits
getOwnerRole()
uses
$this->input()
instead of
$this->validated()
— consistent with
getOwnerEmail()
in the same file, so not a blocker, but
validated()
is technically safer since it only returns data that passed validation.
ownerRoleOptions
is in
<script setup>
— in Vue 3,
<script setup>
runs once per instance. Since it's a static array, it's fine functionally, but moving it to the module-level
<script>
block alongside the other constants (e.g.,
SOFTPHONE_FEATURE_ID
,
syncPeriodOptions
) would be more consistent.
No validation test for
CreateTeamRequest
— there's no test verifying that invalid
owner_role
values (e.g.,
"admin"
,
""
) are rejected. The DTO tests exercise the happy path well, but a
Request
validation test would give more confidence.
What looks good
What looks good
The...
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52522
|
|
52525
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
Jiminny
Jiminny
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 8 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 129 additions & 18 deletions
Conversation (5)
Conversation
(
5
)
Commits (8)
Commits
(
8
)
Checks (3)
Checks
(
3
)
Files changed (6)
Files changed
(
6
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 8 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 8 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 2 hours ago
LakyLak
LakyLak
commented
2 hours ago
2 hours ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
2 hours ago
2 hours ago
New changes since you last viewed
View changes
View changes
LakyLak
LakyLak
and others
added
4
commits
2 hours ago
2 hours ago
@LakyLak
JY-20613
JY-20613
fix tests
fix tests
12 / 12 checks OK
b7df560
b7df560
@nikolay-yankov
JY-20613
JY-20613
Add Owner Role field
Add Owner Role field
2864624
2864624
@nikolay-yankov
Merge branch '
Merge branch '
JY-20613
JY-20613
-allow-owner-role-on-team-setup' of github.com:…
-allow-owner-role-on-team-setup' of github.com:…
Commit message body
0 / 2 checks OK
d2d5ccc
d2d5ccc
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20613
JY-20613
-allow-owner-role-on-team-setup
-allow-owner-role-on-team-setup
20 / 21 checks OK
190239d
190239d
@nikolay-yankov
Show options
nikolay-yankov commented 1 hour ago
nikolay-yankov
nikolay-yankov
commented
1 hour ago
1 hour ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 1 hour ago •
claude
claude
Bot
commented
1 hour ago
1 hour ago
•
edited
edited
Claude finished
@nikolay-yankov
@nikolay-yankov
's task in 2m 4s
——
View job
View job
Code Review: Allow owner's role to be selected when setting up a trial
Code Review: Allow owner's role to be selected when setting up a trial
Completed task
Gather context
Completed task
Read changed files
Completed task
Analyze and review code
Completed task
Post review findings...
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52525
|
|
52526
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
Jiminny
Jiminny
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 8 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 129 additions & 18 deletions
Conversation (5)
Conversation
(
5
)
Commits (8)
Commits
(
8
)
Checks (3)
Checks
(
3
)
Files changed (6)
Files changed
(
6
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 8 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 8 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 2 hours ago
LakyLak
LakyLak
commented
2 hours ago
2 hours ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
2 hours ago
2 hours ago
New changes since you last viewed
View changes
View changes
LakyLak
LakyLak
and others
added
4
commits
2 hours ago
2 hours ago
@LakyLak
JY-20613
JY-20613
fix tests
fix tests
12 / 12 checks OK
b7df560
b7df560
@nikolay-yankov
JY-20613
JY-20613
Add Owner Role field
Add Owner Role field
2864624
2864624
@nikolay-yankov
Merge branch '
Merge branch '
JY-20613
JY-20613
-allow-owner-role-on-team-setup' of github.com:…
-allow-owner-role-on-team-setup' of github.com:…
Commit message body
0 / 2 checks OK
d2d5ccc
d2d5ccc
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20613
JY-20613
-allow-owner-role-on-team-setup
-allow-owner-role-on-team-setup
20 / 21 checks OK
190239d
190239d
@nikolay-yankov
Show options
nikolay-yankov commented 1 hour ago
nikolay-yankov
nikolay-yankov
commented
1 hour ago
1 hour ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 1 hour ago •
claude
claude
Bot
commented
1 hour ago
1 hour ago
•
edited
edited
Claude finished
@nikolay-yankov
@nikolay-yankov
's task in 2m 4s
——
View job
View job
Code Review: Allow owner's role to be selected when setting up a trial
Code Review: Allow owner's role to be selected when setting up a trial
Completed task
Gather context
Completed task
Read changed files
Completed task
Analyze and review code
Completed task
Post review findings
Overall, the implementation is clean and the intent is clear. A few issues worth addressing:...
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52526
|
|
52527
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
Jiminny
Jiminny
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 8 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 129 additions & 18 deletions
Conversation (5)
Conversation
(
5
)
Commits (8)
Commits
(
8
)
Checks (3)
Checks
(
3
)
Files changed (6)
Files changed
(
6
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 8 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 8 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 2 hours ago
LakyLak
LakyLak
commented
2 hours ago
2 hours ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
2 hours ago
2 hours ago
New changes since you last viewed
View changes
View changes
LakyLak
LakyLak
and others
added
4
commits
2 hours ago
2 hours ago
@LakyLak
JY-20613
JY-20613
fix tests
fix tests
12 / 12 checks OK
b7df560
b7df560
@nikolay-yankov
JY-20613
JY-20613
Add Owner Role field
Add Owner Role field
2864624
2864624
@nikolay-yankov
Merge branch '
Merge branch '
JY-20613
JY-20613
-allow-owner-role-on-team-setup' of github.com:…
-allow-owner-role-on-team-setup' of github.com:…
Commit message body
0 / 2 checks OK
d2d5ccc
d2d5ccc
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20613
JY-20613
-allow-owner-role-on-team-setup
-allow-owner-role-on-team-setup
20 / 21 checks OK...
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52527
|
|
52528
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
Jiminny
Jiminny
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 8 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 129 additions & 18 deletions
Conversation (5)
Conversation
(
5
)
Commits (8)
Commits
(
8
)
Checks (3)
Checks
(
3
)
Files changed (6)
Files changed
(
6
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 8 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 8 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 2 hours ago
LakyLak
LakyLak
commented
2 hours ago
2 hours ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
2 hours ago
2 hours ago
New changes since you last viewed
View changes
View changes
LakyLak
LakyLak
and others
added
4...
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52528
|
|
52551
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
Jiminny
Jiminny
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app...
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52551
|
|
52553
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Usage | Windsurf
Usage | Windsurf
Feed — jiminny — Sentry
Feed — jiminny — Sentry
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Pipelines - jiminny/app
Pipelines - jiminny/app
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
CloudWatch | us-east-2
Jiminny
Jiminny
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app
Close tab
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
Allow owner's role to be selected when setting up a trial #12092 Edit title
Allow owner's role to be selected when setting up a trial
#
12092
Edit title
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 8 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Lines changed: 129 additions & 18 deletions
Conversation (5)
Conversation
(
5
)
Commits (8)
Commits
(
8
)
Checks (3)
Checks
(
3
)
Files changed (6)
Files changed
(
6
)
Open
Allow owner's role to be selected when setting up a trial #12092 LakyLak wants to merge 8 commits into master from JY-20613-allow-owner-role-on-team-setup Copy head branch name to clipboard
Allow owner's role to be selected when setting up a trial
Allow owner's role to be selected when setting up a trial
#
12092
LakyLak
LakyLak
wants to merge 8 commits into
master
master
from
JY-20613-allow-owner-role-on-team-setup
JY-20613-allow-owner-role-on-team-setup
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 2 hours ago
LakyLak
LakyLak
commented
2 hours ago
2 hours ago
JIRA: JY-20613
JIRA:
JY-20613
JY-20613
Changes:
Changes:
Add support for owner role
Add or remove reactions
@LakyLak
JY-20613
JY-20613
support owner role on setup team
support owner role on setup team
8 / 10 checks OK
6fae8bb
6fae8bb
@nikolay-yankov
nikolay-yankov
nikolay-yankov
changed the title
JY-20613 support owner role on setup team
Allow owner's role to be selected when setting up a trial
2 hours ago
2 hours ago
New changes since you last viewed
View changes
View changes
LakyLak
LakyLak
and others
added
4
commits
2 hours ago
2 hours ago
@LakyLak
JY-20613
JY-20613
fix tests
fix tests
12 / 12 checks OK
b7df560
b7df560
@nikolay-yankov
JY-20613
JY-20613
Add Owner Role field
Add Owner Role field
2864624
2864624
@nikolay-yankov
Merge branch '
Merge branch '
JY-20613
JY-20613
-allow-owner-role-on-team-setup' of github.com:…
-allow-owner-role-on-team-setup' of github.com:…
Commit message body
0 / 2 checks OK
d2d5ccc
d2d5ccc
@nikolay-yankov
Merge branch 'master' into
Merge branch 'master' into
JY-20613
JY-20613
-allow-owner-role-on-team-setup
-allow-owner-role-on-team-setup
20 / 21 checks OK
190239d
190239d
@nikolay-yankov
Show options
nikolay-yankov commented 1 hour ago
nikolay-yankov
nikolay-yankov
commented
1 hour ago
1 hour ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 1 hour ago •
claude
claude
Bot
commented
1 hour ago
1 hour ago
•
edited
edited
Claude finished
@nikolay-yankov
@nikolay-yankov
's task in 2m 4s
——
View job
View job
Code Review: Allow owner's role to be selected when setting up a trial
Code Review: Allow owner's role to be selected when setting up a trial
Completed task
Gather context
Completed task
Read changed files
Completed task
Analyze and review code
Completed task
Post review findings
Overall, the implementation is clean and the intent is clear. A few issues worth addressing:
Issues
Issues
1. Potential test flakiness — unordered whereIn results
1. Potential test flakiness — unordered
whereIn
results
UserInvitationDTO::forOwner
uses
Role::whereIn('name', [...])
which does
not
guarantee a consistent order from the database. All three new tests assert a specific order:
// tests/Feature/DTO/UserInvitationDTOTest.php:72, 101, 130
self
::
assertSame
([
$
adminRole
->
getId
(),
$
recorderRole
->
getId
()],
$
dto
->
roleIds
);
Copy code to clipboard
This could be silently flaky depending on query execution plan or DB state. Use
assertEqualsCanonicalizing
instead, which ignores order:
self
::
assertEqualsCanonicalizing
(
[
$
adminRole
->
getId
(),
$
recorderRole
->
getId
()],
$
dto
->
roleIds
);
Copy code to clipboard
Fix this →
Fix this →
2. Hardcoded role strings duplicate User::ROLE_* constants
2. Hardcoded role strings duplicate
User::ROLE_*
constants
CreateTeamRequest.php:26
:
'
owner_role
'
=> [
'
required
'
,
'
in:recorder,recorder_and_voice,analyst
'
],
Copy code to clipboard
These string literals duplicate the...
|
Firefox
|
Allow owner's role to be selected when setting Allow owner's role to be selected when setting up a trial by LakyLak · Pull Request #12092 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12092
|
52553
|