|
43354
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
43354
|
|
43355
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
Jiminny
Jiminny
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
Ask Gemini
WORK, Google Account: [EMAIL]
Main menu
Temporary chat
PRO
PRO
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Awaiting approval
Awaiting approval
Code
Code
Open
LakyLak
LakyLak
wants to merge 1 commit into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 10 additions & 5 deletions
Conversation (2)
Conversation
(
2
)
Commits (1)
Commits
(
1
)
Checks (4)
Checks
(
4
)
Files changed (2)
Files changed
(
2
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 1 commit into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 1 commit into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 3 hours ago
LakyLak
LakyLak
commented
3 hours ago
3 hours ago
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@sonarqubecloud
Show options
sonarqubecloud Bot commented 2 hours ago
sonarqubecloud
sonarqubecloud
Bot
commented
2 hours ago
2 hours ago
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
0.0% Coverage on New Code
0.0% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud
Add or remove reactions
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
2 hours ago
2 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
1 hour ago
1 hour ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
43355
|
|
43356
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
Jiminny
Jiminny
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
WORK, Google Account: [EMAIL]
Main menu
New Chat
Open menu for conversation actions.
Conversation with Gemini
Conversation with Gemini
Copy prompt
Edit
You said how to unpin slack message
You said
how to unpin slack message
Gemini said
Gemini said
Unpinning a message in Slack is straightforward,
though the steps vary slightly depending on whether you are using the desktop app or the mobile version.
On Desktop (Mac/Windows/Web)
On Desktop (Mac/Windows/Web)
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Stop response
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Gemini replied
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Awaiting approval
Awaiting approval
Code
Code
Open
LakyLak
LakyLak
wants to merge 1 commit into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 10 additions & 5 deletions
Conversation (2)
Conversation
(
2
)
Commits (1)
Commits
(
1
)
Checks (4)
Checks
(
4
)
Files changed (2)
Files changed
(
2
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 1 commit into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 1 commit into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 3 hours ago
LakyLak
LakyLak
commented
3 hours ago
3 hours ago
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@sonarqubecloud
Show options
sonarqubecloud Bot commented 2 hours ago
sonarqubecloud
sonarqubecloud
Bot
commented
2 hours ago
2 hours ago
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
0.0% Coverage on New Code
0.0% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud
Add or remove reactions
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
2 hours ago
2 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
1 hour ago
1 hour ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 1 hour ago
Vasil-Jiminny
Vasil-Jiminny
1 hour ago
1 hour ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM today
👍
1
Reply...
Resolve conversation...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
43356
|
|
43388
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
43388
|
|
43389
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
Jiminny
Jiminny
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
43389
|
|
43518
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Unnamed Group...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
43518
|
|
43519
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
Jiminny
Jiminny
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
WORK, Google Account: [EMAIL]
Main menu
New Chat
Open menu for conversation actions.
Conversation with Gemini
Conversation with Gemini
Copy prompt
Edit
You said how to unpin slack message
You said...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
43519
|
|
43520
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
Jiminny
Jiminny
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
WORK, Google Account: [EMAIL]
Main menu
New Chat
Open menu for conversation actions.
Conversation with Gemini
Conversation with Gemini
Copy prompt
Edit
You said how to unpin slack message
You said
how to unpin slack message
Listen
Gemini said
Gemini said
Unpinning a message in Slack is straightforward, though the steps vary slightly depending on whether you are using the desktop app or the mobile version.
On Desktop (Mac/Windows/Web)
On Desktop (Mac/Windows/Web)
Open the channel or DM
where the message is pinned.
Click the
Pinned
icon (the thumbtack) located just below the channel name or header at the top of the screen. This opens a sidebar showing all pinned items.
Find the message you want to unpin and
hover over it
.
Click the
"X"
icon that appears next to the message in the sidebar, then click
Remove
to confirm.
Alternative Method:
Find the message directly in the chat history, click the
three-dot icon
(More actions) on the message, and select
Unpin from channel
.
On Mobile (iOS/Android)
On Mobile (iOS/Android)
Tap the channel name
or the name of the person at the very top of the screen.
Select
Pins
from the menu options.
Long-press
the message you wish to remove (or tap the
"X"
if visible).
Tap
Unpin
(or
Remove
) when the confirmation prompt appears.
Key Things to Keep in Mind
Key Things to Keep in Mind
Permissions:
Depending on your workspace settings, you might need administrative permissions to unpin messages in certain channels.
Notifications:
When you unpin a message, Slack usually posts a small system notification in the channel letting everyone know the item was unpinned.
Pins vs. Bookmarks:
If you don't see the thumbtack icon, check the
Bookmarks
bar (the row of links just under the channel header). Some workspaces use bookmarks for important items instead of pins.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Unable to merge
Unable to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 1 commit into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 10 additions & 5 deletions
Conversation (2)
Conversation
(
2
)
Commits (1)
Commits
(
1
)
Checks (4)
Checks
(
4
)
Files changed (2)
Files changed
(
2
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 1 commit into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 1 commit into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented 3 hours ago
LakyLak
LakyLak
commented
3 hours ago
3 hours ago
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@sonarqubecloud
Show options
sonarqubecloud Bot commented 3 hours ago
sonarqubecloud
sonarqubecloud
Bot
commented
3 hours ago
3 hours ago
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
0.0% Coverage on New Code
0.0% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud
Add or remove reactions
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
2 hours ago
2 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
1 hour ago
1 hour ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 1 hour ago
Vasil-Jiminny
Vasil-Jiminny
1 hour ago
1 hour ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM today
👍
1
Reply...
Resolve conversation
Resolve conversation
@yalokin-jiminny
Show options
yalokin-jiminny commented 14 minutes ago
yalokin-jiminny
yalokin-jiminny
commented
14 minutes ago
14 minutes ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 13 minutes ago •
claude
claude
Bot
commented
13 minutes ago
13 minutes ago...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
43520
|
|
43570
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
Jiminny
Jiminny
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
WORK, Google Account: [EMAIL]
Main menu...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
43570
|
|
43571
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
Jiminny
Jiminny
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
WORK, Google Account: [EMAIL]
Main menu
New Chat
Open menu for conversation actions.
Conversation with Gemini
Conversation with Gemini
Copy prompt
Edit
You said how to unpin slack message
You said
how to unpin slack message
Listen
Gemini said
Gemini said
Unpinning a message in Slack is straightforward, though the steps vary slightly depending on whether you are using the desktop app or the mobile version.
On Desktop (Mac/Windows/Web)
On Desktop (Mac/Windows/Web)
Open the channel or DM
where the message is pinned.
Click the
Pinned
icon (the thumbtack) located just below the channel name or header at the top of the screen. This opens a sidebar showing all pinned items.
Find the message you want to unpin and
hover over it
.
Click the
"X"
icon that appears next to the message in the sidebar, then click
Remove
to confirm.
Alternative Method:
Find the message directly in the chat history, click the
three-dot icon
(More actions) on the message, and select
Unpin from channel
.
On Mobile (iOS/Android)
On Mobile (iOS/Android)...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
43571
|
|
43572
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
Jiminny
Jiminny
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
WORK, Google Account: [EMAIL]
Main menu
New Chat
Open menu for conversation actions.
Conversation with Gemini
Conversation with Gemini
Copy prompt
Edit
You said how to unpin slack message
You said
how to unpin slack message
Listen
Gemini said
Gemini said
Unpinning a message in Slack is straightforward, though the steps vary slightly depending on whether you are using the desktop app or the mobile version.
On Desktop (Mac/Windows/Web)
On Desktop (Mac/Windows/Web)
Open the channel or DM
where the message is pinned.
Click the
Pinned
icon (the thumbtack) located just below the channel name or header at the top of the screen. This opens a sidebar showing all pinned items.
Find the message you want to unpin and
hover over it
.
Click the
"X"
icon that appears next to the message in the sidebar, then click
Remove
to confirm.
Alternative Method:
Find the message directly in the chat history, click the
three-dot icon
(More actions) on the message, and select
Unpin from channel
.
On Mobile (iOS/Android)
On Mobile (iOS/Android)
Tap the channel name
or the name of the person at the very top of the screen.
Select
Pins
from the menu options.
Long-press
the message you wish to remove (or tap the
"X"
if visible).
Tap
Unpin
(or
Remove
) when the confirmation prompt appears.
Key Things to Keep in Mind
Key Things to Keep in Mind
Permissions:
Depending on your workspace settings, you might need administrative permissions to unpin messages in certain channels.
Notifications:
When you unpin a message, Slack usually posts a small system notification in the channel letting everyone know the item was unpinned.
Pins vs. Bookmarks:
If you don't see the thumbtack icon, check the
Bookmarks
bar (the row of links just under the channel header). Some workspaces use bookmarks for important items instead of pins.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (29)
Pull requests
(
29
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Checks pending
Checks pending
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 10 additions & 5 deletions
Conversation (2)
Conversation
(
2
)
Commits (2)
Commits
(
2
)
Checks (4)
Checks
(
4
)
Files changed (2)
Files changed
(
2
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
43572
|
|
43573
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
Jiminny
Jiminny
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
WORK, Google Account: [EMAIL]
Main menu
New Chat
Open menu for conversation actions.
Conversation with Gemini
Conversation with Gemini
Copy prompt
Edit
You said how to unpin slack message
You said
how to unpin slack message
Listen
Gemini said
Gemini said
Unpinning a message in Slack is straightforward, though the steps vary slightly depending on whether you are using the desktop app or the mobile version.
On Desktop (Mac/Windows/Web)
On Desktop (Mac/Windows/Web)
Open the channel or DM
where the message is pinned.
Click the
Pinned
icon (the thumbtack) located just below the channel name or header at the top of the screen. This opens a sidebar showing all pinned items.
Find the message you want to unpin and
hover over it
.
Click the
"X"
icon that appears next to the message in the sidebar, then click
Remove
to confirm.
Alternative Method:
Find the message directly in the chat history, click the
three-dot icon
(More actions) on the message, and select
Unpin from channel
.
On Mobile (iOS/Android)
On Mobile (iOS/Android)
Tap the channel name
or the name of the person at the very top of the screen.
Select
Pins
from the menu options.
Long-press
the message you wish to remove (or tap the
"X"
if visible).
Tap
Unpin
(or
Remove
) when the confirmation prompt appears.
Key Things to Keep in Mind
Key Things to Keep in Mind
Permissions:
Depending on your workspace settings, you might need administrative permissions to unpin messages in certain channels.
Notifications:
When you unpin a message, Slack usually posts a small system notification in the channel letting everyone know the item was unpinned.
Pins vs. Bookmarks:
If you don't see the thumbtack icon, check the
Bookmarks
bar (the row of links just under the channel header). Some workspaces use bookmarks for important items instead of pins.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message
Your Jiminny chats aren’t used to improve our models. Gemini is AI. It can make mistakes, so double check it.
Your privacy & Gemini Opens in a new window
Your privacy & Gemini
Opens in a new window
Summarize page
Summarize page
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
43573
|
|
43574
|
Unnamed Group
Platform Sprint 4 Q2 - Platform Team Unnamed Group
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
Usage | Windsurf
Usage | Windsurf
Unnamed Group
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
[JY-20891] Sidekick SMS issue - Jira
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Unnamed Group
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[SRD-6849] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
[JY-20903] Recorded call does not appear on the dashboard - Jira
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Jiminny
Unnamed Group
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Configure SSH access to multiple environment - Engineering - Confluence
Configure SSH access to multiple environment - Engineering - Confluence
Useful commands - Engineering - Confluence
Useful commands - Engineering - Confluence
Unnamed Group
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
[JY-20904] Fix UpdateActivityElasticSearchDocumentCommand - Jira
Jiminny
Jiminny
New Tab
Customize sidebar
Close Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
AI Chat settings
Close
WORK, Google Account: [EMAIL]
Main menu
New Chat
Open menu for conversation actions.
Conversation with Gemini
Conversation with Gemini
Copy prompt
Edit
You said how to unpin slack message
You said
how to unpin slack message
Listen
Gemini said
Gemini said
Unpinning a message in Slack is straightforward, though the steps vary slightly depending on whether you are using the desktop app or the mobile version.
On Desktop (Mac/Windows/Web)
On Desktop (Mac/Windows/Web)
Open the channel or DM
where the message is pinned.
Click the
Pinned
icon (the thumbtack) located just below the channel name or header at the top of the screen. This opens a sidebar showing all pinned items.
Find the message you want to unpin and
hover over it
.
Click the
"X"
icon that appears next to the message in the sidebar, then click
Remove
to confirm.
Alternative Method:
Find the message directly in the chat history, click the
three-dot icon
(More actions) on the message, and select
Unpin from channel
.
On Mobile (iOS/Android)
On Mobile (iOS/Android)
Tap the channel name
or the name of the person at the very top of the screen.
Select
Pins
from the menu options.
Long-press
the message you wish to remove (or tap the
"X"
if visible).
Tap
Unpin
(or
Remove
) when the confirmation prompt appears.
Key Things to Keep in Mind
Key Things to Keep in Mind
Permissions:
Depending on your workspace settings, you might need administrative permissions to unpin messages in certain channels.
Notifications:
When you unpin a message, Slack usually posts a small system notification in the channel letting everyone know the item was unpinned.
Pins vs. Bookmarks:
If you don't see the thumbtack icon, check the
Bookmarks
bar (the row of links just under the channel header). Some workspaces use bookmarks for important items instead of pins.
Good response
Bad response
Redo
Share & export
Copy
Show more options
Enter a prompt for Gemini
encrypted
Enter a prompt for Gemini
encrypted
Open upload file menu
Tools
Open mode picker
Fast
Microphone
Send message...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
43574
|
|
46024
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Top Bar
Top Bar
Sidebar
Sidebar
Main Content
Main Content
Space navigation
Space navigation
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
Notifications
Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards
Create dashboard
Create dashboard
More actions for Dashboards
More actions for Dashboards
Operations
Operations
More actions for Operations
More actions for Operations
Confluence , (opens new window)
Confluence
, (opens new window)
Teams , (opens new window)
Teams
, (opens new window)
open menu
open menu
Customise sidebar
Customise sidebar
Resize side navigation panel
Spaces
Spaces
/
Jiminny (New)
Jiminny (New)
Platform Team
Platform Team
Add people
Add people
Board actions
Board actions
Share
Automation
Give feedback
Give feedback
Enter full screen
Enter full screen
Summary
Summary
Timeline
Timeline
Backlog
Backlog
Active sprints
Active sprints
Calendar
Calendar
Reports
Reports
Testing Board
Testing Board
List
List
Forms
Forms
Components
Components
Development
Development
Code
Code
Security
Security
Releases
Releases
6 more tabs
More
6
Add to navigation
As you type to search or apply filters, the board updates with work items to match.
Search on current page
Filter by assignee
Filter assignees by Lukas Kovalik
Filter assignees by Aneliya Angelova
Filter assignees by Nikolay Ivanov
Filter assignees by Nikolay Nikolov
Filter assignees by Steliyan Georgiev
Filter assignees by Unassigned
Epic
Epic
Type
Type
Quick filters
Quick filters
Complete sprint
Complete sprint
Sprint details
Sprint details
Group by Queries
Group
: Queries
Sprint insights
Sprint insights
View settings
View settings
More actions
More actions
Ready To Be Merged (2 work items)
Ready To Be Merged
(2 work items)
Ready For DEV
READY FOR DEV
In DEV
IN DEV
Code Review
CODE REVIEW
Create work item in Code Review
Create
Blocked
BLOCKED
Create work item in Blocked
Create...
|
Firefox
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira — Work...
|
github.com/jiminny/app/pull/12077
|
46024
|
|
46025
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Top Bar
Top Bar
Sidebar
Sidebar
Main Content
Main Content
Space navigation
Space navigation
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
Notifications
Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕
Board actions
Board actions
Processing Team
Processing Team
Board actions
Board actions
SE Kanban
SE Kanban
Board actions
Board actions
Service-Desk
Service-Desk
More actions for Service-Desk
More actions for Service-Desk
More spaces
More spaces
Filters
Filters
More actions for Filters
More actions for Filters
Dashboards
Dashboards
Create dashboard
Create dashboard
More actions for Dashboards
More actions for Dashboards
Operations
Operations
More actions for Operations
More actions for Operations
Confluence , (opens new window)
Confluence
, (opens new window)
Teams , (opens new window)
Teams
, (opens new window)
open menu
open menu
Customise sidebar
Customise sidebar
Resize side navigation panel
Spaces
Spaces
/
Jiminny (New)
Jiminny (New)
Platform Team
Platform Team
Add people
Add people
Board actions
Board actions
Share
Automation
Give feedback
Give feedback
Enter full screen
Enter full screen
Summary
Summary
Timeline
Timeline
Backlog
Backlog
Active sprints
Active sprints
Calendar
Calendar
Reports
Reports
Testing Board
Testing Board
List
List
Forms
Forms
Components
Components
Development
Development
Code
Code
Security
Security
Releases
Releases
6 more tabs
More
6
Add to navigation
As you type to search or apply filters, the board updates with work items to match.
Search on current page
Filter by assignee
Filter assignees by Lukas Kovalik
Filter assignees by Aneliya Angelova
Filter assignees by Nikolay Ivanov
Filter assignees by Nikolay Nikolov
Filter assignees by Steliyan Georgiev
Filter assignees by Unassigned
Epic
Epic
Type
Type
Quick filters
Quick filters
Complete sprint
Complete sprint
Sprint details
Sprint details
Group by Queries
Group
: Queries
Sprint insights
Sprint insights
View settings
View settings
More actions
More actions
Ready To Be Merged (2 work items)
Ready To Be Merged
(2 work items)
Ready For DEV
READY FOR DEV
In DEV
IN DEV
Code Review
CODE REVIEW
Create work item in Code Review
Create
Blocked
BLOCKED
Create work item in Blocked
Create
QA
QA
Create work item in QA
Create
PO Acceptance
PO ACCEPTANCE...
|
Firefox
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira — Work...
|
github.com/jiminny/app/pull/12077
|
46025
|
|
46026
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Transferring data from github.com…...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46026
|
|
46027
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Unable to merge
Unable to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 19 hours ago
Vasil-Jiminny
Vasil-Jiminny
19 hours ago
19 hours ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM yesterday
👍
1
Reply...
Resolve conversation
Resolve conversation
@yalokin-jiminny
Show options
yalokin-jiminny commented 18 hours ago
yalokin-jiminny
yalokin-jiminny
commented
18 hours ago
18 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 18 hours ago •
claude
claude
Bot
commented
18 hours ago
18 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData
method and the
FixActivitiesOpportunity
command.
app/Models/Activity.php
app/Models/Activity.php
Logic is correct.
The reordering makes sense:
// Before: only set stage if null (no reset on opportunity change)
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
.
.
.
}
// After: reset stage when opportunity changes, then fallback for null stage_id
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
$
this
->
opportunity_id
=
$
opportunity
->
id
;
$
this
->
stage_id
=
$
stage
?->id;
// may null out stage_id
}
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
// fallback still needed
Copy code to clipboard
The second
if
block is still needed — it handles cases where the opportunity didn't change but
stage_id
is
null
.
Observation:
The same pattern is NOT applied to the
UpdateCrmDataByStrategy::Account
branch (line 2156), which only sets opportunity when
$this->opportunity_id === null
. Since that branch never changes an existing opportunity, there's no stale stage risk — this asymmetry is intentional and correct.
Comment (line 2124):
Per project convention, comments should only be added for non-obvious quirks. The "why" here (avoiding stale stage) isn't immediately evident from the code alone, so the comment is borderline justified. That said, the code is readable enough without it — I'd lean toward removing it per the project rules, but it's not a blocker.
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Responding to Vasil's question
"Activity stage should be the stage at import, no?"
"Activity stage should be the stage at import, no?"
:
The command uses
$opportunity->getStageId()
— the
current
stage of the newly matched opportunity, not the stage at the time the activity was originally imported. This is a design decision:
If the activity had a
wrong
opportunity (cross-team mismatch), its previous stage was already wrong — restoring "stage at import" of the bad match doesn't help.
Setting the stage to the current state of the
correct
opportunity is the more consistent approach.
This seems intentional and correct given the purpose of the command (fixing mismatched opportunities).
Potential concern:
Opportunity::getStageId()
has a non-nullable
int
return type. If the opportunity somehow has a null
stage_id
in the DB, this would fail at runtime. The command should handle this case gracefully, e.g. catching the error or checking for null. That said, if
stage_id
is always guaranteed non-null for opportunities coming from the CRM match, this may be acceptable.
Test Coverage
Test Coverage
SonarQube reports
0.0% coverage on new code
. Per project rules (
CLAUDE.md
):
"Make sure the new code you write is covered by unit tests."
Tests are missing for:
Activity::updateActivityCrmData
— scenario where opportunity changes should reset
stage_id
Activity::updateActivityCrmData
— scenario where opportunity doesn't change,
stage_id
stays
FixActivitiesOpportunity
command — verifying
stage_id
is updated alongside
opportunity_id
This should be addressed before merging.
Overall
Overall
The logic itself is sound. The main gaps are
missing test coverage
(required by project rules) and a minor question about whether to keep the comment in
Activity.php
.
Add or remove reactions
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
approved these changes
17 hours ago
17 hours ago
View reviewed changes
View reviewed changes
@LakyLak
JY-20903
JY-20903
revert changes in command
revert changes in command
12 / 12 checks OK
e883ed5
e883ed5
@sonarqubecloud
Show options
sonarqubecloud Bot commented 17 hours ago
sonarqubecloud
sonarqubecloud
Bot
commented
17 hours ago
17 hours ago
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
0.0% Coverage on New Code
0.0% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud
Add or remove reactions
This branch has not been deployed
This branch has not been deployed
No deployments
Merge info
Merge info
Changes approved
Changes approved
1 approving review by reviewers with write access.
Changes approved
Expand 1 approval group
1 approval
Expand 2 pending reviews group
2 pending reviews
All checks have passed
All checks have passed
12 successful checks
Expand checks
This branch is out-of-date with the base branch
This branch is out-of-date with the base branch
Merge the latest changes from master into this branch. This merge commit will be associated with LakyLak.
Update branch
Update branch
Update branch options
Merging is blocked
Merging is blocked
All comments must be resolved.
Enable auto-merge
Enable auto-merge
Select merge method
You can also merge this with the command line.
View command line instructions.
Still in progress?
Convert to draft
Convert to draft
@LakyLak
Add a comment
Add a comment
Comment
Write
Write
Preview
Preview
Comment
Markdown is supported
Markdown
is supported
Paste, drop, or click to add files
Paste, drop, or click to add files
Close pull request
Close pull request
Comment
Remember, contributions to this repository should follow our
GitHub Community Guidelines
GitHub Community Guidelines
.
ProTip!
Add comments to specific lines under
Files changed
Files changed
.
Reviewers
@Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny approved these changes...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46027
|
|
46028
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Unable to merge
Unable to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 19 hours ago
Vasil-Jiminny
Vasil-Jiminny
19 hours ago
19 hours ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM yesterday
👍
1
Reply...
Resolve conversation
Resolve conversation
@yalokin-jiminny
Show options
yalokin-jiminny commented 18 hours ago
yalokin-jiminny
yalokin-jiminny
commented
18 hours ago
18 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 18 hours ago •
claude
claude
Bot
commented
18 hours ago
18 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData
method and the
FixActivitiesOpportunity
command.
app/Models/Activity.php
app/Models/Activity.php
Logic is correct.
The reordering makes sense:
// Before: only set stage if null (no reset on opportunity change)
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
.
.
.
}
// After: reset stage when opportunity changes, then fallback for null stage_id
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
$
this
->
opportunity_id
=
$
opportunity
->
id
;
$
this
->
stage_id
=
$
stage
?->id;
// may null out stage_id
}
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
// fallback still needed
Copy code to clipboard
The second
if
block is still needed — it handles cases where the opportunity didn't change but
stage_id
is
null
.
Observation:
The same pattern is NOT applied to the
UpdateCrmDataByStrategy::Account
branch (line 2156), which only sets opportunity when
$this->opportunity_id === null
. Since that branch never changes an existing opportunity, there's no stale stage risk — this asymmetry is intentional and correct.
Comment (line 2124):
Per project convention, comments should only be added for non-obvious quirks. The "why" here (avoiding stale stage) isn't immediately evident from the code alone, so the comment is borderline justified. That said, the code is readable enough without it — I'd lean toward removing it per the project rules, but it's not a blocker.
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Responding to Vasil's question
"Activity stage should be the stage at import, no?"
"Activity stage should be the stage at import, no?"
:
The command uses
$opportunity->getStageId()
— the
current
stage of the newly matched opportunity, not the stage at the time the activity was originally imported. This is a design decision:
If the activity had a
wrong
opportunity (cross-team mismatch), its previous stage was already wrong — restoring "stage at import" of the bad match doesn't help.
Setting the stage to the current state of the
correct
opportunity is the more consistent approach.
This seems intentional and correct given the purpose of the command (fixing mismatched opportunities).
Potential concern:
Opportunity::getStageId()
has a non-nullable
int
return type. If the opportunity somehow has a null
stage_id
in the DB, this would fail at runtime. The command should handle this case gracefully, e.g. catching the error or checking for null. That said, if
stage_id
is always guaranteed non-null for opportunities coming from the CRM match, this may be acceptable.
Test Coverage
Test Coverage
SonarQube reports
0.0% coverage on new code
. Per project rules (
CLAUDE.md
):
"Make sure the new code you write is covered by unit tests."
Tests are missing for:
Activity::updateActivityCrmData
— scenario where opportunity changes should reset
stage_id
Activity::updateActivityCrmData
— scenario where opportunity doesn't change,
stage_id
stays
FixActivitiesOpportunity
command — verifying
stage_id
is updated alongside
opportunity_id
This should be addressed before merging.
Overall
Overall
The logic itself is sound. The main gaps are
missing test coverage
(required by project rules) and a minor question about whether to keep the comment in
Activity.php
.
Add or remove reactions
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
approved these changes
17 hours ago
17 hours ago
View reviewed changes
View reviewed changes
@LakyLak
JY-20903
JY-20903
revert changes in command
revert changes in command
12 / 12 checks OK
e883ed5
e883ed5
@sonarqubecloud
Show options
sonarqubecloud Bot commented 17 hours ago
sonarqubecloud
sonarqubecloud
Bot
commented
17 hours ago
17 hours ago
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
0.0% Coverage on New Code
0.0% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud
Add or remove reactions
This branch has not been deployed
This branch has not been deployed
No deployments
Merge info
Merge info
Changes approved
Changes approved
1 approving review by reviewers with write access.
Changes approved
Expand 1 approval group
1 approval
Expand 2 pending reviews group
2 pending reviews
All checks have passed
All checks have passed
12 successful checks
Expand checks
This branch is out-of-date with the base branch
This branch is out-of-date with the base branch
Merge the latest changes from master into this branch. This merge commit will be associated with LakyLak.
Update branch
Update branch
Update branch options
Merging is blocked
Merging is blocked
All comments must be resolved.
Enable auto-merge
Enable auto-merge
Select merge method
You can also merge this with the command line.
View command line instructions.
Still in progress?
Convert to draft
Convert to draft
@LakyLak
Add a comment
Add a comment...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46028
|
|
46029
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Unable to merge
Unable to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 19 hours ago
Vasil-Jiminny
Vasil-Jiminny
19 hours ago
19 hours ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM yesterday
👍
1
Reply...
Resolve conversation
Resolve conversation
@yalokin-jiminny
Show options
yalokin-jiminny commented 18 hours ago
yalokin-jiminny
yalokin-jiminny
commented
18 hours ago
18 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 18 hours ago •
claude
claude
Bot
commented
18 hours ago
18 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData
method and the
FixActivitiesOpportunity
command.
app/Models/Activity.php
app/Models/Activity.php
Logic is correct.
The reordering makes sense:
// Before: only set stage if null (no reset on opportunity change)
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
.
.
.
}
// After: reset stage when opportunity changes, then fallback for null stage_id
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
$
this
->
opportunity_id
=
$
opportunity
->
id
;
$
this
->
stage_id
=
$
stage
?->id;
// may null out stage_id
}
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
// fallback still needed
Copy code to clipboard
The second
if
block is still needed — it handles cases where the opportunity didn't change but
stage_id
is
null
.
Observation:
The same pattern is NOT applied to the
UpdateCrmDataByStrategy::Account
branch (line 2156), which only sets opportunity when
$this->opportunity_id === null
. Since that branch never changes an existing opportunity, there's no stale stage risk — this asymmetry is intentional and correct.
Comment (line 2124):
Per project convention, comments should only be added for non-obvious quirks. The "why" here (avoiding stale stage) isn't immediately evident from the code alone, so the comment is borderline justified. That said, the code is readable enough without it — I'd lean toward removing it per the project rules, but it's not a blocker.
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Responding to Vasil's question
"Activity stage should be the stage at import, no?"
"Activity stage should be the stage at import, no?"
:
The command uses
$opportunity->getStageId()
— the
current
stage of the newly matched opportunity, not the stage at the time the activity was originally imported. This is a design decision:
If the activity had a
wrong
opportunity (cross-team mismatch), its previous stage was already wrong — restoring "stage at import" of the bad match doesn't help.
Setting the stage to the current state of the
correct
opportunity is the more consistent approach.
This seems intentional and correct given the purpose of the command (fixing mismatched opportunities).
Potential concern:
Opportunity::getStageId()
has a non-nullable
int
return type. If the opportunity somehow has a null
stage_id
in the DB, this would fail at runtime. The command should handle this case gracefully, e.g. catching the error or checking for null. That said, if
stage_id
is always guaranteed non-null for opportunities coming from the CRM match, this may be acceptable.
Test Coverage
Test Coverage
SonarQube reports
0.0% coverage on new code
. Per project rules (
CLAUDE.md
):
"Make sure the new code you write is covered by unit tests."
Tests are missing for:
Activity::updateActivityCrmData
— scenario where opportunity changes should reset
stage_id
Activity::updateActivityCrmData
— scenario where opportunity doesn't change,
stage_id
stays
FixActivitiesOpportunity
command — verifying
stage_id
is updated alongside
opportunity_id
This should be addressed before merging.
Overall
Overall
The logic itself is sound. The main gaps are
missing test coverage
(required by project rules) and a minor question about whether to keep the comment in
Activity.php
.
Add or remove reactions
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
approved these changes
17 hours ago
17 hours ago
View reviewed changes
View reviewed changes
@LakyLak
JY-20903
JY-20903
revert changes in command
revert changes in command
12 / 12 checks OK
e883ed5
e883ed5
@sonarqubecloud
Show options
sonarqubecloud Bot commented 17 hours ago
sonarqubecloud
sonarqubecloud
Bot
commented
17 hours ago
17 hours ago
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
0.0% Coverage on New Code
0.0% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46029
|
|
46030
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Unable to merge
Unable to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 19 hours ago
Vasil-Jiminny
Vasil-Jiminny
19 hours ago
19 hours ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM yesterday
👍
1
Reply...
Resolve conversation
Resolve conversation
@yalokin-jiminny
Show options
yalokin-jiminny commented 18 hours ago
yalokin-jiminny
yalokin-jiminny
commented
18 hours ago
18 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 18 hours ago •
claude
claude
Bot
commented
18 hours ago
18 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData
method and the
FixActivitiesOpportunity
command.
app/Models/Activity.php
app/Models/Activity.php
Logic is correct.
The reordering makes sense:
// Before: only set stage if null (no reset on opportunity change)
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
.
.
.
}
// After: reset stage when opportunity changes, then fallback for null stage_id
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
$
this
->
opportunity_id
=
$
opportunity
->
id
;
$
this
->
stage_id
=
$
stage
?->id;
// may null out stage_id
}
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
// fallback still needed
Copy code to clipboard
The second
if
block is still needed — it handles cases where the opportunity didn't change but
stage_id
is
null
.
Observation:
The same pattern is NOT applied to the
UpdateCrmDataByStrategy::Account
branch (line 2156), which only sets opportunity when
$this->opportunity_id === null
. Since that branch never changes an existing opportunity, there's no stale stage risk — this asymmetry is intentional and correct.
Comment (line 2124):
Per project convention, comments should only be added for non-obvious quirks. The "why" here (avoiding stale stage) isn't immediately evident from the code alone, so the comment is borderline justified. That said, the code is readable enough without it — I'd lean toward removing it per the project rules, but it's not a blocker.
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Responding to Vasil's question
"Activity stage should be the stage at import, no?"
"Activity stage should be the stage at import, no?"
:
The command uses
$opportunity->getStageId()
— the
current
stage of the newly matched opportunity, not the stage at the time the activity was originally imported. This is a design decision:
If the activity had a
wrong
opportunity (cross-team mismatch), its previous stage was already wrong — restoring "stage at import" of the bad match doesn't help.
Setting the stage to the current state of the
correct
opportunity is the more consistent approach.
This seems intentional and correct given the purpose of the command (fixing mismatched opportunities).
Potential concern:
Opportunity::getStageId()
has a non-nullable
int
return type. If the opportunity somehow has a null
stage_id
in the DB, this would fail at runtime. The command should handle this case gracefully, e.g. catching the error or checking for null. That said, if
stage_id
is always guaranteed non-null for opportunities coming from the CRM match, this may be acceptable.
Test Coverage
Test Coverage
SonarQube reports
0.0% coverage on new code
. Per project rules (
CLAUDE.md
):
"Make sure the new code you write is covered by unit tests."
Tests are missing for:
Activity::updateActivityCrmData
— scenario where opportunity changes should reset
stage_id
Activity::updateActivityCrmData
— scenario where opportunity doesn't change,
stage_id
stays
FixActivitiesOpportunity
command — verifying
stage_id
is updated alongside
opportunity_id
This should be addressed before merging.
Overall
Overall
The logic itself is sound. The main gaps are
missing test coverage
(required by project rules) and a minor question about whether to keep the comment in
Activity.php
.
Add or remove reactions
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
approved these changes
17 hours ago
17 hours ago
View reviewed changes
View reviewed changes
@LakyLak
JY-20903
JY-20903
revert changes in command
revert changes in command
12 / 12 checks OK
e883ed5
e883ed5
@sonarqubecloud
Show options
sonarqubecloud Bot commented 17 hours ago
sonarqubecloud
sonarqubecloud
Bot
commented
17 hours ago
17 hours ago
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
0.0% Coverage on New Code
0.0% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud
Add or remove reactions
This branch has not been deployed
This branch has not been deployed
No deployments
Merge info
Merge info
Changes approved
Changes approved
1 approving review by reviewers with write access.
Changes approved
Expand 1 approval group
1 approval
Expand 2 pending reviews group
2 pending reviews
All checks have passed
All checks have passed
12 successful checks
Expand checks
This branch is out-of-date with the base branch
This branch is out-of-date with the base branch
Merge the latest changes from master into this branch. This merge commit will be associated with LakyLak.
Update branch
Update branch
Update branch options
Merging is blocked
Merging is blocked
All comments must be resolved.
Enable auto-merge
Enable auto-merge
Select merge method
You can also merge this with the command line.
View command line instructions.
Still in progress?
Convert to draft
Convert to draft
@LakyLak
Add a comment
Add a comment
Comment
Write...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46030
|
|
46031
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Unable to merge
Unable to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 19 hours ago
Vasil-Jiminny
Vasil-Jiminny
19 hours ago
19 hours ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM yesterday
👍
1
Reply...
Resolve conversation
Resolve conversation
@yalokin-jiminny
Show options
yalokin-jiminny commented 18 hours ago
yalokin-jiminny
yalokin-jiminny
commented
18 hours ago
18 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 18 hours ago •
claude
claude
Bot
commented
18 hours ago
18 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData
method and the
FixActivitiesOpportunity
command.
app/Models/Activity.php
app/Models/Activity.php
Logic is correct.
The reordering makes sense:
// Before: only set stage if null (no reset on opportunity change)
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
.
.
.
}
// After: reset stage when opportunity changes, then fallback for null stage_id
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
$
this
->
opportunity_id
=
$
opportunity
->
id
;
$
this
->
stage_id
=
$
stage
?->id;
// may null out stage_id
}
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
// fallback still needed
Copy code to clipboard
The second
if
block is still needed — it handles cases where the opportunity didn't change but
stage_id
is
null
.
Observation:
The same pattern is NOT applied to the
UpdateCrmDataByStrategy::Account
branch (line 2156), which only sets opportunity when
$this->opportunity_id === null
. Since that branch never changes an existing opportunity, there's no stale stage risk — this asymmetry is intentional and correct.
Comment (line 2124):
Per project convention, comments should only be added for non-obvious quirks. The "why" here (avoiding stale stage) isn't immediately evident from the code alone, so the comment is borderline justified. That said, the code is readable enough without it — I'd lean toward removing it per the project rules, but it's not a blocker.
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Responding to Vasil's question
"Activity stage should be the stage at import, no?"
"Activity stage should be the stage at import, no?"
:
The command uses
$opportunity->getStageId()
— the
current
stage of the newly matched opportunity, not the stage at the time the activity was originally imported. This is a design decision:
If the activity had a
wrong
opportunity (cross-team mismatch), its previous stage was already wrong — restoring "stage at import" of the bad match doesn't help.
Setting the stage to the current state of the
correct
opportunity is the more consistent approach.
This seems intentional and correct given the purpose of the command (fixing mismatched opportunities).
Potential concern:
Opportunity::getStageId()
has a non-nullable
int
return type. If the opportunity somehow has a null
stage_id
in the DB, this would fail at runtime. The command should handle this case gracefully, e.g. catching the error or checking for null. That said, if
stage_id
is always guaranteed non-null for opportunities coming from the CRM match, this may be acceptable.
Test Coverage
Test Coverage
SonarQube reports
0.0% coverage on new code
. Per project rules (
CLAUDE.md
):
"Make sure the new code you write is covered by unit tests."
Tests are missing for:
Activity::updateActivityCrmData
— scenario where opportunity changes should reset
stage_id
Activity::updateActivityCrmData
— scenario where opportunity doesn't change,
stage_id
stays
FixActivitiesOpportunity
command — verifying
stage_id
is updated alongside
opportunity_id
This should be addressed before merging.
Overall
Overall
The logic itself is sound. The main gaps are
missing test coverage
(required by project rules) and a minor question about whether to keep the comment in
Activity.php
.
Add or remove reactions
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
approved these changes
17 hours ago
17 hours ago
View reviewed changes
View reviewed changes
@LakyLak
JY-20903
JY-20903
revert changes in command
revert changes in command
12 / 12 checks OK
e883ed5
e883ed5
@sonarqubecloud
Show options
sonarqubecloud Bot commented 17 hours ago
sonarqubecloud
sonarqubecloud
Bot
commented
17 hours ago
17 hours ago
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
0.0% Coverage on New Code
0.0% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud
Add or remove reactions
This branch has not been deployed
This branch has not been deployed
No deployments
Merge info
Merge info
Changes approved
Changes approved
1 approving review by reviewers with write access.
Changes approved
Expand 1 approval group
1 approval
Expand 2 pending reviews group
2 pending reviews
All checks have passed
All checks have passed
12 successful checks
Expand checks
This branch is out-of-date with the base branch
This branch is out-of-date with the base branch
Merge the latest changes from master into this branch. This merge commit will be associated with LakyLak.
Update branch
Update branch
Update branch options
Merging is blocked
Merging is blocked
All comments must be resolved.
Enable auto-merge
Enable auto-merge
Select merge method
You can also merge this with the command line.
View command line instructions.
Still in progress?
Convert to draft
Convert to draft
@LakyLak
Add a comment
Add a comment
Comment
Write
Write
Preview
Preview
Comment
Markdown is supported
Markdown
is supported
Paste, drop, or click to add files...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46031
|
|
46032
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Unable to merge
Unable to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 19 hours ago
Vasil-Jiminny
Vasil-Jiminny
19 hours ago
19 hours ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM yesterday
👍
1
Reply...
Resolve conversation
Resolve conversation
@yalokin-jiminny
Show options
yalokin-jiminny commented 18 hours ago
yalokin-jiminny
yalokin-jiminny
commented
18 hours ago
18 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 18 hours ago •
claude
claude
Bot
commented
18 hours ago
18 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData
method and the
FixActivitiesOpportunity
command.
app/Models/Activity.php
app/Models/Activity.php
Logic is correct.
The reordering makes sense:
// Before: only set stage if null (no reset on opportunity change)
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
.
.
.
}
// After: reset stage when opportunity changes, then fallback for null stage_id
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
$
this
->
opportunity_id
=
$
opportunity
->
id
;
$
this
->
stage_id
=
$
stage
?->id;
// may null out stage_id
}
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
// fallback still needed
Copy code to clipboard
The second
if
block is still needed — it handles cases where the opportunity didn't change but
stage_id
is
null
.
Observation:
The same pattern is NOT applied to the
UpdateCrmDataByStrategy::Account
branch (line 2156), which only sets opportunity when
$this->opportunity_id === null
. Since that branch never changes an existing opportunity, there's no stale stage risk — this asymmetry is intentional and correct.
Comment (line 2124):
Per project convention, comments should only be added for non-obvious quirks. The "why" here (avoiding stale stage) isn't immediately evident from the code alone, so the comment is borderline justified. That said, the code is readable enough without it — I'd lean toward removing it per the project rules, but it's not a blocker.
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Responding to Vasil's question
"Activity stage should be the stage at import, no?"
"Activity stage should be the stage at import, no?"
:
The command uses
$opportunity->getStageId()
— the
current
stage of the newly matched opportunity, not the stage at the time the activity was originally imported. This is a design decision:
If the activity had a
wrong
opportunity (cross-team mismatch), its previous stage was already wrong — restoring "stage at import" of the bad match doesn't help.
Setting the stage to the current state of the
correct
opportunity is the more consistent approach.
This seems intentional and correct given the purpose of the command (fixing mismatched opportunities).
Potential concern:
Opportunity::getStageId()
has a non-nullable
int
return type. If the opportunity somehow has a null
stage_id
in the DB, this would fail at runtime. The command should handle this case gracefully, e.g. catching the error or checking for null. That said, if
stage_id
is always guaranteed non-null for opportunities coming from the CRM match, this may be acceptable.
Test Coverage
Test Coverage
SonarQube reports
0.0% coverage on new code
. Per project rules (
CLAUDE.md
):
"Make sure the new code you write is covered by unit tests."
Tests are missing for:
Activity::updateActivityCrmData
— scenario where opportunity changes should reset
stage_id
Activity::updateActivityCrmData
— scenario where opportunity doesn't change,
stage_id
stays
FixActivitiesOpportunity
command — verifying
stage_id
is updated alongside
opportunity_id
This should be addressed before merging.
Overall
Overall
The logic itself is sound. The main gaps are
missing test coverage
(required by project rules) and a minor question about whether to keep the comment in
Activity.php
.
Add or remove reactions
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
approved these changes
17 hours ago
17 hours ago
View reviewed changes
View reviewed changes
@LakyLak
JY-20903
JY-20903
revert changes in command
revert changes in command
12 / 12 checks OK
e883ed5
e883ed5
@sonarqubecloud
Show options
sonarqubecloud Bot commented 17 hours ago
sonarqubecloud
sonarqubecloud
Bot
commented
17 hours ago
17 hours ago
Quality Gate Passed Quality Gate passed
Quality Gate Passed
Quality Gate passed
Issues
0 New issues
0 New issues
0 Accepted issues
0 Accepted issues
Measures
0 Security Hotspots
0 Security Hotspots
0.0% Coverage on New Code
0.0% Coverage on New Code
0.0% Duplication on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud
See analysis details on SonarQube Cloud
Add or remove reactions
This branch has not been deployed
This branch has not been deployed
No deployments
Merge info
Merge info
Changes approved
Changes approved
1 approving review by reviewers with write access.
Changes approved
Expand 1 approval group
1 approval
Expand 2 pending reviews group
2 pending reviews
All checks have passed
All checks have passed
12 successful checks
Expand checks
This branch is out-of-date with the base branch
This branch is out-of-date with the base branch
Merge the latest changes from master into this branch. This merge commit will be associated with LakyLak.
Update branch
Update branch
Update branch options
Merging is blocked
Merging is blocked
All comments must be resolved.
Enable auto-merge
Enable auto-merge
Select merge method
You can also merge this with the command line.
View command line instructions.
Still in progress?
Convert to draft
Convert to draft
@LakyLak
Add a comment
Add a comment
Comment
Write
Write
Preview
Preview...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46032
|
|
46138
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Close tab
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Top Bar
Top Bar
Sidebar
Sidebar
Main Content
Main Content
Space navigation
Space navigation
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
Notifications
Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions
Board actions
Capture Team
Capture Team
Board actions
Board actions
Enterprise Stability Issues 🤕
Enterprise Stability Issues 🤕...
|
Firefox
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira — Work...
|
github.com/jiminny/app/pull/12077
|
46138
|
|
46139
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Close tab
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to:
Top Bar
Top Bar
Sidebar
Sidebar
Main Content
Main Content
Space navigation
Space navigation
Collapse sidebar [
Collapse sidebar [
Switch sites or apps
Switch sites or apps
Go to your Jira homepage
Search, press enter to navigate to advanced search with your text query
Create
Create
Rovo Ask Rovo
Ask Rovo
Notifications
Notifications
Help
Help
Settings
Settings
[EMAIL]
[EMAIL]
For you
For you
Recent
Recent
Starred
Starred
Apps
Apps
More actions for Apps
More actions for Apps
Spaces
Spaces
Create space
Create space
More actions for spaces
More actions for spaces
Recent
Jiminny (New)
Jiminny (New)
Jiminny (New)
Create board
Create board
More actions for Jiminny (New)
More actions for Jiminny (New)
Platform Team
Platform Team
Board actions...
|
Firefox
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira — Work...
|
github.com/jiminny/app/pull/12077
|
46139
|
|
46140
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
github.com/jiminny/app/pull/12077
github.com/jiminny/app/pull/12077
Close tab
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Waiting for github.com…...
|
Firefox
|
Work — Mozilla Firefox
|
github.com/jiminny/app/pull/12077
|
46140
|
|
46141
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
FirefoxFileEditViewHistoryBookmarksProfilesToolsWindowHelp(ahlmeet.google.com/mie-gawc-dsi?authuser=lukas.kovalik%40jiminny.comNikolay Yankov (Presenting)52 ServiceE3 PromelAttentx MoP•X Schen Xo Curso X* Claude XС МОР ТКhttps://fiminny.atlassian.net/jra/software/c/projects/JJY/boards/37?selectedissue=JY-20846C Projects|Datado ©* ClaudePlatform Team %.Q Search boards00$ Sy-20739 / A JY-20846Ready To Be Merged 12 work temsMCP > Enable the AI to know details about the userO AUTYOK UEYv Sprint (16 work items)KLAOY JOR DEV 5~ DescriptionEnable the AI tool to know the details about the user that is asking the questions. It will use those detalls to know how tofilter the calls and deals.Panorama prompts isAJREPORTSBacklogД Jy-20076• provide the Al a tool that gives insights about the user - name, emali, team etc.• il the customer doesn't have the MCP feature enabled then they should be able to access the data:o use a feature fiag for the check - "MCP" add to Technical Settings for now• "Error: The Jiminny MCP Connector is not avallable for your account. Please contact your Jiminny CustomerSuccess Manager or our support team for heip."3 •e0+=Notify the user it a SS isdeleted but is used in AJSubtasks25% DoneAssigneeBacklog% JY-20848 implement get.me= Medium% Unassign...READY FOR DEVS9 JY-20849 manualtestingUnassign...READY FOR DEVSUpgrade BE Ibraries - MayMAINTENANEIbackiюgJy-19058= Medium8 Unassign...READY FOR DEV-address feedback for the tool9 Jy-20877structure= Medium• Nikolay V....Linked work itemsAdd linked work itemAlew ownerooSeiecied Whenl Sctunt Loatrial9:48 AM | Daily - PlatformC Dev@ 1.Code Review3X Improve Story~ DetailsAssigneeNkolay IvanowAssign to me2 Galya DimitrovaDevelopment* Q Open with VS Code1 branch8 commits1 pull request1 build14 hours agoOPENvomponontPlatformSub-ProductAdd optionsLabelsstory point esamatDaily - Platform - now100% L2Fri 15 May 9:48:53=07 8Q8• Fi 15 May 9:48L Al BookmarxsGroup: QueriesDEPLOY 3(Deadiine 25 May) Migratedepricated Gemini 3.1 FlashwosoTreД лл-г0вв0Setup test coverage forProphet in SonarDeployedЕ-л-1051[Deadline 17 June] Migratedepricated Gemini modelsNikolay YankovNikolay Iivanov3 othersSteliyan GeorgievLukas Kovalik1:39...
|
Firefox
|
Work — Mozilla Firefox
|
github.com/jiminny/app/pull/12077
|
46141
|
|
46142
|
ActivityFllesLateMoreFirefoxVIewMistorbookmarksPro ActivityFllesLateMoreFirefoxVIewMistorbookmarksProtllesToolsWindowmelpJiminny…..Toast# jiminny-bg# platform-tickets# product launches# random# releases# soha-office# support# thank-yous# the_people_of jimi...• Direct messages8P. Stoyan TomovP Galya Dimitrova E. Aneliya Angelova •€. Vasil Vasilev8. Stefka StoyanovaS: Todor Stamatov8. Mario Georgiev.. Nikolay Ivanov2o James Graham "Ro Stoyan Tanev MR. Steliyan Georgiev =. Petko Kashinski. Lukas Kovali.i: AppsG Jira CloudToastHomeAboutWeanesday, May 15thapproved by you and @llian KyuchukovYecterdavvToast APP 10:00 AMReview#12058JY-180911Update composer tosupport php 8.519 hours old - 260 fileschanged •nikolavbiaivanovAdded bv Toast for GitHubMergeabt#12066 JY-20725 add HSrate limit handling onactivities rematching1 davs old • 12 hlec.changedAdded by Toast for GitHubResolve Conflicts#11443 lest hubletslatency5 months old • 20 hles+ Aa €Mlib- scr• NewPlatform Sprint 4 Q2 - Platform Te@ JY-20903 Update activity stag XJY-20904 Fix UpdateActivityElastic• JY-20903 Update activity stage wf. JY-20891 add support for seconda* (SRD-6853) Moxso - Potential deaL New Tal• github.com/jimin,=jiminny / app 8<> Code !? Pull requests 31G. Agents • Actions Ш Wiki ® Security and quality ~ Insights {3 Settings@ On April 24 we'll start using GitHub Copilot interaction data for Al model training unless you opt out. Review this update and manage your preferences in vour GitHub account settings.JY-20903 Update activity stage when opportunity is changed #12077 •I1 Open LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change !@J Conversation 4• Commits 2 IChecks 3 Files changed 1Lakvlak commented vesterdavJIRA: JY-20903Changes:Reviewers@ Vasil-Jiminnynikolaybiaivanovyalokin-jiminny• Reset stage on activity if opportunity is changedStill in proaress? Convert to drattAssigneesNo one-assign yourselfo @ JY-20903 Update activity stage when opportunity is changed8dacodfLabelsNone yet• @ LakyLak requested review from Vasil-Jiminny, nikolaybiaivanov and yalokin-jiminny 20 hours agoProjectsNone yet• Vasil-Jiminny reviewed 19 hours agoView reviewed changesapp/Console/Commands/Activities/FixActivities0pportunity.php (Outdated123Sactivity->update( ['opportunity_id' => Sopportunity->getId()I):123 : Sactivprundatet'opportunity id' => Sopoortunity->aetido.'stage_id' = Sopportunity->getStageId(),No milestoneDevelopmentSuccessfully meraina this pull request may close these@ Vasil-Jiminny 19 hours ago.Activity stage should be the stage at import, no?(d1)None yetUnsubscribeYou're receiving notifications because you're watchingA Reply...Resolve conversation3 participants00€yalokin-jiminny commented 18 hours ago8 Lock conversationC 80 lbl I Daily - Platform • now A100% C43 &• Fri 15 May 9:48:56Q Type D to searchcode+6 -4 00020:...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46142
|
|
46143
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Unable to merge
Unable to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 19 hours ago
Vasil-Jiminny
Vasil-Jiminny
19 hours ago
19 hours ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM yesterday
👍
1
Reply...
Resolve conversation
Resolve conversation
@yalokin-jiminny
Show options
yalokin-jiminny commented 18 hours ago
yalokin-jiminny
yalokin-jiminny
commented
18 hours ago
18 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 18 hours ago •
claude
claude
Bot
commented
18 hours ago
18 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46143
|
|
46144
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Unable to merge
Unable to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46144
|
|
46145
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Unable to merge
Unable to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 19 hours ago
Vasil-Jiminny
Vasil-Jiminny
19 hours ago
19 hours ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM yesterday
👍
1
Reply...
Resolve conversation
Resolve conversation
@yalokin-jiminny
Show options
yalokin-jiminny commented 18 hours ago
yalokin-jiminny
yalokin-jiminny
commented
18 hours ago
18 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46145
|
|
46146
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Unable to merge
Unable to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46146
|
|
46147
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46147
|
|
46148
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46148
|
|
46149
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Unable to merge
Unable to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46149
|
|
46150
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
Show resolved
Show resolved
@yalokin-jiminny
Show options
yalokin-jiminny commented 18 hours ago
yalokin-jiminny
yalokin-jiminny
commented
18 hours ago
18 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 18 hours ago •
claude
claude
Bot
commented
18 hours ago
18 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData
method and the
FixActivitiesOpportunity
command.
app/Models/Activity.php
app/Models/Activity.php
Logic is correct.
The reordering makes sense:
// Before: only set stage if null (no reset on opportunity change)
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
.
.
.
}
// After: reset stage when opportunity changes, then fallback for null stage_id
if
(
$
opportunity
&&
$
this
->...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46150
|
|
46151
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
Show resolved
Show resolved
@yalokin-jiminny
Show options
yalokin-jiminny commented 18 hours ago
yalokin-jiminny
yalokin-jiminny
commented
18 hours ago
18 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 18 hours ago •
claude
claude
Bot
commented
18 hours ago
18 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData
method and the
FixActivitiesOpportunity
command.
app/Models/Activity.php
app/Models/Activity.php
Logic is correct.
The reordering makes sense:
// Before: only set stage if null (no reset on opportunity change)
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
.
.
.
}
// After: reset stage when opportunity changes, then fallback for null stage_id
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
$
this
->
opportunity_id
=
$
opportunity
->
id
;
$
this
->
stage_id
=
$
stage
?->id;
// may null out stage_id
}
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
// fallback still needed
Copy code to clipboard
The second...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46151
|
|
46152
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
Show resolved
Show resolved
@yalokin-jiminny
Show options
yalokin-jiminny commented 18 hours ago
yalokin-jiminny
yalokin-jiminny
commented
18 hours ago
18 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 18 hours ago •
claude
claude
Bot
commented
18 hours ago
18 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData
method and the
FixActivitiesOpportunity
command.
app/Models/Activity.php
app/Models/Activity.php
Logic is correct.
The reordering makes sense:
// Before: only set stage if null (no reset on opportunity change)
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
....
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46152
|
|
46153
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
Show resolved
Show resolved
@yalokin-jiminny
Show options
yalokin-jiminny commented 18 hours ago
yalokin-jiminny
yalokin-jiminny
commented
18 hours ago
18 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 18 hours ago •
claude
claude
Bot
commented
18 hours ago
18 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData
method and the
FixActivitiesOpportunity
command.
app/Models/Activity.php
app/Models/Activity.php
Logic is correct.
The reordering makes sense:
// Before: only set stage if null (no reset on opportunity change)
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
.
.
.
}
// After: reset stage when opportunity changes, then fallback for null stage_id
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
$
this
->
opportunity_id
=
$
opportunity
->
id
;
$
this
->
stage_id
=
$
stage
?->id;
// may null out stage_id
}
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
// fallback still needed
Copy code to clipboard
The second
if
block is still needed — it handles cases where the opportunity didn't change but
stage_id
is
null
.
Observation:
The same pattern is NOT applied to the
UpdateCrmDataByStrategy::Account
branch (line 2156), which only sets opportunity when
$this->opportunity_id === null
. Since that branch never changes an existing opportunity, there's no stale stage risk — this asymmetry is intentional and correct.
Comment (line 2124):
Per project convention, comments should only be added for non-obvious quirks. The "why" here (avoiding stale stage) isn't immediately evident from the code alone, so the comment is borderline justified. That said, the code is readable enough without it — I'd lean toward removing it per the project rules, but it's not a blocker.
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Responding to Vasil's question
"Activity stage should be the stage at import, no?"
"Activity stage should be the stage at import, no?"
:
The command uses
$opportunity->getStageId()
— the
current
stage of the newly matched opportunity, not the stage at the time the activity was originally imported. This is a design decision:
If the activity had a
wrong
opportunity (cross-team mismatch), its previous stage was already wrong — restoring "stage at import" of the bad match doesn't help.
Setting the stage to the current state of the
correct
opportunity is the more consistent approach.
This seems intentional and correct given the purpose of the command (fixing mismatched opportunities).
Potential concern:
Opportunity::getStageId()
has a non-nullable
int
return type. If the opportunity somehow has a null
stage_id
in the DB, this would fail at runtime. The command should handle this case gracefully, e.g. catching the error or checking for null. That said, if
stage_id
is always guaranteed non-null for opportunities coming from the CRM match, this may be acceptable.
Test Coverage
Test Coverage...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46153
|
|
46154
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
Show resolved...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46154
|
|
46155
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
Show resolved
Show resolved
@yalokin-jiminny
Show options
yalokin-jiminny commented 18 hours ago
yalokin-jiminny
yalokin-jiminny
commented
18 hours ago
18 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 18 hours ago •
claude
claude
Bot
commented
18 hours ago
18 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46155
|
|
46156
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
Show resolved
Show resolved
@yalokin-jiminny
Show options
yalokin-jiminny commented 18 hours ago
yalokin-jiminny
yalokin-jiminny
commented
18 hours ago
18 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 18 hours ago •
claude
claude
Bot
commented
18 hours ago
18 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData
method and the
FixActivitiesOpportunity
command.
app/Models/Activity.php
app/Models/Activity.php
Logic is correct.
The reordering makes sense:
// Before: only set stage if null (no reset on opportunity change)
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
.
.
.
}
// After: reset stage when opportunity changes, then fallback for null stage_id
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
$
this
->
opportunity_id
=
$
opportunity
->
id
;
$
this
->
stage_id
=
$
stage
?->id;
// may null out stage_id
}
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
// fallback still needed
Copy code to clipboard
The second
if
block is still needed — it handles cases where the opportunity didn't change but
stage_id
is
null
.
Observation:
The same pattern is NOT applied to the
UpdateCrmDataByStrategy::Account
branch (line 2156), which only sets opportunity when
$this->opportunity_id === null
. Since that branch never changes an existing opportunity, there's no stale stage risk — this asymmetry is intentional and correct.
Comment (line 2124):
Per project convention, comments should only be added for non-obvious quirks. The "why" here (avoiding stale stage) isn't immediately evident from the code alone, so the comment is borderline justified. That said, the code is readable enough without it — I'd lean toward removing it per the project rules, but it's not a blocker.
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46156
|
|
46157
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
Show resolved
Show resolved
@yalokin-jiminny
Show options
yalokin-jiminny commented 18 hours ago
yalokin-jiminny
yalokin-jiminny
commented
18 hours ago...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46157
|
|
46158
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
Show resolved
Show resolved
@yalokin-jiminny
Show options
yalokin-jiminny commented 18 hours ago
yalokin-jiminny
yalokin-jiminny
commented
18 hours ago
18 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 18 hours ago •
claude
claude
Bot
commented
18 hours ago
18 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData
method and the
FixActivitiesOpportunity
command.
app/Models/Activity.php
app/Models/Activity.php
Logic is correct.
The reordering makes sense:
// Before: only set stage if null (no reset on opportunity change)
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
....
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46158
|
|
46159
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
Show resolved
Show resolved
@yalokin-jiminny
Show options
yalokin-jiminny commented 18 hours ago
yalokin-jiminny
yalokin-jiminny
commented
18 hours ago
18 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 18 hours ago •
claude
claude
Bot
commented
18 hours ago
18 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData
method and the
FixActivitiesOpportunity
command.
app/Models/Activity.php
app/Models/Activity.php
Logic is correct.
The reordering makes sense:
// Before: only set stage if null (no reset on opportunity change)
if
(
$
this
->
stage_id
===
null
&&
$...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46159
|
|
46206
|
FirefoxFileToolsWindow(ahl| Daily - Platform • now FirefoxFileToolsWindow(ahl| Daily - Platform • now100% <8• Fri 15 May 9:52:36EditViewHistoryBookmarksProfiles→Helpmeet.google.com/mie-gawc-dsi?authuser=lukas.kovalik%40jiminny.comNikolay Yankov (Presenting)=07 8+51 ServiceE3 JmirE83 Promp:Athenthttps://fiminny.atlassian.net/jra/software/c/projects/JJY/boards/37?selectedissue=JY-20833C Projects|Platform Team %.Q Search boards009 J1-207391 1 J-2983SReady To Be Merged (2 work tems)O AUTYOK UEVSprint (16 work itema)RLADY JOR DEVSPanorama prompts isAJREPORTSBacklogД JY-200763 •ea+=Notify the user il a SS isdeleted but is used in AJReportAKEVOKTBacklogWtetotUpgrade BE Ibraries - MayMAINTENANEISbackiоg@ Jy-19058Selected When Setureuoatrial• the proper authentication wil be done in a separate storysubtaskswOrkovt"zudse toottorgeccal9 Jy-20854 tool for list._calloptions9JY-20855aoe mistne cal mot0t(summanies, scoon kems, key point.CoJY-20856 manual tesoog% Jy-20857 rate limits% JY-20858 featurefiag% JY-20889 address changes on the tool structure% JY-20890 add emalls in ES% JY-20905 tool searchumembersLinked work itemsAdd linked work itemConfluence contentPriority= Medium= Medium= Medium= Medium= Medium= Medium= Medium= Medium= Medium83 MCP -(a Schero Cursor X * Claude XE Datadog* ClaudelSoteeUnassign...8 Unassign...wulbssleUnassionN xoidyNkolay VY...8 Unassign...•.•+20% DoneREADY FOR DEVSBAOTORDYRAOTORDWAOYFOR DEVNKATDORUEYС моР Т@ 1.In DevIz Improve Story~ DetailsAssignee•Nkolay NikolowAssign to me2 Galya DimitrovaDevelopment 3*© Open with VS CodeIJ Create b4 Create col1 pull request1 build incompletewomponentPlatformSub-ProductAdd optionsLabetsstory point esomateC Dev8• Fri 16 May 9:52AwamereStefka StoyanovaNikolay IvanovBERLOT(Deadline 25 May) Migrateemwra moooД л-20880Setup test coverage forProphet in SonarMASNTENANCEDeployed8 л-1051[Deadiine 17 June] Migratedepricated Gemini models3 othersNikolay Yankov9:52 AM | Daily - Platform→Lukas Kovalik5:22...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46206
|
|
46207
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 19 hours ago
Vasil-Jiminny
Vasil-Jiminny
19 hours ago
19 hours ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM yesterday
👍
1
Reply...
Resolve conversation
Resolve conversation
@yalokin-jiminny
Show options
yalokin-jiminny commented 18 hours ago
yalokin-jiminny
yalokin-jiminny
commented
18 hours ago
18 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 18 hours ago •
claude
claude
Bot
commented
18 hours ago
18 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46207
|
|
46208
|
Jiminny ... ~# jiminny-bg# platform-ticketsic prod Jiminny ... ~# jiminny-bg# platform-ticketsic productlaunches# random# releases# sofia-office# support# thank-yous# the_people_of jimi...• Direct messages88. Stoyan TomovP Galya Dimitrova EP. Aneliya Angelova M€. Vasil VasilevA. Stefka StoyanovaS: Todor Stamatov8. Mario Georgiev.. Nikolay Ivanov2o James Graham "Ro Stoyan Tanev MR. Steliyan Georgiev =. Petko Kashinski. Lukas Kovali.i: AppsG Jira Cloud® ToastQ Describe what you are looking for# releases8 22• Messages( Filese Bookmarks20881): UpgiToday~ y Volume #2#512 stelivan-gGitHub APP 9:35 AM1u new commits pusnea to master oy(574b5a61 - Switched deprecated get)metnoas to input and nixed merzelogic for Lapier recuests to prevent en-Us trom Slioping in as correct languageocts4ber - Merge dranch master intoJy-20708-nx-request-handling-for-zapier642c811a - JY-20708 More tall satesand logginga548fbbe - JY-20908 Fixing to logs6604f8-2 - Y-20208 nxed svntaxerrorShow morejiminny/app Added by GitHubcirc ec APP 9-42 AMI• New commits denloved to Prophet Prod.5991oel(https://github.com/jiminny/prophet/commit/759976e18aa28d3b66030eebb36d908a92461266- Y-20881|(https://jiminny.atlassian.net/browse/JY-Message #releases+ Aa I• github.oMlib- scr2 scrPlatform Sprint 4 Q2 - Platform TeJY-20903 Uodate activity stac XJY-20904 Fix UpdateActivityElasticJY-20903 Update activity stac XJY-20891 add support for second:* (SRD-6853) Moxso - Potential deaActivityLaterMore‹ $0 lil • | Daily -Platform • nowX 100% C/ 8 • Fri 15 May 9:52:36.JY-20903 Update activity stage when opportunity is changed #12077LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-changeSummaryThe PRresets stage_id when the opportunity on an activity changes, to avoid carrying over a stale stage from apreviously matched opportunity. The change is in two places: the model's updateActivityCrmData method and theFixActivities0pportunity command.app/Models/Activity.phpLogic is correct. The reordering makes sense:// Before: only set stage if null (no reset on opportunity change)1T (sch1s→>Stage 10 === null dd Sstage) 1 ... Jif (Sopportunity && Sthis->opportunity_id !== Sopportunity→>id) { ... }// After: reset stage when opportunity changes, then fallback for null stage_idif (Sopportunity && $this->opportunity_id !== $opportunity->id) {pines-popportundlyde= sopportunalyeedSthis->stade id = Sstage?->id: // mav null out stage idSô +The second if block is still needed — it handles cases where the opportunity didn't change but stage id is null.Observation: The same pattern is NOT applied to the UpdateCrmDataByStrategy::Account branch (line 2156), whichonly sets opportunity when Sthis->opportunity_id === null. Since that branch never changes an existingonnortunitv there's no stale stage risk — this asvmmetrv is intentional and correctiComment (line 2124): Per project convention, comments should only be added for non-obvious quirks. The "why" here(avoiding stale stage) isn't immediately evident from the code alone, so the comment is borderline justified. That said,the code is readable enouah without it — I'd lean toward removina it ner the proiect rules but it's not a blockerlapp/Console/Commands/Activities/FixActivities0pportunity.phpResponding to Vasil's question "Activity stage should be the stage at import, no?":The command uses $opportunity->getStageId() - the current stage of the newly matched opportunity, not thestage at the time the activity was oriainallv imported. This is a desian decision:• If the activity had a wrong opportunity (cross-team mismatch), its previous stage was already wrong — restoring"stage at import" of the bad match doesn't help.• Setting the stage to the current state of the correct opportunity is the more consistent approach.This seems intentional and correct given the purpose of the command (fixing mismatched opportunities)Potential concern: Ooportunitv::getStageld() has anon-nullable int return tvpe. If the opportunity somehow has alnull stage_id in the DB, this would fail at runtime. The command should handle this case gracefully, e.g. catching theerror or checking for null. That said, if stage_id is always guaranteed non-null for opportunities coming from the CRMmatch this mav he accentableTest Coverage...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46208
|
|
46209
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
Close tab
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46209
|
|
46210
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46210
|
|
46211
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 19 hours ago
Vasil-Jiminny
Vasil-Jiminny
19 hours ago
19 hours ago
Activity stage should be the stage at import, no?
Add or remove reactions...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46211
|