|
46224
|
Activity MonitorFilelEditViewWindowHelp(ahlmeet.go Activity MonitorFilelEditViewWindowHelp(ahlmeet.google.com/mie-gawc-dsi?authuser=lukas.kovalik%40jiminny.comDaily - Platform - now100% L2Fri 15 May 9:53:1957|07 8=Nikolay Yankov (Presenting)57 ServiceE3 SminE83 PromelAthent* MoP-XK Scher xo Curso X * Claude Xhttps://fiminny.atlassian.net/jra/software/c/projects/JJY/boards/37?selectedissue=JY-20835C Projects|Datadog* CauờiPlatform Team %.Q Search board$ SY-20739 / A JY-20835Ready To Be Merged (2 work tema)MCP > Enable users to get a list of deals and their detailsOAUTTOKUYv Sprint (16 work items)RLADY JOR DEV 5Panorama prompts isCwOOUDUOUAAU RiPORTBacklogД JY-200763 -.=0Notify the user il a SS isdeleted but is used in AJBacklogWtowotD~ DescriptionEnable customers to brainstorm in their Al tool using the information from their Jiminny deals.• allow users to search for deals through their Al and find the deals they are looking foro if nothing can be found that matches the user's search then show an appropriate error message - "Resuft: No dealsfound matching your criteria. Try searching by a different account name, adjusting the date range, or checking thedeal name in Jiminny."• allow users to get any relevant details about each deal - owner, amount, stage, account/contacts, all CRM fieids whichare stored in vimininy por bt and for chow talng), acunioes (cars, cmars)• each user should be able to access the same deals they can access in Jiminny - based on the Team Visibillty settings• Il the customer doesn't have the MCP feature enabled then they shouldn't be able to access the data:• "Error: The Jiminny MCP Connector is not avallable for your account, Please contact your Jiminny CustomerSuccess Manager or our support team for heip."|• ensure appropriate error message is shown when rate limits are hit - do we have such?• *Error: Rate limit exceeded. Too many requests have been made to the Jiminny MCP server in a short period.Please wait 60 seconds before retrying."Upgrade BE Ibraries - MayMAINTENANEISbackiоg@ JY-19958Note: here you can find example prompts for testing - E) Prompts and SkiltsSubtasks..•_ -0% DoneAixwownerSeiected When Sctone LoatrialPriorityStor...ASSRAR*xIIn Dev v~ DetailsAssigneeNkolay IvanowAssign to me2 Galya DimitrovaDevelopmentQ Open with VS Code1 branch1 commit11 Create pull request |componenttPlatformSub-ProductAdd optionsLabeisNookStory point estimateС МОР Тinsights & Coachin…C DevSminiGroup: Queries8• Fr 15 May 9:53L Al BookmarxsStefka StoyanovaNikolay IvanovI Improve StoryBERLOT(Deadiine 25 May) Migratedepricated Gemini 3.1 Flashemr mooowgoyCeД л-20880Setup test coverage forProphet in SonarMAINTENANCDeployedЕ л-151110=(Deadline 17 June] Migratedepricated Gemini models©3-202723 othersNikolay Yankov9:53 AM | Daily - PlatformLukas Kovalik6:05...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46224
|
|
46225
|
ActivityLateMoreActvity MonitorJiminny ...# jiminn ActivityLateMoreActvity MonitorJiminny ...# jiminny-bg# platform-ticketsic productlaunches# random# releases# soha-office# support#t thank-vous# the people of jimi..ó- Direct messagesStoyan TomovGalva Dimitrova. Aneliya Angelova• Vasil VasilevN Stefka StovanovaSe: Todor StamatovN Mario GeorgievNikolay Ivanova James Graham *o Stoyan Tanevd Stelivan Georgievf Petko KashinskiLukas Kovali.#: Apps" Jira Cloud8 ToastViewWindownelpDescribe wnat you are lookins for# releases8 22Messagesr Filese Bookmarks20881): UpgiToday v iy Volume #2#512 stelivan-gGitHub APP 9:35 AM1u new commits pusnea to master by574b5a61 - Switched deprecated get()metnoas to input and nixed merzelogic for Lapier recuests to prevent en-Us trom Slioping in as correct languageocts4ber - Merge dranch master intoJy-20708-nx-request-handling-for-zapier642c811a - JY-20708 More tall satesand logging0548fo%e -Y-20208 Fixing to logs6604f8-2 - Y-20208 nxed svntaxerronShow morejiminny/app Added by GitHubcirc ec APP 9-42 AMI• New commits denloved to Prophet P[URL_WITH_CREDENTIALS] Isolated Web ContentWindowServerFiretox GPU Helperkernel_taskcoreaudiod• Firefo›CleanShotXã FirefoxCP Socket ProcessscreenpipeFirefoxCP Isolated Web Contentcom.apple.DriverKit.AppleUserECM" iTermeapplehi3camerad19 Activity MonitonlaunchdWisor Flow Heloer (Renderer)bluetoothaW Wisor FlowNotion HelperNotion Helper (Renderer)Wispr Flow Helper (GPU)Wisor Flow Helner (Renderer)Notion Helper (RendererFinderlaunchservicesdin kandi KandiiAgent.ESF-ExtensionFirefo›Control CentreVTEncoderXPCServiceauditdFirefoxCP Isolated Web Contentcom.apole.ApoleUserHIDDriverssysmondtrustdThumbnailSxtension macosCPU Memoryidle Wake-Ups% CPU96,568,2Cpu Time10:59,549:54:46,0214:46,16Threads154,048,76:01:58,0926:50:35,952:01:46.8725,228:46,8222:31,2738,894:43,6542:12,0916,2324,802:14:11.235:42,8128:15,5442:54,9250:07.1432:05,231:11:11,9812:04,037:39.0421:51,231:13:34.1434:30,262:35:19.3117:34,4330:12,2640:09,2747:19.318:10,0641:03,023,3712:30.1217:38,9025:07,2421:19,5720:27.650,518:45,0519:28,898:10,487.6039:13,3160521613233System56 020,40.400AppleAppleAppleAppleAppleApoleAppleAppleAppleApoleAppleAppleApoleAppleAnoleAppleAnoleAppleAnoleAppleAnoleAppleAnoleAnoleAppleAppleAnoleApoleAppleApoleAppleApoleAppleAppleApoleo epul66.00,0eo ltuime0,004:29:19.433:03,560.000,000.000,030.020,000.000,000.000,000.001:26,330.000.00|0.360.00|0,000.000.000,000.000.000,000.000.00ne 200.00• I Daily - Platform • now100% CFri 15 May 9:53:195363z aonnol859534EG00Q Searchrootlukaslukaslukaslukasdriverkitlukasrootlukasdriverkittrustdlukas...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46225
|
|
46226
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 19 hours ago
Vasil-Jiminny
Vasil-Jiminny
19 hours ago
19 hours ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM yesterday
👍
1
Reply...
Resolve conversation
Resolve conversation
@yalokin-jiminny
Show options
yalokin-jiminny commented 18 hours ago
yalokin-jiminny
yalokin-jiminny
commented
18 hours ago
18 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 18 hours ago •
claude
claude
Bot
commented
18 hours ago
18 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData
method and the
FixActivitiesOpportunity
command.
app/Models/Activity.php
app/Models/Activity.php
Logic is correct.
The reordering makes sense:
// Before: only set stage if null (no reset on opportunity change)
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
if
(
$
opportunity
&&
$
this
->
opportunity_id...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46226
|
|
46227
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 19 hours ago
Vasil-Jiminny
Vasil-Jiminny
19 hours ago
19 hours ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM yesterday
👍
1
Reply...
Resolve conversation
Resolve conversation
@yalokin-jiminny
Show options
yalokin-jiminny commented 18 hours ago
yalokin-jiminny
yalokin-jiminny
commented
18 hours ago
18 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46227
|
|
46228
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46228
|
|
46229
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46229
|
|
46752
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
Show resolved
Show resolved
@yalokin-jiminny
Show options
yalokin-jiminny commented 18 hours ago
yalokin-jiminny
yalokin-jiminny
commented
18 hours ago
18 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 18 hours ago •
claude
claude
Bot
commented
18 hours ago
18 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46752
|
|
46753
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
Show resolved
Show resolved
@yalokin-jiminny
Show options
yalokin-jiminny commented 18 hours ago
yalokin-jiminny
yalokin-jiminny
commented
18 hours ago
18 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 18 hours ago •
claude
claude
Bot
commented
18 hours ago
18 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData
method and the
FixActivitiesOpportunity
command.
app/Models/Activity.php
app/Models/Activity.php
Logic is correct.
The reordering makes sense:
// Before: only set stage if null (no reset on opportunity change)
if
(
$
this
->
stage_id
===...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46753
|
|
46754
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Service-Desk - Queues - Platform team - Service space - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
Show resolved
Show resolved
@yalokin-jiminny
Show options
yalokin-jiminny commented 18 hours ago
yalokin-jiminny
yalokin-jiminny
commented
18 hours ago
18 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 18 hours ago •
claude
claude
Bot
commented
18 hours ago
18 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData
method and the
FixActivitiesOpportunity
command.
app/Models/Activity.php
app/Models/Activity.php
Logic is correct.
The reordering makes sense:
// Before: only set stage if null (no reset on opportunity change)
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
.
.
.
}
// After: reset stage when opportunity changes, then fallback for null stage_id
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
$
this
->
opportunity_id
=
$
opportunity
->
id
;
$
this
->
stage_id
=
$
stage
?->id;
// may null out stage_id
}
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
// fallback still needed
Copy code to clipboard
The second
if
block is still needed — it handles cases where the opportunity didn't change but
stage_id
is
null
.
Observation:
The same pattern is NOT applied to the
UpdateCrmDataByStrategy::Account
branch (line 2156), which only sets opportunity when
$this->opportunity_id === null
. Since that branch never changes an existing opportunity, there's no stale stage risk — this asymmetry is intentional and correct.
Comment (line 2124):
Per project convention, comments should only be added for non-obvious quirks. The "why" here (avoiding stale stage) isn't immediately evident from the code alone, so the comment is borderline justified. That said, the code is readable enough without it — I'd lean toward removing it per the project rules, but it's not a blocker.
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Responding to Vasil's question
"Activity stage should be the stage at import, no?"
"Activity stage should be the stage at import, no?"
:
The command uses
$opportunity->getStageId()...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46754
|
|
46832
|
FirefoxFile• •Edit→ CViewHistoryBookmarksProfilesT FirefoxFile• •Edit→ CViewHistoryBookmarksProfilesToolsWindowHelpl46]meet.google.com/gjc-ikxu-wxu?authuser=lukas.kovalik%40jiminny.comBackend Chapter • nowБГ100% C47 8• Fri 15 May 10:32:53• [EMAIL] accountLukas KovalikBackend ChapterSteliyan Georgiev is in this callOther people are waiting. Join to let them in.* Use Gemini to take notesShare notes and transcriptStartJoin nowOther ways to join ~{ soundcore A...4 System Defa...• FaceTime HD...g Backgrounds...Gemini is available in Meet as your personal in-meeting assistant. It can analyze conversation via temporaryaccess to meeting captions. Using Ask Gemini won't create a recording or store meeting data. The meetinghost can turn it off. Learn more...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46832
|
|
46833
|
ActivityMoreFirefoxcalMistorbookmarksProtllesTools ActivityMoreFirefoxcalMistorbookmarksProtllesToolsHelpJiminny ... ~# jiminny-bg# platform-ticketsic productlaunches# random# releases# sofia-office# support# thank-yous# the_people_of jimi...• Direct messages8. Stoyan TomovP. Galya Dimitrova. Aneliya Angelova€. Vasil Vasilev EFf. Stefka StoyanovaS: Todor Stamatov8. Mario Georgiev.. Nikolay Ivanov2o James Graham *Ro Stoyan TanevR. Steliyan Georgiev =f Petko Kashinski. Lukas Kovalik y...i: Apps® ToastSi Jira GloudWindow. Stoyan Tomov• Messagest Add canvasO FilesMoreXE Bug SKudaSid Today ssue48 in Jira CloudStatusin ProgressLukas Kovalik (you)As of today at 10:29 AMOpen in Jira*Summariseфикс представлява добавяне наsecondary emalза ла може ла се намери userлеплойнах поомените вечеimage.pngreally sorry but we could not send your text molten due to tne message being t0o longTo e genericне сьм пазбрал лали в крайна сметка тисм Марио сьщо го получихтев база вашите не ca failedMessage Stoyan Tomov+ Aa IMlib2 scnPlatform Sprint 4 Q2 - Platform Te[SRD-6848] Sidekick SMS issue -JY-20903 Update activity stage wi•JY-20904 Fix UpdateActivityElasJY-20903 Update activity stage wiJY-20891 add support for second:…SRD-68531 Moxso - Potential dea© Pipelines - jiminny/appFeed — iminny — Sentrv(UY-20906) Review of Pipedrive StPipedrive API Reference and D. X• pioedrive/client-oho: Pipedrive APapo.clrelecl.com/ploelines/eltnuo//iminnyappo circleci •homePipelinesProjectsJobsPipedrive API Reference and Documentationedrive/client-oho: Pipedrive APl client fon• phpstan 887513• setup 887517.©test 887518©test-backend-lint 887514-sonar_cloud 887519V setup 887510mco-toos-schemas302527b Merge branch 'master' into mcp-tools-schemasPush Commit pushedPlanChunkChunkbuild_accept_deploycheckout-code 887480build-frontend 887481test-frontend 887482V build-backend 887483v phpstan 887484prepare_deploy_revision_prod 887499build docker hackend code nrod 887502build_docker_worker_code_prod 887500ould docker worker video code orod 887501db_migrations_prod 887503deploy_frontend_assets_to_s3_prod 887504deplov _docker backend code_prod 887506deploy_docker_worker_code_prod 887505deploy_docker_worker_video_code_prod 887507sentry notitv-1 887508prepare_deploy_revision_prod_eu 887487build_docker_backend_code_prod_eu 887489buid docker worker code orod eu 887490huild dockor worker viden codo nrod ou 887488.mastera00d536 Merge pull request #2073 from uminnv iJY-20891-improve-sms-text-relays &Push Commit pushedhhl^ & Backend Chapter • now30m ago32m ago100% 152rn To May 10.32:031m 8s1m 29s24m 13s25m 55s59sGG..5/S25m 37sGGOS...1m 13s1m 30sIm 50s1m 19s1m 8s44s1m 53s1m 51s1m 49s22g1m Os13m 13s11m 55g23s32S57c1m 50s1m 51s1m 51c...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46833
|
|
46834
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
20 hours ago
20 hours ago
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
19 hours ago
19 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 19 hours ago
Vasil-Jiminny
Vasil-Jiminny
19 hours ago
19 hours ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM yesterday
👍
1
Reply...
Resolve conversation
Resolve conversation
@yalokin-jiminny
Show options
yalokin-jiminny commented 18 hours ago
yalokin-jiminny
yalokin-jiminny
commented
18 hours ago
18 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 18 hours ago •
claude
claude
Bot
commented
18 hours ago
18 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData
method and the
FixActivitiesOpportunity
command.
app/Models/Activity.php
app/Models/Activity.php
Logic is correct.
The reordering makes sense:
// Before: only set stage if null (no reset on opportunity change)
if
(
$
this
->
stage_id
===
null
&&
$
stage...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
46834
|
|
47208
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47208
|
|
47209
|
PhpStormFileEditViewNavigateCodeLaravelRefactorRun PhpStormFileEditViewNavigateCodeLaravelRefactorRunToolsGitWindowHelp>0.labolBackend Chapter • 20 m leftA100% [8• Fri 15 May 11:10:28ffmpeg181DOCKERO ₴1DEV (-zsh)82APP (-zsh)*3-zsh₴4ffmpeg885ec2-user@ip-10-20-...₴86|ec2-user@ip-10-30-...ec2-user@ip-10-...• *8ggml_metal_init: usegraphoptimize= truewhisper_backend_init: using BLAS backendwhisper_init_state: kv selfsize=3.15 MBwhisper_init_state: kv cross size =9.44 MBwhisper_init_state: kv padsize=2.36 MBwhisper_init_state:compute buffer (conv)whisper_init_state: compute buffer (encode) =whisper_init_state: compute buffer (cross)whisper_init_state: compute buffer(decode) =14.17 MB65.96 MB8.50 MB96.83 MBggml_metal_free: deallocatingwhisper_backend_init_gpu: device 0: Metal (type: 1)whisper_backend_init_gpu:found GPUdevice 0:Metal(type: 1, cnt: 0)whisper_backend_init_gpu:using Metal backendggml_metal_init:allocatingggml_metal_init:found device:Apple M1ggml_metal_init:picking default device: Apple M1ggml_metal_init:use fusion= trueggml_metal_init: use concurrency= trueggml_metal_init: use graph optimize = truewhisper_backend_init: using BLAS backendwhisper_init_state: kv self size=3.15 MBwhisper_init_state: kv cross size =9.44 MBwhisper_init_state: kv padsize=2.36 MBwhisper_init_state: compute buffer (conv)whisper_init_state: compute buffer(encode)whisper_init_state: computebuffer (cross)whisper_init_state: computebuffer (decode) =14.17 MB65.96 MB8.50 MB96.83 MBggml_metal_free: deallocating2026-05-15T11:08:30.409470ZINFOscreenpipe_audio::audio_manager::manager: reconciliation: transcribed 50 orphanedchunks2026-05-15T11:09:35.302047ZWARN screenpipe_audio::core::run_record_and_transcribe: no usable audio from soundcore AeroClip (input) for 30s - only zero-fill buffers (likely OS device hijack by anotherapp),triggering reconnect2026-05-15T11:09:35.302246ZWARNscreenpipe_audio::audio_manager::manager: recording for device soundcore AeroClip (input) exited with error: Audio stream zero-fill - no usable data from soundcore AeroClip(input)for 30s (suspected device hijack by anotherprocess)2026-05-15111:09:36.4538642WARN screenpipe_audio::audio_manager::device_monitor: [DEVICE_RECOVERY] detected stale recording handle for soundcore AeroClip (input), cleaning up for restart2026-05-15T11:09:36.453999Z2026-05-15T11:09:36.587528Z2026-05-15T11:09:36.587578Z2026-05-15T11:09:36.587608Z2026-05-15T11:10:22.015788ZROM\nframes \nWHERE\n088917sINFOscreenpipe_audio::device::device_manager: Stopping device: soundcore AeroClip (input)INFO screenpipe_audio::device::device_manager: starting recording for device:soundcore AeroClip (input)INFO screenpipe_audio::audio_manager::device_monitor: restarted with system default device: soundcore AeroClip (input)INFOscreenpipe_audio::core::run_record_and_transcribe: starting continuous recording for soundcore AeroClip (input) (bluetooth / 30s segments)WARNsqlx::query:summary="SELECT id,snapshot_path, device_name, "db.statement="\n\nSELECT\nid, \nsnapshot_path, \ndevice_name, \ntimestamp\nFsnapshot_path IS NOT NULL\nAND timestamp < ?1\nORDER BY\n device_name, \ntimestamp ASC\nLIMIT\n5000\n" rows_affected=0 rows_returned=46 elapsed=7.0142026-05-15T11:10:22.018444Z2026-05-15111:10:26.9224762INFOscreenpipe_engine::snapshot_compaction: snapshot compaction: found 46 eligible framesINFO screenpipe_engine::snapshot_compaction: snapshot compaction: 22 frames, 3.7MB → 1.3MB (2.8x), 22 JPEGs deleted...
|
Firefox
|
JY-20904 Fix UpdateActivityElasticSearchDocumentCo JY-20904 Fix UpdateActivityElasticSearchDocumentCommand find activity… by LakyLak · Pull Request #12078 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47209
|
|
47217
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Usage | Windsurf
Usage | Windsurf
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47217
|
|
47218
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Usage | Windsurf
Usage | Windsurf
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
yesterday
yesterday
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
20 hours ago
20 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
Show resolved
Show resolved...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47218
|
|
47219
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Usage | Windsurf
Usage | Windsurf
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47219
|
|
47220
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Usage | Windsurf
Usage | Windsurf
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
yesterday
yesterday
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
20 hours ago
20 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
Show resolved
Show resolved
@yalokin-jiminny
Show options
yalokin-jiminny commented 19 hours ago
yalokin-jiminny
yalokin-jiminny
commented
19 hours ago
19 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 19 hours ago •
claude...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47220
|
|
47221
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Usage | Windsurf
Usage | Windsurf
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
yesterday
yesterday
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
20 hours ago
20 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
Show resolved...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47221
|
|
47222
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Usage | Windsurf
Usage | Windsurf
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
yesterday
yesterday
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
20 hours ago
20 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
Show resolved
Show resolved
@yalokin-jiminny
Show options
yalokin-jiminny commented 19 hours ago
yalokin-jiminny
yalokin-jiminny
commented
19 hours ago
19 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 19 hours ago •
claude
claude
Bot
commented
19 hours ago
19 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData
method and the
FixActivitiesOpportunity
command.
app/Models/Activity.php
app/Models/Activity.php
Logic is correct.
The reordering makes sense:
// Before: only set stage if null (no reset on opportunity change)
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
.
.
.
}
// After: reset stage when opportunity changes, then fallback for null stage_id
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
$
this
->
opportunity_id
=
$
opportunity
->
id
;
$
this
->
stage_id
=
$
stage
?->id;
// may null out stage_id
}
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
// fallback still needed
Copy code to clipboard
The second
if
block is still needed — it handles cases where the opportunity didn't change but
stage_id
is
null
.
Observation:
The same pattern is NOT applied to the
UpdateCrmDataByStrategy::Account
branch (line 2156), which only sets opportunity when
$this->opportunity_id === null
. Since that branch never changes an existing opportunity, there's no stale stage risk — this asymmetry is intentional and correct.
Comment (line 2124):
Per project convention, comments should only be added for non-obvious quirks. The "why" here (avoiding stale stage) isn't immediately evident from the code alone, so the comment is borderline justified. That said, the code is readable enough without it — I'd lean toward removing it per the project rules, but it's not a blocker.
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Responding to Vasil's question
"Activity stage should be the stage at import, no?"
"Activity stage should be the stage at import, no?"
:
The command uses
$opportunity->getStageId()
— the
current
stage of the newly matched opportunity, not the stage at the time the activity was originally imported. This is a design decision:
If the activity had a
wrong
opportunity (cross-team mismatch), its previous stage was already wrong — restoring "stage at import" of the bad match doesn't help.
Setting the stage to the current state of the
correct
opportunity is the more consistent approach.
This seems intentional and correct given the purpose of the command (fixing mismatched opportunities).
Potential concern:
Opportunity::getStageId()
has a non-nullable
int
return type. If the opportunity somehow has a null
stage_id
in the DB, this would fail at runtime. The command should handle this case gracefully, e.g. catching the error or checking for null. That said, if
stage_id
is always guaranteed non-null for opportunities coming from the CRM match, this may be acceptable.
Test Coverage
Test Coverage
SonarQube reports
0.0% coverage on new code
. Per project rules (
CLAUDE.md
):...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47222
|
|
47223
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
Usage | Windsurf
Usage | Windsurf
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
yesterday
yesterday
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
20 hours ago
20 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
Show resolved
Show resolved
@yalokin-jiminny
Show options
yalokin-jiminny commented 19 hours ago
yalokin-jiminny
yalokin-jiminny
commented
19 hours ago
19 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 19 hours ago •
claude
claude
Bot
commented
19 hours ago
19 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData
method and the
FixActivitiesOpportunity
command.
app/Models/Activity.php
app/Models/Activity.php
Logic is correct.
The reordering makes sense:
// Before: only set stage if null (no reset on opportunity change)
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
.
.
.
}
// After: reset stage when opportunity changes, then fallback for null stage_id
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
$
this
->
opportunity_id
=
$
opportunity
->
id
;...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47223
|
|
47298
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47298
|
|
47299
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47299
|
|
47300
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
yesterday
yesterday
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
20 hours ago
20 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 20 hours ago
Vasil-Jiminny
Vasil-Jiminny
20 hours ago
20 hours ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM yesterday
👍
1
Reply...
Resolve conversation
Resolve conversation
@yalokin-jiminny
Show options
yalokin-jiminny commented 19 hours ago
yalokin-jiminny
yalokin-jiminny
commented
19 hours ago
19 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 19 hours ago •
claude
claude
Bot
commented
19 hours ago
19 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData
method and the
FixActivitiesOpportunity
command.
app/Models/Activity.php
app/Models/Activity.php
Logic is correct.
The reordering makes sense:
// Before: only set stage if null (no reset on opportunity change)
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
.
.
.
}
// After: reset stage when opportunity changes, then fallback for null stage_id
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
$
this
->
opportunity_id
=
$
opportunity
->
id
;
$
this
->
stage_id
=
$
stage
?->id;
// may null out stage_id
}
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
// fallback still needed
Copy code to clipboard
The second
if
block is still needed — it handles cases where the opportunity didn't change but
stage_id
is
null
.
Observation:
The same pattern is NOT applied to the
UpdateCrmDataByStrategy::Account
branch (line 2156), which only sets opportunity when
$this->opportunity_id === null
. Since that branch never changes an existing opportunity, there's no stale stage risk — this asymmetry is intentional and correct.
Comment (line 2124):
Per project convention, comments should only be added for non-obvious quirks. The "why" here (avoiding stale stage) isn't immediately evident from the code alone, so the comment is borderline justified. That said, the code is readable enough without it — I'd lean toward removing it per the project rules, but it's not a blocker.
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Responding to Vasil's question
"Activity stage should be the stage at import, no?"
"Activity stage should be the stage at import, no?"
:
The command uses
$opportunity->getStageId()
— the
current
stage of the newly matched opportunity, not the stage at the time the activity was originally imported. This is a design decision:
If the activity had a
wrong
opportunity (cross-team mismatch), its previous stage was already wrong — restoring "stage at import" of the bad match doesn't help.
Setting the stage to the current state of the
correct
opportunity is the more consistent approach.
This seems intentional and correct given the purpose of the command (fixing mismatched opportunities).
Potential concern:
Opportunity::getStageId()
has a non-nullable
int
return type. If the opportunity somehow has a null
stage_id
in the DB, this would fail at runtime. The command should handle this case gracefully, e.g. catching the error or checking for null. That said, if
stage_id
is always guaranteed non-null for opportunities coming from the CRM match, this may be acceptable.
Test Coverage
Test Coverage
SonarQube reports
0.0% coverage on new code
. Per project rules (
CLAUDE.md
):
"Make sure the new code you write is covered by unit tests."
Tests are missing for:
Activity::updateActivityCrmData
— scenario where opportunity changes should reset
stage_id...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47300
|
|
47301
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
yesterday
yesterday
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
20 hours ago
20 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47301
|
|
47302
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
yesterday
yesterday
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
20 hours ago
20 hours ago
View reviewed changes
View reviewed changes...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47302
|
|
47303
|
Ask Google Gemini
Platform Sprint 4 Q2 - Platform Ask Google Gemini
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47303
|
|
47304
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
yesterday
yesterday
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
20 hours ago
20 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 20 hours ago
Vasil-Jiminny
Vasil-Jiminny
20 hours ago
20 hours ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM yesterday
👍
1
Reply...
Resolve conversation
Resolve conversation
@yalokin-jiminny
Show options
yalokin-jiminny commented 19 hours ago
yalokin-jiminny
yalokin-jiminny
commented
19 hours ago
19 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 19 hours ago •
claude
claude
Bot
commented
19 hours ago
19 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47304
|
|
47305
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
yesterday
yesterday
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
20 hours ago
20 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 20 hours ago
Vasil-Jiminny
Vasil-Jiminny
20 hours ago
20 hours ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM yesterday
👍
1
Reply...
Resolve conversation
Resolve conversation
@yalokin-jiminny
Show options
yalokin-jiminny commented 19 hours ago
yalokin-jiminny
yalokin-jiminny
commented
19 hours ago
19 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 19 hours ago •
claude
claude
Bot
commented
19 hours ago
19 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData
method and the
FixActivitiesOpportunity
command.
app/Models/Activity.php
app/Models/Activity.php
Logic is correct.
The reordering makes sense:
// Before: only set stage if null (no reset on opportunity change)
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
.
.
.
}
// After: reset stage when opportunity changes, then fallback for null stage_id
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
$
this
->
opportunity_id
=
$
opportunity
->
id
;
$
this
->
stage_id
=
$
stage
?->id;
// may null out stage_id
}
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
// fallback still needed...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47305
|
|
47306
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
yesterday
yesterday
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
20 hours ago
20 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 20 hours ago
Vasil-Jiminny
Vasil-Jiminny
20 hours ago
20 hours ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM yesterday
👍
1
Reply...
Resolve conversation
Resolve conversation
@yalokin-jiminny
Show options
yalokin-jiminny commented 19 hours ago
yalokin-jiminny
yalokin-jiminny
commented
19 hours ago
19 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 19 hours ago •
claude
claude
Bot
commented
19 hours ago
19 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData
method and the
FixActivitiesOpportunity
command.
app/Models/Activity.php
app/Models/Activity.php
Logic is correct.
The reordering makes sense:
// Before: only set stage if null (no reset on opportunity change)
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
.
.
.
}
// After: reset stage when opportunity changes, then fallback for null stage_id
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
$
this
->
opportunity_id
=
$
opportunity
->
id
;
$
this
->
stage_id
=
$
stage
?->id;
// may null out stage_id
}
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
// fallback still needed
Copy code to clipboard
The second
if
block is still needed — it handles cases where the opportunity didn't change but
stage_id
is
null
.
Observation:
The same pattern is NOT applied to the
UpdateCrmDataByStrategy::Account
branch (line 2156), which only sets opportunity when
$this->opportunity_id === null
. Since that branch never changes an existing opportunity, there's no stale stage risk — this asymmetry is intentional and correct.
Comment (line 2124):
Per project convention, comments should only be added for non-obvious quirks. The "why" here (avoiding stale stage) isn't immediately evident from the code alone, so the comment is borderline justified. That said, the code is readable enough without it — I'd lean toward removing it per the project rules, but it's not a blocker.
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Responding to Vasil's question
"Activity stage should be the stage at import, no?"
"Activity stage should be the stage at import, no?"
:
The command uses
$opportunity->getStageId()
— the
current
stage of the newly matched opportunity, not the stage at the time the activity was originally imported. This is a design decision:
If the activity had a
wrong
opportunity (cross-team mismatch), its previous stage was already wrong — restoring "stage at import" of the bad match doesn't help.
Setting the stage to the current state of the
correct
opportunity is the more consistent approach.
This seems intentional and correct given the purpose of the command (fixing mismatched opportunities).
Potential concern:
Opportunity::getStageId()
has a non-nullable
int
return type. If the opportunity somehow has a null
stage_id
in the DB, this would fail at runtime. The command should handle this case gracefully, e.g. catching the error or checking for null. That said, if
stage_id
is always guaranteed non-null for opportunities coming from the CRM match, this may be acceptable.
Test Coverage
Test Coverage
SonarQube reports...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47306
|
|
47317
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47317
|
|
47318
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47318
|
|
47319
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
yesterday
yesterday
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
20 hours ago
20 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 20 hours ago
Vasil-Jiminny
Vasil-Jiminny
20 hours ago
20 hours ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM yesterday
👍
1
Reply...
Resolve conversation
Resolve conversation
@yalokin-jiminny
Show options
yalokin-jiminny commented 19 hours ago
yalokin-jiminny
yalokin-jiminny
commented
19 hours ago
19 hours ago
@claude
@claude
Add or remove reactions
react with eyes...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47319
|
|
47320
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
yesterday
yesterday
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
20 hours ago
20 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 20 hours ago
Vasil-Jiminny
Vasil-Jiminny
20 hours ago
20 hours ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM yesterday
👍
1
Reply...
Resolve conversation
Resolve conversation
@yalokin-jiminny
Show options
yalokin-jiminny commented 19 hours ago
yalokin-jiminny
yalokin-jiminny
commented
19 hours ago
19 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 19 hours ago •
claude
claude
Bot
commented
19 hours ago
19 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData
method and the
FixActivitiesOpportunity
command.
app/Models/Activity.php
app/Models/Activity.php
Logic is correct.
The reordering makes sense:
// Before: only set stage if null (no reset on opportunity change)
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
.
.
.
}
// After: reset stage when opportunity changes, then fallback for null stage_id
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
$
this
->
opportunity_id
=
$
opportunity
->
id
;
$
this
->
stage_id
=
$
stage
?->id;
// may null out stage_id
}
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
// fallback still needed
Copy code to clipboard
The second
if
block is still needed — it handles cases where the opportunity didn't change but
stage_id
is
null
....
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47320
|
|
47321
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
yesterday
yesterday
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
20 hours ago
20 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 20 hours ago
Vasil-Jiminny
Vasil-Jiminny
20 hours ago
20 hours ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM yesterday
👍
1
Reply...
Resolve conversation
Resolve conversation
@yalokin-jiminny
Show options
yalokin-jiminny commented 19 hours ago
yalokin-jiminny
yalokin-jiminny
commented
19 hours ago
19 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 19 hours ago •
claude
claude
Bot
commented
19 hours ago
19 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData
method and the
FixActivitiesOpportunity
command.
app/Models/Activity.php
app/Models/Activity.php
Logic is correct.
The reordering makes sense:
// Before: only set stage if null (no reset on opportunity change)
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
.
.
.
}
// After: reset stage when opportunity changes, then fallback for null stage_id
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
$
this
->
opportunity_id
=
$
opportunity
->
id
;
$
this
->
stage_id...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47321
|
|
47322
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
yesterday
yesterday
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
20 hours ago
20 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 20 hours ago
Vasil-Jiminny
Vasil-Jiminny
20 hours ago
20 hours ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM yesterday
👍
1
Reply...
Resolve conversation
Resolve conversation
@yalokin-jiminny
Show options
yalokin-jiminny commented 19 hours ago
yalokin-jiminny
yalokin-jiminny
commented
19 hours ago
19 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 19 hours ago •
claude
claude
Bot
commented
19 hours ago
19 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData
method and the
FixActivitiesOpportunity
command.
app/Models/Activity.php
app/Models/Activity.php
Logic is correct.
The reordering makes sense:
// Before: only set stage if null (no reset on opportunity change)
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47322
|
|
47323
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
yesterday
yesterday
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
20 hours ago
20 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 20 hours ago
Vasil-Jiminny
Vasil-Jiminny
20 hours ago
20 hours ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM yesterday
👍
1
Reply...
Resolve conversation
Resolve conversation
@yalokin-jiminny
Show options
yalokin-jiminny commented 19 hours ago
yalokin-jiminny
yalokin-jiminny
commented
19 hours ago
19 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 19 hours ago •
claude
claude
Bot
commented
19 hours ago
19 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData
method and the
FixActivitiesOpportunity
command.
app/Models/Activity.php
app/Models/Activity.php
Logic is correct.
The reordering makes sense:
// Before: only set stage if null (no reset on opportunity change)
if
(
$
this
->
stage_id
===
null
&&
$...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47323
|
|
47324
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
yesterday
yesterday
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
20 hours ago
20 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 20 hours ago
Vasil-Jiminny
Vasil-Jiminny
20 hours ago
20 hours ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM yesterday
👍
1
Reply...
Resolve conversation
Resolve conversation
@yalokin-jiminny
Show options
yalokin-jiminny commented 19 hours ago
yalokin-jiminny
yalokin-jiminny
commented
19 hours ago
19 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 19 hours ago •
claude
claude
Bot
commented
19 hours ago
19 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task
Post findings
Summary
Summary
The PR resets
stage_id
when the opportunity on an activity changes, to avoid carrying over a stale stage from a previously matched opportunity. The change is in two places: the model's
updateActivityCrmData
method and the
FixActivitiesOpportunity
command.
app/Models/Activity.php
app/Models/Activity.php
Logic is correct.
The reordering makes sense:
// Before: only set stage if null (no reset on opportunity change)
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
.
.
.
}
// After: reset stage when opportunity changes, then fallback for null stage_id
if
(
$
opportunity
&&
$
this
->
opportunity_id
!==
$
opportunity
->
id
) {
$
this
->
opportunity_id
=
$
opportunity
->
id
;
$
this
->
stage_id
=
$
stage
?->id;
// may null out stage_id
}
if
(
$
this
->
stage_id
===
null
&&
$
stage
) {
.
.
.
}
// fallback still needed
Copy code to clipboard
The second
if
block is still needed — it handles cases where the opportunity didn't change but
stage_id
is
null
.
Observation:
The same pattern is NOT applied to the
UpdateCrmDataByStrategy::Account
branch (line 2156), which only sets opportunity when
$this->opportunity_id === null
. Since that branch never changes an existing opportunity, there's no stale stage risk — this asymmetry is intentional and correct.
Comment (line 2124):
Per project convention, comments should only be added for non-obvious quirks. The "why" here (avoiding stale stage) isn't immediately evident from the code alone, so the comment is borderline justified. That said, the code is readable enough without it — I'd lean toward removing it per the project rules, but it's not a blocker.
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Responding to Vasil's question
"Activity stage should be the stage at import, no?"
"Activity stage should be the stage at import, no?"
:
The command uses
$opportunity->getStageId()
— the
current
stage of the newly matched opportunity, not the stage at the time the activity was originally imported. This is a design decision:
If the activity had a
wrong
opportunity (cross-team mismatch), its previous stage was already wrong — restoring "stage at import" of the bad match doesn't help.
Setting the stage to the current state of the
correct
opportunity is the more consistent approach.
This seems intentional and correct given the purpose of the command (fixing mismatched opportunities).
Potential concern:
Opportunity::getStageId()
has a non-nullable
int
return type. If the opportunity somehow has a null
stage_id
in the DB, this would fail at runtime. The command should handle this case gracefully, e.g. catching the error or checking for null. That said, if
stage_id
is always guaranteed non-null for opportunities coming from the CRM match, this may be acceptable.
Test Coverage
Test Coverage
SonarQube reports
0.0% coverage on new code
. Per project rules (
CLAUDE.md
):
"Make sure the new code you write is covered by unit tests."
Tests are missing for:
Activity::updateActivityCrmData
— scenario where opportunity changes should reset
stage_id
Activity::updateActivityCrmData
— scenario where opportunity doesn't change,
stage_id
stays
FixActivitiesOpportunity
command — verifying
stage_id
is updated alongside
opportunity_id
This should be addressed before merging.
Overall
Overall
The logic itself is sound. The main gaps are
missing test coverage
(required by project rules) and a minor question about whether to keep the comment in
Activity.php
.
Add or remove reactions
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
approved these changes
18 hours ago
18 hours ago
View reviewed changes
View reviewed changes
@LakyLak
JY-20903
JY-20903
revert changes in command
revert changes in command...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47324
|
|
47325
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47325
|
|
47333
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
yesterday
yesterday
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
20 hours ago
20 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 20 hours ago
Vasil-Jiminny
Vasil-Jiminny
20 hours ago
20 hours ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM yesterday...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47333
|
|
47334
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47334
|
|
47335
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47335
|
|
47336
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
yesterday
yesterday
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
20 hours ago
20 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47336
|
|
47337
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
yesterday
yesterday
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
20 hours ago
20 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47337
|
|
47338
|
Ask Google Gemini
Platform Sprint 4 Q2 - Platform Ask Google Gemini
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
yesterday
yesterday
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
20 hours ago
20 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 20 hours ago
Vasil-Jiminny
Vasil-Jiminny
20 hours ago
20 hours ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM yesterday
👍
1
Reply...
Resolve conversation
Resolve conversation
@yalokin-jiminny
Show options
yalokin-jiminny commented 19 hours ago
yalokin-jiminny
yalokin-jiminny
commented
19 hours ago
19 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 19 hours ago •
claude
claude
Bot
commented
19 hours ago
19 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47338
|
|
47367
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47367
|
|
47368
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Open
JY-20903 Update activity stage when opportunity is changed #12077 LakyLak wants to merge 2 commits into master from JY-20903-update_activity-stage-on-opportunity-change Copy head branch name to clipboard
JY-20903 Update activity stage when opportunity is changed
JY-20903 Update activity stage when opportunity is changed
#
12077
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
yesterday
yesterday
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
20 hours ago
20 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47368
|
|
47369
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
yesterday
yesterday
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
20 hours ago
20 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 20 hours ago
Vasil-Jiminny
Vasil-Jiminny
20 hours ago
20 hours ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM yesterday
👍
1
Reply...
Resolve conversation
Resolve conversation
@yalokin-jiminny
Show options
yalokin-jiminny commented 19 hours ago
yalokin-jiminny
yalokin-jiminny
commented
19 hours ago
19 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 19 hours ago •
claude
claude
Bot
commented
19 hours ago
19 hours ago
•...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47369
|
|
47370
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
yesterday
yesterday
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
20 hours ago
20 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123
124
125
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
+
$activity->update([
+
'opportunity_id' => $opportunity->getId(),
+
'stage_id' => $opportunity->getStageId(),
Show options
@Vasil-Jiminny Vasil-Jiminny 20 hours ago
Vasil-Jiminny
Vasil-Jiminny
20 hours ago
20 hours ago
Activity stage should be the stage at import, no?
Add or remove reactions
thumbs up (1): Vasil-Jiminny, 02:16PM yesterday
👍
1
Reply...
Resolve conversation
Resolve conversation
@yalokin-jiminny
Show options
yalokin-jiminny commented 19 hours ago
yalokin-jiminny
yalokin-jiminny
commented
19 hours ago
19 hours ago
@claude
@claude
Add or remove reactions
react with eyes
👀
1
@claude
Show options
claude Bot commented 19 hours ago •
claude
claude
Bot
commented
19 hours ago
19 hours ago
•
edited
edited
Claude finished
@yalokin-jiminny
@yalokin-jiminny
's task in 1m 40s
——
View job
View job
Code Review
Code Review
Completed task
Gather context
Completed task
Review changed files
Completed task...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47370
|
|
47371
|
Platform Sprint 4 Q2 - Platform Team - Scrum Board Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
Platform Sprint 4 Q2 - Platform Team - Scrum Board - Jira
[SRD-6848] Sidekick SMS issue - Jira
[SRD-6848] Sidekick SMS issue - Jira
Usage | Windsurf
Usage | Windsurf
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app
Close tab
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
JY-20891 add support for secondary email by LakyLak · Pull Request #12073 · jiminny/app
[SRD-6853] Moxso - Potential deal stages bug - Jira
[SRD-6853] Moxso - Potential deal stages bug - Jira
Pipelines - jiminny/app
Pipelines - jiminny/app
Feed — jiminny — Sentry
Feed — jiminny — Sentry
[JY-20906] Review of Pipedrive SDK - Jira
[JY-20906] Review of Pipedrive SDK - Jira
Pipedrive API Reference and Documentation
Pipedrive API Reference and Documentation
pipedrive/client-php: Pipedrive API client for PHP
pipedrive/client-php: Pipedrive API client for PHP
New Tab
Customize sidebar
Open Google Gemini (⌃X)
Tabs from other devices
Open history (⇧⌘H)
Open bookmarks (⌘B)
Skip to content
Skip to content
Open menu
Homepage (g then d)
jiminny
jiminny
app
app
Search or jump to…
Type
/
to search
Chat with Copilot
Open Copilot…
Create new...
All issues(g then i)
All pull requests
All repositories
You have unread notifications(g then n)
Open user navigation menu
Repository navigation
Repository navigation
Code
Code
Pull requests (31)
Pull requests
(
31
)
Agents
Agents
Actions
Actions
Wiki
Wiki
Security and quality
Security and quality
Insights
Insights
Settings
Settings
Important update
Important update
On April 24 we'll start using GitHub Copilot interaction data for AI model training unless you opt out.
Review this update
Review this update
and manage your preferences in your
GitHub account settings
GitHub account settings
.
Dismiss banner
JY-20903 Update activity stage when opportunity is changed #12077 Edit title
JY-20903 Update activity stage when opportunity is changed
#
12077
Edit title
Ready to merge
Ready to merge
Code
Code
Open
LakyLak
LakyLak
wants to merge 2 commits into
master
master
from
JY-20903-update_activity-stage-on-opportunity-change
JY-20903-update_activity-stage-on-opportunity-change
Copy head branch name to clipboard
Lines changed: 6 additions & 4 deletions
Conversation (4)
Conversation
(
4
)
Commits (2)
Commits
(
2
)
Checks (3)
Checks
(
3
)
Files changed (1)
Files changed
(
1
)
Conversation
Conversation
@LakyLak
Show options
LakyLak commented yesterday
LakyLak
LakyLak
commented
yesterday
yesterday
JIRA: JY-20903
JIRA:
JY-20903
JY-20903
Changes:
Changes:
Reset stage on activity if opportunity is changed
Add or remove reactions
@LakyLak
JY-20903
JY-20903
Update activity stage when opportunity is changed
Update activity stage when opportunity is changed
12 / 13 checks OK
8dac0df
8dac0df
@LakyLak
LakyLak
LakyLak
requested review from
Vasil-Jiminny
Vasil-Jiminny
,
nikolaybiaivanov
nikolaybiaivanov
and
yalokin-jiminny
yalokin-jiminny
yesterday
yesterday
Vasil-Jiminny
Vasil-Jiminny
Vasil-Jiminny
reviewed
20 hours ago
20 hours ago
View reviewed changes
View reviewed changes
Comment thread
app/Console/Commands/Activities/FixActivitiesOpportunity.php
app/Console/Commands/Activities/FixActivitiesOpportunity.php
Outdated
123
-
$activity->update(['opportunity_id' => $opportunity->getId()]);
123
+
$activity->update([
124
+
'opportunity_id' => $opportunity->getId(),
125
+
'stage_id' => $opportunity->getStageId(),
123
123...
|
Firefox
|
JY-20903 Update activity stage when opportunity is JY-20903 Update activity stage when opportunity is changed by LakyLak · Pull Request #12077 · jiminny/app — Work...
|
github.com/jiminny/app/pull/12077
|
47371
|